summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-16remove border line from sidebarandreas kainz
Change-Id: I520b6a5eaec5db065dc122b3e97861548347791e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102825 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-16sw: remove dead code in lcl_FillBookmarkArray()Michael Stahl
Change-Id: Idb9fbac5bd1c74f8ccd434a2337daea58b624e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102738 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-16Cleanup: apply Clang formattingSzabolcs Toth
Some formatting on a previous commit. Change-Id: Ib5de7170ca230486b6d8c85cc999fac1f736def6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102716 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-16clean-up of commit 83c30743eaf44d8eded4a73e3ac2585b5bdbaffcRegényi Balázs
Change-Id: Ic49b9337e6accea6c9045f1da377eafcb683a1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102721 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-09-16tdf#135663 DOCX export: fix OLE distance from textDaniel Arato (NISZ)
Implements the export of the "mso-wrap-distance-*" properties of VML icons of OLE objects to the "style" property of the "object" XML tag. These properties are variously referred to as "wrap distance", "margin" or "spacing" and they control the amount of blank space to be left on each side of the object before text can appear. Follow-up of commit 8ee88230c110ae90b439a52bc2906d6c5383967f (tdf#135660 DOCX import: fix OLE icon wrap distance). Change-Id: I576b876d2dca133b0ff593ff301519c17d2a348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102323 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-16tdf#136706 writerfilter: don't create page style for footnoteJustin Luth
Each time CloseSectionGroup is called for a non-continuous break, it wants to create a new page style. Each footnote calls CloseSectionGroup twice, so two unused ConvertedX page styles were created for each footnote. A quick glance through the code makes me wonder whether footnotes can skip CloseSectionGroup altogether, (unit tests suggest that it can...) but it might be necessary for a floating table that should be in-lined, or setting relative width (although tables aren't really supported in footnotes). In any case, the safest approach is to change as little as possible, so that is what I have done. HandleMargins...() only seems to add the margin information into the page style, so it should be safe to avoid that function, even though relative width stuff checks the margins. Comments are already excluded, and the function is not even called for isInIndexContext() || isInBibliographyContext(). I thought header/footers were also considered sections, but that does not appear to be the case. I'm not aware of any other types of non-text sections, but if there are, they may need similar treatment. Change-Id: I4325604c286ca1132e5765a56627be4b7e64ba4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102723 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-16ScColumn::ScColumn never called with a null ScDocument*Caolán McNamara
Change-Id: I125d0e7571e3c34fbaab0fd024a67cbb518fdf64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16IsNameValid never passed a null ScDocument*Caolán McNamara
Change-Id: I2bef21f5c6356823b3c0470e7640896740e2ee9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16ScTable ctor never called with a null ScDocument*Caolán McNamara
Change-Id: I183fd26df45ddd4e7432833c5c77b07b64e03609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102842 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16ScEditableTester ctor never passed a null ScDocument*Caolán McNamara
Change-Id: I29338e400ba489e57571cb7711d92f611d5ce8d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102841 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16ScImportExport always dereferences it ScDocument* argCaolán McNamara
Change-Id: I0543c005fdabcf67ae2bfb0fc28dccf2c2a47a7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102840 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16ofz#25696 OOMCaolán McNamara
Change-Id: Ia69e9ce1ca0156e960dddb7e0bf98dfd2be2d7cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16The default implementation can be usedMike Kaganski
Change-Id: Iaae5e3f7eeb7bde3ef6763cd3b0d2992ef999712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102758 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-16AdjustRangesOfChartsOnDestinationPage never passed null ScDocument*sCaolán McNamara
Change-Id: Ic31a6b19dc9701bb4e8be500050ca6f689352342 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16Remove more redundant checksMike Kaganski
... follow-up for bf3d1b8e8f89bfdb409c70cfea126f36474d4772. Changes pointer to ScDocument into reference; makes some unique_ptrs inlined; simplifies construction of ScViewData to remove the need in additional initialization after internal ctor. Change-Id: I54055ce8243628c3bf9a3e40c557e0098e5801ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102833 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-16Simplify initializationMike Kaganski
Change-Id: Ib12b3644bbf732bac57713980b1fec14ee7783d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102757 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-16TransferDrawPage always dereferences its ScDocument* argumentCaolán McNamara
Change-Id: Ie2639fc10f1bf6a5c046e4e075337b117a8f6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16TransferTab always dereferences its ScDocument* argumentCaolán McNamara
Change-Id: I68b1fb4cda82a8a334e60b43216cfa74534e4a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16lcl_GetHyperlinkCell never passed a null ScDocument*Caolán McNamara
Change-Id: I0a4e3453016f4f8ac84c0d501456ee9f52c79c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16CalcScale never passed a null ScDocument*Caolán McNamara
Change-Id: Ie916a28a8c1be66db161531daad48ffd0d5d8554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16CopyStaticToDocument never passed a null ScDocument*Caolán McNamara
Change-Id: I1cd3b0f6b17e7b8e3430cb2aaa5cd1c78c8abc46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16copyChartRefDataToClipDoc never passed a null ScDocument*Caolán McNamara
Change-Id: I3a647358263b0e328dc2238bbfdc6e4e2ecf4090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102791 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16lcl_checkClassification never passed a null ScDocument* destination docCaolán McNamara
Change-Id: Ic0010d785e49c96a19e6e04e44fe6bc02cc44375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16GetChartRanges never passed a null ScDocument*Caolán McNamara
Change-Id: I021544d0cdfb68f6e30a4bb229eb0e8b3ea695d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16AddRangesIfProtectedChart never passed a null ScDocument*Caolán McNamara
Change-Id: Ia73438defc9db3bff8aecd7a537170e9a86fd1a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16FillProtectedChartRangesVector never passed a null ScDocument*Caolán McNamara
Change-Id: If090786c7e5834ea3cf990b0b4e9dbd2ec2a56a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102786 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16tdf#134784 DOCX import: fix shape paragraph marginsLászló Németh
based on bad style inheritance. Regression from commit dc0300eac3b755bc207cd1fe87217f4ebaeb9f58 (tdf#118521 DOCX import: fix paragraph margin from paragraph style), revealing the problematic m_sCurrentParaStyleName, see also commit 8920d865ee148518bf71f71ce1866b24cc17c07e for more information. Change-Id: Icc7f70452d946d56dc840d39545d850f74f97ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102774 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-16external: update pdfium to 4260Miklos Vajna
Change-Id: I1b6c7e9991b2e35921f7f849380d940c6662b174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102787 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-15Online: selection highlight in Calc should follow font size changes.Marco Cecchetti
When user changes font size of selected text, markers and highlight rectangle should be updated. impedit3.cxx: Line had no effect, removed. Lokitsearchtest.cxx: Test had bug. Other changes: LOKit code is separated. Now callback_text_selection is fired when font size is changed (Calc). On Writer it already behaves that way. Change-Id: I9b7e3224ad162bfb7d8f0853b6cb17b4feafa0cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101193 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102465 Tested-by: Jenkins
2020-09-15lcl_SeekAutoSumData never passed a null ScDocument*Caolán McNamara
Change-Id: I5c651a444f6878a0a71eaf4e1c48cdc8306742f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102785 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15CreateProtectedChartListenersAndNotify never passed a null ScDocument*Caolán McNamara
Change-Id: I76efe00924938830f26e1901c22da04376c30ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15CreateNameSortedArray never passed a null ScDocument*Caolán McNamara
Change-Id: Ib5501d3b3eef77224ffb091df0e30ecab9859c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102777 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15establish that ScViewData::GetDocument can always return ScDocument&Caolán McNamara
we can only be ctored with a ScDocShell& or ScDocument&, and ScDocShell provides a ScDocument& from its GetDocument() so we can always have a ScDocument& when a public ctor has completed some null checks can then be seen to be redundant and are removed Change-Id: Ifaf39cb06e8dbce363999c05ee0aeb3ec4f00428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102775 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15establish ScViewData always ctored from ScDocShell& or ScDocument&Caolán McNamara
Change-Id: Ie4d9520fe2ce69bbfc5fa755cce165f01947a535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102752 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15setDocument and InitData never called with a null ScDocument*Caolán McNamara
Change-Id: Ia0c6613daabcdcd61bd3efe1fe8a79ccbc7fa19c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ofz#25684 keep ParseCMAP within legal areaCaolán McNamara
Change-Id: Iee18b5a9390b79efa67414ea2d229d2816c84e18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102776 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScAreaNameIterator always dereferences its ScDocument* argumentCaolán McNamara
Change-Id: Ibdeeb634561a4bdd437e04bece77315b392b020e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15GetStringFromXMLRangeString never passed a null ScDocument*Caolán McNamara
Change-Id: I2855e212db08b6df0aa91f25b10b4605173b2095 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScRefFinder ScDocument* argument dereferenced on all pathsCaolán McNamara
Change-Id: I0e78a9b286dbd8e9a4acbd411f556b6eea0ec1ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102742 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScRangeData::MakeValidName never passed a null ScDocument*Caolán McNamara
Change-Id: I8decd37658133d4bbe44703e430cb74946483ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102741 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15tdf#135028 Added icon for the Styles InspectorShivam Kumar Singh
Change-Id: Ie6c5430bd43d40193297062cd546ef311e41dd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102707 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-09-15ScCondFormatEntry ScDocument* arg always dereferencedCaolán McNamara
Change-Id: I6a5c930b7f59b877fab479f7dc4228a0658c0e08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102739 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ConvertSingleRef never passed a null ScDocument*Caolán McNamara
Change-Id: I1ce4f369d8078e1950204b3046457582d9d67397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102736 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id56c9b50540a4de1950dfc4b49ea783d164a6604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101811 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-15ScRangeUtil::IsAbsPos ScDocument* arg dereferenced on all branchesCaolán McNamara
Change-Id: Ie42e6eb280886c237b7042948298eef0bd38eebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ConvertDoubleRef never passed a null ScDocument*Caolán McNamara
Change-Id: I37702a7070fdafc3c9db962a9746ac9e97adf7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15ScRangeUtil::IsAbsArea ScDocument* arg dereferenced on all branchesCaolán McNamara
Change-Id: Ie83a42db769b45f6d64d0c2b7fda58216efc36c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102718 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15lcl_Parse ScDocument* arg dereferenced on all branchesCaolán McNamara
Change-Id: I1cf901ab555c0f3bca7ef2d505a08dd53f83cd18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102714 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f44071b2e41f0956301b435fc009b4349c13cba0 - Add video in remaining entry pages. Change-Id: I2e125dc4e9aff28c6078257a7cf1f2b5a4571ff5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/102735 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-15Fix typoAndrea Gelmini
Change-Id: I0ee96ee32e419138811f19226e87d21107877d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102717 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-25 12:14:11 +0000