Age | Commit message (Collapse) | Author |
|
Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I492a951f1d686e1507232e6688c2dc75e8a41cc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145463
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This patch makes the following changes:
1) Silence the string "[placeholder for message]" for translation, since it is never actually used in the UI.
2) Add a generic tooltip for the command.
Change-Id: If46d7476638c72d35af2a4c8f242542aae2eafca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145294
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
nothing seems to be using it
Change-Id: Ib986d2906ac10df3743a30d912bb8ec356838e20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145462
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This is similar to commit c68d06dfa1498f862923eaddf3e5d247650a53d5 (sw:
add a new .uno:DeleteTextFormFields UNO command, 2023-01-10), but that
was for fieldmarks and this is for bookmarks.
The primary use-case is to specify a prefix for the name, so e.g. all
Zotero-related bookmarks can be removed, but it can be also used to
remove all bookmarks when no prefix is specified.
Change-Id: Ifc1f666f66d9fc3f6cd055f9263f0e4f949c191d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145458
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I173920a96524f991f2965af99e8d95f11d1b3c35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145455
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I40cb4dc4ce1fd3caa2464f92803124c3d2107afb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145433
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I051b5edd5936bcb94521f88ec7a7a762c66c9283
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145419
Tested-by: Jenkins
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
This is similar to commit ea208f6004770eb4b81d28e6930cd0c7bd5d8f12 (sw:
add a new .uno:UpdateBookmark UNO command, 2023-01-11, but that was for
the bookmark under cursor, and this is for fields (refmarks as a start).
Change-Id: I3e547b668361898b7ed734ea325fdf1d74e5dbb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145427
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
It had been using cppu::OComponentHelper (which derives from XAggregation) ever
since b525a3115f54576017a576ff842dede5e2e3545d "initial import", bug e.g.
ORegistryFactoryHelper deriving from it implements queryInterface in a way that
is incompatible with XAggregation (it should only have forwarded to
OFactoryComponentHelper::queryInterface, and rather implemented its logic in an
ORegistryFactoryHelper::queryAggregation override).
Also, without this commit but instead with a local
> diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
> index c8efcab0e604..9011264b3f3a 100644
> --- a/cppuhelper/source/factory.cxx
> +++ b/cppuhelper/source/factory.cxx
> @@ -241,6 +241,7 @@ class OFactoryComponentHelper
> , public OComponentHelper
> , public OSingleFactoryHelper
> {
> + void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
> public:
> OFactoryComponentHelper(
> const Reference<XMultiServiceFactory > & rServiceManager,
`make check` still succeeded for me on Linux, without hitting that injected
assert that should have fired if that XAggregation mechanism had been used after
all.
So switch from OComponentHelper to WeakComponentImplHelper here (which is the
simplest implementation helper to use, even if it still needs the non-standard
OFactoryComponentHelper::getTypes overriding the non-fitting
WeakComponentImplHelper default implementation).
Change-Id: I9fc2f4f2ef36bd016f9a943a8efd5e4ac5f3baaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145428
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie2435701078b0e111c1b04b77c857fd1923f2d59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145430
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This was enabled by default in commit
5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22 (tdf#152463 Turn on AutoSave
and Backup by default, 2022-12-12), and it makes sense on the desktop,
but this breaks LOK clients, e.g. online.git unit-wopi-save-on-exit.
Keep the desktop case unchanged, but disable it again for the LOK case
to make the failing test pass again.
Change-Id: I3a7eed8fdd6d394e9c7e75a477cbc11a6f40f7c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145426
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
To avoid styles appearing on root if their parent is hidden
(eg. Heading hidden, Heading 1 moves under root), the Stylist
shows all styles but with disabled color for the hidden styles
Change-Id: Iec73a3010ab05d01e9b7209d81f1f03c1355ef49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145324
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I7faf7a3ad54c80bd3c53525c92c26c0f980110f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145423
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The internal libpng 1.6 is now dropped, but that doesn't really affect
us.
Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Because otherwise it's quite confusing that we have a For() and an At()
variant as well, and it would be less clear what happens in For() when
there are multiple matches.
Also improve getInnerBookmarkFor() a tiny little, so we process the
first hit only once.
Suggested at
<https://gerrit.libreoffice.org/c/core/+/145348/1#message-286262286f234823b390e8f962e3ba11f5fa71b2>.
Change-Id: If068f93e6934c9fc042760c03aac866fe5b50bd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145412
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
As suggested at
<https://gerrit.libreoffice.org/c/core/+/145347/1#message-d2e88d8a1923f0fa5d2869b8d92e1d25d15ac645>,
in case the provided prefix is empty, then don't try to look up
ODF_CODE_PARAM and don't compare it with the provided prefix.
This allows deleting all fieldmarks in the document, which is probably
intended with an empty prefix.
Change-Id: Ic3015925165a9abc13a30889c36c667b10996c4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145409
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This is similar to commit 4bcb66ec7b417fbe113267f2615e78fe47eb55ca (sw
lok: expose name of bookmark under cursor, 2023-01-11), but that was for
the bookmark under the cursor and this is for refmarks.
Change-Id: I0acf0181d0acfdc087e1ed737b3c18ab3736031a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145405
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I1f8c864a939dff1252ba15f517f63b62d1a1e1fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145393
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
If the style id is unavailable from MSWordStyles::GetStyleId at this point,
it is a bug (meaning that we failed to output the style to styles.xml).
Local style generation here would skip the "make it unique" step anyway,
so the id would be unreliable / useless.
Change-Id: I32c3c6a2581a7aaa6c5b1bb3d48f09b90fb65f73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145401
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Adds a unified UNO property for theme colors *ColorTheme
(CharColorTheme and FillColorTheme) which uses XThemeColor, that
replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod.
The properties are still present for backwards compatibility and
to keep ODF support working in tests as that needs a bigger change.
Reactor the code and tests to accomodate for this change.
Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
it seems Jenkins fails sometimes with this test
https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/131248/
this commit might help
TODO: convert the remaining test
Change-Id: Ib3fb48e2e457a9168fa16c8f9f2ac9f98beabcf3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145422
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Added a new component docmodel, that has the document model types,
which only depend on other basic components. This is needed so the
types can be used in every relevant component - xmloff, oox, svx,
editeng,...
Introduces model::ThemeColor, which is a class used to store the
theme color data, including transformations (svx::Transformation).
For UNO use XThemeColor is added, and the implementation UnoThemeColor
which wraps svx::ThemeColor, so it can be tranported around.
Reactor all the code and tests to accomodate for this change.
Change-Id: I7ce6752cdfaf5e4d3b8e4d90314afa469dd65cfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144847
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
...as it doesn't make sense that e.g. OFactoryComponentHelper::createInstance
checked for bOneInstance, called OSingleFactoryHelper::createInstance, which
called [OFactoryComponentHelper::]createInstanceWithContext, which checked for
bOneInstance again
Change-Id: I53f54079a2ac1af18a6e95f0cb9d7b75c1e46ceb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
4bfc00aca2441082842f91dfba15886258674227 "#67468# factories support
XUnloadingPreference now" had added the check for XUnloadingPreference there,
but that's already covered by OFactoryComponentHelper::queryAggregation
delegating to OSingleFactoryHelper::queryInterface. (And as
OFactoryComponentHelper is inheriting XAggregation via OComponentHelper, the
only thing that OFactoryComponentHelper::queryInterface shall do is delegate to
OComponentHelper::queryInterface.)
Change-Id: Iebe507e88791d1e2390d042a8a9c152512ce212a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145420
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
from commit 3756e3145c39ace4454d2569709c2c0d64ad389a
"CppunitTest_sc_uicalc: combine external reference tests"
Change-Id: I0c34ae8bd1668aa6ecc02d420aa767f7d631bef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145404
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
attention in the document view
Fixes crash that happens in SalInstanceTreeView iter_compare when the
mouse enters the content tree at a point that has no tree entry and
is then moved over an entry.
Moves code to bring entry content to attention in the document view
from the mouse move handler to it's own function.
Renames the overlay timer handler function and moves it to the area
of the code having related functions.
Checks added for visible content and if the type has any content to
bring to attention.
Change-Id: I381eed6ffcf7ddb095c4c09650578a7f7fd874b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145168
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I65fa68bbd8ff40c0e324851376dd8a8a1614ac99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145396
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie8eda3465381eeed62d3271040c1697ef8f6559a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145395
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since:
commit 21734247d58a6e915b058d8fa55ece949d049613
Date: Tue Jan 10 12:56:58 2023 +0200
drop internal support for 1-bit images
the input data is still 1 bit here, even if the output will be 8 bit
Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Makes the highlight state of the tabbar tab behave as expected when
the sidebar is in the collapsed or expanded state. When collapsed, the
tabbar should never have a highlighted tab. When expanded, the tab in
the tabbar corrosponding to the open deck should be highlighted.
Change-Id: I0e6c54aff95b1f1e417f147070742e900fd51513
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145251
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
The Flathub build for
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/d5ac1d2bd680970ba992c8c6836683262f067592>
"Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at
<https://buildbot.flathub.org/#/builders/6/builds/16778> consistently failed for
both aarch64 and x86_64 builds with
> text.cxx:260:Assertion
> Test name: VclTextTest::testSimpleText
> double equality assertion failed
> - Expected: 28
> - Actual : -1
> - Delta : 2
during CppunitTest_vcl_text. The reason (as seen with a temporary build setting
mbExportBitmap = true and looking at the resulting
workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the
stem of the "L" doesn't contain any COL_BLACK pixels, so
getCharacterLeftSideHeight returns early with -1. The stem is drawn as three
vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 23/0/0),
and a blue (RGB 31/155/199) one. In comparison, when running the same test on
Fedora 37, the three vertical lines use gray-scale instead of colors,
RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115.
An earlier test build of
<https://github.com/flathub/org.libreoffice.LibreOffice/pull/206> "Update to
LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at
<https://buildbot.flathub.org/#/builders/6/builds/14712> succeeded, so I assume
that it must be some change in the meantime to the underlying
org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing here.
Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The bugdoc has a table with 2 columns and 2 rows, but both the A1 and
the A2 cell has rowspan=2, so there are only covered cells in the second
row. It seems there is no valid HTML markup to express this Writer doc
model.
What HTML seems to suggest instead is to simply decrease the amount of
rowspan attribute values and then the empty <tr> elements can be simply
skipped.
This fixes the
Row 2 of a row group established by a tbody element has no cells beginning on it.
from the w3c HTML validator.
Note that you can't create such problematic tables on the UI: the UI
will delete the row only containing covered cells for you when the last
cell gets merged. Such documents can be created by importers, though.
Change-Id: Ice4fa3636e8b780d374f3d319b198aaaada9f5e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145402
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
The check for platform in raptor's sort_r.h no longer worked with
Emscripten 3.1.30. Looking for __EMSCRIPTEN__ explicitly helps.
Change-Id: Ieccf723d809b4e90d44a8a510f71e12bd1d2e529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145408
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
The __EMSCRIPTEN_major__, minor, and tiny macros are no longer
predefined but only defined in <emscripten/version.h>. So grep that
instead of running emcc -dM -E.
Change-Id: I2383a906f9c746784449cd4606f653ab722b54de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145407
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
As requested at
<https://gerrit.libreoffice.org/c/core/+/145361/2#message-e00b755a1a0cdc5cec9b8e2213226e56ec87c038>.
Change-Id: I8868969a2061f0447b101d978acc5027d1bdd545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145400
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
* Update translations from branch 'master'
to 31b3190fb111c82e95e8322e860c4371407c4bd9
- update translations for 7.5.0 rc2/master
and force-fix errors using pocheck
Change-Id: I47591b005b12917245c4be7214d6bd986780044d
|
|
Change-Id: I6d1cdd3f420e146ecad38bd3b1181eb654481440
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145394
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to b23e481175ae62e827075f333d303fa393fd65e0
- tdf#152589 Add warning on experimental mode
Change-Id: Ia3e85594b88ec9e38c1e3efb84cf02dbd69fba42
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145406
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Use case now complies with ODF 6.9.14 (MATCH).
Added use case to unit test.
Change-Id: I749a979135fbc01a3bb1583092fb6d6a100e2d2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144883
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
so we can avoid dynamic_cast and XUnoTunnel in various places
Change-Id: I1f524270a8030106a2058691c3d89b90d46ed26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145391
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
the code already relies on the underlying type of mxModel being Model
rather than XModel
Change-Id: I5b78482d37024a5bc274b0208fa56e4328f3f5f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145390
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5a16b5ac64189ade77f6378d8cc88eee41ee188b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145357
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3d82d1dd3b5f66d76622103ec7b9b76acd857f36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145356
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9b03d2ec973e2dab28358d7e8041b9d26705e700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145352
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
I can't find anything where that doesn't work, so can drop
IconPixmapHint/IconMaskHint.
Change-Id: Ifa9f6a548a92006450335037836fbb7dd3039ecd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145339
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibde845b19bc5993251fb2118b3daeafb63871aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145338
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8e86aa5a43f7c0bc234331def1b4440dbe2cefa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145389
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I818c63aadd23256c183b89a69b77ac8cdcc081f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144968
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|