summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-19Adapt to clang::PPCallbacks::InclusionDirective change in Clang 16 trunkStephan Bergmann
<https://github.com/llvm/llvm-project/commit/8f0df9f3bbc6d7f3d5cbfd955c5ee4404c53a75d> "[clang] Convert OptionalFileEntryRefDegradesToFileEntryPtr to std::optional" Change-Id: I60bf4a770d6037edcfe0129591fd46941c8903db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-19Typo in variable name: ContentCnotrol -> ContentControlJustin Luth
Plus some bonus cleanup. I want these files to be clean of junk. How I missed these SAL_CALLs in my previous clean attempts, I don't even dare to speculate. Change-Id: I6056b61bbbdb088fe83752496df00d0fa319e637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144137 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-19sw layout xml dump: show numbering portion weightMiklos Vajna
Similar to font size & font color. Change-Id: I0987c50235dc317dd4b778a5b9946a0415558eeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144502 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-19[API CHANGE] tdf#85592: deprecate .uno:BackColor, use .uno:CharBackColorJustin Luth
EditEngine stuff uses CharBackColor, while SW used BackColor. Deprecate the SW-only SID. What does this do? It allows the toolbar "Character Highlighting Color" to work with both body text (previously BackColor) and comment text(CharBackColor). Otherwise, the toolbar item was disabled when moving into a comment. (Shapes/Textboxes got their own formatting toolbar, so those are unaffected.) AFAIK, after this commit, SID_ATTR_CHAR_COLOR_BACKGROUND should still work fine for API calls, or for customized toolbars. That's why I didn't try to remove it completely - just deprecate. Do I know what I am doing here? No, although I'm fairly confident nontheless, and I've had some good help from reviewers. Change-Id: I0afcbdb1b91c872f6d47f3c82c573f3b9fea6dfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137334 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-19sc: check ScDocShell::GetViewData()Xisco Fauli
ScDocShell: :GetViewData() can return nullptr Change-Id: I39bb2dce1ab233f39b0ec687ed71089b35537f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144467 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-19Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to e2388e894212c7be710371c589263c45e994a304 - set id attribute from paragraphs as type ID for uniqueness constraint so that the xmllint job on jenkins can detect those Change-Id: I45058e114fbce907cb4fc26ec5a8d06974eb8145 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144465 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-19loplugin:implinheritancehelper in ucbNoel Grandin
use more ImplInheritanceHelper to reduce boilerplate Change-Id: I3ecc79ac5a1ae7a005845a7f1460e3b5037e6d53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-19loplugin:implinheritancehelper in toolkitNoel Grandin
use more ImplInheritanceHelper to reduce boilerplate Change-Id: I209e013f84a83339d0f4a6dfd90b462a47b6beeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-19Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to b91a0a30115e414982bd4b3f710e0218661b4e18 - Fix typo Change-Id: Iede879decee335d13e50df7244326dbc44728145 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144503 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-19Fix typoAndrea Gelmini
Change-Id: Ibd4381e8e1f38588706a9cb093a63a9673776d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144504 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-19tdf#145538 Use range based for loopsLeonid Ryzhov
Change-Id: I6d04185f14c3ec72b40426bd881cac80528cc736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143244 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-12-19crashtesting: asserts with outsized object positionsCaolán McNamara
seen during import of: forums/forum-mso-en4-187408.xls forums/forum-mso-en4-187900.xls forums/forum-mso-en4-187890.xls Change-Id: Id15e9c1ea98d761225d41850b9b2aa58d9c9e407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-19Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 1445fa8fda93a2f0ffab873c926390adb4937397 - Fix duplicate IDs in non-localized content Change-Id: I759b05a2ba10671700c9222f54e61edf39f5baff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144538 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-12-19Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 7d5ae8c4582675a8e102e4d330658a588ef015cf - update translations for 7.5.0 rc1/master and force-fix errors using pocheck Change-Id: I3c9458097e8ea70e7931e1646095b0da3f5a04eb
2022-12-19tdf#151548 vba ContentControls: don't always return a filtered valueJustin Luth
Searching for content controls can be filtered by tag, title, or Id. The function was erroneously returning the last control in the list if the specified control did not exist. Change-Id: I0cfbccadc134b64456d703f1e19db6e142f162fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144346 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-19ofz#54240 Integer-overflowCaolán McNamara
Change-Id: I50c8f9579a9fb07431ad0d6eebc5f0df8e40ebd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-19ofz: bad-casts at shutdownCaolán McNamara
Change-Id: Ia8cdf5d446647e0f3d60c14e1aae315db63769c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144462 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-19tdf#151548 vba ContentControls: fix fundamental errorJustin Luth
The problem was that the SwTextControl could be deleted by the user or in VBA and my references (or pointers for that matter) to m_rCC would be invalid. Instead, use the shared_ptr, which will always be valid, from the SwContentControl. Thankfully, there is backwards access to the Format and Text controls. This is nicer anyways. It has reduced code lines, and simpler access to the most used aspect. Change-Id: Ie382b33ecda5c3d0024f0eabcb8ff158db942f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144345 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-19-Werror=maybe-uninitializedStephan Bergmann
Change-Id: Ib467fa5eec2560943e10adc2c440fdbf8f853a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144446 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-19build baseline is macOS 12 and XCode 14 (macOS 13 for m1)Christian Lohmaier
(and would also be macOS 13 for the intel builds if the old macMini would be on the officially supported list) Change-Id: I4205f30274bdd43d80d02d6cda863ec83bdda63e
2022-12-19loplugin:unocast (oox::ForumlaImExportBase)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I11bc363447c44319bc47f7eebb7084f64ea85511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144400 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-19tdf#65535 sw: fix lost comment at fixing spelling with context menuLászló Németh
Also fix the bad Undo label, where the invisible IAA character became visible. Choosing one of the spelling suggestions of the context menu of a bad word fixed the spelling of the original word, but also deleted its inword comment. Keep the comment at the end of the fixed word. Fix also the bad Undo label, which contained the original word with the Interlinear Annotation Anchor (IAA) character. Now it shows only the word, but not the Unicode replacement glyph of IAA. Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8 "0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002". Change-Id: I5bfa214a060c446e9897e806832bedfe54241e1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144397 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#152295 sw sd UI: don't reset tiled image size by Area tabTibor Nagy
The background tiling images become larger when opening and closing Area tab: reopening the image properties in the Area tab shows that the Width and Height got reset to the original values of the image. Regression from commit 686349476e03f951f4a9ff9755b9f71951b64ea5 "[GSoC] Move all fill style tabs inside area tab". Change-Id: Ibc4dfd73dedd81b1b7fe17574198dd4999aab967 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143819 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#152070 PPTX import: fix offset of tile background imageTibor Nagy
by using bitmap image sizes instead of the original ones. Change-Id: Id6f2777bf6803bca7252878203a12ab796ac33dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143766 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#152436 PPTX export regression: fix lost shape at missing objectTünde Tóth
If the object is missing, it's still possible to keep its shape by exporting its preview graphic, as before the regression. Regression from commit adc042f95d3dbd65b778260025d59283146916e5 "tdf#124333 PPTX import: fix Z-order of embedded OLE objects". Change-Id: Ib2fd00f53a80572cfc9acaefea55015780c57da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144040 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19sw: ODT import/export of DOCX's paragraph marker formattingMiklos Vajna
The bugdoc had a numbering, where the paragraph marker was explicitly formatted to a custom sans font, and this font is also used for the numbering portion's font. This was imported from DOCX correctly, but once you save to ODT and reload, the font used in the numbering portion changed from sans to serif, which is incorrect. The reason for this seems to be that earlier 5ba30f588d6e41a13d68b1461345fca7a7ca61ac (tdf#64222 sw: better DOCX import/export of paragraph marker formatting, 2019-09-06) introduced support for storing this paragraph marker formatting in RES_PARATR_LIST_AUTOFMT, but this was lost on ODT export / import. Fix the problem by 1) adding the autostyle to the autostyle pool, so the font gets written when writing automatic char styles 2) extending SwXTextPortion to have a mode where it exposes the RES_PARATR_LIST_AUTOFMT of the current text node and 3) improving lcl_CreatePortions() to expose a trailing empty text portion that works with these properties. This also required adjusting CppunitTest_sw_ooxmlexport2's testFdo64238_b, which explicitly asserted that the format of the paragraph marker is not exposed in the UNO API text portion enumeration. An additional improvement would be to go with a more explicit markup in the ODT output for RES_PARATR_LIST_AUTOFMT, but we would need to decide what name to use there, since currently we call this paragraph marker formatting RES_PARATR_LIST_AUTOFMT / ListAutoFormat, and somewhat confusingly this is primarily about paragraph marker formatting, not lists / numberings (that is just a consequence). Change-Id: I19c7eed19c6fc85c251ef87a5181c0719a0a382c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144447 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-19tdf#152434 PPTX import: fix lost shapes with connectorsTibor Nagy
Regression from commit eec48130271188cab63665acedbabf1ff5e850a2 "tdf#148926 tdf#151678 PPTX import: position of standard connector - part1". Change-Id: Ib9381403f7c0edf9a06e3d98965067a51b4797d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144000 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19sw: prefix members of ContentControlListEntriesEnumWrapper, ...Miklos Vajna
... ContentControlsEnumWrapper, ListEntriesEnumWrapper and SwHTMLTextFootnote See tdf#94879 for motivation. Change-Id: I1efbf1d7e3def37868ef0e36aeb4ec184d31eb46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144445 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-19Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 318ec1f0e6248eac2536256bf26e1a183fc59541 - janitor: update comment for the bookmarks.part rule the remarks about the indicator files are obsolete after the rule has been rewritten to work in batch and not on single files Change-Id: I8a2509aed7a38b9cff0dacec3d4161bc020fde31 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144468 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-19tdf#65535 sw: fix lost comments using spelling dialogLászló Németh
Choosing one of the spelling suggestions in the spelling dialog, or rewriting the bad word removed also its inword comment. Keep the comment at the end of the fixed word. Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8 "0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002". Change-Id: Iaf083453fad4e0ca99e254f53b20ead86b3ba15e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144458 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#151152 sc filter: fix string entry checkingTünde Tóth
When a column was filtered for values that included 0, the all string entries were always checked in the Autofilter dropdown (because their conversion to number, i.e. value 0 was used to check their existence in the filtered values instead of their string value). Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d "tdf#142910 sc filter: fix "greater than" or "smaller than" etc". Change-Id: Ib659aba9d6f3d6bc3557547b1a27963f51e3eca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143777 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19tdf#152082 ODS: fix import of Empty filter operatorTünde Tóth
Bad import of the Empty filter operator resulted shifted filter settings, e.g. selected "A" and "B" instead of "empty" and "A" from the range "empty", "A" and "B". Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d "tdf#142910 sc filter: fix "greater than" or "smaller than" etc". Change-Id: I33082d77fb9e707aa474fb22753a001960341d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143776 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19keep environment clear of SYSTEM_FOO varsChristian Lohmaier
those are only meant to be used by the build system (primarily RepositoryExternal.mk) - of course no rule without exception: concat-deps reads SYSTEM_BOOST from env, so set it in the corresponding recipe lines Change-Id: I83c88fc6ad4467b429771c43650fe7fc0ccde407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144343 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-19loplugin:implinheritancehelper in stocNoel Grandin
use more ImplInheritanceHelper to reduce boilerplate Change-Id: I2b4937ebee2e8cc16759df0eacdeb160343a7001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-19tdf#152335 PPTX export: fix 3D shape properties of the shape in themeTibor Nagy
The shapes got extra 3D shape properties by the default template, which caused visible difference in MSO. Follow-up to commit I02f1edea84b50dbb9b0e0a59b6062a29894afde4 (tdf#152186 PPTX export: fix shadow of the shape in theme) Follow-up to commit 25e9766e9b87342b6f1b29dc146d5f33e12157a7 (tdf#92222 PPTX export: fix line width of the shape in theme) Change-Id: I84f931e45e7656c456fe910cbb5e09aabeb8924f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143516 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2022-12-19Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to e739da903b92597316aeac26ec190a8d7c7bec28 - convertfilters.py: Don't add name attribute to links Change-Id: I556ee26594fada9722ef898ef9e36df4644e4f37 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144461 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-12-19Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to c8611c6e320bf5db95a6d1fa54d3ff6e13f9eaa7 - Remove name attribute from links Change-Id: I999712c68026ddd40578c1f5e92a994c24a11eae Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144460 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-12-19Fix title for nlpsolver/README.mdHossein
The nlpsolver module is "Solver for Nonlinear Programming", which was mistakenly called "New Linear Programming", and this is now fixed. The change will appear within a week in: https://docs.libreoffice.org/nlpsolver.html Change-Id: I05b14d1e4056d8d0797728905886edef867f29e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144408 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-19tdf#152206 DOCX import: fix mixed first footnoteLászló Németh
Also the first footnote can be at arbitrary place in footnote.xml. Follow-up to commit 09ae3c01940bbc25ffde51963683b04e3cb4bb6a "tdf#152203 DOCX import: fix mixed footnotes/endnotes". Change-Id: Iab356f7373483d812f0e802a994357fdad831d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144380 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-19remove dependency from drawinglayer to frameworkNoel Grandin
to try and untangle the dependency mess a little. This means (*) tunneling a piece of information from VCLXWindow via the XWindowPeer::getProperty method, so we do not need to directly call VCLXWindow. (*) moving some formpdf code from framework "down" to vcl, where the drawinglayer code can use it Change-Id: I2c1ff3e34941b3147e66cf0a2d0fdb13293e3aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-19tdf#151755 fix export of borders of contentless cellsAttila Szűcs
Change-Id: I650aeebb4d021911c1f14d4867c5beee84020155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143880 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-18crashtesting: failure on load of forum-en-7529.odtCaolán McNamara
==324198== Invalid read of size 8 ==324198== at 0x2D840D75: std::__uniq_ptr_impl<SwField, std::default_delete<SwField> >::_M_ptr() const (unique_ptr.h:191) ==324198== by 0x2D840D54: std::unique_ptr<SwField, std::default_delete<SwField> >::get() const (unique_ptr.h:462) ==324198== by 0x2D932B9B: SwFormatField::GetField() (fmtfld.hxx:122) ==324198== by 0x2E740E7B: SwXTextField::Impl::GetField() const (unofield.cxx:2634) ==324198== by 0x2E7487EB: SwXTextField::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (unofield.cxx:2150) ==324198== by 0x1100C123: XMLPropertyBackpatcher<short>::ResolveId(rtl::OUString const&, short) (XMLPropertyBackpatcher.cxx:73) ==324198== by 0x1100BB0F: XMLTextImportHelper::InsertFootnoteID(rtl::OUString const&, short) (XMLPropertyBackpatcher.cxx:180) ==324198== by 0x10FF7E71: XMLFootnoteImportContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (XMLFootnoteImportContext.cxx:99) ==324198== by 0x10C40361: SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlimp.cxx:812) ==324198== by 0x28FBFE71: (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) (fastparser.cxx:470) ==324198== by 0x28FBED4E: sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) (fastparser.cxx:1304) ==324198== by 0x28FBCCAF: (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) (fastparser.cxx:333) ==324198== Address 0x259e2b68 is 328 bytes inside a block of size 344 free'd ==324198== at 0x4848669: operator delete(void*) (vg_replace_malloc.c:923) ==324198== by 0x2E4EC2B1: SwFormatField::~SwFormatField() (atrfld.cxx:132) ==324198== by 0x8635DA2: SfxItemPool::Remove(SfxPoolItem const&) (itempool.cxx:802) ==324198== by 0x2E5BB014: SwTextAttr::Destroy(SwTextAttr*, SfxItemPool&) (txatbase.cxx:63) ==324198== by 0x2E594EE2: SwTextNode::DestroyAttr(SwTextAttr*) (thints.cxx:1302) ==324198== by 0x2E55C4EC: SwTextNode::~SwTextNode() (ndtxt.cxx:238) ==324198== by 0x2E55CB38: SwTextNode::~SwTextNode() (ndtxt.cxx:227) ==324198== by 0x2DEE048F: SwNodes::RemoveNode(o3tl::strong_int<int, Tag_SwNodeOffset>, o3tl::strong_int<int, Tag_SwNodeOffset>, bool) (nodes.cxx:2325) ==324198== by 0x2DEE50C2: SwNodes::DelNodes(SwNodeIndex const&, o3tl::strong_int<int, Tag_SwNodeOffset>) (nodes.cxx:1384) ==324198== by 0x2DC87B02: sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (DocumentContentOperationsManager.cxx:2118) ==324198== by 0x2DD2BB66: sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat*) (DocumentLayoutManager.cxx:285) ==324198== by 0x2DB0900E: DelFlyInRange(SwNodeIndex const&, SwNodeIndex const&, SwIndex const*, SwIndex const*) (docedt.cxx:254) maybe this is a problem since the various changes associated with: commit 2c9298e4f667a5dd7606d79890fcedfff0f66e26 Date: Fri Apr 5 23:14:47 2019 +0200 SwXTextField::Impl FieldTypeClient: SwClient no more commit e18359445fabad9ba1a704600e9ee327112cc6ae Date: Sun Apr 14 13:33:35 2019 +0200 [API CHANGE] SwXTextField: no more SwModify/SwClient Change-Id: I52aa0a70604ea5ce96d2b55a9a2ad363a889f58e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-18crashtesting: related to failure on load of forum-en-7529.odtCaolán McNamara
save SwDoc* before calling DeleteAndJoin, so SetFormatField doesn't use m_pImpl->m_pDoc potentially cleared by it Change-Id: Ia130f224fcccd35e1dfafbbaf5c461c9bd032f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-18Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 534e501e3ad4fef3ebee8788b45c063e96d50346 - janitorial cleanup/minor optimizations mostly making xstlproc and python order-only dependencies, simplifying some of the print statements/remove sed or grep calls that can be handled by make's own text functions Change-Id: If4f8ef145d7721384e914ae79494c500bbf244dc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144410 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-18Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 6a83788dd6205cd600327ead7388bc5ad26fc7f7 - process files for bookmarks.part in bulk instead of running xsltproc for each file, pass multiple files at once, greatly reducing the overhead of the processing, especially on Windows/cygwin. since it not only removes the need for the xsltproc invocations, but also for the surrounding workarounds with the rm, touch, rm of the indicator file. Change-Id: I4588bfc869c668a41da29b5d4080a600ed02223b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144409 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-18cid#1517772 more Logically dead codeCaolán McNamara
Change-Id: Iecbf15486b319bf2d04c451ceea94844a567fe02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-18ofz#54402 check boundsCaolán McNamara
git show -w Change-Id: I8e7c719a9f1c38f151eb7e59ec222849eb2e28f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144402 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-18add some SAL_WARN_UNUSED_RESULTCaolán McNamara
commit 817dfb74d9ec9f46ba32be6d5066d534f81072a5 Date: Tue Jul 17 09:45:37 2001 +0000 #89783#: NULL-Ptr possible probably intended pViewFrame = SfxViewFrame::GetFirst() but at this distance in time, just accept the current state of things Change-Id: I8779fef1041843e9f2e6c879cfb475d8ac8251fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144401 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-18loplugin:unocast (cairocanvas::SurfaceProvider)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) There are implementation classes whose getSomething already delegates to RepaintTarget, so they can't also delegate to SurfaceProvider. So introduce the concept of comphelper::getSomethingImpl additionally delegating to a sequence of mixin classes before delegating to the base. Change-Id: I9230f3dc06abbdd1ad92514a11473dae2624f7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144404 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-18loplugin:unocast (cairocanvas::CanvasBitmap)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I6044567e4027fe1fdc361917d5233157d4ce98d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144399 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-29 23:57:47 +0000