summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-11-27tdf#132145: Synchronize ScInputCfg with configurationMike Kaganski
Change-Id: I45cc9b6c8cbd9205e185bebff97644f53f5cf0af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125896 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-27use more OInterfaceContainerHelper3 in UndoManagerHelper_ImplNoel Grandin
Change-Id: I9076f35366de690cca84361695d45ad3ffc31089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125917 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-27use more OInterfaceContainerHelper3 in ImplEventAttacherManagerNoel Grandin
Change-Id: I5c73d61a5b7a0a7fcc218e0ee839be5b9fdbb987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-27use more OInterfaceContainerHelper3 in OPropertyBagNoel Grandin
Change-Id: I915614c8e70a0f179655530b2c8822fa06c21386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125915 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-27use more OInterfaceContainerHelper3 in chart2Noel Grandin
Change-Id: Icff667a11f1798e29c732c13b5739a4f7b581999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-27use more OInterfaceContainerHelper3 in NameContainerNoel Grandin
Change-Id: I75cb302156ea93fe0b545b22ca85a0c537cce760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125919 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26Work around use-after-poisonStephan Bergmann
> ==21930==ERROR: AddressSanitizer: use-after-poison on address 0x61d001aa0eb0 at pc 0x0000004398b4 bp 0x2ada81952e60 sp 0x2ada81952610 > WRITE of size 192 at 0x61d001aa0eb0 thread T42 (utl::Moderator) > #0 0x4398b3 in __interceptor_memset.part.43 /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:773 > #1 0x2ada82e404ae (/lib64/libnsspem.so+0x154ae) > #2 0x2ada82e405bf (/lib64/libnsspem.so+0x155bf) > #3 0x2ada82e331b7 (/lib64/libnsspem.so+0x81b7) > #4 0x2ada82e386c1 (/lib64/libnsspem.so+0xd6c1) > #5 0x2ad58dccdafc in secmod_ModuleInit /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11 > #6 0x2ad58dcd3027 in secmod_LoadPKCS11Module /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10 > #7 0x2ad58dd37e20 in SECMOD_LoadModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10 > #8 0x2ad58dd389b9 in SECMOD_LoadUserModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28 > #9 0x2ad54cea71b1 in nss_load_module /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12 > #10 0x2ad54ce969ae in nss_setup_connect /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12 > #11 0x2ad54ce95a5a in nss_connect_common /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14 > #12 0x2ad54ce9320a in nss_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10 > #13 0x2ad54cebfa5a in Curl_ssl_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12 > #14 0x2ad54cc6929e in https_connecting /workdir/UnpackedTarball/curl/lib/http.c:1591:12 > #15 0x2ad54cc68c74 in Curl_http_connect /workdir/UnpackedTarball/curl/lib/http.c:1517:14 > #16 0x2ad54cd42aac in protocol_connect /workdir/UnpackedTarball/curl/lib/multi.c:1696:16 > #17 0x2ad54cd2a3dc in multi_runsingle /workdir/UnpackedTarball/curl/lib/multi.c:1997:16 > #18 0x2ad54cd25704 in curl_multi_perform /workdir/UnpackedTarball/curl/lib/multi.c:2568:14 > #19 0x2ada803a8d54 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&, http_dav_ucp::CurlUri const&, curl_slist*, com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const*, std::pair<std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&> const*, (anonymous namespace)::ResponseHeaders&) /ucb/source/ucp/webdav-curl/CurlSession.cxx:918:14 during UITest_sw_options (<https://ci.libreoffice.org/job/lo_ubsan/2210/>) after bdef11f5337ecc87556a92693f6b7b5e200eb29e "configure: default to --with-webdav=curl", apparently caused by a mixture of external/nss built with ASan and system /lib64/libnsspem.so not build with ASan. (And this commit may become obsolete with <https://gerrit.libreoffice.org/c/core/+/120388> "configure: default to --with-system-nss on Linux".) (The last time that use-after-poison in /lib64/libnsspem.so hit <https://ci.libreoffice.org/job/lo_ubsan/>, I could work around it with db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files".) Change-Id: Ic5ed4e60a577a65c71084e97b3fb3afd03266bb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125912 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26tdf#118063 - Writer: Deselected line spacing items remained checkedAndreas Heinisch
The state of the attributes for line spacing within comments and textboxes are now read and set correctly. Line spacing menu items were removed from Calc in Bug 136071 (ce9e965b3fc3744b99afee07f6d56860852af5e4). Change-Id: Ie20a8529d84a14d549e1985471f684b88e21819b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125880 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-11-26Regression Statistics: use cell reference, not fix row to calculate offsetEike Rathke
The INDEX() offset was calculated with a fix row number derived from the initial output position, like 35-ROW(). That fails if the range later is moved or rows inserted/deleted. Instead, use a cell reference of the cell's current column and end row, like ROW($A$34)+1-ROW(). 34+1 to not have things shifted if a row is inserted before 35. Change-Id: I11276c4acb35505576daa1a20ad49a4fcdbaba49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125914 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-26tdf#145831: fix typo in PNGAndrea Gelmini
Change-Id: I206ac72d56409b3516f49798fb7f10b3a4c3d721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26ofz#41398 drop a para scheduled for deletion if something else deletes itCaolán McNamara
Change-Id: I0b7d7f5224b78658951c7d0b71eb793057059bca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26ucb: webdav-curl: fix CurlUri::CloneWithRelativeRefPathAbsolute()Michael Stahl
Change-Id: Idf1d75817009286cd79a00c0ba154cea70e2ffda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125908 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26tdf#126356 partial Revert "sc tiled editing: Mapping has to beJustin Luth
turned off after drawing the buttons." This partially reverts LO 5.0 commit 342d84218c17da40d0a4f96bc3b07b536d64517a which comments: Also - we are actually never call with something else than MAP_PIXEL, so let's kill the resetting of the mapmode; let's see if some obscure corner case bites us here. Several bug reports have indicated artifacts on screen, all coming from the use of autofilter, and in these cases the map mode is 0 (Map100thMM), so I restored the whimsically removed logic. Change-Id: I9bb5d7418fc4083ed71139a64329b11fa1e4cc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125879 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2021-11-26Adapt distro-configs/LibreOfficeFlatpak.confStephan Bergmann
...to 214fa233338c09156c67f85818b6a2ea6b3235bd "add with-system-abseil/with-system-openjpeg for pdfium" Change-Id: I5956b2710e3c3aa02285224e9d5799ef2da91270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125885 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26--without-system-cuckoo missing in distro-configs/LibreOfficeFlatpak.confStephan Bergmann
...for 3749d9af3745c0eaff7239e379578e4e2af89e9d "tdf#130795 use concurrent hashmap in SharedStringPool" Change-Id: I1f8d224cc412ff3e8ad819b018aea6cc1829faca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26ucb: webdav-curl: don't use chunked encoding for PROPPATCHMichael Stahl
Sharepoint 16 has the same problem with this as with PROPFIND. But this still doesn't work, trying to add dead properties results in HTTP/1.1 400 BAD REQUEST now. In fact, it has additional problems: request 3 properties Foo, Bar, Baz with one PROPFIND and it complains about Foo, FooBar, FooBarBaz... Change-Id: Ia0ce0f7b9422e0751839151a4c964f0437282c64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125907 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26tdf#133996 speed up opening of ODS with autofilter + conditional formattingNoel Grandin
inline some hot methods, and use OUStringLiteral to avoid repeated construction of an OUString, saves about 3% Change-Id: I6d09ade4e08a94ed5dd49a8882e26bb5786409d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26speed up Fraction::operator*= a littleNoel Grandin
for my test spreadsheet this reduced the time spent in Fraction by 30% Change-Id: Ib14a93284dbd6c6ea2349c1754979135463ca61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26use more OUStringLiteral in svxNoel Grandin
Change-Id: Ifdcfa4e1f9a42618061642ffe05eaa2a32e1010e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26remove unused definesNoel Grandin
Change-Id: I96f224c9afae857c0b37ec91c523e41afdc9db05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125881 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26tdf#145814 fill format mode is mostly disabledCaolán McNamara
when it shouldn't Change-Id: Ic282c313a6986d7d08f54b475c5d2ce32098ada1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26tdf#49033 Honor Selection When Applying Sentence Case FormatMichael Warner
Prevents Sentence Case formatting from occuring outside of a user's selection. This commit does not prevent Title Case formatting from adjusting the first letter of a word, even if the selection does not include that letter. Change-Id: Id3f1a5b0da973d24ef73f1e640306a65e1b4c561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121966 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-11-26tdf#119190: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: I5ba98b3651470f7c86b9aca9359d563e64058552 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125874 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-26Reverts tdf#144247 tdf#101217 - 4 digits in row height/col widthHeiko Tietze
Reverts patch I29d90b413e6f6f6e8b73d30ac47d644a69d15046, ad8edac43e73555bc2055514300c5b81a1bb04ea and partially Ibdee348d84a8b96d8f698e7fc6db89eb24422f5d Change-Id: Iba5fd2d2a65d813c2d5ba85e66a7c3e07b726ca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125871 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-11-26loplugin:stringliteraldefine in svxNoel Grandin
Change-Id: I2375ebfe9791c43063ffbc8ddbe1bd365499a576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26floatingnavigation.ui is no longer usedTomoyuki Kubota
since https://gerrit.libreoffice.org/c/core/+/87005/9/sw/source/uibase/utlui/navipi.cxx#b393 and https://gerrit.libreoffice.org/c/core/+/87005/9/sw/source/uibase/ribbar/workctrl.cxx#b310 Change-Id: Id95f73d782f8d785b26ee6739014314c4d1a6fae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125831 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26loplugin:stringliteraldefine in stoc,svtoolsNoel Grandin
Change-Id: Ifd583582fa7bf7366a1f8d482eefd64b30228ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125867 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26cid#1494447 ucb: webdav-curl: Logically dead codeMichael Stahl
Change-Id: I98a99ddc287fd83ff95e9a1b3851a9888dd6ef5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26tdf#145873 Fix FILEOPEN: EMF file not displayedHossein
EMF can have WMF embedded inside it. The sample PPTX file contains an EMF file consisting of several GDIcomment records in which embed a Placeable WMF file without some records related to the size of the WMF. It reaches pStm->SetError( SVSTREAM_FILEFORMAT_ERROR ); in emfio/source/reader/wmfreader.cxx:1982 which causes to the problem in loading the file. With this fix, the EMF file will be displayed. Without the fix, the EMF file will be displayed as blank. Regression from commit 5e4e1cdb1e14354b42838e1dfcf82873b3071896 tdf#88163 Fix font size for placeable wmf files The fix can be tested with: make CPPUNIT_TEST_NAME="testTdf145873" -sr \ CppunitTest_sd_svg_export_tests Change-Id: I04babd5029ba123fdd03758eef2be69faf45fda8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125796 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-11-26cid#1494445 silence Data race conditionCaolán McNamara
Change-Id: If1037293058812d6800646a2a0399a59f356d098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26loplugin:stringliteraldefine in sfx2Noel Grandin
Change-Id: I45ccf6b1841024db7406b910a28dff054f67464d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125862 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26ucb: webdav-curl: remove useless assert in getLockTokenForURI()Michael Stahl
Change-Id: Ia27acf55bd7baf70c0b57e0922a62b1d9680c5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125848 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26ucb: webdav-curl: don't use chunked encoding for LOCKMichael Stahl
Sharepoint 16 produces exactly the same error HTML as for PROPFIND. Change-Id: Idd3862456c4efbb9eb0533298dcd93711b30faae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125847 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26ucb: webdav-curl: avoid pointless HEAD requests for DAV resourcesMichael Stahl
Content::getPropertyValues() has a funny conditional which was changed in commit a86bc34ddcff6b04bb9fdb8c960bbf2c49540da1 "Resolves: #i121922# Fix wrong condition". But the new condition also appears wrong, there is no need to do any further requests if all properties have already been retrieved, so the check for m_bDidGetOrHead could just be omitted. There is a surprising result in the Remote Files dialog when connecting to a Sharepoint 16 server: all properties have been retrieved from the directory given as Root, but because of !m_bDidGetOrHead the branch is taken anyway. The HEAD request results in a "HTTP/1.1 302 Redirect" to $ROOT/Forms/AllItems.aspx, HEAD on this URL gives a "HTTP/1.1 200 OK" and then subsequently a PROPFIND on that very same URL results in "HTTP/1.1 404 NOT FOUND". Physics claims that a single observation should be sufficient to determine whether an URL exists or not, but Sharepoint is apparently able to maintain this quantum superposition indefinitely, hence the Remote Files dialog doesn't display anything as the 404 causes an exception. Try to fix this by requiring a missing property again before initiating the HEAD request for DAV resources. Change-Id: I1239762948b6abd1f8fc097edd4a16cb6b75ca7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125826 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26ucb: webdav-curl: don't use chunked encoding for PROPFINDMichael Stahl
Sharepoint 16 responds to PROPFIND with "Transfer-Encoding: chunked" with "HTTP/1.1 200 OK" and this body: <HTML><DIV dir="ltr"><H2>Microsoft SharePoint Foundation Error.</H2>\n\n<P>\n<B>User:</B> please report details to this Web site's Webmaster.\n<P>\n\n<P>\n<B>Webmaster:</B> please see the server's application event log for more details.\n</P></DIV> Understandably, WebDAVResponseParser barfs on this: ucb/source/ucp/webdav-curl/webdavresponseparser.cxx:405: Parser destructed with existing content (!) ucb/source/ucp/webdav-curl/webdavresponseparser.cxx:942: WebDAV Parse error (!) Apparently setting Content-Length works better. Change-Id: If3eae8c2f8b9f1e1bb4ed4fc67a79a682d7d0050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125825 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-26cid#1494446 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib8e1d0e691772e822f81afafbd47ba33698b592e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125863 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26Fix typosAndrea Gelmini
Change-Id: Id23e40de23de829e42b984d74be8bb0e632112d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125855 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-11-26cid#1494444 silence Dereference null return valueCaolán McNamara
Change-Id: I7c6c60489a58378238ff63ff9c6b45f3a7aa4bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26remove unused definesNoel Grandin
Change-Id: I299486e00e027299b571fdeb3846a74830511ce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26tdf#144940 sc: fix disabled header/footer regressionAttila Bakos (NISZ)
Setting "Same content on first page" in the Page Style dialog on either the Header or Footer tab resulted disabled header/footer after reload. This was due to flawed logic when assigning SC_UNO_PAGE_HDRON/FTRON value: "leftness" was checked for but not "first pageness". Regression from commit b9993369b4011cd8f367e439f5248096827f1efc "tdf#121715 XLSX: support custom first page header/footer". Co-authored-by: Daniel Arato (NISZ) Change-Id: I8ee4c9f8145913d9dc5f4b66cdbc2352f2e405f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125367 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-26-FIIntrin.h in CC/CXX is no longer needed for my clang-cl buildStephan Bergmann
...at least with Clang 14 trunk now (but I didn't check which llvm commit would be responsible for that, and which version of LLVM that appeared in first). That also means the -D_CRT_RAND_S hack in CXX is no longer needed either. (See the mail thread starting at <https://lists.llvm.org/pipermail/cfe-dev/2015-November/046012.html> "[cfe-dev] clang-cl question".) Change-Id: If1b1b4fa17782161c3b72ac68fdef28b0e044a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125859 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26Drop support for poppler w/o cpp/poppler-version.hJan-Marek Glogowski
Seems the first poppler including poppler-cpp.pc.in and also cpp/poppler-version.h.in was 0.14.0. So this also increases the minimal system poppler dependency from * poppler 0.12.0 (Wed Sep 9, 2009) to * poppler 0.14.0 (Tue Jun 8, 2010) Compiling the internal poppler, we're up-to-date anyway. Change-Id: Iee07cfeb43f4320fd596c772eeb26662505d0daf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125778 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-11-26m_xTreeBox is always trueCaolán McNamara
this has evolved from an optional m_pTreeBox widget to an always present widget that's optionally visible and this case wasn't updated somewhere along the line. Use "IsSafeForWaterCan" which the other cases of this pattern were merged to Change-Id: Ia20327ade5378bbdfa9fbfecbfa9705a33555f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26tdf#139102 Erase with COL_TRANSPARENT doesn't do what it shouldCaolán McNamara
lets not fight that here, just provide a simple backportable fix to 7-2 for now. Change-Id: I77ceb7ccace08041a42b51e1b028ebe2d6a03e51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-26loplugin:stringliteraldefine in frameworkNoel Grandin
Change-Id: I8bdda62c232b8f20aa6bb1e5e7ad303d6ffa47ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26loplugin:stringliteraldefine in packageNoel Grandin
Change-Id: I91ce2f65513ea9ae74841c6b0286c01d4e6dd82f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125812 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26loplugin:stringliteraldefine in l10ntools..ooxNoel Grandin
Change-Id: Ia19d247f3cf439405c05a53c4cf2c9d0e7344560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-26loplugin:stringviewparamStephan Bergmann
Change-Id: I8a4c310e3a963362bff390e93ca39a7583e83e1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125857 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26sw, viewing OLE objects: also protect "common" embeded objectsMiklos Vajna
Commit 4f9f1ac33366817df61c488a9f36b09c592ee939 (sw: allow viewing OLE objects in protected sections, 2021-11-25) allowed launching OLE objects in protected sections, and then made sure that changes done in "real" OLE editors (on Windows) are discarded: both the native data and preview. Extend this mechanism to also handle common embedded objects (i.e. when we load the data into an own document model, like Calc-in-Writer on Linux): there we can simply load the data read-only, so there will be no need to discard anything. This requires some way to pass down the read-only flag from sw/ to embeddedobj, implement XInitialization on OCommonEmbeddedObject to do that. Change-Id: I7b32d7514a6b0a40b4f58bed57879d292daa4ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125858 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-11-26tdf#133835 speedup calc autofilter (10)Noel Grandin
Remove more temporary buffers in INetURLObject::setAbsURIRef Change-Id: I3c5430937e3365a15b396504226d3bbdd39c4cc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>