summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-12-07tdf#145614 Convert #define to 'enum class'Pesi Taototo
Change-Id: I991cd44b13465e63c5adc1aed3cfbc038847c0f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126396 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2021-12-07cid#1202917 Uninitialized scalar fieldCaolán McNamara
since... commit 4c00e8fb10437fcaefe8635ef390b78376938d15 Date: Fri Dec 3 20:52:12 2021 +0100 Add image preffered DPI document setting, use it in Writer, Impress Change-Id: Ie8c8bc568c483b790b2360162aedcf8ab6e48cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-07lock model while building chartNoel Grandin
reduces the amount of broadcasting we do Change-Id: I29ebabfcd255a96381d75b2b013f4a1abfb8ee08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07make sure vector elements are initialized properlyLuboš Luňák
Change-Id: If18268a26118ea587f474c21b7ca0f1fa4622744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126469 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-07tdf#145322, tdf#144378 fix printing for vertical writingMark Hung
Printing still uses ExTextOutRenderer to render text because Skia haven't yet support printing and DWriteTextRenderer can't bind the printer DC. ExTextOutRenderer uses win32 API ExtTextOutW. In order to renderer upright CJK text in vertical writing with that API, the HFONT created with CreateFontIndirectW needs a font name prefixed with '@'. OTOH, use '@' prefixed font with Skia break the vertical writing unit test. - WinSalGraphics::ImplDoSetFont: use '@' prefixed font name if the requested font is vertical and is for printing. - ExTextOutRenderer: use SetTextAlign and text metric tmDescent to adjust vertical glyphs. It's not consistent with Skia or DWriteTextRenderer, and is still incorrect in many cases. The patch is adapted from reverting commit 5686c1aca40beb9514d40c86b4a3780a8a1334ba Author: Mark Hung <marklh9@gmail.com> Date: Sun May 2 14:45:45 2021 +0800 vcl: use DWriteTextRenderer for vertical writing. Change-Id: Ib2d3df8b68cad4bebe0672c9da0a16b62aed99e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125978 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-12-07ODP export: write the theme of a master pageMiklos Vajna
Which requires describing the schema, which is really just a new <loext:theme> element, the rest reuses the color-table markup, which wasn't used in ODF so far (but was used in our .soc files). Also make sure that we only do this in ODF extended mode (which is the default). Change-Id: I90eaad30f63946c441fe0c53caf6a47caf1714d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126466 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-12-07sw layout xml dump: handle SwFieldPortionsMiklos Vajna
This is the case where the field has a single placeholder character, but it typically expands to more characters at a view level. Change-Id: I5f11b29772697dbca3475aa53cf9301b67e64452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126459 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-07loplugin:unusedmethodsNoel Grandin
Change-Id: Ic1ba90447575278d854af85312271c41766b776b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07loplugin:unusedfieldsNoel Grandin
Change-Id: Id39c3f484a364fb5163444febe99aee79daf1a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-07loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I231195c36d620254cbcd2f4d7bbb9044f7887fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06tdf#145910: relax a bit denylist about OpenGLJulien Nabet
since we don't use OpenGL anymore for rendering, only for slide transition (and some canvas part but it doesn't work) Change-Id: Ia891915fcc10c0817a79e30fa59605a9681b6536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126461 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-06fix overflow in cairo downscaled bitmap cache (tdf#137719)Luboš Luňák
In my system, sizeof(long long) == sizeof(long) == 8, so multiplying by LONG_MAX overflows long long. Change-Id: Ieb9613ef05916ef24a64db69f698036ecaf194e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126456 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06signed-integer-overflowStephan Bergmann
...after 8406139062d9ffe1daed32aefe4e261c6c55d63e "process broadcasts for adjacent cells together (tdf#119083)" during CppunitTest_sc_bugfix_test, > sc/source/core/tool/grouparealistener.cxx:340:72: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Change-Id: Ica29fc4c204cd6fd5c52c61271ebfcc9691f7f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126458 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06signed-integer-overflowStephan Bergmann
...after 8406139062d9ffe1daed32aefe4e261c6c55d63e "process broadcasts for adjacent cells together (tdf#119083)" during e.g. CppunitTest_sc_ucalc_copypaste, > sc/source/core/data/documen7.cxx:143:59: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Change-Id: If848747f6b004219475b39b48c6a3de086bd1ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126457 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06Retire build-nocheckThorsten Behrens
Build target was kept for backward compat in 'rework the default make target', so lets retire it after 1.5 years. Use 'make build' instead (which is since the default target anyway). Change-Id: I93d5237dce2abf2536a4d847d79d33d5b6d6cec9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126362 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-06don't want to link to system static libs for DISABLE_DYNLOADINGCaolán McNamara
since... commit 4250958a492b300a52a83e68dd599f9c36c5086e Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Aug 20 14:31:36 2021 +0100 ofz: prep for allowing oss-fuzz msan dependencies need to be built with the msan flags so undo the --with-system .a usage now that trying to squeeze into the 12 hour build window isn't critical because the afl 6-8 hour build+check is disabled dropped the use case for that Change-Id: Ic525c9e0a948195cc823d904ba5a0d80b3aff668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-06ofz: Use-of-uninitialized-valueCaolán McNamara
since... Date: Wed Jun 2 17:01:55 2021 +0200 WMF: add more SAL warnings in case record was not implemented Change-Id: I1d58c4093817403caa5f1112b5d4d5a4e638b799 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116618 Change-Id: Ib82efbc93405b7fafb661f698a772593d2495bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126454 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-06Fix typosAndrea Gelmini
Change-Id: I16d59aa3a3f17764a848428a2e6b206dc57a480a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126325 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-12-06Revert "lose the caching in ViewObjectContact" because it breaks...Noel Grandin
bitmap caching. Added some notes for future would-be optimizers. This reverts commit 7f02cb80ac2075b65ee1adee4e29d1d5c4819424. Change-Id: I39c41ea95d23d4a65edd3cef46a5d86fab48a044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126425 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-12-06gbuild: create services.rdb from built componentsJan-Marek Glogowski
... and introduce the --enable-services-rdb-from-build option. Currently the build handles global build options redundant in a few places: * in Repository*mk + modules - the "real" build dependencies * the full services.rdb generation * the static UNO constructor map generation Also the component files don't reflect the really built components and so the RDB services generation must handle the whole options to select the correct components. So this optionally replaces the latter two by generating the list of components and it's constructors from the build itself. As a consequence, component files must now be split, so they reflect the real components in the libraries, otherwise the static constructor list will have missing symbols. IMHO this is more natural, as it happens in the same place already handling these build options for the sourcecode. This also adds a convenience helper to add multiple component files: gb_Library_set_componentfiles This is WIP and currently just works for the stripped WASM build, which introduces many more split component files in later patches. It also explicitly filters the gb_Rdb__URECOMPONENTS and the CppunitTest related components from the services.rdb. Maybe there is a good way to do this properly. Change-Id: I1b38a6f2c1e5221f18d7e5e756c30263b555d962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126185 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-06Better workaround for ASan use-after-poisonStephan Bergmann
...than ae36ee4f3aa544e53e2edad93d6d79160b27bc9d "Work around use-after-poison" for > ==1922539==ERROR: AddressSanitizer: use-after-poison on address > 0x61d00190fab0 at pc 0x00000026aaa9 bp 0x7f422ee84b80 sp > 0x7f422ee84348 WRITE of size 192 at 0x61d00190fab0 thread T44 #0 in > memset at > ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:800:3 > (instdir/program/soffice.bin +0x26aaa8) #1 at <null> > (/lib64/libnsspem.so +0x15f3d) #2 at <null> (/lib64/libnsspem.so > +0x16185) #3 at <null> (/lib64/libnsspem.so +0x8a9b) #4 at <null> > (/lib64/libnsspem.so +0xe13b) #5 in secmod_ModuleInit at > workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11 > (instdir/program/libnss3.so +0x4ad372) #6 in secmod_LoadPKCS11Module > at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10 > (instdir/program/libnss3.so +0x4b1fca) #7 in SECMOD_LoadModule at > workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10 > (instdir/program/libnss3.so +0x50de92) #8 in SECMOD_LoadUserModule > at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28 > (instdir/program/libnss3.so +0x50e9a9) #9 in nss_load_module at > workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12 > (instdir/program/libcurl.so.4 +0x4fdd25) #10 in nss_setup_connect at > workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12 > (instdir/program/libcurl.so.4 +0x4eeffb) #11 in nss_connect_common > at workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14 > (instdir/program/libcurl.so.4 +0x4ee237) #12 in > nss_connect_nonblocking at > workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10 > (instdir/program/libcurl.so.4 +0x4ebe4a) #13 in > Curl_ssl_connect_nonblocking at > workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12 > (instdir/program/libcurl.so.4 +0x514039) #14 in https_connecting at > workdir/UnpackedTarball/curl/lib/http.c:1591:12 > (instdir/program/libcurl.so.4 +0x2f29ce) #15 in Curl_http_connect at > workdir/UnpackedTarball/curl/lib/http.c:1517:14 > (instdir/program/libcurl.so.4 +0x2f23d5) #16 in protocol_connect at > workdir/UnpackedTarball/curl/lib/multi.c:1696:16 > (instdir/program/libcurl.so.4 +0x3b8620) #17 in multi_runsingle at > workdir/UnpackedTarball/curl/lib/multi.c:1997:16 > (instdir/program/libcurl.so.4 +0x3a2232) #18 in curl_multi_perform > at workdir/UnpackedTarball/curl/lib/multi.c:2568:14 > (instdir/program/libcurl.so.4 +0x39dc5c) #19 in > http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&, > http_dav_ucp::CurlUri const&, curl_slist*, > com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> > const*, com::sun::star::uno::Sequence<signed char> const*, > std::pair<std::__debug::vector<rtl::OUString, > std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&> > const*, (anonymous namespace)::ResponseHeaders&) at > ucb/source/ucp/webdav-curl/CurlSession.cxx:880:14 > (instdir/program/../program/libucpdav1.so +0x5aad30) 0x61d00190fab0 > is located 48 bytes inside of 2048-byte region > [0x61d00190fa80,0x61d001910280) allocated by thread T44 here: #0 in > malloc at > ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3 > (instdir/program/soffice.bin +0x2d3c7e) #1 in PR_Malloc at > workdir/UnpackedTarball/nss/nspr/out/pr/src/malloc/../../../../pr/src/malloc/prmem.c:448:55 > (instdir/program/libnspr4.so +0x123629) #2 in PL_ArenaAllocate at > workdir/UnpackedTarball/nss/nspr/out/lib/ds/../../../lib/ds/plarena.c:134:27 > (instdir/program/libplds4.so +0x9a32) #3 at <null> > (/lib64/libnsspem.so +0x15f77) during UITest_sw_options: That --with-system-nss workaround for <https://ci.libreoffice.org/job/lo_ubsan/> had caused CppunitTest_desktop_lib to start to fail there, presumably "caused by --with-system-nss on the CentOS7 baseline", see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2021-December/088136.html> "Re: [global-libreoffice-ci] UBSAN Linux Build - Build # 2217 - Still Failing!" And while I had initially not been able to reproduce the use-after-poison during UITest_sw_options with my local ASan+UBSan build (on Fedora 35), I now found out that that was just because my machine happened to not have an nsspem library installed in the system (the nss-pem RPM on Fedora). With that system library installed, my local build failed UITest_sw_options in the same way as the Jenkins tinderbox. Which lead me to the idea of avoiding the whole mess by avoiding that CUrl loads the (apparently optional) nsspem library in ASan builds altogether. (Another approach might have been to disable the __asan_poison_memory_region functionality in workdir/UnpackedTarball/nss/nspr/lib/ds/plarena.h, but the chosen approach nicely makes us less dependent on accidental differences in build-time execution environments, at least for ASan builds.) Change-Id: I8fd2ff255771622f26ad666ca78a6d9ded0af2d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06Work around two -Werror=implicit-fallthrough=Stephan Bergmann
...that started to crop up with recent GCC 12 trunk (where it expanded the ENSURE_OR_THROW macro, but apparently didn't take into account that its > 97 | if( !(c) ){ \ > | ^~ will always be taken in these cases where the c argument is false), and can easily be avoided by getting rid of those uses of ENSURE_OR_THROW(false, "...") (And while at it, move the default case to a more reasonable position in mtftools.cxx, obsoleting the FALLTHROUGH comment in any case.) Change-Id: I8189d98b361e6725096d0968f3e0e604fb84e591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126452 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06Revert "cid1494597 silence Uncaught exception"Stephan Bergmann
This reverts commit 96e9eb56f0f76590ccc46a6948ae00803a92f113, as it should no longer be necessary with the more general 0a710c5c4475b593428c6d90e791ef2ccc880062 "cid#1494595,1494597: Silence UNCAUGHT_EXCEPT" (which I had created without being aware that this commit already existed). Change-Id: Iabf20626577af251e2e5bb146ad37c2a6ed7e3e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-06tdf#138999 only grab keyboard and not pointing devicesCaolán McNamara
this way scrolling in a combobox dropdown and moving the mouse outside the widget doesn't cause the scrollbar to jump to the top. No ill effect seen in a) autofilter dropdowns in calc b) color dropdown in writer main window or sidebar and clicking on combobox subwidget to launch its popup and select an entry to return to color dropdown c) submenu popups from style combobox dropdown Change-Id: I6ad445a6fab899d52907237e1f5506cce31b1f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-06an empty $LOCKFILE means build our ownCaolán McNamara
Change-Id: I93fd08b3b106e461f402446bd4dbbe78b8f06849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126450 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2021-12-06tdf#143422 Hide "Hyphenation data not found" in JapaneseJun Nogata
When I open a document with mixed English and Japanese, I get a warning "Missing hyphenation data Please install the hyphenation package for locale "ja"". English needs hyphenation, but Japanese does not need hyphenation. However, the hyphenation check only checks for unknown language or no language. Change-Id: I559e1b1eec8089f50aadad2710a33d0268ab13f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120497 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-12-06a large but clipped image may still be cached from a previous callLuboš Luňák
Canvas apparently likes to redraw only small parts of the background, which means that there may be repeated scaling of clipped parts of a large background image that are considered too clipped to be cached, but even the drawing of the clipped part may add up to be costly in the end if done often. Refusing the caching only after checking whether the image is possibly cached may avoid some of the drawing in case there was an initial drawing that wasn't clipped and thus generated the cached image. Helps a bit with e.g. tdf#136223. Change-Id: I4de6164940ec7a06fb6ae2f504907b4fa076f1d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126412 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06Adapt CppunitTest_cppcanvas_emfplus CPPUNIT_TEST_NAME=testFdo77229::TestBodyStephan Bergmann
...to 374e261ad1ea8b41f5ecdd850c27fdc961c4868b "increase maximum document thumbnail size from 256 to 512" (which wasn't caught by Jenkins due to bcd243793ee4174d71b5e61c88d2bc79fd0d7f1d "CppunitTest_cppcanvas_emfplus: disable this in case there is no display to use") Change-Id: Ibe3dc93401e237c37b4823f0393746b1e8b569bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06process broadcasts for adjacent cells together (tdf#119083)Luboš Luňák
The problem in tdf#119083 is that it sets up listening for the range of cells used by VLOOKUP, and when adding a new column changes all those cells, it results in repeated SfxHintId::ScDataChanged broadcasts to the cells with the VLOOKUP formula. This commit makes ScHint include a row count, making it possible to group adjacent rows for SfxHintId::ScDataChanged together and send notifications just once for the range. Change-Id: Ib3439de58a2b1e5e8f01b037a62608e38b8e9125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06try to broadcast in bulk (tdf#119083)Luboš Luňák
This somewhat improves the situation, but still a lot of time is spent repeatedly making the same cells dirty. Change-Id: I3444ca6dac4b3a40c6ac40a0b70cf5baeefa2f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126391 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 73228ff72af0e4f8ca7e29b4dca388741804cb06 - Document new TableControl methods and properties Change-Id: I8623a11f5fb710332765b8db3914a36b51285b7a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126294 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-12-06map->unordered_map in PropertyMapperNoel Grandin
a little bit faster Change-Id: I11e756e65a76fedeca2525edf37a04b34ac6aeda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126407 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06Drop ENABLE_FUZZERS from config_host.mk.inJan-Marek Glogowski
... and just convert the last user to $(BUILD_TYPE). Change-Id: Iaf6361b0be47594e5c1ac08a8183460b7ada92f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126410 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-06tdf#145892 disable failing assert in additional icu khmer patchCaolán McNamara
Change-Id: I8507c101544fcdcdc6e75c853c44e04e97a96d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-06cid#1494595,1494597: Silence UNCAUGHT_EXCEPTStephan Bergmann
...after aa5ee0085c7d8b8713f4dbed0009b38b9fabb281 "Stop swallowing exceptions in ~ScopeGuard" had dropped the catch blocks from ~ScopeGuard to make it usable in Library_salhelper in 0c1c300ed7ce168755ae945822eb7a1c610cfa25 "Rather use ScopeGuard to prevent catch and rethrow". But using the original suppress_fun_call_w_exception, which used css::uno::Exception, would have caused the same circular-dependency issue again that aa5ee0085c7d8b8713f4dbed0009b38b9fabb281 had solved, so drop the use of css::uno::Exception (and SAL_WARN, which triggered a number of missing #include <sal/log.hxx>) also from suppress_fun_call_w_exception. After all, that was __COVERITY__-only code that wasn't meant to be actually run, so it shouldn't matter if we just catch everything and silently terminate. Change-Id: If28a214709e4636e1c23a49f2d95d87c91492f14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126404 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-06loplugin:stringliteraldefine in sdNoel Grandin
Change-Id: Ie03e3d06a608ee89484a07439bd6deeb1679aade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b7bdb8a47c81ed94509777b12d2706a36ad18add - Fix a "D'oh you found a bug"... Change-Id: I7261546457c0d128bef55cb8be7737cb6b70d22a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126417 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-12-06tdf#145671 Don't open URL twice in cell edit modeSamuel Mehrbrodt
Change-Id: I8a324d6a037c8a5c0efc0b2825657513c2f9841c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126159 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-06Limit static system library linking to fuzzersJan-Marek Glogowski
When building a static LO on Linux, I get a lost of missing symbols for binaries, like oosplash. In that case we just link to Xinerama, but this has obviously other X11-based dependencies, and there is no real way to fix this. According to caolan, this was just added in commit 7a3eaef6dd707781c2f4e341aebb9d4c42df780f ("for DISABLE_DYNLOADING support linking to static .a system libs") to support instrumented static libraries used for the oss-fuzz runs (see https://github.com/google/oss-fuzz/issues/608). So actually limit these flags for FUZZERS only. Change-Id: I7eaa81c46fab040848fdf4dbe100a6e634f54446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126409 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-06skip some intermediate results in tryToGetChartContentAsPrimitive2DSequenceNoel Grandin
Change-Id: Idf3179c97fe40da1ff41100fc7e7a0b80ee1ca73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06only collect hitstack if we actually need itNoel Grandin
Change-Id: I95f04b05c431f0009c5a843626c397e1dbc3f39e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126402 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06Revert "tdf#145354: Ensure displayed paper name matches displayed paper ..."Tor Lillqvist
It causes tdf#146045. This reverts commit 65081542d2dabdf17820d62abdc5a22d3734e52d Change-Id: Id980701b1a823c8bf7cfb57e0b32cf5d672c3bfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126373 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-12-06Add image preffered DPI document setting, use it in Writer, ImpressTomaž Vajngerl
This adds a "image preferred DPI" document setting, which is used as a suggestion of the DPI that an image should have in the document. This is currently used when the image is inserted into the document (Writer, Impress/Draw) to resize it to the preferred DPI value. Change-Id: I3ee9d409257e3c6aa2ead05144ecbba7b3b916f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126334 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-12-06configure.ac: tabs to spacesJan-Marek Glogowski
Regression from commit 214fa233338c09156c67f85818b6a2ea6b3235bd ("add with-system-abseil/with-system-openjpeg for pdfium"). Change-Id: I218cd4762f295c8d253afb670d3f3ebd5e104c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126398 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-12-06loplugin:stringliteraldefine in starmathNoel Grandin
Change-Id: I539dbb8eaa21604401709d3b6e19433474056902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126406 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-06make it clearer that ScHint is modifiedLuboš Luňák
It's somewhat confusing that an accessor is provided to give a reference to internal data and then the object is modified indirectly using the reference. It appears to be only for performance reasons, so I thought that inlining the ctor and ctor could help the compiler to optimize this, but apparently it can't move this outside of the loop, so at least make it clearer. Change-Id: I72cf15d1446daa559ac4079b9478e53694d7d198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126394 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06use sc::AutoCalcSwitchLuboš Luňák
Change-Id: Idea2206ace5c40b2b7c38b949f9d20feb4513974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126390 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06slightly simpler Intersects() checkLuboš Luňák
For two ranges to intersect, both start points must not be larger than the end points. Change-Id: I69d1c548ff1bac90baea0767e92ca86458808c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126393 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06rename In() to Contains()Luboš Luňák
Similarly to b22d4785310eac35696d, 'A.In(B)' makes it unclear whether the check is for A in B or B in A, as it's actually the latter. Change-Id: Iaccc41d40f4bb105a44c1bb8d9211c06d1a3c127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126392 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-12-06tdf#143148 Use pragma once instead of include guardsPesi Taototo
Change-Id: Ia1c309425e64449679d6948b5e9e595fe421cfa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126378 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-15 07:17:55 +0000