Age | Commit message (Collapse) | Author |
|
The event is sent shortly before the Dialog will go into
Application::Yield. Therefore you know that you can rely on the dialog
being visible shortly after the event has been sent.
Change-Id: Ifa911adae60ac877161ec43f27cb57d611a60059
|
|
This avoids that we are stuck when we call a modal dialog.
Change-Id: Id8c6a7a4c1369359b1355095b87cccaa95123f89
|
|
Change-Id: I3cbb3d8f7c6fa0d2616a31192a959f89d4cc7703
|
|
Change-Id: I88eb14bb0846ee8baff9c3d15ee93d777601f260
|
|
Change-Id: I48be9d1daeff83913909f57bf972ca171367a2b0
|
|
ReallyVisible is calculated by going through the hierarchy and check if
all parents are visible.
Change-Id: I41dec643618a9ee57a0d04efb9d72c45723b3f65
|
|
Change-Id: I0432f1bbe0e282e854df534094908a8eba62eaa3
|
|
Change-Id: I9bbb60c1b64a10488ccf74f12e144802485bbc82
|
|
Just for consistency.
Change-Id: I13577b9318039493f585268fd7189f5cbc4dec46
|
|
This is much closer to what happens when a user inputs some text and
ensures that the modify handler is called.
At some point we need to introduce a general keyboard handling. This
includes functions like DEL, RETURN, ...
Change-Id: I0561d8ff83bbf93c460be82634b4d3a23b42b68b
|
|
Change-Id: Ife00f65311c44703edae06971f77faa6b0e2eb3f
|
|
Change-Id: Ia926854eefdf4b972ceb0766da16730d552dfe8f
|
|
Change-Id: Ic4c701d385d3d439dd9f92da201fffd31adbfad2
|
|
Change-Id: I0ee5d1e93808103a1541ced6fc7ea9d05a70fc89
|
|
Change-Id: I545a9e40f6fb1f07e685d6901d2158b83012331c
|
|
This might be a modal dialog (mpLastExecuteDlg) or a modeless dialog/the
toplevel window (mpFirstFrame).
This window should be used with get_child to find the correct window in
the current scope.
Change-Id: I0a1e63d0aa19c782069ba5876549f274dabb109b
|
|
Change-Id: I81d53aaeca83f22887a461dc2151001118dad2e9
|
|
Change-Id: Ib46ef5ea31e77d54786c0d732845984ce3c9c07f
|
|
All the actual implementations don't need to be exposed to the outside
world.
Change-Id: If92469b99e6c39493767de947434c6d78ae3804c
|
|
Change-Id: Iac35bf1e699c64f16b4479ed5a6c7fb101e12f9d
|
|
This allows us to use them in vcl as well without introducing dependency
problems.
Change-Id: Ib97af2d559902f1a6b47f9255bb0426411670647
|
|
Change-Id: I79193190f8f614b2d6a71032f05a0518eb9d1a1d
|
|
Change-Id: I51b81da870fd220d56b32c20b9e6c4604912a014
|
|
We will use the ID in the UI testing to identify the widget.
Change-Id: I4dd79a02355e1de40f3c2ddc6a61a805b4e30778
|
|
Change-Id: I4ead30fa1736a3a99fb3379e89367934c8df2809
Reviewed-on: https://gerrit.libreoffice.org/26444
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I02903cda46809798ec7664cf620c06ea7687e54e
Reviewed-on: https://gerrit.libreoffice.org/26443
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Project: help 16c021b2259e92fd21da3689309375fcc21891b2
Better wording for FORECAST.ETS.* help pages
Change-Id: Iac41e281088fb1ca48f1b5509d38301405ff6348
Reviewed-on: https://gerrit.libreoffice.org/26437
Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
|
|
Change-Id: I8c4a5e701c20c70c7df091a34efb38936ee59f9d
Reviewed-on: https://gerrit.libreoffice.org/26420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I2dfcdde6ef1782edc22ca6d70d353549706eb14f
Reviewed-on: https://gerrit.libreoffice.org/26322
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
See also: sfx2/source/sidebar/PanelTitleBar.cxx#162
Change-Id: I22eca7eeabb6ba7dd64b7840a3eac3ce9a455a9b
Reviewed-on: https://gerrit.libreoffice.org/26412
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
It is more readable and more efficient as a bonus.
See: https://goo.gl/jsVAwy:
Change-Id: I0831b2f6ab2912a15ff33397a7959596b7bd3cb8
Reviewed-on: https://gerrit.libreoffice.org/26451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Cell editing uses editeng which has a different
set of requirements. The coordinates are in
100th mm and so we have to convert the ofsets
to 100mm.
Change-Id: I278457ffc2273eb786101875c85ddfb959d4c5e3
Reviewed-on: https://gerrit.libreoffice.org/26205
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 0dbffca63191712d9f77297061a3d4651b8410aa)
Reviewed-on: https://gerrit.libreoffice.org/26377
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Since embedded graphics and buttons use
absolute coordinates, we set the origin
to be the top-left corner of the tile.
This includes the origin + ScrPos (see
previous patch).
Then, the coordinates of the graphic is
shifted by this amount to make sure it
renders in its relative position to the tile.
This renders embedded graphics and buttons
at their correct position, with some limitations.
Tiles large enough to cover a graphic object
show the graphic object where it should be.
However, rendering a relatively small tile
doesn't render the graphic. This seems to be
an issue with moving the graphic's coordinate
at a later stage than the 2D Processor decides
what objects intersect with the 'view area'
that is rendered.
Another issue is that graphs don't render.
What they seem to suffer is incorrect scale
and a fix coordinates (they show up as tiny
thumbnails at the top-left corner and grow
in proportion to the real graph when resized).
These shall be addressed in a separate patch.
Reviewed-on: https://gerrit.libreoffice.org/26204
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 5f01d80f75dc86b393cc2fdb66b94aece964c674)
Change-Id: I4b71bf5f2e357d1114d46022bc00905ceed0c2f9
Reviewed-on: https://gerrit.libreoffice.org/26376
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
For every tile, the bounding columns and
rows are found. The origin of the device
is set to the top-left corner of the
top-most row and left-most column, respectively.
Because tiles don't have to align with a
column or row, the ScrX and ScrY (Screen Position)
coordinates are set to the offset a tile has
to its top-most row and left-most column.
Rendering of text is super fast as the
minimum area is rendered for a given tile.
However, it doesn't work for embedded objects.
This is addressed in a separate patch.
One pending issue with text is when editing.
The text doesn't correctly render while
editing a cell. This is almost certainly
because the edit control is not rendered
at the correct offset (in the middle top
row it can be seen showing up to the right
of where it should be).
Reviewed-on: https://gerrit.libreoffice.org/26203
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit ecc33ce663625ae1114a56fe3d1625c5ed274685)
Change-Id: I6f1ea0aa2f19a7fda926f596a2009290680c593c
Reviewed-on: https://gerrit.libreoffice.org/26375
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
OWeakObject::m_pWeakConnectionPoint is returned from
OWeakObject::queryAdapter(), and stored in
OWeakRefListener::m_xWeakConnectionPoint.
This is cleared in OWeakRefListener::dispose(), called from
OWeakConnectionPoint::dispose(), called from
OWeakObject::disposeWeakConnectionPoint(), but it can happen that
another thread is in WeakReferenceHelper::get() and has copied
m_xWeakConnectionPoint onto the stack before the OWeakObject is
released and deleted, then calls OWeakConnectionPoint::queryAdapted()
after it is released, accessing the dead m_pObject.
Change-Id: I7782e6fb7e07f5a48cf7064115217376714ba8e8
|
|
Change-Id: Ibfb27b3eded45e2646dada37ce3663f427985ae9
|
|
This fixes the following problem:
- createView() = 1
- createView() = 2
- destroyView(1)
and then view #2 was renumbered to 1.
Instead expose the pointer address of the SfxViewShell as the ID, which
is not changing in such a situation.
Note that the SfxViewShell <-> ID mapping is an implementation detail of
SfxLokHelper, and only pointers are converted to IDs, user-supplied IDs
are never converted back to pointers.
Change-Id: If79ef8b99ba391011b5d82b219ad13447d44cd5a
Reviewed-on: https://gerrit.libreoffice.org/26423
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
when there is associated data in the src. Its copies those pointers
into the block that will appear in the destination. Then can destroy
the source block, which deletes the contents of those pointers, and
then inserts the new block which has dangling pointers to the deleted
data.
https://gitlab.com/mdds/mdds/merge_requests/2
Change-Id: Id9614d95652c8032b03cb5748a284917043d8d21
|
|
Change-Id: Ib56c08f916cdae74c54bc13d4ef7ced46a227520
Reviewed-on: https://gerrit.libreoffice.org/26384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ia78f9d29025e593dfa4202af67c95bdb5432d15c
Reviewed-on: https://gerrit.libreoffice.org/26383
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
otherwise building from source-tarballs fails when it tries to extract
fetched submodule tarballs
Change-Id: I75bcd6821e244ca2a3375ec2916ee7c38ec9844e
|
|
Change-Id: Ic756db3decb4b4bfde345bc0adc092907622287e
|
|
Change-Id: I2641abe8e049361d5eb92e19b9ed57b8e7209386
|
|
Change-Id: Ic927bd52949f1bd196bec0efd3d49f9bb2841bd6
Reviewed-on: https://gerrit.libreoffice.org/25781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I39fbc89cffe25e85b8cd1f2e36f0a20c07e33497
|
|
Change-Id: I2fb13854a6da3f114dba386169e5aef7f741b922
|
|
Change-Id: I06485c07e6c6fd3621fdfc99b7176107bb0ee999
Reviewed-on: https://gerrit.libreoffice.org/26418
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
|
|
... but its documentation claims that it is, which is partially
misleading, so fix both the documentation and the data race in
WeakReferenceHelper::clear().
This actually crashed in clear() in the multi-threaded ZipPackage code
on exporting the bugdoc from tdf#94212, presumably because clear()
races against OWeakRefListener::dispose().
Change-Id: I85665c11b8157e90d15e8263758e24e66efeb86c
|
|
Change-Id: I2abf050bd6627cda993ff03bdf1d1867e209bda5
Reviewed-on: https://gerrit.libreoffice.org/26392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Its purpose was to allow incrementally migrate all callers of
SdrModel::libreOfficeKitCallback() to use
SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only
the currently active or all views) instead. That is done by now, so it
can go.
Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3
Reviewed-on: https://gerrit.libreoffice.org/26413
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|