Age | Commit message (Collapse) | Author |
|
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2
Reviewed-on: https://gerrit.libreoffice.org/73897
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d18f31c4c9d6169f48f34bc53615a5a93a822aa7)
Reviewed-on: https://gerrit.libreoffice.org/73938
Tested-by: Jenkins
|
|
Change-Id: Ib7a39b69fc55461b68fa416a48399f5e0a16c63a
Reviewed-on: https://gerrit.libreoffice.org/73932
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
(cherry picked from commit 896e8b0914b6e5dee562ddaa09d4169eb8f325f5)
Reviewed-on: https://gerrit.libreoffice.org/73940
|
|
Commit e6c2951f1957224aa0e7dc97b33b0450c41f92f7 (delegate RenderContext,
invalidate - prgsbar, scrbar, 2015-04-29) switched ProgressBar::SetValue() from
direct partial paint to invalidate + paint later, which means setting a
progressbar value, then using an external sleep (such as Python's time.sleep())
no longer results in an updated progressbar.
Solve the problem by explicitly processing all events with at least
TaskPriority::REPAINT priority after the invalidate in ProgressBar::SetValue(),
which is similar to what the Wait implementation in the basic runtime does.
(cherry picked from commit f7157f04fab298423e2c4f6a7e5f8e361164b15f)
Change-Id: I86475fb899f16b72ebefe9d3056c92cedeff4439
Reviewed-on: https://gerrit.libreoffice.org/73952
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
And since whether this works correctly is tested by cl-test.ods,
without this OpenCL gets disabled on Intel machines.
Change-Id: I8d5c9b1298a08f2e2cb6dfdf183f542315372889
Reviewed-on: https://gerrit.libreoffice.org/73887
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(cherry picked from commit 5b6128699dbe94590629c43cc8f78d95f68330bb)
Reviewed-on: https://gerrit.libreoffice.org/73944
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This apparently has been wrong since the beginning in 2009.
It's a somewhat odd algorithm anyway, first calculating the time
in seconds, minutes and hours, but maybe there's a reason
regarding rounding, so not changing that.
Change-Id: I855d2c96094b4edb1095d20bcdfebdea6d6d943a
Reviewed-on: https://gerrit.libreoffice.org/73893
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit 1436d2307d90f5ddbdcb0f129e59544306530342)
Reviewed-on: https://gerrit.libreoffice.org/73914
|
|
Change-Id: I0bd597498d10130928de5d7865219fe6f4bc8bcd
Reviewed-on: https://gerrit.libreoffice.org/73882
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Commit e6c2951f1957224aa0e7dc97b33b0450c41f92f7 (delegate RenderContext,
invalidate - prgsbar, scrbar, 2015-04-29) switched
ProgressBar::SetValue() from direct partial paint to invalidate + full
paint. This means that ProgressBar::ImplDrawProgress() has to paint the
whole progressbar, not only just the delta between the old and the new
value.
Remove the not needed mnPreviousPercent member and just paint from 0 to
the percent value, like we did before the above commit, that does the
needed full paint.
(cherry picked from commit 6fd3eb533998c8f63430a43767b2a52aa5e71e3f)
Change-Id: Id45ee918248b5fa6647bd766a49b707da1e5846f
Reviewed-on: https://gerrit.libreoffice.org/73933
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I56b1bb83dc221c87ec7aac72b406d67c85f74f43
Reviewed-on: https://gerrit.libreoffice.org/73881
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I976edb0b49c8439d1723be4544b10a5375b8e1d3
Reviewed-on: https://gerrit.libreoffice.org/73900
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9d5165a486e8806f41122e72803000ab3e7b3b46
Reviewed-on: https://gerrit.libreoffice.org/73913
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
It happened that the first and subsequent paints used a different font
size, standardize on the label font.
E.g. the linux gen backend used either 11 or 12 pt font height, now it
always uses 12pt, matching the gtk3 behavior. (No cutoff of text with
Windows gdi 125% text size this way, either.)
(cherry picked from commit 47dbbe214641b9a28871d0c82f71b2afb9c5943c)
Change-Id: Ia3f7b69c5a76e1c15fe04743870e92cffdc351d7
Reviewed-on: https://gerrit.libreoffice.org/73888
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
6a7db071c75609093fc3a9cbc297b8069726a33e "tdf#125497 allow backspace to remove
CJK IVS" had moved these functions from sw/source/uibase/wrtsh/delete.cxx to
rtl/character.hxx, but the latter appears to be a less than ideal home for them:
For one, it is part of the stable URE interface, which makes it harder to
maintain (e.g., later versions of Unicode have added CJK Extension C--F code
blocks, which the current implementation of isCJKIVSCharacter does not reflect).
And for another, besides details of legacy/ubiquitous ASCII, it only deals with
the "hard" structure of Unicode (isUnicodeCodePoint, isSurrogate, etc.), not
with any specific code blocks or character classifications (which can change
over time). Internal i18nutil/unicode.hxx appears to be better suited.
Reviewed-on: https://gerrit.libreoffice.org/73873
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit c1399e497191f295b9c3db95d126ff6a4fa5891d)
Conflicts:
include/rtl/character.hxx
Change-Id: I88b3e4e2488411f988c1a20f79b8a58626d93dce
Reviewed-on: https://gerrit.libreoffice.org/73889
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I71c834733ff0f3d4b89ecaeecb12631609e84c1d
Reviewed-on: https://gerrit.libreoffice.org/73872
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit a025132839b19ba952558b9dbec454c8a34c6489)
Reviewed-on: https://gerrit.libreoffice.org/73895
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
This fixes the following issue for the GCC build with '-Werror=shadow'
in place which does not show up in the default build setup since
compiler flag '-Wno-shadow' is currently being set in
'RepositoryExternal.mk' for qt5 and kde5.
(This will be dropped in a follow-up commit.)
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx: In constructor ‘cairo::Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr&)’:
.../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:24:69: error: declaration of ‘m_pSurface’ shadows a member of ‘cairo::Qt5SvpSurface’ [-Werror=shadow]
Qt5SvpSurface::Qt5SvpSurface(const CairoSurfaceSharedPtr& m_pSurface)
^
In file included from .../libreoffice/vcl/qt5/Qt5SvpSurface.cxx:12:
.../libreoffice/vcl/inc/qt5/Qt5SvpSurface.hxx:27:27: note: shadowed declaration is here
CairoSurfaceSharedPtr m_pSurface;
^~~~~~~~~~
cc1plus: all warnings being treated as errors
Change-Id: I501657447e02675f7c6b1c9aaca670ba81715590
Reviewed-on: https://gerrit.libreoffice.org/73891
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(cherry picked from commit cc237438f6d1c7ee3a391b51402aaa71cd347b6b)
Reviewed-on: https://gerrit.libreoffice.org/73916
|
|
Change-Id: I179780c2df5637b8a28c3a77b829319b1a64845b
Reviewed-on: https://gerrit.libreoffice.org/73924
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 9758b9b6e52e8e8a8a5cc24b51d62a853a3def82)
Reviewed-on: https://gerrit.libreoffice.org/73926
|
|
Let's just face reality and store it as a VclPtr.
And this is needed, because Qt, like VCL, uses deferred deletion,
and has no way to filter events to QObjects out of its event queue
easily. This way the qt5 plugin can report focus changes for
SalObjects without a crash, which happens when you close a
presentation with a video by click.
And in addition it reverts the workaround introduced in commit
e770bacc85a0 ("Qt5 workaround modal change after show bug"), as it
seems this bug is a use-after-free error, introduced by LO.
Thanks Michael Weghorn for catching that!
Maybe someone should also rename SalObject...
Change-Id: I0bc64ea64f95dfc7a838799c4a04de183adfefcf
Reviewed-on: https://gerrit.libreoffice.org/73567
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 2dc6bdd1d5789ace0500cad90f5d2eb930888bb9)
Reviewed-on: https://gerrit.libreoffice.org/73921
|
|
Just a little refactoring.
Gets rid of the common used idom in the code:
m_pTopLevel ? m_pTopLevel : m_pQWidget
Change-Id: I3e96687d9d02c0b1a5537c6b6cea53e1ca3a2067
Reviewed-on: https://gerrit.libreoffice.org/73414
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit d8d8cdecdb760500b06cacef3d17c8e05332967d)
Reviewed-on: https://gerrit.libreoffice.org/73920
|
|
tdf#125742: Fix tracked change, fix blurred, missmatched icons etc
Change-Id: I4d6df1ba5e2cb4b016f40e5f626e8fcabc818454
Reviewed-on: https://gerrit.libreoffice.org/73909
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
(cherry picked from commit 47d0dac4f4b165a7e18a09aa45a6984a6c1fce0e)
Reviewed-on: https://gerrit.libreoffice.org/73925
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
The icon isn't needed at two places anymore and it's a follow up of
daba09df247c09db715ca86a6b78365e49bfe034, which removed the menu entry
toolsmacroedit. Also clean the links.txt file.
Change-Id: I700aebab5f3049ab43b778de8ae6e3e3476ae2a1
Reviewed-on: https://gerrit.libreoffice.org/73642
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
(cherry picked from commit ab09fa72f2b7b1ce9da00b4e9cb12bd0841f7820)
Reviewed-on: https://gerrit.libreoffice.org/73918
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
If GStreamer can't auto-detect an audio sink via "autoaudiosink",
it'll return a nullptr. If the volume plugin is missing, then this
currently also results in a crash.
So check the gst_element_factory_make results before using the
objects and change some wrong mpPlaybin checks to the right
mpVolumeControl ones.
This works for me without any audio and volume plugins. Since we
are linked against libgstaudio, I assume the bin is always there.
Change-Id: Ide526363d810ea48d0a62539c0a435553783e34a
Reviewed-on: https://gerrit.libreoffice.org/73848
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 5e6af47dc87a55fea595c952ea3e59c93d0620db)
Reviewed-on: https://gerrit.libreoffice.org/73919
|
|
Since we can't use an input and visual transparent widget, like a
GtkGrid, we have to implement input forwarding in the QWindow.
Using a Qt5Widget directly results in other problems on Qt 5.12+,
like these warnings (depending on the tested Qt::WA_* flags):
* Attempted flush to non-raster surface QWidgetWindow(0xa386c10,
name="QWidgetClassWindow") of type QSurface::OpenGLSurface
(consider using Qt::WA_PaintOnScreen to exclude from
backingstore sync)
* QWidget::paintEngine: Should no longer be called
So the current QWidget::createWindowContainer has to stay and key
and mouse handling must be implemented as in Qt5Widget. And the
QWindow is strangely not accessible through the windowHandle() of
the container QWwidget.
As a result this patch is mostly boilerplate code, publishing the
Qt5Widget mouse and key handling as static functions.
Change-Id: I5be5f5fa1379c6bdefab0f96604251801c252b38
Reviewed-on: https://gerrit.libreoffice.org/73566
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 25edbded9946801effd117b9c46de0f8b4bc5632)
Reviewed-on: https://gerrit.libreoffice.org/73917
|
|
Change-Id: I2768bcf146a4b5acf4f202b91e665fd478372ad2
Reviewed-on: https://gerrit.libreoffice.org/73883
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
(cherry picked from commit a38bd8bfa95e8f86e88f43ad569e849db0c49eda)
Reviewed-on: https://gerrit.libreoffice.org/73910
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I2463e7ac7d73b83e79474175bc5d51ffd826f320
Reviewed-on: https://gerrit.libreoffice.org/73841
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit b25186b6701f0770127b38ecd7744901d2c5fe72)
Reviewed-on: https://gerrit.libreoffice.org/73869
|
|
... in the double-buffering case. Commit
a4cb27f61376d8f2d8faed0022c291af68d437bd (refactor ScMenuFloatingWindow
to use RenderContext, 2015-05-14) changed the partial paints to
invalidate + full paint, so invalidate the whole treelist, this makes
sure that no checkboxes go missing on mouse click.
(cherry picked from commit 7aaa7212f2f37606b34d44a039398f05c02d5660)
Conflicts:
vcl/source/treelist/svimpbox.cxx
Change-Id: I43377b7e29d1cdfb43c60256bd57531a8251e2ed
Reviewed-on: https://gerrit.libreoffice.org/73862
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
and give the global list of just 1 entry space for 2 to take the bare
look off it, if there end up with more entries here, then let it take
its natural size at that point
Change-Id: Ic1834dc90cdcc061636ad49d69c301c7b570db3e
Reviewed-on: https://gerrit.libreoffice.org/73833
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
On Windows or with other renderings than gtk3, the urls may begin with an ~
In this case, cutPrefix returns only empty string
When trying to access Index management for odb files related to dBase
indexes don't display because cutPrefix returns empty url
in dbaccess/source/ui/dlg/detailpages.cxx line 200
198 ::dbaccess::ODsnTypeCollection* pTypeCollection = pTypesItem ? pTypesItem->getCollection() : nullptr;
199 if (pTypeCollection && pUrlItem && pUrlItem->GetValue().getLength())
200 m_sDsn = pTypeCollection->cutPrefix(pUrlItem->GetValue());
Change-Id: I47360e205ddea7b060a31da697bbe9857ad3f4c0
Reviewed-on: https://gerrit.libreoffice.org/72568
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit d34ed0008f12cfe47dd239672f1941f3c54d97fd)
Reviewed-on: https://gerrit.libreoffice.org/73709
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Regression from commit 69b62cfcbd364d7f62142149c2f690104b217ca1
(tdf#125281 DOC import: fix size of lazy-loaded metafiles, 2019-05-27),
the problem is that setting the preferred size of a Graphic swaps it in.
Avoid this by extending ImportUnloadedGraphic(): if a size hint is
provided, then that will be used instead of info from the graphic
descriptor (which is usually only meaningful for bitmaps).
This way we maintain the correct size and we're back to lazy-loading
metafiles from binary MSO files as well.
(cherry picked from commit acb803b730f2c6bd82e39beab58949ec14f85eb0)
and:
CppunitTest_sw_ww8import: disable failing assert on Windows
It fails only sometimes, it's yet clear why.
(cherry picked from commit b5d624c4af1085d4670149e9c1d280da7bc9add0)
Change-Id: Ide12d12166110e98ea47b5347dd24fb203b22da3
Reviewed-on: https://gerrit.libreoffice.org/73818
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I52fe7b9cb3c8f3dc4a3d747fb841e196dfa61ad6
Reviewed-on: https://gerrit.libreoffice.org/73856
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
(cherry picked from commit f8c6667a4407606a34917bba737bcb2578bcf2ca)
Reviewed-on: https://gerrit.libreoffice.org/73871
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I04b524784df4ef453d8b1feec13b62f183a17e23
Reviewed-on: https://gerrit.libreoffice.org/73643
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit b518882de8213ef71a8003f95fbdf7689069c06d)
Reviewed-on: https://gerrit.libreoffice.org/73857
|
|
Change-Id: I1e5fa0053e16f5ec9bf181712d111fc1a659931a
Reviewed-on: https://gerrit.libreoffice.org/73866
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7048171501e32d29f9d5a58f0d5fc0b96b318a4e
Reviewed-on: https://gerrit.libreoffice.org/73809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit 238cadd315901cbacfd9304bb1205e9f53f13eae
Date: Wed Apr 10 04:30:25 2019 +0530
dpcache : use case-insensitive normalization of...
Change-Id: I19057bde268ec07561da323bc694536dcad03a95
Reviewed-on: https://gerrit.libreoffice.org/73820
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib4c47189d5c9c89433f0c7de194ebb9777dc7bac
Reviewed-on: https://gerrit.libreoffice.org/73830
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id841d214b8d88a986c07d2827b281e5805c3c941
Reviewed-on: https://gerrit.libreoffice.org/73811
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update translations from branch 'libreoffice-6-3'
- update translations for master/6.3
and force-fix errors using pocheck
Change-Id: I04bf6657f97cf2dc94f272f401bc961a60d2fc54
(cherry picked from commit ceca6b42c96fa4c3878dd910d2ff5980ef4e79d8)
|
|
Change-Id: Ie6cea9a97205a54f806c7e56561f712f8a106fb9
Reviewed-on: https://gerrit.libreoffice.org/73808
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
- Set Noto Sans CJK KR as the 1st priority.
- Set Nanum-series font as the 2nd priority, Such as NanumGothic(나눔고딕),NanumMyeongjo(나눔명조)
- Set KoPub-series font that Korea Publisher Society(한국출판인회의) and Ministry of
Culture, Sports and Tourism, Republic of Korea(문화체육관광부) are released
- for Windows vista and later versions, Add default Korean font, Malgun Gothic(맑은고딕)
- for Mac OSX, add default Korean font Apple SD Gothic Neo(Korean: 애플 SD 산돌고딕 Neo)
- for Mac OSX, Also add Mac OSX fonts Apple Gothic(애플고딕),AppleMyungjo(애플명조)
- remove Sun-style fonts(Maybe Sun StarOffice's legacy)
- remove Hy(한양)-series fonts(Hancom HWP package's font, proprietary font-series)
Modern Linux distribution's default Korean font-families are Noto Sans&Noto Serif-family
Before Noto Sans font released, UnFont-family was Linux distribition default Korean font.
Early Linux distribution's default Korean font: Baekmuk-family.
Sun-series font rarely use in Korean Linux distribution.
ps.
Noto Fonts(Modern Korean All OS default fonts) https://www.google.co.kr/get/noto/
Source Han Sans https://fonts.adobe.com/fonts/source-han-sans-korean
Source Han Serif https://source.typekit.com/source-han-serif/kr/
Nanum-series font https://hangeul.naver.com/font
KoPub-series font http://www.kopus.org/biz/electronic/font.aspx
UnFont(Many of Linux distribution's default Korean font) http://kldp.net/unfonts/release/
Baekmuk Font(Early Linux distribution's Korean default font http://kldp.net/baekmuk/
Change-Id: If5bbcf549cbe96240250e44396dce1ff714c88b8
Reviewed-on: https://gerrit.libreoffice.org/73307
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 0fd3610979a3116ca15377f3450f7794e768d937)
Reviewed-on: https://gerrit.libreoffice.org/73739
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
...which had been broken with edc85fb55f8adc30a1416c6c854c89097060fb21
"clang-tidy performance-unnecessary-copy-init in idl..reportdesign" (and could
cause "Tools - Options... - LibreOffice - Advanced - Java Options" to
erroneously list a single JRE multiple times, instead of listing different
JREs).
Change-Id: I6799903be39a5c6aa601131fad6eab3edea8d9e4
Reviewed-on: https://gerrit.libreoffice.org/73679
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(cherry picked from commit b70ab9e9e5630a965c5e6cc40c2480dddf1e2384)
Reviewed-on: https://gerrit.libreoffice.org/73801
|
|
Regression from 5c23459245f566831383934dd64d19e002bfcfcb
If statement was removed while getOptionsDrawinglayer().IsAntiAliasing()
condition still stands
Change-Id: I33baf1975436d0f917d14bf5df8232dafba92793
Reviewed-on: https://gerrit.libreoffice.org/73762
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit d85499381177bbd050ed85f66f4386d5f41db237)
Reviewed-on: https://gerrit.libreoffice.org/73772
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: Idfb2397e09c5b53214fad1b6fbd4d50b5f0aa87b
Reviewed-on: https://gerrit.libreoffice.org/73797
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
...which changed PyTypeObject in <https://github.com/python/cpython/commit/
aacc77fbd77640a8f03638216fa09372cc21673d> "bpo-36974: implement PEP 590
(GH-13185)".
Change-Id: I687ec38aeda05d0747b9ed08221db75a758bed51
Reviewed-on: https://gerrit.libreoffice.org/73664
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 2bd585f31d7abb066e3f53d9b29c822af20aea69)
Reviewed-on: https://gerrit.libreoffice.org/73778
|
|
The two actually affected functions are SdrEditView::RotateMarkedObj()
and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions
in SdrEditView are safe to be changed the same way.
I expect IsUndoEnabled() can't be changed, though: that would mean there
would be no undo for the text edit itself, either.
If other actions still crash, the pattern is the same: put a breakpoint
on the SdrUndoAction constructor and see the backtrace to find the
function that calls IsUndoEnabled() without calling CanDoSdrUndo() at
the same time.
Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c
Reviewed-on: https://gerrit.libreoffice.org/73669
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 9870ff897f088563426bee9567dd9cb722c2b929)
Reviewed-on: https://gerrit.libreoffice.org/73748
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
To bring back centering of the preview
on the Format Cells dialog.
Change-Id: I2bf1e1dc5cb722c742713d3b245d2b6714976527
Reviewed-on: https://gerrit.libreoffice.org/73740
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
(cherry picked from commit 0d35f8f673ac4e6aa3f1e5f1edc0c6c7a45d2f95)
Reviewed-on: https://gerrit.libreoffice.org/73741
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
In LibreOffice's Korean Hangul part, It check Korean code points only 3 part ranges.
(such as,
U+AC00 - U+D7AF - Hangul Syllables
U+3130 - U+318F - Hangul Compatibility Jamo
U+1100 - U+11FF - Hangul Jamo )
So, add Korean Hangul jamo code point ranges.
such as,
U+A960 - U+A97F: Hangul Jamo Extended-A
U+D7B0 - U+D7FF: Hangul Jamo Extended-B
Below is Korean Hangul Jamo and Syllables code point ranges on Unicode Consortium
Hangul Jamo (Range: U+1100 - U+11FF)
http://www.unicode.org/charts/PDF/U1100.pdf
Hangul Jamo Extended-A (Range: U+A960 - U+A97F)
http://www.unicode.org/charts/PDF/UA960.pdf
Hangul Jamo Extended-B (Range: U+D7B0 - U+D7FF)
http://www.unicode.org/charts/PDF/UD7B0.pdf
Hangul Compatibility Jamo (Range: U+3130 - U+318F)
http://www.unicode.org/charts/PDF/U3130.pdf
Hangul Syllables (Range: U+AC00 - U+D7AF)
http://www.unicode.org/charts/PDF/UAC00.pdf
Change-Id: I65da4d9c6c43e01eb61f2e420faf1ad6cd986d86
Reviewed-on: https://gerrit.libreoffice.org/73309
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d9a31b8e164ad39e8b2f49b8e136cd9108ccac36)
Reviewed-on: https://gerrit.libreoffice.org/73733
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Otherwise
* starting Writer
* "File" -> "New" -> "Spreadsheet"
* switching back to Writer window using Alt+Tab
in Plasma Wayland session results in
Thread 1 "soffice.bin" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0 0x00007ffff7b287bb in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007ffff7b13535 in __GI_abort () at abort.c:79
#2 0x00007ffff7b1340f in __assert_fail_base
(fmt=0x7ffff7c75ee0 "%s%s%s:%u: %s%sAssertion `%s' failed.
%n", assertion=0x7ffff14b0410 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7ffff14b03d0 "/mnt/data/development/git/libreoffice/vcl/source/app/dbggui.cxx", line=46, function=<optimized out>) at assert.c:92
#3 0x00007ffff7b21102 in __GI___assert_fail
(assertion=0x7ffff14b0410 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7ffff14b03d0 "/mnt/data/development/git/libreoffice/vcl/source/app/dbggui.cxx", line=46, function=0x7ffff14b0470 <ImplDbgTestSolarMutex()::__PRETTY_FUNCTION__> "void ImplDbgTestSolarMutex()") at assert.c:101
#4 0x00007ffff0e495db in ImplDbgTestSolarMutex() () at /mnt/data/development/git/libreoffice/vcl/source/app/dbggui.cxx:46
#5 0x00007ffff2026c2f in DbgTestSolarMutex() () at /mnt/data/development/git/libreoffice/tools/source/debug/debug.cxx:91
#6 0x00007ffff4eea765 in SfxBroadcaster::AddListener(SfxListener&) (this=0x555558e61620, rListener=...) at /mnt/data/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:94
#7 0x00007ffff4effe4e in SfxListener::StartListening(SfxBroadcaster&, DuplicateHandling) (this=0x55555a1ebe50, rBroadcaster=..., eDuplicateHanding=DuplicateHandling::Unexpected) at /mnt/data/development/git/libreoffice/svl/source/notify/lstner.cxx:104
#8 0x00007fffbfdff188 in ScTabViewShell::AddAccessibilityObject(SfxListener&) (this=0x555558c27080, rObject=...) at /mnt/data/development/git/libreoffice/sc/source/ui/view/tabvwshh.cxx:215
#9 0x00007fffbf65754a in ScAccessibleDocument::PreInit() (this=0x55555a1ebdb0) at /mnt/data/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleDocument.cxx:1303
#10 0x00007fffbfd12754 in ScGridWindow::CreateAccessible() (this=0x555558c2dd50) at /mnt/data/development/git/libreoffice/sc/source/ui/view/gridwin5.cxx:443
#11 0x00007ffff06ef948 in vcl::Window::GetAccessible(bool) (this=0x555558c2dd50, bCreate=true) at /mnt/data/development/git/libreoffice/vcl/source/window/accessibility.cxx:129
#12 0x00007fffe730f9c6 in lcl_retrieveSurrounding(sal_Int32&, sal_Int32&, QString*, QString*) (rPosition=@0x7fffffffcb90: -12560, rAnchor=@0x7fffffffcba0: -13392, pText=0x0, pSelection=0x0) at /mnt/data/development/git/libreoffice/vcl/qt5/Qt5Widget.cxx:598
#13 0x00007fffe730ff17 in Qt5Widget::inputMethodQuery(Qt::InputMethodQuery) const (this=0x555556c50ec0, property=Qt::ImCursorPosition) at /mnt/data/development/git/libreoffice/vcl/qt5/Qt5Widget.cxx:656
#14 0x00007fffe786c7f7 in QWidget::event(QEvent*) (this=0x555556c50ec0, event=0x7fffffffcef0) at kernel/qwidget.cpp:8993
#15 0x00007fffe730f0d3 in Qt5Widget::event(QEvent*) (this=0x555556c50ec0, pEvent=0x7fffffffcef0) at /mnt/data/development/git/libreoffice/vcl/qt5/Qt5Widget.cxx:466
#16 0x00007fffe782e4b1 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x5555556480f0, receiver=receiver@entry=0x555556c50ec0, e=e@entry=0x7fffffffcef0) at kernel/qapplication.cpp:3726
#17 0x00007fffe7835950 in QApplication::notify(QObject*, QEvent*) (this=0x555555647fe0, receiver=0x555556c50ec0, e=0x7fffffffcef0) at kernel/qapplication.cpp:3485
#18 0x00007fffe851b5a9 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x555556c50ec0, event=event@entry=0x7fffffffcef0) at ../../include/QtCore/5.11.3/QtCore/private/../../../../../src/corelib/thread/qthread_p.h:307
#19 0x00007fffe5bdbf6a in QCoreApplication::sendEvent(QObject*, QEvent*) (event=0x7fffffffcef0, receiver=<optimized out>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qcoreapplication.h:234
#20 0x00007fffe5bdbf6a in QtWaylandClient::QWaylandTextInput::updateState(QFlags<Qt::InputMethodQuery>, unsigned int) (this=0x555555655ab0, queries=..., flags=2) at qwaylandinputcontext.cpp:134
#21 0x00007fffe5bdc433 in QtWaylandClient::QWaylandTextInput::commit() (this=0x555555655ab0) at qwaylandinputcontext.cpp:98
#22 0x00007fffe5bdc4b9 in QtWaylandClient::QWaylandInputContext::commit() (this=0x555555652300) at qwaylandinputcontext.cpp:544
#23 0x00007fffe5bdc4b9 in QtWaylandClient::QWaylandInputContext::commit() (this=0x555555652300) at qwaylandinputcontext.cpp:410
#24 0x00007fffe7833aa5 in QApplication::setActiveWindow(QWidget*) (act=act@entry=0x555556f29a60) at kernel/qapplication.cpp:2088
#25 0x00007fffe7833b53 in QApplicationPrivate::notifyActiveWindowChange(QWindow*) (this=<optimized out>, previous=<optimized out>) at kernel/qapplication.cpp:2182
#26 0x00007fffe7e42ce5 in QGuiApplicationPrivate::processActivatedEvent(QWindowSystemInterfacePrivate::ActivatedWindowEvent*) (e=<optimized out>) at kernel/qguiapplication.cpp:2292
#27 0x00007fffe7e42f1d in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) (e=e@entry=0x555559c186d0) at kernel/qguiapplication.cpp:1838
#28 0x00007fffe7e1d06b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) (flags=...) at kernel/qwindowsysteminterface.cpp:1032
#29 0x00007fffe5bfc6cb in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/x86_64-linux-gnu/libQt5WaylandClient.so.5
#30 0x00007fffe72e9d7d in Qt5Instance::ImplYield(bool, bool) (this=0x5555556c46a0, bWait=true, bHandleAllCurrentEvents=false) at /mnt/data/development/git/libreoffice/vcl/qt5/Qt5Instance.cxx:345
#31 0x00007fffe72e9e8d in Qt5Instance::DoYield(bool, bool) (this=0x5555556c46a0, bWait=true, bHandleAllCurrentEvents=false) at /mnt/data/development/git/libreoffice/vcl/qt5/Qt5Instance.cxx:356
#32 0x00007ffff0ec1a66 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /mnt/data/development/git/libreoffice/vcl/source/app/svapp.cxx:457
#33 0x00007ffff0ec1f89 in Application::Yield() () at /mnt/data/development/git/libreoffice/vcl/source/app/svapp.cxx:521
#34 0x00007ffff0ec185e in Application::Execute() () at /mnt/data/development/git/libreoffice/vcl/source/app/svapp.cxx:438
#35 0x00007ffff7d3dfea in desktop::Desktop::Main() (this=0x7fffffffda80) at /mnt/data/development/git/libreoffice/desktop/source/app/app.cxx:1621
#36 0x00007ffff0edc6c9 in ImplSVMain() () at /mnt/data/development/git/libreoffice/vcl/source/app/svmain.cxx:203
#37 0x00007ffff0edc7ee in SVMain() () at /mnt/data/development/git/libreoffice/vcl/source/app/svmain.cxx:237
#38 0x00007ffff7d977a9 in soffice_main() () at /mnt/data/development/git/libreoffice/desktop/source/app/sofficemain.cxx:170
#39 0x000055555555495d in sal_main () at /mnt/data/development/git/libreoffice/desktop/source/app/main.c:48
#40 0x0000555555554943 in main (argc=2, argv=0x7fffffffddd8) at /mnt/data/development/git/libreoffice/desktop/source/app/main.c:47
Change-Id: I40bf501d07dde0c4610496aa1b2bb2a4051fdf2d
Reviewed-on: https://gerrit.libreoffice.org/73696
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(cherry picked from commit 87238627b025ee6aa61378667e56b1769d4460c2)
Reviewed-on: https://gerrit.libreoffice.org/73725
|
|
We just need AcquireGraphics() to return a KDE5Graphics.
Otherwise the BufferDevice's SVP will use a SvpSalGraphics
instead of the KDE5Graphics, which knows about Qt's theming.
Change-Id: I0ea646df260f2067d61c753f03dee01a003f382a
Reviewed-on: https://gerrit.libreoffice.org/73673
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 2cb6a591b643a0f65dc58f060f60cc707ad3589c)
Reviewed-on: https://gerrit.libreoffice.org/73722
|
|
And use RunInMain for both SalInstances and for both picker types,
as there is no reason to assume just the file and not the folder
picker can be called from the non-GUI thread.
Little drawback is the inclusion of Qt5FilePicker header in the
Qt5Instance header, as Qt's enums aren't forward-declarable.
Change-Id: Ie170d247a76134df9aff835393c71c9d6e907d32
Reviewed-on: https://gerrit.libreoffice.org/73416
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit ca69a1e17782d88580f2449e0252be52c26cae42)
Reviewed-on: https://gerrit.libreoffice.org/73721
|
|
not after dialog async exec begins, but defer to during that response
callback
Change-Id: I316022c01a87cf251d57b1007ae93fefddada776
Reviewed-on: https://gerrit.libreoffice.org/73716
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Uneeded since the merge of most of the KDE5FilePicker code into
Qt5FilePicker. KDE5SalInstance also uses no signals or slots, so
Q_OBJECT + moc can go for them.
Change-Id: If48c677106b78c759ca165563ad3c081ca5442a5
Reviewed-on: https://gerrit.libreoffice.org/73393
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
(cherry picked from commit 81307dd74f26ba5c054dccd32dad507dc1510298)
Reviewed-on: https://gerrit.libreoffice.org/73718
|
|
Change-Id: Ifd689c54574c08f026f6760efb39b5f927cb2625
Reviewed-on: https://gerrit.libreoffice.org/73706
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|