Age | Commit message (Collapse) | Author |
|
The Implementation follows closely EmfPlusRecordTypeDrawString.
For each set of characters with the same PosY a TextSimplePortionPrimitive2D
is created.
Change-Id: I04e4d11dc3c4e1e5bd16aefa8e7f00556aa5282b
Reviewed-on: https://gerrit.libreoffice.org/40716
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I6eeaaf9ca05bed2a908143ae5f4daab6e098799c
Reviewed-on: https://gerrit.libreoffice.org/41199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea
Reviewed-on: https://gerrit.libreoffice.org/41201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I45e0f9a95da20c1a3b6bdf2ac1387b3c14e3dad4
|
|
Change-Id: Ia28463e1c83aa496e8c389d1614f9b8a78100994
Reviewed-on: https://gerrit.libreoffice.org/41209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
(missing external/boost/include/boost/exception/diagnostic_information.hpp had
caused errors with clang-cl)
Change-Id: Ibb84960e5da8fe73cb67aa5ad32a2c249ff921e6
|
|
<sberg> noelgrandin, and is loplugin:deadclass even sound?
struct B { B(B const &) {} }; struct D: B { D(): B(*this) {} };
Change-Id: Idadd379b925aa6f9de6c625bffa8560ec4192ac7
|
|
Change-Id: Id3c56a2c9f8f8813e3bbff4c4ae9156b2185fc9c
Reviewed-on: https://gerrit.libreoffice.org/41206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
unused since commit b3dfb1e807eba91eed35a02d74fe8a917c41ee6f
"loplugin:checkunusedparams in sc"
Change-Id: I53ac9e281a93651259eb39a145acbb89613d3e04
Reviewed-on: https://gerrit.libreoffice.org/41205
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...introduced with aeb3853a21435f00f225d751e56184e875bc46ed "osl: (Win32) check
allocated pipe succeeded, otherwise needs to fail"
Change-Id: Ieeb0b1755e74f583d1b52447eb84f7512eb07914
|
|
Change-Id: Idf4ab2d4d2550a02c0c50a981d94c67b111082a9
Reviewed-on: https://gerrit.libreoffice.org/41204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5d66024024b8150fad67397a0debc40aab1ae5fc
Reviewed-on: https://gerrit.libreoffice.org/41200
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
The format used is column orientated and allows quick import and
export of the table content. This will be used for the external data
to cache the results of each transformation step in the UI.
Change-Id: I6e1bfd3b3384cbfadeb98fb995dfd0b03d5e6eb6
Reviewed-on: https://gerrit.libreoffice.org/41198
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Id31c8de69043d393f005f83d5c7eba878af5119c
Reviewed-on: https://gerrit.libreoffice.org/41149
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I594581ce388221760554f6272ee3af761f172c05
Reviewed-on: https://gerrit.libreoffice.org/41197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: If253b2ff2b4f38ba45a2be7f66dfbcb65ed9be74
Reviewed-on: https://gerrit.libreoffice.org/41196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
To enable finding the source of the duplicate calls, I add new SAL
API (only for internal use) to retrieve and symbolise stack
backtraces.
The theory is that it relatively cheap to just store a backtrace,
but quite expense to symbolise it to strings. Note that the
backtrace() library we use on Linux does not do a particularly
good job, but it gives enough information that developers can use
the addr2line tool to get more precise info.
Explanation of fixes in the code that triggered the assert:
In SwFrameHolder, we need to only call StartListening() if the
pFrame member is actually changing. We also need to call
EndListening() on the old values when pFrame changes.
In SwNavigationPI, there is already a StartListening() call in
the only place we assign to m_pCreateView.
In ImpEditEngine, we need to ignore duplicates, because it is
doing a ref-counting thing. By storing duplicates on the listener
list, it doesn't need to keep track of which stylesheets its
child nodes are using. Given that it therefore will see
duplicate events, there is probably some performance optimisation
opportunities here.
In MasterPageObserver::Implementation::RegisterDocument, we
seem to be getting called multiple times with the same
SdDrawDocument, so just check if we've been registered already
before calling StartListening()
In SvxShape::impl_initFromSdrObject, do the same thing we do
elsewhere in this class, i.e. only call StartListening()
if the model has changed.
Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac
Reviewed-on: https://gerrit.libreoffice.org/41045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iff2b184b8764e459165b7254b32d7ffb810fb3db
|
|
Change-Id: I598b600ca93d86c4c0bc433ae9432ccd7f264192
|
|
Change-Id: Ie1948c87fd790184fd556617384b1824f85e81ec
|
|
Change-Id: Ide78daefced91fff2efeeb25dace6f722acfa3e9
|
|
Change-Id: I727d50ce4725f10efbeaedd70ed961e726f99a5e
Reviewed-on: https://gerrit.libreoffice.org/41190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If098b44d2627d86795cea4e4211d357d1a562dba
Reviewed-on: https://gerrit.libreoffice.org/41176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
...after 5aab2900dfdc9f12adda378470149670a2a069df "tdf#109142: Update to
HarfBuzz 1.4.8". The parts that were still relevant for 'make check' are:
* 6694ce6b542367074667e4445a6b7f50568a2729 "external/harfbuzz: Work around ASan
out of bounds warning"
* 99f7aacd5b39a0f79351d8d7568b2e43d39878cb "external/harfbuzz:
-fsanitize=function"
* ca9a08bbf7d42727a93b5f725784308a3590c0fe "external/harfbuzz: Silence
-fsanitize=nonnull-attribute" (plus 83a9c8e046dfcaccdb1114ec5a386a11fcca3a02
"build fix")
Change-Id: Ibff2a7c52c5de60ae00744acd2ef481bbb08706c
|
|
To test: make CppunitTest_writerfilter_rtftok
These crash triggering instances were hidden by the presense of \super
in topcontext-2.rtf - so I copied it, and only removed \super.
My fix for tdf#109382 triggered a unit test failure for one
missing m_xTextFactory. It seemed safe enough to test for all of them
that aren't in try/catch blocks, not just for the specific
instance I can prove with the test.
Change-Id: I1e317e05f9bcbbb14360941ce07af1bdf0edac6a
Reviewed-on: https://gerrit.libreoffice.org/41060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
\htmautsp changes the meaning of \sbauto and \saauto, but the auto
keywords may appear early in style definitions before \htmautsp arrives.
This wasn't a problem before commit
1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF
import: override style properties like Word, 2014-06-17), as there the
right auto keyword interpretation was repeated as direct formatting.
So fix the regression by not deduplicating these keywords, which brings
back the correct layout. A larger rework is necessary in the future to
delay the parsing of the stylesheet table, that would be a cleaner
approach.
Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c
Reviewed-on: https://gerrit.libreoffice.org/41187
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
The first field isn’t editable, so show it visually. Make the actual
editable box have the default focus. Drop the unnecessary heading.
Change-Id: Icf0d5fc3ddb9b9af6d04045899d9e8476a217bba
|
|
Change-Id: Ie7cc004e02e3bb1ac8d52a9c0b67b9fa9f946c8c
Reviewed-on: https://gerrit.libreoffice.org/41167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Ia4cf7a5382a05061ff98f423cf5640a51015236d
Reviewed-on: https://gerrit.libreoffice.org/41182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
If there are parents, they are necessarily different pointers for
different pools; the only sensible way to compare them is by-value,
which is a bit tricky because the items overwritten in the child
should of course be ignored.
Rather than rewrite the whole function, just ignore the parents for
now, because this comparison is currently used to replace compares
of the serializations of item sets, and SfxItemSet::Store()
completely ignores the m_pParent, so this looks like the best
replacement.
Change-Id: I0a4bf44d4fef49e47a3ec78bc7d977a6fcbd789d
Reviewed-on: https://gerrit.libreoffice.org/41186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I381626d80470db18044d517c2c8bb76b2bc6a829
Reviewed-on: https://gerrit.libreoffice.org/40879
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
|
|
As seen on exporting rhbz739243-1.odt, the xGraphic is null in that case.
(regression from 4469b29faeb8dbf7793a5d81d9c5ddebacf3015f)
Change-Id: I535d67eeddc1b9bdf2562fc3b54a97e38ab0354c
|
|
Change-Id: Ic8fa88f1e471fe3eab965e5f0106de0348e62ec0
Reviewed-on: https://gerrit.libreoffice.org/41161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
|
|
* libgpg-error has some fixes around autogen & win32 critical sects
* gpgme has a few nice additions around keyinfos
* update lib versions to deliver
* remove external/libgpg-error/fix-autoconf-macros.patch -> this is
upstream now
Change-Id: I5a58ac15a485621c54ca1c7a768268e8a541256c
Reviewed-on: https://gerrit.libreoffice.org/37926
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I3ec06e9a196897c095f227e9f765243c6c188898
Reviewed-on: https://gerrit.libreoffice.org/41185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
they are KDE3 only and we don't support either KDE3 nor TDE anymore
anyways
Change-Id: I80198c2b63298c0bb3220f3641b6e45107797426
Reviewed-on: https://gerrit.libreoffice.org/41159
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
|
|
I have no idea why the original implementation used ++nLines
when setting aDrop.Lines. Unchanged since mass import from OOo in
2008 commit 614f53dda31f14fe89303dc1809fc29350c1ba29.
Change-Id: If427dcea815e91d2cccb2c11044cdb393bff09e3
Reviewed-on: https://gerrit.libreoffice.org/41184
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I6a8fe2476adc5c4379c76dfaef090d1b5cd81ea0
Reviewed-on: https://gerrit.libreoffice.org/41170
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
|
|
Split output by chapters. The index is still basic, just "Section N"
entries so far.
Change-Id: I4db659ee4110ab30f4b75f44c41f958533ddad7f
Reviewed-on: https://gerrit.libreoffice.org/41177
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Regression from commit 528632660b72b105345945c13c5b68060d94a91b
"convert ErrCode to strong typedef"
Why this is necessary I don't know. Only the change in ehdl.cxx is
necessary to fix the reported bug, bug fixing the other one too because
it operates in the same way.
I know that the other arrays that get passed here look like:
{ NC_("RID_UUI_ERRHDL", "....."),
ErrCode(sal_uInt32(ERRCODE_UUI_IO_ABORT) & ERRCODE_RES_MASK) },
but RID_ERRHDL in svtools/inc/errtxt.hrc does not, it looks like:
{ NC_("RID_ERRHDL", "...."),
ErrCode(ERRCODE_SFX_MACROS_SUPPORT_DISABLED) },
I'm guessing that somehow before my conversion somehow the code was
stripping the top bits off the error codes?
And why we need to strip the top half of the error code off at all is
also a mystery.
Change-Id: Iebca026ddf80e24ed74802410693adf90ea36047
Reviewed-on: https://gerrit.libreoffice.org/41172
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifa8e01542ed0e7d72bfc9684f36b6dee9e185df4
Reviewed-on: https://gerrit.libreoffice.org/40645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
<sberg> noelgrandin, 718cdd43c25783d9cd402e381123efe3981cc514 now also
looks through typedef sugar, e.g. complaining about a gdouble -> double
expl. conversion in configmgr/source/dconf.cxx;
I think we want to remain silent about such conversions involving typedefs
<noelgrandin> sberg, ah, good point.
Change-Id: Icbb0d6be273f53e507c91556cf0ccb5a5c03e5a1
Reviewed-on: https://gerrit.libreoffice.org/41175
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibc93277c71e51709d56345e8934f045c60d322ca
Reviewed-on: https://gerrit.libreoffice.org/40914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
|
|
In the enum types that caused the problem look like this when I dump
then:
EnumType 0xdb45770 'enum SvxFrameDirection'
`-Enum 0xdb456d8 'SvxFrameDirection'
SubstTemplateTypeParmType 0xdb61200 'enum SvxFrameDirection' sugar
|-TemplateTypeParmType 0xd7518f0 'EnumT' dependent depth 0 index 0
| `-TemplateTypeParm 0xd7518a8 'EnumT'
`-EnumType 0xdb45770 'enum SvxFrameDirection'
`-Enum 0xdb456d8 'SvxFrameDirection'
Change-Id: Id8fedabe43b7a27df61a2320a9acbf54d2dc7882
Reviewed-on: https://gerrit.libreoffice.org/41169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Project: help 319e2f6b226de998f9945a2325deb608ce1b20a0
tdf#111777 correct help page for named ranges
Scrolling suggested named ranges is done with Crtl+Tab keys
Change-Id: If57beb17528a291e7b08f768378d15c67f1149d9
Reviewed-on: https://gerrit.libreoffice.org/41125
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
|
|
Project: help c9fc9a65717e174477d11ae4b5d13dfae17848a3
tdf#111651 'Styles and Formatting' -> 'Styles'
Change-Id: Ic4db58aa04d21c514987cdbeaed5d11292d79b85
Reviewed-on: https://gerrit.libreoffice.org/41103
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
|
|
Should fix the Tibetan long U issue.
Also reverts this commit as depending on auto-detection for a required
feature is not a very good idea. The underlying issue is fixed upstream:
commit 5985bed1764358a515c378c80bb60b4d35bad6b1
Author: jan Iversen <jani@libreoffice.org>
Date: Mon Jun 12 14:51:42 2017 +0200
iOS, harfbuzz libcoretext not found
changed --with-libcoretext
from "yes" to "auto" for IOS and MACOSX
which seems to be a misguided attemp to fix the build breakage
introduced in:
commit b3559e5c6ce036b1a4fe96c0ffc935e0c94a7b10
Author: jan Iversen <jani@libreoffice.org>
Date: Sun Jun 11 19:35:53 2017 +0200
iOS, patch harfbuzz
Add support for arm64
Also had to drop ubsan.patch as it no longer applies, hopefully it is no
longer needed, otherwise it is always good idea to submit such patches
upstream.
Change-Id: I91643c542c0a5a00f36d5564052787eedef8c9cf
Reviewed-on: https://gerrit.libreoffice.org/41124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8b20ce6b58915c37e6d4caa11d2f4c724864a257
|
|
Characters under <text:span> (and not only under <text:p>) are now
handled.
Change-Id: Iac353005423d65f446b9f93519957f4caeaf1c7a
Reviewed-on: https://gerrit.libreoffice.org/41164
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I2b79ae40afad8c392f219f1798ce44b41649e5b9
Reviewed-on: https://gerrit.libreoffice.org/41163
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|