summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-08-29Fix some variable scopes and clarify namesJan-Marek Glogowski
Helps understanding the code, especially CheckPageDescs(). Change-Id: I53e7d0ea65d6c6ae3da98acba4d366a47d2c4210
2016-08-29Don't re-check valid SwPageDescs when layoutingJan-Marek Glogowski
nCheckPageNum is set to USHRT_MAX, if all SwPageDesc were checked. Code manipulating SwPageFrm objects checks the pages via CheckPageDescs(). If this is currently forbidden, CheckPageDescs() sets nCheckPageNum to the first page to check. I guess the !pPage check is there to check the pages - at the end, if someone has missed the CheckPageDescs call. And we have to run the check, if the current page is unchecked AKA pPage->GetPhyPageNum() >= nCheckPageNum to do correct layouting. Change-Id: Ib67878115cde04b7161c919a67131a1e1dc67d8d
2016-08-29Remove now unused SwTextBoxHelper functionsJan-Marek Glogowski
Change-Id: I39500424c79040b1887ea74081fdf0ea0bc5f009
2016-08-29Add convenience function getOtherTextBoxFormatJan-Marek Glogowski
Since we already have isTextBox to identify a text box, this just adds a call to SwFrameFormat::GetOtherTextBoxFormat() to actually return the corresponding SwFrameFormat. This gets rid off all the remaining occurences of the SwFrameFormat / Textbox sets and maps. Change-Id: Id5f05a1ff71e604658e7d8a0d0825f5671335b3f
2016-08-29Switch isTextBox to use the format pointersJan-Marek Glogowski
This replaces all possible occurences of the text box format maps, which just want to know, if a SwFrameFormat is part of a text box to use the direct lookup via the isTextBox, which is now a cheap call. Change-Id: I3b4e2301f816aead1b719cd70a8ef118e685ccfc
2016-08-29Link DRAW and FLY format for faster textbox lookupJan-Marek Glogowski
Currently we have to rebuild the list of text boxes for every lookup. Instead of a managed set, or a per-document list etc., this introduces direct pointers between the corresponding SwDrawFramFormat and SwFlyFrameFormat of a text box. Change-Id: Iefba2d153d9d8b3f1185aa305e9f463a50e78f89
2016-08-29Don't inheritate from boost::multi_indexJan-Marek Glogowski
Drops all using statements and the namespace aliases. This is more in the spirit of tdf#75757. Change-Id: Id7c81baea0e2d1af151b7b9bdce8d9fe5f7a2089
2016-08-29Convert SwFrameFormats to boost::multi_indexJan-Marek Glogowski
This is almost the same situation as SwPageDescs. What makes this more complicated is the fact, that actually duplicated draw objects are allowed, in regard to the key values "type" and "name". And actually for some types, duplicate names are not allowed, e.g. SwDoc::FindFlyByName( const OUString& rName, sal_Int8 nNdTyp ) expects a single result! Change-Id: I6e0ea1099c1c1e6cfe90926170e27179722e88b8
2016-08-29Convert SwPageDescs to boost::multi_indexJan-Marek Glogowski
Page descriptions are exported via XIndexAccess, so they need a stable array, currently a vector. On the other hand they are referred by a unique name, so the lookup in the unsorted array is O(n), not taking into account the amount of string comparisons. The multi index container adds an ordered unique index, which gets the lookup time down to O(log(n)) at the cost of a bit more management overhead for most operations, which is largely outweighted by the amount of lookup calls. These anyway have to be done on insert to guarantee the unique naming. Change-Id: I3fb892ff524f6a9804d9572c1825074c0810649e
2016-08-29Fixup clang Werror boost build on MacOSXJan-Marek Glogowski
Fixes the Boost::Tuple header used by Boost::MultiIndex. Change-Id: I98eb047e699e04934ee09323633e28cecef84e70
2016-08-29Toolbar popups need explicit deactivationMaxim Monastirsky
... if based on MenuBarManager, because unlike context menus, we reuse the same menu instead of creating from scratch each time, so that it suffers from the same "double activation" problem as in tdf#97665. Note that for GtkSalMenu the problem is only for the top level popup menu, as the Deactivate callback is properly called when sub menus are closed. The non-native case also had this problem, but only when closing the menu by selecting one of its items, and was fixed already in b41deb2ef057c3bd43fa61448bb4d7299138c8d4. Change-Id: Iee037f7baba0f80c32fb3a45f16511f8585c203e
2016-08-29Resolves: tdf#95162 Hung is RTL/CTLEike Rathke
Change-Id: If408305564b1fddbef371f32d2b91b6a1e44a2b0
2016-08-29tdf#101589 MS export: use dont-split-row for 1-row tableJustin Luth
.doc and .docx do not have a setting for "do not split table" so it was being emulated by "keep paragraph with next" for all but the last table-row. That means that a single-row table with lots of content might be split. There is a setting to prevent a row from splitting, so use that instead in this corner case. It needs to be separate from the other function in order to be set in time for docx to write w:cantSplit w:val="true" before the row contents. For some reason it did not work to move the whole function here. Change-Id: Idc11626e0e2cf1706b87a83f2bd4a802348cb633 Reviewed-on: https://gerrit.libreoffice.org/28352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-29coverity#1371317 avoid unnecessary copiesCaolán McNamara
and coverity#1371211 Change-Id: I65e277c4af70a86f1513749de4eb116d929e858f Reviewed-on: https://gerrit.libreoffice.org/28448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-29sw: prefix members of SwHTMLForm_ImplMiklos Vajna
Change-Id: Ifecf64e10833e2ede87e304db095c2480db64c81 Reviewed-on: https://gerrit.libreoffice.org/28452 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-29tdf#43157 Clean up OSL_ASSERTdrazil
Clean up OSL_ASSERT in basegfx/source/tools/b2dclipstate.cxx Change-Id: I4107980aa079b0e0e8605de34ecfd01587647af6 Reviewed-on: https://gerrit.libreoffice.org/28417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-08-29cid#1371230 Missing move assignment operatorNoel Grandin
Change-Id: Ia58dda7eaadf6a91b7af67e011a6f44a4e7a3c0b
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29Emit notification to a LibreOfficeKit client also when a redline is modifiedTor Lillqvist
Work in progress, not all modifications to a redline record cause notifications yet. Change-Id: I01614cd6ede9576e9cc329889fef86342567325f
2016-08-29TypoStephan Bergmann
...(ever since c5bcf0e5e7a467b41c955a5f13affbccd23004eb "convert sw pos/size page to .ui"), leading to out-of-bounds reads, but which should be harmless, as all they could do is add bad StringIds inot aFrames, but the only use of those IDs in SvxSwFramePosString::GetString (svx/source/dialog/swframeposstrings.cxx) guards against bad IDs. Change-Id: I7a50230c12bcf8a197f787201442c503fe5974e7
2016-08-29cid#1371168 Missing move assignment operatorNoel Grandin
Change-Id: I986b94df4aa8158f3e0623ab6cb392c178a820ce
2016-08-29cid#1371235 Missing move assignment operatorNoel Grandin
Change-Id: If5fc8d783211a131711b5961d6b076c24dd64412
2016-08-29cid#1371170 Missing move assignment operatorNoel Grandin
Change-Id: Iaf02d5bd3090190b6b9ad15a884d3f0444983297
2016-08-29cid#1371176 Missing move assignment operatorNoel Grandin
Change-Id: I57df53df6933e1945fabc0e4a7f0e1c5815aeaca
2016-08-29cid#1371144 Missing move assignment operatorNoel Grandin
Change-Id: Ice8c22324700d51b86696fc3df140bb9f84973cb
2016-08-29cid#1371163 Missing move assignment operatorNoel Grandin
Change-Id: Ie050cfae965adf7bc43c91f366904cf6876783c0
2016-08-29cid#1371173 Missing move assignment operatorNoel Grandin
Change-Id: Idf179403426d9714fa73d0c3370a6debc30a0431
2016-08-29cid#1371154 Missing move assignment operatorNoel Grandin
Change-Id: If434a0ee5c97018777646c96f52ddded46ce0337
2016-08-29cid#1371171 Missing move assignment operatorNoel Grandin
Change-Id: I3150428f130823cdb1584e30c54f5591896214cf
2016-08-29cid#1371160 Missing move assignment operatorNoel Grandin
Change-Id: Ifcddd08cd1ec6bfb7679ee0433524c4bd68803dd
2016-08-29cid#1371253 Missing move assignment operatorNoel Grandin
Change-Id: Ic95894569380927da5dbd9aba4844f17bbbf25f6
2016-08-29cid#1371241 Missing move assignment operatorNoel Grandin
Change-Id: Ic914ac2ed5fb48cf340f2e54d074ee64e202225e
2016-08-29cid#1371256 Missing move assignment operatorNoel Grandin
Change-Id: Idf50c8f56e1d409fbd1306ee0fec20360bf99c86
2016-08-29cid#1371188 Missing move assignment operatorNoel Grandin
Change-Id: I775db6b3c9db0847184f12fad778a1fc3fcd92eb
2016-08-29cid#1371206 Missing move assignment operatorNoel Grandin
Change-Id: Ide97adea0bc0611dac676df923796d031d6752e5
2016-08-29cid#1371226 Missing move assignment operatorNoel Grandin
Change-Id: I915b24d8f546f156b85ad18ad0418903fa3ce1ba
2016-08-29cid#1371209 Missing move assignment operatorNoel Grandin
Change-Id: Ib383d2a12ac13a78f4ecf6817379ebbe0dc83194
2016-08-29make the SfxObjectShellLock inline code a little more readableNoel Grandin
Change-Id: Ia312f3bf588c7987ee6956ab2675e73b7d9db6a4
2016-08-29cid#1371187 Missing move assignment operatorNoel Grandin
Change-Id: Ib0b51a029adcb0b703aa975b6c5fc02a8b21ed63
2016-08-29cid#1371223 Missing move assignment operatorNoel Grandin
and cid#1371216, cid#1371179 Change-Id: I64faaada85cc92a8b47c2a665488f07050be6fc3
2016-08-29loplugin:vclwidgetsStephan Bergmann
Change-Id: Icce2f463d9263de4c0e40b38600677dbe74d83b3
2016-08-29tdf#93329 : Fixes FTest algorithmic bugDennis Francis
Also added tests for FTEST() with reference results from Octave that covers a reasonable range of variance ratios. References : 1) Octave-Forge : https://sourceforge.net/p/octave/statistics/ci/default/tree/inst/vartest2.m with head = f8f3ede1f4e9576f0e05700d7bed0b3f2753e9c5 2) R-project : https://github.com/wch/r-source/blob/trunk/src/library/stats/R/var.test.R From read-only mirror of R source code from https://svn.r-project.org/R/, updated hourly. branch : "trunk", head = d48a3960875fa373e1e68286245ee8e1bc7ac0fd Change-Id: Icc843be3a1497e4d69e8b39b31c4b6998594dfe9 Reviewed-on: https://gerrit.libreoffice.org/26482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-08-29Make SvXMLTokenMap compatible with FastTokens:Mohammed Abdul Azeem
Added seperate map for fastToken and Token, to get token using only fastToken. Default values are derived for fastTokens from prefixKey and localName. Duplicate/ dummy tokens need to be overidden with different values. Change-Id: I17268754d8fd1bac29dd7bae05706ff20b8314ae Reviewed-on: https://gerrit.libreoffice.org/28415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29BASIC : Remove useless SbxBase::GetCreatorArnaud Versini
Change-Id: I3d9aa358ffaefc11b7d2427f2b567c360be2c667 Reviewed-on: https://gerrit.libreoffice.org/28434 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29loplugin:unreffunStephan Bergmann
Change-Id: If65f8ef5accad8d6317b07938ec97c7b129763b5
2016-08-29Updated coreOlivier Hallot
Project: help 32e04637f0cdf7f44b17c83fb78f66752430ab41 tdf#80652 Help file for CMIS remote servers Also * User guide for using remote files * Check-in, check-out * Setting up a remote file service Linguistics/typos and overall contents accuracy fixes welcome. Change-Id: I7779e4bde91c1d304d87de083e76c64309c13992 Reviewed-on: https://gerrit.libreoffice.org/28277 Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk> Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-08-28silence coverity#1371316 operator= is equal to default, so unnecessaryCaolán McNamara
Change-Id: I9b301b6f661732ce4f6e9010324aa0a828736b50
2016-08-28add ODF schema files to core repoThorsten Behrens
Source: https://tools.oasis-open.org/version-control/svn/office/ Please no changes to those files, these are the official, blessed, OASIS-approved standard schemas, in their respective version. Change-Id: I8538495fe7d9ece0c4e3ad097460a5f41ee7a403
2016-08-28BASIC: Devirtualize SbiExprNode::~SbiExprNode and make SbiExprNode finalArnaud Versini
Change-Id: I95581265e2cc7befc00e67d42b6516d49c794680 Reviewed-on: https://gerrit.libreoffice.org/28438 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-08-28Silence "non-nillable property without value" warningsMaxim Monastirsky
Change-Id: I8135dde19023754dac506334ed576daba68b9365
generated by cgit (git 2.34.1) at 2024-08-18 08:07:55 +0000