summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-03-07xmlsecurity OOXML export: remove signature relation with the last signatureMiklos Vajna
The signature relation refers to _xmlsignatures/origin.sigs, but that's not written when all signatures are removed. Change-Id: I5ee1c8849962cba4b338e6f43243bcf89aedad36
2016-03-07xmlsecurity OOXML export: don't write signature relations when all ...Miklos Vajna
... signatures are removed. With this, the _xmlsignatures/ sub-storage inside the document is empty when all signatures are removed. Change-Id: I391bd1d3b6fdb724952a7158a043b1e602d532a9
2016-03-07xmlsecurity: extract final signature export logic from DigitalSignaturesDialogMiklos Vajna
To be able to unit-test this later without creating a vcl dialog. Change-Id: I4794e212ffefc2efa3bddaf58e6c6bf2a4ea8d9a
2016-03-07gtktiledviewer needs gtk3 not gtk2Caolán McNamara
Change-Id: Iede2008139cb570ff65202762e92f6694548a065
2016-03-07return early and drop elseCaolán McNamara
Change-Id: I4887f01c94e6d7d716d2a074d503fca505a4aff8
2016-03-07-Werror=unused-but-set-variableStephan Bergmann
since b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 "loplugin:write only fields" Change-Id: I610e88373ebca576e5607b224ad648c1d3e47bab
2016-03-07!(==) -> !=Caolán McNamara
Change-Id: Ie1c3c61dea2052e85179157e3e0b6c07dd60bb48
2016-03-07loplugin:write only fieldsNoel Grandin
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Id895d61c0bbea99379bb6e9b4e6d6c54da4c98db
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07disable means Enable(false), not true.. tdf#98389 relatedEike Rathke
EnableAdjustHeight(true) lead to the side effect that when clearing the range of a pivot table during import, formulas in the same rows were recalculated with then empty data. Through xSheetOp->clearContents() in PivotTable::finalizeImport() of sc/source/filter/oox/pivottablebuffer.cxx In the case of the bugdoc attached to tdf#98389 that lead to all VLOOKUP() calls resulting in #N/A errors because an empty string was looked up. Change-Id: Ie629ce871d255cc871671165c4da974f21041cec
2016-03-07Resolves: tdf#98389 check memory requirement of matrixEike Rathke
Attachment 123203 of tdf#98389 has external references of the form [1]Data!$1:$1048576 which effectively address the entire cell range of sheet Data and allocating a matrix for a billion cells attempted to allocate 8GB+xGB of memory which the system said no-no ... Some brave soul along the road once decided that a check on the number of elements wasn't needed anymore and dared to remove it during refactoring.. This change reintroduces the check and adds it also to other places that try to instanciate or resize a matrix. When allocation of a matrix for an external range reference fails it is checked whether the request is for such nasty entire rows or entire columns ranges and if so tries to shrink the range to the actual data area used, which at least in this case helps and works. Additionally it fixes a long standing bug in the cached area to array mapping which caused the cache to not be hit but instead the matrix was aquired over and over again for the same range, causing a serious performance bottle neck specifically for VLOOKUP and related functions where the same external range is used in a lot of cells. Change-Id: I35f67b48e665bf1cc8d672325c32b889f2e05c57
2016-03-07Resolves: tdf#96172 crashtesting: avoid crash in layoutCaolán McNamara
sectfrm is riddled with workarounds for "half dead" section frames. This is yet another one. Change-Id: Ic03ad8971002d7dce308475f1497d1dda8045d15
2016-03-07tdf#65219 Fix temp files clean up in sc unit testsAleksas Pantechovskis
Change-Id: I23bf5d47c2cce31d6dd076eeac58cb2ce47b248a Reviewed-on: https://gerrit.libreoffice.org/22953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07convert DEFINE to anonymous functionCaolán McNamara
Change-Id: I9b62f02ac0013d1da13c176155c5742972a43fe3
2016-03-07OSL_ENSURE followed by deref -> assertCaolán McNamara
Change-Id: Ib815da2f341096775052d2280d62a210a856fdf8
2016-03-07upgrade neon to 0.30.1Caolán McNamara
Change-Id: If84ce83cdbde530f7a6743c93ae210b030a41c30 Reviewed-on: https://gerrit.libreoffice.org/22977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-07basic: tdf#87530 if a new password is set, must set mbLoadedSource flagMichael Stahl
... so that the library is stored (and encrypted), and not copied unencrypted from source storage. Change-Id: I9546087ec6f07007aa1ec377d2e959f2bae99a38
2016-03-07basic: tdf#87530 don't copy storage that doesn't existMichael Stahl
If the Basic library is newly created it may not have been stored to the document storage yet. (regression from 5246fa262450f686674850c53df666422f441c86) Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8
2016-03-07Make detection of HAVE_CXX14_CONSTEXPR work with "selective debugging"Stephan Bergmann
...where "make ... debug=t" is used to build some parts of LO with debug enabled without re-running autogen.sh (so NDEBUG will start to be undefined, so constexpr functions calling assert will start to trigger GCC PR66460). See mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-March/073554.html> "Compiler crash when building libreoffice with debug." Change-Id: I6e3c0375c1e5843616fb9fe287d0bf5ee40e64f7
2016-03-07Resolves: tdf#98425 gtk3: grab the SolarMutex when setting the clipboardCaolán McNamara
Change-Id: Ic439affbd69532534f5caf82a743786d5975939e
2016-03-07lwp: fix infinite recurseCaolán McNamara
Change-Id: Ibd17c0f68a9bac92e591fd2c998de45a84b372aa
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07tdf84938 Replaced Sb_Attr_ defined constants with enum class in runtime.hxxSteven Guo
Replaced the #define Sb_Attr_* constants with SbAttributes enum class in runtime.hxx and adjusted uses in methods.cxx. Change-Id: Ic7f6f6452849ffc9675ffd697ffc130276082318 Reviewed-on: https://gerrit.libreoffice.org/22948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07libxmlsec: move new files back to xmlsec1-customkeymanage.patchMiklos Vajna
That was the situation before commit ec6af4194e80f5f0b2e46ca59802ff397a2a4a24 (convert libxmlsec to gbuild, 2012-11-29), and if we ever manage to upstream this patch, then it'll just make the review process harder if half of the patch is in separate files. Change-Id: I0d12d72ea7a1a2591d1ef5232c006b6b7fea7aff Reviewed-on: https://gerrit.libreoffice.org/22973 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-07SVGIO: tdf#97539: clip-path elements might contain...Xisco Fauli
reference to other clip-paths Change-Id: I3722b31cefa4df6225e369b3d1db9f46be5933ff Reviewed-on: https://gerrit.libreoffice.org/22956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-07tdf#97538: SVGIO: Add unittestXisco Fauli
Change-Id: I5bf523ac532ad19a005d99e19deb1e0ec9ce96e4 Reviewed-on: https://gerrit.libreoffice.org/22955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-03-07fix build, this time for realDavid Tardon
Change-Id: I9dbaedc6b4427399618261cac35b2ab9caddc54e
2016-03-07fix buildDavid Tardon
Change-Id: I372e87f94b52c9880662573a56f28b07fede7d8d
2016-03-07fix buildDavid Tardon
Change-Id: If6e42d519187990b27fbf15f22d600af86d952f0
2016-03-07drop removed templates from the listDavid Tardon
Change-Id: I3017a5904569d9f773d3c69cb6aa27f860b8b2a8
2016-03-07expand src templates only used in a single placeDavid Tardon
Change-Id: I0af62539f9dfe636eb242acd766559ffe1097217
2016-03-07expand src templates only used in a single placeDavid Tardon
Change-Id: If10e2fb1448867e79df3ddc962f93b904af94b3d
2016-03-07expand src templates only used in a single placeDavid Tardon
Change-Id: Ic18e4c0a1617f0284b7ffcfb8859cdced4949471
2016-03-07Bin overly verbose OSL_TRACEs of questionable usefulnessTor Lillqvist
Change-Id: Ic535aef31c2a8d73f9c496ffdc535494c15d3c12
2016-03-07Bin overly verbose function entry/exit debug print macrosTor Lillqvist
Change-Id: Icdbb9344a669e5f78d5db85dc555e91a56ded34c
2016-03-07tdf#96099 Reduce number of trivial typedefsChirag Manwani
Change-Id: I39e9fcfdf2203239ac56d1c8195ca7ac07054817 Reviewed-on: https://gerrit.libreoffice.org/22898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07fix typo getSupportedPlaforms -> getSupportedPlatformsDouglas Mencken
Change-Id: I6adecfc0475b3c93a538874515be478efb733fae Reviewed-on: https://gerrit.libreoffice.org/22968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07starmath: Make SmNode abstract and noncopyableTakeshi Abe
... and remove unused SmStructureNode's copy ctor/assignment operator. This seems desirable according to the old comment in SmNode::Accept(). Change-Id: Ifb51c64ca784f1295374d31cc210cbe3e45aa2f8 Reviewed-on: https://gerrit.libreoffice.org/22801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-03-07opengl: fix loading shader with preamble that uses #versionTomaž Vajngerl
The preamble was inserted into a false position so the shader could was constructed incorrectly and would fail to compile. Change-Id: I4c51adde9014a326bbe38a5d2d17dd0047e33195
2016-03-07opengl: fix inv.scale values are always integer - cid#1352479Tomaž Vajngerl
Force cast to double to avoid integer division - which gives a wrong inverse scale value. Change-Id: I0135e44ef07f3915619f9dfead9aadf50fc03685
2016-03-06coverity#1326576 Useless callCaolán McNamara
Change-Id: I1d51b96042f229de42ed26d90ecc2a070eb5b3a6
2016-03-06coverity#1355250 Logically dead codeCaolán McNamara
Change-Id: If5a07e11cf63d0dbb83853fce48b2eb7b458663b
2016-03-06coverity#1355253 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib89a7e44562b6bf8a8ae41e71e3d91ad5569b8d1
2016-03-06bIsExpanding is unusedCaolán McNamara
Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
2016-03-06coverity#1355252 Uninitialized pointer fieldCaolán McNamara
Change-Id: I34c5565adcfd3fd39f9b03967e5c4272767a58ea