summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-06update precompiled_rptui.hxxCaolán McNamara
Change-Id: Iaef795ee48f590ed2cd0ba1c47dcc703172d8677 Reviewed-on: https://gerrit.libreoffice.org/73597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06weld HeaderFooterDialogCaolán McNamara
Change-Id: I6a5068106d0f243646cf12ec676dff60a04922ee Reviewed-on: https://gerrit.libreoffice.org/73596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06duplicated about dialog close button when headerbars not enabledCaolán McNamara
Change-Id: Idd69b37ff0dc85dc96349c4e85fc5d4a93597e62 Reviewed-on: https://gerrit.libreoffice.org/73601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06tdf#125324 table export: do not ignore default valuesPatrick Jaap
It seems like Writer default values for table positioning differ from OOXML spec. if nothing is given. So write them anyway during export. Change-Id: If5bf77de71b457a826be8f1559212e7d06c5237c Reviewed-on: https://gerrit.libreoffice.org/73402 Tested-by: Jenkins Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
2019-06-06CoreTextStyle::mbFauxBold shall presumably be boolStephan Bergmann
...it was added as float with eb5606511fac2a8ee1af7cc03c12d6c5b16f7c96 "tdf#101854 Move to CommonSalLayout removed faux bold in macos", but that causes loplugin:implicitboolconversion warnings, and was probably just a typo. Change-Id: Ib35c5b001f0a77befa17e7bbb6447129e36a42ba Reviewed-on: https://gerrit.libreoffice.org/73590 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-06-06tdf#124947 fix hit area of the radio buttons, size in ios themeTomaž Vajngerl
The hit area of the radio buttons was not calculated correctly, so sometimes when you hit the radio button at the "wrong" place, nothing happened. This fixes the hit area to correctly cover the radio button and the text. Another issue was that the ios theme size of the radio button was not defined correctly (32px instead of 26px), which increased the error when calculating the hit are even more. The height of the radio button should be the same as defined in the definition.xml, and not bigger (or smaller). Change-Id: I4b03f36ca9d9c82bd6dc442bd6e06af938c62bdd Reviewed-on: https://gerrit.libreoffice.org/73592 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#68103 Mark differences between Draw and Impress Although the 2 modules share a common kernel, the nomeclature, menus and master pages/slides are different. Change-Id: Id4282b2ebaf48a57b753ff0cefa228c3f3bdc644 Reviewed-on: https://gerrit.libreoffice.org/73578 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Remove superfluous string in impress/Draw contents Keep same Contents structure as other apps Change-Id: I1afc21e3581c3200ce6821ee3594686a1f8a70dc Reviewed-on: https://gerrit.libreoffice.org/73571 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-06loplugin:simplifyconstruct (macOS)Stephan Bergmann
Change-Id: I7c46c231f720c7d35a24e19833fb3239a31946ef Reviewed-on: https://gerrit.libreoffice.org/73589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06loplugin:data (macOS)Stephan Bergmann
Change-Id: I404a8364a4c7f8d48533fb3c7757a5b7798de9d8 Reviewed-on: https://gerrit.libreoffice.org/73588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06sfx2: warn when invoking LOK callback before setupAshod Nakashian
Change-Id: I2c845c357f73dbce71b1e420979aecf2cff38827 Reviewed-on: https://gerrit.libreoffice.org/68255 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73482 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06sd: support inserting background image from file via .uno:SelectBackgroundAshod Nakashian
The UNO command always prompted the user via file open dialog. This change allows for passing the filename as an argument to allow for inserting slide background programatically. Also, hide the Insert Image button in the sidebar since we can't use that (just yet), because it invokes .uno:SelectBackground directly. We would need to send LOOL a notification to invoke this on its own end to first prompt the user for a file. (cherry picked from commit 2118143bdd246921439ba9e835207585203dd45f) Change-Id: I20c0e33d66f8bcd72a6388e39c4ac92e64978f45 Reviewed-on: https://gerrit.libreoffice.org/73481 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06tdf#125719 sw: rtf: refactor associated character propertiesSerge Krot
1. \rtlch, \ltrch should be placed before their properties. 2. Do not mix associated and normal character properties in output. 3. Do not output empty "\rtlch \ltrch", "\ltrch \rtlch" pairs. 4. Handle associated character properties runs instead of handling separately their parts without order of them. Change-Id: Ibbf7365d04708682a5f1eb664a579c60a47465d2 Reviewed-on: https://gerrit.libreoffice.org/72578 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-06loplugin:typedefparam: Work around different size_t typedefs on macOSStephan Bergmann
...which for me caused > [CXX] registry/tools/options.cxx > /Users/stephan/Software/lo/core/registry/tools/options.cxx:39:89: error: function param 3 at definition site does not match function param at declaration site, 'size_t' (aka 'unsigned long') vs 'size_t' (aka 'unsigned long') [loplugin:typedefparam] > bool Options::checkArgument(std::vector< std::string> & rArgs, char const * arg, size_t len) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ > /Users/stephan/Software/lo/core/registry/tools/options.hxx:41:93: note: declaration site here [loplugin:typedefparam] > static bool checkArgument (std::vector< std::string > & rArgs, char const * arg, size_t len); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ because one is TypedefType 0x115a4d700 'size_t' sugar |-Typedef 0x115a4d460 'size_t' `-BuiltinType 0x7fde8e0393c0 'unsigned long' while the other is TypedefType 0x7fde8e94a3a0 'size_t' sugar |-Typedef 0x7fde8e94a138 'size_t' `-TypedefType 0x7fde8e94a100 '__darwin_size_t' sugar |-Typedef 0x7fde8e88cc28 '__darwin_size_t' `-BuiltinType 0x7fde8e0393c0 'unsigned long' and > [CXX] store/source/storcach.cxx > /Users/stephan/Software/lo/core/store/source/storcach.cxx:218:43: error: function param 1 at definition site does not match function param at declaration site, 'std::size_t' (aka 'unsigned long') vs 'std::size_t' (aka 'unsigned long') [loplugin:typedefparam] > void PageCache::rescale_Impl (std::size_t new_size) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ > /Users/stephan/Software/lo/core/store/source/storcach.hxx:67:36: note: declaration site here [loplugin:typedefparam] > void rescale_Impl (std::size_t new_size); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ because one is ElaboratedType 0x116f5cba0 'std::size_t' sugar `-TypedefType 0x7fd58673e090 'size_t' sugar |-Typedef 0x7fd58673dde8 'size_t' `-BuiltinType 0x7fd58603cfc0 'unsigned long' while the other is ElaboratedType 0x7fd586742200 'std::size_t' sugar `-TypedefType 0x7fd58621cdc0 'size_t' sugar |-Typedef 0x7fd5861ce4a0 'size_t' `-TypedefType 0x7fd5861cdc70 '__darwin_size_t' sugar |-Typedef 0x7fd586889ec8 '__darwin_size_t' `-BuiltinType 0x7fd58603cfc0 'unsigned long' Change-Id: I3622716376198cc046b0489db59c5cbf613ea1f4 Reviewed-on: https://gerrit.libreoffice.org/73585 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06loplugin:cstylecast (macOS)Stephan Bergmann
Change-Id: I4468aff1817fdb47256dff94e7f2d8aa7575137e Reviewed-on: https://gerrit.libreoffice.org/73586 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06KJ & elementary: +/^ svx dir, elementary: ^ bezier & mimerizmut
Change-Id: Ieaff18277743da93393667c946ed2e95c98921b0 Reviewed-on: https://gerrit.libreoffice.org/73466 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-06vcl: move bitmap scale test to its own fileTomaž Vajngerl
Change-Id: I21e01f63da1c95c3a2c8bae9b998a28fc0a27bc1 Reviewed-on: https://gerrit.libreoffice.org/73560 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-06Cosmetics.Ashod Nakashian
Change-Id: Ic86960ce2f690bebc51c9120053bdd50232f0358 Reviewed-on: https://gerrit.libreoffice.org/73480 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06fix the color dropdownCaolán McNamara
Change-Id: I7666a8364f765830634be46bcb590a1604e5ced1 Reviewed-on: https://gerrit.libreoffice.org/73551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06weld AboutDialogCaolán McNamara
use a native GtkAboutDialog on that platform and refactor the current cui about dialog body to form the body of a vcl AboutDialog use add_button to add the buttons to whichever is preferred of the headerbar or action-area Change-Id: I67e0b36dcb8d3fa08ec4f0397b0f6185b0778675 Reviewed-on: https://gerrit.libreoffice.org/73439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06ViewShellBase const correctnessAshod Nakashian
Change-Id: I00bffe23f2f850f5e0cbf63a60aa1600f848edac (cherry picked from commit 4e6e33870a60a796c17c1e2d67ac6482b853ad28) Reviewed-on: https://gerrit.libreoffice.org/73479 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-06drop never used dialogCaolán McNamara
Change-Id: I2474887914ec74e62667fd6f68ecb57bad89ca0d Reviewed-on: https://gerrit.libreoffice.org/73561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06xmloff: create XMLDrawMetaImportOasis instances with an uno constructorMiklos Vajna
Change-Id: I6793d227fd5e7f358904083f37ccae825f733fd4 Reviewed-on: https://gerrit.libreoffice.org/73570 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-06tdf#115212 DOCX export: fix ToC with tracked deletionLászló Németh
Removing part of Table of Contents with tracked deletion resulted broken DOCX export, ie. unrecoverable and uneditable document in MSO. Change-Id: If5972b2c9fb967819b7be889e0a3efb3714e670b Reviewed-on: https://gerrit.libreoffice.org/73550 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-06only want a border here surely, not scrollabilityCaolán McNamara
Change-Id: Ief22fa4e437af5d408a4debc776be3237a97601a Reviewed-on: https://gerrit.libreoffice.org/73553 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-06tdf#125642: fix minimal sizes of dialog and its elementsMike Kaganski
Change-Id: I0232999866eb731fd74b3e954121f1960a3873bd Reviewed-on: https://gerrit.libreoffice.org/73577 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I3883dedde0ad3ca6c4d6190d711af9c1e6411a50 Reviewed-on: https://gerrit.libreoffice.org/73573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I391dd0af85ced2cb16d54c560c7fb733ff8d780d Reviewed-on: https://gerrit.libreoffice.org/73574 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: I351a41c7b6964bdf60d9231640c18461fca81ff2 Reviewed-on: https://gerrit.libreoffice.org/73575 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-06Fix typoAndrea Gelmini
Change-Id: Iedf4ec187812fd152d19f70405d2f4554211bf6b Reviewed-on: https://gerrit.libreoffice.org/73576 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-05tdf#111522 svx: fix crash with view1 doing text edit and view2 doing sdr undoMiklos Vajna
If one view has an active text edit, then current code doesn't handle manipulating the undo text outside the text edit, so avoid problems by simply not adding an undo action to the undo stack for shape creation or move. Other actions might want to do the same in the future: check for CanDoSdrUndo() before calling SdrUndoFactory member functions. [ Found no existing test suite similar to CppunitTest_sw_uiwriter, so added one. ] Change-Id: I3a364bf4fe6f9b0c13aa07283681b1045368cf7a Reviewed-on: https://gerrit.libreoffice.org/73558 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-05Load align icons from themeMike Kaganski
GTK stock images aren't available using other vcl plugins Change-Id: I5ab23733d8d9c71fcf8db9f1867cb7d43516fff1 Co-authored-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/73548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-05Related: tdf#125404 alias cmn-CN to zh-CN, cmn-TW to zh-TWEike Rathke
Map 'cmn' Mandarin Chinese with associated country for Simplified and Traditional to the technically used 'zh' macrolanguage code. Change-Id: Ifb8a31e728bbf828f13145513bc56a51684ea134 Reviewed-on: https://gerrit.libreoffice.org/73563 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-06-05git-hooks: show length of first line if it's too longMiklos Vajna
Change-Id: I164e4308c2a3e685bbc83cfde1cae5189839075e Reviewed-on: https://gerrit.libreoffice.org/73556 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-05ofz#15068 build failureCaolán McNamara
Change-Id: Ic306faa25c726be39bc76fa9d492204ad0602810 Reviewed-on: https://gerrit.libreoffice.org/73554 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-05sw: disable test_tdf118540_preview_document_properties()Miklos Vajna
See the discussion at <https://gerrit.libreoffice.org/#/c/70840/> this test is quite unstable at the moment, unfortunately. Change-Id: I6cbfdd0d9c5af8a848f32ab209ae70bc7a10d4af Reviewed-on: https://gerrit.libreoffice.org/73557 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-05make OutputDevice::LogicToLogic respect empty Rectangle in more casesNoel Grandin
follow the logic from the block at the top of the function Change-Id: I3756eac9eb4fddb239a433927c52a505c7ab9b36 Reviewed-on: https://gerrit.libreoffice.org/73547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-05crash testing export of ooo72915-2.odt to ooo72915-2.docNoel Grandin
blind fix Change-Id: I670b851405a1a41dbb7c85d495de9144dffd0194 Reviewed-on: https://gerrit.libreoffice.org/73542 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-05Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-05tdf#125062: distort hairline borders only if selection is usedXisco Fauli
Regression from 046df0a876b3d948bb1e14443c00c180bc8cccaa Use the fix for tdf#105998 only when 'selection' option is checked in the save dialog Change-Id: I8c4127c780736408e905ead48e0d3ee6ae149197 Reviewed-on: https://gerrit.libreoffice.org/73391 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Prevent L10n issue when building Help Pootle does not convert back &lt; and &gt; into the same entities, thus disturbing XML parsing of string. Changed to (). Change-Id: I4e754313a2c51c6b5b190a7e236768fe84ec8672 Reviewed-on: https://gerrit.libreoffice.org/73444 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#124582 Change Outline to Chapter in Help page Change-Id: Ica5e33aa11da21b1194710a46b60663421222bf8 Reviewed-on: https://gerrit.libreoffice.org/73442 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-05Linguistic: new underlining styles for grammar checkersOlivier R
This patch adds two new underlining styles: - BOLDWAVE: a thicker version of the default WAVE style - BOLD: a thick straight line No default setting changed. It's up to the grammar checkers to specify the underlining style they want. This contribution to LibreOffice is licensed under the MPLv2/LGPLv3+ dual license. modified : include/vcl/outdev.hxx modified : offapi/com/sun/star/text/TextMarkupDescriptor.idl modified : sw/source/core/inc/wrong.hxx modified : sw/source/core/txtnode/fntcache.cxx modified : vcl/source/outdev/textline.cxx modified : vcl/workben/outdevgrind.cxx Change-Id: I5629253905ba40c51cc748a7ceeb84170ef5d94c Reviewed-on: https://gerrit.libreoffice.org/73412 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-05Qt5 workaround modal change after show bugJan-Marek Glogowski
The presentation minimizer dialog calls setVisible before execute. This results in the dialog being shown before setting the modality in execute. And this triggers a bug in the Qt / Xcb stack (gtk is fine because it directly uses XSendEvent to change the state). The result is an unmapped, modal dialog window: it's invisible and blocks the GUI. Qt believes it's show; isVisible() returns true. And my ~/.xsession-errors shows a "qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow) ... major code: 18 (ChangeProperty)" with an invalid resource id, according to 'xwininfo -tree -root'. You can find the window resource of the minimizer by its name in the full root tree and its unmapped state with 'xwininfo -id'. I originally thought of a Scheduler bug so enabled debug output for it. This is already responsible for a delay long enough to prevent the bug often. Same for doing an additional hide() and show() sequence. In the end I went with a fixed delay, but that is just a guess. In theory we could check the mapped state via Xlib in Qt's show event and manually map it using XMapWindow and the winId... I also noted that the minimizer leaks, as there are multiple new presenter resources after each show and hide... Change-Id: I2060918aa9c63d385ebb2ffee9e7a3e4196ea766 Reviewed-on: https://gerrit.libreoffice.org/73462 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-05Qt5/KDE5 always use either Qt5 or KDE5 pickersJan-Marek Glogowski
And use RunInMain for both SalInstances and for both picker types, as there is no reason to assume just the file and not the folder picker can be called from the non-GUI thread. Little drawback is the inclusion of Qt5FilePicker header in the Qt5Instance header, as Qt's enums aren't forward-declarable. Change-Id: Ie170d247a76134df9aff835393c71c9d6e907d32 Reviewed-on: https://gerrit.libreoffice.org/73416 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-05baseline is CentOS/RHEL 7 (glibc 2.14 or later)Christian Lohmaier
Change-Id: Ie796a5c8f36b33c61eb69b6b68f7439f9359526f
2019-06-05Fix typoAndrea Gelmini
Change-Id: Id77320481846d20fd3f2a8dbdb845a19411baa1d Reviewed-on: https://gerrit.libreoffice.org/71817 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-05Link: support tracing link source and targetAshod Nakashian
By adding a couple of members to Link, we are now able to trace the target function name and the file:line where the Link instance in question was created (provided the LINK macro is used). This gives the invaluable ability to track down the source of a Link instance in the debugger, provided we have enabled this feature, which is enabled in DBG_UTIL automatically, unless explicitly enabled. Of course it is also possible to judiciously add LOG/fprintf statements to chase this info, if not outright track all links, if so we wish, by dumping from Link::Call, or at construction time of Link. Change-Id: Iab1dce31a179d28aaa1f20228e9e0405973b5e9b Reviewed-on: https://gerrit.libreoffice.org/73478 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-05python: add sample python script to insert/replace textAshod Nakashian
Change-Id: Idde3cd22ecc1f1bd34f7519acedc85584ed2deaf Reviewed-on: https://gerrit.libreoffice.org/58160 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/73477 Tested-by: Jenkins
2019-06-05tdf#125685 sw: disregard footnotes in follow table on table splitMichael Stahl
The first problem here is that the table isn't fully formatted; it fails with: warn:legacy.osl:22975:22975:sw/source/core/layout/tabfrm.cxx:2639: debug assertion: <SwTabFrame::MakeAll()> - format of table lowers suppressed by fix i44910 The situation is that there is a big table split across pages; the first line of the table would fit onto the previous page so its follow frame moves backward and then the table frame tries to split again. During SwTabFrame::Split(), all the frames in the table are formatted, and at that point a footnote that was on the next page is moved to this page. A nested table frame also splits, such that it fits inside the page... but then the split of the outer table fails by 5 twips, because the moved footnote has reduced the space available for the outer table. The footnote is anchored in the inner table's follow frame, which would be moved to the next page anyway, taking the footnote with it. Fix this in lcl_RecalcSplitLine() by checking for footnotes that are anchored in the follow frame of the top-level table being split, and adding their height to the available space on the page. Fixing the first problem avoids the crash as well; the crash happens since 18765b9fa739337d2d891513f6e2fb7c3ce23b50 and it's rather hard to avoid it in a situation where formatting starts at the end and recurses into an unformatted table preceding it, which isn't supposed to happen. Change-Id: I85286583c1c4930468a1c283afc98504cd35bb71 Reviewed-on: https://gerrit.libreoffice.org/73465 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit (git 2.34.1) at 2024-07-10 20:59:40 +0000