summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-06use same logic in both CreatesCaolán McNamara
Change-Id: I49dab360c5f93e40f5a6e91fbe721935d795472c
2017-01-06unixODBC: revert nonsensical trival change 622bb4bcMichael Stahl
There is no point to trivial cleanups in external headers. Change-Id: I9cb7ba135655e1426dcafd3a621ab4eaa7da1011
2017-01-06bSilent is unusedStephan Bergmann
...ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import" Change-Id: Iccee867aa9722ced2f66d4d8b8911c5e191502c2
2017-01-06lsan+wmffuzzer shows a circular reference leading to a leakCaolán McNamara
graphic gets a context set on it which has a shallow copy of the graphic in it. ==37==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 1024 byte(s) in 1 object(s) allocated from: #0 0x6170b0 in operator new[](unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:84 #1 0x91361b in BitmapPalette::BitmapPalette(unsigned short) /src/libreoffice/include/vcl/salbtype.hxx:467:56 #2 0x9029f0 in GIFReader::GIFReader(SvStream&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:114:7 #3 0x91648d in std::__1::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>, GIFReader, 1u>::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>&, SvStream&, 0ul, 0ul>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>, std::__1::__tuple_indices<0ul>, std::__1::__tuple_indices<0ul>) /usr/local/bin/../include/c++/v1/memory:2173:15 #4 0x91648d in std::__1::__compressed_pair<std::__1::allocator<GIFReader>, GIFReader>::__compressed_pair<std::__1::allocator<GIFReader>&, SvStream&>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>) /usr/local/bin/../include/c++/v1/memory:2330 #5 0x91648d in std::__1::__shared_ptr_emplace<GIFReader, std::__1::allocator<GIFReader> >::__shared_ptr_emplace<SvStream&>(std::__1::allocator<GIFReader>, SvStream&) /usr/local/bin/../include/c++/v1/memory:3827 #6 0x91648d in std::__1::shared_ptr<GIFReader> std::__1::shared_ptr<GIFReader>::make_shared<SvStream&>(SvStream&) /usr/local/bin/../include/c++/v1/memory:4443 #7 0x91284b in _ZNSt3__111make_sharedI9GIFReaderJR8SvStreamEEENS_9enable_ifIXntsr8is_arrayIT_EE5valueENS_10shared_ptrIS5_EEE4typeEDpOT0_ /usr/local/bin/../include/c++/v1/memory:4807:12 #8 0x91284b in ImportGIF(SvStream&, Graphic&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:889 #9 0x61c85c in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/giffuzzer.cxx:18:11 #10 0x575ef58 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:546:13 #11 0x575fcb4 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:497:3 #12 0x577e43a in fuzzer::Fuzzer::RunOne(std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) /src/libfuzzer/FuzzerInternal.h:119:41 #13 0x575e5ad in fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >*) /src/libfuzzer/FuzzerLoop.cpp:476:30 #14 0x5708588 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:534:6 #15 0x56fb3c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10 #16 0x7fb5f13da82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) Change-Id: I1384f4ced094e79a27e7d15b569c88f129cd115a
2017-01-06Updated coreOlivier
Project: help 65af088bf1a712cd234e0e97e2820c44f6327f81 Better wording for title pages help page Change-Id: Idb7643131803708206c04382d7b2520610216ad1 Reviewed-on: https://gerrit.libreoffice.org/32780 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-01-06gtktiledviewer: Lets avoid using manual buffer sizesPranav Kant
Change-Id: I76e70ccb5b1f40193a1eda1cbca19b3444168dae
2017-01-06loplugin:salboolStephan Bergmann
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-06loplugin:nullptrStephan Bergmann
Change-Id: I279e65c2ec5fa7b3b06f01e7ef4e50ed822fcd03
2017-01-06Work around clang-cl -Werror,-Wmissing-field-initializersStephan Bergmann
...the same way as in other uses of GetStartupInfo Change-Id: Ieeadf028d15c915df32e055e3725513b2047da4d
2017-01-06gtktiledviewer: Override alignment buttons uno commands for calcPranav Kant
Use .uno:HorizontalAlignment instead of .uno:XXXPara for calc Change-Id: I5af4fe62dc3075af4ba779499d062e6d91f21ecf Reviewed-on: https://gerrit.libreoffice.org/32773 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-06gtktiledviewer: Support for posting arguments to uno commandsPranav Kant
Change-Id: I5db217b525d0f976ef6a7840e370f8f6a21d60cb Reviewed-on: https://gerrit.libreoffice.org/32772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-06tdf#105127 VML import: handle <v:shape style="flip:..." path="...">Miklos Vajna
I don't see an easy way to implement this via UNO, so use the internal API. As to the internal API usage, SdrEditView::MirrorMarkedObjVertical() (for UI) and SvxMSDffManager::ImportShape() (for WW8 import) are example client code. Change-Id: I9bf27788db32fd35d6b56e0f1a240c4b7abc5604
2017-01-06Use string literals directlyStephan Bergmann
Change-Id: Ia4ae5c01ae7eb976a0e9638f8bc8fe7ebab8e2cb
2017-01-06QA Basic: split tests of methods in different filesLaurent Balland-Poirier
Following resolution of "Missing TAN method" [1] as discussed on dev list [2] a large majority of methods are now tested with (almost) one method per file Missing methods: - colors failed: RED, GREEN, BLUE - file methods: DIR, CHDRIVE, EOF,... - financial methods calling Calc functions: IPmt, IRR,... - not totaly implemented methods (?): ROUND, WAITUNTIL... [1] https://bugs.documentfoundation.org/show_bug.cgi?id=102872 [2] http://nabble.documentfoundation.org/QA-test-for-BASIC-functions-tt4202257.html Change-Id: I2b2824b5b18a2cfbbee2bbc5369e9e2b9e5c930b Reviewed-on: https://gerrit.libreoffice.org/32519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-06writerperfect, xmloff: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Ie8246433a7cea0886f00d8c76cf6f7d023545417 Reviewed-on: https://gerrit.libreoffice.org/32770 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06No need to check isEmpty() before clearingStephan Bergmann
Change-Id: I75b077cbc2d100964d4157220561d53c1b235199
2017-01-06Updated coreOlivier
Project: help d2ff85a3942838ae72e4d7abced5e94e6d275225 Typos and tweaks in Help pages from translation Change-Id: I53963f69b268ac57166963b5d1f4cac663b67312 Reviewed-on: https://gerrit.libreoffice.org/32760 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-01-06This apparently doesn't happenStephan Bergmann
The code has been like this ever since ed8c4fd992a4e2e43e65d05e6f06336bfe2fdba2 "INTEGRATION: CWS eforms2", but it doesn't make sense: It apparently wants to clear XCurrent to leave the for-loop early, but would acutally cause a null deref instead. So this branch apparently doesn't get executed routinely. Is it impossible to be reached? To play it safe, assume no. But I can't find anything substantiating the "we'll remove the slash below" claim, so just return an empty string instead. Change-Id: I18e05385bbef05e7682a2eb4d525cfee25d9a6f5
2017-01-06lokdocview: Handle insert keyPranav Kant
Change-Id: Idb5ad17a3a94b9a6fba1113a759207c59acfb7bd
2017-01-06Clean up a usage of OUStringBufferStephan Bergmann
Change-Id: I05205763502fb20e056cc80f50a37b93232e5743
2017-01-06Use OUString::booleanStephan Bergmann
Change-Id: I8989fcc18cd0f0b28ef6da5c3c3d7f87429b569b
2017-01-06No need for an OUStringBuffer hereStephan Bergmann
Change-Id: I01697ac2b84f836ff0b3d15aa8d03042f229eacb
2017-01-06Updated coreGabor Kelemen
Project: help 5dab8d006d59a1187da8afae151c48f24080764f test-hid-vs-ui: Fix Writer Navigator side pane element references From source/text/shared/01/02110000.xhp, we did not find file sw/uiconfig/swriter/ui.ui. From one of ['source/text/swriter/01/02110000.xhp', 'source/text/shared/01/02110000.xhp'], referenced items ['numericfield', 'promotelvl', 'up', 'demotelvl'] were not found inside sw/uiconfig/swriter/ui/navigatorpanel.ui. From these numericfield is a special case, let it be for now. Change-Id: Ief96fd2238e993d7d1a6d8a59cd86f1ddef94980 Reviewed-on: https://gerrit.libreoffice.org/32765 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-06tdf104061 - looking for test documentsJustin Luth
This fixes the specific test document here, but likely there need to be other qualifiers such as "if the table is the first node in the section". Likely this commit will be reverted. We will use Milos' document tester to hunt for the side-effects of this patch - which should give us a good set of test documents. Change-Id: I7d3a2168556c82bc4758ad665da319d55df4ba2b Reviewed-on: https://gerrit.libreoffice.org/32759 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-01-06libpng: update to release 1.6.28Thorsten Behrens
Change-Id: Ie22e5eb6656ef1d2e7903011ea72a1aa26d4da7c Reviewed-on: https://gerrit.libreoffice.org/32767 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-05refactor and simplify AppendAllObjs with a circular bufferBjoern Michaelsen
- do not iterate repeatedly over objects already handled - filter out AS_PAGE and AS_CHAR before looping - use circular buffer as we are only ever removing, never adding formats to handle, so we can get away with one alloc Change-Id: I0244bda6db4704891111f6c6a8630a72bede68e6 Reviewed-on: https://gerrit.libreoffice.org/32747 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-05add gif fuzzerCaolán McNamara
Change-Id: I47dc449464cc7643d05b73e9612d01e50a8d4b8e
2017-01-05tdf#90290 use custom asserter in subsequent_filters-test.cxxkerem
Change-Id: I1a6e4ecb69c4de330d506b56e7622b58c6836bd8 Reviewed-on: https://gerrit.libreoffice.org/32740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-05Related: tdf#45820 polygon clipping during wmf load is ultra slowCaolán McNamara
For file fuzzing defer actually doing it during load and just set a clipping region, which can take a polypolygon argument, instead of setting a basic cliping rectangle + complexclip flag to specially clip certain things for normal use, continue to do the slow thing as it gives different visual output, so its either not quite the right thing, or there's bugs elsewhere that would need to be fixed to go this way the whole time Change-Id: Ieac7ab54ed7d7c1ca14afd75b25fe273fd676c5d
2017-01-05add ISECTREGIONCLIPREGION to dumperCaolán McNamara
Change-Id: If60e84031cfa8aa3cbbdbb99281d784dcd9e6432 Reviewed-on: https://gerrit.libreoffice.org/32757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-05check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-upEike Rathke
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7
2017-01-05check token array code errors when testing for equality, tdf#105024 relatedEike Rathke
To not end up with a series of equal errors when importing individual error cells and attempting to group them. Change-Id: Idfcbb2e7077fc8799ef925c2c2e17188ac5e3b14
2017-01-05Resolves: tdf#105024 generate and parse detailed "#ERRxxx!" error constantsEike Rathke
Change-Id: I4e5d98cdbbc2f3e7746cd3892f70151376bc5808
2017-01-05Resolves: tdf#104919 crash with empty ScNavigatorDlg memberCaolán McNamara
commit 292560a957498bed70b625c992ec6bcf631dceb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Oct 17 13:23:23 2016 +0200 loplugin:unusedmethods detected the intended methods to do this were unused, so restore then, but hook them up this time Change-Id: I3b7e4a557696a91a70956487468b99fec6324a93
2017-01-05No need to check isEmpty() before clearingStephan Bergmann
Change-Id: Ie32a4ee915d57618d2a6a661febf39fd0d55dd80
2017-01-05finish moving ImageList to frameworkCaolán McNamara
Change-Id: I9d9f292066321174af8b0bcd96c58de5fc7566b8
2017-01-05Related: tdf#105093 sw PDF export: handle embedded videosMiklos Vajna
Use vcl::PDFExtOutDevData::SetScreenStream() for embedded media to make sure that vnd.sun.star.Package: URLs don't end up in PDF out literally. Acrobat Reader obviously doesn't understand that protocol. Change-Id: I384891b3ef2dcea25bbf591bd210ccf899d30a61
2017-01-05xmlsecurity: hold XMLSignatureTemplateImpl by rtl::ReferenceMiklos Vajna
Going via UNO for a class in the same directory is an overkill. Change-Id: I3dd09a74b6113c472402632bd54bc5bcf32f69bf Reviewed-on: https://gerrit.libreoffice.org/32748 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05use proper message passingBjoern Michaelsen
- checking the type of Format hopefully allows skipping contact checks Change-Id: I11690e4ec1e94b809b0ec13f2d9b4e3a22ded213 Reviewed-on: https://gerrit.libreoffice.org/32729 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-05getLength -> isEmptyStephan Bergmann
Change-Id: I5a8c2911851d1a798d8c6f3c25b08cb0469f07a0
2017-01-05move ImageList to frameworkCaolán McNamara
this can probably be replaced by a std::*map<Image> Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05move CommandImageResolver out of vcl and beside its only userCaolán McNamara
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05move ImageType enum out of CommandImageResolver.hxxCaolán McNamara
Change-Id: I0b4da9a4edff8d0f9016fbd79cb205bdf2b35268
2017-01-05oox: rename misleadingly prefixed m_pShapeStyleMichael Stahl
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05No need for heap-allocated OUStringBufferStephan Bergmann
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05use GetZOrnderHint instead of duplicationBjoern Michaelsen
Change-Id: I78f428e9ddc50df60f7e9652015d49f3cf7b3286 Reviewed-on: https://gerrit.libreoffice.org/32746 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-05ImageList doesn't need to be a friend of ImageCaolán McNamara
Change-Id: I3bfe3b6fcd033f1cab503934cf4442adb0143939
2017-01-05Clean up a usage of OUStringBufferStephan Bergmann
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05drop unused forward declCaolán McNamara
Change-Id: Ie4a2ac8e5363539eb09bb16f13f46829c3c63785
2017-01-05drop newly unused InsertFromHorizontalBitmapCaolán McNamara
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
generated by cgit (git 2.34.1) at 2025-02-19 16:35:17 +0000