summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-12iOS patch liborcusjan Iversen
Support for arm64 Change-Id: Ie2289e4df9f90b7c31357ecfe859f087a7df9c5a
2017-06-12iOS, patch langtagjan Iversen
Support for arm64 Change-Id: I1f5d8a11f42026b08aa01a8a19059c18ff116c1c
2017-06-12tdf#50916 : Refactor table1.cxx ScTable::GetNext*() methodsDennis Francis
Refactored ScTable::GetNextPos() and ScTable::GetNextMarkedCell() methods in table1.cxx for dynamic column container. Change-Id: I5dfe9e5b2236e6ede68119f4e1252610990e498b Reviewed-on: https://gerrit.libreoffice.org/38599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-12Use unique_ptr fro ScMergePatternState::pItemSetStephan Bergmann
Change-Id: I672785b273eaa8862f43112d7f25ae495b65b0c7
2017-06-12Resolves: tdf#108413 yet some more TYPEDITEMLIST property entriesEike Rathke
... which apparently need to be present to be able to override them. You also can have never enough macro names to obfuscate things for grep.. Change-Id: Ic0bdcb71682136a537b3ce1c564f02f686f1ee9e
2017-06-12Revert "uitest: disable failing part of manual_tests/calc.py"Miklos Vajna
This reverts commit 8c59cfb6aad60c06271ac7ae3c124132bdf223c9. Turns out this was a problem for non-English locales only, and Markus fixed this in general in the meantime. Change-Id: I4bb487345b9de4ee637538bbb9d53faa98c7ec5f Reviewed-on: https://gerrit.libreoffice.org/38698 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12Avoid use-after-freeStephan Bergmann
...as seen in UITest_calc_demo: > ==1010== Invalid read of size 4 > ==1010== at 0x58DA550: __pthread_mutex_unlock_usercnt (/usr/src/debug/glibc-2.24-33-ge9e69e4/nptl/pthread_mutex_unlock.c:39) > ==1010== by 0x58DA550: pthread_mutex_unlock (/usr/src/debug/glibc-2.24-33-ge9e69e4/nptl/pthread_mutex_unlock.c:324) > ==1010== by 0x1085FB42: __gthread_mutex_unlock(pthread_mutex_t*) (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/x86_64-redhat-linux/bits/gthr-default.h:778) > ==1010== by 0x10861414: std::mutex::unlock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:121) > ==1010== by 0x10861901: std::unique_lock<std::mutex>::unlock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:323) > ==1010== by 0x108604C6: std::unique_lock<std::mutex>::~unique_lock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:232) > ==1010== by 0x1085FA5E: (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:103) > ==1010== by 0x1085EDE7: (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:85) > ==1010== by 0x10715647: Link<Timer*, void>::Call(Timer*) const (/include/tools/link.hxx:84) > ==1010== by 0x107154A6: Timer::Invoke() (/vcl/source/app/timer.cxx:89) > ==1010== by 0x106D3841: ImplSchedulerData::Invoke() (/vcl/source/app/scheduler.cxx:46) > ==1010== by 0x106D3D28: Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:159) > ==1010== by 0x107040EF: ImplYield(bool, bool, unsigned long) (/vcl/source/app/svapp.cxx:508) > ==1010== by 0x106FE9A7: Application::Yield() (/vcl/source/app/svapp.cxx:558) > ==1010== by 0x106FE92A: Application::Execute() (/vcl/source/app/svapp.cxx:458) > ==1010== by 0x513F498: desktop::Desktop::DoExecute() (/desktop/source/app/app.cxx:1354) > ==1010== by 0x5141660: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1698) > ==1010== by 0x10711884: ImplSVMain() (/vcl/source/app/svmain.cxx:192) > ==1010== by 0x10713197: SVMain() (/vcl/source/app/svmain.cxx:230) > ==1010== by 0x51AEDF7: soffice_main (/desktop/source/app/sofficemain.cxx:166) > ==1010== by 0x40091C: sal_main (/desktop/source/app/main.c:48) > ==1010== by 0x4008F6: main (/desktop/source/app/main.c:47) > ==1010== Address 0x2ccca4e8 is 72 bytes inside a block of size 96 free'd > ==1010== at 0x4C2F21A: operator delete(void*) (/builddir/build/BUILD/valgrind-3.12.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576) > ==1010== by 0x1085FA55: (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:102) > ==1010== by 0x1085EDE7: (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:85) > ==1010== by 0x10715647: Link<Timer*, void>::Call(Timer*) const (/include/tools/link.hxx:84) > ==1010== by 0x107154A6: Timer::Invoke() (/vcl/source/app/timer.cxx:89) > ==1010== by 0x106D3841: ImplSchedulerData::Invoke() (/vcl/source/app/scheduler.cxx:46) > ==1010== by 0x106D3D28: Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:159) > ==1010== by 0x107040EF: ImplYield(bool, bool, unsigned long) (/vcl/source/app/svapp.cxx:508) > ==1010== by 0x106FE9A7: Application::Yield() (/vcl/source/app/svapp.cxx:558) > ==1010== by 0x106FE92A: Application::Execute() (/vcl/source/app/svapp.cxx:458) > ==1010== by 0x513F498: desktop::Desktop::DoExecute() (/desktop/source/app/app.cxx:1354) > ==1010== by 0x5141660: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1698) > ==1010== by 0x10711884: ImplSVMain() (/vcl/source/app/svmain.cxx:192) > ==1010== by 0x10713197: SVMain() (/vcl/source/app/svmain.cxx:230) > ==1010== by 0x51AEDF7: soffice_main (/desktop/source/app/sofficemain.cxx:166) > ==1010== by 0x40091C: sal_main (/desktop/source/app/main.c:48) > ==1010== by 0x4008F6: main (/desktop/source/app/main.c:47) Change-Id: Ie95bf07f2fcd9420c9c24e6829272430895957a6
2017-06-12next version will be 6.0, not 5.5Christian Lohmaier
Change-Id: Iaf10adce17f129c564e1f1ba4ca811b9274618fc Reviewed-on: https://gerrit.libreoffice.org/38575 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12Fix typosAndrea Gelmini
Change-Id: Ib2ba32d48d3df16b0b20deea84416fe15a2d7176 Reviewed-on: https://gerrit.libreoffice.org/38650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12tdf#95883 Select Unprotected Cells in CalcGulsah Kose
Change-Id: I20a71f66154675de9c2c47ff32e859c899fe9103 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/37424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-12Setting Buffered(threaded)Stream as default:Mohammed Abdul Azeem
Also cleaning up bUseBufferedStream parameter. Change-Id: Ibf9c9fcefbdcd229ffaa1d3b169ff87f00e91ceb Reviewed-on: https://gerrit.libreoffice.org/38661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12tdf#103311 Conditionally disable Next button on MM Wizard page 4Gabor Kelemen
The user has to set up either an address block on page 3 or a greeting on page 4 to be able to progress to page 5. The 5th page is already disabled if these are not enabled but the Next button on page 4 is always enabled. Now the Next button gets enabled/disabled if the 5th page is enabled/disabled by UpdateRoadmap(). Change-Id: If216d935ebebb3fc6a4e1488ec2dfc716db41c3e Reviewed-on: https://gerrit.libreoffice.org/38610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-12tdf#106423: dbase file can have no recordsJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3ff19b33c84557fd20e68960499933b4e52638 tdf#84834 sc: stricter type detection for dBASE files Log test file from tdf#84834 still opens in Writer as expected Change-Id: Ibf5a0f586e3a132455d2363e61e5cc7ea249002d Reviewed-on: https://gerrit.libreoffice.org/38660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12tdf#108055 RTF: Header and Footer are added multiple times.Thomas Beck
Made it so Header/Footer of a certain section can only be added once. This change should only affect RTF-Files. Added Unittest Change-Id: I55025984e343d04da7fc0f201164ef39e3a26202 Reviewed-on: https://gerrit.libreoffice.org/37814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-12tdf#43157 - salhelper: convert from OSL_ASSERT to assertChris Sherlock
Change-Id: I8691a627bbf78ce83db595053d6e254557641408 Reviewed-on: https://gerrit.libreoffice.org/38506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12sw: prefix members of SwNotePropsMiklos Vajna
Change-Id: If1d50504d9d7efcb0f6b1b5ddf570d3016f40be5 Reviewed-on: https://gerrit.libreoffice.org/38686 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12sw: GCC still complains about "multi-line comment" [-Werror=comment]Michael Stahl
Apparently a trailing space after the "\" does not prevent the warning? Let's work around harder... Change-Id: I05239697b26cd53df719ed520826db60a7805417
2017-06-12Refactor create layout cache in status barTamas Bunth
Create SalLayout in StatusBar instead of getting cache through output parameter. Pass cache as a constant to the output device afterwards. Results in a more readable code, with more evident memory management. Change-Id: I4f949ea8f390b31379f661d611a183ceb3d91c25 Reviewed-on: https://gerrit.libreoffice.org/38651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-06-12tdf#108427 Direct cursor: Add option to insert only spacesSamuel Mehrbrodt
Change-Id: I1136688ec8af44c533f4dd40a9a4b24ea59992ef Reviewed-on: https://gerrit.libreoffice.org/38685 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-12tdf#39468 translate german comments, removing redundant onesThomas Beck
Translated remaining german comments in ww8par5.cxx Change-Id: I7a21f0f0424e821cd5350c776dcab58658a0a24b Reviewed-on: https://gerrit.libreoffice.org/38687 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-12Fix unclear commentStephan Bergmann
...after 5312da481ea8e25f06a7a0b725001b40069af081 "Translate German comments and debug strings (leftovers in dirs j... to q...)" Change-Id: I4155abb0a2d3d58b92be6835b8e9de37d2a19cfd
2017-06-12tdf#39468 Translate German comments/terms sw/source/filter/html/htmlform.cxxJens Carl
Change-Id: I40a32dd04cfffda02b1418664f40295929e91fcc Reviewed-on: https://gerrit.libreoffice.org/38622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Johnny_M <klasse@partyheld.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12Translate German comments and debug strings (leftovers in dirs j... to q...)Johnny_M
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "j" to "q". Additionally: - A few spelling fixes Change-Id: I5abf71dde3efc0dbaad162c705c6dc17af50f6c1 Reviewed-on: https://gerrit.libreoffice.org/38613 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-12Take new FormulaTokenArrayPlainIterator into use in one more fileTor Lillqvist
Change-Id: I0a7565e2cc666151440d9fdb0a0e7b90263a88e5
2017-06-12skip copying tile when we don't need toCaolán McNamara
Change-Id: I137c69b7217801a6c86634f7e44e363ef73fd9de Reviewed-on: https://gerrit.libreoffice.org/38667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-12use the shared path codeMarkus Mohrhard
Change-Id: I046b8f497b78c4067abbf22180edb1b210020f4e Reviewed-on: https://gerrit.libreoffice.org/38684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12better variable namesMarkus Mohrhard
Change-Id: I14e667f10ae472f24fbb6107eee449ff9cf7f4a4 Reviewed-on: https://gerrit.libreoffice.org/38683 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12make it easier to extend the responseMarkus Mohrhard
Change-Id: I95d60fe38bbb16c502eccaae3bc25a35dd269d1a Reviewed-on: https://gerrit.libreoffice.org/38682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12use the shared path codeMarkus Mohrhard
Change-Id: I02cc24d7a9e3b679a7bd883cd7085682063520ee Reviewed-on: https://gerrit.libreoffice.org/38681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12remove debug print statementMarkus Mohrhard
Change-Id: I419dd9311bc4fbb9fcd2e73a83c5272ecbec242d Reviewed-on: https://gerrit.libreoffice.org/38680 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12better updater loggingMarkus Mohrhard
Change-Id: I6012f2159d058cbb2afb4b685badb8c870adf07b Reviewed-on: https://gerrit.libreoffice.org/38679 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-12sw, xmlsecurity: indentation fixesMiklos Vajna
Change-Id: I3bc916c8318b63a829ec391a72976829815fa987
2017-06-12configure.ac back again.jan Iversen
Readded changes to configure.ac, after seeing that the android builds. This is not the ideal way to check that a tinderbox builds correctly, but currently we have no other options. Change-Id: I48f898131e2f506db67507d43f4a896748f98c81
2017-06-12Remove VCLExternalSolarLock and IMutex.Arnaud Versini
Next step is to remove OContextEntryGuard. Change-Id: I9460fb67fba6f3bfb3c809b730c33f38d225a64e Reviewed-on: https://gerrit.libreoffice.org/38411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12replace double checked locking patterns in getTypes macrosJochen Nitschke
with thread safe local statics Change-Id: Ie7c44fb35ba0b24e154631a4805463230e2c69e7 Reviewed-on: https://gerrit.libreoffice.org/38662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12clang-tidy readability-delete-null-pointerNoel Grandin
which in turn triggered some loplugin:useuniqueptr Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64 Reviewed-on: https://gerrit.libreoffice.org/38281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12pass comphelper::PropertySetInfo around using rtl::ReferenceNoel Grandin
and remove some manual ref counting Change-Id: Ib78122fbbf914e87e0aef1f8fffe3952639e5b22 Reviewed-on: https://gerrit.libreoffice.org/38607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12Android tinderbox build breakerjan Iversen
add openssl library back for Android static link Change-Id: I7ac5c3f9c00060f926f03fb21d8fa5e87b928c71
2017-06-12iOS, patch harfbuzzjan Iversen
Add support for arm64 Change-Id: Icfc47b0c3b600ea3d26c40741c933028e8e9c47d
2017-06-11tdf#80671: mediawiki, no superscript tags allowed in footnotesJulien Nabet
Change-Id: I54c2cc0fc6b2a9c631fc83f59c2204dd5e374d2c Reviewed-on: https://gerrit.libreoffice.org/38666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-11refactor fuzzer army a bitCaolán McNamara
the core lib has grown sufficiently large that the fuzzing tooling complains of too many instrumented conditions so split things up to hopefully fit again Change-Id: I58899d143925f958aec95b5f213c2dc75a6686ec Reviewed-on: https://gerrit.libreoffice.org/38647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-11Revert "nPoolId already points to STR_POOLCOLL_TOX_AUTHORITIES1 at this point"Caolán McNamara
it does on the first loop, but the same poolid is wanted on subsequent loops This reverts commit 6414389f8d95e76dcdf2bd9a7c2fa6dc9acd304d.
2017-06-11Fix typo in codesAndrea Gelmini
Change-Id: If52ff2c0bb4c8a703e883f25d0ba567236cbe479 Reviewed-on: https://gerrit.libreoffice.org/38609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-11Fix typosAndrea Gelmini
enviroment -> environment Change-Id: I08b95367fbd45f7f785121df33533c0ee7ee331f Reviewed-on: https://gerrit.libreoffice.org/38649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-11Fix typosAndrea Gelmini
Change-Id: I81740a3ff9474e971556e9e7d4aa245151163d0e Reviewed-on: https://gerrit.libreoffice.org/38608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-11Access2Base - Correct handling of empty arrays in UtilPropertyJean-Pierre Ledure
Avoid runtime error when storing an empty array (undocumented API) Change-Id: I3f8d31300dec365d7028dcd6bd9de2b24b2e0c4c
2017-06-11logging the simple message is sufficientCaolán McNamara
Change-Id: I84bced2b8dd92082f4777e00261ac87752278527
2017-06-11move unlocalized pricing strings into sourceCaolán McNamara
and each string array is always 1 string in length, so simplify a little based on that Change-Id: I822dbe884608a935ff2cf86c059c558ee9ad4d4b Reviewed-on: https://gerrit.libreoffice.org/38644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-11undo touch of ANDROID buildjan Iversen
tinderbox had a problem with android build due to test message removed Change-Id: I2ab101dd037257be16eb2771f65e78794bad4489