summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-19sw lok: Accept / reject change is always enabled in the context menuTamás Zolnai
Use conditional fastcall for allow executing these two uno commands even if there is no tracked changes at the cursor position instead of enable the menu slots unconditionally. See also: b6011f07254f8003929320ad842d8d09daca0e09 Change-Id: Iaf8a8082961cd174c038fc021d2c41fb7cb97bff Reviewed-on: https://gerrit.libreoffice.org/53148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-19tdf#117075 TOC numberings have incorrect right indentNoel Grandin
This reverts parts of commit 867a22fd199e732803c9050fe9f84ad630ec27fb Date: Wed Mar 28 10:00:30 2018 +0200 loplugin:virtualdown in xmloff/xmlsecurity and commit 73e6a7975b3508c5cfccb3df7c35b0303f87d9bb Date: Thu Mar 29 09:35:22 2018 +0200 loplugin:unusedmethods Change-Id: Id4230fafc10bbfe5822f7011a1b1d3d9dff30735 Reviewed-on: https://gerrit.libreoffice.org/53149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19cppcheck - fix variableScope in some filesGökhan Gurbetoğlu
Reduced the scope of some variables in source. Change-Id: I705e7f2587fd81015f06fb301eb8d4a270668d73 Reviewed-on: https://gerrit.libreoffice.org/53042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gökhan Gurbetoğlu <gokhan.gurbetoglu@pardus.org.tr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19Colibre icons: update math app iconandreas kainz
Change-Id: I567237f6bd379a0319511dd9dc15843e79da5291 Reviewed-on: https://gerrit.libreoffice.org/53140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19Add help button to signature line dialogsSamuel Mehrbrodt
Change-Id: I984889c374333a7c76dac0221334366cfdf471ee Reviewed-on: https://gerrit.libreoffice.org/53106 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-19tdf#42949 Remove unnecessary localization headers from reportdesignGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<core_resource.hxx\> -e \<strings.hrc\> reportdesign/ | xargs grep -c RptResId | grep :0$ | grep -v /pch A few false positives were omitted from the commit. Change-Id: I93a17a3edb2c9ab89a913c92541eafb250086201 Reviewed-on: https://gerrit.libreoffice.org/52910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-19Colibre icons: update notebookbar icon to hamburger menuandreas kainz
Change-Id: I45cf2ed0a4eed8a879eb7b157c79c3fb06d72dea Reviewed-on: https://gerrit.libreoffice.org/53139 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-19comphelper: fix some doxygen tagsChris Sherlock
Change-Id: I75fb71ac88f48d3a821aa8b2cefd395a70cf35bb Reviewed-on: https://gerrit.libreoffice.org/52555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-19sw: remove dead SwLayoutTestMiklos Vajna
Obsoleted by SwLayoutWriter and SwModelTestBase::dumpLayout() in general. Change-Id: Ibcd1b34aaa8781f3199572f8795f2cb6daff264f Reviewed-on: https://gerrit.libreoffice.org/53127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-19gla11y: fix a grandfathered warningCaolán McNamara
Change-Id: I1741f5822c5132e4176c6a46248feee2ac8a72a8 Reviewed-on: https://gerrit.libreoffice.org/53126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19weld CompressGraphicsDialogCaolán McNamara
Change-Id: I593e6f0fe2e002c75ecd367a38dda96e7e6552f9 Reviewed-on: https://gerrit.libreoffice.org/53125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-19drop IS_SET macroNoel Grandin
Change-Id: I876462e3f436b1540bb1a7ef92f184fa1c0be0e8 Reviewed-on: https://gerrit.libreoffice.org/53102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19NB Implementation: update calc data tab .ui fileandreas kainz
Change-Id: If317a6183dffc2d5411c7da49bb26ed25973964a Reviewed-on: https://gerrit.libreoffice.org/53135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19NB Implementation: calc data tabandreas kainz
Change-Id: Ia1c0ba09b683501093065045163c406b1187b050 Reviewed-on: https://gerrit.libreoffice.org/53134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19tdf#96795: Use locale-sensitive sorting in Android viewerMert Tümer
Change-Id: I98edec9f57f1bf0576e16a1ba3c0e023d6d0b6ed Signed-off-by: Mert Tümer <merttumer7@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/52494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-04-19NB Implementation: add print / presentation action to shortcuts listandreas kainz
Change-Id: Id49672a9a363e78844d08d18e34944dbd7a4711e Reviewed-on: https://gerrit.libreoffice.org/53131 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19NB Implementation: update notebookbar wheel popupmenu for writerandreas kainz
Change-Id: Iaf0df12029298f775ba8c2a7502465e1f7f67159 Reviewed-on: https://gerrit.libreoffice.org/53132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-19NB Implementation: update writer tabbed toolbarandreas kainz
Change-Id: I6e62053836a279c487bc5d3eeba9032b4ec72852 Reviewed-on: https://gerrit.libreoffice.org/53128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18NB Implementation: add icons to impressandreas kainz
Change-Id: I0192a431f79a46fa17b214fb9c978ec0215f061c Reviewed-on: https://gerrit.libreoffice.org/53123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18weld EPUBExportDialog and add parentCaolán McNamara
Change-Id: Iec4fa3afb1e90ec36f792ea65b8c57b11cff98b3 Reviewed-on: https://gerrit.libreoffice.org/53094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18weld SwCreateAuthEntryDlg_ImplCaolán McNamara
Change-Id: Ib654539cca64efe479cf3c9b8b585ab17019edeb Reviewed-on: https://gerrit.libreoffice.org/53117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18tdf#42949 Remove unnecessary helpids.h from sc.hrcGabor Kelemen
There is only a few files now where HIDs are set from code so no need to include helpids.h into the widely used sc.hrc Change-Id: Id7c9ef7fdf299c580f597e4c27ba8bece3d99f5d Reviewed-on: https://gerrit.libreoffice.org/53076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#117053 create database wizard: set a property when it is supportedLionel Elie Mamane
not only when we let the *user* set it in the "Advanced Settings" dialog. There are two notions: 1) Does the driver/datasource support a property 2) Do we show the user any UI in "Advanced Settings" to change that property. Notion 2 is called a _Feature_, notion 1 a _property_. Database creation was saving properties only in case 2; the right test is obviously case 1. Change-Id: Ie740c9eb6768ae5f412a49119201e9211a9cd07d Reviewed-on: https://gerrit.libreoffice.org/53121 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18NB Implementation: calc -> view shrink labelsandreas kainz
Change-Id: Id865c864d175e31de49b8eb62df8b6ca144fd50c Reviewed-on: https://gerrit.libreoffice.org/53104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18sw XHTML export: close <col> for tablesMiklos Vajna
By switching to HtmlWriter instead of manually constructing HTML elements / attributes. Also fix a validity problem for ReqIF (transitional XHTML still allows that, so not depending on mbXHTML here). Change-Id: I4f3fef781fdbb4c72824701ad6d380cece8e6f81 Reviewed-on: https://gerrit.libreoffice.org/53120 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18tdf#117081: show Firebird by defaultXisco Fauli
Change-Id: I4247b86cdbe332bd6c529b075174e3657fbfa9e1 Reviewed-on: https://gerrit.libreoffice.org/53090 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-04-18tdf#45904 Move _XScenario Java tests to C++Jens Carl
Change-Id: Ic12eebe62de5132dce26ec46c62501f90200b909 Reviewed-on: https://gerrit.libreoffice.org/52180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-18Missing newlineMike Kaganski
Change-Id: I20ea4b43c1cbf5a79a1d52c0c8c27018b003411b Reviewed-on: https://gerrit.libreoffice.org/53101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-18gla11y: Add dependency on .ui filesSamuel Thibault
During the gla11y work, the dependency of UIA rules on the .ui files got lost, this adds it so that modifying a .ui file triggers checking accessibility with gla11y. Change-Id: I62103ca1783c2f532d7647384c1add1b557b37a1 Reviewed-on: https://gerrit.libreoffice.org/53116 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18Keep the still relevant part of external/icu/icu4c-ubsan.patch.1Stephan Bergmann
...which f247f08e370626bbb427acd8f4a400fd875350a3 "Upgrade to ICU 61.1" had removed completely, in error. Change-Id: I7239011561851333cac58e54e4e7d590b8529dbc
2018-04-18vcl: WNT: *really* avoid calling SHAddToRecentDocs() from unit testsMichael Stahl
At least in sw unit tests, AddToRecentDocumentList is apparently called too early so the variable isn't set yet. It's much better to check IsHeadlessMode anyway because that is set in more situations, and if you run soffice --headless you probably don't want the corresponding files to show up in Explorer's Recently list. Change-Id: I8ada3659d05c94d072ba30859090e835a595e9ea Reviewed-on: https://gerrit.libreoffice.org/53100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-18Fix translation domain in a couple of .ui filesAdolfo Jayme Barrientos
Change-Id: I0eb57c1c2e4fe53906ecf9da1d4841bbc250c4e5
2018-04-18tdf#117044 Base crash when attempting to edit a table definitionNoel Grandin
this story started in commit 433fc2214c980abd82fa6240f45e634a53a3c61c (patch) sal_uIntPtr->sal_Int32 in MultiSelection which caused a regression, reported in tdf#116981. I attempted to fix it in commit 235d61890512894e27f4f81e38a325eee3c67b30 Date: Fri Apr 13 17:14:59 2018 +0200 tdf#116981 Base when deleting table column and commit 0973e1f4e727a3204c843398bcb0e6a411b1a02d Date: Mon Apr 16 08:28:16 2018 +0200 follow on for tdf#116981 But my analysis was wrong. To recap, and get it right: Before all this, MultiSelection stored it's values internally as sal_uIntPtr, but returned them as long in FirstSelected(), NextSelected(),and SFX_ENDOFSELECTION was defined to be ULONG_MAX. On 64-bit Linux, sal_uIntPtr is typedefed to sal_uInt64, and ULONG_MAX is 2^64, which means that previously, the SFX_ENDOFSELECTION value was being converted from 2^64 to -1 when it was returned, which was why these loops worked. So convert SFX_ENDOFSELECTION to -1 to match how how the external code wants it to be (and the code frequently uses -1 instead of SFX_ENDOFSELECTION or BROWSER_ENDOFSELECTION) The modification to MultiSelection::Select is necessary because previously, nCurMin and nCurMax would be == ULONG_MAX, and we would, somewhat unintuitively, end up in the // expand on left side? if( nTmpMax < nCurMin ) part of the logic, which would do the right thing, even if a little weirdly. Change-Id: I7c830b0392add394d8c294247f75a2ffe8017c24 Reviewed-on: https://gerrit.libreoffice.org/53022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#116990 Unwanted line breaks if ODS export to XHTMLAndreas Brandner
Change-Id: I86cc48d74f0572a7ba18beabbaf307bcaa069d38 Reviewed-on: https://gerrit.libreoffice.org/53087 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-04-18convert DelCellCmd to scoped enumNoel Grandin
Change-Id: I4766fc874026f218b33e66944b98562d1ec614d3 Reviewed-on: https://gerrit.libreoffice.org/53088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18vcl: WNT: avoid calling SHAddToRecentDocs() from unit testsMichael Stahl
On Windows 10, Explorer spends ridiculous amounts of CPU with updating its recent documents view while tests are running. Change-Id: I170306a392900fc4b911950e36f13f1af0e405ac Reviewed-on: https://gerrit.libreoffice.org/53058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-18Upgrade to language-subtag-registry-2018-03-30Eike Rathke
Change-Id: I0cc3104cfccebe5d7e3fcafdb71d73a9d8d5e3d8
2018-04-18Upgrade to ICU 61.1Eike Rathke
Change-Id: I89c1c3d13d85decc72576744de2a16d20471d29d Reviewed-on: https://gerrit.libreoffice.org/53064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-18Related: tdf#117068 inform salframe that there's a modal dialog runningCaolán McNamara
Change-Id: Ie95fbc1586e11396271fb43e6117f39f4f61cb0e Reviewed-on: https://gerrit.libreoffice.org/53086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18fix oss-fuzz buildCaolán McNamara
https://github.com/google/oss-fuzz/issues/1335 Change-Id: I7681413d5e45e1e2f1ff62a077a067b11e42b4bb Reviewed-on: https://gerrit.libreoffice.org/53082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18sw HTML import: use GraphicDescriptor to determine default sizeMiklos Vajna
Rather than the hardcoded HTML_DFLT_IMG_WIDTH / HTML_DFLT_IMG_HEIGHT defines. Change-Id: I4ed2207ce3fdcd247054941d91eb67a679fb370c Reviewed-on: https://gerrit.libreoffice.org/53081 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18avoid error message from configure about clang's header for compiler pluginsLuboš Luňák
The header fails to compile without C++11 with recent Clang, and although configure currently passes the check because the existence of the header is considered to be enough, it still prints a distracting error message about the compile check failing. Change-Id: Icf037114b73122f193629e17a8e2b0e2bca3a990
2018-04-18Fix typoAndrea Gelmini
Change-Id: Ia4733366338ceda7af4ee26914be38798b8c7e16 Reviewed-on: https://gerrit.libreoffice.org/53079 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18tdf#75398 - Replace hicontrast by Sifrheiko tietze
Change-Id: Idd581cb73d0d32d808177f86beaf50dcc6bf53c1 Reviewed-on: https://gerrit.libreoffice.org/53053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page header and footer panels were completely missing labelling The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I3ca6b1984fab23478a11e916f26702592a5ee991 Reviewed-on: https://gerrit.libreoffice.org/52948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page style panel was completely missing labelling. The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I741ddea4a1608f0d7084dda79af2ab59a6fc5812 Reviewed-on: https://gerrit.libreoffice.org/52947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page format panel was completely missing labelling. The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I1c026f7a743b5da45f244d2527ab2b66165ccd4a Reviewed-on: https://gerrit.libreoffice.org/52946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18tdf#94300: Use named gradients | hatches | bitmapsKatarina Behrens
this helps chart sidebar to identify them by name when switching between different kinds of fill types. Also prep work for tdf#113688 Change-Id: I7cb148562cfa50704f27fa3273d93941eb01a7ab Reviewed-on: https://gerrit.libreoffice.org/52961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18Resolves: tdf#117046 messages set after dialog created should affect sizeCaolán McNamara
Change-Id: I03688ec1d869720b4a042602ff1da15727174592 Reviewed-on: https://gerrit.libreoffice.org/53046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>