summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-23prevent some "index hint out of range" warningsNoel Grandin
Change-Id: Ib3d4dce2e535fb16a0f34c01c03c71927fa5cdd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152160 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23a11y: Fix returning unpaired surrogates when retrieving charactersColomban Wendling
Fix implementations of XAccessibleText's getTextAtIndex(), getTextBeforeIndex() and getTextBehindIndex() when called with AccessibleTextType::CHARACTER to return the whole code point rather than an unpaired surrogate. This is still not perfect because XAccessibleText::getCharacterCount() will return an incorrect value (code units rather than code points), but it fixes the most useful case of retrieving the character at e.g. the caret offset. This fixes the GTK3 and Windows backends as well without further changes. Qt6 also mostly works according to Michael Weghorn, but for a bug on Qt's side (https://bugreports.qt.io/browse/QTBUG-113438). MacOS backend doesn't seem to be affected in the first place. Change-Id: I53f07bcba78c6b267939257542a521b106101e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151303 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-05-23tdf#140557 notebookbar: be smarter about hidden window sizeJustin Luth
This fixes a 7.1 regression from 53d73d532281b6734a7d4614bb74fc6cc15510f0 where notebookbar controls were being hidden (and then shown after a refresh of the toolbar), leaving big empty gaps. I don't know anything about vcl or window layout idiosyncracies, so I just read through this code looking for some way to fix the problem of the notebookbar not using all of its available space. The problem was that GetOutputSizePixel was returning zero. Why that would be I don't know. Perhaps because it had never actually been displayed on screen yet? (This was occurring on simply loading Calc.) Substituting a small DUMMY_WIDTH didn't give a very accurate reduction, so there was no space to add back in any items later on. When adding it back, it adds using a legitimate-seeming width, with an (unused this time) fallback to DUMMY_WIDTH. So, unless getLayoutRequisition cannot be depended upon for returning an accurate size, this should be a nice fix. It will no longer hide too many controls from the notebookbar. Change-Id: I1c39fe3532dad501c16f53612f8e26835b72638a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152125 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-05-23tdf#155002 sw floattable, split but not yet moved follow: fix GetNextFlyLeaf()Miklos Vajna
Trying to open the bugdoc resulted in a layout loop since commit b47401e12d9c45386899df0aa26653bd26c9abd4 (sw floattable: fix assert fail when object formatter gets the wrong anchor, 2023-05-22), previously could not open due to an assertion failure. What happened is that the anchor hosted a fly frame with a table, but the anchor was inside a section. Instead of splitting the fly and moving part of it to a next page, we constantly created and deleted new pages, without moving anything, which is a layout loop. In fact crating a new page in SwFrame::GetNextFlyLeaf() is not correct: we should realize that we're inside a section and let GetNextSctLeaf() handle the page (and section) creation. Once the anchor code is improved to detect that we're in a section, GetNextSctLeaf() creates the follow section, and later in GetNextFlyLeaf() the call to GetNextLayoutLeaf() will find the new follow section. Which means we have a place for the follow anchor and don't create any new page, fixing the loop. The import result of the bugdoc is still not perfect, but at least we don't crash or hang while opening the document. Change-Id: Ic0717dddbcd0949df7d4ae766f3cc0dbbbcff27a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152163 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-23Avoid -Werror=unused-function when building against older GTK4Stephan Bergmann
...as reported in the comment at <https://gerrit.libreoffice.org/c/core/+/151866/2#message-daf995784c18439280d3280877cfcf73d0bb5e9b> "Silence loplugin:external and lopluign:unreffun in (WIP?) a11y.cxx for now", > In file included from /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.cxx:17: > /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.hxx:19:24: error: ‘void* lo_accessible_get_instance_private(LoAccessible*)’ declared ‘static’ but never defined [-Werror=unused-function] > 19 | static inline gpointer lo_accessible_get_instance_private(LoAccessible*); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.hxx:21:24: error: ‘void* ooo_fixed_get_instance_private(OOoFixed*)’ declared ‘static’ but never defined [-Werror=unused-function] > 21 | static inline gpointer ooo_fixed_get_instance_private(OOoFixed*); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I40811235a66e429e2472b50bcbaa3e6fefa6a593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152147 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-23tdf#155235 workaround gtk3 accessiblibility crashes on closeNoel Grandin
we are still working around the problem here, which is that various bit are not firing accessibility events when their children change. So clear the static map in comphelper on shutdown, to prevent crashes resulting from objects being kept alive after vcl has shutdown Change-Id: I3ae216b345a1bb4cb4e3fde3527e4d4aa5968f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23[API CHANGE] Add createShortCutManager function to uiconfigurationmanager.Gökay Şatır
We need to have different accelerator classes for differnt languages. This PR creates a new accelerator class for different languages. Since current code uses single instance for accelerators, i needed to add a create function. Also we now have an unordered map for different languages and modules. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147157 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148680 Tested-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ia646f20b3206f430ece614fc127e8b748044e4c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151798 Tested-by: Jenkins
2023-05-23sd: fix crash in SdXImpressDocument::postMouseEvent()Miklos Vajna
Crashreport signature: program/libsdlo.so SdXImpressDocument::postMouseEvent(int, int, int, int, int, int) sd/source/ui/unoidl/unomodel.cxx:2615 program/libmergedlo.so doc_postMouseEvent desktop/source/lib/init.cxx:5007 Change-Id: I321f39b284f5917048925bf45c9a6417ac9cb2ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-23in online do less whole document invalidationCaolán McNamara
https://github.com/CollaboraOnline/online/issues/6379 lets at least halve the num of invalidations on joining a session. Change-Id: I8ceb0a9ee23d632c9fb2c4a96250cc259b4a2f29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-23tdf#120283 CopyObjects: Use CloneList to wire up connectorsDr. David Alan Gilbert
Remove the old connector wiring code and replace it by CloneList. The copy/paste code uses CloneList to do this work, and CloneList knows how to deal with groups; and not dealing with groups is the cause of tdf#120283 Change-Id: I48476a93a89c1a14f55ba206e0c8354823d0e8c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23tdf#155410 move some layer/object visibility computation inside SdrObjectNoel Grandin
which has the nice effect of (a) removing some duplicated code (b) being more efficient with deeply nested complex objects Change-Id: Ifee10d40fca3faac0f5a7b79febdba756850f30f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152124 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23Don't even bother to introduce unused variablesStephan Bergmann
With <https://gerrit.libreoffice.org/c/core/+/152157> "More conservative SAL_WARN_UNUSED to avoid -Werror,-Wunused-private-field", these two cases would have started to cause "unused variable declaration [loplugin:casttovoid]" (because the call to isWarnUnusedType in compilerplugins/clang/casttovoid.cxx would no longer return true). Just avoid that by not introducing the variables in the first place. Change-Id: I3d2b085082555d1765fbd32045b5157deb0af67e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-23tdf#155410 speedup shutdown when document has lots of imagesNoel Grandin
prevent unnecessary broadcasting during teardown of draw model regression from commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 ref-count SdrObject The above patch seems to have changed the destruction ordering and now we do lots of unnecessary broadcasting. Change-Id: I90f4e560bc82834246a323275d13ef8ee8abeae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23avoid some ref-counting traffic in SvxShape::NotifyNoel Grandin
which is quite a hot method Change-Id: I7fe6557d48cff8c9312b4dbcd24c215f16b9fcfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-23Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b79b0b978cd10d8bd2ef7ecf15972bfd1d778f3f - Add missing file this must fix https://gerrit.libreoffice.org/c/help/+/152130 Change-Id: Ic7c418c5993429cc622aa9a61023be3a58bb6f3e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152159 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-23sw: fix crash in DocumentLayoutManager::CopyLayoutFormatXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/sw::DocumentLayoutManager::CopyLayoutFormat(SwFrameFormat%20const%20&,SwFormatAnchor%20const%20&,bool,bool) Change-Id: I1680bb79be4c1eb2ff18ed46dfa286da5e729e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152015 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-05-23tdf#100034: Fix to persistently remove print-rangeCzeber László Ádám
Don't save print range if the builtin index is unknow and sheet index is vaild (this is a deleted range). Change-Id: I10dfa98ad4f24d0f5958053974bd75cb19c85147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152081 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-23Add configure switch to enable building the installer with WiX.Jussi Pakkanen
Change-Id: I5b1cf7a4a90c65b27fd3a9e2f33c9ffe044704e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151738 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-05-23ofz#59210 AbrtCaolán McNamara
Change-Id: I464f508324e66125a1578f162b5be31b00397075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-23Update git submodulesLászló Németh
* Update dictionaries from branch 'master' to e868c6a2b11784ff728588ef15f310737dce2747 - Update Hungarian dictionary Change-Id: I6627735ffefd6547deec31ece44faa57d3f4b3c4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/152089 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-23MCGR: Check correctly for used FillTransparenceGradientArmin Le Grand (allotropia)
To correctly check using UNO API if a FillTransparence- Gradient is used it is necessary to check if a Name for it is set. This corresponds to the IsEnabled() state of the XFillFloatTransparenceItem in the core. This was not consequently done that way and e.g. was done by checking if the FTG was 'default' in the sense that the StartColor was COL_BLACK. This was never sufficient and is not with MCGRs, too. Important in this case is the UnitTest checking for file fdo66688.docx - the re-export/roundtrip goes wrong when not doing this correctly. Change-Id: Iaf14c1e4481188124f044b4b3c8bcd6689c65aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152087 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-23Resolves tdf#145080 - Use accent color for focused cellHeiko Tietze
Accent color added but effectively working only on macOS See inline comments for gtk, qt, and win Change-Id: I1e4a729331735683921f94b27bb2bb02555c0165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-23tdf#143445 DOC import: limit the usage of the CONTINUOUS_ENDNOTES compat flagMiklos Vajna
The bugdoc has 72 endnotes and not all of them were listed at the end of the document, since commit 4814e8caa5f06c4fe438dfd7d7315e4a2410ea18 (tdf#124601 sw: add ContinuousEndnotes layout compat option, 2019-09-30). The problem is that for simple documents the strategy to just place the endnotes (in the form of footnotes) on the last page works, but this approach breaks when the document is growing, since nobody moves the endnotes from the former last page to the new last page. Additionally, it's not trivial to know what the effective last page is, once you have enough endnotes that the end of the body text is not on the last page. Fix the problem by restricting when the DOC import sets this compat flag. The limit is picked to be 2 endnotes, just because that keeps the use-cases for continuous endnotes working. A future solution would be to create a layout-level section at the end of the document for such endnotes: that would allow them to be inline, and we know how to keep endnotes inside a section & know how to keep a section at the end of the document. But that would be a bit of a feature work, let's keep this regression fix simple. Change-Id: Ideea1c52f4e31ded3e28e9441aace2bc3857079e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 017955e2322d86929802db5ebcbce65889345528 - remove xml-lang, formatting clean-up, no i10n consequences Change-Id: I7ce3f3722c6a3f52f89623f39683d0a23daa8f36 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152101 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 26a379d7f2c21de638bbeb1e7d4032896ac326d4 - tdf#153561 embed sections: <hyperlink>,<tab_options>,<headinginfo>,<eval>,<tab_relative> remove <xml-lang> Change-Id: Ia8aa894ffc112d7ec16991cbcc44ab963903fc52 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152099 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-23sc drawstyles: Enable the clear DF commandMaxim Monastirsky
.uno:StandardTextAttributes works for shape formatting already (despite its name), but it's a different command than Format > Clear DF. So let's connect the regular Clear DF command to the same code. Also includes a workaround for comments to maintain their size. Changing the size (because of the "Fit height to text" setting) is probably confusing for other shapes as well, but for comments this requires an extra step to undo, as comments can't be resized unless they're shown permanently. And manually resizing each comment back will also result with inconsistency in their size. Change-Id: I7c158523ecc4be18d17479632eaf9fd2a51dca12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151161 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-05-23Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6d37d30f9474ae437544ce04cfdcbc4ba4119303 - tdf#153561 add <note> for heading info section remove <xml-lang> from bookmarks Change-Id: I75d1e5b2882816a66fc9859a881ae34381c969dd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152100 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-22Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ed9181c7a7b65f1de07c809b5ac515e4dfc73b7b - tdf#153561 add <section> to hyperlink, update hyperlink description remove <xml-lang> from bookmarks Change-Id: Ia29f026c9e40a58633c4428066ba9c8269cfe88c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152098 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-22tdf#155065 change label for "Page Number" -> "Page Number Field"Seth Chaiklin
Change-Id: I80b646857311e9fa910f3384e49ea965a1a7fb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151284 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-22tdf#155065 hide .uno:PageOffsetDialog from Customize dialogSeth Chaiklin
Change-Id: Iad95d757ed09921403f41ed3c757b34149ec8c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151285 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-05-22tdf#154186 change "OK" to "Apply" and rearrange button positionSeth Chaiklin
Some buttons are sorted automatically. As a result, the "close" button appears in the desired position, after the label change. Change-Id: I67ce06825a642fa34086f97a99cde8ac2acb1ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151195 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 033dc1a727a6cb48419a08990a2b737058afd99f - Calc Sheet Tab Navigator help page Change-Id: Ie79a7e1b6e3383d52660e48d145bec5ca7ca89af Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152130 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f412e2dadeeba74aa71293d010d9a6d092d38e64 - tdf#140091 Precisions for the (+) button in sheet tabs bar. Change-Id: I6c125b5fa230690f598399b68e1f310f4cbc25d5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152129 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-22Fix typoAndrea Gelmini
Change-Id: Ic3f79113f09be10f6ff33183b09f80e269f77f93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152122 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-22Fix typoAndrea Gelmini
Change-Id: I6fab6b5c40eb9668df72ea01a2d158eabdc99f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152121 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-22tdf#155271 add drawooo:display to libreoffice-schemaRegina Henschel
Commit 33ef17ed had introduced attribute drawooo:display at 2010-03-02. The entry in libreoffice-schema.rng was missing and therefore validation in unit tests fails, when this attribute occures. The attribute is written in case an object in Calc is hidden by hiding the cell to which it is anchored, for example. The attribute belongs to properties 'Visibile' and 'Printable' in 'Shape Service' in API. Change-Id: Id3d2e7984aed146fca9e2819eb183d7d7bfaf701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152119 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-05-22sw floattable: fix assert fail when object formatter gets the wrong anchorMiklos Vajna
A subset of the tdf#155002 bugdoc hit an assertion failure in SwObjectFormatterTextFrame::DoFormatObj() for multi-page floating tables. What happens is that a section frame wants to format its content, calls CalcContent(), which assumes that the text frame's all draw objects are also on the same page, as long as they are at-para anchored. This is true for at-para anchored images, but not for split flys. Fix the problem by using FindAnchorCharFrame() to know if the anchored object should be inside the master anchor or a follow anchor: that allows invoking SwObjectFormatter::FormatObj() with the correct anchor and page frames, so we don't hit the assertion failure. The hang with the original tdf#155002 bugdoc needs more work, still. Change-Id: I2b4d88ccb2ff251c0b0811c31d2aa85053143443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152116 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-22tdf#155368: sc_subsequent_export: Add unittestXisco Fauli
Change-Id: Ie177342720df50d160600cf133b87bdf3411203d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152114 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-22tdf#146547 Mark read-only docs as modifiedSamuel Mehrbrodt
when an editable section is changed. Change-Id: I588b09f160974d3a3833bfa011fd07f2ee496616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151535 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-22improve logging when we get an exception in copyPropertiesNoel Grandin
Change-Id: Id37ad92df93667536efaac86db3765da98847184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-22ScriptForge (SFDialogs: create dialogs on-the-flyJean-Pierre Ledure
A dialog service is returned by next statement dialog = CreateScriptService("newdialog", dialogname, place) All properties and methods applicable to predefined dialogs are available for such new dialogs. In particular the series of CreateXXX() methods for the addition of ne dialog controls. The functionality is available from Basic and Python user scripts. An update of the SFDialogs.SF_Dialog help page is required. A display rendering unstability (flickerings, delays, ..) has been observed when (all conditions must be met) - the user script is run from Python - from inside the LibreOffice process - the dialog is non-modal Change-Id: Id3f311cd04497fd79712ce712bdb2724b5caa861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152071 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-05-22tdf#155319 sc: fix conditional format data bar after copyingTibor Nagy
This is a follow up to commit I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 (tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scale) Change-Id: Iacc1f5af762e1f6a40ecd13c33384e4a3340822a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151860 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-22Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to b2e864f9b44f85777d7679cb3696a5a801b8ee97 - update translations for master/7.6 and force-fix errors using pocheck Change-Id: Iec9043ba6ba5c1520fd5906a7ebfc8c7ae94a2c5
2023-05-22sw: prefix members of XMLGradientStyleExport, XMLGradientStyleImport, ...Miklos Vajna
... XMLHatchStyleExport and XMLHatchStyleImport See tdf#94879 for motivation. Change-Id: I2dd4c97c6e234447190e46bd6f6a6354e16911bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152077 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-22tdf#155368 Can't toggle Wrap Text on all cells if cell already hasNoel Grandin
The problem is not so much that we cannot toggle, it is that we cannot unset a toggle property. And the reason for that, is that the state of the toggle never goes off because the view state as computed by ScViewFunc::GetSelectionPattern is different from the state that is seen in ScViewFunc::ApplySelectionPattern where we apply the pattern. So make the same shrink-data-area adjustment in GetSelectionPattern. Change-Id: Ic56145ee98ead931278767851f74e0ce7422a150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-21Revert "tdf#63130 when getting the size, do not do a full paint"Caolán McNamara
because it is triggering many CppunitTest_toolkit_a11y failures This reverts commit 67c3b3becab2aa2b9522e3a092d46bfe507c3101. ImplCallResize is not called on the same Window after that commit than it was originally called on. Change-Id: I0c3721d2674067ac7f0bf765e0fe1097b1d67dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-21tdf#155349 add a test case to catch if full invalidation ever returnsCaolán McNamara
Change-Id: Ifea1102fd27643ba950b4c9e8d42dd06c1ce71e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-21tdf#155412 ooxml export typeface attribute is mandatoryRegina Henschel
The attribute 'typeface' is required for <a:ea>, <a:cs> and <a:latin> elements, see CT_TextFont in ISO/IEC 29500-1:2016. Its value may be the empty string. Change-Id: I7c9316fa40ad6d1aabccb4191fee11be553c453b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152024 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-05-21oox: convert odp documents to fodp so it is easiert to changeTomaž Vajngerl
Mainly to change the non yet fixed theme ODF format. Change-Id: Iad51de7b4f9a721e566fe12266e633534c15bb54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152052 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-21xmloff: rename XMLThemeColorHandler to XMLComplexColorHandlerTomaž Vajngerl
Change-Id: Ib24c4b819c31cdc6a9626b09a5b2acd10389ad7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152051 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-17 19:53:31 +0000