summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-05New loplugin:dynexcspec: Add @throws documentation, dbaccessStephan Bergmann
Change-Id: I117be0dca3cc5e204414613123422b4b0716d8ed (cherry picked from commit 4c81fe62c16b0ebc7f86ff589880169247584c8e) (cherry picked from commit efb1db0b656d7ffe57a9b3cc23c7ebeb1b319f26)
2017-12-05remove UL/L suffixes from shift-by-constant expressionsNoel Grandin
Change-Id: Ia470f643e3eefeccc14183133603db260460bd53 Reviewed-on: https://gerrit.libreoffice.org/41212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 224b770fa77fe12ad5dc543ce020aca316b6558d) (cherry picked from commit 58c171983d4f828d36bf1f6d8fb8329e69424c7e)
2017-12-05move the exception handlingCaolán McNamara
Change-Id: Ie61a424a78be85c1dc54dd56451319356227f443 (cherry picked from commit ce0e70fdd643b88b70cbcfa55847f0285116273a) (cherry picked from commit 0b50531a401f405edd9f1c889512171d3273169a)
2017-12-05loplugin:loopvartoosmallStephan Bergmann
Change-Id: If76fa042462897735d0d67341a3734b8cfced12c (cherry picked from commit 6412b9c5dd10af511cc255a952be4b18a25ab9a8) (cherry picked from commit 3f447f4a613dc692f4775b2d8988711213b01b42)
2017-12-05tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c (cherry picked from commit 9e51007039770370182839846676b205f5c34c57) (cherry picked from commit a090e1e17962c5ca95f66c9d18fca6ac5dd4bca0)
2017-12-05better fix for tdf#101563: Export to PDF creates huge PDF filesNoel Grandin
Change-Id: Idda6a5ac824090e620fc6577fc82d5c5f1234b7e Reviewed-on: https://gerrit.libreoffice.org/33037 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 24fa5d0570b997cc92f1fdf412f517f8d4021207) (cherry picked from commit df7e1cb393083b30b7a1dd25539f0f3831b80ba2)
2017-12-05fold ImplConstruct into ctors and reduce to necessaryCaolán McNamara
ImplConstruct sets mnAnimationLoopCount, but is always followed by ImplAssignGraphicData which overwrites it so we can omit that ImplConstruct sets mnDataChangeTimeStamp, but is always followed by ImplAssignGraphicData which always calls ImplAfterDataChange which overwrites it so we can omit that Change-Id: I2304dc1ea590071a83ca30768426f721c1bd259c Reviewed-on: https://gerrit.libreoffice.org/32953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4ff1b3589076f66c3d783c3ea6c5f1fd9b9337ed) (cherry picked from commit 5df3ec82798e3fff1ea1e71e64a23e501c89af22)
2017-12-05mpGlobalMgr must already exist if we're copying from another GraphicObjectCaolán McNamara
Change-Id: I7befa3bf8c80ed71d13a1481569bb046036cbd21 (cherry picked from commit adea1891e5d195a450a2ed0906e0af7424902146) (cherry picked from commit df86ef575bb68a0eced0226ba2e320d7503d5475)
2017-12-05post ctor, pre dtor there is always a mpMgr and its mpGlobalMgrCaolán McNamara
move the ImplEnsureGraphicManager calls to be the first thing in the ctor to ensure that its also always available during the ctoring, this is hopefully a good change Change-Id: Iccddee7cac152df66dec0039df207a7575e1fa54 (cherry picked from commit a1d3dc1cbd1ca8b61e717c8ef8c7fdfe3ec33045) (cherry picked from commit 0cd69d16547020bc2e8eae326cf6ef12836dc3d5)
2017-12-05mpGlobalMgr has to exist at GraphicObject dtor timeCaolán McNamara
Change-Id: I75d82c041aa5a01bab3dceecaaa132ce9172862b Reviewed-on: https://gerrit.libreoffice.org/32899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 11e5668f12565ad9b1acb5c0085653c7a22ca329) (cherry picked from commit a12e49be7f91611d03b704b878b55dcd97681532)
2017-12-05mpGlobalMgr is the only manager possibleCaolán McNamara
Change-Id: Ic7e20c9c198cfdab73647b009af3e269aabf680f Reviewed-on: https://gerrit.libreoffice.org/32898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bd5ec81c78df81fb85a036d07cc4d60d01575fd0) (cherry picked from commit 64882d474fbd651f144cb8e9c4d6b53ad57c85fb)
2017-12-05move the ImplRegisterObj outside ImplSetGraphicManager and rename itCaolán McNamara
Change-Id: I1eded3ee41787b9a3339e01cf6e1157724bba1a6 (cherry picked from commit 8065e33626b8b9cf02caaa12b345b538535a8acf) (cherry picked from commit 4c13d773bf597fc31f97cdd6fdd6085d6aec44b6)
2017-12-05ImplSetGraphicManager only called from ctors now where mpMgr is nullptrCaolán McNamara
Change-Id: Ib275f4c803d74eaf45409e78a6c786dac159af6b (cherry picked from commit f0ab4138ca30690c4779c6a440826de3bd6fc8e7) (cherry picked from commit ff182e7569f003e6bd1f9bcba3588b4590d88242)
2017-12-05GraphicManagerDestroyed would just set the default manager againCaolán McNamara
which is the only one that could already be set. Seeing as the manager is always there if a Graphic exists then the maObjList must be empty at the dtor time Change-Id: Id447d1e62a4b94b0ef986edf3cc05629c90e511b (cherry picked from commit 3a44ef1d5de57022ad2f5339dbcbfa534174eb9f) (cherry picked from commit 4ba98391b536997413be837803566a7d03ba8d4c)
2017-12-05unfold and unindent else causeCaolán McNamara
Change-Id: I22131a477547ac08b0c6b762353c9796f80c3666 (cherry picked from commit 9d138866d269eea262b22497af62b09570bd7a05) (cherry picked from commit 21d4a03363b776109deaa6cef541a071f244d7a5)
2017-12-05the only GraphicManager is the mpGlobalMgr, so simplify accordinglyCaolán McNamara
Change-Id: I5b237e27815e138cdcab75b1b9f657882ae8a37b (cherry picked from commit 6b0ae6c674e0216bc916232e500515f9eb764664) (cherry picked from commit 27b3043ac1d125e48fbb857282759d67acf1b2b6)
2017-12-05collapse !mpMgr || mpMgrCaolán McNamara
Change-Id: Id93b2da5665c47b1e8941d2f7428fe078c6227f7 (cherry picked from commit 7aaa217894fad1b3fd5c06cc77a216a87adae93d) (cherry picked from commit a5fd6e0d34db092c89e0fd7a0be210705dcc7735)
2017-12-05first GraphicManager* arg of ImplSetGraphicManager is thus always nullCaolán McNamara
Change-Id: I3da98280d3c1d95663e6e43ce7a5ca82c001c334 (cherry picked from commit 8564b5beb1c49104d555e70d3c6134908fc0811f) (cherry picked from commit cde9409ac3069cd91a1cde6e4fbb68e9fea3f5f9)
2017-12-05second arg of deformed copy ctor isn't usedCaolán McNamara
except in the qa test Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526 Reviewed-on: https://gerrit.libreoffice.org/32890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 855fbe4edccf5c8299373087eb2cee5342ba4097) (cherry picked from commit 67e7354564cf52eef45f5c405b5cc8f10f75d76a)
2017-12-05return false on exceptionCaolán McNamara
Change-Id: I478724b2842eed847c28fdd90c95ea86c80e86f4 (cherry picked from commit 487f349184013d718fe2a82336bfe0fec1bfd612) (cherry picked from commit f47f1e505b7fb16c140425cdad48c9471505eda3)
2017-12-05Improved loplugin:redundantcast, static_cast on arithmetic types: vclStephan Bergmann
Change-Id: I5c85d3df578d0b7e9ffc54679b73a0ce35de8620 (cherry picked from commit e2a218114de3fd74848323238188c847a733d9b3) (cherry picked from commit d0f734ca4f37b97dced4f2ebc13c86a45e17afa5)
2017-12-05ofz#984 better match post-creation aBitmap.HasGreyPalette() logicCaolán McNamara
i.e. Bitmap::HsGreyPalette checks that the palette has entries before calling Palette::IsGreyPalette Change-Id: I287647869ad615327f3119b7798f410e22140302 (cherry picked from commit 81894a5f7200b4c4233e407163b7f1b00256dccb) (cherry picked from commit eb801998a29012cb0c428057ae087288e3060752)
2017-12-05ofz: 0 bitcount bmps are unsupportedCaolán McNamara
Change-Id: Ibd7b25546006506350f9fc009596f2989a305a4c (cherry picked from commit d6eaa8aa5211f1c140d7e9ed27a7fef806b4af3b) (cherry picked from commit b8da9852dab1aa7942efb0c88390a01fc707fc15)
2017-12-05expand forcing to mono mask during load to non-indexed sources tooCaolán McNamara
Change-Id: I38c1eec5e180d689de72413b1438c88a1085bbb5 (cherry picked from commit 473066c526ac1d970658b39381436b23d78676ac) (cherry picked from commit e2a20b0795448df517b3932636bbdafffbb87565)
2017-12-05ofz#948 optimize the edge-case of converting masks to 1bit during dib loadCaolán McNamara
Change-Id: Ibed50b92ab49685a1ac033c93bd52bc7d2ea581c Reviewed-on: https://gerrit.libreoffice.org/35757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fa4120f270f64dae43b316fdd1bc41b48e2296d3) (cherry picked from commit 79224b9126c2af4ca04455bab8eb1383f300dac3)
2017-12-05move bitmap allocation after palette readCaolán McNamara
Change-Id: Ie7b2d64bde48d49c6e389c0770f2456187107bda (cherry picked from commit 155886c99ba55ef28bd902cfe7256cbc1f4d2d01) (cherry picked from commit 5805073cbd2260675ef206d228bb029ad5e94b51)
2017-12-05return early on errorCaolán McNamara
no logc change intended (cherry picked from commit ec1015430dcfd5a6e20a13d878bc34ce3149b8ea) Change-Id: I9a000ccc53b13d2948264b18ae0abf29a6ddc33c (cherry picked from commit 0a4ea263aca16eb05dd6c8d4ccb5ed2aca2b4a63)
2017-12-05process palette standaloneCaolán McNamara
Change-Id: I489a5cdecf4a5c856e9e5fdd03e6f9c920c0a4d5 (cherry picked from commit dfed481524113a1be03d29ec8a9e13bb96052895) (cherry picked from commit ddcb49d42089b2eec168afb63da551666aaa4a72)
2017-12-05ofz: reject broken rle bmpsCaolán McNamara
Change-Id: I1354d4aa4d7e46cd3bf463e3350071aad3ff5674 (cherry picked from commit f25cdaf6cba85a6a161755fe5f8067e479ab0414) (cherry picked from commit 7380cfc9263b5adbe91bd5433b6703bbea877882)
2017-12-05ofz#787 avoid bmp oomCaolán McNamara
Change-Id: Id5d1a1b8dd6d4e78bef9d09ab68d1e7daf7e1bd5 (cherry picked from commit 3d21afb8aac5da0139d85498607d40c748b6db53) (cherry picked from commit 025b5c8f3bb89015477fd43d3ec5a5fbb8a25843)
2017-12-05-Werror,-Wimplicit-fallthroughStephan Bergmann
Change-Id: I7a3f7233018e76208f80e47eb176c2879e943e47 (cherry picked from commit d6960667b4ff120e6c70aadf490b82911bdd7030) (cherry picked from commit 6bf54bac898e4d96fbd9dd5f9f6b114eafd99994)
2017-12-05reject bmps with unknown compression schemesCaolán McNamara
and RLE8/RLE4 compression with wrong bitmap depth Change-Id: I7e580cb119e90262a88c57b86f562eaba81c4944 (cherry picked from commit 82070481f34091718ee0ca0dd97826c7e3d7d79e) (cherry picked from commit abf93c45eed3b17b8831e4d0c0afccf6c839c637)
2017-12-05vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1 (cherry picked from commit 3a74745367a73ed9351379fc32bbe9253cdae697) (cherry picked from commit 3437713c11d60f99470fc1d0e2a8e5c56d5a6fe8)
2017-12-05loplugin: unnecessary destructor vbahelper..vclNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/33577 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 32a461bdd6ffda4b59ff262e1fcbcbe8bf2be7a0) Change-Id: I6b7800d4a456391251168f7923a1ec7a5ca9efc9 (cherry picked from commit 6a734daa02e7d816bf924465e53765b811a517d5)
2017-12-05Related tdf#101467: fix a leak with pSalMask (vcl/bitmapex)Julien Nabet
+ initialize pSalBmp+pSalMask to nullptr Change-Id: I320e9cf98ef8224e98303bec1e58f59dc5b1ad4e Reviewed-on: https://gerrit.libreoffice.org/41097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 68b0a61f7d4f89fd25b7725830b828c821da7dad) (cherry picked from commit 09d6dcc120902213cce7c3ebce84f0f0551c2fd8)
2017-12-05pQLine2 will be non-zero in any case that nHeight is non-zeroCaolán McNamara
Change-Id: Ic0fcf6c095dd2ebb2bfd901ac176229a95edd630 (cherry picked from commit 2670d43a840276d990a1c3bd993c06faa42e8b1d) (cherry picked from commit d74df1175c6f733026b30e03043b1eaa413cd23d)
2017-12-05pQLine2 will be non-zero in any case that nHeight is non-zeroCaolán McNamara
Change-Id: I5c836552df2122049dc88ca724444b29ae2c74e9 (cherry picked from commit 13f80252de289b666b5df126e1ec8a9c99445bac) (cherry picked from commit bfaf9b9dc59cd38a1480da61daf949736759b9ed)
2017-12-05crashtesting: empty ReadAccess on converting fdo58541-1.xls to pdfCaolán McNamara
Change-Id: I72c74c7224e99b090eceb8928eeddc3b50d1d2c8 (cherry picked from commit 537469f2294742fcd770b162ad965ad1c09cd72e) (cherry picked from commit 32d85e43062e846395bd96e9954790415a603bce)
2017-12-05ofz#968 short-cut slow create mask when we are our own mask alreadyCaolán McNamara
Change-Id: I5969226bf2da34d34e30e44ae763792cdc072bc8 Reviewed-on: https://gerrit.libreoffice.org/35921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 30d58306a93d4325f6388b8d05b9db91026c7c55) (cherry picked from commit b4e6579b3ad574bf44cda3a15e6ef6dc7d233c01)
2017-12-05tweak indent a littleCaolán McNamara
Change-Id: Icc3c69887a15eb0eacfa9209630a57f602c44422 Reviewed-on: https://gerrit.libreoffice.org/35920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d9d94d716903e34863b8e28fde90dcfbd4786284) (cherry picked from commit fe9d45a9c2b139094b6b5d5db1d7bc1224fe1d65)
2017-12-05ofz#954 out of memoryCaolán McNamara
Change-Id: Ib27f2dfe0d0837544910208f38a1bc11a35e3cb4 Reviewed-on: https://gerrit.libreoffice.org/35794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5d87c15ef0935081319afe2400c99df14d9fa258) (cherry picked from commit 84d743194e8f92117dff0eabc907c30926a95031)
2017-12-05move inlines into the classCaolán McNamara
Change-Id: If185834c35c9aa7d48e3305cfee3fde47826180f (cherry picked from commit 1a99e32f6fd6213981e9272c22f5019ed7444d1d) (cherry picked from commit a727ac86e1c6cd72d0edeac16edeefd9dcc261ba)
2017-12-05ofz#908 faster to scale a monochrome bitmap than a non-monochrome oneCaolán McNamara
so if both are wrong, correct depth before scale Change-Id: Ia0b6a194e14072a6f73f23e16ec640e0e1d34cf0 (cherry picked from commit 155b1bc18a180dc036d61eb98184737058b84b8a) (cherry picked from commit a80f6b79dfb4186084b509c7b43032591bcb2bf4)
2017-12-05improve readabilityJochen Nitschke
and make it easier to debug. top crasher in 5.3.0.3 is around this area: https://cgit.freedesktop.org/libreoffice/core/tree/vcl/source/gdi/ bmpacc2.cxx?h=libreoffice-5.3.0.3#n235 http://crashreport.libreoffice.org/stats/signature/ BitmapReadAccess::GetPixelForN32BitTcRgba( unsigned%20char%20const%20*,long,ColorMask%20const%20&)#summary in case someone wonders suffix increment '++' precedes dereference '*' Change-Id: I15876711db569d55739da3514f61ef1b981269ab Reviewed-on: https://gerrit.libreoffice.org/35099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b8261a99ae537078e0bc1c62154fc6c66c7556b4) (cherry picked from commit da47256fb15152971530f73bceeb3ba58e1dada6)
2017-12-05coverity#1402152 Uninitialized pointer fieldCaolán McNamara
forgot to remove this unused member Change-Id: I596d9f95284d1e27c2ca86e4c1ee75fc38cb7fce (cherry picked from commit 34e9e77bf38b9ea7569f6a051505ac92eb4ae825) (cherry picked from commit 7a1173f5e9a8e2e0f7f5053564295673a5fde6a1)
2017-12-05just calculate the scanline positionsCaolán McNamara
rather than generating a big offset table to dramatically reduce the amount of memory loading graphics takes Change-Id: I8a4b1dc5cbcb686d6b8570f2eeef61ee0fe25515 Reviewed-on: https://gerrit.libreoffice.org/35005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 25a5458e751f34063686c4fecd7b8bfc8a78302d) (cherry picked from commit 2e6a7c1973652a2041315e4853489c97b23d3710)
2017-12-05mpScanBuf can be privateCaolán McNamara
Change-Id: I78d6f94f65c9f6e667840c26c1359aa1ab9ad794 (cherry picked from commit c0b72399bb6bceb3d227b3323aabeaf768d31cb8) (cherry picked from commit ea8ab3e8795ca3f8919981d7f105762986228140)
2017-12-05bmp is never 'unique' so always copiedCaolán McNamara
cause we have a shared_ptr to it at this point, so its never unique, so a new copy is always generated. this really peaks memory with large images. Change-Id: I53dab2a1f6e5102b9af08dd6365187a383f7c247 Reviewed-on: https://gerrit.libreoffice.org/35003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 68aac9b1764338df0b6e7dc927955fecaa015d29) (cherry picked from commit 695a59146f8baf9207c89570b496c57ffde182dd)
2017-12-05convert BmpConversion to scoped enumNoel Grandin
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators Also fix a bug in x11::convertBitmapDepth where we were incorrectly passing BmpConversion enumeratirs to ReduceColors Reviewed-on: https://gerrit.libreoffice.org/34062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b5699cd01b6a52906880c107bac6f3802ea7353d) Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242 (cherry picked from commit 2d171734f349c0f9868106f57f5644a70fbeb945)
2017-12-05Bitmap::Convert->ConvertCaolán McNamara
Change-Id: Id8e6c4d7290eabdc32991bad1e8cda1f06c751f2 (cherry picked from commit b3bddf8b75226326a39f92f8fcb1745569b86caa) (cherry picked from commit ad885418bf59412fe7a85c86adb1fe2d4e7ae1d0)
generated by cgit (git 2.34.1) at 2024-07-11 15:48:14 +0000