summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-10crashtesting: threaded scaling crash on re-export of ooo24840-1.sxw to odtCaolán McNamara
#13 0x00007f1cb843752a in o3tl::cow_wrapper<ImplBitmapPalette, o3tl::UnsafeRefCountingPolicy>::operator->() (this=0x5596086d5968) at include/o3tl/cow_wrapper.hxx:329 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)" #14 0x00007f1cb843752a in BitmapPalette::operator[](unsigned short) (this=0x5596086d5968, nIndex=nIndex@entry=0) at vcl/source/bitmap/bitmappalette.cxx:139 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)" #15 0x00007f1cb849f5f5 in BitmapInfoAccess::GetPaletteColor(unsigned short) const (nColor=0, this=0x5596085989f0) at include/vcl/BitmapInfoAccess.hxx:114 __PRETTY_FUNCTION__ = "const BitmapColor& BitmapInfoAccess::GetPaletteColor(sal_uInt16) const" the mpBuffer member of BitmapInfoAccess is BitmapBuffer* mpBuffer; not const BitmapBuffer* mpBuffer; so mpBuffer->maPalette.foo() calls non-const variants of foo(), (BitmapPalette::operator[](unsigned short) in this case), which is presumably non the expected outcome, as the copy-on-write mpImpl of BitmapPalette unsafely creates a new copy its internals on the first dereference of mpImpl in a non-const method. Change-Id: I1ebb3c67386a9028e5b8bab4b2d1cc5862700aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10BitmapInfoAccess::GetColorMask can return a const referenceCaolán McNamara
Change-Id: I84c18b1d73910aa4c5a269e122f4ae86eb765e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121907 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10gtk4: use gtk_event_controller_key_forward to see if toplevel would use keyCaolán McNamara
Change-Id: Ia0074daab6528f561169ecaf5544fa1c969a7103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10gtk4: we don't need to block the drawing area as a focus candidateCaolán McNamara
because we put that as a child of the overlay so its not a focus candidate in the gtk4 version, and blocking the FixedContainer in gtk4 means none of its children can have focus since gtk4 and that the opposite of what we want to make focus traversal work between native gtk widgets Change-Id: Ide59e816189b5a89d13be9205d1fc9579ae33f92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10gtk4: complete child_grab_focus for gtk4Caolán McNamara
Change-Id: I35a19b4c95c1a57426a8fc51d4a15814ae443e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10Resolves: tdf#143777 Exclude recipient is always greyed outCaolán McNamara
Change-Id: I6ce94fad6ba518457665ae6d6b473cfe6f80849f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121905 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10tdf#144412 Qt5 reset m_nModKeyCode on key inputJan-Marek Glogowski
Switching the input direction on Ctrl + L/R-Shift is actually no bug but a feature. It is triggered on key release, so it can be distinguished from / doesn't interfere with shortcut handling. That's what should happen. So trying to implement that behaviour correctly and seeing the appearingly wrong modifier events for gtk3, I found gtk3 resets the frames persistent mnModKeyCode for key input events, which also seems to fix the problem for qt5. Some additional discussion is also in tdf#103158. Regression from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747 ("tdf#143298 Qt5 send SalEvent::KeyModChange events"). Change-Id: Iafcd1db7abcdf078001ca0602ae6e374f2a169ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121858 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-09-10Clarify that css::sdbc::XClob::getSubString takes 1-based posMike Kaganski
... and fix connectivity::firebird::Clob::getSubString. XClob::getSubString is modelled after JDBC counterpart, that also takes 1-based position argument. This is also described in multiple places in our code: - OPreparedStatement::setClob in connectivity/source/drivers/firebird/PreparedStatement.cxx - OSingleSelectQueryComposer::setConditionByColumn in dbaccess/source/core/api/SingleSelectQueryComposer.cxx - ORowSetValue::getString in connectivity/source/commontools/FValue.cxx However in some places 0-based value was used (fixed here). To clarify, the mention that the pos argument is 1-based is put to the corresponding IDL file. Also the code in connectivity::firebird::Clob::getSubString had multiple issues: - no checks of arguments; - possibility to throw "nPosition out of range" when just-read segment has enough data; - wrong start position in case when nPosition is not aligned to segment boundary. This change fixes these, and simplifies the implementation. Change-Id: I119a62dd7f02c9569ce36395ed8cc1a98c931fcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121884 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-10vcl: move outdevstate.cxx to stack.cxxChris Sherlock
Change-Id: I674be4eb758178468dbba70cb45d68d009952ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10clang:optin.performance.Padding in salNoel Grandin
warning: Excessive padding in 'struct ImplTextEncodingData' (8 padding bytes, where 0 is optimal). warning: Excessive padding in 'struct ImplByteConvertData' (10 padding bytes, where 2 is optimal). warning: Excessive padding in 'struct ImplDBCSConvertData' (10 padding bytes, where 2 is optimal). warning: Excessive padding in 'struct DirectoryItem_Impl' (11 padding bytes, where 3 is optimal). Change-Id: Ia19f192099c305734256103c7cdc0f64e398b6af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10crash in tdf132431-1.ods --export-to xlsNoel Grandin
probably related to commit 817ef891cf2bef8fdc82852f73acb422afb89bd2 tdf#142579 Consider color scale background colors in color filter Change-Id: I30bc477319ffc5474d9a27c4955603a183cccf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10Update git submodulesAndreas Heinisch
* Update helpcontent2 from branch 'master' to d6f20e65e37295a617c4bf0f534c8a0f746d7b19 - tdf#128018 - Adapted column/row labels to reflect the change of the descriptive statistics result Change-Id: Idc97739525180ba3acc8d1e636fe9209e4f78b67 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121881 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-10tdf#123055 - Start to read unicode text in order to avoid the BOMAndreas Heinisch
Change-Id: Ica5a2e11b4be1764cc94aafe5366197065cf6363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121391 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-09-10fix Skia/Raster screen flushing on MacLuboš Luňák
There's no window context in that case, so check the surface, as other places do. A mistake from 234ed4bcd5c4b5b41467890b82c6ef. Change-Id: I7f9d97340ed30444cb151c1141f8cc3045bd6dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121892 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-10gtk4: cannot focus to toolbutton if can-focus is falseCaolán McNamara
which seems reasonable Change-Id: I0cc5fecaace99f612d637c39065982ad12b23b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10drop stray fprintfCaolán McNamara
Change-Id: Ide4df588f8642b3eaad6dab4c819ba1914f3e2ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10This example doesn't have any idl filesStephan Bergmann
Change-Id: Ia70268084603db3329d276533a9351e6c1eebbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121894 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-10uitest: sw: Close the modeless dialogs after using themXisco Fauli
Otherwise, they will remain open in the next test Change-Id: I0019a3d98b7a66d6c4ba15408047facc7093cb5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121893 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-10tdf#142214: reintroduce unittest and adapt it to the expected behaviourXisco Fauli
The test was added in ca2ec443893731093970914feb750b31ea13e47f < tdf#142214: autocomplete: do not search across empty blocks > and later reverted in 85a46d2beefbd3d32fd221e8f9d247ff84adca26 < Revert "tdf#142214: autocomplete: do not search across empty blocks" > Change-Id: I5ca19ea9513740bfb6a197fe0a27860fa3cb6770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121871 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-10warning: Excessive padding in 'struct OutDevState'Caolán McNamara
experiment with optin.performance.Padding analyzer and tuning AllowedPad to 2 with clang as compiler; export ENVCFLAGSCXX="-Xclang -analyze -Xclang -analyzer-checker=optin.performance -Xclang -analyzer-config -Xclang optin.performance.Padding:AllowedPad=2" and get a report of: OutDevState (13 padding bytes, where 5 is optimal) UIControlOptions (9 padding bytes, where 1 is optimal) Change-Id: I174f6f62d6e32df057d5e0f21d4274166f6ed8c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121812 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10tdf#144353 - Handling of missing optional parametersAndreas Heinisch
Don't assign a missing optional variable to a property and don't allow the computation/comparision including missing optional attributes. In the previous cases a ERRCODE_BASIC_NOT_OPTIONAL is raised. Change-Id: Iab391286fcace16c271ae511304075e2a0c5c651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121794 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-10gtk4: default GtkViewport to can-focusCaolán McNamara
Change-Id: If4c730cef1782c20f6f8519e77ff336c0e9e692c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-10xmloff: ODF export: avoid mysterious crash while sorting shapesMichael Stahl
Apparently the draw page contains a null XShape. That sounds like a bug but OTOH this sorting feature from commit 9bc6160e0acbc78be998129ea55ed7e4529959faa isn't that important so let's sweep the problem under the rug. 0 swlo.dll sw::GetZOrderLayer::operator()(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const &) C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\zorder.hxx:37 1 mergedlo.dll xmloff::FixZOrder(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const &,std::function<unsigned int > const &) C:\cygwin64\home\buildslave\source\libo-core\xmloff\source\draw\shapeexport.cxx:1003 2 swlo.dll SwXMLWriter::Write_(com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const &,rtl::OUString const &) C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\wrtxml.cxx:190 https://crashreport.libreoffice.org/stats/crash_details/045adea4-c577-4164-9e69-bde5f892bd17 Change-Id: I1e67dc1c354cb14717cf9667314d6752e1b4c295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121860 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-10CppunitTest_sw_rtfexport5: simplify assertsXisco Fauli
Directly get the properties as Color Follow-up of 7b3a681a867eeb2d68abd4ce33b07cabfff224ef < tdf#141908: replace usage of sal_Int32 with colors > Change-Id: I23da21b88dad7758856c719ebebaef9ed6fe7ca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121868 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-10tdf#126426: support for hyperlinks in TextParagraphContextVasily Melenchuk
Usually hyperlinks are processed by TextBodyContext, but for grouped shape we accidentaly gone into TextParagraphContext It has almost all possibilities to process txbxContent, but not hyperlinks. Additionally some hyperlink char attributes (color and underline) can expand to follow up ordinal text. Additional small hack applied to avoid this. Unfortunately this is not a final solution: such document fails roundtrip and hyperlinks are lost after saving to DOCX. Change-Id: Ie954f53696bd872cb1f59cb586fb55f6cd7c73bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121172 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-09-10--without-system-cuckoo to override --with-system-headers didn't workCaolán McNamara
Change-Id: I7a516fb0b7449dd33f95724f311b63387cc42f34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121869 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2021-09-10cache FormulaError::NoRef error string (tdf#144249)Luboš Luňák
Those COUNTIF() may call it a huge number of times, and the translation of the string each time then actually is a noticeable impact. And ScGlobal already does one-time intialization of objects based on the locale, so one-time initializing a string there should be fine too. Change-Id: I0daeb50ccb43f780d99cf3838cfd1bf790c5f6cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121856 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-10do not intern a temporary cell error stringLuboš Luňák
Interning is way more work than a simple text comparison done once. Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-10tdf#144425 Set sane lower bounds (1) for MM e-mail output rangesGabor Kelemen
Lower bounds were forgotten to be set in weld commit f1ca64800074530d95e507f93c764a687310b9eb for the new GtkAdjustments of the GtkSpinButtons This caused no visible differences until commit d9fa826769cd570814f3556d53493a78d2869873 when new default values (0) were added for VCL FormattedFields This made it possible to email MM results on non-GTK vclpugs starting from 0th mail if custom range is chosen, which causes an instant hang in the sending process since there is no -1st generated result. The default Send all option has still worked after this. Then commit ec44f87d5b99a3299322d0b79abc4c6808877865 started to use the default GtkSpinButton values for default range of result generation, breaking the Send all option as well. Change-Id: I2a9f2b0954045700f947f342e5928ef75ce23aed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121865 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2021-09-10vcl: move OutputDevice::SetDigitLanguage() to text.cxxChris Sherlock
Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually, the plan is to separate metafile processing from rendering. Add unit test for SetDigitLanguage() and GetDigitLanguage(). Change-Id: I138d08c7d79c66d296b4c96eff644a40a379c6be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121023 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10vcl: move SetLayoutMode() to text.cxxChris Sherlock
Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually, the plan is to separate metafile processing from rendering. Also add a unit test for SetLayoutMode() and GetLayoutMode() Change-Id: I92cada7bf3d57ca8b84e04308c74428a1a19e775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-10vcl: move OutputDevice drawmode functions to outdev.cxxChris Sherlock
Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually, the plan is to separate metafile processing from rendering. Add unit test for GetDrawMode() and SetDrawMode(). Change-Id: I63948e7e4c332c786487c18c52faa60893f672a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121021 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-10A copy-paste message text errorMike Kaganski
Change-Id: I3d6f7a968fc5fca112087212ab7730f654534dfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121876 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-10sw layout xml dump: show SwParaPortionMiklos Vajna
Towards showing details of multi-portions, which are invisible to XmlPortionDumper, which uses SwPortionHandler, which was introduced for SwAccessiblePortionData, and is currently misused for debugging. Change-Id: Ib62df8c9338855b6f03b24ca2d83b4d0e4408761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121861 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-10Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3cc7fd773a5502b520f5240749420a9c63649aa8 - tdf#144398 Fix Slide master info in help page This patch also adds information about the option "Delete unused backgrounds" that is also available in the referenced dialog. Change-Id: I25ffea0acd456174181176375e1ab5075e2a17f7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121771 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-09-10Use std::vector instead of css::uno::SequenceMike Kaganski
This allows to avoid multiple reallocations during successive reads Change-Id: I74102d21c5dc4d1e92e27ede3490e9ed07bd568e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121873 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-10tdf#120129: don't forget to update buffer size to actual lengthMike Kaganski
Otherwise extra bytes get written to the resulting string from the too long buffer. Change-Id: Iccde16b8002f214df6f86f484f288ec464c6b674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121872 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-09Fix apparent typosStephan Bergmann
...introduced with aaebbb0e597bfeb8e1c545130a0d17a55b164228 "INTEGRATION: CWS jsc21" (but which never caused an issue as cppumaker generated output for all of $(COMP_RDB) anyway when the undefined $(TYPESLIST) didn't contribute anything to its command line) Change-Id: Ic6792ad9edc159c02d307ca72500605bc3c38077 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-09a system cuckoo isn't availableCaolán McNamara
build without it and see what warnings there might be Change-Id: I54b4d0c784631d26f634c63157563203bc37f1b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121864 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09crashtesting: assert making thumbnail on reexport of tdf127770-1.ods to odsCaolán McNamara
convert to B2DPolygon earlier and do scaling on B2DPolygon's doubles #18 0x00007f534e1093bc in ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long) (n=<optimized out>, nDPI=<optimized out>, nMapNum=<optimized out>, nMapDenom=<optimized out>) at vcl/source/outdev/map.cxx:268 __PRETTY_FUNCTION__ = "tools::Long ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long)" n64 = <optimized out> #19 0x00007f534e10a4ff in OutputDevice::ImplLogicToDevicePixel(tools::Polygon const&) const (this=this@entry=0x55c3ebbb9f60, rLogicPoly=...) at include/tools/gen.hxx:80 rPt = Point = {x = -794275722273860480, y = 0} i = 0 nPoints = 2 aPoly = {mpImplPolygon = {m_pimpl = 0x55c3e9fdc250}} pPointAry = 0x55c3e9c9b970 #20 0x00007f534e0ff4d4 in OutputDevice::drawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:251 nPoints = 2 aPoly = {mpImplPolygon = {m_pimpl = 0x7f534e0bfde8 <__gnu_debug::_Safe_sequence<std::__debug::vector<OutDevState, std::allocator<OutDevState> > >::_M_invalidate_if<__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > > >(__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > >)+208>}} __PRETTY_FUNCTION__ = "void OutputDevice::drawPolyLine(const tools::Polygon&, const LineInfo&)" aInfo = {mpImplLineInfo = {m_pimpl = 0x55c3eaa4ca68}} bDashUsed = <optimized out> bLineWidthUsed = <optimized out> #21 0x00007f534e0ff3d8 in OutputDevice::DrawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:135 __PRETTY_FUNCTION__ = "void OutputDevice::DrawPolyLine(const tools::Polygon&, const LineInfo&)" #22 0x00007f534e1f1d56 in MetaPolyLineAction::Execute(OutputDevice*) (this=0x55c3e998e300, pOut=0x55c3ebbb9f60) at vcl/source/gdi/metaact.cxx:481 #23 0x00007f534e1be27a in GDIMetaFile::Play(OutputDevice&, unsigned long) (this=this@entry=0x55c3e9e4c700, rOut=..., nPos=86, nPos@entry=4294967295) at vcl/source/gdi/gdimtf.cxx:371 nCurPos = 48 i = 48 pAction = 0x55c3e998e300 nObjCount = <optimized out> nSyncCount = 4294967295 #24 0x00007f534e1be4e1 in GDIMetaFile::Play(OutputDevice&, Point const&, Size const&) (this=this@entry=0x55c3e9e4c700, rOut=..., rPos=Point = {...}, rSize=Size = {...}) at vcl/source/gdi/gdimtf.cxx:512 aDrawMap = {mpImplMapMode = {m_pimpl = 0x55c3e9f338d0}} aDestSize = Size = {width = 756, height = 1020} pMtf = 0x0 aScaleX = {mnNumerator = 756, mnDenominator = 341, mbValid = true} aScaleY = {mnNumerator = 1020, mnDenominator = 461, mbValid = true} rOldOffset = Size = {width = 0, height = 0} aEmptySize = Size = {width = 0, height = 0} bIsRecord = false #25 0x00007f534e1be9c5 in GDIMetaFile::CreateThumbnail(BitmapEx&, BmpConversion, BmpScaleFlag) const (this=this@entry=0x55c3e9e4c700, rBitmapEx=..., eColorConversion=eColorConversion@entry=BmpConversion::N8BitColors, nScaleFlag=nScaleFlag@entry=BmpScaleFlag::Default) at include/rtl/ref.hxx:206 aAntialias = Size = {width = 756, height = 1020} aBitmap = {maBitmap = <incomplete type>, maAlphaMask = <incomplete type>, maBitmapSize = Size = {width = 94299930324064, height = 139995769668141}} aVDev = {<ScopedVclPtr<VirtualDevice>> = {<VclPtr<VirtualDevice>> = {m_rInnerRef = rtl::Reference to 0x55c3ebbb9f60}, <No data fields>}, <No data fields>} aNullPt = Point = {x = 0, y = 0} aDrawSize = Size = {width = 189, height = 255} aSizePix = <optimized out> nMaximumExtent = 256 aAntialiasSize = Size = {width = 760, height = 1024} Change-Id: I4284a7da0684845d7c0af136b25c5210d522c79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8eaf65fa4d1982ff60f612088adea6d636246612 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09tdf#143905: Parse password from connection stringjucasaca
Parse user and password, so its possible to connect to a firebird server more over embeded and file Change-Id: Idbfa526e2a29f6f8bed5165f57844350c8b6d127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121638 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-09Fix typoAndrea Gelmini
Change-Id: I899c68cf53657eaab6a72ae36594606b31d9fb8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121859 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-09tdf#144241 don't return a negative width for osx edit regionCaolán McNamara
instead expand the region to the min osx width Change-Id: I01dc336c97ba9573948e1ca8f3eeb3ac46008819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09flatten DocumentRedlineManager a littleNoel Grandin
no need to allocate these things separately Change-Id: I832e77587e1272a6be5dfc8d460891564ed07517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09reserve space in vector to reduce reallocationsNoel Grandin
Change-Id: I6263c0b742331138188f7b557c05b2a59188d4fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09fix std::move same object more than onceNoel Grandin
after commit 8104d771b10a5c8b15eae4b67aa112ae2ef77b5b tdf#144052 reduce Primitive2D copying spotted by mikekanganski Change-Id: I97e4675a9042cfafa3f9f6c053ba2f50aeea2183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09tdf#144052 reduce Primitive2D copyingNoel Grandin
when creating charts, by using a Primitive2DContainer&& parameter in the GroupPrimitive2D constructor, which forces the call sites to pass a temporary, and at most call sites, we can std::move in an existing local variable. Change-Id: I531970918800c6832ab606b5a4ff5fd2d47ccf5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-09Resolves: tdf#144389 get_accessible_parent should only be called on vcl implsCaolán McNamara
Change-Id: If5d8718fcd9bcccee37e162a99cc68ff4a77de8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-09merge ThumbnailView and ThumbnailViewBaseCaolán McNamara
only ThumbnailView inherits directly from ThumbnailViewBase and it will simplify a11y if ThumbnailView instead of ThumbnailViewBase is available Change-Id: I715faa3f9b2cec68c1de07479b7d1dbbd9ddbcc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-07 16:39:58 +0000