summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-11loplugin:simplifyconstruct in svtools..svxNoel Grandin
Change-Id: Ia20fac7cec01ac658a903f8b001807b2e72dbf3e Reviewed-on: https://gerrit.libreoffice.org/60316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11WIN drop unused fpicker subdirsJan-Marek Glogowski
While the folder picker had some shared code with the file picker, the folder hierarchy made some sense, but since it's gone now, move the files to the base directory. Change-Id: Ib78ada9cdb570df64ccbc28da835cfcaf25009db Reviewed-on: https://gerrit.libreoffice.org/60145 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-11tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[n-w]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I32e9e2fb636d80ce351d1ef7beb888afac0e8ee7 Reviewed-on: https://gerrit.libreoffice.org/60205 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-11Better check for MSVCStephan Bergmann
Change-Id: Ida9197e662f4f13baf834e54e2ff4f7dff65160f Reviewed-on: https://gerrit.libreoffice.org/60312 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-11tdf#119756 assume the HFONT is always validJan-Marek Glogowski
This is a regression from the commit 7cb3e475f2fb ("WIN add SalGraphics* to WinFontInstance"). We need a sensible way to compare the SalGraphics / HFONT. I'm not sure how to implement this yet, so just assume unchanged, as the old code did. Change-Id: I828a41e529976c500eedaef3afd40cf20287f746 Reviewed-on: https://gerrit.libreoffice.org/60256 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-11Revert "clang bugprone-unused-return-value"Noel Grandin
comment from sberg: aren't these changes broken in general, when the called function may throw an exception before it takes ownership of the passed-in pointer? So revert, except for (a) PlainTextFilterDetect::detect, which was definitely a leak (b) SwCursor::FindAll, where unique_ptr was being unnecessarily used This reverts commit 7764ae70b04058a64a3999529e98d1115ba59d1c. Change-Id: I555e651b44e245b031729013d2ce88d26e8a357e Reviewed-on: https://gerrit.libreoffice.org/60301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11cppcheck: variableScope in basegfxJochen Nitschke
and use range based loops on B2DPolyPolygon Change-Id: Ic68c236c839766a0c52369ae8487de187d1ad04e Reviewed-on: https://gerrit.libreoffice.org/60189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedmethodsNoel Grandin
Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11Use [[nodiscard]] in SAL_WARN_UNUSED_RESULT where availableStephan Bergmann
...which required some lax placements of SAL_WARN_UNUSED_RESULT to be fixed. Also, Clang unfortunately is rather picky about the relative order of SAL_WARN_UNUSED_RESULT expanding to [[nodiscard]] and uses of the DLLPUBLIC macros (expanding to __attribute__(...) resp. __declspec(..) for clang-cl). Change-Id: Iae6ca36bef97f1864873aefdb5f05c7f5e045ad3 Reviewed-on: https://gerrit.libreoffice.org/60274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-11ofz#10228 Integer-overflowCaolán McNamara
Change-Id: Ifb7e6ad6f5ffe71c3c5bb7cca9cb3b27bff7943a Reviewed-on: https://gerrit.libreoffice.org/60308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11weld SvxNumPositionTabPageCaolán McNamara
Change-Id: I95844c549393f5e151377cdfd79e770d1563b662 Reviewed-on: https://gerrit.libreoffice.org/60271 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11weld SvxBitmapPickTabPageCaolán McNamara
Change-Id: I4c5fd94356f3640b150ef9fec48a166457f3b70b Reviewed-on: https://gerrit.libreoffice.org/60266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11weld SvxNumPickTabPageCaolán McNamara
Change-Id: I575927d125af684e1133d6b46c0f637d996cbb88 Reviewed-on: https://gerrit.libreoffice.org/60265 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11tdf#108028 OOXML: Fix line breaking of chart titleBalazs Varga
With adding the "TextMaximumFrameWidth" property to the chart title's textbox property, it breaks chart titles longer then the chart width, as in OOXML reference implementation. LibreOffice previously distorted the text and squeezed the chart. This patch will fix it. Change-Id: Ic086d25b49e9c5cf9c6f2c79f141592749adc7d8 Reviewed-on: https://gerrit.libreoffice.org/59991 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-11tdf#119617 Fix export of Autofit property of shapes to PPTXBalazs Varga
With this patch the "Resize shape to fit text" property (TextAutoGrowHeight-->spAutofit/noAutofit) will be exported correctly to PPTX format. Change-Id: I5fa975c6390a17bad30c360b3b17aa944bbe72af Reviewed-on: https://gerrit.libreoffice.org/60043 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-11move 'features' button for format->character to next rowCaolán McNamara
for non CJK/CTL case, there's loads of space there for it Change-Id: I713e827b2d332fd29fec7f09f900406b98d08762 Reviewed-on: https://gerrit.libreoffice.org/60273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11sd: Drop unused ImplProcessObjectList()Takeshi Abe
which could be gone at commit 174bbee54828788eb562cb9b172200e509fdd08d. Change-Id: I2baa67123279f0da6f2443af6bfd351aaa9dfcd8 Reviewed-on: https://gerrit.libreoffice.org/60298 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:useuniqueptr in SwPaM::MakeRegionNoel Grandin
Change-Id: Ie069da6336d8d73c41c47a32308de751de438b31 Reviewed-on: https://gerrit.libreoffice.org/60253 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedfieldsNoel Grandin
Change-Id: I876183559a7d9f1e6d914fbf37d7ffe91459144e Reviewed-on: https://gerrit.libreoffice.org/60278 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:constantparamNoel Grandin
Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11tdf#119316 sfx2 store: no move on macOSMiklos Vajna
osl::FileStatus::getAttributes() and osl::File::setAttributes() doesn't preserve all the necessary file properties (at least "Hide extension" is not handled), so always copy on macOS instead. Change-Id: I529467cc3d432d04e593f936c13ed4656a18150c Reviewed-on: https://gerrit.libreoffice.org/60294 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-11clang-tidy bugprone-copy-constructor-initNoel Grandin
Change-Id: Idd435b3a4d081f6d3af26ff8add69ad4af50db57 warning: calling a base constructor other than the copy constructor Reviewed-on: https://gerrit.libreoffice.org/60239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11fix loplugin:unusedmethodsNoel Grandin
revert the part of commit 9f4d23c15115d64febd6bf01f870cc157badd350 Date: Mon Aug 13 17:24:26 2018 +0200 filter out some of the AST in the plugins that applied to this plugin. Turns out it really needs to see __all__ the code in order to produce good results. Change-Id: If580a701049d2570f2a833327b2189641090079b Reviewed-on: https://gerrit.libreoffice.org/60279 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:useuniqueptr in StylePool::createIteratorNoel Grandin
Change-Id: I1a7bdfc00352c25f5d2db9ef195000d16f909537 Reviewed-on: https://gerrit.libreoffice.org/60263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11prevent crashes when running the global-analysis pluginsNoel Grandin
Change-Id: Ib50583289afd6212d5d5aedd3d6b7ede75902052 Reviewed-on: https://gerrit.libreoffice.org/60277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:includeformStephan Bergmann
Change-Id: I4885c9ad497c350679588fc2068728c7a39edb88
2018-09-11tdf#109229: Set "TextBox" prop before filling textbox-related propsMike Kaganski
Otherwise those properties aren't set, and defaults are used Change-Id: Ib6671c019ff652ec5b59d9cbbf02a4e536a17817 Reviewed-on: https://gerrit.libreoffice.org/60267 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-10tdf#119777 min target is 3.18, not 3.20Caolán McNamara
Change-Id: I9d0ff68729df01f1d9dc9bb953be10ea44ce58df Reviewed-on: https://gerrit.libreoffice.org/60270 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10a11y: Remove unused warningsKatarina Behrens
since commit 1188bebbc53d0519733cfe98cfab4d83474e8ddf tdf#118742 - Input field dialog workflow Change-Id: Ied80dca50222de8dfea93d4d4fbee74c5255943c Reviewed-on: https://gerrit.libreoffice.org/60248 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-10a11y: Fix multiple instances of duplicate mnemonicsKatarina Behrens
Change-Id: I0ffe2a7c6b8102aa977af16232ce930541a8b816 Reviewed-on: https://gerrit.libreoffice.org/60246 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-10weld SvxSingleNumPickTabPageCaolán McNamara
Change-Id: I6d8cf1d63b30472072e2d464c3ba6f173f4d030f Reviewed-on: https://gerrit.libreoffice.org/60264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10weld SvxBulletPickTabPageCaolán McNamara
Change-Id: I0b3e48cc63984208c8e4a090d6630dd5325d776e Reviewed-on: https://gerrit.libreoffice.org/60257 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10wrap GlobalNeonMutex as local staticCaolán McNamara
Change-Id: I8d879877c93ce4d3a8f52fc707f94f2f095227d6 Reviewed-on: https://gerrit.libreoffice.org/60262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10add mutex guard to new methodsCaolán McNamara
Change-Id: I4d6ae0622107df6f619f945575687f616f184ccc Reviewed-on: https://gerrit.libreoffice.org/60260 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10suspicious MutexGuard placementCaolán McNamara
Change-Id: I3b5cf5984a1a852d2482b8a417fc46c836ea2dc2 Reviewed-on: https://gerrit.libreoffice.org/60258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10bounce callback functions back into class methodsCaolán McNamara
Change-Id: I5e449768f867d3d08ced830f9ea36f6519f4276a Reviewed-on: https://gerrit.libreoffice.org/60259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10No more need for extra local variablesStephan Bergmann
...after 453fde35bb838febf73bfda0bd981ee270c9b12e "BitmapFilter::execute can be const". This reverts the call-site changes of bce47223099bb3349d96af9d6b1fe88bcdd539df "clang-tidy bugprone-use-after-move in BitmapFilter::Filter" again. Change-Id: I5ce4eb7ddce90fb779ddfb1c5864fd4785708175 Reviewed-on: https://gerrit.libreoffice.org/60255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10weld SvxCaptionTabDialogCaolán McNamara
Change-Id: If678c5f4834144f1c710465701dc4d13714a6b44 Reviewed-on: https://gerrit.libreoffice.org/60247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10weld SvxCaptionTabPageCaolán McNamara
Change-Id: I163e00ce91cc207f735e67c32269ee2df0ffbfb6 Reviewed-on: https://gerrit.libreoffice.org/60245 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10sd / pptx export: get rid of GET and GETA macros.Mark Hung
Change-Id: Ib090bb3e9168e62767404823dd2beadd70eeb440 Reviewed-on: https://gerrit.libreoffice.org/60179 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-10Generate UNO exception classes as SAL_WARN_UNUSEDStephan Bergmann
...to find more places like 09978dd1fc18ce1ae707bc9e4ea1d2745ff07b61 "clang-tidy bugprone-unused-return-value" Change-Id: Ibe8b6790c701dc8270295dd1e2cbc9023b5ce018 Reviewed-on: https://gerrit.libreoffice.org/60234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10select an entry before setting sensitivityCaolán McNamara
Change-Id: Ifeafd4dedc77e5361a1ef6744a68f601ffd713bc Reviewed-on: https://gerrit.libreoffice.org/60227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10Missing includeStephan Bergmann
Change-Id: I7c0616ffefb00d45342013acc28460dcf76476cb
2018-09-10weld SwTableTabDlgCaolán McNamara
Change-Id: I343ddfd5ba1e42711b74815517ab931e0905dd07 Reviewed-on: https://gerrit.libreoffice.org/60243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10correct doxygen syntaxKorrawit Pruegsanusak
rename two functions according to 2a3678c713a88f43867aead48f320d1d301bcab1: * rtl_getCommandArg -> rtl_getAppCommandArg * rtl_getCommandArgCount -> rtl_getAppCommandArgCount Change-Id: I4bd3699640b03a062868b1f92fd6d78d75f5b3d4 Reviewed-on: https://gerrit.libreoffice.org/59910 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-10Fix for --enable-debug --disable-assert-always-abortStephan Bergmann
...found by <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1465/> Change-Id: Ia38fe5cac9fa187535599d313a3422c34458bcd9 Reviewed-on: https://gerrit.libreoffice.org/60242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10CppunitTest_sw_uiwriter: improve readabilityMiklos Vajna
Change-Id: I31121878ab71f318d3e5cbbcc769c9b9be10f004 Reviewed-on: https://gerrit.libreoffice.org/60244 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-10sw: prefix members of SwRedlineDataMiklos Vajna
Change-Id: Idf21b7f3330fdc4ecca6245494a788a33efee2a7 Reviewed-on: https://gerrit.libreoffice.org/60236 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-10Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Document Ctrl+Alt+Shift+Home -> .uno:Menubar "Main menu disappeared; how to bring it back" is an often-asked question Change-Id: I0ff70feb61a87c34ed80fe6b484c363c2e769b03 Reviewed-on: https://gerrit.libreoffice.org/60185 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-10Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - it is not possible to set negative angle for watermark Change-Id: Ie51a36a95c8443d56a559bf79fb9a674e9e1a283 Reviewed-on: https://gerrit.libreoffice.org/59615 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-15 23:12:27 +0000