summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-10static_cast after dynamic_castNoel Grandin
Change-Id: I3792ddadad9582a7e6f4740829c081d9571ddaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-10remove some old debugging codeNoel Grandin
Change-Id: Idd88e4dcc920d7dd198545e519d7860e59762bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-10Fix some warnings for Raspberry pi 4 (part5)Julien Nabet
Change-Id: I843746f976855168c791c97a56bcce430af1eea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109046 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-10online: make buttons work in statistics dialogsSzymon Kłos
Change-Id: Ie4810b87ea5ce4fc7b3e98afdd37bcd903e2907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108978 Tested-by: Jenkins
2021-01-10pivot table: add separator between list viewsSzymon Kłos
Change-Id: If4cb3735014bfde6124fb1173fb03aa950c3b77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107519 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108968 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10online: Don't lock new views if ref dialog is openedSzymon Kłos
When one of ref dialogs was opened in one view and then new user opened new view - the new one was locked. Don't do that for all dialogs, not only function wizard. Was partially fixed for one dialog in: 48a216cd16b306f4d2d7edc374ceb4670d177db8 Change-Id: I3b37aa182fd2096a5c989dfbdeb6c245985706d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107743 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108967 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10Fix json structure for decksSzymon Kłos
Change-Id: I7f203c29a03af917f50192946ee794f6e01b16e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109029 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10jsdialog: export correct children for toolboxSzymon Kłos
if toolbox has children it means we have embedded widgets so don't export notmal 'toolitem' entries Change-Id: Ia1bd3323cf3606b923a4b30e1147633dcac24a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109036 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10Replace strtmpl.cxx with actual C++ templates in strtmpl.hxxMike Kaganski
This has at least better IDE support, with easier lookup for function implementations. Change-Id: I0e4cfe40df036efa796c057852bd5cb4421507f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108931 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-10tdf#96787: AutoCorrect: after deleting a replacement entry, it's still usedJulien Nabet
If specific acor<language>.dat exists in "user", don't use the initial one in "share" since the initial one will still contain the deleted entry. See detailed explanation here: https://bugs.documentfoundation.org/show_bug.cgi?id=96787#c21 Change-Id: Ic349159c93d9fc327f38a1d4e8187e3bdc16d08a Change-Id: If6b16641d04721f2945a8e920e2933d1b8baa90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109039 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-10Set visibility of text range overlay the same as the annotation windowJim Raykowski
When frames containing comment anchors are removed the annotation window is hid but the text range overlay belonging to the annotation window remains visible in the edit window. This patch sets the visibility of text range overlay of the annotation window to the same visibility as the annotation window. Change-Id: I82170b2cab248a2c852a347ebdc6901bed3c83f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108428 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-01-10Update git submodulesJean-Pierre Ledure
* Update helpcontent2 from branch 'master' to 9a888e136a47b381837a2aecbf586c96637f8c64 - Remove reference to Calc sheets in Array service Within ScriptForge services, import/export methods between arrays and Calc sheets are in the SF_Calc module and, hence, in the sf_calc.xhp help Change-Id: I95386bfa83a8c15e84b9f097ce9cd5401f5abf45 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108993 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-09ofz#29443 uncaught exceptionCaolán McNamara
Change-Id: I35b0c23f6b6df6d5e4d7e89fce84e8e0f306d8e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109038 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09Update git submodulesAndras Timar
* Update dictionaries from branch 'master' to a706f520e612d1148c6d259b595ba4815be99f50 - Updated Slovenian thesaurus Change-Id: I189ae0f22fe2fa73d04fd149b8defdd1d7bb1f15 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/109040 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-09Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 0b90b02540e278f632d4526c75dbe986d1f2d8b9 - Fix typo Change-Id: Ib35a4fe3b4f6d5d1da567d92e860d327987e564c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109033 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-09Navigator outline content visibility menu item related fixesJim Raykowski
- fixes crash that occurs using Hide All - fixes logic used for Hide/Show All - adds comments for Toggle, Hide All and Show All popup menu items ids Change-Id: I87076c606e3d2bc49f5fe7d07119c6c74237f3e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09lok: fix initialization variableHenry Castro
It should initialize false Change-Id: I67249bc8040688ee82bf12532178eb133f80b8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09Fix typosAndrea Gelmini
Following: https: //gerrit.libreoffice.org/c/core/+/108936 Change-Id: I57fcdd1485f32ed4bcbfc9a91028eb9cd6b01f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109034 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09Update git submodulesBalaharipreetha Muthu
* Update helpcontent2 from branch 'master' to e3ac5513e2a4729063413ba131ef0cb5cb8f6daf - tdf#103587 - Find and Replace : Add explanations for options: Kashida sensitive and Diacritics sensitive. Change-Id: I4d94ed1c76ff799280b32bfec184a617c2a3d7f9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108994 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-09fix coverity parse errorsCaolán McNamara
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09cid#1470783 Logically dead codeCaolán McNamara
Change-Id: I0bf96d28904b84bb970c53d0cb732dc45aa2deb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09cid#1471571 Dereference null return valueCaolán McNamara
Change-Id: Ia284ddc1a2f9e60639a2992f0b091745d9721d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09cid#1471587 silence Unchecked dynamic_castCaolán McNamara
Change-Id: I1aa2dc5eabe29c66584451959e414e5f4d279aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109015 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09cid#1471677 Dereference after null checkCaolán McNamara
Change-Id: Ida02184e2cce87f8cfcf4ad380855175ea958f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09dynamic_cast followed by static_castCaolán McNamara
Change-Id: I12e8e438e0a3b556e29b191374341ddd2e76a24b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109013 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09w was the accelerator in Down, not DCaolán McNamara
Change-Id: I813362bc52b4c761617ab73584df6d6302d29c41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109012 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 1a448c30bca44a332348446afce82a3f5294461a - tdf#107229 final tweaks in template manager help - import and relatedtopics ( shared/guide/template_manager.xhp ) * move <note> about adding paths to "My Templates" to "Main Window" because it is about what choices are available. It also avoids have two notes together in the same place. * modified "Import" explanation to make it clear that multiple files can be imported * added <embed> with link to guide page about files and templates * repair broken link in <relatedtopics> * improve ordering of topics in <relatedtopics> ( swriter/guide/templates_styles.xhp ) (Templates and Styles) + add link to "Template Manager" in <relatedtopics> ( source/auxiliary/swriter.tree ) + add link to "Template Manager" in "Templates and Styles" section Change-Id: I4cd17696188da1a344d1143344e5cacd9b18e1ba Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108910 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-09Fix typoAndrea Gelmini
Change-Id: I74b1125fff6a63089a5eae4b32bcf30096bfbb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108661 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09Fix typoAndrea Gelmini
Change-Id: I44b6b006ca74a60cd00af7ee765b0e21be1afa48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109024 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09Removed execution bits on docxAndrea Gelmini
Change-Id: I304963f2200cda41a228290f4caf6033b5c7413c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109023 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09Fixed few grammar mistakesViKrAm-Baisclear
Change-Id: I772d24df6aefc441380379c2a2f075e879aafa29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108936 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09AccessibleShapeTreeInfo needs a vcl::WindowNoel Grandin
no point in passing an OutputDevice there Change-Id: I6da9b29a0e6f57ad6a8ebcb6113987ee25419483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108988 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-09tdf#104927 consider character width for CSV importMark Hung
dialog in fixed width mode. Postions and column width in csvgrid.cxx are muliplied by character width to get X coordinate. Positions are calculated based on the string length, disregard the fact that the characters may have different visual width. Most CJK ideographs and symbols are designed so that their width are twice of the western characters in the same font in general. This patch implement ScImportExport::CountVisualWidth() to count their visual width, convert the position so string that contains CJK ideographs render at the right place, and separate the string based on the calculated visual width instead of the number of sal_Unicode chars. Change-Id: Ic5c1ec219820cf4e1d6c554d5eaccca9f8210ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108802 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-01-09Revert "Very early work-in-progress commit for the "DevTools" dockable toolbar"Tomaž Vajngerl
Better path forward is to use a dockable window for the DevTools - added in commit 5f5ee992bd8377dc984b576950d468f6407d5c63 This reverts commit c0d770d4feb919cb3306c48d576ac30709154eae.
2021-01-09devtools: Implement development tools docking windowTomaž Vajngerl
Change-Id: Id3b8f424e24bac5164b8b3069580ffee65dd265c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107993 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-09~SwModify: do not silently tolerate clients registered past deathBjoern Michaelsen
- Make SwFormat/SwContentNode explicitly resetting the page desc. before death instead of SwFormatPageDesc trying to do that on the dying hint: * the dying hints is send _after_ the SwFormat/SwContentNode dtor are completed, so the RTTI magic did not work anyway * simply resetting the attribute in a final dtor and make SwFormatPageDesc just check to never get a dying hint (because it should have been destructed by reset) is a lot less errorprone. Change-Id: I231f1729729491ba7544e5ba93d81192b212e2ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108648 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-01-09sfx2: organize forward class declarations in objsh.hxxTomaž Vajngerl
Change-Id: I5e21010d540eaa6be2f75ef1a43b29d8ac75e32f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-09remove sdrgrafprimitive2d.{cxx,hxx} from excludelistTomaž Vajngerl
Change-Id: I9533fe0bb082f6688d6f8030e5bc0d6960abf359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108844 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-09vcl: remove "path" attribute from VectorGraphicDataTomaž Vajngerl
This isn't used for anything important for the vector graphic and is mostly empty string anyways. Change-Id: I1c5b52b5b407bd320cb5053141f1699971607399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108438 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-08tdf#124822 Move UItest to CppUnitTestshubham656
Change-Id: Ifb9c68dc8b1e61f8c180e44948c9a8f037a22fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108535 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-08tdf#139173: sc_addin_functions_test: Add dec2bin and dec2oct functionsXisco Fauli
Change-Id: Ic5cf78dc82bf68d8b406b85619ef79e94d56f079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108979 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-08tdf#128353 sd slideshow: fix handling of animgifs on slower machinesMiklos Vajna
Regression from commit 3e0092031b73bad107e3122d5d4be2f5bd487744 (tdf#112318 sd opengl: fix lack of initial animation, 2019-04-05), the problem was that in case a timer adds itself to the end of the scheduler queue during Scheduler::ProcessEventsToIdle(), then the idle trigger in SlideshowImpl::updateSlideShow() will never finish. The intention of invoking idles is to help vcl backends which do the actual painting in an idle, so actually it's enough to only process tasks which are already scheduled. That is enough for skia/gtk3/etc and avoids the problem with the animgifs. This is only a problem in debug builds or on slower machines: the animgif from the bugdoc wants to play a frame every 40ms, so in case processing the current tasks finishes faster than that, then the problem was not visible. Change-Id: I7487cb9a79e7e5acc0b816eb4744a04559ae26ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-08Introduce Color::IsFullyTransparentNoel
Change-Id: I94875b9fb7ee18edf63ed28902da4ae77eb14bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108973 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08fix variable name and improve method nameNoel
the variable value is alpha, not transparency Change-Id: I87904afcc0fb0fecfeeb4b80b52c5dd62893669c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08use more IsTransparentNoel
Change-Id: Ice7904f2531dba98101c5f7a05d14702fa897053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08Remove BitmapColor::GetAlphaNoel
since its implementation is completely wrong - alpha and transparency are not the same thing, they are inverses of each other. Change-Id: Id9e00b8296391befd471345b6c86e0493a9e3f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08opacity->alpha in BPixelNoel
They are basically the same thing, but alpha is the preferred term these days. Also improve the mixing algorithm, 1 - opacity is 255 - opacity not 256 - opacity since the range of sal_uInt8 is 0..255 Change-Id: I8788ac79285ab25c8d322b05817dffd3745fd699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 1be17f48daa2fd77eb955410b10edcf21da13749 - Use switches for Ctrl vs. Command on macOS Change-Id: Ib0c3b971e927d7828290549dee0c2ffca9873f6a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108974 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-01-08lok: send chart line width updatesSzymon Kłos
Change-Id: I4c9c4a977df12a1cefb81cfbcac73b61ff26e488 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108843 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108966 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-08tdf138773 Chart OOXML import: set text overlap to falseTünde Tóth
of category axis label, if the rotation is undefined in xml, to avoid e.g. missing rotation of them. Regression from commit: 21620f9d2f50e66dffc45a5afb539edb8d54434c (tdf#138194 Chart OOXML import: set text break to true) Change-Id: I5b03614eca547a206afc0d8118e3f6c055ed5348 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108792 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>