summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-06-23XMLSignature_GpgImpl: Use cppu::supportsServiceSamuel Mehrbrodt
Change-Id: Ic093462c957aa445aab43f95ac22af3a3df1d709
2017-06-23XMLSignature_GpgImpl: Clean up namespacesSamuel Mehrbrodt
Change-Id: I34aa59171b5d440bdd6bdec80badf7a3eb42bd3f
2017-06-23Gpg key listing: Use range based for loopSamuel Mehrbrodt
Change-Id: Idc7b39f751b2572f5ddd077aaad86a1f7b4b9a5d
2017-06-23tdf#108692 gpg4libre: List all gpg keysSamuel Mehrbrodt
Change-Id: I7300da36215233fa91b7a04a42b1c9bf907ad78b
2017-06-23gpg4libre: Handle error when retrieving public keySamuel Mehrbrodt
Change-Id: I9543e47fb3302a5ca146a606305b24733f015a5d
2017-06-23convert to std::vectorCaolán McNamara
Change-Id: I37a866f4248ad6441cb73b826c13b3602b96e03a
2017-06-23coverity#1412987 Untrusted value as argumentCaolán McNamara
Change-Id: Ia41c81d7cf864a5b38594b85577139bdaf5fc7bb
2017-06-23move pBuffer out of classCaolán McNamara
Change-Id: I88120530b21ebe72796ddee39c2446a70c3fd193
2017-06-23coverity#1412873 Dereference null return valueCaolán McNamara
Change-Id: I7b812c3381237cd52902fd15667e6e70bb36d53e
2017-06-23silence some unique_ptr warningsCaolán McNamara
Change-Id: Ibf3a8d00e8b91be79117d9c060b4cb2a7bafe651
2017-06-23coverity#1412992 Unused valueCaolán McNamara
Change-Id: I37c27b69ba2be2ffcc0d961d7b4faf527a671807
2017-06-23coverity#735795 Unchecked dynamic_castCaolán McNamara
Change-Id: I3599c03d43761da73b89beae990f8688bd0b549b
2017-06-23coverity#1412988 Uninitialized scalar fieldCaolán McNamara
Change-Id: I98bcb9f45caab6b8b052737baf5500766f94f88d
2017-06-23coverity#1412991 Resource leakCaolán McNamara
Change-Id: I0fc9b64ba8783530a0b7d597edbf8be8a43f5fd6
2017-06-23Fix typos: uniform registeredAndrea Gelmini
We have in the same files "registered" and "registred". Change-Id: I604a8fdb7d5c40fe208fc11e9120333b3eaef3da Reviewed-on: https://gerrit.libreoffice.org/39097 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23osl: getpagesize() uses sysconf(_SC_PAGESIZE) on all BSDsChris Sherlock
OpenBSD, FreeBSD, OS X, NetBSD and DragonflyBSD all now use POSIX sysconf, so there isn't any need to use the BSD getpagesize() anymore. Looking at the FreeBSD source in their VCS, it appears it sysconf support for _SC_PAGESIZE was introduced in the following commit on March 4, 1998: https://svnweb.freebsd.org/base/head/lib/libc/gen/sysconf.c?r1=12674&r2=34030 The man page for sysconf(3) says it has been available since BSD4.4 And it looks like OSX has supported this at least as far back as 10.6.2. Change-Id: Id8c188c00a8d87dbd8056635b5bf7f5940508ab1 Reviewed-on: https://gerrit.libreoffice.org/39120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23android: show when native-code.py is invoked even for non-verbose buildsMiklos Vajna
Change-Id: I176d140bf5efc090c89cbd3a3699a764abf7107a Reviewed-on: https://gerrit.libreoffice.org/39121 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-23gpg4libre: Warn before removing document signaturesKatarina Behrens
simple version, no "do not show this message again" checkbox Change-Id: Iba8ac8cda51acac748174c864aa5c205f2efcc8f Reviewed-on: https://gerrit.libreoffice.org/38962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23gpg4libre: Show certificate kind OpenPGP vs. X509 as 1 table columnKatarina Behrens
Shuffled the columns around a little bit Change-Id: Ib0a979458db680d712737ff997e1c3b4e4564f3f Reviewed-on: https://gerrit.libreoffice.org/38984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23loplugin:unusedfields in accessibility..comphelperNoel Grandin
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695 Reviewed-on: https://gerrit.libreoffice.org/39137 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in cuiNoel Grandin
Change-Id: I6d3ef43ab915d65794f1052f1f184eda10d39e1a Reviewed-on: https://gerrit.libreoffice.org/39136 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in dbaccessNoel Grandin
Change-Id: I3f32573f25b4861799124905cefb3d9166570989 Reviewed-on: https://gerrit.libreoffice.org/39135 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in desktop..editengNoel Grandin
Change-Id: Ieea12d0790a1034eba8975fe74fa205f02003b7d Reviewed-on: https://gerrit.libreoffice.org/39134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in forms..idlcNoel Grandin
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822 Reviewed-on: https://gerrit.libreoffice.org/39133 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:oncevar in cppcanvas..drawinglayerNoel Grandin
Change-Id: I5456aad61fb0dfe6830eae62b91d1a6399d6343f Reviewed-on: https://gerrit.libreoffice.org/39128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in jvmfwk..mysqlcNoel Grandin
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08 Reviewed-on: https://gerrit.libreoffice.org/39099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in registry..saxNoel Grandin
Change-Id: Ie0e2ecaadb49273cb4e78bc894111523940e7c8e Reviewed-on: https://gerrit.libreoffice.org/39098 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23inline some ERRCODE_AREA aliasesNoel Grandin
and drop unused ERRCODE_AREA_OFA_END constant Change-Id: Ic34ecda7f842c5db93807b3f21aa1062966ca523 Reviewed-on: https://gerrit.libreoffice.org/39089 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23writerfilter: map endnote text to EndnoteJustin Luth
I'm not exactly sure what role the Endnote Symbol char style plays, but it is only related to Endnote Characters, not the main footnote text. Note: the existing mapping rarely takes effect since MSWord exports the stylename in lower-case. Unfortunately, there is no history to indicate why "Endnote Text" is mapped to "Endnote Symbol". That looks like an error to me. related to tdf#82173 which exposed this issue. Change-Id: Ie92f527b1e594fd571f1118d18a8ff225cfc2314 Reviewed-on: https://gerrit.libreoffice.org/38605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-06-23tdf#89139: dump pivotField itemsMike Kaganski
This makes the pivot table exported to XLSX refreshable (does not crash Excel on pivot table refresh). Change-Id: Icc35795cd116e091b75bb1d4a603c52ccc71c44d Reviewed-on: https://gerrit.libreoffice.org/39018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-06-23osl: doxygen fixes for headersChris Sherlock
Change-Id: I3f30b5ab985c2ff709116568905b941c5d50fd1a
2017-06-23osl: document osl_mapFile parameters and return valuesChris Sherlock
Change-Id: I307662ef0d8360da3cbc7edc96890575715bbf07
2017-06-23osl: typo from last commitChris Sherlock
Change-Id: I3dce45da77c6ab21be5a999d4ea5b7944a07bbd7
2017-06-22osl: File map flag constants documentedChris Sherlock
Change-Id: I8f02cfdcaa1a5d2ce981b5de1b9754da36760649 Reviewed-on: https://gerrit.libreoffice.org/39124 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-06-22tdf#108682 DOCX import: fix <w:spacing w:line=...> for negative valuesMiklos Vajna
I didn't find UI in Word to create <w:spacing w:line="-260" w:lineRule="auto"/> the equivalent markup when you set line spacing to exactly 13pt for new documents is: <w:spacing w:line="260" w:lineRule="exact"/> The OOXML spec and Microsoft's implementer notes ([MS-OI29500]) is also pretty silent about what a negative value means. However, if this markup is converted to WW8 by Word, then the WW8 LPSD structure is like this (as presented by doc-dumper): <lspd type="LSPD" offset="5086"> <dyaLine value="0xfefc"/> <fMultLinespace value="0x1"/> </lspd> For the 0xfefc value the [MS-DOC] spec clearly states that means the type of the spacing is "exactly", with the value of 0x10000-0xfefc, i.e. the same 260 twips. Change-Id: I84b485d02dea49c610b6df2e06ccce03e1d29d21 Reviewed-on: https://gerrit.libreoffice.org/39091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-22gitignore: compile_commands.jsonMuhammet Kara
This file is generated by "make vim-ide-integration" Change-Id: I9355bc36b2a654efd6183b268662b10b224f2117 Reviewed-on: https://gerrit.libreoffice.org/39108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-22Unit test for named single reference pointing to deleted row, tdf#108671Eike Rathke
Change-Id: Idb22bd00572d362eb2cc0137fe01835d6c28fcf8
2017-06-22expat-2.2.1 patch to allow compile on macOS and othersjan Iversen
xmlparse.c has a #define buffer something later #include something that happens to use buffer as a parameter. Change-Id: I7378aa9481b30364097c70317c794c0bcca2f05c Reviewed-on: https://gerrit.libreoffice.org/39109 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-06-22Resolves: tdf#108475 swipe only if some reasonable movement was involvedCaolán McNamara
Change-Id: I5ee2a60f80728a2cca1401e43c8e27f852bfc657 Reviewed-on: https://gerrit.libreoffice.org/39116 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-22assert( nX < nC && nY < nR ); cause of tdf#108292Eike Rathke
Change-Id: Iaa23361510b1aa1eebfa6618b526fc7d9d6fa537
2017-06-22Resolves: tdf#108452 gtk3 xbm cursors invisible on black bgCaolán McNamara
Change-Id: I5c9b27862da6ac76ae38542f85a51f9aefdd013d Reviewed-on: https://gerrit.libreoffice.org/39111 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-22Add RemoveEntry method to SvTreeListBoxMuhammet Kara
Allows you to remove an entry along with its children without selecting the entry. Change-Id: Ie833df5e0d2d3bc86ed01a70dc6f042ebb6d6a47 Reviewed-on: https://gerrit.libreoffice.org/38971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-22add factory function mapping for libspelllo archivebrainbreaker
Change-Id: I7cbea9381bc993e7894603c731ab0ac54e80d4b4 Reviewed-on: https://gerrit.libreoffice.org/39049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-22xmlsecurity: implement support for building against system-xmlsecMiklos Vajna
The only remaining difference is that in the system-xmlsec case we work with the default key manager, not with the one that's only added by our xmlsec patches. This works for me for the uses I know of (see <https://lists.freedesktop.org/archives/libreoffice/2017-February/076947.html> for the motivation): signing and verifying of different signatures (bad signature, good with non-trusted CA, good with trusted CA) with software-based certificates all behave as expected. Change-Id: If3f3e2b8373ab7397db3f98070a5a2ce51fa7c06 Reviewed-on: https://gerrit.libreoffice.org/39075 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-22tdf#101821 sw: fix layout footnote use-after-free in SwRootFrameMichael Stahl
The ClearSwLayouterEntries() accesses anchored objects and if they are anchored in footnotes then RemoveFootnotes() has already deleted them. (regression from 962d0500c4debaef43e5f146e47e08c66d851562) Invalid write of size 1 at 0x4143CCB3: SwAnchoredObject::SetTmpConsiderWrapInfluence(bool) (anchoredobject.cxx:739) by 0x414D8A21: SwObjsMarkedAsTmpConsiderWrapInfluence::Clear() (objstmpconsiderwrapinfl.cxx:58) by 0x414C943E: SwLayouter::ClearObjsTmpConsiderWrapInfluence(SwDoc const&) (layouter.cxx:401) by 0x411DBE57: sw::DocumentLayoutManager::ClearSwLayouterEntries() (DocumentLayoutManager.cxx:504) by 0x414D05D9: SwRootFrame::DestroyImpl() (newfrm.cxx:594) by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389) by 0x419E8171: std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (shared_ptr_base.h:464) by 0x40EB6DB5: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:150) by 0x40EB5E76: std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (shared_ptr_base.h:662) by 0x419E65F9: std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (shared_ptr_base.h:928) by 0x419E6615: std::shared_ptr<SwRootFrame>::~shared_ptr() (shared_ptr.h:93) by 0x419E619D: SwViewShell::~SwViewShell() (vnew.cxx:285) Address 0x5feb6eee is 334 bytes inside a block of size 488 free'd at 0x4C2F21A: operator delete(void*) (vg_replace_malloc.c:576) by 0x41488962: SwFlyAtContentFrame::~SwFlyAtContentFrame() (flyfrms.hxx:134) by 0x41535AFC: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:391) by 0x415360BD: SwLayoutFrame::DestroyImpl() (ssfrm.cxx:477) by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389) by 0x414A2FF4: sw_RemoveFootnotes(SwFootnoteBossFrame*, bool, bool) (ftnfrm.cxx:852) by 0x414A3104: sw_RemoveFootnotes(SwFootnoteBossFrame*, bool, bool) (ftnfrm.cxx:874) by 0x414A321A: SwRootFrame::RemoveFootnotes(SwPageFrame*, bool, bool) (ftnfrm.cxx:897) by 0x414D0558: SwRootFrame::DestroyImpl() (newfrm.cxx:585) by 0x41535AB3: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:389) by 0x419E8171: std::_Sp_counted_deleter<SwRootFrame*, void (*)(SwFrame*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() (shared_ptr_base.h:464) by 0x40EB6DB5: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:150) by 0x40EB5E76: std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() (shared_ptr_base.h:662) by 0x419E65F9: std::__shared_ptr<SwRootFrame, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() (shared_ptr_base.h:928) by 0x419E6615: std::shared_ptr<SwRootFrame>::~shared_ptr() (shared_ptr.h:93) by 0x419E619D: SwViewShell::~SwViewShell() (vnew.cxx:285) Change-Id: I147f46d49c90de46189ad34feed66c289adddc15
2017-06-22Bin a couple way too verbose SAL_INFOsTor Lillqvist
Use temporary SAL_DEBUGs in your local tree instead if/when you need to trace these constructors and destructors. Change-Id: Icc52c905205914f0e5b911a2dae8322e99e9234e
2017-06-22Removed duplicated includeAndrea Gelmini
Change-Id: Ibbd83a7d69a27ab96b99d28e1d4a1f65af63b82f Reviewed-on: https://gerrit.libreoffice.org/39037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-22Explicit --with-valgrind, to not accidentally miss Valgrind supportStephan Bergmann
Change-Id: If4de6e4cdebb082cbe8faa9392fceb61c3f8fb9e
2017-06-22tdf#39468 Translate some random German comments/termsJens Carl
Change-Id: I38cb79abb2a495ccca454903bc46b407009e8290 Reviewed-on: https://gerrit.libreoffice.org/39084 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-22iwyu: add language standard defines to flagsJochen Nitschke
for some reason they are not set and cause parse warnings Change-Id: I1bbc14da8cd7f4cbde8e59934b6ace932245e2a1 Reviewed-on: https://gerrit.libreoffice.org/39093 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>