summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-29Fix macro "AC_HELP_STRING" is obsolete (m4)Julien Nabet
Change-Id: I0b19293d72f3428004ffc8fc7874420b0ff95bf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124347 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-29Fix typoAndrea Gelmini
Change-Id: I06cb364b31274d36a712f43db258a2421995388a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124434 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-29Let's assume this is a bogus warningTor Lillqvist
Change-Id: I3941d8b1811d34b2b7646b20bc7e91c9034770be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124427 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-29tdf#145274: vcl_pdfexport: Add unittestXisco Fauli
Exporting to PDF was the only way I could find to test this issue Change-Id: Id2af0f98b505c49ad912e74477d7bb5246cf850c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124341 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-29Prepare for removal of non-const operator[] from Sequence in drawinglayerMike Kaganski
Change-Id: I9cea42e100de6bb05a32edbf9611fbd05d91759e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124359 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski
The bits missing from 5b0ae3b59cd2cccfb72d991657366eb2a69bff49, where explicit use of sal_Bool* was needed instead of 'auto', to workaround loplugin:implicitboolconversion warnings. Change-Id: I32ef417d46ceea38fbcebae053e288222179818c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124428 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29simplify framework::TitleHelperNoel Grandin
Every callsite (bar one) calls setOwner and connectWithUntitledNumbers after construction, so just pass them in the constructor. And for that lone callsite we can just nullptr as an argument. Change-Id: If838e068bb59a407225d853a0f67983be400f2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29Split overly long line into multiple logically separate pieces for sanityTor Lillqvist
Change-Id: Ic23bfba8ff9f403e49bda89e4fffe73cf11fdd70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124424 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-29Use non-deprecated names for bits and constantsTor Lillqvist
Change-Id: I9004aaef7b2d526ad99b316b78733671a785c847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124328 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-29tdf#141193 Added support for bar codes in qrcode dialog box[API Change].homeboy445
Change-Id: I6b79ece1d5419ef92b76755d3bd921a64d6e38fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113989 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-29tdf#143392 fix title on Base windowNoel Grandin
regression from commit 857caa5fc69b92e781457a1b67a89aa051c2d70f tdf#79049 speed up OOXML workbook load Change-Id: Ia2d55386a7508dc2bbb2fa8501b45c3f30ad6a75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29tdf#128969: Let the user explicitly decide to execute an external programStephan Bergmann
...bringing up a warning dialog now in cases where it would have before only brought up a failure message Change-Id: I850badf5927517f16f965950df699979887dbdc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-29Fix misuses of NULL across Windows-only codeStephan Bergmann
...which defines NULL as a plain 0 integer literal instead of the GNU __null extension, so clang-cl's -Wnull-conversion cannot kick in. These findings are from an experimental build done with clang-cl and a modified > --- a/clang/lib/Headers/stddef.h > +++ b/clang/lib/Headers/stddef.h > @@ -83,6 +83,10 @@ typedef __WCHAR_TYPE__ wchar_t; > # if !defined(__MINGW32__) && !defined(_MSC_VER) > # define NULL __null > # else > -# define NULL 0 > +# if __cplusplus >= 201103L > +# define NULL nullptr > +# else > +# define NULL 0 > +# endif > # endif > #else > # define NULL ((void*)0) However, that build also ran into lots of places where 3rd-party code in external/ and Windows system headers caused issues when NULL is nullptr (which I worked around with various hacky patches for that build), so this is unfortunately not something that can easily be enabled generally. Change-Id: I10674464498a9bc63578d9e6cc32ddde23ab4f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124419 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-29external/nss: More -Werror,-Wunknown-pragmas with clang-clStephan Bergmann
> In file included from C:/lo-clang/core/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx:28: > In file included from C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss\pk11pub.h:12: > In file included from C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss/pk11hpke.h:8: > C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss/blapit.h(66,9): error: unknown pragma ignored [-Werror,-Wunknown-pragmas] > #pragma deprecated(DSA_SUBPRIME_LEN, DSA_SIGNATURE_LEN, DSA_QBITS) > ^ Change-Id: If84d8640d770ed20a6492678a9bc7fe4f4a547f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-29loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: If23252e7640a9cfc9dd9feab4416ae832feddaf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124403 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-29tdf#140798, tdf#143815, tdf#141659: fix fly content hint handlingBjoern Michaelsen
Also revert most of the test changes in 188ec34cf157ffee8c63f03f420ca9daafb5ff29, except in mailmerge, where 3bc8f90e9693f710f12632f69b9348c1c833c906 seems to have done some research and the old state wasnt particulary well-justified. In testSmartArtAnchoredInline the order of elements has changed. This exposes a bug in SwFEShell::Paste, which stops copying SpzFrameFormats (aka FlyFrameFormats and DrawFrameFormats) after having copied the first FlyFrameFormat, claiming other Flys will have been copied via FlyInFly. If there are DrawFrameFormats behind the FlyFrameFormats, they will be forgotten. So instead: - first copy the DrawFrameFormats - then copy the first FlyFrameFormat to not forget any Draw Formats. Also, give the format copying its own function, at 100 lines its annoying enough all by itself. Change-Id: I301e27ff94fb82cf0502457630acdcbfa342a566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124162 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-29Prepare for removal of non-const operator[] from Sequence in dbaccessMike Kaganski
Change-Id: Iddb96d39a512ef68827ecf89f3b5650950f88096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124357 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in cuiMike Kaganski
Change-Id: Ib359c029099cf86ccdebefd014d4a9bd91d57eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124356 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in cppuhelperMike Kaganski
Change-Id: I692f1faf0b6ebe26771f3b8c5be1aa548ebd8515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124355 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in cppcanvasMike Kaganski
Change-Id: I2a16a8ea7776447592e51a23ce21aac0a156735f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124354 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29pass DX array around using o3tl::span instead of pointerNoel Grandin
so we get bounds checking in debug mode Note that I cannot just pass around the std::vectors involved because there is a place in editeng which calls with a subset of a vector. Change-Id: I5088a139593c27bf9cbe5d843ab4b0048ac6d508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski
Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in configmgrMike Kaganski
Change-Id: Ia349292783b81f0b4eebe64ae672ea5cb6d6cd59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in connectivityMike Kaganski
Change-Id: If92f9af5e248f4b066359fe043adf221102e8561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in comphelperMike Kaganski
Change-Id: Ie4f3675adc888ecf175c5342c87d416f34f8dce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124351 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in codemakerMike Kaganski
Change-Id: I058cf9ff4f7ce3f49f1dc3abb6b02268d208b225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124350 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in canvasMike Kaganski
Change-Id: Ifb96e496b0994b5fc66975b7aea0a60bcb4a3a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124345 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in binaryurpMike Kaganski
Change-Id: Ibbe07a6de488461a99bb06d558cf740caa606bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124344 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in basicMike Kaganski
Change-Id: If048bc301c38ac5ac5412a7d8f69231705088a50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124343 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29use virtual function call for dynamic dispatchBjoern Michaelsen
... as it is around since the dawn of C++ and should be stable -- certainly more stable and less errorprone that manual typetagging. Change-Id: I5dfe2ce40c2334dc8fe60705d358779fa4bf1586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124131 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-10-29consolidate DDE updates in FieldTypeBjoern Michaelsen
Change-Id: I70243dad4cd62ab1f601d010e0bcf441831ec556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124130 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-10-28Fix passing DYLD_LIBRARY_PATH into lldb on macOSStephan Bergmann
...making sure that the shell expands the leading DYLD_LIBRARY_PATH=${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}... before it reaches lldb. (This gets rid of gb_{Cppunit,Pyhton}_{PRE,POST}GDBTRACE again. No idea why c38a4d9ce248b4b3fcc9208b25dfa599fe506ac0 "Make the CPPUNITTRACE="lldb --" thing work again (on macOS)" used -s with a temp file rather than -o to pass that env var into lldb.) Change-Id: I9ae5217a9629981c8652fc5aca8f97fa6eb99729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124331 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-28gtk4: use a GtkPicture for arbitrary size/ratio toolbar imagesCaolán McNamara
so the wide .uno:BackgroundColor Toolbar MenuButton in sidebarparagraph.ui is shown correctly Change-Id: I231145092b5444fa2c70a7b3f0d85ddd6762eac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28center the content of the underline controlCaolán McNamara
Change-Id: If93af6e031bd108903d9528a43bd7e06fcd8340e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28XAccessibleSelection: Don't reference non-existing methods in docMichael Weghorn
There are no 'XAccessibleSelection::deselectSelectedChild' and 'XAccessibleSelection::getSelectedChild' methods, so don't mention them in the documentation for 'getSelectedAccessibleChildCount'. First, there's 'XAccessibleSelection::getSelectedAccessibleChild', but not 'XAccessibleSelection::getSelectedChild', so update that accordingly. Second, there's no 'XAccessibleSelection::deselectSelectedChild', and 'XAccessibleSelection::deselectAccessibleChild' doesn't take an index into the selection, but a child index, s. its documentation and the commit message of pending Gerrit change Change-Id: I3c63c647e61baaa6288ffd545d8d89d8b94231de ("gtk3 a11y: Use correct index when deselecting child") on how the semantics of AT-SPI functions with corresponding names differ. (The comment was added in commit daacf7ed0bc8a1a2447c4b1cb340c97f82918af8 Date: Thu Apr 24 16:35:46 2003 +0000 INTEGRATION: CWS uaa02 (1.1.2); FILE ADDED 2003/04/02 10:06:50 obr 1.1.2.3: #108113# Renamed deselectSelectedAccessibleChild to deselectAccessibleChild 2003/03/14 10:40:52 af 1.1.2.2: #108113# Removed references to the drafts directory. 2003/03/11 15:00:39 af 1.1.2.1: #108113# Moved from drafts/com/sun/star/accessibility. and > 2003/04/02 10:06:50 obr 1.1.2.3: #108113# Renamed deselectSelectedAccessibleChild to deselectAccessibleChild sounds like there might temporarily have existed a draft implementation that actually took an index into the selection rather than a child index.) Change-Id: Ib8eeadd1ffe8e05b87422e3f9d5c4b3fcc6b696d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124332 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-10-28gtk3 a11y: Use correct index when deselecting childMichael Weghorn
The AT-SPI selection interface provides two functions to unselect: gboolean atspi_selection_deselect_selected_child (AtspiSelection *obj, gint selected_child_index, GError **error); gboolean atspi_selection_deselect_child (AtspiSelection *obj, gint child_index, GError **error); For the first one, 'atspi_selection_deselect_selected_child', "child_index is the index in the selected-children list, not the index in the parent container." [1] For the second one, 'atspi_selection_deselect_child', "child_index is the index of the child in the parent container". [2] ATKSelection, on the other hand, only has gboolean atk_selection_remove_selection (AtkSelection *selection, gint i); where the index 'i' is "a gint specifying the index in the selection set. (e.g. the ith selection as opposed to the ith child)." [3] That means, the meaning of the index in 'atk_selection_remove_selection' is the same as in 'atspi_selection_deselect_selected_child', while 'XAccessibleSelection::deselectAccessibleChild' expects an index in the parent container, not in the selection set. Therefore, convert the index from an index in the selection to a child index first before passing it into 'XAccessibleSelection::deselectAccessibleChild'. (For ATK, the mapping from the two AT-SPI to the ATK function is done in libatk-bridge.) Example to reproduce wrong behaviour without this change in place: 1) select cells B1 to E5 in Calc 2) start Accerciser 3) select the Calc table in Accerciser 4) get AT-SPI selection interface for the table by typing the following in the IPython Console in Accerciser: sel = acc.querySelection() 5) check whether child 0 (i.e. cell A1) is selected In : sel.isChildSelected(0) Out: False -> OK 6) check whether child 1 (i.e. cell B1) is selected: In : sel.isChildSelected(1) Out: True -> OK 7a) try to unselect cell B1: In : sel.deselectChild(1) Out: True -> NOK: selection remains unchanged, cell B1 is still selected Alternatively, intead of step 7a: 7b) try to unselect cell C1 (2nd item in the selection): In : sel.deselectSelectedChild(1) Out: True -> NOK: cell B1 gets unselected instead of C1 [1] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-selected-child [2] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-child [3] https://gnome.pages.gitlab.gnome.org/atk/AtkSelection.html#atk-selection-remove-selection Change-Id: I3c63c647e61baaa6288ffd545d8d89d8b94231de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124329 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-10-28Prepare for removal of non-const operator[] from Sequence in avmediaMike Kaganski
Change-Id: Iefa86987f6ce43610177b7c4122744d37386ad6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124335 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-28Prepare for removal of non-const operator[] from Sequence in accessibilityMike Kaganski
Change-Id: I9454befb46767255451c490eab17e331eb8bb9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-28Prepare for removal of non-const operator[] from Sequence in basctlMike Kaganski
Change-Id: Icc6ea4eea08a1cd3fffbfb211f420ab91602e8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124336 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-28Prepare for removal of non-const operator[] from Sequence in includeMike Kaganski
Change-Id: I85ca453f3add5ac5b59dc6f1ccb2cdb55f0a463c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124333 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-28gtk[3 vs 4]: remove can-focus entirely from toolbarpopover.uiCaolán McNamara
so tab-cycling inside sidebar popovers work as wanted In gtk3 a can-focus of True means that tab-cycling doesn't work correctly as the container is seen as a candidate itself In gtk4 a can-focus of False means that focus cannot enter any child of it. So it needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I423094657854ed02bc28496dfc9a30efa1e945da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124338 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28-Werror,-Wunused-macrosStephan Bergmann
(when e.g. building natively on macOS ARM64) Change-Id: Ibff6f913a6251573058c52a8b4106233fad1d443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124322 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-28Don't auto-enable --enable-online-update for Win/MacChristian Lohmaier
newcomers will run into the need to specify --with-privacy-policy-url and besides that the update server won't know about the build done/will be useless without also using your own update-check server. Change-Id: I77ff61e55ae4a0ca387b79cc2dcfc3f3059ef962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124324 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-10-28ScriptForge - (SF_Chart) fix Resize() method must return a BooleanJean-Pierre Ledure
Change-Id: I8acccd3036c8a08d6fd52b64623f2c9ab3ded5ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124323 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-10-28endian check in internal neon looks dubiousCaolán McNamara
Change-Id: Idebe6d07e37a28c005565f1e14826756be4e3a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28Revert broken optimization attemptStephan Bergmann
This partially reverts 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 "optimise find/insert pattern", which caused > ~/llvm/inst/bin/../include/c++/v1/unordered_map:1134: _LIBCPP_ASSERT '__get_const_db()->__find_c_from_i(&__p) == this' failed. unordered_map::insert(const_iterator, const value_type&) called with an iterator not referring to this unordered_map during CustomTarget_testtools/uno_test in an experimental build with -D_LIBCPP_DEBUG=1 on macOS. Change-Id: Id40e5eab7c3fb1f8e1bb2599c7fb84649e870ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124319 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-10-28loplugin:simplifybool (clang-cl)Stephan Bergmann
(not a typo according to the comment at <https://gerrit.libreoffice.org/c/core/+/124287/3#message-df56362ec7d674eaab3fe81bb0827be81ee5686d> "xmlsecurity: some Distinguished Names are less equal than others": "i was too lazy to look up which integer would be returned by the function and hoped this would convert it to bool anyway" Change-Id: I0f4f4d19e8d382f4430023aa6f9459c66a605b04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124321 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-28tdf#141301: extrusion-skew angle value -135 is not written to file...Julien Nabet
whereas it should since not default value (Regina) Hopefully in some years missing values are unlikely and bug tdf#141127 can be fixed. (Regina) I have added a unit test to Julien's patch. Change-Id: Ia2aabd8e724e3c3db9ae8a87cb27707aa7040fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113257 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-10-28-flto: only use firstword of PARALLELISMChristian Lohmaier
jenkins agents use PARALLELISM with additional load limit, e.g. PARALLELISM="16 -l 24" causing the linker to complain about not finding -l24 when lto is enabled. So only use the first element/the number of jobs to use and omit the load limit here. Change-Id: Ie3e2bdbde1b89d9371d1d9b9e426f42a91d2eca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124288 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-10-28sc: split UITest_chart in twoXisco Fauli
it already has 48 tests Change-Id: I8ce52b74d29d034531884f32ab965febcd9e266f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124282 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-04 14:49:06 +0000