summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-30Photo album: Remove padding from preview imageSamuel Mehrbrodt
So that it aligns well with the other controls Change-Id: I32fcb50bf378443dc27c10a1a674ff672b95a15f Reviewed-on: https://gerrit.libreoffice.org/26798 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30tdf#65356 Photo Album: Allow inserting images as linkSamuel Mehrbrodt
Change-Id: Ic7d1228b9e0a5ee5a303c5e3f4ce4d5a1b2b2036 Reviewed-on: https://gerrit.libreoffice.org/26793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30distclean the generated bin/bffvalidator.shStephan Bergmann
Change-Id: I3ea4f0682250ddb475c66a9782194177e6ae7586
2016-06-30fix Window::~Window: inconsistency in top window chain leakCaolán McNamara
Change-Id: I4f32b77a4b107e5315e0c2bc9b20db897135c8b0
2016-06-30lokdocview: avoid pointless setView() before getView()Miklos Vajna
This fixes the following use-case: 1) Start gtktiledviewer, click New View 2) Click Edit in the first view 3) Click somewhere in the document in the first view -> nothing happens Change-Id: I79d63538607f03b78851a639adf158d918745276 Reviewed-on: https://gerrit.libreoffice.org/26789 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-30Explain usage of -isystem instead of -IStephan Bergmann
Change-Id: Ib7153db5c2c1542ff7e9a0daa6d7124225c7701c
2016-06-30Who needs that $(CLANGDIR)/tools/clang/include anyway?Stephan Bergmann
It was included ever since 02a8d36ebf3d54784903f2899eafe010bedf2f4c "initial support for clang compiler plugins" but will probably point at either a non- existing dir or a dir in the Clang source tree (that does not even contain all the include files that the corresponding installation dir would contain, as some include files are generated during the build). For a properly installed LLVM/ Clang, all include files should be found underneath a single include/ dir. Change-Id: Ie23cb1ae701eed1ee78448eb6c828d07b15121c2
2016-06-30RTF export: it's enough to pass these by const ref, no need to copyMiklos Vajna
Change-Id: I6854c3c8e9a2b5c6d478551c5f9bba19e114152c Reviewed-on: https://gerrit.libreoffice.org/26787 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30loplugin:unusedfieldsNoel Grandin
Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Modify the ImpGraphic class SwapFile to use a shared pointerMark Page
Change-Id: I2cf85f91d9022a4ea10804efe2e986e95a63419f Reviewed-on: https://gerrit.libreoffice.org/26284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Improve readability of OUString concatanation in ODatabaseExportMuhammet Kara
It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: I3cf18cfb6879ea1598ad98a0bccd3ec91c88c875 Reviewed-on: https://gerrit.libreoffice.org/26760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Step towards disposing of ScDataFormDlg properlyKatarina Behrens
There were some VclPtrs hiding inside std::vector (twice), so fix that, but the destructor is still not called (getting Window::~Window inconsistency assert). With this patch however the screenshot cppunit test no longer fails Thanks noelgrandin for help Change-Id: I8b46c4608cbab2070e36ef4abec226bcd997425e Reviewed-on: https://gerrit.libreoffice.org/26772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30tdf#89616 Find toolbar: Activate search arrows when input has textSamuel Mehrbrodt
Not only when input is modfified Change-Id: Ic6b94dbfba34ec6eb88c9c385aaa36a7bac19de7 Reviewed-on: https://gerrit.libreoffice.org/26782 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-30remove pageStyle name dependencies from rtfexportJustin Luth
It was not the intention of these unittests to specify the name of the style. Better not to hardcode a "random" name in a unit test. Change-Id: Ic071bf42dc45c4fa831fec433e3c02b161b4268c Reviewed-on: https://gerrit.libreoffice.org/26734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-30LOK: change back type of view ids to intMiklos Vajna
Commit 45c2410041c48c22bd860efb42d4daadad7869b0 (LOK: change type of view ids to uintptr_t, 2016-06-17) fixed the problem of view IDs being reused for the price of random IDs, which makes debugging harder. Implement a simple shellToView() function that makes sure view IDs are not reused, and stop exposing view shell pointer addresses, which allows reverting the LOK API change. Change-Id: I63089e6de08ee7e1c7706757d43a11f6cf4d6e06 Reviewed-on: https://gerrit.libreoffice.org/26773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29Add MS binary format validator support for wineThorsten Behrens
Run bffvalidator also from Linux, reportedly works from wine 1.9 upwards. Wraps stuff in a shell for path name conversion. Change-Id: I3093b10bbbf89aaff97f63485b8ccadb417b3561 Reviewed-on: https://gerrit.libreoffice.org/26784 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-29compilerplugins: -isystem /usr/include breaks the buildMichael Stahl
... on Fedora 24, and it's a Bad Idea in general because it breaks "#include_next" ordering of GCC's and glibc's variously distributed headers. Change-Id: I0c8b51a6d7191ec9cc5187636ea2717e8fd97715
2016-06-29dynamic_cast followed by static_castCaolán McNamara
Change-Id: I9ebdc33ceabc8aaa34dc897cc47e692fedde9199
2016-06-29loplugin:badstatics: whitelist some more staticsStephan Bergmann
...which use std containers and are only found at all with the libc++ container implementations, not the libstdc++ ones. Change-Id: Ic9af06139823befad4af1a9a825cba10c115aceb
2016-06-29No need for a derived classStephan Bergmann
Change-Id: I42e96a0c7818abdaff15f5cd2b1111839aa771e6
2016-06-29Simplify finding elements of theAddInAsyncTblStephan Bergmann
Change-Id: Id9a2d84e1efb86a89e620dca5cd35274979aa1b9
2016-06-29loplugin:staticmethodsStephan Bergmann
Change-Id: I506f1e79a7500ab79dd0f199150949face091931
2016-06-29tdf#100594 Calculate nFrac with fNumber for Forced DenominatorLaurent Balland-Poirier
nFrac was calculated with fraction value = nFrac/nDiv which could be rounded in case of few digits in nDiv Change-Id: I568121b0e7b5ea0b67bbff7bbbb37d2c272c3691 Reviewed-on: https://gerrit.libreoffice.org/26663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29tdf#97837 Add qa unit testLaurent Balland-Poirier
Add a number format with "/ " at the begining like in bug report Change-Id: I98ae12434608e16c8e202a1c4acfda50df4db6f1 Reviewed-on: https://gerrit.libreoffice.org/26576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29tdf#81939 Remove escape char only for fractionLaurent Balland-Poirier
In XLSX files, in number format, all escape characters were removed. But it is only necessary for space character in fraction. Preserve escape character in other cases. Change-Id: I6f82b7285cf91726725b723b0bb109bcced066b8 Reviewed-on: https://gerrit.libreoffice.org/26466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29tdf#90336, make it visible in options, if openCL will be usedJBurant
I tried to hide the black and white list settings and to add the info, whether OpenCL will be used. Change-Id: Ida7d34078bdb6fc2597376a61138cf9ec0c8eeaa Reviewed-on: https://gerrit.libreoffice.org/23847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-29Further clean-upStephan Bergmann
Change-Id: I884acbc85108f9cbd5e244c73a1f4c58a8c89613
2016-06-29Don't waste too much time evaluating the "score" for the "native CPU"Tor Lillqvist
This code took tens of second typically, which is utterly pointless. Instead run the loop for max a second, after which estimate how long it would have taken to process all of the data. Don't confuse the "native CPU" term here with a CPU-based device of an actual OpenCL implementation. That is a completely different thing. This "native CPU" thing here is just our way to estimate how much time it takes to do calculations using normal C++ code on the CPU. Change-Id: I92f5eedc06bbaaef6a9b5322fefec9d41f0db505 Reviewed-on: https://gerrit.libreoffice.org/26774 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29framework: fix typo in dispatchdisablerMiklos Vajna
maDisabledURLs is a set, aDisabledURLs is a sequence, the intention is to copy the set into the sequence, not to copy the (empty) set into itself. Change-Id: Ib262e863b1f1aa4c455bd7552df3dc2c3f73a400 Reviewed-on: https://gerrit.libreoffice.org/26765 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29move #includes to top of fileNoel Grandin
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29starmath: Replace OSL_ENSURE with assertTakeshi Abe
as negative n would be undefined for OUString::copy(..., n). Change-Id: I950ec60656142450a5d5f6804324f6080c9c4c2a Reviewed-on: https://gerrit.libreoffice.org/26753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorArnold Dumas
Change-Id: I6fc54accb6c08e34909db2131e0abc84d32da2f5 Reviewed-on: https://gerrit.libreoffice.org/26763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-29tdf#100592 Add extra number formats for fractionLaurent Balland-Poirier
Change-Id: Ia3a5fa02029e06e083fcc10748b0deb3048dae79 Reviewed-on: https://gerrit.libreoffice.org/26675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29clang-analyzer-deadcode.DeadStoresStephan Bergmann
cf. <https://lists.freedesktop.org/archives/libreoffice/2016-June/074681.html> "Re: chained editeng: Add TextChainFlow related files" Change-Id: I0b1611db620c0e0ee56890e652066afb95b3e9ce
2016-06-29Resolves: rhbz#1350478 identify that we own the selection with a unique targetCaolán McNamara
so we can tell that we own the selection in the absence of reliable selection ownership notifications under wayland Note that gnome#768177 means that requests for CLIPBOARD targets after requests for PRIMARY targets can time out, which is why my attempts at doing this before giving up with commit 88cd9dd591d7921e5bce33c170b457ae5aa871bb Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 24 15:06:36 2016 +0100 Resolves: rhbz#1326304 cannot detect loss of wayland clipboard ownership didn't work. Change-Id: I1154899e478b6e0cc6f70aa0c90c26663299072c
2016-06-29Further clean-upStephan Bergmann
Change-Id: I2b867a93fd8c5cf3c1e4f53863c441478d9201e1
2016-06-29Fix inconsistent dependencies of "make $MODULE" vs. "make $MODULE.build" etc.Stephan Bergmann
...where the latter failed to rebuild compilerplugins if necessary, while the former did. (No idea about the proper dependencies of "make $MODULE.showdeliverables".) Change-Id: Ib6f8e193445229745475aa52eb7a78ebb30e49e5
2016-06-29loplugin:staticmethodsStephan Bergmann
Change-Id: I0f1be4e783dfa039cf8cec085df9827adbd56b35
2016-06-29vcl: GTK: fix libstdc++ "irreflexive" assertMichael Stahl
/usr/include/c++/6.1.1/bits/stl_algo.h:4737: Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)). GdkRectangleCoincident is clearly not a less-than operator as required for std::sort. Change-Id: If2e65d420dc8cdf0707081361a40d4eaea28424e
2016-06-29vcl: handle PDF data in Read/WriteImpGraphic()Miklos Vajna
Initially I wrote the test to cover f7d6f3e4e3fda3cd4936880918e2831246634a3e (svtools: survive swapout/in of graphic with embedded pdf, 2016-06-28), but as it turns out the actual swapin/out code is in vcl, so extend that as well to support pdf data. Change-Id: I320ea729dce9440b84a5089607807322ea7b0b04 Reviewed-on: https://gerrit.libreoffice.org/26755 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29Reinstate: tdf#99729: fix text alignment (no autofit & no full width)Caolán McNamara
with extra disposes to shutdown the test thingies in the right order This reverts commit a4780b3c8b45261e59ed3cbb34c4463d58ad8079. Change-Id: I13282d6bc54a0dceb3ed91a04cd438a9011154fe Reviewed-on: https://gerrit.libreoffice.org/26756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29tdf#100413 Use same default values for preview string and format listLaurent Balland-Poirier
Add specific default values for: - scientific: to distinguish engineering notation - fraction: to have quarter format understandable Change-Id: I73b74713a4bc502e9967b8d2c9983cfc6244912e Reviewed-on: https://gerrit.libreoffice.org/26391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29Further clean-upStephan Bergmann
Change-Id: I16b8bfe2c4a337acf188ec8ffa2ed084ca437faa
2016-06-29Further clean-upStephan Bergmann
Change-Id: Ice5fcb8f598b079afde3346f569d9619f1383506
2016-06-29Move accessibility relations to .ui files, Part 12: tdf#87026Muhammet Kara
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. As of this commit, all accessible relations have been moved to .ui files other than a few exceptions. Change-Id: Ic9dffdde414d245c13f13ee08543f90884991222 Reviewed-on: https://gerrit.libreoffice.org/26707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29add XOR test caseZdeněk Crhonek
Change-Id: I07a2cf1d38757614c469e2cb7bfb3730ea32f3cc Reviewed-on: https://gerrit.libreoffice.org/26741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-29Revert "tdf#99729: fix text alignment (no autofit & no full width)"Miklos Vajna
This reverts commit 0cb200d000fad8ba31c7400e08cd031823f27308. Even if it was verified by Jenkins, it broke CppunitTest_sd_import_tests on a number of tinderboxes. Need to at least find out how to reliably trigger the crash and fix it before it goes in again. Change-Id: I7ed52cae559648ec101b7a343046a7d74a7c48d3
2016-06-29loplugin:passstuffbyrefNoel Grandin
Change-Id: Ic96736e5dc07abcbb738bcc4664981e3e142eee9
2016-06-29Get rid of some repetitive warnings about unimplemented MetaActionTypesTor Lillqvist
Change-Id: I79b11918a7d1fd9d47dcf2f14f27924ab739c21f
2016-06-29loplugin:defaultparamsStephan Bergmann
Change-Id: I17fd4679e0a6a58856021b40575ac9603da01b37