summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-22Restore .git-hooks/commit-msg accidentally removed earlierTor Lillqvist
(Removed in a06954bf5b100c9433b4e1dbcdcf8ab2df2763a1.) Change-Id: Ieec84ecb9863c490786e4c195b8e6a838c0712a0 Reviewed-on: https://gerrit.libreoffice.org/54662 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-22sw: prefix members of WW8StyleMiklos Vajna
Change-Id: Ib42250d293b7dc5ae5f4dca8687d8052db8da21e Reviewed-on: https://gerrit.libreoffice.org/54653 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22loplugin:unusedfields in avmedia..comphelperNoel Grandin
Change-Id: I74f125103b67c506d9bb67537e4c4cd3f8f871da Reviewed-on: https://gerrit.libreoffice.org/54641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22Fix the incomplete self reference checks for doublerefsDennis Francis
This fixes the case when the start and end points of the doubleref are themselves outside the formula-group range, but the doubleref engulfs the entire formula-group. Change-Id: Ie43ef5560a867769a1f08c893d9497c40401cc5b Reviewed-on: https://gerrit.libreoffice.org/54642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-22tdf#117342 - Add Karasa Jaga to LibreOffice coreRizal Muttaqin
Change-Id: Id121df0ddc763a299c5714cadd0d61740876e3d6 Reviewed-on: https://gerrit.libreoffice.org/54512 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-22Related tdf#83877 Select certificate ok button label doesn't matchSamuel Mehrbrodt
Change the button to "Select" instead of sign when we only want to select a certificate. Change-Id: Ifa896e502c8680497d71912ddd1058ab0b71542b Reviewed-on: https://gerrit.libreoffice.org/52823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#117171 unit test for localized page number numbering stylesLászló Németh
Change-Id: Iad92cbe0b0376725c3078d26a4f3201d072c3c16 Reviewed-on: https://gerrit.libreoffice.org/54554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-05-22tdf#117171 support localized page number numbering stylesLászló Németh
in ordinal and cardinal number names and ordinal indicators. Change-Id: I35fa9c5c31b31f112ac0bb7feb5d310daca819e1 Reviewed-on: https://gerrit.libreoffice.org/54553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-05-22Don't try to sign when no certificate is selectedSamuel Mehrbrodt
Change-Id: I30f8f5970538db25ae678dc5b32afb292fd3983a Reviewed-on: https://gerrit.libreoffice.org/54652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Use Signer comments as signature descriptionSamuel Mehrbrodt
Change-Id: Ia9f18addeee9cf86989c873419113ddbd07c219f Reviewed-on: https://gerrit.libreoffice.org/54551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Add valid/invalid images to signaturesSamuel Mehrbrodt
Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on: https://gerrit.libreoffice.org/54513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Revert "lokdialog: Give non-programmatic name to autofilter"Jan Holesovsky
In the meantime, we are able to treat the title-less pop-ups just fine. This reverts commit a895f6356159f4267c0ac24781814ae0cbcba0b9. Change-Id: I1e2913190e9a1141eddf9aba0732e57bd5407987 Reviewed-on: https://gerrit.libreoffice.org/54629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-05-22Really don't show empty Writer document on cancelled recoveryMike Kaganski
Commit b5ad981518f4407243f89507b2561dd0b1ef28ee tried to make that, but either didn't work on all platforms, or was broken later. Then, commit fbe9accf36ac4c52ef5bcb84d455b4d06c317668 handled one special case. The problem is that cancelling recovery returns false. It's unclear why the distinction should be done for the cancelled recovery case: in any case, if the recovery has opened some documents, it will be handled in the code that enumerates frames ("no default document if a document was loaded by recovery..." comment). In other cases, we need to honour user command line parameters (selected module), and if none is specified, do the global default, which is currently to show Start Center. So - let the OpenDefault() do just that. Change-Id: I90f3581fc72628d1317e97074a4a1d352d630c7e Reviewed-on: https://gerrit.libreoffice.org/54604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-22tdf#77444: Call TriggerUserEventProcessing() in a few key placesTor Lillqvist
Causes the updated aAppEventList to be handled right away, and not only when the next ten-second timed fires. Change-Id: Idbcc67f13c8ea69cc08b6c5f832d4461579d5dc6 Reviewed-on: https://gerrit.libreoffice.org/54643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-22Bin dead codeTor Lillqvist
OleServer::provideService() was not called anywhere. That means the ProviderOleWrapper class is unused, too. Which is good, as it seemed to largely be identical to OneInstanceOleWrapper anyway. Change-Id: If8782d56ed1ec1bb173cfc18be585be4c331f335 Reviewed-on: https://gerrit.libreoffice.org/54647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-22vbahelper, xmloff: Ask current datetime only onceTakeshi Abe
Change-Id: I930983fab11d30f0887965fe30b07c5ac6eef8ef Reviewed-on: https://gerrit.libreoffice.org/54651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22tdf#108523 Remove @author annotationsAbhyudaya Sharma
Change-Id: Icd9cd2c17657001058f09c4042804a91b4f1d1b1 Reviewed-on: https://gerrit.libreoffice.org/54539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Turn debug fprint in vcl/unx/generic/fontmanager/ into SAL_INFOStephan Bergmann
...mapping OSL_DEBUG_LEVEL > 1 ones to "vcl.fonts" and OSL_DEBUG_LEVEL > 2 ones to new "vcl.fonts.detail" Change-Id: I750b4915083c4a0f9d0310a667987ff33d7fcc2a Reviewed-on: https://gerrit.libreoffice.org/54526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-22Place help button on the left of signature dialogOlivier Hallot
Change-Id: Ic78646b7540d2eaf176b3b6c57b0225793b866bd Reviewed-on: https://gerrit.libreoffice.org/54597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Fix svg to base64 conversionSamuel Mehrbrodt
This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had a questionable fix by unconditionally removing the first 8 bytes of the svg which led to svgs starting with rsion="1.0" encoding="utf-8"?> instead of <?xml version="1.0" encoding="utf-8"?> Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03 Reviewed-on: https://gerrit.libreoffice.org/54550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Don't pass ODF version, just retrieve it directlySamuel Mehrbrodt
Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf Reviewed-on: https://gerrit.libreoffice.org/54483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Rename parameter bScriptingContent -> bSignScriptingContentSamuel Mehrbrodt
Change-Id: I227e59417719625a9752e727060f5e4f5094092d Reviewed-on: https://gerrit.libreoffice.org/54479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Simplify SignContents_Impl by moving readonly check to caller methodsSamuel Mehrbrodt
Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44 Reviewed-on: https://gerrit.libreoffice.org/54478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Reduce indentation by returning early on error conditionSamuel Mehrbrodt
Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c Reviewed-on: https://gerrit.libreoffice.org/54475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#97231: basic: do not use extra wrapping for string marshalingVasily Melenchuk
previous approach did wrap string reference once again, making practically "a pointer to pointer to string" so this code was not working correctly for RegQueryValueExA WinAPI call. String is already provided as a reference (see marshalString(), so no reason to wrap its reference. This approach was just copied from from dllmgr-x86.cxx plus some minor changes to make both versions similar. Change-Id: I85065112407de3f078265d2c76437814402eb1b3 Reviewed-on: https://gerrit.libreoffice.org/54645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-22Fix misleading comment: We do check HAVE_FEATURE_READONLY_INSTALLSET...Tor Lillqvist
...at least in a couple of places, and at least for a sandboxed macOS build that check does its job, it prevents write attempts into the app bundle. Change-Id: I6d243d3e8a4c77f03a8265125aefd75becbf0998
2018-05-21tdf#117189 Fix table InsertRow redoJim Raykowski
Change-Id: I92ce18105550d9514b18b81080cfd0c19dfe648b Reviewed-on: https://gerrit.libreoffice.org/53618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-21uitest - Calc standard filterZdeněk Crhonek
Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd Reviewed-on: https://gerrit.libreoffice.org/54636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-21weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFieldsCaolán McNamara
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900 Reviewed-on: https://gerrit.libreoffice.org/54541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21weld SfxCheckinDialogCaolán McNamara
Change-Id: Iaa7954baf734229683acb81819daa332b02a7733 Reviewed-on: https://gerrit.libreoffice.org/54624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21loplugin:staticaccessTor Lillqvist
Change-Id: I9e8accc56fc1d3b095390944a5ae2fc80bcbc05d
2018-05-21Activated notebookbar in drawKshitij Pathania
Added tabbed and two groupedbars mode of notebookbar. Change-Id: I208a365139ca6c83510a73a8ffa0260b05787793 Reviewed-on: https://gerrit.libreoffice.org/54547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-21check-elf-dynamic-objects: Fedora 28 GTK+ depends on libfribidi.so.0Michael Stahl
... so add it to whitelists. Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf Reviewed-on: https://gerrit.libreoffice.org/54607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-21sw: Ask current datetime only onceTakeshi Abe
Change-Id: I99bed9a09ed1701ce441ddb0a19b5259ab37f135 Reviewed-on: https://gerrit.libreoffice.org/54621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21Updated coreOlivier Hallot
Project: help 4e45182924569adab9bc43ec174b3c4c828c7452 tdf#102259 formula groups at Statistics tab page Change-Id: I206139776c77e8855bd82fc5b5ffaa6c0ec60147 Reviewed-on: https://gerrit.libreoffice.org/54627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-21dont use SwClient/SwModify in unocore: RefMarkBjoern Michaelsen
Change-Id: I021f410793c9debfe5e984d591144636d6793fd6 Reviewed-on: https://gerrit.libreoffice.org/54610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-21weld ODateTimeDialogCaolán McNamara
Change-Id: Id93147f1d442e1e5f1cfba8ef2f9e476f4f6d728 Reviewed-on: https://gerrit.libreoffice.org/54623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21In fact it's simpler to not have m_guid fields in these two classes at allTor Lillqvist
We can just pass the GUID as parameter to the single member function registerClass() that needs it. This perhaps means the same class can be used in more cases, also for objects/classes that aren't going to be registered and don't need any GUID. Change-Id: I28703190c52b14236c6f613dd4acbe359c075f5c Reviewed-on: https://gerrit.libreoffice.org/54622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21weld SchAxisDlgCaolán McNamara
Change-Id: I18441b4fc06b69caf12dc73e5042ad2b609a7cc5 Reviewed-on: https://gerrit.libreoffice.org/54620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21Updated coreOlivier Hallot
Project: help 1d9b92c466b2b920ff46987d1668f4494b9f743a Fix media path for en-US Change-Id: If3a9667fa3dd8c1007132448a23e75d66279a192 Reviewed-on: https://gerrit.libreoffice.org/54640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-21weld SplinePropertiesDialogCaolán McNamara
Change-Id: I1df0f2bce86da698205c5b36217f935e0e971de5 Reviewed-on: https://gerrit.libreoffice.org/54619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21Add sal/osl/unx/file.cxx for debugging convenienceTor Lillqvist
Change-Id: Ibfc8995c4d35c33fe203b9779b10a182cf5a4294
2018-05-21fix navigate by previous headings does not wrap when cursor positionJim Raykowski
...is before first heading unreported bug fix for a patch I made for tdf#115600 Change-Id: I7ccaad387c5ea344cda71d3cc1f185e590a1f586 Reviewed-on: https://gerrit.libreoffice.org/54059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21gla11y: Enable warnings for more widgets missing a labelSamuel Thibault
Namely GtkSpinButton GtkSpinner GtkProgressBar Change-Id: I00c1d03cde43d23cee5e8b502a03284ac81967a5 Reviewed-on: https://gerrit.libreoffice.org/54131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21Improve placement of tdf#117024/tdf#117283 patchesJim Raykowski
no need to repeatedly call so relocate the patches Change-Id: I87f8be3c1802924e76134d3221a72b04c1a03e54 Reviewed-on: https://gerrit.libreoffice.org/53919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#98544 Other Options remain expanded if any checkbox is checked.manujvashist
Change-Id: I2de79da0f0a6295d4d3c294d7cf6c123fca914bc Reviewed-on: https://gerrit.libreoffice.org/51190 Reviewed-by: Manuj Vashist <manujvashist@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#117581 impress: fix selection overlay after moving tableDaniel
Change-Id: Ie5afa4fbddf86c6692a7ed68af9ef990c2f9f487 Reviewed-on: https://gerrit.libreoffice.org/54493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#115600 Display messages in FindBar for Footnote navigationJim Raykowski
...and make Footnote navigation wrap Change-Id: Ie4ab6a5d34ba75119f900f46a983a031b84ab51a Reviewed-on: https://gerrit.libreoffice.org/54556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#97231: potential crash fixedVasily Melenchuk
blob2 pointer can be invalidated during marshalString() call, because it also adds new element in data vector and thus later access to blob2 can cause crash. Change-Id: I2de519c363193f34b249e7250a016397b7420882 Reviewed-on: https://gerrit.libreoffice.org/54613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21Partially revert "Fixup 23c5125148a8110d88385b29570bf0b7d4400458"Khaled Hosny
This reverts most of commit e8d48dd75a1bb31b5bc500bc79fb80384a09bcc6. Hopefully it will make the Win@42 tinderbox happy again. Change-Id: Ie5ef2c16a62e774dcd1f6005df3d86e1973dea2d Reviewed-on: https://gerrit.libreoffice.org/54567 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>