summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-12loplugin:constantparamNoel Grandin
Change-Id: I676a8408e97cc8134009f764736cad68513c89ad Reviewed-on: https://gerrit.libreoffice.org/58875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-12Don't show ShowImeStatusWindow in the customization dialogMaxim Monastirsky
Change-Id: I5aeac6cf6ec9fae56c0dba3c176e0d6c52a28a5e Reviewed-on: https://gerrit.libreoffice.org/58899 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-12Fix typosAndrea Gelmini
Change-Id: I673b9121968ff79e6313e4019bc02a3364b4737f Reviewed-on: https://gerrit.libreoffice.org/58901 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2018-08-12Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Avoid several JS errors. Change-Id: If0b8b4f3e8c3464f4e7f812ba727a929330438f3 Reviewed-on: https://gerrit.libreoffice.org/58864 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-12Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Use window.location.href = ...; instead of window.open(..., '_self'); Otherwise the interim URLs end up in the history. Change-Id: If99aa1a29126f93387d2f5a6460cc0d43b488cd9 Reviewed-on: https://gerrit.libreoffice.org/58867 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-12Use o3tl::temporaryMike Kaganski
Change-Id: Ifbe8de75aa0000eab9403b8e6366ecd927851c32 Reviewed-on: https://gerrit.libreoffice.org/58894 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-12Sort includesMike Kaganski
Change-Id: Ied47f42098eb7975340ba82406fefbeb0533d704 Reviewed-on: https://gerrit.libreoffice.org/58893 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-12Draw menubar: add icons to shape menusectionandreas kainz
Change-Id: Ia095375bc300e45ce4956867fc02472d1e11a0dc Reviewed-on: https://gerrit.libreoffice.org/58890 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-12Fix typosAndrea Gelmini
Change-Id: I2cee481ec18f52d6610ab73b99637268b2340337 Reviewed-on: https://gerrit.libreoffice.org/58886 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-12KJ:^macro,db*sql,compare doc icons, copyright fileRizal Muttaqin
Change-Id: I1460f178ba0f7a568ba341cc5456658a441010f9 Reviewed-on: https://gerrit.libreoffice.org/58891 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-12Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - correct variable name in VBA example for WeekdayName function Change-Id: I79cbb241239f1f9cee59994b2b35e76703b1aa1a Reviewed-on: https://gerrit.libreoffice.org/58885 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-12Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - fix description of VBA Rate function Change-Id: I6cd34d766825d5c947a533368b8ce8d132324fab Reviewed-on: https://gerrit.libreoffice.org/58883 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-12Fix fallout from 6a4c464b49dbfa2801818ead1b50bc9580824d00Tor Lillqvist
Change-Id: I72e4008a0aacf7e35006be685462168874954631
2018-08-11Added PDF Export option on Android ViewerMert Tumer
Change-Id: I89d0ca239e3a713979f84a77a66d6da95aad234d Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/58826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-11set copy_paste_error to false rather than intentionalCaolán McNamara
Change-Id: I152482ef594c286d3c2a94cab62feff49bbf79fa Reviewed-on: https://gerrit.libreoffice.org/58884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-11tdf#119197: import some symbols as symbols, not as Math functionsMike Kaganski
... to avoid broken formulas due to missing arguments Change-Id: If86737450a16a257528cfb9d5f52915ec930f6a8 Reviewed-on: https://gerrit.libreoffice.org/58835 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-11when DISABLE_DYNLOADING gc linkingCaolán McNamara
Change-Id: Ifba1dd8e6cf095b965ed1277ce63505085f1d13c Reviewed-on: https://gerrit.libreoffice.org/58854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-11loplugin:mergeclasses AbstractShapeFactory into ShapeFactoryNoel Grandin
Change-Id: I9cc607bcc84a14ffdbe22bdbe1a038f5b22b719a Reviewed-on: https://gerrit.libreoffice.org/58871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-11loplugin:unusedmethodsNoel Grandin
mostly this seems to be fallout from commit 089a4f245325a5be5cd5951d85305d791b4d9cb6 Date: Mon Aug 6 14:55:04 2018 +0200 remove Calc's software interpreter Change-Id: Ib48696e724969a28a7d41155ba1573fd9cd58be6 Reviewed-on: https://gerrit.libreoffice.org/58869 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-11writerfilter: ensure bidi has expected valueJustin Luth
In case the document has an unexpectedly high positive value for bidi, don't let that mess up the logic. Change-Id: I133dbec738a7503dff49b2af6d1a35b2f7754a9d Reviewed-on: https://gerrit.libreoffice.org/58827 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-10Simplify control logicMatteo Casalin
Change-Id: I71d688862458df25e3f417e7aee32d072aa51d50
2018-08-10Use indexed getToken()Matteo Casalin
Change-Id: I102c9ea0b11144cc930b5e4d3617f6178b63218b
2018-08-10Use indexed getToken()Matteo Casalin
Change-Id: Iaf52b7eee0e906d2c21982b354b69fd8d87231e3
2018-08-10OUString: avoid getTokenCount to only get last tokenMatteo Casalin
Change-Id: I68529076a6a6c2b23842c41d3e9099083a78d3c6
2018-08-10OUString: avoid getTokenCountMatteo Casalin
Change-Id: Icceff0aeb5c6fb70513786366416c2d86b60602a
2018-08-10CopyDlg: avoid getTokenCountMatteo Casalin
OUString managed inside this class either is empty or has 8 tokens, simplify check. Change-Id: If576187c6e4800e85f1cebb1ed3e1ae87a4315d1
2018-08-10OUString: use optimized concatenationMatteo Casalin
Change-Id: Ibaaa29568fe46148baa47422853ef2e627f4045b
2018-08-10OUString: use indexed getToken and convert to proper integer typesMatteo Casalin
Change-Id: I39210971a65e62cc22b384ebf090a987747c57af
2018-08-10Avoid getTokenCountMatteo Casalin
Change-Id: Ib1b6c354184b9379ebafb15ac4a1c789e1c3c1a2
2018-08-10Use ASCII literals in indexOf and compare result against 0Matteo Casalin
Change-Id: I3bea0f3d0566d46c9f92e74f452b6c5a009adcd6
2018-08-10Reduce OUString operationsMatteo Casalin
Change-Id: I379cc523587da41ee270ac90e8cfdc00526a2745
2018-08-10Fix whitespacesMatteo Casalin
Change-Id: I4d64e537fe6eacf8481479604ee34272073d9aae
2018-08-10Avoid getTokenCount/getToken to get last tokenMatteo Casalin
Change-Id: I19de49e64746a6632c56c0ddb0a0c455c97be414
2018-08-10cleanup tdf#106062 writerfilter: use new GetAnyProperty functionJustin Luth
Change-Id: I88945bbaaf07e3b068c63f17c654c5f7fee9d20a Reviewed-on: https://gerrit.libreoffice.org/58828 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-10vcl: separate SalLayout from the rest of sallayout.hxxMiklos Vajna
This way SalLayout can be created separately (and potentially reused) outside vcl as well. Don't reformat the moved code, so git blame keeps working. This is a first step towards the goal of <https://wiki.documentfoundation.org/Development/Budget2017#Text_layout_performance>, in the context of code outside vcl. Change-Id: I8b40313b5fa531d3b56c153cbc4b5ca3cec8f8df Reviewed-on: https://gerrit.libreoffice.org/58851 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-10vcl text layout: return early for empty stringsMiklos Vajna
It seems the only side effect of GenericSalLayout::LayoutText() is push_back() calls on m_GlyphItems, which doesn't happen for an empty string input, so it's safe short-circuit this case. Change-Id: Ia6e2865117bca60573e2874f11d3742413e9df4b Reviewed-on: https://gerrit.libreoffice.org/58850 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-10tdf#119169 impress, crash when editing bulleted listNoel Grandin
regression from commit e278df1a14c5cb5dbb7add5d6ed5dd52da131e92 tdf#108608 Draw file unresponsive on large text pasted into textbox Somewhere up in the accessibility code it has a stale paragraph index. Judging up other code in this class, that is fairly common, so just add similar safety checks. The old code (pre-regression) only worked because it iterated over all paragraphs, and it just ignored the paragraph index. Change-Id: I51c573b95f976fa87228e4f7e9f33bd6ea0dc3c8 Reviewed-on: https://gerrit.libreoffice.org/58836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10vcl statusbar: fix last non-use of pre-calculated layoutMiklos Vajna
Use it in the offscreen rendering case as well. Layout calls are visible by logging the invocations of GenericSalLayout::LayoutText(). Change-Id: I9157aa56d22b6c0cee71cdaeca4d61d1c673c79e Reviewed-on: https://gerrit.libreoffice.org/58831 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10shrink scrtf fuzzerCaolán McNamara
Change-Id: I977636eff8a2962ca248287f8733422d635f8559 Reviewed-on: https://gerrit.libreoffice.org/58833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-10tdf#119160 remove fill from all fontwork shapesSzymon Kłos
Change-Id: I66cd5ab39c3f3b8635eb4e9b5261e100a8037abf Reviewed-on: https://gerrit.libreoffice.org/58817 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-10vcl statusbar: store calculated layout in StatusBar::SetItemText()Miklos Vajna
Otherwise we calculate the layout of the text multiple times, which is a waste of resources. This effectively reverts commit a4ed3d9a1ffa1b51ba4352a955c950235f099fdc (tdf#115353 Status bar: no cache in settext, 2018-03-01). That seems to be safe, given that I can't reproduce tdf#115353 after this change, and reading through the comments the bug was reported fixed after both the mentioned commit and commit 8d42909cd326cb26d8ba1fb383b5578f820c72ed (tdf#115353 layout fix, 2018-02-23). So either the first one was not necessary, or it just worked around an underlying problem that has been fixed in the meantime. Change-Id: I79c014e9ce41be0c06dae65b5195a23d0d88c2aa Reviewed-on: https://gerrit.libreoffice.org/58830 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10Translate German variable namesJohnny_M
This is a follow-up to commit 48806ad275b0c4c8fa3eb1637684092266ec6a0d for the rest of the variables in the same files. Change-Id: I2d95f73be4cf3d91315ed4f7fac80484a7cb29b0 Reviewed-on: https://gerrit.libreoffice.org/58698 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-10tdf#91999 export/drawingml: shape rotate 180 is not specialJustin Luth
This commit reverts the first (LO 4.3ish) regression commit 6063555744ed89d8a757b667cddcdd4357839466 and most of the two commits that tried to fix that: commit 9ae1e094d5a8a5b4432c88ebea0ca9fc1c79f602 and commit ee45d881efab230e7682f964d6ad4d00f85b0006 in LO6.0/6.2. The ooxmlexport6 unit test shows that there is nothing special about 180degrees. So, all transformations need to be avoided in docx format - not just 180 degree ones. I removed IsInGroupShape() since it is no longer being used - as per standard procedures. Change-Id: Id2bba5bc542875a10ac21fbb67f29b2d59705493 Reviewed-on: https://gerrit.libreoffice.org/58434 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10Avoid -Werror=deprecated-declarations with recent Clang trunkStephan Bergmann
...which first added alternative names to and then deprecated getLocBegin/End Change-Id: Iaefb8ce259057abfa6cd20f0b63c0ef2949a96b2 Reviewed-on: https://gerrit.libreoffice.org/58820 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-10tdf#42949 Fix IWYU warnings in include/salhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iaef3e980a96e8a831458e42540795b922bec5ab4 Reviewed-on: https://gerrit.libreoffice.org/58810 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10tdf#111856 Playing video in impress is considered a modificationNickson
Change-Id: If7a2db2d37dc6230a76b79c79e6163a1b33be7d2 Reviewed-on: https://gerrit.libreoffice.org/58713 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-08-10Resolves: rhbz#1614419 FIPS mode PK11_ImportSymKey failureCaolán McNamara
use rhbz#1461450 style workaround Change-Id: I9e3b17deb9bac6af76ac253634c91d5e8ccd4963 Reviewed-on: https://gerrit.libreoffice.org/58816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-10Revert "uitest for bug tdf#79569"Stephan Bergmann
This reverts commit 5bd027e17f3656ab65548126ed6d7e309818eae7. It kept failing in the Jenkins ASan+UBSan build (see below) but wasn't reproducible/debuggable by anybody else. So as discussed with vmiklos on #libreoffice-dev, lets disable/revert this test for now. This also includes reverts of the follow-up commits that unsuccessfully tried to track down and fix the issue: * c57191e0c45f9735a33953d6b95d54b0e10c876f "Try to make test_tdf81457_table_merge_undo deterministic" * 88d82b7da7f3b362c62494875ad359158be964d8 "Temporarily sprinkle test code with debug print statements" * a94a481c9f5088e6957220a7e09b64fc3f15aaf1 "One last attempt at fixing UITest_writer_tests for Jenkins ASan+UBSan build" With the above follow-up commits still enabled, the latest failure of the ASan+UBSan Jenkins bot was <https://ci.libreoffice.org//job/lo_ubsan/998/> [...] > warn:vcl.gdi:26099:26099:vcl/headless/svpgdi.cxx:235: non default depth bitmap, slow convert, upscale the input > WPSDocument::isFileFormatSupported() > warn:i18nlangtag:26099:26377:i18nlangtag/source/languagetag/languagetag.cxx:1388: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'xx-XX' > warn:legacy.osl:26099:26798:sw/source/core/table/swnewtable.cxx:222: Didn't find wished box > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [1]: 8393 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2137: Wrong position/size of overlapped table box > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2164: Different Line Widths: first: 9894 current [2]: 1982 > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:2167: Line width differs from table width: 9894 current [2]: 1982 > warn:legacy.osl:26099:26798:sw/source/core/table/swnewtable.cxx:222: Didn't find wished box > warn:sw.core:26099:26798:sw/source/core/table/swnewtable.cxx:216: Possibly wrong box found > soffice.bin: /home/tdf/lode/jenkins/workspace/lo_ubsan/sw/source/core/layout/findfrm.cxx:1702: const SwCellFrame &SwCellFrame::FindStartEndOfRowSpanCell(bool) const: Assertion `pRet && "SwCellFrame::FindStartRowSpanCell: No result"' failed. > > > Fatal exception: Signal 6 > Stack: > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/soffice.bin(backtrace+0x41)[0x44f821] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x457429)[0x2b7859768429] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x456c25)[0x2b7859767c25] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x45452a)[0x2b785976552a] > /lib64/libpthread.so.0(+0xf6d0)[0x2b785b78b6d0] > /lib64/libc.so.6(gsignal+0x37)[0x2b785bff1277] > /lib64/libc.so.6(abort+0x148)[0x2b785bff2968] > /lib64/libc.so.6(+0x2f096)[0x2b785bfea096] > /lib64/libc.so.6(+0x2f142)[0x2b785bfea142] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xbd5c735)[0x2b792487d735] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xc74058b)[0x2b792526158b] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN7SwFrame6ShrinkElbb+0x1502)[0x2b7925218cb2] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xc710bb2)[0x2b7925231bb2] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN13SwContentNode9DelFramesEb+0x2a10)[0x2b79237ff1e0] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN7SwNodes9MoveNodesERK11SwNodeRangeRS_RK11SwNodeIndexb+0x12d4d)[0x2b79238848ed] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xa0168ea)[0x2b7922b378ea] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdd5f2f2)[0x2b79268802f2] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdebd7b4)[0x2b79269de7b4] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdc6c87c)[0x2b792678d87c] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN17SfxListUndoAction15UndoWithContextER14SfxUndoContext+0x5cc)[0x2b78774690fc] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN14SfxUndoManager8ImplUndoEP14SfxUndoContext+0x1b2d)[0x2b787744829d] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsvllo.so(_ZN14SfxUndoManager15UndoWithContextER14SfxUndoContext+0x106)[0x2b78774496d6] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdb2a648)[0x2b792664b648] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0xdb2bac7)[0x2b792664cac7] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN11SwEditShell4UndoEt+0x15b6)[0x2b7923f7cde6] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(_ZN10SwWrtShell2DoENS_6DoTypeEt+0x635)[0x2b792b4e14e5] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0x1168a394)[0x2b792a1ab394] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/../program/libswlo.so(+0x11688002)[0x2b792a1a9002] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x326de37)[0x2b787042be37] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3227341)[0x2b78703e5341] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(_ZN13SfxDispatcher8Execute_ER8SfxShellRK7SfxSlotR10SfxRequest11SfxCallMode+0x1a40)[0x2b7870401c50] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3196242)[0x2b7870354242] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3795206)[0x2b7870953206] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsfxlo.so(+0x3798e6f)[0x2b7870956e6f] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libcomphelper.so(_ZN10comphelper15dispatchCommandERKN3rtl8OUStringERKN3com3sun4star3uno8SequenceINS6_5beans13PropertyValueEEERKNS7_9ReferenceINS6_5frame23XDispatchResultListenerEEE+0x163a)[0x2b78628adb0a] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libvcllo.so(_ZN6UITest14executeCommandERKN3rtl8OUStringE+0x78d)[0x2b789fac7fbd] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libvcllo.so(+0x87b6b72)[0x2b789fae5b72] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x134616)[0x2b78e0997616] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x12dedb)[0x2b78e0990edb] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libgcc3_uno.so(+0x12aaef)[0x2b78e098daef] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x38ae9c)[0x2b78e63f5e9c] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x381e87)[0x2b78e63ece87] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libbinaryurplo.so(+0x4b213d)[0x2b78e651d13d] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x254191)[0x2b78641a1191] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x286a8e)[0x2b78641d3a8e] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_cppu.so.3(+0x298567)[0x2b78641e5567] > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libuno_sal.so.3(+0x48bc3d)[0x2b785979cc3d] > /lib64/libpthread.so.0(+0x7e25)[0x2b785b783e25] > /lib64/libc.so.6(clone+0x6d)[0x2b785c0b9bad] > DEBUG.1 > DEBUG.2 > DEBUG.3 > DEBUG.4 > DEBUG.5 > DEBUG.6 > DEBUG.7 > DEBUG.8 > DEBUG.9 > DEBUG.10 > DEBUG.11 > DEBUG.12 > DEBUG.13 > DEBUG.14 > DEBUG.15 > DEBUG.16 > DEBUG.17 > DEBUG.18 > DEBUG.19 [...] showing that soffice.bin hit the assert at sw/source/core/layout/findfrm.cxx:1702 during the second .uno:Undo (after the .uno:Redo). Change-Id: I24a4ae379a1589f6d762dc3979f963eb543ba6b6 Reviewed-on: https://gerrit.libreoffice.org/58813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-10tdf#116549 docx export: write "nil" to uninherit a borderJustin Luth
If styles would provide a border, then non-borders need to be explicitly written out. Unit tests prove this out for both styles and pragraphs. Change-Id: I4195d38622adc09831f6dad64840a92a42c494b5 Reviewed-on: https://gerrit.libreoffice.org/58803 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-10tdf#119194: save deprecated argument earlyMike Kaganski
Change-Id: I4b5001e1f71ac536ac0c3bda4b8c1955020ab40d Reviewed-on: https://gerrit.libreoffice.org/58815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>