summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-22Allow to pass additional options into generator's clang::toolingStephan Bergmann
In my macOS build, that clang::tooling::runToolOnCodeWithArgs invocation failed to find headers like cassert and assert.h, which works now with COMPILER_PLUGINS_TOOLING_ARGS=-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -isystem /Users/stephan/Software/llvm/inst/include/c++/v1 added to my autogen.input (I build against my Clang trunk libc++ whose headers are at /Users/stephan/Software/llvm/inst/include/c++/v1). Change-Id: Idbffa39c9fd4a88743fd498b8f7b6c9c56d7630d Reviewed-on: https://gerrit.libreoffice.org/69538 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-22rhbz#1690732 basic font variation supportCaolán McNamara
on the fontconfig/harfbuzz/cairo drawing path for preset variations Change-Id: I95ef68aecfd59687ae9aae58e01e394c83c6ea9e Reviewed-on: https://gerrit.libreoffice.org/69505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22find-unneeded-includes: don't try to fw. declare o3tl/span.hxxGabor Kelemen
As seen in include/sfx2/dispatch.hxx IWYU proposes to replace o3tl/span.hxx with fw declaration, but that won't compile Change-Id: If5739075bd91511cf22a39f3382c424c21829053 Reviewed-on: https://gerrit.libreoffice.org/69397 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22Unit test for cut copy move with a group reference adjusting along, tdf#121002Eike Rathke
Change-Id: I4f3731e2236f1b8be97a6f5d21e32e678610fecb Reviewed-on: https://gerrit.libreoffice.org/69532 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-03-22TableDesignBox is unusedCaolán McNamara
since... commit 57ca02a7486090f1dd63977bb8fb351f9bf9a7f3 Date: Wed Apr 18 00:04:09 2018 +0200 NB Impress tabbed toolbar big update Change-Id: I357a65b5f71ff9960f36d2e4ae64117509b41a48 Reviewed-on: https://gerrit.libreoffice.org/69536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22CustomAnimationBox is unusedCaolán McNamara
since... commit 57ca02a7486090f1dd63977bb8fb351f9bf9a7f3 Date: Wed Apr 18 00:04:09 2018 +0200 NB Impress tabbed toolbar big update Reviewed-on: https://gerrit.libreoffice.org/53072 Change-Id: I45f099d2521db576089e8d555f7ccc8fef6d49bc Reviewed-on: https://gerrit.libreoffice.org/69535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22SmallButton unusedCaolán McNamara
since... commit 57ca02a7486090f1dd63977bb8fb351f9bf9a7f3 Date: Wed Apr 18 00:04:09 2018 +0200 NB Impress tabbed toolbar big update Change-Id: I7c59d5388138166851c24d1494dc3293a32f8330 Reviewed-on: https://gerrit.libreoffice.org/69537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22reorient dialog to standard orientationCaolán McNamara
Change-Id: I4883d3f79250edeafb78fa58f993955b5839f041 Reviewed-on: https://gerrit.libreoffice.org/69531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22tdf#124109: Fix missing kashida glyphsKhaled Hosny
This partially reverts: commit 436b829f5b904d76039db0818cff5dedf1ae89f1 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Thu Aug 16 17:35:17 2018 +0200 sw: save one vcl layout call in SwFntObj::DrawText() Pressing a key in Writer used to lay out the relevant string 4 times (counting GenericSalLayout::LayoutText() invocations), save one of them by pre-calculating the layout and sharing it between GetTextArray() and DrawTextArray(). The reverted part was causing inserted Kashida to be missing, leaving gaps inside the words. See attachment in the bug report. Change-Id: Iaafbc793ed5906e6fdf3dcb03c54d5a440e15da4 Reviewed-on: https://gerrit.libreoffice.org/69530 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22tdf#123943 sw btlr writing mode render: fix text portion backgroundMiklos Vajna
The text frame is swapped in this case, so handle BTLR similar to the normal vert (TBRL) case and the background will be positioned correctly behind the text portion. Change-Id: I2399131ef74ea8849577a467ad9bb02d980d8609 Reviewed-on: https://gerrit.libreoffice.org/69539 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22tdf#124211: fix regression in sd/slidesorterJulien Nabet
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8f6a170e4bbb5d0a0bf06d26560189e4ca7ecfb0 Change-Id: I2b574cc7ddaf55e770bc5b746e615834f413b6b4 Reviewed-on: https://gerrit.libreoffice.org/69540 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-22Sifr icon theme update lc_andreas kainz
Change-Id: I54ffd3ea66fcb5d6e7eb9922a1bb5e848ac74c58 Reviewed-on: https://gerrit.libreoffice.org/69542 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-22Fix typoAndrea Gelmini
Change-Id: I3cb9d607c468cf29ef3e409c4f59b7e0960362a7 Reviewed-on: https://gerrit.libreoffice.org/69544 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-22Fix some doxygen-generated documentation.Christophe JAILLET
Doxygen is misled by the "127." at the beginning of a sentence and converts it to "<ol><li>..." So it is erroneously rendered as: all ASCII characters are in the allowed range between 0 and 1. The ASCII string must be NULL-terminated. Change-Id: If36de7d4df668b5f9e9f6c7ea139552798e349d2 Reviewed-on: https://gerrit.libreoffice.org/69360 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-21fix db field page database refreshCaolán McNamara
Change-Id: I87e18e8624d63de18bd6e0d68eececab75e7166b Reviewed-on: https://gerrit.libreoffice.org/69527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-21Resolves: tdf#122804 make bitmap page 'add' dialog title localizedCaolán McNamara
Change-Id: I0c4f6775b8bc9fae8dc81f07fec2e21218e36037 Reviewed-on: https://gerrit.libreoffice.org/69520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-21license: JDOM is not included in LibreOfficeAndras Timar
Change-Id: I36606503c469cb069f81f57ac4f0836842c12e0f Reviewed-on: https://gerrit.libreoffice.org/69513 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: fix libe-bookAndras Timar
Change-Id: I3f72089d2f0dc4b34f166841049a6d0c757333cb Reviewed-on: https://gerrit.libreoffice.org/69526 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: add libepubgenAndras Timar
Change-Id: I38e30fb45aed7d2b8f39348e92afeb6a6f85ef6e Reviewed-on: https://gerrit.libreoffice.org/69525 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: libatomic_ops: the portion needed for Firebird is MIT licensedAndras Timar
Change-Id: I58ae4b4c7b94ba4d821681448e2cca19210db346 Reviewed-on: https://gerrit.libreoffice.org/69524 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21Typo: ibatomic_ops -> libatomic_opsAndras Timar
Change-Id: Iaa4ff5cd30d3163e7a44f162bbe296c59a7111cb Reviewed-on: https://gerrit.libreoffice.org/69514 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21tdf#121671 Floating toolbars remain their position after reopenIlhan Yesil
Calculate the relative position of the floating toolbars by calling the ImplCallMove function, where the current position is read from the real window. Change-Id: I6a142055c3340dda2339980fbc5a7ebb431e228b Reviewed-on: https://gerrit.libreoffice.org/64093 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21Resolves: tdf#122803 make gallery 'add' dialog title localizedCaolán McNamara
Change-Id: Iaa2ee6c982c8fd5d5cf1b9b09a835b917217d85c Reviewed-on: https://gerrit.libreoffice.org/69516 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-21tdf#124109: Revert "Only do kashida insertion with fonts that have non-zero ↵Khaled Hosny
width kashidas" This reverts commit c45b23377bb2fe44c26f1287ff38495344e4ca50. This commit breaks Kashida justification when a document is first opened (the kashida justification will be disabled and spaces will be used untill the text is changed). Probably it is checking for width of Kashida glyph too early. Also I'm not sure what the reverted commit was trying to fix since we already do kashida justification in fonts that has non-zero width Kashida and it has been the case for a long time. This does not fix the original issue in the document attched with the bug report, but if fixes kashida not being applied when opening the document. Change-Id: Ic95859bca94fa792793e3223d2adb465bc6d880f Reviewed-on: https://gerrit.libreoffice.org/69509 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-03-21tdf#124212 make adjustment handle work alwaysRegina Henschel
In method SetHandleControllerPosition() all transformations are reversed to get the coordinates in shape inner coordinate system from the outer position. The error was, that the first transformation, the move in method GetPoint was forgotten. In case of default viewBox '0 0 21600 21600' it is not visible. But the error is noticeable, if left or top do not equal zero. Change-Id: Icc3f4f2c603826151c95b8b9eea5030fb5805d67 Reviewed-on: https://gerrit.libreoffice.org/69439 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-03-21Close all opened List elements at the end of the pageKatarina Behrens
Change-Id: I7c1e11ec57537441417f6b1cebe137587883d8c1 Reviewed-on: https://gerrit.libreoffice.org/69259 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21Limit tagging of background objects to imagesKatarina Behrens
i.e. don't tag custom shapes and other than bitmap background fills Change-Id: I1d42012420f59e1e7b62affb8aca5a8c85688423 Reviewed-on: https://gerrit.libreoffice.org/69258 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21Correct hierarchy of L, LI structure elementsKatarina Behrens
in particular, don't terminate L prematurely Change-Id: Iaf642f547b072b12ccbf861536825a2526b8798a Reviewed-on: https://gerrit.libreoffice.org/69257 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-21add missing else in an if-else chainLuboš Luňák
No functional change, but avoid the warning. Change-Id: Ia552c6199806a9e029800e9d65c0852baa370bd8 Reviewed-on: https://gerrit.libreoffice.org/69270 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-21Make SvxChartColorTableItem more constArmin Le Grand
SvxChartColorTableItem has non-const members (aka modifiers) which is bad for SfxItems in general, see comments in change. Adapt SvxChartColorTableItem and it's usage in SvxDefaultColorOptPage as needed. This is also preparation for possible SfxItem refactoring Change-Id: Ia7982b4e7bbfa736229223e55ce63e02143b8cf7 Reviewed-on: https://gerrit.libreoffice.org/69499 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-03-21lok: intercept the UNO command ".uno:ThesaurusDialog"Henry Castro
Change-Id: I085cb646037f260ada4d4d04c2419638dd235048 Reviewed-on: https://gerrit.libreoffice.org/69264 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-03-21pUnoReturn should be null when UNO methode is VOIDJuergen Funk
the problem is that at least the msvc_win32_x86-64 bridge's unoInterfaceProxyDispatch (bridges/source/cpp_uno/msvc_win32_x86-64/uno2cpp.cxx) requires pUnoReturn to be a nullptr when the UNO method has VOID return type (see computation of retKind in cpp_call in the same file), but that IdlInterfaceMethodImpl::invoke doesn't set up the arguments according to that expectation. Change-Id: I187a997300571cd9822de2eeacf7ad887ad00a4f Reviewed-on: https://gerrit.libreoffice.org/69495 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-21license: liblangtag is LGPLv3+/MPLv2Andras Timar
See: http://tagoh.github.io/liblangtag/#sec2 or workdir/UnpackedTarball/liblangtag/README Change-Id: I0ce9b4c6ada0dad93f214d23f43800b89b6533df Reviewed-on: https://gerrit.libreoffice.org/69497 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21Increase the life-cycle of threads in thread-pool...Dennis Francis
to ScDocument lifetime if possible. This helps to avoid lots of thread setup-cost while doing recalcs especially if there are many formula-groups in the document and most of them are fairly light-weight. Change-Id: Idd57e1ebd0d4e492f99e31237d4a55ec9c95a121 Reviewed-on: https://gerrit.libreoffice.org/69473 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-21Related tdf#122788: avoid assertJulien Nabet
See: - https://bugs.documentfoundation.org/attachment.cgi?id=149853 - https://bugs.documentfoundation.org/attachment.cgi?id=149854 - https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c5 - https://bugs.documentfoundation.org/show_bug.cgi?id=122788#c6 Change-Id: Icd1d4afcd05bf5398813505702bf244bd18fbfee Reviewed-on: https://gerrit.libreoffice.org/69006 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-21tdf#123204 hu_HU collation: don't ignore special charactersLászló Németh
to show/handle them in Calc AutoFilter. Partial revert of "tdf#116666 fix Hungarian sorting" (commit 7b1eb6313c0d2621c364df1724c69d28f8267841). Change-Id: Ib135f1eac77780e901fb4c427c3f1bb8a5e090b9 Reviewed-on: https://gerrit.libreoffice.org/68014 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-21tdf#42949 Fix IWYU warnings in sc/source/ui/pagedlg...undoGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icb5f0235339364e6dc09936e26f256765a60830a Reviewed-on: https://gerrit.libreoffice.org/69378 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-21CppunitTest_svx_unit: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Ib2eac7368ebb06702f05101641e8830ea1fff6d5 Reviewed-on: https://gerrit.libreoffice.org/69483 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-21license: added bzip2Andras Timar
Change-Id: I467e8e7eb60ab0005b15217b0ff088fa6704cf1c Reviewed-on: https://gerrit.libreoffice.org/69492 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: internal Pixman is used, when internal Cairo is usedAndras Timar
Change-Id: I482f6b88314737a793e1d9e9ec1375d49ef676a3 Reviewed-on: https://gerrit.libreoffice.org/69491 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added PDFiumAndras Timar
Change-Id: I523aaa1d623565125a8e224fe8c0a25aa85154b7 Reviewed-on: https://gerrit.libreoffice.org/69490 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added Google breakpadAndras Timar
Change-Id: I79bff85fe4243c3c54fa038d333c713a4a3849ad Reviewed-on: https://gerrit.libreoffice.org/69489 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: STLPort is not included in LibreOfficeAndras Timar
Change-Id: I081ceab1c54b01ed6a3c6ad2702fd69f82b4493e Reviewed-on: https://gerrit.libreoffice.org/69486 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2019-03-21license: added APR and SerfAndras Timar
Change-Id: Ieaae5fcb6ef0163e63723604f0dea484d55b117d Reviewed-on: https://gerrit.libreoffice.org/69485 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-21tdf#79717 save/restore character style on selection overwritePhil Krylov
Change-Id: Ie423e72014734bc188ffb585150dcb024d377d1b Reviewed-on: https://gerrit.libreoffice.org/69323 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-21Fix typoAndrea Gelmini
Change-Id: I5e585dfe96e650da40c0311928e681619ba40bca Reviewed-on: https://gerrit.libreoffice.org/69494 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-21uitest for bug tdf#124111Zdeněk Crhonek
Change-Id: I346415708a439f1b11043c217de46da389d0231e Reviewed-on: https://gerrit.libreoffice.org/69484 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-03-21Sifr icon theme updateandreas kainz
Change-Id: I61762e501e062e0a0a22d5b5d7665b3aaa3bef57 Reviewed-on: https://gerrit.libreoffice.org/69488 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-20tdf#124168: The libctllo.a is needed in the iOS app for ToCTor Lillqvist
After I added the share/template folder, the app then turns out to need this UNO component. Change-Id: I877dd8c730f49477e20c58515ee80bafdafaa6b7
2019-03-20tdf#124168: The share/template folder is needed in the iOS appTor Lillqvist
Otherwise we get a warning dialog about a missing internal/idxexample.odt when inserting a table of contents. Change-Id: Id30be100906ea3292b9acd9e983ef7ae39ef63a2