summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-25Fix typosAndrea Gelmini
Change-Id: I35d4a7648566105b176eb39f6a1db44ca91d4f4c Reviewed-on: https://gerrit.libreoffice.org/35643 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I5fc62060e7d01c6b492a0e91323f753cc676bf71 Reviewed-on: https://gerrit.libreoffice.org/35639 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9 Reviewed-on: https://gerrit.libreoffice.org/35633 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ib8bec97be916d5ea70ae9fb9dc83771b6fec1845 Reviewed-on: https://gerrit.libreoffice.org/35634 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2 Reviewed-on: https://gerrit.libreoffice.org/35629 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I389542e18fcf71011f22919743b5280779f449fd Reviewed-on: https://gerrit.libreoffice.org/35632 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ifb779b6c96a009e6c770a8017bb2e2031a288f5f Reviewed-on: https://gerrit.libreoffice.org/35630 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I63ae7dbd7edf66aa5542f7d41f1bfd8ac04fc5e8 Reviewed-on: https://gerrit.libreoffice.org/35631 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Fix typosAndrea Gelmini
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: https://gerrit.libreoffice.org/35617 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25Access2Base Missing parentheses - Bug #106710Jean-Pierre Ledure
Due to more severe Basic interpreter on final parentheses missing parentheses were revealed Change-Id: I779b5e3d299fb9c56ecd807d28a780cc3ab9a1b5
2017-03-25refresh elementarty icons with svg and some 32px iconsandreas kainz
Change-Id: Ia02a3004e21c7a4df5e8df7eccb82a8ff7cb9686 Reviewed-on: https://gerrit.libreoffice.org/35671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-24update notebook icon now it work without backgroundandreas kainz
Change-Id: I15e9d5e8ae8cef6d1f5063d2d6c0f418ea12826d Reviewed-on: https://gerrit.libreoffice.org/35668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-03-24Fix configmgr argumentAndrea Gelmini
Commit 3e64874e7cd23 introduce a not-existent argument. Dunno if it's an issue. Just made this commit to show it to real developers! Change-Id: I01f4b859631e76e0d76269db19bcbcf3481d827c Reviewed-on: https://gerrit.libreoffice.org/35531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24Added Test for EditEngine - Copy/Paste with Hyperlinks in TextVarun Dhall
Change-Id: Iabe11ddac346f1c48b355c21797c11de8db54b1f Reviewed-on: https://gerrit.libreoffice.org/35593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24Added Test for EditEngine - Copy/Paste with Tabs in TextVarun Dhall
Change-Id: If40dabc53d35c01e61f8a17799f26e6ef9fd6b08 Reviewed-on: https://gerrit.libreoffice.org/35579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24starmath: Make SmParser::DoAlign() return SmNodeTakeshi Abe
instead of pushing it to the stack, for later refactoring. Change-Id: I61760fbfe95771dede62f90f82df3e9961efdcd6 Reviewed-on: https://gerrit.libreoffice.org/35609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-24Added Test for EditEngine - Copy/Paste using Underline TextVarun Dhall
Just because Underline is as important as Bold/Italic we cannot skip a test for it :) Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43 Reviewed-on: https://gerrit.libreoffice.org/35217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24tdf#106751 fix regressions in Hungarian spell checkingLászló Németh
using recent fixes of Hunspell code base Change-Id: I180a2ecba924180419c5eb1a0e78b5c84e7242c4 Reviewed-on: https://gerrit.libreoffice.org/35665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2017-03-24sw: remove CHECK_FOR_DEFUNC macrosMichael Stahl
Change-Id: I317b5fcd6e5753b4f854930ed4f4ceea53a385c4
2017-03-24tdf#106693 vcl PDF export, norefxobj: update XObject refsMiklos Vajna
Start copying referenced objects recursively, and also take care of updating references to the object IDs as they appear in our output. With this, the 4th image referenced from the PDF image has a correctly updated reference in its dictionary's ColorSpace key. Change-Id: I8b49701c1f60bd0ef5a097b24ce59164554c44fa Reviewed-on: https://gerrit.libreoffice.org/35653 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-24lok: Allow setting of the language during load.Jan Holesovsky
Change-Id: I9dbb62950e639376c26122ceb9fcec2982b3ca82
2017-03-24sw: just remove SwAccesibleContext must-override methodsMichael Stahl
What's the point? Change-Id: Ifdff4aae85282d213f82bd2d69f61f96f8b5e40c
2017-03-24sw: remove THROW_RUNTIME_EXCEPTION macroMichael Stahl
Change-Id: I74d4b31ea619c94245759b7a061c40095a0879ad
2017-03-24sw: remove CHECK_FOR_WINDOW macroMichael Stahl
Change-Id: Ie375b199e055a01b0888a6efe56ef3a2801412b2
2017-03-24sw: convert to assert in SwAccessiblePageMichael Stahl
Change-Id: I3bb8430be2460fa72938a4952670d3d92b12e123
2017-03-24sw: remove SolarMutexGuards from SwAccessible* constructorsMichael Stahl
Clearly the mutex must be locked by the caller already. Change-Id: I2c8a76f5b04751610ed07819343994b75bea4f4f
2017-03-24sw: remove unnecessary ifdefMichael Stahl
Change-Id: Ifa0a036589fba816eaa3503b17223e80f5b99aa1
2017-03-24sw: fix incorrect static_cast in ~SwAccessibleMapMichael Stahl
Change-Id: I43aef41cee96f69b0bbd540b832780c4002219e3
2017-03-24sw: remove unnecessary ClearMapPointer calls from ~SwAccessibleMapMichael Stahl
These are unnecessary with the fix for tdf#58624, because now SwAccessibleContext dtor will check that the map is still alive. Anything that's still alive at that point should have been disposed by the recursive Dispose call. Change-Id: I39102a6b222b2121987d92077d4b9548281d9973
2017-03-24loplugin:redundantcastStephan Bergmann
Change-Id: Ia7701e84ea87588abb526ad82da659114474bee5
2017-03-24iOS LibreOfficeLight, document actionsjan Iversen
added action menu in Document viewer Change-Id: Ia7c796f7806e363769a5932ce774f33bb4ae8bd2 Reviewed-on: https://gerrit.libreoffice.org/35666 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-03-24Better check for 'defined LIBO_INTERNAL_ONLY'Stephan Bergmann
(to avoid warnings about undefined macros in external code) Change-Id: Ie1007207b22c19a3d9d96f0f94070c32d417595a
2017-03-24fix for regression from 522e9c65: dont make all charts disappearBjoern Michaelsen
Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838 Reviewed-on: https://gerrit.libreoffice.org/35650 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-03-24This code trades in 'char' entities disguised as 'int'Stephan Bergmann
(with EOF represented as 0), so better actually use 'char'. Same as 0a92c29e4747f2289514cdb1030900b7c1cbb6ba "This code trades in 'char' entities disguised as 'int'" in idl. Change-Id: Ie664c1a0cceb7281fae29bdb75d191b998df44cc
2017-03-24iOS LibreOfficeLight filemanagerjan Iversen
Update to filemanager to act as an overlay to documentView updated appIcon to include only required added setName dialog (used for rename/create directory/save as) Removed trailing whitespace Change-Id: I1c8a8cd7ef4eb76687f40e806a14884a1e396bc5 Reviewed-on: https://gerrit.libreoffice.org/35612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
2017-03-24fix indentCaolán McNamara
Change-Id: Ifc1f654e4f63fc7aa62e1b920d1550281a0fa71e
2017-03-24Offst might as well be expanded to OffsetCaolán McNamara
Change-Id: I6ba3131155fbbe5a01e47aca4008d39191254fe0
2017-03-24valgrind: fix memory leakCaolán McNamara
Change-Id: I33ad32f4fa6ca6206e98b38f9170634bce9970de
2017-03-24de-trainwreck this a little to form something approaching readableCaolán McNamara
Change-Id: I9dbe7218d6ca0fa7ffc780094843be232af74e95
2017-03-24fix macosx build failureCaolán McNamara
I only *need* it for the fuzzers, just wanted to keep this in sync with those for simplicity Change-Id: I4fd8aef54c6604c0d44faca9a6515bfd8e85d8bf
2017-03-24tdf#58624 sw: fix ~SwAccessibleContext() use-after-free raceMichael Stahl
As seen in JunitTest_toolkit_unoapi_1: Method doAccessibleAction() finished with state OK LOG> doAccessibleAction(): COMPLETED.OK debug:27272:12: -SwAccessibleParagraph mutexwait 0x3fd9f50 debug:27272:9: SwAccessibleContext::Dispose 0x3872620 11SwRootFrame debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386d600 11SwPageFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386cef0 11SwBodyFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x3878fe0 11SwTextFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleMap::RemoveContext erase 0x3872620 debug:27272:9: ~SwAccessibleMap: frame entry 0x3878fe0 debug:27272:9: ~SwAccessibleMap: mpFrameMap 0x3eb64a0 debug:27272:9: ~SwAccessibleMap: mpShapeMap 0 soffice.bin: sw/source/core/access/accmap.cxx:1726: virtual SwAccessibleMap::~SwAccessibleMap(): Assertion `(!mpFrameMap || mpFrameMap->empty()) && "Frame map should be empty after disposing the root frame"' The problem here is that thread 12 is blocked on SolarMutex in ~SwAccessibleParagraph(), while thread 9 is in ~SwAccessibleMap(). This means that in SwAccessibleContext::DisposeChildren(), the WeakReference to the SwAccessibleParagraph cannot create a uno::Reference because its reference count is 0, so SwAccessibleContext::Dispose() is not called on it and it remains in the SwAccessibleMap::mpFrameMap. This triggers the assert and later on ~SwAccessibleContext() would access the deleted SwAccessibleMap and crash. To fix this, introduce a weak reference from SwAccessibleContext to SwAccessibleMap; use a std::weak_ptr because that is not derived from OWeakObject. The weak_ptr is only used in the dtor ~SwAccessibleContext(); as long as the ref-count of SwAccessibleContext is > 0 it is guaranteed that the SwAccessibleContext::m_pMap is either null or valid as the recursive Dispose() will work fine. It is possible that additional temporary owning references could delay the destruction of SwAccessibleMap, and the order of destruction of Writer documents is very fragile, so rely on the SolarMutex lock to prevent that; the only shared_ptr that owns SwAccessibleMap while SolarMutex is not locked is the one in SwViewShellImp. (An alternative fix would be to represent the 3 lifecycle stages of SwAccessibleContext by adding a C++-pointer to the SwAccessibleMap::mpFrameMap, so that DisposeChildren() can, if the WeakReference is no longer valid due to ref-count 0, use the pointer and clear SwAccessibleContext::m_pMap - this and the corresponding call to SwAccessibleMap::RemoveContext() from ~SwAccessibleContext() under a mutex that is shared_ptr-owned by SwAccessibleMap and all SwAccessibleContext.) Change-Id: If2b44c79189e3b3d276491a5c57d5404bb2be71a
2017-03-24Resolves: tdf#106724 crash when Title property doesn't already existCaolán McNamara
because we just write past the end instead of resizing before hand Change-Id: I4742980a331b14ca39aff8aa6cfc27db154091ff
2017-03-24update fftester documentationCaolán McNamara
Change-Id: I091491a628b267a18d044d770a28a6b9e96f39f4
2017-03-24Just include sal/types.h nowadaysStephan Bergmann
Change-Id: Ic8f6322854ff0ac25c34cd9286545c8aaa27d03b Reviewed-on: https://gerrit.libreoffice.org/35628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-24tdf#106693 vcl PDF export, norefxobj: copy XObject referencesMiklos Vajna
With this the images inside the PDF image show up correctly. Change-Id: I430502fb6ae9de8111dda7e67db33642ff263317 Reviewed-on: https://gerrit.libreoffice.org/35621 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24remove unhandled SID commands in starmathNoel Grandin
checked that none of these are present in any .xcu files. Change-Id: Ife5ac45ca4e71fed9515941c20853b9ab811e057 Reviewed-on: https://gerrit.libreoffice.org/35619 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24tdf#105908: add test for this.Kohei Yoshida
Change-Id: I553c18107d469bd7dce37d673f958126455b4393 Reviewed-on: https://gerrit.libreoffice.org/35608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-24tdf#105908: restore previously deleted range references upon undo.Kohei Yoshida
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>