Age | Commit message (Collapse) | Author |
|
...and in turn add OUString::operator = and OUString::operator +=
overloads that take a std::u16string_view. Without making the ctors explicit,
the operator overloads would have caused ambiguities when called with raw
sal_Unicode pointers/non-const arrays, as those can convert to both OUString and
to std::u16string_view.
But the std::u16string_view operator overloads will generally be useful when
changing OUStringLiteral similarly to 4b9e440c51be3e40326bc90c33ae69885bfb51e4
"Turn OStringLiteral into a consteval'ed, static-refcound rtl_String", at which
point many existing uses of OUStringLiteral will be replaced with uses of
std::u16string_view.
Implementing this change turned up a need for an operator = overload for
OUStringNumber, which has thus been added. No such need turned up for a
corresponding operator += overload, but which can easily be added when the need
arises.
It also revealed that the operator == overloads between an OUString and a raw
sal_Unicode pointer/non-const array were implemented rather inefficiently,
creating a temporary OUString from the raw argument. Those have been improved.
Preceding commits have already taken care of many dubious or simply unnecessary
implicit uses of the now-explicit OUString ctors. This commit makes explicit
the few remaining reasonable uses. (And in some cases needed to change variable
initialization syntax from using parentheses to using curly braces, to avoid the
most vexing parse issue. And needed to explicitly add OUString ctors from
char16 const[2] string literal lvalues in a conditional expression in
writerfilter/source/ooxml/OOXMLFastContextHandler.cxx that are only necessary
because MSVC apparently still insists on doing array-to-pointer decay there.)
All of this only affects LIBO_INTERNAL_ONLY.
Change-Id: I7ce31162e9be1c3ff3c0bd184a34b535ec56be9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102098
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Regression from commit 8fc1b60f62c213a0476f3acc9f89cd5eccbf335d (sw SVG
export: try to reuse original bitmap data for JPG and PNG bitmaps,
2020-02-27), which generalized the code that tries to get the original
bitmap of shapes for performance reasons. Originally this worked with
SdrGrafObj, but now we try every XShape which has a Graphic property.
Add the missing check, so shapes without a graphic property just miss
the fast path, but doesn't fail the entire SVG export.
Change-Id: I6b20083110f3269337b9df6a23bd193cc6f7d13b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102187
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I83722d99fa0d5919a7e878d32311dbb6de1c6714
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102175
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id1b1c07ddcacca8eef8af71890d9392f29b6be6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102172
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I596ef2603560f521386e273b6f0fb2f672db56d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102171
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update translations from branch 'master'
to 14a72851d401d86cf9fd72a5e139ab87eb0f47d1
- update translations for master
and force-fix errors using pocheck
Change-Id: I95203f89a4148dd4f91a2a438c5c9811ac2dbe44
|
|
Surprised it took so long to find an example of an
anchored object on the empty paragraph.
I considered making a more useful function,
but I didn't want to return a pointer,
and my skills and understanding aren't good enough
to intelligently return an empty vector reference,
so I just left it as I first created it.
It seems a bit silly to make a bool function
just for this, but nothing returns anything
that I wanted to use. So I just made a
perfect-fit function for my unique need here.
I would have preferred to create a potentially
re-useable and flexible function...
Change-Id: I8c2527403cd8059223d4bc610b10243656b1db3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102060
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I8f6a3756d48b1727f9ac64c2e162be148e1c61d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102183
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This was disabled by accident at some stage, the original commit
b6f9eeb9b5c0e29ca655185dc299ebd4a2c092d7 (external: bundle pdfium,
2017-02-08) did have Android enabled back then.
Change-Id: Ia875ba6c663d74e6c9061f4ffe814bc124431abe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
...afer 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a
consteval'ed, static-refcound rtl_String"
Change-Id: I8afab29e9b7477c8a6c519b61d1fd6b3c21589e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102174
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I878c1108757b6637e221b39c50ecf21477edb534
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102169
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Although this was probably harmless, as Skia by default
decides this based on NDEBUG, if not explicitly set.
Change-Id: I46f0d336cdb940d2214c67bdb461cb4f8d9140f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102164
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Ia260a1420291f4811aa6fbf3beae57184462db7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4bee1ec99b69b42b7eea540b04511cbafe5fbd0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102106
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1e1edafc7b9daf5748e22846ca5807613f779b2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102167
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The document tries to draw a larger number of tiny bitmaps,
which results in Skia trying to allocate many tiny GPU images,
which slows it down (something quadratic there?) and it may
eventually run out of memory. So force a flush if there are
too many such operations unflushed.
This is somewhat similar to what was done in the past by
ad3580df085b3a3d66eb73cae997ea5ca178ccc1 .
Change-Id: Ib0309ea9c7ac6c80d69ceed2922e885a2aa7f2d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102166
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
If the image is way too oversized, it doesn't matter it's being
scaled down.
Change-Id: I148cd6b95953abb9fcbb5ea8dd19cadaa513e573
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102070
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
16MiB was enough to hold just one 2000x2000 image, which is almost
the usual screen size.
Change-Id: I8fd02101cd2a18ddb89500d555d5c2f051fdb81f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102069
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The original idea was to create a temporary SkImage in order to first
merge the bitmap and its alpha bitmap, otherwise scaling already
while merging them could introduce artefacts because of smoothscaling
the alpha. But SkShader use blends the bitmap and alpha values
before the scaling, so this is actually not necessary.
Change-Id: I4e351611e3c33530dd5326c542b0a191955b5109
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102068
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
If the graphics area is clipped to a smaller size, use that
as the maximum size that would be drawn, not the whole graphics
area.
Change-Id: I8892e62ca83fb4de4d58edffb1783eccfbd39dc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102067
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
This matters in a merged menu bar (e.g. insert chart), where the
Window menu belongs to the container rather than to the embedded
object. (Same as for the File menu, see also commit
94a7a71b070d3911b39d1026ba266768b71ba8a6 - "MenuBarManager:
Actually use xPopupMenuDispatchProvider".)
Change-Id: Ia502674b778554378546f5629ea44bbb17c830ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102158
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: I7244f429194145df99a4b52fce144c6ec45f3b61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102168
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If892a16875ef16015639aacf8359d15c953fb1d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102149
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
from InvalidateStyle.idl, so I don't have to keep jumping around to
figure out what this means
Change-Id: Iee7d5f2a83afba075f15c44a36a5b4a8def04724
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102160
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The wrap setting that OOXML calls "tight" and LibreOffice calls
"contour" (== true) was not supported by the import code, only
the export.
Change-Id: I48739ffaad48e28df05fd87a9b51a14238dc47e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101932
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
After a574bb602031f0d1febb059c7dc9d1c4937271c6 "external/redland: Honour
LIBXML_CFLAGS/LIBS in raptor's configure", ExternalProject_raptor started to
fail on Android with
> configure: error: libxml2 is not available - please get it from http://xmlsoft.org/
due to
> configure:11263: checking for xmlCreatePushParserCtxt
> configure:11263: .../android-ndk/android-ndk-r20b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -target aarch64-linux-android21 -no-canonical-prefixes -ffunction-sections -fdata-sections -Qunused-arguments -o conftest -O -fvisibility=hidden -I.../workdir/UnpackedTarball/libxml2/include conftest.c -L.../workdir/UnpackedTarball/libxml2/.libs -lxml2 >&5
> .../workdir/UnpackedTarball/libxml2/.libs/libxml2.a(xpath.o): In function `xmlXPathFormatNumber':
> xpath.c:(.text.xmlXPathFormatNumber+0x3d4): undefined reference to `log10'
> .../workdir/UnpackedTarball/libxml2/.libs/libxml2.a(xpath.o): In function `xmlXPathStringEvalNumber':
> xpath.c:(.text.xmlXPathStringEvalNumber+0x3e0): undefined reference to `pow'
> xpath.c:(.text.xmlXPathStringEvalNumber+0x69c): undefined reference to `pow'
> .../workdir/UnpackedTarball/libxml2/.libs/libxml2.a(xpath.o): In function `xmlXPathModValues':
> xpath.c:(.text.xmlXPathModValues+0x144): undefined reference to `fmod'
> .../workdir/UnpackedTarball/libxml2/.libs/libxml2.a(xpath.o): In function `xmlXPathCompNumber':
> xpath.c:(.text.xmlXPathCompNumber+0x394): undefined reference to `pow'
> xpath.c:(.text.xmlXPathCompNumber+0x62c): undefined reference to `pow'
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
in workdir/UnpackedTarball/raptor/config.log, and the old way of unconditionally
re-determining LIBXML_LIBS in workdir/UnpackedTarball/raptor/configure via
`$XML_CONFIG --libs` had set it to
> -L/data/sbergman/lo-android-aarch64/core/workdir/UnpackedTarball/libxml2/.libs -lxml2 -lm
which differs from the value hardcoded in configure.ac in the trailing "-lm".
Change-Id: Ifc4a70e014a826a38ad92125b6851d40e15c3c7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102154
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
with arrow keys.
Change-Id: I357c320406d9f044b12b1289aa0f88045001c283
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102002
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Otherwise e.g. Android builds would fail with
> vcl/source/filter/ipdf/pdfread.cxx:231:77: error: no member named 'PDFiumPage' in namespace 'vcl::pdf'
> std::vector<PDFGraphicAnnotation> findAnnotations(std::unique_ptr<vcl::pdf::PDFiumPage>& pPage,
> ~~~~~~~~~~^
etc.
Regression apparently introduced with 6d275917944c274a22620c2c19880eb8e94f2558
"extract PDF import for annotations to a separate function".
Change-Id: I364d8d3f30c7eeaa933bfe6aebaf4cad35c20d2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102153
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
since...
commit 487df0c8f307500029b06c89985a1148ebc784b5
Date: Tue Sep 1 13:55:25 2020 +0200
tdf#123353 XLSX export: fix lost AutoFilter on empty cells
Change-Id: I5ef156cd9fe371b0b04b9308a0aa0887ac57713f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102152
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and insert backwards which is a little faster
Change-Id: Ie72d08bb6e869b2d8fe86ae5526706d051233939
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102151
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iae7a028d2845d8b0bef2aefdce2ae00fa7f5660f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102110
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
|
|
Regression from cd384e2d31f74223948ea70d8aa3c318d3ceeb50
author Caolán McNamara <caolanm@redhat.com> 2020-06-05 16:11:39 +0100
committer Caolán McNamara <caolanm@redhat.com> 2020-06-08 20:21:35 +0200
commit cd384e2d31f74223948ea70d8aa3c318d3ceeb50 (patch)
tree 49ae5191c2bd4b13c3cd547951933fbc37cda0fa /cui/source/options/fontsubs.cxx
parent c3669c8bd62ecf5eaa6b5e95289825bc11b2688a (diff)
rework treeview initial toggle button col to be like expander col
cause this assumption is baked into the vcl one making it hard
to adapt remaining cases
Change-Id: I31854211be5f558b51f345af6a11c471a9bd120d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102148
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
... SwIntrnlSectRefLink and SwTextFrameInfo
See tdf#94879 for motivation.
Change-Id: Iecf5a06b020488fae6f209133bcaed016feeb44f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102142
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I932675efaeb1072602775115fc368bbba7bfd2b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102134
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Since tdf#131120 we don't use the original ComboBox menu, but it's still
listening to additions to the ListStore and slowing things down (tdf#136455)
Change-Id: Ie2383e1a4b28f0787559132d93236df5c641cb06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102135
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I495b90b9661c32ad3ec71c2a2455d1576fb8f918
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102112
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
when you using git for windows (faster) then the git-hooks
not work with "ln", it needs "mklink" from windows
Change-Id: I15981f44293186efd3fbaa5c1a044348034cef28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102032
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I9f5a69d89eaa25a79a672d28de20c869df4f3e75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102111
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Now that we have a single ctor, which always calls
FillMenuManager.
Change-Id: Ib6b04882ddde252a1dc81670576f76b4fc21ea09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102138
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
i.e. restore the fix for i#65734/i#75851, which for some
reason was disabled in 3c471fa5480d58e867e05a1ef474a23aef94b07d.
This can be tested by inserting chart into Writer or Calc, and
looking at the File menu. Given that this menu is merged from
the container app, it makes sense to use its dispatch provider
for everything, not just for a few commands hardcoded in
CommandDispatchContainer::getDispatchForURL of chart2.
Change-Id: I03f233a84249284354ea709d8aa7c950390294e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102137
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Addon menus were created with a different ctor, which called
Init instead of FillMenuManager. But the former is just a
subset of the latter, and I don't see in the latter anything
particularly harmful for addon menus.
There was however the bool _bHandlePopUp parameter, which
controlled whether to create popup menus to be used by popup
menu controllers, but: (a) it doesn't make any sense to me to
allow controllers in some addon menus but not in others, and
(b) the Activate method creates controllers unconditionally,
which means that a controller might still be created, but
then get nullptr for the popup menu, and crash.
There was also m_bIsBookmarkMenu, which was set to true for
addon menus, and used in the Select method to add Referer
argument to the executed command. As a matter of fact, this
argument is useless, as the referer is never evaluated for any
command or macro execution. Only affected case might be when
content URLs used directly as menu commands. But such usage
isn't common, and even then an empty referer is similarly
accepted by SvtSecurityOptions::isUntrustedReferer. However
seeing the message of f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db
("rhbz#887420 Implement "block untrusted referer links" feature")
it appears that it's better to have the explicit referer anyway
(but with a different check, as m_bIsBookmarkMenu is now gone).
(Historically, the referer argument wasn't even introduced for
addon menus, but for the new document and wizards menus, which
used to be managed by the menu manager back then. This can be
seen in commit 40fefd8e0d5937666129278fe2b27c36cb58033c ("support
for images and target frames"). Only later this code path was
reused for addon menus. That's why the member was called
m_bIsBookmarkMenu, as "bookmark menu" was the term used for the
new and wizard menus, and there was also a related BmkMenu class.)
Change-Id: Idd48a0416f8703ef1a5c91e949345537ec9a5ec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102136
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
This is the proper fix for tdf#99527, instead of
the workaround that was applied back then.
Change-Id: Ibbcac747e2b0ef421fd71b79eb9e536dc2f31771
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101891
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Let GalleryThemeEntry initialize GalleryTheme.
Change-Id: Ib81d95faf6561604a30a7d0a3d9dae808c83a398
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101655
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I8a0660922e29d0dfaf8b859d396b88997a46bc92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102108
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I841cbb2bad3af5f6f6212962d7f15436d5e7bead
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102105
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
|
|
Change-Id: I57823bb2a04da46ad1b66d1ba3d69f323406f612
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102107
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1f01f4f57d9e711ead86d9d7abf9ef9c7f630fe2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102104
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I69aa6fc27c095a920c22a84e6e84e78b0230e46b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102102
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ia1edcdb2931db0dd7b9174a697711c6d79ff9a13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102103
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
add "FreeText" and "Line" annotations
Change-Id: I00e4ac3e446dbec4fcd29a103d6cf8014137179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102094
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|