summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-28tdf#127811 tdf#127813 Introduce compatibility key for the data seriesTünde Tóth
order of filled net and normal area charts. The data series of filled net and normal area charts are drawn in reversed order in LibreOffice but not in Microsoft Office. Default value is true to keep current behavior. Change-Id: I07adac814597b756878d74610d028f07327f7214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/83897 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
2020-04-28resolved clashing of two idsPranam Lashkari
Multiple SvxFillAttrBox objects having the same ID 'fillattr' caused the problem in online making it hard to distinguish for different function Change-Id: Ic5a29ea75fb442d7e495761faf4a10d6ab212829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92977 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-27tdf#116883: sw: support for lists level format stringVasily Melenchuk
Multilevel lists are more flexible in case of DOCX. There is supported custom format for any level in DOCX unlike in LO and ODT where we are limited only with prefix and suffix for hardcoded list levels separated by dot. At the same time DOCX can have lists not only "1.2.3.4", but "1/2/3/4" or even "1!2>3)4" and such format can vary on each list level. Here is basic implementation for list format as a core feature for all documents and old way (prefix-suffix + ".") is left as fallback. Practically its usage is currently implemented only in DOCX import/export. Some RTF/OOXML unittests were redesigned: since we are not creating prefix/suffix for these formats conditions should be checked in a different way. Change-Id: I1ec58bcc5874d4fa19aee6a1f42bf1671d853b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92106 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-27tdf#108496: DOCX: list overrides some cleanupsVasily Melenchuk
This is a follow up commit to cf13fe3e fix with some mostly cosmetic changes. General idea of list overrides is not modified. Change-Id: I35937449bd563eacceb3753e62b9ff7245f12b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92739 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-27Add the few functions without parameters as entries with BoundsEike Rathke
It doesn't really matter, but the assumption is that functions without entries take at least one and only scalar value arguments. Change-Id: I6a4cb882c86c50a0c63ddd5fc6a3b885fab32ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92990 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-27loplugin:unusedfieldsNoel Grandin
Change-Id: I47034909e6258fc4d65d39f484d71290f793107d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27elementary: fix for tdf#125779: object handlers are too faintRizal Muttaqin
Change-Id: If1741e88178205aee9f46b0fa96ca29b61ac4d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92970 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-27Fix typoAndrea Gelmini
Change-Id: I90152d94067c6ba0daa473fa069dddbc0988e306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92644 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-27solenv: handle copying empty directories in the installerMiklos Vajna
'make test-install -o build' fails without this when --enable-macosx-sandbox is used. It is harmless in other cases. Change-Id: Ic62a2c7729402cf45172ccc12fa83b46bee31e78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92985 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-27tdf#115896 doc import: recognize new version 2013Justin Luth
Now, I don't know for sure that E000 is from Office 2013, since I don't know where the document came from and I don't have 2013 readily available. However, I tried round-tripping the unit test in Office 2016 and it gave the version number 0x2000. Change-Id: Ib02f9440de34225affcb2ccbfd96ed89c717085e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92764 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-04-27loplugin:makeshared in dbaccessNoel Grandin
Change-Id: Idf5f6179771edaf7af85d95e10b092ce0e3344f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27loplugin:makeshared in vclNoel Grandin
Change-Id: I990fafa8b01e94aef58d6cad30bc13de539ea496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27Don't insert embedded object twiceMike Kaganski
During debugging of failure https://gerrit.libreoffice.org/c/core/+/92980, I saw that one of objects throws calling OCommonEmbeddedObject::getEntryName in EmbeddedObjectContainer::StoreAsChildren, because its m_bWaitSaveCompleted is true. The reason turns out that the object was already inserted, and thus its OCommonEmbeddedObject::storeAsEntry was called; but not yet its OCommonEmbeddedObject::saveCompleted. The double insertion happened in SwXFrame::attachToRange, where the object was first passed to InsertEmbeddedObject directly, and then was passed to InsertEmbObject, which called the former one again in this stack: comphelper.dll!comphelper::EmbeddedObjectContainer::InsertEmbeddedObject(const com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> & xObj, rtl::OUString & rName) Line 514 C++ swlo.dll!SwOLEObj::SetNode(SwOLENode * pNode) Line 884 C++ swlo.dll!SwOLENode::SwOLENode(const SwNodeIndex & rWhere, const svt::EmbeddedObjectRef & xObj, SwGrfFormatColl * pGrfColl, const SwAttrSet * pAutoAttr) Line 220 C++ swlo.dll!SwNodes::MakeOLENode(const SwNodeIndex & rWhere, const svt::EmbeddedObjectRef & xObj, SwGrfFormatColl * pGrfColl) Line 382 C++ swlo.dll!sw::DocumentContentOperationsManager::InsertEmbObject(const SwPaM & rRg, const svt::EmbeddedObjectRef & xObj, SfxItemSet * pFlyAttrSet) Line 2914 C++ swlo.dll!SwXFrame::attachToRange(const com::sun::star::uno::Reference<com::sun::star::text::XTextRange> & xTextRange, const SwPaM * pCopySource) Line 3028 C++ ... Remove the redundant call, and put a comment on that. Change-Id: I680786a601ec454483e86c47ae07666d82c24146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92982 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a713d9a4e339fc00c48ad22f1503b53055f208ca - Revert "Fix grammar and more in text" This reverts commit bb5376ab2c0fc80e8f49197e4077ccce0639e186. Reason for revert: improve patch after comments in bug Change-Id: I636f91e5bbf6e709eb7606758f0cb13182368d5d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92785 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-27Fix testFdo58949Mike Kaganski
For some reason, on my Windows box (but apparently not on CI) I saw testFdo58949 consistently failing during `make CppunitTest_sw_odfexport`, but not in `make CppunitTest_sw_odfexport CPPUNIT_TEST_NAME=testFdo58949`. Turns out that depends on test order (if the static counter for objects was inreased by other tests or not). This makes the test not rely on a specific object name, but rather on total matching names count. Additionally allow testResolvedComment to run on Windows, since it seems this reason why it used to break testFdo58949. Change-Id: Ibf0b7f1848622f800a05035a96028a8ed0986f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92980 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to bb5376ab2c0fc80e8f49197e4077ccce0639e186 - Fix grammar and more in text Change-Id: I6a72906dca5982ab8f206cdc75273754fc0f420c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92783 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-27drop unused usingCaolán McNamara
Change-Id: I89c6892b51d651a25aff9c36c02c93374138635f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-27tdf#132138 Update DNA impress templateandreas kainz
Change-Id: I876a59b81bc18fea2477c3dc46020ea2dedae85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92975 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 94a9abec550eeb2363bd2fd5cb0f451b0aeeb59f - Fix attributes Change-Id: I0153b7a2457130ae6cd8a313d86424662d0576e5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92780 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-27tdf#42949 Fix IWYU warnings in dbaccess/source/ui/[m-u]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bf360b331589692141f6fca52eee5b8e11ef7bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-27tdf#132355 fix X axis position of stock chartsTünde Tóth
Set the ShiftedCategoryPosition for true in case of stock chart. Regression from commit: 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: I7ced1b03158908e838f7bb44c89dea23c5b347b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92759 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-04-27DOCX import: handle <wp:positionH relativeFrom="insideMargin">Miklos Vajna
This is the same as page, but it is from-left on odd pages and from-right on even pages, i.e. our "mirror on even pages" mode. Change-Id: I018e0ac165a3d802f64cfc314d5c5f58da3cb580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92965 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-27Missing includes on Windows with --disable-pchMike Kaganski
... since b512ce255f46d90e682634e4dd17e146af7f9080. Yes, MSVC also produces an error if the completeness requirements are not met. Change-Id: I0ad573ef1d14a383eed3a8f83aa932657c22ae20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92963 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27sw: prefix members of SwSdrUndo, SwUndoDrawDelete, SwUndoDrawGroup and ...Miklos Vajna
... SwUndoDrawUnGroup See tdf#94879 for motivation. Change-Id: Ice419c3614ebba1b5aa9bf81de6bfcc2af8edd73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92961 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-27Do not time out close_dialog_through_buttonStephan Bergmann
If something goes wrong, better keep the testing Python and the tested soffice process in a state in which the actual problem can (hopefully) be debugged better. I happened to run into a hung UITest_chart on Linux, where soffice.bin was still at > Thread 1 (Thread 0x7f2e2b280fc0 (LWP 1906251)): > #0 futex_abstimed_wait_cancelable (private=0, abstime=0x7f2e27b59a80, clockid=<optimized out>, expected=0, futex_word=0x60e000024e8c) at /usr/src/debug/glibc-2.31-17-gab029a2801/sysdeps/nptl/futex-internal.h:320 > #1 __pthread_cond_wait_common (abstime=0x7f2e27b59a80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:520 > #2 __pthread_cond_clockwait (abstime=0x7f2e27b59a80, clockid=<optimized out>, mutex=0x60e000024e38, cond=0x60e000024e60) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:677 > #3 __pthread_cond_clockwait (cond=0x60e000024e60, mutex=0x60e000024e38, clockid=<optimized out>, abstime=0x7f2e27b59a80) at /usr/src/debug/glibc-2.31-17-gab029a2801/nptl/pthread_cond_wait.c:665 > #4 0x00007f2e5fead808 in std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:210 > #5 0x00007f2e5fead295 in std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > >(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&) (this=0x60e000024e60, __lock=..., __atime=...) at include/c++/10.0.1/condition_variable:120 > #6 0x00007f2e5fea8f05 in std::condition_variable::wait_until<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __atime=..., __p=...) at include/c++/10.0.1/condition_variable:159 > #7 0x00007f2e5fea6e60 in std::condition_variable::wait_for<long, std::ratio<1l, 1000l>, SvpSalInstance::DoYield(bool, bool)::$_2>(std::unique_lock<std::mutex>&, std::chrono::duration<long, std::ratio<1l, 1000l> > const&, SvpSalInstance::DoYield(bool, bool)::$_2) (this=0x60e000024e60, __lock=..., __rtime=..., __p=...) at include/c++/10.0.1/condition_variable:186 > #8 0x00007f2e5fea5a8e in SvpSalInstance::DoYield(bool, bool) (this=0x611000001bc0, bWait=true, bHandleAllCurrentEvents=false) at vcl/headless/svpinst.cxx:497 > #9 0x00007f2e5f3a232d in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:454 > #10 0x00007f2e5f3a18e8 in Application::Yield() () at vcl/source/app/svapp.cxx:518 > #11 0x00007f2e5bf32c2d in Dialog::Execute() (this=0x61a000072080) at vcl/source/window/dialog.cxx:1032 > #12 0x00007f2e5efdcd62 in SalInstanceDialog::run() (this=0x619000091080) at vcl/source/app/salvtables.cxx:1480 > #13 0x00007f2dc37421fd in weld::DialogController::run() (this=0x61200077c5c0) at include/vcl/weld.hxx:2227 > #14 0x00007f2dc39672f2 in chart::CreationWizardUnoDlg::execute() (this=0x610000168d40) at chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:189 > #15 0x00007f2df91f2507 in FuInsertChart::FuInsertChart(ScTabViewShell&, vcl::Window*, ScDrawView*, SdrModel*, SfxRequest&) (this=0x7f2e27f1a300, rViewSh=..., pWin=0x61a0001e8a80, pViewP=0x61d0001f6880, pDoc=0x617000066a00, rReq=...) at sc/source/ui/drawfunc/fuins2.cxx:673 > #16 0x00007f2dfaf9a379 in ScTabViewShell::ExecDrawIns(SfxRequest&) (this=0x61d0001eaa80, rReq=...) at sc/source/ui/view/tabvwshb.cxx:336 > #17 0x00007f2dfaedf365 in SfxStubScTabViewShellExecDrawIns(SfxShell*, SfxRequest&) (pShell=0x61d0001eaa80, rReq=...) at workdir/SdiTarget/sc/sdi/scslots.hxx:1447 > #18 0x00007f2e8031ded6 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) (this=0x61d0001eaa80, pFunc=0x7f2dfaedf240 <SfxStubScTabViewShellExecDrawIns(SfxShell*, SfxRequest&)>, rReq=...) at include/sfx2/shell.hxx:197 > #19 0x00007f2e802a77ff in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x6020002f3dd0, rShell=..., rSlot=..., rReq=..., bRecord=true) at sfx2/source/control/dispatch.cxx:251 > #20 0x00007f2e802aacb6 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) (this=0x6020002f3dd0, pReq=std::unique_ptr<class SfxRequest> = {...}) at sfx2/source/control/dispatch.cxx:988 [...] but the Python process was already at > Traceback (most recent call first): > <built-in method waitpid of module object at remote 0x60800002d1c0> > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1611, in _try_wait > (pid, sts) = os.waitpid(self.pid, wait_flags) > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1653, in _wait > (pid, sts) = self._try_wait(0) > File "instdir/program/python-core-3.7.7/lib/subprocess.py", line 1019, in wait > return self._wait(timeout=timeout) > File "uitest/libreoffice/connection.py", line 133, in tearDown > ret = self.soffice.wait() > File "uitest/libreoffice/connection.py", line 178, in tearDown > self.connection.tearDown() > File "uitest/uitest/framework.py", line 46, in tearDown > self.connection.tearDown() > File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 631, in run > self.tearDown() > File "instdir/program/python-core-3.7.7/lib/unittest/case.py", line 676, in __call__ > return self.run(*args, **kwds) > File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 122, in run > test(result) > File "instdir/program/python-core-3.7.7/lib/unittest/suite.py", line 84, in __call__ > return self.run(*args, **kwds) > File "instdir/program/python-core-3.7.7/lib/unittest/runner.py", line 176, in run > test(result) > File "uitest/test_main.py", line 128, in <module> > result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite) and the relevant > ====================================================================== > ERROR: test_tdf99069_chart_cancel_data_ranges_dialog (tdf99069.tdf99069) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sc/qa/uitest/chart/tdf99069.py", line 32, in test_tdf99069_chart_cancel_data_ranges_dialog > self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart") > File "uitest/uitest/test.py", line 83, in execute_dialog_through_command > raise DialogNotExecutedException(command) > uitest.test.DialogNotExecutedException: Dialog not executed for: .uno:InsertObjectChart had not yet been written to workdir/UITest/chart/done.log (Python's unittest appears to unhelpfully hold back such vital information until the very end of the full test run). That means DialogNotClosedException is unused now and can thus be removed. Change-Id: I556ae52f05b1362f4e78f2de362a7b4f9b8a0cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92959 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27Graphic: cleanup private, public declarations, remove friendTomaž Vajngerl
Friend GraphicObject doesn't seem to be needed anymore. Change-Id: I629ddaabf0c1802e986af42b457cd6322d2fd04d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92949 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27STYLESPREVIEW is never definedCaolán McNamara
added by... commit dda842bec338efb06457551136678340d0718807 Date: Thu Aug 29 17:22:48 2013 +0100 Change-Id: I8fc15a0d7c18df69e772366ac81980f6acef52a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-27aPoint is never consumed so calculations to derive it are mootCaolán McNamara
Change-Id: I4b00fc1e3bb0f346e688d50d1ea4d1ad4dd56915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-27tdf#42982: Improve UNO API error reportingIan Barkley-Yeung
Improve error repoting in BreakIteratorImpl Change-Id: I0be64a758ed81b7a720c8b26af14de6b51cc5dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92955 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27Extract getting default locale for filters into separate unotools functionMike Kaganski
Change-Id: Ic97b1a4507d5629963f360147ecc20eb10f5d391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27vcl: add tests for GraphicNativeMetadataTomaž Vajngerl
Test the rotation in JPEG metadata is what we expect. Change-Id: I5ee2d646a5257d5695c51f37fb6fe795dcb9af50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92948 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: rename ImplCreateSwapInfo and simplifyTomaž Vajngerl
ImplCreateSwapInfo changed to createSwapInfo. Flatten the code body Change-Id: I5865373d0b7f3cc717a9600bcf6fd198e8320e35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92947 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: move content of swapOutToStream into swapOutTomaž Vajngerl
Change-Id: Iec0227b1e1ceebda961e158315ea5e56c2d33204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92946 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: move filename handling from swapout to ImpSwapFileTomaž Vajngerl
Change-Id: I30930f61385e31e7754d6653ff2eecfea61ce4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92945 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: clean-up and simplify swapOut()Tomaž Vajngerl
Change-Id: I3e578c3172fcea341a218798843cd750971a5af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92944 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27Don't convert OUString to char*Mike Kaganski
Change-Id: I3bfcc6fedb782b12be1fb1d42981756287f29f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92956 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 14064200e02a2280c76e4de3d26d55995332eeb0 - Call it what it is Change-Id: I8ff69aee8063f8997868829291500244e2c1a6a1
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to e8f6152ad369f7cb8152b65ccb1dd7432b77d1f8 - This is an IANA media type; it shouldn’t be translatable Change-Id: I714fd9685c1bf35a2c8b3d05e2a4df07ca8f8cbb
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 731ea5215c543caa876b2087c4303970b011d824 - Some more copyediting… Change-Id: I43d4535b5c0ea659fd19177775ad00db71a2d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/91001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-26tdf#132424 don't generate font previews in advance for loolCaolán McNamara
Change-Id: I393db7b019fe16b2b7361bd20ec99dc5671ba1ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26move PanelLayout to sfx2Caolán McNamara
Change-Id: If29ccb67835adba3ff6cf2eb53f348bbe71d6463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26vcl: When exporing PDF, write the correct page of embedded PDFTomaž Vajngerl
We can display PDF as an graphic in the document, where the PDF is treated as a vector graphic and rendered with Pdfium. When in that case we export the document as PDF, we can insert the original PDF page as an reference XObject. This workes fine, however the PDF as an graphic also contains the page number, which page should be rendered. This was not taken into account in the PDF export - it was hardcored to first page. This extends the support so it reads the page index from the graphic, and sets the correct PDF page. Change-Id: I15188ee495f9b3fcc3aa7df6f4bad4fa09903c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92924 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26ImpGraphic: encapsulate members of ImpSwapFileTomaž Vajngerl
Change-Id: I882d30f2f27149c865160b3fa68fa974701cea71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to dacce1ab09a52f8eecee9a0651069934eb91054b - Highlight dialog objects in text Change-Id: I9a0a65988a79602bf1e43006f2266bb8ab1471ab Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92778 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-26Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 45df710ed2b840dd15c34f9a24767a50a7454861 - Fix typo Change-Id: I5b1e5f3abbd6543c0c6fc2b2051c5f9922b379e8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-26Test swapping of GraphicTomaž Vajngerl
Change-Id: I895002aa31380d2b5bc2593e66080f3fc94034e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26fix make screenshot breakageCaolán McNamara
Change-Id: Ieb2a4ee7475de2f3f0b6de6c1f3a5c305805131f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26Fix typoAndrea Gelmini
Change-Id: I12743733a35d00b5d99495b584bdb85de0175196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92928 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-04-26Fix typo in codeAndrea Gelmini
Change-Id: I79939bbaea5730fa0c3d714103e0b1976edd2e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-21 04:08:30 +0000