Age | Commit message (Collapse) | Author |
|
Change-Id: Ie8ffc928315b742d5b445d5fdda62cb9c2aabc0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122089
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
The passwords for editing in XLSX documents
created with Excel weren't asked and verified.
Note: LibreOffice supports only a subset of the hashing
algorithms specified in MS-OE376, according to
DocPasswordHelper::GetOoxHashAsVector() and
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/f70a4140-340b-4e94-a604-dff25b9846b1.
Also the documents encrypted with unsupported algorithms
got edit protection now, but it's not possible to add
permission to edit them (copy of these documents are still
editable).
Change-Id: Iabc90f6bba4ed071dd2c60e9dea905481816964b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121497
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
which will solve the problem of setting icons and keeping the drop
down for GtkMenuButtons used in toolbars
Change-Id: I9e0632c8756e7085868541d11709aa598f738bf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122192
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4c1be40e40d2f1e2bcbf26cffda7a6dd52e4f731
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122191
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I892aae979f8fb9b5a7c13a790905d7e7e3f2c087
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122190
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3eeb7dea4ff36b8c969aec210161c1729ab9b372
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122189
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit 67d83e40e2c4f3862c50e6abeabfc24a75119fc8.
because it causes less accuracy sometimes, eg. see
https://gerrit.libreoffice.org/c/core/+/122186
Change-Id: I06eb4921359a8fe6689c6cfd3e2967e25b646fa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
for the icon in GtkMenuButton in the calc, insert, header and footer in
gtk 4.6 where the MenuButton begins to support a child widget again but
the icon while now shown in squished
Change-Id: Ibc274d88b1185eee0ee61973b40b5cde2d08f554
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122187
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The new test from d5e55d204b71710eb5eb5d2c683dd6698626df3c "tdf#144319:
sw_odfexport: Add unittest" started to cause UBSan failure during
CppunitTest_sw_odfexport (<https://ci.libreoffice.org/job/lo_ubsan/2136/>),
> /workdir/UnpackedTarball/boost/boost/rational.hpp:605:22: runtime error: signed integer overflow: 1073741824 * 2 cannot be represented in type 'int'
> #0 0x2b450983594f in boost::rational<int>::operator/=(boost::rational<int> const&) /workdir/UnpackedTarball/boost/boost/rational.hpp:605:22
> #1 0x2b450982e216 in Fraction::operator/=(Fraction const&) /tools/source/generic/fract.cxx:224:7
> #2 0x2b45098312d3 in operator/(Fraction const&, Fraction const&) /tools/source/generic/fract.cxx:320:10
> #3 0x2b46066963d5 in (anonymous namespace)::lcl_CountBlanks(MathMLAttributeLengthValue const&, int*, int*) /starmath/source/mathml/mathmlimport.cxx:1497:30
> #4 0x2b46066943eb in (anonymous namespace)::SmXMLSpaceContext_Impl::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /starmath/source/mathml/mathmlimport.cxx:1526:25
[...]
Formula-14/content.xml in sw/qa/extras/odfexport/data/tdf144319.odt contains
width="0.444em", which resulted in the inaccurate Fraction 476741369/1073741824
since 67d83e40e2c4f3862c50e6abeabfc24a75119fc8 "speedup rational_FromDouble"
(which computes dVal=4.76741e+08 and nDen=1073741824; where before that speedup
it computed dVal=4.44e+08 and nDen=1000000000, which would have resulted in the
accurate Fraction 111/250). The excessively large denominator (1073741824 =
std::numeric_limits<sal_Int32>::max()/2 + 1) then caused overflow later on, as
shown above.
Change-Id: I221549528e4fa155e10697d218ec76bf678e8b2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122186
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Sync textboxes with group shapes, adding textboxes to
group shapes, copying textboxes with group shapes,
grouping/ungrouping group shapes with textboxes, removing
textboxes from group shapes.
This patch fixes a memory leak (tdf#144271) introduced
by commit 504d78acb866495fd954fcd6db22ea68f174a5ab
"tdf#143574 sw: textboxes in group shapes - part 1".
Note: AS_CHAR anchoring is far not the best for group
shapes and import/export is still missing.
Change-Id: I7dc3b8d36c4a04f792ae4742fe4a45af9227a17e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121449
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ie56e70faf40ec63ba5b17a8a9ea5f2947bbe53e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122174
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
use alloca in Transliteration_body::transliterateImpl to avoid
over-allocating stack-space (which tends to unnecessarily flush some
cache)
Change-Id: I1843fdcb830a3e948a8bbd0a9c7eb143b21a804c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 0730e0e4e05095fba949378e2cc489f31784c7e4
- tdf#125636 (part) GPG siging works only for ODF
https://bugs.documentfoundation.org/show_bug.cgi?id=125636#c16
Change-Id: If8826fd96288ac85197a2b937b5e4fdcda528d11
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122150
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I935b67f2159f7a35e28ea2b7b7eb707f0a1548de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121507
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
* Update helpcontent2 from branch 'master'
to c8c6952d809ccc08b89b8d5ac5e603e5ec00ec20
- Minor fixes in help files (sbasic)
Change-Id: Ifb4a91bfeb1ca8f7e67e9affa30b1e29028b4731
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122071
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I25aa71d214eec3a131a7b11dfe292764061a127c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122182
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
remove empty sequence creation in CharacterClassificationImpl::toUpper,
rather pass a pointer, so it can be nullptr.
Which results in a fair degree of cascading change.
Change-Id: Ie56d49dc71480195c1807764b0d5124f0019f30b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122183
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 446fbc68aaf1ddc03e3b8c176d943c5f5ca09ade
- tdf#144332 fix bookmark typo + refactors
Change-Id: I990a9edff16d1c7e1f828f291a123c3aa12f69cf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122188
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
since 4.4
Change-Id: I6d7d0077617077606a7ef48f22183fcd3ca69c88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122181
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This is sort of the other side of the 417f881d20cafe88a02b6489
optimizations. C++ streams are relatively slow.
Change-Id: I295cc662ecab68eb23a6cb3a85606a4c95edeb07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122159
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
This function gets called on modifying documents, and it shows up
noticeably e.g. when profiling editing in Online.
The code repeatedly restarts the whole process on most changes,
but in practice this seems to only lead to repeated checks with
the same outcome. So finish the whole compression and try again
only at the end, if deemed needed. And even there I'm not sure
if it's actually ever needed, since I couldn't trigger such a case
in practice.
Change-Id: I15b0a83c6865bad21fe60a7e9ca0b87ceea5b489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122156
Tested-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I8867ab619acf0dcb7ba056f2b8754bd1778f1ccb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122175
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 1a62af2400327a33a9e51b7d4697364ba14dfa9e
- tdf#132643 Translate German section IDs
Change-Id: Ic4c682838a4e50c7d714850a57e403c60a7093e3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121949
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 2f54ef24da73bafb8da3ab5a05592c8b0e31edd4
- tdf#132643 Translate German section IDs
Change-Id: I3d3b9bae635293c122d563c8da3d1d93d39a124a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121955
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
When handling a SELECTION_CHANGED_REMOVE event,
AccDescendantManagerEventListener previously emitted a corresponding
EVENT_OBJECT_SELECTIONREMOVE MSAA event with the removed child's ID
as a parameter, then deleted that child's accessibility object.
This resulted in the accessibility object no longer being available
if accessibility tools queried for the object just received in
the EVENT_OBJECT_SELECTIONREMOVE event.
As a consequence, no 'event_selectionRemove' would be triggered
for any table cell object on NVDA side, so an updated selection
would not be announced for that case.
To keep child objects available for such cases, don't delete the
corresponding object in the handler for the SELECTION_CHANGED_REMOVE
handler, but remember it for deletion and only do the actual deletion
once a subsequent different event is handled.
With this in place, the announcement for multiple selected cells in
Calc generally works with the NVDA screen reader and a pending
NVDA pull request [1] by Leonard de Ruijter in place
(s.a. discussion in NVDA issue [2] for more background
and further information).
(There are still cases where events in response
to selection changes are missing, as described e.g. in
tdf#118508 and tdf#118748, but those are not winaccessibility-specific
and it's the same when using the gtk3 VCL plugin with the Orca screen
reader on Linux.)
[1] https://github.com/nvaccess/nvda/pull/12849
[2] https://github.com/nvaccess/nvda/issues/9310
Change-Id: I7a46060c501ba9b8288e7c127121a535c60ce2bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122169
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Towards showing details of multi-portions.
Change-Id: If086df39127483820c245fe58f2de0ddf2c98694
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122160
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ib3c6834150e7bc2538af413840b8b45b053af603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122161
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I8ad589dd8d0a64f75179d3330c80c9c43a21ff32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I88831f290e1923db6fb5a733746bfa3bc7fbc7e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122148
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6070a392319bdc4e04db3a36a6876c194c8a6495
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122147
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3ec4ccb58dc3823eee8b6ab8bda31b128ee24569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122146
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibc703b4c2adc6c6579cc4be50d274504ba957f45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122138
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
instead of including the header, as suggested by
Mike Kaganski in the Gerrit change for
commit 6bf771f0a5ba7be9955f05b307c190fb157adb47
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Sep 9 11:36:57 2021 +0100
wina11y: Use XAccessible* instead of void*
Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(The header had actually been included previously, so
the above commit had added it to the same header a second time...)
Change-Id: Id6a6c5e2426bf07e41f29e1473ec1694970272c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
I suspect this happens automatically > 4.2.1
Change-Id: I1b752ee5cec00005fe0f552548f38eab40249087
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122144
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and add truncate-multiline for consistency
Change-Id: I5a6fc0f0ac97a0f96739f2383b6d3eb474e776fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122145
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
We rely on IEEE floating-point arithmetic anyway, and then even both
arguments equal to 0 do not result in an error.
Even if it was different, it would be better to check id both nDX and
nDY are 0, and return 0 early.
It was so ever since "MWS_SRX644: migrate branch mws_srx644 -> HEAD"
commit fd2cf3dc7cd9c73070fa4d70c8ca99c9fc1ce135.
Change-Id: I5b8e2a359374dd1500b149d74eba4c0b0e5cd8d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122115
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
...after 45c4caff685b15a0f1b87ef05436a7e6aca96851 "tdf#144483 sw mail merge:
save ranges in a single document", causing CppunitTest_sw_dialogs_test to fail
with
> warn:vcl.gtk:2759211:2759211:vcl/unx/gtk3/gtkinst.cxx:21611: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: ~/lo/core/instdir/share/config/soffice.cfg/modules/swriter/ui/mmresultsavedialog.ui:165:49 Invalid property: GtkCheckButton.group
Change-Id: Ib846f3cb1883de50c28c13441aaf880ae1a480fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122153
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The built-in Writer styles (e.g. Caption) are written to each & every
document to help compatibility: this way if the built-in style changes,
existing documents are not changing.
While this is a good default, sometimes document conversion workflows
want to ensure that no new styles are added to the document during
conversion. This new settings allows to opt in for this behavior in case
not polluting the doc model is more important than the negative effects
of changing built-in styles.
Change-Id: I43130a215ee10ee6952724dbef2caab7174ff77f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122154
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
The guarantee is that either x or y argument is non-0.
It was this way ever since "initial import" commit
8ab086b6cc054501bfbf7ef6fa509c393691e860.
Change-Id: I2f5ccbbc9a4f00aafef151ef3dd008eddeef0e78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122114
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 323c851c00559631e9e2ee1098d9aed89ca1d2ff
- tdf#133851 connect help page to certificate path dialog
Change-Id: I5a96785f32b81c6a8dd347b5665e1f5d0c7b84b2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122152
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to d599028d4f126c8a2badc3787e3fdf8277219c96
- Improve another frankly inaccurate statement…
... and fix a couple of typos done in core commit 5e86949c479af5ef443f77b978fcb2b9021de848
Change-Id: Ie7ed9da3a3858434ae9ff086d61587c8ffdcd02b
|
|
...presumably since 0c3e47cc2f0570a7cd8ff4889763991a86b29f26 "tdf#144305 sw: fix
rendering of ruby portions with non-default ruby alignment",
> DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so
> ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI13SwLinePortion"
and
> DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so
> ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI14SwMultiPortion"
Change-Id: Iaebffc3c9c0245d6092ef1dfc58213fd2d38d303
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122143
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I7794376c9475a32276d23135365c99a3f6fb7d84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122142
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Thanks Mihail Balabanov, Olivier Hallot and Tuomas Hietala for your keen eyes.
Change-Id: Ibceeae6d82e39079c02140ac99729be1a1ab0407
|
|
when its created, as noted in...
commit e1a5bcb20e15400320f926165b6d798fa36c564e
Author: Caolán McNamara <caolanm@redhat.com>
Date: Tue Sep 14 20:30:58 2021 +0100
tdf#143831 fix black background appearing on spellchecking wavy lines
...
OutputDevice::SetAntialiasing only mirrors its arg to the secondary
mpAlphaVDev if it exists, and it doesn't exist until the size is set so
move that call down a bit (this is probably another preexisting bug
maybe worth following up on to set that when mpAlphaVDev is created)
Change-Id: I8ef27aae4dcabe529327224bfc6cd7b4bb2a5af5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122141
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
m_pSoftMaskStream is dead since
commit 581e7d7057afa87036d84e42c0e0a8a7368e20c7
Author: Joseph Powers <jpowers27@cox.net>
Date: Thu Sep 1 20:51:15 2011 -0700
unusedcode.easy: PDFWriter cleanup
Change-Id: If397981fb09a7b74ba2294513c13186cc51ad5fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122139
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9648097ca9f77494ec4ddb2662dbc0372b998cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122140
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia7617a0fd4413cbaafaae8fbfee2b2ea819fde8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122136
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to ebe05a0be7226d4e35ed1cf96e60aaa2703234eb
- extra bookmark in help
Change-Id: I0f78b497a2f8921b75a73570e2799948997b48a3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122113
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I9b35d6333afa6b305bf73fc55a7e60c8365674e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122134
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|