Age | Commit message (Collapse) | Author |
|
Change-Id: I57e463bf110fd3818ec586bbab1db75ff1101ff6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139972
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Probably this test could be improved by checking the
position of the pathes. For now, this is better than nothing
Change-Id: I5063a9005a55be9d556eb147ba6a11fb2a1115a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140013
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... so the result can be used with INDIRECT().
Change-Id: I76e4d7739e22c53a3cfa3e004a9b24dc3dfcd233
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140021
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Ifdf59f4957428efdc56009947f8c87f6b6351603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139273
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I4dea32ad24e9a6c24f69c75fea75dbd63c14c91b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139920
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
A leftover from commit f6e0527033be682dbf6b60bd9b060fdd853ffe33
Date Mon Mar 21 12:55:40 2011 +0100
Remove most of dead code inlibs-core (basic)
which dropped the related commented out code for "not implemented"
stub, being there since c25ec0608a167bcf1d891043f02273761c351701
"initial import".
Change-Id: Ic09a0c63921f1c5daa277fe7bb6dfc194895b673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139978
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
...as referenced e.g. at
<https://docs.microsoft.com/en-us/previous-versions/visualstudio/foxpro/aa975345(v=vs.71)>
"Code Pages Supported by Visual FoxPro". That source lists those two encodings
with "code page" values 895 and 620, resp. (which might be what we call "Windows
code pages" in include/rtl/tencinfo.h) and "code page identifier" values 0x68
and 0x69, reps. (which might be what we call "Windows charsets" in
include/rtl/tencinfo.h. But I deliberately left these two new
RTL_TEXTENCODING_* values without any mappings to such Windows codepages etc.,
as I didn't find any authoritative sources. What I used is the information
available at <https://en.wikipedia.org/wiki/Kamenick%C3%BD_encoding> and
<https://en.wikipedia.org/wiki/Mazovia_encoding>.
(And while at it, I also updated the instructions what to do "Whenever some
encoding is added here" in include/rtl/textenc.h.)
This commit is building on some prior, abandoned work by Julien Nabet at
<https://gerrit.libreoffice.org/c/core/+/139819> "tdf#150877: DBF Mazovia
encoding (0x69)".
Change-Id: Iae8af4ebab8915411499ae7ef951339b335aa857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140014
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
this is the inline starmath editing where you can edit the formula
directly in the view window instead of the command window. Currently
requires experimental to be enabled.
reproduce by clicking in initially empty formula and enter a character.
In practice the deleted pos.pSelectedNode is not actually used-after-free
in SmCursor::FindPositionInLineList because it is not found by the
std::find of pLineList.
Change-Id: I57476a8eb073914099c5026dd33dc75b20288d52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140003
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
==1533286== Conditional jump or move depends on uninitialised value(s)
==1533286== at 0x12DEC3C9: param_double_validate (gparamspecs.c:592)
==1533286== by 0x12DEF924: g_param_value_validate (gparam.c:700)
==1533286== by 0x12DEFA9A: object_set_property (gobject.c:1594)
==1533286== by 0x12DF1F96: g_object_set_valist (gobject.c:2538)
==1533286== by 0x12DF2253: g_object_set (gobject.c:2705)
==1533286== by 0x241E8C44: gtk_adjustment_configure (gtkadjustment.c:833)
==1533286== by 0x23B6310A: (anonymous namespace)::GtkInstanceScrolledWindow::vadjustment_configure(int, int, int, int, int, int) (gtkinst.cxx:8207)
==1533286== by 0x23B63D3D: virtual thunk to (anonymous namespace)::GtkInstanceScrolledWindow::vadjustment_configure(int, int, int, int, int, int) (gtkinst.cxx:0)
==1533286== by 0x36424112: SmGraphicWindow::Resize() (view.cxx:227)
Change-Id: Ib81e26b1042e7a5eebd0a2b561f57f7b4eb25dd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I090e10604562665cf22aa98758e81dd398f4f9c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139997
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
presumably this must hold
Change-Id: I2c218c6a63d5213f5abc1b671fa9f035bc69ed7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139996
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8e2cb9c71793a05db4f08662ee497a5f95759d67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139995
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibaf4bb0a9c9a8f613fd63ccd53a0e29d840fb21a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137904
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Making `RuntimeException` instances's messages in 'SyncDbusSessionHelper.hxx' more clear.
Change-Id: I40105102f8785536d29e103a44d20d11c68943bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136629
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
...avoiding to have code in configmgr that knows about the details of the data
stored in the configuration. (See the comments starting at
<https://gerrit.libreoffice.org/c/core/+/139690/9#message-44703a2529c07bf1b0202ed3a232aa661784b159>
"Migrating product name related color schemes between different versions" for
details.)
This reverts the dubious changes of 583ea856f2aa227bb04581c5bcdc3a402f5a184f
"Migrating product name related color schemes between different versions" in
configmgr and offapi. (Also, this moves the computation of sMigratedProductName
in MigrationImpl::copyConfig, desktop/source/migration/migration.cxx, to a saner
location than in the middle of the "check if the shared
registrymodifications.xcu file exists" block where that
583ea856f2aa227bb04581c5bcdc3a402f5a184f had placed it.)
Change-Id: I7ab3d57db19065c7c818e697300a2abd9e7f72bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139963
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The problem was that when doing the SHELL mail merge with a document
starting with a table, the generated marks point to the first node on
the page, which is not a content node, but a table node. When getting
page numbers for such mark, cursor got cleaned up, meaning that it
looked for a content node as the cursor position. The lookup tried
to go to a previous content node first, and that gave a content node
on the previous page.
The cursor position cleanup was introduced for i#18014 in commit
468c7b8d3287712c6959cd531c71875f4d26bcbc
Author Jens-Heiner Rechtien <hr@openoffice.org>
Date Fri Jan 04 12:19:29 2008 +0000
INTEGRATION: CWS sw8u10bf02 (1.66.92); FILE MERGED
The bug was incorrect restoration of cursor position after inserting
a row to a table, placing cursor there, and undoing.
I have checked that the mentioned scenario keeps the cursor inside the
table, not jumps to the beginning of the document, as it did before
the mentined commit.
Unfortunately, I don't see how to test this properly in
sw/qa/extras/mailmerge/mailmerge.cxx; FILE mailmerge tests there use
a different code path; and SHELL tests obviously do not perform the
post-processing from SwMMResultSaveDialog::SaveOutputHdl_Impl. Likely,
an UITest would be needed.
But why do we use this SHELL + post-processing here, instead of using
the same FILE mail merge that is performed from form letter dialog,
when SwDBManager::Merge is called from SwDBManager::ExecuteFormLetter
with properly constructed SwMergeDescriptor? That would also speed up
the merge, avoiding extra steps of generating full resulting document
in memory, saving it to a temporary file, just to split it to pieces
(TODO/LATER).
Change-Id: I269de4ae3407261c4f6df51cacd5fc72643fd29a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139973
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Also removed now pointless line making stream seek back to start as a
SeekGuard exists now
Change-Id: I82e8e6852b47176fff8aae3e7d7b0e7d5c533b40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139956
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I5b86bd53d1fc68804970deba9d40f02861a1975b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139955
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Idc9756bf5b468d8ed0d11e6a75703d96350e1273
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139960
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I28316a33fab208ddea2dda9f6ef3a22a8dc60457
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139969
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This was introduced this way since commit 468c7b8d3287712c6959cd531c71875f4d26bcbc
Author Jens-Heiner Rechtien <hr@openoffice.org>
Date Fri Jan 04 12:19:29 2008 +0000
INTEGRATION: CWS sw8u10bf02 (1.66.92); FILE MERGED
Obviously, since pNode was not updated, the next check would fail again,
and the updated value of aIdx would be discarded immediately, making the
first check and the call to GoNext effectively a no-op.
Change-Id: I878cd0887197a86d8800a467807275ed09e617c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139968
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad has among other things
enabled, that a shape with vert='mongolianVert' in a docx file is
imported to a shape where the attached frame has WritingMode =
text::WritingMode2::TB_LR and that it is then exported to a shape with
vert='mongolianVert'.
The unit test here tests this behavior.
Change-Id: I18ef6fdcb9cbad4fdd18061aca536f95c9ea83af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139957
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
Map it to /FT/Tx, and set the additional actions so it appears like a
date picker.
Also extract a SwModelTestBase::LoadPdfFromTempFile() to avoid
copy&paste.
Change-Id: I062481cc557d8222953987355c7b08cb92efda51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139964
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I9deb3ec3dad5174dfb49cf0df3004746f3e47ea6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139959
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ic40dfeb742e97b90332dd711cfb582b6f102c8df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139958
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
than testRedlineAutoCorrect2
Change-Id: I05ea1ef902f1cddf429d594e0031fab2ec89b653
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139927
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I246168902d07dbc75b68142c73f148e711320d03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139938
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I75aaa3b211d0385c7138b531a77058e05d58f028
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139962
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
GraphicFormatDetector and GraphicDescriptor have duplicate format
detection code so now GraphicDescriptor uses GraphicFormatDetector
functions instead to detect the format for PCX files
Change-Id: Ib4c9ca98c420b313fd3483272a7844d98ea227dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139274
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Fixes CVE-2022-38784
Add external/poppler/disable-freetype.patch.1 to get rid of some new
code that unconditionally requires freetype, to avoid building that on
WNT/MACOSX.
Change-Id: I854d1865286b6fb4112cdf37898cda0203c52f2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139941
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
All the tests in this suite use CPPUNIT_TEST_FIXTURE() already, so this
is never called.
Change-Id: I9f0c868b3fdcc17ed7c6240afa90d7fa3a374ecf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139951
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Draw can handle PDF files, so offer them in "Open with" menu
Change-Id: I1c8f9af8e38ee15490371074d02a2ccf35933076
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139802
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
regression since LO 4.2
Change-Id: Ic9b6c00af9f1cccdb58ac3eede59268d1c83c767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139761
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Some tests were using mxComponent and some other
tests where using their own xComponent
Hopefully this will fix the CppunitTest_sc_vba_macro_test
failures on windows
Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie0b685dbcbc3504de10372b9c0127781171f8fb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139946
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: If09c419ba00fc9be021249e4d4da27d1650b9080
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139913
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
after promote, demote, and move chapter
Change-Id: Ie165fadf6154a019ad79a0fed489f63aa768c8f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139823
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
after c97c60f70e9e6de594f7e0e0b85f17944c640dcf
"external: update pdfium to 5298"
Change-Id: I4a0a37ebf6cbc070d2fc5e17c89fd307a53de7fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139949
Tested-by: René Engelhard <rene@debian.org>
Tested-by: Jenkins
Reviewed-by: René Engelhard <rene@debian.org>
|
|
* Update helpcontent2 from branch 'master'
to dfa442b3d862539a7b10af5281a080acaef7e73d
- tdf#150909 workaround for bad renderring of help page
Change-Id: I6d33eb8fd9787cc36837cb4c10c93695d834ed26
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139770
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I91dc9f7123b878e49a1ad57e5f40b6741ab04487
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139945
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
If a cell is not formatted as Text and
ScSetStringParam::mbHandleApostrophe is true, all input (except
one single apostrophe that otherwise would lead to an empty cell
string) now is treated the same and the leading apostrophe is
removed and the remainder is set as text content. The Input Line
and editing a cell get an apostrophe prepended for the cases
needed to generate such escaped string again.
This made it necessary to adapt a unit test that exactly checked
the old behaviour.
Change-Id: I07b35d33f3704970784dc6de1322bda28903bb97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139934
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Fixes CVE-2022-2309
Change-Id: I180218be275d3b6d38f8f74aa51c57e50d2734ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139911
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: If34a2b15aebc5316783d72564ede23e02db04302
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139944
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
======================================================================
FAIL: test_tdf134390 (navigator.navigator)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/qa/uitest/calc_tests8/navigator.py", line 143, in test_tdf134390
self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
AssertionError: '1' != '2'
- 1
+ 2
Change-Id: I7c781191facd10abbb25f895cb0d2bacb72d92ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4b50822183d9752d6a413b0308e1d661785fb10e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139937
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I01e06fe89f95141a177298e400ccd0f54c2a05db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139936
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If2460da367356ef04ca344542c2c82f8283c9e67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 130638cf417ad37c42c7da8c47f552ba791fe3a7
- Related: tdf#131136 Don’t mention obsolescent “Use printer metrics” option in Help
Change-Id: Idfe7f76bef4c48fc4d4762544cbe4439760b1a17
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139953
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Remove language (to get automaticaly user language)
Restore same font size for Asian and complex font
When using template as master page, styles Accent_x are not imported
This patch add direct formating to keep format when using template as
master page.
Change-Id: Iea38c1e235967c7f8d47d6a4419aec62ff4e9a33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139779
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
This change was added in commit 6ed597a7dd1da40248236e7a71843c2d76d6173e
for unclear reasons (that wasn’t asked for in the bug report), and,
besides, it solves an inexistent problem. No one has been confused on their
expectations after clicking this launcher on their app selector or Start menu.
For anyone looking, it is an obvious thing that, if presented with a set of
launchers like:
LibreOffice
LibreOffice Writer
LibreOffice Calc
...
... the option that isn’t specific will launch a general interface. That’s just simple.
“Start Center” is not the brand name of an application. Although, technically, it is
a module, for users, it’s just a welcome screen, to which OOo has added a glorified
name (it seems we’re experts on inventing weird terms for everyday UI paradigms…
just see “NotebookBar”, which is just a ribbon; deal with it).
It shouldn’t be present in the main launcher for the same reason we don’t add
the word “Dialog” to the title of every dialog.
Change-Id: I3703299fcb8a8244c721631c3107c9f9d3264d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139805
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|