summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-05dito->dittoCaolán McNamara
Change-Id: I432dcc61dfb53e6b439052c495a602aab8a58f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05tdf#124470: Split export of table autostyles out from collection phaseMike Kaganski
This allows to call collectAutoStyles where required (e.g. when enumerating used fonts), without side effect of writing table styles XML inside the call, out of place. Change-Id: Ida05e373eb8502590c43e2b0e85c3b0c1107c551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-05Adapt --enable-lto to --without-parallelismStephan Bergmann
...which sets PARALLELISM to 0 and thus caused cc1: error: unrecognized argument to ‘-flto=’ option: ‘0’ at least with recent GCC 11 trunk Change-Id: Ifcfb6485c1c2efc8ab798686ca7fc2392d2cfc2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100171 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05tdf#134913 set table width after setting columnsCaolán McNamara
so "relative" mode sticks regardless of any rounding issues triggering the table out of relative mode. Change-Id: If0abbf2ef75feb6fc4a408966c2a3c350589023f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05tdf#134925 keep a copy of the original SwTableRep to Reset back toCaolán McNamara
instead of operating on a copy of the original SwTableRep and over writing the original at commit Change-Id: I5c42291302f8b4a3394adcdb3425524623f7a051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05add some missing activates_defaultCaolán McNamara
Change-Id: I26c8743b2ecd174e24dc61f796039793eee7e0c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05gpgpmepp: fix creative abuse of gbuildMichael Stahl
The problem was that (cd sw && make CppunitTest_sw_ooxmlexport4) fails with an error that the gpgmepp package doesn't exist, but only on WNT. Nonobviously, this is due to the override of the rule for the gpgmepp package in ExternalPackage_gpgmepp.mk, which copies the same file that the package already depends on for no obvious reason. Furthermore, RepositoryExternal.mk uses gb_Helper_register_executables_for_install with gpgme-w32spawn, when it should just register the package instead, because that is not a gbuild Executable. Change-Id: I8cb8b7a68c9681844a39de1390aa736a1ec53449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100159 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-05tdf#121716 XLSX export: fix loss of left header (footer)Attila Szűcs
when footer (header) is shared (even). Co-authored-by: Tibor Nagy (NISZ) Change-Id: I6e656f2df1f9b6522af933bd1c71b8d60bbfe19f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99315 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-05tdf#135367 enable_toggle_buttons sets SvTreeFlags::CHKBTNCaolán McNamara
designating that the special auto-sized toggle column is in use Change-Id: I23aa927c56e706590f397d15ef7329d20e0b18a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100136 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05remove some unused suppressionsCaolán McNamara
Change-Id: I8b29bccdf90c4b044aaa4905226c8c33dd07f880 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-05Ensure cp target directory existsStephan Bergmann
<https://ci.libreoffice.org/job/gerrit_windows/71710/console> > cp: cannot create regular file 'C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/extensions/source/activex/SOActionsApproval.cxx': No such file or directory [...] > make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/extensions/CustomTarget_so_activex_x64.mk:22: C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/extensions/source/activex/SOActionsApproval.cxx] Error 1 makes it look like this has been missing all along? Change-Id: Ifa685808942f05c539950311a4d800be0894c8ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100122 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-05tdf#135330: avoid replacing all settings when enabling IA2Mike Kaganski
Call to ImplHandleGetObject may happen in the middle of any UI operation, including those that make use of references to parts of global settings, like this: const LocaleDataWrapper& rLocaleData = Application::GetSettings().GetUILocaleDataWrapper(); setValue(*m_xCurrentWordFT, rCurrent.nWord, rLocaleData); // < here ImplHandleGetObject may be called setValue(*m_xCurrentCharacterFT, rCurrent.nChar, rLocaleData); If all settings get replaced, then LocaleDataWrapper gets destroyed, and the reference becomes invalid, and crashes in the next line. So first, the change makes the call only modify settings when it's needed; and second, it makes use of the implementation detail that aMisc modifies the shared data. The check after the change will catch if implementation changes so that this is no more true. Yet, the problem stays that using any references to global settings objects is unsafe, since any call to Application::SetSettings will invalidate them. Change-Id: I96d237ee57e80465fe52bc6bb6c149b087c89af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-05Propagate clang-format failure from reformat-formatted-filesStephan Bergmann
Specifically, this allows to manually terminate a (long-running) reformat-formatted-files through Ctrl-C. Change-Id: Ic44099b29e72619a6697d349a611a12b8536a3bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100154 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-05Silence loplugin:staticmethods when the definition involves preprocessingStephan Bergmann
...to help avoid false positives. (Another option to silence such warnings is to add (void) this; to false-positive function bodies, but this new approach may be more natural in certain cases.) Change-Id: Ie6ea908730c596dbfb62ff42ae60dbd0a00a8fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05CppunitTest_sw_uwriter: make rng used in this test repeatableMiklos Vajna
So in case the test fails, it's possible to see the same failure multiple times. Change-Id: Ic573807967b004bb7650ffb3614f5006db34080e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100137 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-05Adapt to --disable-assert-always-abortStephan Bergmann
Change-Id: Ib578c5d8c82ca763770d316384c6753534dbfee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100141 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05external/libgpg-error: -Werror,-Wundef (clang-cl)Stephan Bergmann
Change-Id: I7e71411901cc2c09b5d13a5ca451f1981e8a9e44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05loplugin:indentation (--disable-assert-always-abort)Stephan Bergmann
Change-Id: I47e4ec87a007864177d76b46863a87ea8c4b1a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100150 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05loplugin:indentation (--disable-assert-always-abort)Stephan Bergmann
Change-Id: I9f5f60771e7d658e0806428eb1c515ebb6fad6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05document the abort in ProcessTaskSchedulingNoel Grandin
Change-Id: I8a30e9abbf437cdf4f91a14755e5cc639dd172b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-05Simplify this a littleMike Kaganski
Change-Id: I81298ad97ef2161fb9e52466b7e17cd5a142067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100065 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-05Throw detailed IllegalArgumentException regardless of OSL_DEBUG_LEVELStephan Bergmann
...assuming that such an exception is rare enough that any performance impact does not matter. (The code was like this ever since its introduction in 9e2bf1d54a6e92dcfa3076bf4d7cc623ace87cd3 "INTEGRATION: CWS canvas02".) This nicely avoids loplugin:unusedmember about unused mpStr and mnArgPos when OSL_DEBUG_LEVEL is zero. Change-Id: I2ad3e36e98a6811ae255525cf8159db89c78ad7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100143 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-08-05Avoid warnings about unused Char4Stephan Bergmann
Change-Id: Ibcb256552ee03b14a76463be3d9b7ce53213fa7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05remove unused pStrScDoc fieldNoel Grandin
Change-Id: Ie62d5cc2c0c29be14c85e618ddb65cc328fadcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100083 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-05loplugin:flatten in unotoolsNoel Grandin
Change-Id: I2fad16061bca6dc3e57926863e7a3b71947a8ade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:simplifypointertobool (clang-cl)Stephan Bergmann
Change-Id: I6512e6e4217ef9084c74e46e3b4f1e8defbd1bec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04tdf#134930 remaining space is for display only purposesCaolán McNamara
use a label instead, keep spinbutton (but invisible) to format the label Change-Id: I36660566df34891e8e813dee24375eacf55e09d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04two unused suppressionsCaolán McNamara
Change-Id: Ia8df1177bb0d60ce2201f1e91d19845c8b873602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100126 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04tdf#128218: sc_macros_test: Add unittestXisco Fauli
Change-Id: Id0597de78873dccd7316c406364f1c4c2ae5bb93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100120 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-04weld OTableWindowListBoxCaolán McNamara
Change-Id: Iae1d2da93fd150d2a333a55bd5b3c06aad0a308f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04explicit text column to avoid dummy nodes for non-toggle caseCaolán McNamara
Change-Id: If216705929454146d39b291b9a6483c68c3eac89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100123 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04loplugin:elidestringvar (clang-cl)Stephan Bergmann
...plus ensuing loplugin:unnecessaryparen in vcl/source/treelist/transfer.cxx Change-Id: I1abf2e0c589c2c124399c1337f5dd703ee7d04a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04external/gpgmepp: Avoid overloaded utf8_to_wchar in C codeStephan Bergmann
> w32-util.c(176,1): error: conflicting types for 'utf8_to_wchar' > utf8_to_wchar (const char *string) > ^ > workdir/UnpackedTarball/libgpg-error/src\gpg-error.h(1109,10): note: previous declaration is here > wchar_t *utf8_to_wchar (const char *string, size_t length, size_t *retlen); > ^ with clang-cl on Windows, while in a case like this where there is only one definition, the mismatching declaration merely gets warned about by MSVC with "warning C4029: declared formal parameter list different from definition". (And on non-Windows that w32-util.c apparently doesn't get compiled at all.) Change-Id: I76cfc3ec086325c527c04dbe0e8341cb9b775c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:referencecasting (clang-cl)Stephan Bergmann
("the source reference is already a subtype of the destination reference") Change-Id: Ifba02593d77057eaa356ec7c3c76de64ba65cf09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100089 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04Remove seemingly unused #includesStephan Bergmann
...that caused > desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx(81,10): error: macro is not used [-Werror,-Wunused-macros] > # define WIN32_LEAN_AND_MEAN > ^ with clang-cl Change-Id: I129f659aa196e0e713d7bd9065c637d65ee2ac10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04Improved loplugin:staticanonymous -> redundantstatic redux, clang-clStephan Bergmann
Change-Id: Ie6dc22edbcfdf05ab8d7d668cb7cc33b5b747995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 92d4f32170e6d3a1b65857bb83e22c4bf7f565bd - Fix some "D'oh! You found a bug" here and there Change-Id: I0b3b4eec07378dcc3a110bfb7e2205220f30c579 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100132 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-04Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 7bb1ec81e997e270be39f5639073f5190dd3655e - tdf131416 Basic syntax diagrams - Input, Line Input, Print, Put, Reset, Seek and Write statements Added comma|semicolon delimiter information Change-Id: I1ef994f1fe68db3d1b8f5d1a85d3764078ab33f3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99925 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-04Avoid some unhelpful loplugin:makesharedStephan Bergmann
...like > canvas/source/directx/dx_impltools.cxx(137,31): error: rather use make_shared than constructing from 'Gdiplus::Graphics *' [loplugin:makeshared] > GraphicsSharedPtr pRet(Gdiplus::Graphics::FromImage(rBitmap.get())); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ on Windows, where those functions like FromImage are provided by Windows (so we can't help it that they are returning pointers) Change-Id: Iae5c4b20d64cc6b38ff66409519fbd25f6e509cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100095 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:makeshared (clang-cl)Stephan Bergmann
Change-Id: Ie28438633d9d81d756013772c573f02a756478d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100096 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: Ib53c1d0d11962067d3a18dab453a6530398bc5a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100093 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:unusedmethodsNoel Grandin
Change-Id: I5fa2bbeff17a9933ff55afb0c3544d025d096a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:referencecasting (clang-cl)Stephan Bergmann
("the source reference is already a subtype of the destination reference") Change-Id: I1183eaa2015bd9d6567001bb14f7809dffcae7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100088 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04-Werror,-Wunused-function (clang-cl)Stephan Bergmann
Change-Id: I85149c0618a9b347fd1710f46b825844b3119bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100087 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04tdf#134925 operate on a copy of the original SwTableRepCaolán McNamara
and keep the original around for use from ::Reset and overwrite the original SwTableRep on commit Change-Id: I18e078e577382c4c13d6f5e576cc1eeec15a7906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04Related: tdf#134925 use std::vectorCaolán McNamara
Change-Id: I7046814570a3ac98c92dc3d08e8dd05ed4d3483c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04tdf#134420 select neighbour when deletedCaolán McNamara
Change-Id: I55c6135360d3d77b7b3d2e54012ad82e1a4813ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-04remove some debug codeNoel Grandin
Change-Id: I6aff84ce7b9d4fed27d8442d1366bcf14bc44f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 1c00f748202eb64ffa0be5ce38e57a47f6e5798a - update translations for master and force-fix errors using pocheck Change-Id: I7e90d467017ce8e49d81e914d60d944e2e69e0f1
2020-08-04tdf#135144 sw: copy bookmarks in SwDoc::CopyMasterHeader()Michael Stahl
... and SwDoc::CopyMasterFooter(); this is the same as commit 9f7ee38acec0cb614e37aecc5ea9c5f1c63b61b6 but for 2 other functions that do the same thing. Change-Id: Id7ed449a004ee3c9452d4603bf8632e2720651ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100077 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
generated by cgit (git 2.34.1) at 2024-07-11 09:39:39 +0000