summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-24drop empty headerCaolán McNamara
Change-Id: Id0442482f940cf5329e2c9d44ed90b7d5b862aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop unneeded includeCaolán McNamara
Change-Id: I1a5a0f7b799f332d9f1d43ad50c8a6d924c71cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111494 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24crashtesting: assert of unbalanced tags on exporting tdf94591-1.odt to docxCaolán McNamara
because tdf94591-1.odt has coordinates we can't parse, resulting in nulls where the export expects a number and the exception is thrown causing close tags to be omitted, put the coordinate parsing into an exception block of its own so the close tags are emitted Change-Id: Ibf17e6204f360d5c9266ed010e25f9455de2d22b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24ofz#30767 Build-FailureCaolán McNamara
similar to commit 63a9b50a7a062069af3e3bcf05657164179baa83 afl++ build crashes for some obscure reason. Tweaking the code like so gets it to squeak by and continue the build. Change-Id: I8cf477320eab19913c1bb65d9ccb779d9c37c8aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111491 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24Resolves: rhbz#1931423 start update timer in IM events as well as keyeventsCaolán McNamara
Change-Id: I5a72adebd34c3983e7a414110c3192d05b725e45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24tdf#140572 docx export: avoid DocDefault superscript crashJustin Luth
This fixes a crash situation introduced in LO 6.4 by commit d71cf6390a89ea6a4fab724e3a7996f28ca33661. The crash was occurring when the DocDefaults were being exported. Since there was no character or paragraph context, the lookup of the related fontsize was crashing. Moving this variable closer to where it is used "just happens" to fix the crash. Because the DocDefault is considered a style, we are just exporting the superscript/subscript as a default size, and so don't need to know the font size. Thus a style-context position can't cause the crash again. So it isn't a great fix, and leaves the possibility for the same thing to happen in other situations (like RES_CHRATR_BACKGROUND), but at least it quickly solves this known problem, and is easily backportable, as well as following best practice of keeping variables as close to where they are used as possible - eliminating some unnecessary lookups. I did look for a more generic fix (or whether other properties could be affected) and didn't come with any clear examples or a better fix. Change-Id: I03dc3d74a5148973c065cadb09c5c79068f12df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111403 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-02-24tdf#138701: sw: Add UItestXisco Fauli
Change-Id: I3a7ef6742d647b71a63746384daf415d77a495b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111486 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24tdf#140239: sw: Add UItestXisco Fauli
Change-Id: I140cc21fa5682f1dd869da0f135337b97c3e38cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111485 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24Build internal icu with user CFLAGSVincent LE GARREC
I have a Gentoo (Linux) with libxml2 built with icu support. Under Gentoo, icu is built with U_DISABLE_RENAMING=1. Building LibreOffice with internal icu uses system libxml2. So both builds need CFLAGS="U_DISABLE_RENAMING=1" to avoid naming conflicts. Change-Id: I565c4ac079aee5e48a1e43f21d0a697e3498f925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111276 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-24use unique_ptr in WinSalBitmap::AcquireBufferNoel Grandin
Change-Id: I1fca86f6d1f9bd64238b8e75cd98f53df99f91bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111447 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24use unique_ptr in WinSalBitmapNoel Grandin
Change-Id: I3c536b766d35b3137d79739c232d0d5cff3652b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111446 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24use unique_ptr in WinSalBitmapNoel Grandin
Change-Id: I8ca55870094443f7eb670df06de34ad0ed87ad8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24disable-pch fixNoel Grandin
Change-Id: I14760d858c1500800c9360530b0408986122e00b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111444 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24tdf#140567 don't grab focus to outline content visibility buttonJim Raykowski
when pointer is on an outline frame. Change-Id: I9a9d406340a88c24f959445b570ab1f02dffbef8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111367 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-24tdf#124176 Use pragma once in sw/source/core/textSuhaas Joshi
Change-Id: I9eb44c16fef1da8a1931e60857912887282bff59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108735 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-24Fix typosAndrea Gelmini
Change-Id: Ie39c9f9208ecb282612f2f2e1dc5672ea8baf5c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111007 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-24Fix typoAndrea Gelmini
Change-Id: I98757c517d54d38ac96bc80ddb030d00ddfbb1e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110661 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-24Fix typoAndrea Gelmini
Change-Id: I3f3d867ef7fd930119f917c1be6e25a8c59bbf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111365 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-02-24Fix typosAndrea Gelmini
Change-Id: If005139571e46fbf8aedb37e2626c54a43853fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111483 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-24Removed duplicated includeAndrea Gelmini
Change-Id: Ie6aac80ed560ad49dd2167afa965a768aac0818b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111482 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-24qtcreator: Create *.pro.shared files instead of *.pro.userMichael Weghorn
Generating *.pro.user files is not ideal; they're supposed to hold user-specific settings for a project, and thus also to persist manual changes made by the user after initial import of the project. Generate *.pro.shared files instead which are meant to be used to share project settings. [1] This just changes the file name of the generated file for now, but leaves the content the same. The result for the initial loading of the project from a '*.pro' file is basically still the same from a user perspective: A new kit 'Replacement for "Desktop"' is generated on the fly which contains the build and run settings specified in the corresponding '*.pro.shared' file. By using the '*.pro.shared' files, user-specific settings made after initial import will no longer be overwritten by running 'make qtcreator-ide-integration' again, since the '*.pro.user' files are left as they are. The '*.pro.shared' files generated here still contain information specific to the local setup (like file paths). For some more background on LO's Qt Creator IDE integration, s. dev mailing list thread "Added some information about Qt Creator IDE integration to the wiki" [2]. [1] https://doc.qt.io/qtcreator/creator-sharing-project-settings.html [2] https://lists.freedesktop.org/archives/libreoffice/2021-February/thread.html#86800 Change-Id: Ia187bcbffe5297a1cdf6bfeaaabf7867003195e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111474 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-02-24crashtesting: iterators invalidated during loop with tdf94598-3.docxCaolán McNamara
Change-Id: I27fbf1ba578724bb15eadf14db19db62bbd5fc40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24hide menubar detailsCaolán McNamara
Change-Id: If9d30b4f1408f16cb84636245fc9039a0dd6bad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111481 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24use GetMenuBarHeight to get menu bar heightCaolán McNamara
Change-Id: I632ead4c63a3064391366334d961b1767ead9af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24ofz#30767 Build-FailureCaolán McNamara
afl++ build crashes for some obscure reason with attached bt. Tweaking the code like so gets it to squeak by and continue the build. clang-12: /usr/local/include/llvm/IR/Constants.h:661: llvm::StringRef llvm::ConstantDataSequential::getAsString() const: Assertion `isString() && "Not a string"' failed. Stack dump: 0. Program arguments: /usr/local/bin/clang-12 -cc1 -triple x86_64-unknown-linux-gnu -emit-obj --mrelax-relocations -disable-free -disable-llvm-verifier -discard-value-names -main-file-name converter.cxx -mrelocation-model pic -pic-level 2 -fhalf-no-semantic-interposition -mframe-pointer=all -fmath-errno -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -tune-cpu generic -fno-split-dwarf-inlining -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -ffunction-sections -fdata-sections -D BOOST_ERROR_CODE_HEADER_ONLY -D BOOST_SYSTEM_NO_DEPRECATED -D CPPU_ENV=gcc3 -D DISABLE_DYNLOADING -D LINUX -D NDEBUG -D OSL_DEBUG_LEVEL=0 -D UNIX -D UNX -D X86_64 -D _PTHREADS -D _REENTRANT -D SAX_DLLIMPLEMENTATION -D FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -D EXCEPTIONS_ON -D LIBO_INTERNAL_ONLY -D __AFL_HAVE_MANUAL_CONTROL=1 -D __AFL_COMPILER=1 -D FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION=1 -D "__AFL_FUZZ_INIT()=int __afl_sharedmem_fuzzing = 1;extern unsigned int *__afl_fuzz_len;extern unsigned char *__afl_fuzz_ptr;unsigned char __afl_fuzz_alt[1048576];unsigned char *__afl_fuzz_alt_ptr = __afl_fuzz_alt;" -D "__AFL_COVERAGE()=int __afl_selective_coverage = 1;extern \"C\" void __afl_coverage_discard();extern \"C\" void __afl_coverage_skip();extern \"C\" void __afl_coverage_on();extern \"C\" void __afl_coverage_off();" -D "__AFL_COVERAGE_START_OFF()=int __afl_selective_coverage_start_off = 1;" -D __AFL_COVERAGE_ON()=__afl_coverage_on() -D __AFL_COVERAGE_OFF()=__afl_coverage_off() -D __AFL_COVERAGE_DISCARD()=__afl_coverage_discard() -D __AFL_COVERAGE_SKIP()=__afl_coverage_skip() -D "__AFL_FUZZ_TESTCASE_BUF=(__afl_fuzz_ptr ? __afl_fuzz_ptr : __afl_fuzz_alt_ptr)" -D "__AFL_FUZZ_TESTCASE_LEN=(__afl_fuzz_ptr ? *__afl_fuzz_len : (*__afl_fuzz_len = read(0, __afl_fuzz_alt_ptr, 1048576)) == 0xffffffff ? 0 : *__afl_fuzz_len)" -D "__AFL_LOOP(_A)=({ static volatile char *_B __attribute__((used)); _B = (char*)\"##SIG_AFL_PERSISTENT##\"; __attribute__((visibility(\"default\"))) int _L(unsigned int) __asm__(\"__afl_persistent_loop\"); _L(_A); })" -D "__AFL_INIT()=do { static volatile char *_A __attribute__((used)); _A = (char*)\"##SIG_AFL_DEFER_FORKSRV##\"; __attribute__((visibility(\"default\"))) void _I(void) __asm__(\"__afl_manual_init\"); _I(); } while (0)" -O1 -Wno-unused-command-line-argument -Wall -Wno-missing-braces -Wnon-virtual-dtor -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wunused-macros -Wembedded-directive -Wdeprecated-copy-dtor -Wimplicit-fallthrough -Wunused-exception-parameter -Wrange-loop-analysis -Wshadow -Woverloaded-virtual -Wno-unused-command-line-argument -std=c++17 -fdeprecated-macro -ferror-limit 19 -fvisibility hidden -fvisibility-inlines-hidden -fsanitize=address -fsanitize-blacklist=/src/libreoffice/bin/sanitize-excludelist.txt -fsanitize-system-blacklist=/usr/local/lib/clang/12.0.0/share/asan_blacklist.txt -fsanitize-address-use-after-scope -fno-assume-sane-operator-new -funroll-loops -pthread -stack-protector 2 -fgnuc-version=4.2.1 -fno-inline -fcxx-exceptions -fexceptions -fcolor-diagnostics -load /src/aflplusplus/afl-llvm-dict2file.so -load /src/aflplusplus/cmplog-routines-pass.so -load /src/aflplusplus/cmplog-instructions-pass.so -load /src/aflplusplus/split-switches-pass.so -load /src/aflplusplus/SanitizerCoveragePCGUARD.so -faddrsig -x c++ converter-773998.cpp 1. <eof> parser at end of file 2. Per-module optimization passes 3. Running pass 'afl++ dict2file instrumentation pass' on module 'converter-773998.cpp'. #0 0x0000000001719ae3 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/usr/local/bin/clang-12+0x1719ae3) #1 0x0000000001717a4e llvm::sys::RunSignalHandlers() (/usr/local/bin/clang-12+0x1717a4e) #2 0x0000000001719f8f SignalHandler(int) (/usr/local/bin/clang-12+0x1719f8f) #3 0x00007f3e317b2980 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x12980) #4 0x00007f3e306abfb7 raise (/lib/x86_64-linux-gnu/libc.so.6+0x3efb7) #5 0x00007f3e306ad921 abort (/lib/x86_64-linux-gnu/libc.so.6+0x40921) #6 0x00007f3e3069d48a (/lib/x86_64-linux-gnu/libc.so.6+0x3048a) #7 0x00007f3e3069d502 (/lib/x86_64-linux-gnu/libc.so.6+0x30502) #8 0x00007f3e30464810 (anonymous namespace)::AFLdict2filePass::runOnModule(llvm::Module&) /src/aflplusplus/instrumentation/afl-llvm-dict2file.so.cc:150:5 #9 0x00000000011d139f llvm::legacy::PassManagerImpl::run(llvm::Module&) (/usr/local/bin/clang-12+0x11d139f) #10 0x00000000018ef775 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::DataLayout const&, llvm::Module*, clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >) (/usr/local/bin/clang-12+0x18ef775) #11 0x00000000023c074f clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/usr/local/bin/clang-12+0x23c074f) #12 0x0000000002cbe554 clang::ParseAST(clang::Sema&, bool, bool) (/usr/local/bin/clang-12+0x2cbe554) #13 0x0000000001e3ccc7 clang::FrontendAction::Execute() (/usr/local/bin/clang-12+0x1e3ccc7) #14 0x0000000001dc7311 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/usr/local/bin/clang-12+0x1dc7311) #15 0x0000000001ed2dfc clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/usr/local/bin/clang-12+0x1ed2dfc) #16 0x000000000092166e cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/usr/local/bin/clang-12+0x92166e) #17 0x000000000091ff77 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) (/usr/local/bin/clang-12+0x91ff77) #18 0x000000000091fdbb main (/usr/local/bin/clang-12+0x91fdbb) #19 0x00007f3e3068ebf7 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf7) #20 0x000000000091cd49 _start (/usr/local/bin/clang-12+0x91cd49) Change-Id: I4eab488ff09f9213489212e56ed636596be6ae89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111477 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24tdf#140198: sw: Add UItestXisco Fauli
Change-Id: I0cb7286355883dc67b5bcde5ef43046dce224da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111476 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24Move code for setting unique buildable names one level upXisco Fauli
this way, we also set the name for elements like the listbox 'Text type' Change-Id: Id894704f870276c20958612bee2926dae98d766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111475 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24avoid LOK text selection update when reference cell is in different tabPranam Lashkari
Change-Id: I511b9c5a27f97b6e14e9a844179c27a96997abe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111315 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-24sw: make sure g_DefaultAnchor is in sync with aPropNamesMiklos Vajna
This was already the case for one setting, but the same was not done when the default anchor setting was added, fix this now. Change-Id: Ia0cfa20468673117ff6580b270801e6605537ab6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111473 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-24update creditsChristian Lohmaier
Change-Id: I45b6387535bd966f37fdf98579c658747d89a1e0
2021-02-24tdf#140486: sw: Add UItestXisco Fauli
Change-Id: Ie4ae878beed0a298388db29cfecfa537013166c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111472 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24uitest: no need to pass the parent as a parameterXisco Fauli
Change-Id: I750b5600d3e4ef8ba5a0666133b9066904b4cbec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111450 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-24Simplify static string generationMike Kaganski
Change-Id: I838d3900a6f3ba28fd30cd2e3ec7a7f74a7736b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111431 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-24Prevent the unnecessary lclCropGraphic call.Gülşah Köse
In case text::GraphicCrop aGraphCrop( 0, 0, 0, 0 ) we don't need to call lclCropGraphic. Change-Id: I9960900f9b5c5b770824c76ffeb9ec9b51cbaef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111401 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-24crashtesting: avoid assert on loading tdf98681-3.docxCaolán McNamara
as in 80e5e3826f6919e68c75d63f9dfe6417577d41ed this documents font stretch is now 135 Change-Id: I3139d36b909ef1546a1e083c8aabcc9597e314e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111451 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24cid#1473315 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia976785e66878fe23c8f96210f11c477e897858e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24actually prefer DrawTransformedBitmap() if it's known to be fastLuboš Luňák
This partially reverts the logic of change 9d89d98d3349502b56d, which always made DrawTransformedBitmap() get changed to DrawBitmapEx if only translation+scaling was involved. But since that one may call BitmapEx::Mirror() that'll do pixel-shuffling, trust the DrawTransformedBitmap() implementation to do the right and efficient thing if it says so. Change-Id: If25b3d189ddd46b235e122e5e8d6f8079ec09f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111248 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-24add additional 0-1 alpha argument to DrawTransformedBitmap()Luboš Luňák
This allows the VCL backends the apply the extra alpha transformation as it sees fit, rather than it being done manually elsewhere (and even if the backend doesn't implement it, at least do it in one place in the function). With the document from tdf#136223, going from slide 2 to slide 3, this easily saves 10-30% of CPU cycles. As an additional bonus, using AlphaMask::BlendWith() rather than AlphaMask::Replace() makes edges of shapes noticeably more smooth. Change-Id: I036dc9b887d6def0c7cdad3982becabdc7cd5206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111247 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-24simply use drawTransformedBitmap()Luboš Luňák
At least with Skia this is faster than GraphicObject trying to handle it manually, even in raster mode. Change-Id: If77d108751f5621878d4ea87a996c2ea0253d111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111246 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-24do not dispose XDesktop in visualbackendtestLuboš Luňák
6e35794cad555485955c3b43593497dcdbf29840 changed a warning on doing so to an assert, so I think removing this is the same that the other test changes in that commit do. Change-Id: I63b3eb57a42a37e6b607648ab0ae0fb4c56c97e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111397 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-24use unique_ptr in SplitWindowNoel Grandin
Change-Id: Ic17c5a8923190d3be99105cbf47de6b83009145e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24tdf#140599 calc UI: fix row and column highlightTünde Tóth
The row and column headers lost their highlighting when selection moved over a filtered row. Change-Id: Ic416a6183710bbc84fe47a8b2de32ca86bafc11f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111371 Tested-by: Jenkins Tested-by: Balazs Varga <varga.balazs3@nisz.hu> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-02-24show reference range specific to only selected calc sheetPranam Lashkari
Problem: when switching tab in online reference range would not change according to tabs this would show incorrect reference range Change-Id: I07e072a74b2925a25b7a4a50ce0c238308d99ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111409 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-24use XPopupMenu::execute to run the menuCaolán McNamara
instead of cheating and pulling the vcl::Menu out of it Change-Id: I498f4577c1e677e860ccb3bf394adbca298f074a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24don't need to include vcl/layout.hxx in qt5Caolán McNamara
Change-Id: I8e08c4e5c5b92df4cbdb8ea32f40dbde25f7afd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24use unique_ptr in ImplHandleIMECompositionInputNoel Grandin
Change-Id: I9587d97fbdd73844590fd6380e594ec7b4f4df14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-24hide MenuBar detailsCaolán McNamara
Change-Id: I409a4df7703300e920511c28263634a00c7c6da7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24TypoOlivier Hallot
Change-Id: Ia91de8b58e9be79af9d4cbe8e799a26eaa41dee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110861 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-02-24tdf#134432 remove .uno:CharBackgroundExt from Writer UISeth Chaiklin
Tooltip is "Highlight Fill", but the .uno has no effect in a menu or toolbar. Remove from Customize menu. Remove from WriterCommands.xcu because no longer used in Writer UI. Change-Id: Id6447c09eb52bb9204fe4f1b4842d712ede19d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111177 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-24Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to ee3befa87f442e39396cee768c73a07f9faf8632 - tdf#139667 update help in relation to Bullets and Numbering dialog ( shared/01/06050300.xhp ) * modify "outline style" to "outline format" * update to <h1>,<h2> ( shared/01/06050500.xhp ) "Customize" tab * modify "numbering style" to "numbering scheme" * modify "numbered" to "ordered" and "bulleted" to "unordered" * update to <h3> ( shared/01/06050400.xhp ) "Image" tab * "bulleted" -> "unordered" * update to <h1>,<h2> ( shared/01/06050600.xhp ) * "numbered" and "bulleted" to "unordered" and "ordered" ( swriter/01/06060000.xhp ) "Chapter Numbering" * modified description of dialog box to align with terminology used for other help pages and tooltips. * simplify tip (from 2007) about using Chapter Numbering dialog * modified <note> (from 2004) about Load/save, which is also embedded in shared/01/06050600.xhp and swriter/01/legacynumbering.xhp - remove "Save As" option about list styles and its description because this dialog does not have this functionality any more. - remove <note> about "View Shadings", which does not seem valid any more. * update to <h1>,<h3> ( shared/00/00040500.xhp ) * update to <menuitem> for Outline tab * correct command sequence to List Style deck for Outline tab * replace German id + add sys-switch for F11 (3 times) Change-Id: I204b66957f19654fc6d37fd8f79d8b1686810866 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110685 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>