summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-18lok: deglobalize SetDragObjectSzymon Kłos
and other Drag and Drop related functions Change-Id: Idbaec91c0ed396da9888c8ed562d2eff35686cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123209 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129466 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-18Simplify sequence of Property in connectivity/adoJulien Nabet
Change-Id: I1b1e183b053d98139ca5b45f3642d252252da14a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130142 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/macabJulien Nabet
Change-Id: Id0ed3ab3d66dfb8b76030fad7cd0b2bc3ea010fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130139 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Simplify sequence of Property in connectivity/mysqlcJulien Nabet
Change-Id: Ib4e1c47262c42db92226be5f84742799c3a1cbb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Resolves: tdf#147393 SpinButtons should be can-focusCaolán McNamara
Change-Id: I092ed9c3421267ea3b2c671020e7079c3f792e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18resave with latest gladeCaolán McNamara
Change-Id: Ia6fcf99a0d9bb914eb977f20426d6b093f21e3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18lok: sc: simplify drag & drop functionsHenry Castro
The ScDragData is a global use for private drag & drop in a desktop case, it will be used by tiled rendering case to pass its own local ScDragData per user. Change-Id: I0bca8e6d5c0eab82b69374a67425e2a8d746ef4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118990 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129465 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-18clear ScDocumentImport position cache if iterators are invalidCaolán McNamara
SheetDataBuffer::finalizeArrayFormula calls ScCellRangeObj::setArrayTokens ScDocFunc::EnterMatrix ScDocument::InsertMatrixFormula and InsertMatrixFormula calls the variant of ScColumn::SetFormulaCell which doesn't take a sc::ColumnBlockPosition& param when SetFormulaCell adds a cell to the column so any iterators belonging to ScDocumentImport are invalid. Change-Id: Ic2814ecbeafdeb99632d2a255ed6c1dedf7376b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129991 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-02-18-Werror=maybe-uninitializedNoel Grandin
/home/noel/libo3/svx/source/toolbars/extrusionbar.cxx: In static member function ‘static void svx::ExtrusionBar::getState(const SdrView*, SfxItemSet&)’: /home/noel/libo3/svx/source/toolbars/extrusionbar.cxx:938:25: error: ‘eMetalType’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 938 | if (eMetalType == EnhancedCustomShapeMetalType::MetalMSCompatible) | ^~ /home/noel/libo3/svx/source/toolbars/extrusionbar.cxx:933:31: note: ‘eMetalType’ was declared here 933 | sal_Int16 eMetalType; | ^~~~~~~~~~ Change-Id: Ie98bb04900d271299cb930bf6d12af46d45ae8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-18Simplify even more sequence of Property in connectivity/odbcJulien Nabet
Change-Id: I8dd75cf5c41aa879efe740f48bcb305901742804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130135 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18remove MAXCOLCOUNT from calc pivot implementationLuboš Luňák
It appears that PIVOT_DATA_FIELD is just a custom special value that's outside of the valid column range, but otherwise the value doesn't matter, and -1 is generic. Change-Id: Ieac1d4e3391f76350dc420e6b2ae9ed9f35d35f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130124 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-18boost: use utf-8 encoding for unknown locales.Michael Meeks
More exotic locales like es-419 cannot be parsed by boost, so we fall-back to the default encoding. This avoids an exception: invalid_charset_error of the form: "Invalid or unsupported charset:us-ascii or UTF-8" for this case. Change-Id: I6796dd893ec774b221956ea9febbcc19495d47b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130102 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-02-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 04eab5c5e9782cc901262135c68f394f1b3fd163 - tdf#147362 Add bookmark for italic autocorrect function Add also bookmark index for undeline, bold, strikeout. Change-Id: I6f5ebde77ffbc95b3a1e3758994e734be8f616c7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130053 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-18avoid an allocation in WhichRangesContainer::MergeRangeNoel Grandin
speeds up loading a large chart by 5% Change-Id: Idd8566012a0049d429e38b589782fc6d76eb3a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-18improve the SfxItemSet::CloneAsValue checkNoel Grandin
to prevent object slicing. Which reveals a problems with commit 044fa30a4c77013c87a7e2a6dd9022a2f6599778 Author: Noel Grandin <noelgrandin@gmail.com> Date: Thu Sep 23 18:44:42 2021 +0200 no need to allocate this SfxItemSet on the heap and commit 044fa30a4c77013c87a7e2a6dd9022a2f6599778 Author: Noel Grandin <noelgrandin@gmail.com> Date: Thu Sep 23 18:44:42 2021 +0200 no need to allocate this SfxItemSet on the heap so revert the problematic bits of those commits Change-Id: I5eeba1d5bdb91f4e539850516f2b1c11e69ff2c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-18Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 3e86799f1b1e957e442a23022bc12cc25bb0c8a6 - tdf#123318 Use SHARED as the default module instead of WRITER Change-Id: I78c3f71a862ad0896cc13b105cac46dca99b4195 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130079 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-02-18sfx2: introduce SfxBindings::QuerySlotIdHenry Castro
In order to invoke QueryState with the slot id, which it is easier to invoke UNO command states in unit test. Change-Id: I36d72a4381ff8386b1f1af33284ce674cf26acd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123063 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129464 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-18Revert tdf#64345: EDITING: Selected area looses selection when switching sheetAhmet Hakan Çelik
This reverts commit c82634d5a222120b3a95cff1b950a7f7a1f5ded1 Change-Id: I627b46f710da723ad58295d4fa0821df17eebd9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130108 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-18Simplify sequence of Property in connectivity/odbcJulien Nabet
Change-Id: Iaa2b908d63899c2e1141602b26d6da6b064f63e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130119 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-18Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: Ieddb3d76a960d4b87cd2a1e89bce3fcbe0fce7e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130113 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-18Revert "Related tdf#143578 - Rename SAL_NO_QUERYSAVE to NO_QUERYSAVE"Heiko Tietze
This reverts commit 75ac604292e92dc08bb8ba5b9cc30799d643090a. Reason for revert: Decision was made to have some prefix, either SAL_ or LO_ Change-Id: I42c7ad8a8b8a83161db568895d1ec98dcdc0838f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130026 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-18fix Writer key event delayed compression (tdf#145963)Luboš Luňák
SwEditWin::KeyInput() was stopping the flush timer on every invocation, which means that as long as key events kept coming the timer would be started again and again and would not time out, and so the input buffer would not be actually processed. It seems that AnyInput(KEYBOARD) there actually does not normally manage to return true ... except for Win11 where it seems that now GetQueueStatus() detects even key-up events even though it didn't before (I've not debugged this enough to be certain). I think it still makes sense to have the compression in case Writer get overloaded to help it process the pending input events, so fix this (but if there are problems, I think an easy solution is simply to drop it, it doesn't seem to be that necessary). Also decrease the timeout from 200 to 20ms, as 200ms is a very visible delay. Change-Id: I760ad9c4f58726a80bd6a9fbf93f2771f10cbdb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130083 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-18tdf#143817 Fix HUD deleting text contents in WriterRafael Lima
Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-02-18Define policy to optimize to_decimal to our use caseMike Kaganski
We don't need it to strip trailing zeroes (we do that ourselves anyway); also we don't need it to handle negatives. Makes doubleToString ~5% faster in my testing. Change-Id: Ie3c4e3fec1899364af54fda3f7141678a95359d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130120 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-18Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 401fb641aff217c7c333ce71d22abcf575d3ed09 - tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page Change-Id: I99ed22b86b04a3ae4338e0c2ab49dbd594032ac6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129607 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-02-18Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5 - tdf#146847 correction to Integer division help page Change-Id: Icdbdaf1fed778a0d235277680a2504386ec9208f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130010 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-02-17tdf#147409 tdf#146866 use SetPropertyValue for toggleRegina Henschel
The toggles (Textpath,SameLetterHeights) and (Extrusion,Extrusion) change a value by directly writing the value into the property. That is lines (*pAny) <<= bOn;, for example. But that does not trigger InvalidateHash() of the SdrCustomShapeGeometryItem. So the item has still aHashState 'Valid'. On the other hand because of the change the hash itself has changed. Therefore the == comparison between the original item and its clone returns 'false' in customshapeitem.cxx#238. And as a result, the assert in itempool.cxx#679 fails. My solution replaces the direct writing with setting the value via SetPropertyValue(), which includes the needed InvalidateHash(). The method InvalidateHash() is private and so cannot be directly used in fontwork.cxx and extrusionbar.cxx. Change-Id: Ib6021defb61478de9cbefa8f26466a2fe21352a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130117 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-02-17Revert "Fix failure of loplugin:useuniqueptr with older compilers"Stephan Bergmann
...0bf61855164af5751e78ca8626c10d604b1ab13b, which should be obsolete now: It speculated why 05a337e297eb0cfe88c99503d760bd9eaf495b7d "loplugin:useuniqueptr look for deleting in loops with iterators" had introduced Foo24 in compilerplugins/clang/test/useuniqueptr.cxx wrapped in #if CLANG_VERSION >= 50000 and came to the conclusion that "either the old compiler lacked Clang's recent <https://reviews.llvm.org/D50666> "Fix Stmt::ignoreImplicit" (and the above initialization expression happens to include a CXXBindTemporaryExpr, at least with libstdc++), or an even older compiler was used in pre-C++17 mode". But both of those potential reasons should be moot now, as the Clang fix got introduced towards Clang 8, and LO requires C++17 now (except for 3rd-party code). Change-Id: I307afbbecc5f031bca2319c4b22d54bd467eac81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17Don't exclude vcl/source/app/salplug.cxx from loplugin:externandnotdefinedStephan Bergmann
Whatever exactly the original reason to do so, it appears to no longer be relevant. (Maybe that salplug.cxx got reworked in the meantime?) Change-Id: I5187635dcb095ca505b38992b19770fe232f5124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130115 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17Use Dragonbox to implement doubleTo*String*Mike Kaganski
This header-only library is accurate in decimal representation of doubles; provides API that allows to create custom representation - so it's possible to use custom decimal separators and grouping. This allows to unify all corner cases: integers, numbers close to DBL_MAX, up-rounding to the next decade. Note that Dragonbox creates the shortest decimal representation of the number, that is unambiguously convertible back to the same number; thus it may hide trailing digits that are unneeded for such conversion. The functional changes are minimal, and beneficial: 1. Rounding numbers close to DBL_MAX now takes into account the bEraseTrailingDecZeros argument, as it should, allowing to have "1.8E+308" for rounding DBL_MAX to 2 decimals without trailing zeroes, instead of previous "1.80E+308". 2. Incorrect rounding is fixed in some cases, e.g. 9.9999999999999929 rounded to 10 previously using rtl_math_DecimalPlaces_Max. 3. Representing the number in the shortest way may change display of some printed numbers. E.g., 5th greatest double is represented as "1.797693134862315E+308" instead of a bit longer, but giving the same double on roundtrip, "1.7976931348623149E+308". This would generally look better for some numbers similar to the famous 0.1, where users would likely expect more "round" representation where it's unambiguous (but we still truncate to 15 significant decimals anyway - so there's no point in pretending to provide exact digits for actual binary representation). These are reflected in the unit tests affected by the change. Change-Id: I05e20274a30eec499593ee3e9ec070e1269232a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129948 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-17Extend loplugin:stringview to O[U]StringBuffer::makeStringAndClearStephan Bergmann
...at least when called on an rvalue. (The lvalue case would often be trickier to act upon, if the cleared object is still used later on.) Change-Id: I006e618da004b2127e9ed7381911c2d7b00b1169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130110 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17Bump compiler plugins Clang baseline to 12.0.1Stephan Bergmann
...as discussed in the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html> "Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at <https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html> "Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up compilerplugins/clang/ accordingly Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17reenable this layout test againCaolán McNamara
Change-Id: Icaedc8b25301be54fc2c99e829fca5907fcd86d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130075 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17Deduplicate some codeMike Kaganski
Change-Id: Ib05624739cce31b08fc409f238d447ed8d99bad9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130016 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-17Better handling of terminalsRenwa Hiwa
LIBREOFFICE-3MQTR80G Change-Id: Ifa52d7f65aae473056202b46788c5870a8ce38c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17Resolves: tdf#147496 No line feed for one single cell in clipboard Doc2Text()Eike Rathke
Change-Id: If6326bf414e1da43d846f952d88ceae37b2b9cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130109 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-17svtools: fix lost replacement non-rendered graphic when updating it failsMiklos Vajna
This is similar to commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4 (svtools: fix lost replacement grpahic when updating it via OLE fails, 2018-10-30), but that case was when we already had an old mpImpl->pGraphic, the updated failed and then we already lost the old one but didn't have a new one. Here what happened is that in case tools -> update -> update-all was used for an OLE object which had bad native data but a good preview, then the result was bad preview, depending on if you first scrolled to the OLE object to trigger rendering (good) or not (bad). The reason for this is that scrolling to the object calls GetGraphic(), which sets mpImpl->pGraphic using GetReplacement(bUpdate=false), which works, but svt::EmbeddedObjectRef::UpdateReplacement() calls GetReplacement(bUpdate=true). That explains why the update breaks the preview, but not when scrolling to it first. Fix the problem by improving svt::EmbeddedObjectRef::GetReplacement(): if getting an updated graphic fails, try to get a non-updated graphic. The result is that GetGraphic() after an UpdateReplacement() not only always return a non-nullptr Graphic, but also it's no longer of type None. Change-Id: I8e5ff4aaaefdc58e032b325bb4001f2a604ccc8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130086 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-17tdf#143148 Use pragma once instead of include guardspsidiumcode
Change-Id: I5a946c9db1b3ca91fa9d59d0d742c9b30782ed00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129978 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-02-17Revert "ODBC: fix signatures of Bulk, SpecialColumns et NativeSQL"Julien Nabet
This reverts partly commit 8942956e05f2208ffb666a2118f5db092c30ce6a. Reason, Lionel indicates: In general UnixODBC has to deal with more portability to more platforms, so I would tend to more follow their signatures than the ones of Microsoft, that has to deal with only Windows OS on less CPU ABIs. Change-Id: I8b8924d35aa86ac23a8191baa8584463941eddc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130084 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2022-02-17Bump Linux Clang baseline to 8.0.1Stephan Bergmann
...as discussed in the mail sub-thread starting at <https://lists.freedesktop.org/archives/libreoffice/2022-February/088476.html> "Also bump Linux Clang baseline to 12.0.1 (was: Bump --enable-compiler-plugins Clang baseline?)", and clean up newly-obsolete __clang_major__ checks Change-Id: Idacb9148b019c07e138277df3a085ba71c64a8e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130028 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17cid#1498146 silence Dereference after null checkCaolán McNamara
Change-Id: I55da3d7a2f1ccfa0c7120b6cff9ae95936f10e92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17tdf#147196: Fix crash in editeng when applying title case formatMichael Warner
Fixes a possiblity of crashing when applying title case format using the edit engine. Change-Id: I4f44f635a1c96b021c084bb5bb973180744e56e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129888 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-17fix range checking in calls like ScDocument::GetNote()Luboš Luňák
Change-Id: I5612e765b3484b0515f4a16030ee19133ae3126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130076 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-17fix range checking when parsing Calc cell address (tdf#147451)Luboš Luňák
The document contains 'Sheet1', which Calc first tried to parse as a normal address, since it matches the format of e.g. 'XFD1'. The code parsed column into SCCOL (sal_Int16), which with 16k column limit overflowed and the code failed to detect the problem. Change-Id: I470db1b670dbff7bdc8013bede0a0b011e88c372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130073 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-17Refetch in case SwTextNode::InsertItem causes it to be deletedCaolán McNamara
Change-Id: Ie189ae4d37ffc33e58bb405f2521d1ae02a9997b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-17ScriptForge - (L10N): add new arguments to the service creationJean-Pierre Ledure
Actual arguments: - FolderName: the folder containing the PO-files - Locale: in the form la-CO (language-COUNTRY) - Encoding: The character set that should be used New arguments introduced by this commit: - Locale2: fallback Locale to select if Locale po file does not exist - Encoding2: Encoding of the 2nd Locale file Both new arguments are optional => no regression on existing scripts The arguments are available in Basic and Python equally. They may be passed as keyworg arguments in Python only. The default locale is now set to the "OfficeLocale", which is the locale in the user interface. NB: the distinction between SystemLocale and OfficeLocale is new in version 7.4. Change-Id: Ie3bc5d30193df35a8c6c1ec706e13eaea0050981 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130074 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2022-02-17make DBG_UNHANDLED_EXCEPTION no-op if SAL_LOG_WARN is not enabledLuboš Luňák
ee0e19296b959b4545b094f49a8b0c0b5463 make the macro unconditional, but that means it calls both DbgUnhandledException() and DbgGetCaughtException(), and then log it as SAL_WARN that's a no-op. With the document from tdf#105036 it added ~13% CPU time. Change-Id: I9360169e6e3976d40271bc5602765e56f58971d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130069 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-17Revert "Resolves: tdf#147421 Do not use OUString::replaceAll() to strip ↵Mike Kaganski
null-bytes" This reverts commit 4b0c17609c2cca326bbcc9e8488a327a4a9ea952. Reason for revert: it's possible now to revert to previous simpler code after commit 4e4a01302a140d75a49055821b3197a2eda81db5 Related: tdf#147421: optimize O(U)String's replaceAll* Change-Id: Iaefac917afbc9c587e75c38457dd9ea87e4f5861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130017 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-17loplugin:unusedmethodsNoel Grandin
Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-17tdf#147398: sc_ucalc_formula: Add unittestXisco Fauli
Change-Id: I28c8a4614edf577e1f8f101ba55327fd9f358973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130068 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-05-22 15:33:33 +0000