summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-29Make the Modify button functional in the Customize dialogfeature/gsoc17-revamp-customize-dialogMuhammet Kara
By adding "rename", "change icon", "reset icon", and "restore default command" options to the Modify button at the bottom of the right (toolbar/menu entries) list. Change icon / Reset icon / Restore default command options are not supported in the menu/context menu tabs yet. Change-Id: Iade3d1aca722c7f8eddcadf251b9562c5366d8ad Reviewed-on: https://gerrit.libreoffice.org/41620 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-29Disable the individual reset button for the menubar menusMuhammet Kara
And: * Cut m_pDescriptionField's ties to the entries list on the right. * Disable Add and Remove buttons depending on current command selection * Display the description of the selected command Change-Id: I65a06f2f143c335f26de9007c6067f3116465c30 Reviewed-on: https://gerrit.libreoffice.org/41582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-25Make toolbar/menu addition/removal functional again in the Customize dialogMuhammet Kara
"+" and "-" buttons next to the menu/toolbar listbox can be used to add new toolbars/menus or remove existing toolbars/menus. Most of the code was borrowed from the previous implementation, and adapted to fit the current structure. Change-Id: I7e7f51a46251c2d010154f2a0bab3bb20280bf7c Reviewed-on: https://gerrit.libreoffice.org/41431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-24Implement "Reset" button in the Customize dialogMuhammet Kara
For now, it works for the Toolbar and the Context Menu tabs. Normal top-level menus cannot be reset individually at the moment because they are sharing a single xml file, and the removeSettings() mathod doesn't provide per-item removal from within a single file. Change-Id: I42d62dc26130e4c03cf75a1ce6dc9ff367a58d47 Reviewed-on: https://gerrit.libreoffice.org/41367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-22Add some exception messages to the removeSettings methodMuhammet Kara
in UIConfigurationManager and ModuleUIConfigurationManager Change-Id: I82c5369dc43dc8ccd9be62acaf327a39f3b4d68f Reviewed-on: https://gerrit.libreoffice.org/41403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3976f115ef539171e4b165c8d610ab7b49764f15) Reviewed-on: https://gerrit.libreoffice.org/41420 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-22Implement "Insert" button in the Customize dialogMuhammet Kara
Now the Insert button allows the user to insert separators to the toolbars, and separators and submenus to the menus and context menus. Change-Id: Ic520c78dee2152a0294e86d3bc7098a29155e4b9 Reviewed-on: https://gerrit.libreoffice.org/41360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-21Implement Search/Filter feature in the Customize dialogMuhammet Kara
Now commands in the list (left box) are filtered/updated in the Menu, Context Menu, and the Toolbar tabs as you type. Instead of filling the box, and then removing non-matching items (as in the current search feature in the keyboard tab), we filter out items during the Fill process, and don't add them to the sequence att all. This should give a performance boost to the filter operations. Change-Id: I473596a2c897f1cd96a7d55fd3ab11ee3db39863 Reviewed-on: https://gerrit.libreoffice.org/41321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-18Implement "Remove" button in the Customize dialogMuhammet Kara
By using the already implemented DeleteSelectedContent function. Now toolbar and menu/context menu items can be removed by using the "Remove" (Left Arrow) button which is between the commands list and the enrtries list boxes. Change-Id: If445ec6d431bc10263d961563bdd204e7868b931 Reviewed-on: https://gerrit.libreoffice.org/41272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-18Implement "Add" button in the Customize dialogMuhammet Kara
Now new commands can be added to Toolbars, Menus, and Context Menus by using the Add (right arrow) button which is between the commands list and the menu/toolbar entries list. Change-Id: I9c094a5142f82922c5e5bc3075a35442875a5fec Reviewed-on: https://gerrit.libreoffice.org/41240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-14Initialize and update command categories and functions for the Toolbar tabMuhammet Kara
Change-Id: I27a12fc9e337796fc153e1d243eeba37564ef5c1 Reviewed-on: https://gerrit.libreoffice.org/41104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-14Initialize and update Function list box properlyMuhammet Kara
* Add dispose methods to CommandCategortListBox * Cast the commands list to SfxConfigFunctionListBox * Update the glade catalog to include CommandCategoryListBox widget * Borrow and adapt FillFunctionsList method from SfxConfigGroupListBox * Create and setup proper SelectHDL(s) Now the command list box (Function box on the left) is properly populated and updated upon selection of a category from the categories list box. Implemented for the Menu and Context Menu tabs. Change-Id: I30ebe89e80bdb2c5b686a26acb7c1ab1178b7525 Reviewed-on: https://gerrit.libreoffice.org/40968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-11Remove useless if checkMuhammet Kara
And the return in the default case, which could cause the UI element to stop updating Change-Id: I29d35818b015f71890f615a02ea215034c048326 Reviewed-on: https://gerrit.libreoffice.org/41020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 114d3b369ae765ce106ffebfeac4498598b6c6b7) Reviewed-on: https://gerrit.libreoffice.org/41043 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-08-09Add custom widget class: CommandCategoryListBoxMuhammet Kara
It now lists all command categories which can be added based on the current module (writer, calc etc.) This class will be expanded later with macros and styles handling stuff. It will also update the commands listbox when it is added. Change-Id: I4f50408641db067118f63fe0e9a1ee755873412f Reviewed-on: https://gerrit.libreoffice.org/40833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-04Convert UI of Customize Dialog to the new designMuhammet Kara
* Elements of the old design have been removed from both the .ui file and the .cxx/.hxx files. * New elements for the new design have been added to the .ui file. * Menu, Toolbar and Context menu tabs now resemble the new design Change-Id: Ib602e0a4b9419d16adaa4ff6aa23b74097a3b88d Reviewed-on: https://gerrit.libreoffice.org/40468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-23rtl: cleanup equality conditions in uuid.cxxChris Sherlock
Change-Id: I8918cd97f9ab89f0a2f7f95cd59b706ca5a55e2b
2017-07-23rtl: cleanup uri.cxxChris Sherlock
Change-Id: Ic9ddcaa7c699830216e157bd9dfc09d30b50b3e6
2017-07-23rtl: cleanup rtl_process.cxxChris Sherlock
Change-Id: I8640da0d5f44d69b9b628ac2076aec50b8e62ceb
2017-07-23rtl: remove comments, cleanup equality conditions in random.cxxChris Sherlock
Change-Id: I915aafe5a0df39b19e1f5bdc701cb9175dabb5ed
2017-07-22Add new helper class to cui for SvxConfigPageMuhammet Kara
And kill the temporary namespace killmelater. This class will contain helper functions/methods for use of the tab pages of the Customize Dialog. Change-Id: I63a05c9495a79009ed5b47f7790a46cff9f58c6a Reviewed-on: https://gerrit.libreoffice.org/39617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-on: https://gerrit.libreoffice.org/40308
2017-07-22osl: Windows pipe converted from OSL_ASSERT to assert/SAL_WARNsChris Sherlock
Explanation for each conversion: - osl_acceptPipe() - don't worry about an invalid oslPipe sent as function parameter, we check for the error returned by ConnectNamedPipe(), and without a valid pipe we just need to return nullptr - warn if INVALID_HANDLE_VALUE for the file handle, should be handled by ConnectNamedPipe() - createPipeImpl() allocates and initializes memory for the oslPipeImpl structure, if it can't do this then something has been done wrongly - osl_receivePipe() - invalid pipe needs to assert because ResetEvent needs valid pPipe->m_ReadEvent - osl_sendPipe() - invalid pipe needs to assert because ResetEvent needs valid pPipe->m_ReadEvent - osl_writePipe() - really just a thin wrapper around osl_sendPipe() - osl_readPipe() - really just a thin wrapper around osl_receivePipe() Change-Id: I581f8aa996375a8691eafaa384d3f63f0c92b0a2 Reviewed-on: https://gerrit.libreoffice.org/40262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-22Revert because of wrong banner sizeHeiko Tietze
Change-Id: I1f827d373d52e89989e4e7f1e9d4333cba5dbb78 Reviewed-on: https://gerrit.libreoffice.org/40315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-23rtl: cleanup equality conditions in math.cxxChris Sherlock
Change-Id: I13d898479d883f7905d834c82dc778a9e4078375
2017-07-23rtl: cleanup equality conditions in locale.cxxChris Sherlock
Change-Id: I25833b65f89cc24ec2b62d4836f6c7c230c418aa
2017-07-23rtl: remove comment cruft from locale.cxxChris Sherlock
Change-Id: I0db5f31a85e03a0f262f22977dfd7a98090839c7
2017-07-23rtl: cleanup equality conditions in hash.cxxChris Sherlock
Change-Id: I163e1018009d4da49a15457e2cd2f433fd069a73
2017-07-23rtl: fix equality conditions in crc.cxx and digest.cxxChris Sherlock
Change-Id: I3408c2800a5cc41026e5fec8ef99c408e64d69ea
2017-07-23rtl: cleanup cipher.cxx equality conditionsChris Sherlock
Change-Id: I0b8084adea65f8c6a6e5e46b6628297fbd9eda9b
2017-07-23rtl: remove comment cruft from cipher.cxxChris Sherlock
Change-Id: I65d394d2947246b9919e072b06888dd744ef13f0
2017-07-23followup b714ba73c - remove excessive bracesChris Sherlock
Change-Id: I59fe131c6d14d9058fedaf89a2e9d5ceca444aa5
2017-07-22osl: (Win32) check allocated pipe succeeded, otherwise needs to failChris Sherlock
Change-Id: I0e508de4215d92700a9134e422a7b9370f387aea Reviewed-on: https://gerrit.libreoffice.org/40300 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-22tdf#109271: Use ScopedVclPtrJulien Nabet
so disposeAndClear is called See https://bug-attachments.documentfoundation.org/attachment.cgi?id=134781 Change-Id: I5d9a3c4ddc73b303a36643a7d1111d8cc7da7006 Reviewed-on: https://gerrit.libreoffice.org/40306 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22rtl: fix bootstrap formatting, comparison to nullptrChris Sherlock
Change-Id: I8d00e616a56cc3edac6ba2149fd6f9ae44c23a95
2017-07-22rtl: remove comparisons against nullptr from RTL mem filesChris Sherlock
Change-Id: Ic0ae0378d5b46b3d11c99aef2e845796ad0a9c71
2017-07-22rtl: remove comment cruft from alloc filesChris Sherlock
Change-Id: Ibac120af6879739091aacefef5c773649e222f85
2017-07-22Cleanup duplicate functions in cfg.cxxMuhammet Kara
And move all helper functions to the temporary namespace killmelater Change-Id: If74102209a05b8d28c96d51a623ac14c1700630c Reviewed-on: https://gerrit.libreoffice.org/39404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-on: https://gerrit.libreoffice.org/40302 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-07-22Typo: "disposeAndClear", not "clearAndDispose"Julien Nabet
Change-Id: I9f7f30fce9324f7ccb79e9a8ef0c13e091d7c3a3 Reviewed-on: https://gerrit.libreoffice.org/40304 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in basctl..connectivityNoel Grandin
Change-Id: I2f10daadb84e48eaf96f6cc63899b2f4fce7326e Reviewed-on: https://gerrit.libreoffice.org/40295 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in cppcanvas..cuiNoel Grandin
Change-Id: I1cf1f7919e03d863c6f7756e1caf3b9313777479 Reviewed-on: https://gerrit.libreoffice.org/40294 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22add test for CJK (~X) mnemonicsCaolán McNamara
Change-Id: I1f69c23dcde6d963ad9c3bc1f2d9178fe15eb27c
2017-07-22tweak test a littleCaolán McNamara
Change-Id: I6b9aeaf03716496dc2c6dfcc88688891f57fb0c7
2017-07-22osl: get rid of comment cruft in w32/time.cxxChris Sherlock
Change-Id: Ief31a90cb0d14ac396be4d11719f8deb136b081d
2017-07-22osl: get rid of comment cruft in w32/sockimpl.hxxChris Sherlock
Change-Id: Iab2ac765435113b8776be6b6a632e21385b02fae
2017-07-22osl: get rid of comment cruft in w32/socket.cxxChris Sherlock
Change-Id: Ide9debe3e1029646b01ba7698e2c613ba0040bed
2017-07-22osl: get rid of comment cruft in w32/security.cxxChris Sherlock
Change-Id: Ifd3ba56ad420985e646162041682e4872a13258d
2017-07-22osl: remove sig in commentChris Sherlock
Change-Id: I7e02e463105cf65fcc47ce5e3d5f9476ff778cce
2017-07-22osl: remove dead code from w32/salinit.cxxChris Sherlock
Change-Id: I895c0bb5f9d2d072ab6aa7a6aabb22449287283a
2017-07-22osl: get rid of comment cruft in w32 profile.cxxChris Sherlock
Change-Id: If85f1a6d436e894b27a2fcb10a8d44e56e193fff
2017-07-22osl: small cosmetic change to make comment more readableChris Sherlock
Change-Id: I5be685355b0c3180bbf23a421c66c086f05834fa
2017-07-22osl: get rid of comment cruft in w32 path_helper.hxxChris Sherlock
Change-Id: Iaa6160c21281153041fda38ed99f94419f1e9e0d
2017-07-22osl: get rid of comment cruft in w32 path_helper.cxxChris Sherlock
Change-Id: I111c8b4e39fc9f1dd894979ff6fb5e98659182d1
generated by cgit (git 2.34.1) at 2024-05-04 12:06:22 +0000