summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-28Todys work, actully working correctlyfeature/scaling-geometry-providerJan-Marek Glogowski
2022-04-28Yesterdays work, more realJan-Marek Glogowski
2022-04-28Yesterdays workJan-Marek Glogowski
2022-04-28More workJan-Marek Glogowski
2022-04-27More work on per-window native scalingJan-Marek Glogowski
2022-04-27more workJan-Marek Glogowski
2022-04-27Add branch info to README.mdJan-Marek Glogowski
Change-Id: I94e48d767e2717bef55195e81ff6938fd2b746be
2022-04-27more workJan-Marek Glogowski
2022-04-27SalGeometryProvider base for scalingJan-Marek Glogowski
2022-04-27reenable this test on macCaolán McNamara
now that the fonts are not substituted Change-Id: Ib9df279cfd296eabf4e25bc3ff2458c66f14ffb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-27remove static bufferCaolán McNamara
Change-Id: I77ebc45000e09d1553c8e63402f30e720852c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-27use Bitstream Vera Sans for consistent results with LIBREOFFICE-UXTSOREL.rtfCaolán McNamara
instead of Palatino Linotype which will typically get substituted Change-Id: I80c597c7fc807fef334c6edb160dfddf9214d7cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133460 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-27tdf#131760 change category of Styles commandSeth Chaiklin
"Format" -> "View" Change-Id: Ia702a28fd7eacf52bf02964e9dad7a3b69390241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133413 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-27CppunitTest_sw_ooxmlexport10: avoid mustTestImportOf()Miklos Vajna
Can use CPPUNIT_TEST_FIXTURE() instead. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I9006306f0522d08ed47bd26e2a808acdc560f12c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133457 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-27android: Slightly clean up style of LOKitTileProvider#resetPartsMichael Weghorn
* Reduce scope of the `parts` variable to the if block * add an emptly line before the next method Change-Id: I22389cb4c9307f6888c4ed836056caf23ce84da6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133450 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-27android: Reuse existing LOKitTileProvider#resetPartsMichael Weghorn
... instead of duplicating what it does in `LOKitTileProvider#postLoad`. Change-Id: I0ed3d77d9f9651efec764eafeaa3f71576abcf6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133449 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-27android: Leave part names starting with "Sheet" etc. intactMichael Weghorn
It's unexpected that opening a Calc sheet with two tables called "Sheet foobar" and "Sheet 10" would result in the sheets showing up as "Sheet 1" and "Sheet 2" in the parts view instead of their real names. Therefore, leave the original names intact and show them instead of generating new generic names. The change to rename such sheets (and similar parts) has been added in commit 1239dce2595877ad64fd8c8fd927ea4285d69abe Date: Thu Nov 1 22:03:31 2018 +0300 [Pardus] language improvements on Android More hardcoded strings extrated to the resource file Few Turkish language improvements This patch is sponsored by ULAKBIM/Pardus project. where the intention seems to have been to have a localized name for the parts show up. That still happens when the part name is empty (s. lines above), but I think that explicit names should remain as they are, as e.g. also happens for Calc sheets in the desktop version of LibreOffice. Change-Id: I3073babf99a6b2309be2107141bba92236eba76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133448 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-27tdf#148515: RTF filter: do not use char prop defaults for tablesVasily Melenchuk
During deduplication of table row (when nStyleType == 0) we should not deduplicate character properties against default style: this leads to invalid default settings for table rows/cells. Attempts to do so are already made during \pard processing when default style is checked if it is paragraph style. But this is not enough: style definition can contain paragraph and character properties as well. Change-Id: If520c5a248897728b7de08a017136ca1a01a5f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132943 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-04-27Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f6d93aeda80f5a1f24e6fd162c43143a0373add3 - (related tdf#140818) update to "no character style" in help Change-Id: I7e5e09118ec985286cb6a9b8c15dedd17734bd6e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133474 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2022-04-26tdf#131760 change category of Load StylesSeth Chaiklin
Change-Id: I9d27c1a829991232f09486a6fd9cdd1625b03a91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133147 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-26tdf#148732 Change label, add tooltip for .uno:DefaultCharStyleSeth Chaiklin
tdf#140818 changed the label "Default Character Style" to "No Character Style". The changed label appeared in the Styles sidebar, but the menu command that appears in the Styles menu for Writer was not changed. The present patch rectifies that oversight by changing the menu/toolbar label and adds a tooltip for this command. Change-Id: I4a82dc0626702c7282d3022d2f4e45eb6b33b373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133401 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-04-26ofz#47042 previous use of static variable affecting later runsCaolán McNamara
Change-Id: I64fb184e43fb025798781c85c9a0a8e0354b21b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Fix typoAndrea Gelmini
Change-Id: Ic11575e553bfe7177a0bff6b7f5557213fb1930e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133447 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-04-26add o3tl::toUInt32Noel Grandin
Change-Id: I07f11bf12fbe1d1c2d812fa0965d6e632e1e1aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-26DOCX export: image deduplication and clean upTünde Tóth
Follow-up to commit aea8043bc5f5187498fa450505d6de9d6986e2a6 "tdf#74670 tdf#91286 PPTX XLSX export: save image once". This reverts commit 797fef38612fb2fd62d1f6591619b9361e526bca "tdf#118535 DOCX export: save header image once" and commit 32ada80a9f47b095d7b0c4d16e3422f6ef7f2ac2 "DOCX export: make sure a graphic is only written once" and commit b484e9814c66d8d51cea974390963a6944bc9d73 "tdf#83227 oox: reuse RelId in DML/VML export for the same graphic". Change-Id: I2d90249808174290b6b3e4eb957b3ac87ad41f95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132506 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-04-26tdf#148791 tdf#64902 tdf#127759 sw: fix row insert/pasteLászló Németh
Table insertion mode and Paste as Rows Above inserted only a single row above, and overwrite the next ones in the following cases (instead of inserting/pasting rows above according to the clipboard table content): The table stored in the clipboard – has centered, right or not paragraph starting alignment; – or its resource table has a table header with 2 or more repeating rows, and the clipboard content contains the same amount or less rows (it doesn't matter, that the copied rows weren't header rows originally). The reason was that parsing of the HTML clipboard content which is used for counting the row count of the clipboard content hadn't handle the following cases: – different table aligment results <tr> elements with greater indentation level in the HTML extract, according to the new root element <center>, <div> or <dl>; – copying rows from a table with row header always starts with <thead> in the HTML extract, i.e. detecting <tbody> can fail, because there could be only <thead> in the HTML extract (see Case 2 above). Follow-up to commit 0c8b1efbad48fa9697c0b1afbe4753bbbc3c4c5c "tdf#127759 Writer: add table row/column insert mode" and commit 7efae60f3625a58f8a617c80f2a55a695fbaef36 "tdf#64902 Writer table: Paste Special->Rows Above". Change-Id: I466cea20705bc5dd5455e22842da7dfa6631ba81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133445 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-04-26tdf#53970 PPTX: fix import of linked media filesTünde Tóth
Linked media files were imported as images in documents created with Impress after PPTX export. Change-Id: If4920c2e40f45fff73eca4a5fa987d524177597e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132635 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-04-26tdf#140272 gtk3: fix crash with dnd using touchCaolán McNamara
gdk_wayland_drag_context_manage_dnd needs gdk_device_window_at_position(device, ...) to succeed similar to the problem of https://gitlab.gnome.org/GNOME/gtk/-/issues/1080 Change-Id: I2e1956b40a622b1d74d3aef3b5fac654fc1256eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Improve some signed vs. unsigned comparisonsStephan Bergmann
p2-fwd will always be non-negative Change-Id: I143d7fd3c5ec192ffaeb56bc2e9f45ac5e83cb6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133439 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26Use o3tl::make_unsigned in some placesStephan Bergmann
...where a signed and an unsigned value are compared, and the signed value has just been proven to be non-negative here Change-Id: I9665e6c2c4c5557f2d4cf1bb646f9fffc7bd7d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133442 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26sw: fix double-click opening frame dialog, not graphic dialog on imagesMiklos Vajna
The user-visible problem was that once a user clicks on an image a lot (e.g. 5 times), then the slot ID dispatched on double-click in SwEditWin::MouseButtonDown() is no longer FN_FORMAT_GRAFIC_DLG, but it's FN_FORMAT_FRAME_DLG. This is already inconsistent, but it's especially problematic in case an UNO client intercepts only the first UNO command, but not the second one. The other inconsistency is that in practice this only happens for as-char images, at-char anchored images work fine. The reason for this seems to be how we get the doc model position for a twips view point. At-char anchored images are handled at lcl_GetModelPositionForViewPoint_Objects(), and there we return the SwGrfNode in case the view point is inside the frame of the matching fly frame. SwTextCursor::GetModelPositionForViewPoint() restricted the same to as-char fly frames which have text or layout frame children. Fix the problem by allowing non-text frame children for as-char images. Change-Id: If08e7dd2a72f46ebcfb8c6ddf110703eaeb7df6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133443 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-26tdf#125931: Add Elements deck and Elements panel to Math's sidebarMike Kaganski
Change-Id: Ie04a5dc48de38f318f0ddb42efc42cea022dc62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-26tdf#125931: Enable sidebar in MathMike Kaganski
No panels yet, only one default deck (PropertyDeck). It is needed to have the uniform default deck like in all other modules (see commit c09f59eb6173a4a53a2d40ed80aebed18e3882ac); the panels for formula properties might appear later. Change-Id: If1785dc780111fe496638418f43e7b90a250ffce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-26Pick better variable typesStephan Bergmann
Change-Id: Ia4ba19744e23c20d9b6fb0e9d803bc00b415191f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133441 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26Pick better variable typesStephan Bergmann
Change-Id: I134a8cddba169fe9bcc04687ad15c2cfeaccfb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133440 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26ofz#46901 TimeoutCaolán McNamara
Change-Id: I458ddb6ee4d7023f60c8d1c26699bbd74502ddc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Adapt function's interface to change from OUString to std::u16string_viewStephan Bergmann
...in 6fc3dfd3f1b5cb13101299df42444f2ff0493846 "use more string_view" Change-Id: Ibd1b8748e7a261cdb457a14ba87b1ec68d2a83de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133438 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-26Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to c2b26d58f520fa40a8c64fb7d0217c578a1dd135 - update translations for master Change-Id: I6c6fcd88b8e746f36dc784e6c0ccb3b16c81dbeb
2022-04-26android: Use 'if' instead of switch-cases with just 1 caseMichael Weghorn
... which IMHO makes this a bit more readable. Change-Id: Ica1d9416f711e75e6d6c23963ca64d13e08c138e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133428 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-26android: Drop redundant check for SDK version <= 11Michael Weghorn
minSdkVersion is 16. Change-Id: I1082cc5abd7ecc02211509e57fd41c97cf706e8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133427 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-26ofz#47029 TimeoutCaolán McNamara
Change-Id: I0fe3a01b237eb142b9e156fc886144f48f8ede18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133436 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26cid#1504074 silence Improper use of negative valueCaolán McNamara
Change-Id: I4580d4cce8a53f2b1faf0738d08509d2730868df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Translatable string improvements I push so they don’t rot in my local cloneAdolfo Jayme Barrientos
Change-Id: Ic057769718790ced80daf24510d27aad49e3341b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132975 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-04-26use a std::vector hereCaolán McNamara
Change-Id: Ic5ad467bc6f1f8537d17be4bec3a92be947239a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26unnecessary dtorCaolán McNamara
Change-Id: Ia2a5cf38930e394c4aecdd83fb18fc2a212df067 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-26Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 79333af5db2af7c4532e8fffbebfe8ba7daa80c4 - list toolbars in alphabetical order in Contents menu Change-Id: I13f64d384b51f02a73c3e0bb321caa9df9fef4ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133289 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-26revert unnecessary changeNoel Grandin
from commit 25ada1e520b50247aa27fdbb6f1ab35e678c7ef9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Apr 21 13:59:07 2022 +0200 use more string_view in cppuhelper Change-Id: Ie5bd9226dca0f222edd0798b8b478054eda5162c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133430 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-26sw content controls, checkbox: toggle the checkbox on clickMiklos Vajna
Implement this by selecting the content control's text (similar to placeholders), then replacing the selection with the content control's relevant state. Change-Id: I280ce45822fe3fd9615511a9a62d23dc230aa275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133424 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-26tdf#148751 Enable Text toolbar by default in DrawRafael Lima
The "Text" toolbar is not visible in the View - Toolbars menu, however it is accessible via Tools - Customize - Toolbars. As per user request in the bug report, I am setting this toolbar as visible in the default configuration. Change-Id: I1d2249925f24158758bd9f439634191d67ad38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133395 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-26cid#1504268 Silence false data race condition warningStephan Bergmann
Change-Id: I058a0f9d2e3c7434b5dc742c82067cb97c6102d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133425 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>