summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-01-05cosmetic changesfeature/unitverBenjamin Ni
Change-Id: I6826a23655c9556dac2be49a8f28d67e95e91ff2 Reviewed-on: https://gerrit.libreoffice.org/17582 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-10-21unit-verification: more convert Link<> to typedAndrzej Hunt
Change-Id: I8f330dbfb3b5a0a7409475a5a8802c3640e6bb31
2015-10-21ScreenSaverInhibitor: Don't depend on glib type definitionsAndrzej Hunt
We also include this header from the kde and tde backends, it seems to be saner just to use the base definitions of these types rather than depending on glib there. Change-Id: Ib270fd33290f9c213dea72a8e20618007470d882
2015-10-21Ignore the default constructor for loplugin:badvectorinit tooAndrzej Hunt
The default constructor doesn't necessarily have 0 parameters, hence we need to explicitly test for this too. Change-Id: I685c44ab373ec8234a86824a77cc523a355c8b05
2015-10-21Make incompatible-output-box visible to ensure layout spaceAndrzej Hunt
If the incompatible-output warning is not visible when the dialog is loaded, it receives no space in the layout - this then looks ugly when this warning is enabled (as it overlaps the OK/Cancel buttons). We already set the boxes visibility again on startup, hence we then hide the box as needed at that time. Change-Id: I61c9ce463ad80aaec08ae680aa3ad1535c33d9c5
2015-10-21Set default focus on output unit entry boxAndrzej Hunt
This allows the user to immediately enter their desired unit - the input area selection is likely to be used only rarely. Change-Id: I08de7718ed183db21513d1f46f346da27c3ebbf7
2015-10-21unit-verification: convert Link<> to typedAndrzej Hunt
(fix build after rebasing on master) Change-Id: Iecbdbf5a854de0b552f6c9074e72da3fa47d91a4
2015-10-21loplugin:vclwidgetsAndrzej Hunt
Change-Id: I8edbf71d961067ee565954cbb91ee9e503e3077d
2015-10-21Implement undoing conversion of individual locally annotated cellsAndrzej Hunt
Change-Id: I16b62f1105f7839b047a96fdab0e3e6089d400ee
2015-10-21Remove redundant parameters.Andrzej Hunt
Change-Id: I0230fdd69d4f60058ca4f0258c5098f77099a3e4
2015-10-21Test for tdf#92455 (persist purely local annotations after conversion)Andrzej Hunt
Change-Id: I3f0ed297ef4eb9ac7876a9e24e3c2f0c1ec0b521
2015-10-21Added checkbox and config option to toggle unit verificationBenjamin Ni
Change-Id: Ie218821d05466b77ed42a26365b04a6798dec067
2015-10-20tdf#92455 - inconsistent unit handlingBenjamin Ni
Change-Id: Ifbb85a32ef9d84199d17cedd28fa0f9e66eabf66
2015-10-20Coding style cleanupBenjamin Ni
Change-Id: I6171ba59e4df40dfc4734204832857f0fe7637e9 Reviewed-on: https://gerrit.libreoffice.org/16738 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-10-20Added more range conversion testsBenjamin Ni
Change-Id: If4898e6c70cb9731af35d51457de28410f808b96
2015-10-20refresh cell rendering after changing unitMarkus Mohrhard
Change-Id: I6f68c319df89906b29d1f8409f6170a0b68c8b87
2015-10-20add test case for unit conversionMarkus Mohrhard
Change-Id: I726758c93b25ed16b5708a71645004537f32ac76
2015-10-20fix crash when converting unitsMarkus Mohrhard
Change-Id: Ic883e13b5c6923c31e65a887597f0910807dc94d
2015-10-20fix build and adapt a few places to calc coding styleMarkus Mohrhard
Change-Id: I9759b96f7ba53c6737ea1576f16d6b46ad5f472b
2015-10-20WIP: udunits2 build on windowsAndrzej Hunt
It now builds, but only produces a static library. libtool (which udunits2 uses for building) doesn't like the inclusion of expat as a static library and refuses to build a dll - I still need to investigate more. Change-Id: Id4ef089fa9ecbf5cac109bf164b3b3278ba74912
2015-10-20Upgrade to udunits 2.2.19Andrzej Hunt
This has some fixes that should help the windows build Change-Id: I71b17ee74d5d3a9b7c0eed4805fc0136b8db0607
2015-10-20Fix udunits2 install_name on OSXAndrzej Hunt
Change-Id: I048d23d647a6d6f38efddc11f7d3bde3b583e752
2015-10-20Don't assert on unsupported opcode, return unknown insteadAndrzej Hunt
We should eventually support all opcodes, but crashing* isn't really the correct response if not. *or continuing with completely wrong behvaiour in non-debug builds. Change-Id: I22d7746f4e809bdc3da62b8b6f741216504b3f22
2015-10-20Enable --with-system-udunits2Andrzej Hunt
We also have to move udunits2 headers to match the default system installation location of ududnits2/udunits2.h (whereas udunits2 bundled build puts the headers in lib/udunits2.h by default). Change-Id: I1d314f6b3e016f90cfb8e19a143bb77ae98e7734
2015-10-20Enable udunits2 on OSXAndrzej Hunt
My original guess of library was wrong, other than that no special treatment is needed for the OSX build. Change-Id: I2a697c65a6e272bfa3f8070a85b4bbd8b01b5e23
2015-10-20Rename VERIFIED->VALID for formula status.Andrzej Hunt
Change-Id: I93a07e11546ebecf912449c72e57404731c346e9
2015-10-20Kill unnecessary UnitsStatusAndrzej Hunt
Is redundant now that we've got the public FormulaStatus. FormulaStatus adds two new variants that we don't need internally however they are only relevant in one location hence it makes sense to share the enum. Change-Id: Idb08a41574e56a2f994c7e8bc816ffd370d86766
2015-10-20Fix building with disabled unit verification.Andrzej Hunt
Change-Id: I78633082a0e0dfcaa27515ce8d9c8635e50735e9
2015-10-20Remove unnecessary autoreconfAndrzej Hunt
I'm not sure why this was ever necessary, and it seems to break building on OSX. Change-Id: I51a9e163d0066d974c190f191c68be0a2e8d9a46
2015-10-20Don't require use of makeinfo for udunits2Andrzej Hunt
The only way I could find of building _just_ the library, without the extraneous (for our purposes) documentation/packaging, seems to be calling this target. Change-Id: I6469754752c322b2060f09705daa387bb463f906
2015-10-20Show whether error is in formula or output in units warningAndrzej Hunt
Change-Id: Ib21462b3d67bb9b960c0d37384cdcef5003a884e
2015-10-20Add tests for output unit verification.Andrzej Hunt
Change-Id: Ia273a64fdbb5e1fe57f41679e9d77e0df78987de
2015-10-20Return status for formula errorsAndrzej Hunt
Returning a status (instead of a boolean) means we will be able to print better error messages for the user in future. Change-Id: I0b08913267fedb5735112acc7427156e07e32b31
2015-10-20Invalid formulas can't have unit correctness verified.Andrzej Hunt
Formulas that can't be processed will already be treated as invalid, we shouldn't additionally complain about unit verification in this case. Change-Id: I0556bf76b6e2343cdf27ec53669e6fd78da9280b
2015-10-20Implement units conversion dialog.Andrzej Hunt
Change-Id: Iea99d0c86de970e185bfc03e548be47f5235be5f
2015-10-20Add Units::isValidUnitAndrzej Hunt
Change-Id: Ibb9c6e0d713ceeaa4fc4c67467d76da2f6183502
2015-10-20Use GetParamCount instead of GetByte.Andrzej Hunt
Change-Id: I8f49d198c2e49246a28839a77c37563e9a8b19a5
2015-10-20Update units error messsage for clarity.Andrzej Hunt
Change-Id: Ib59b2317f962d01bcc65a981040c3452cee7206e
2015-10-20Convert convertCellUnits to handle rangesAndrzej Hunt
Change-Id: Ibe95cbd9ea9efd08a48e0651f469434802bfa40e
2015-10-20Split convertCellUnits and change contractAndrzej Hunt
This is in preparation for rewriting convertCellUnits to handle ScRangeList's. Change-Id: I17fecdb64674af79a33f2b1a62b4b46150177af5
2015-10-20Make more methods of UtUnit constAndrzej Hunt
Change-Id: I652a77ad3bf547788bf6d566fdeaac525effb541
2015-10-20Implement getUnitsForRangeAndrzej Hunt
This will be useful for e.g. the units conversion dialog. Change-Id: I36391e9aeab5689bfde1d1865549cc2e136a4812
2015-10-20Store original input string for UtUnitAndrzej Hunt
String->UtUnit isn't necessarily reversible, hence we should store the original input too in case it is needed by the user. Change-Id: I8794a1544a9c996da574ee753d95b44f067e819f
2015-10-20Return invalid unit for empty and string cells.Andrzej Hunt
Change-Id: I6dbec9be643040f9fc567e6065f860a3985f138a
2015-10-20Implement areUnitsCompatible API methodAndrzej Hunt
We need this for the conversion dialog, where it's probably better if we can avoid directly fiddling with UtUnits. Change-Id: I090e59c49f3b77ffcc0571838023165c2da931a0
2015-10-20Add setNumberFormatUnit utility method to units testAndrzej Hunt
Should simplify writing further tests. Change-Id: Idf991d12d0731d531f7e7c84e1ebe10b76d82b7a
2015-10-20Use HeaderUnitDescriptor to pass around header specificsAndrzej Hunt
Change-Id: I7c74211236b00c570941fda39cb0d69c1ce4e02c
2015-10-20Implement unit conversion for ranges.Andrzej Hunt
Not entirely finished yet, some further refactoring needed elsewhere to allow sensible implementation of the header editing. Change-Id: I81af74d698098f901b17fcda413e7aac04c94274
2015-10-20Use the actual default format for value/unit splitting.Andrzej Hunt
Change-Id: I1da34b43d273d1ae2f91591aafcfab8adf9a4f02
2015-10-20Add some assertions for UtUnit::convertValueToAndrzej Hunt
Change-Id: Ie606bbb3cab0b4445274b8bf92f8b1533b39c9fd