summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-11-18tdf#157716 - Rename "Language settings" to "Languages and Locales"t-aswath
Change-Id: Idd31b18c87998b03d884e7aa17197c459241abf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159315 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-11-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7137f1de0c227bb33997436ec5e64bea05d1b6b5 - Fix HTML page title Change-Id: I8241c7a36fb419c687bc950b23d7bc6b736522b0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159580 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-11-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to efd47e8d208604d311f39ebddb5f51a1dc46d6e0 - Remove dup bookmark Change-Id: Iebd95831283404b2673b0c4ee15b53bdab9b716f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159579 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-11-18Latest VS 2022 Preview is 17.9.0 nowTaichi Haradaguchi
...while latest proper VS 2022 is 17.8.0 Change-Id: I40905f3d79c3723796c4c9964f72d0fed73795c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159607 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-11-18Related tdf#49895: Mark strings as translatableTaichi Haradaguchi
...and add context strings Change-Id: I2531fc9e24db7e99b440b8042b8a502a2faaa2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159567 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-11-17cool#6893 pre-init dictionary listNoel Grandin
so the forked processes don't need to Change-Id: Id37688ac88c14679e216cca744563ee75c7c4736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-17sd: remote: check that received commands have expected argumentsMichael Stahl
Change-Id: If4b5fe0362a40d14d68829bffb79f91ae9745835 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159590 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-17tdf#158135 - UI: Part 30 - Unify lockdown behavior of Options dialogBalazs Varga
for Writer - Compatibility Page. Change-Id: Id9ad445b451b332314f72f54e183730097584a74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159513 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-17tdf#33201 Highlight current row and column in spreadsheetSahil Gautam
Highlighting functions added Change-Id: I65335538e394d048731c13ac87535502ea97dfa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158680 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-17createmsi: retrieve file handle explicitely so we can close it at the endJulien Nabet
Seen on https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_win_wix/3/console [build PRL] CustomTarget/instsetoo_native/install/install.phony Exception ignored in: <_io.FileIO name='lo.json' mode='rb' closefd=True> Traceback (most recent call last): File "C:\cygwin64\home\tdf\jenkins\daily_workspace\tb\src_master\msicreator\createmsi.py", line 42, in __init__ jsondata = json.load(open(jsonfile, 'rb')) ResourceWarning: unclosed file <_io.BufferedReader name='lo.json'> Change-Id: I98b7436e4e870f4cbcd31a41a4e9d0e84249f5f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159566 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-17Don't reuse --unit values across (sequential, even) systemd-run invocationsStephan Bergmann
At least some old versions of systemd-run apparently have occasional issues when sequential invocations reuse the same --unit value, as <https://ci.libreoffice.org/job/lo_ubsan/2982/> now (i.e., after the machine was updated to auto-detect --with-coredumpctl) failed with > [build CUT] basctl_dialogs_test > LO_TEST_LOCALE=de > Running scope as unit: -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope [...] > LO_TEST_LOCALE=en-US > Running scope as unit: -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope [...] > LO_TEST_LOCALE=fi > Failed to start transient scope unit: Unit -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope already exists. Change-Id: If009e26231228bec739637e4140be90c0b86d6b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159569 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-17android: Update app-specific/MIME type iconsMichael Weghorn
Just as commit 2105f638fa178f49210116bd914889599930b62a Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Nov 17 09:11:42 2023 +0100 android: Update app icon to new startcenter icon updated the main icon for the Android app, also update the MIME type icons that are shown in the "Recent files" section in LibreOfficeUIActivity to the new ones meant to be used for Calc/Draw/Impress/Writer since 7.5. Change-Id: I1d969a290caa3c23589e78151cd5bf70144c3099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-17Add getUnicodeTokenName() to StaticTokenMap and use...Regina Henschel
it in several places. Currently these places get a Sequence<sal_Int8> by call of StaticTokenMap().getUtf8TokenName() and immediately after that generate an OUString from it using reinterpret_cast<const char*> and the OUString ctor with 8-Bit character buffer array. The patch moves this conversion to StaticTokenMap. Change-Id: Ia2af110e2a0f1708e0685115d325c1c12cab3857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159514 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-11-17tdf#154543 - Paragraph dialog: reset snap to grid to parent settingAndreas Heinisch
Added the SID_ATTR_PARA_SNAPTOGRID to the alignment ranges in order to reset the snap to grid option to the corresponding parent setting. Without this parameter, the main dialog does not have any knowledge about this option. Change-Id: Ib090fae0919be54dd41674d129f5355c3566a90c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159565 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-11-17Simplify a bitMike Kaganski
Change-Id: I41ed6256a5933aaadd385bdf9b9aa8469aa71187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159575 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-17android: Update app icon to new startcenter iconMichael Weghorn
Update the icon used for LibreOffice Viewer with the new icon used since LibreOffice 7.5 [1]. Use the startcenter icon from `sysui/desktop/icons/hicolor/` and export for the required resolutions where it doesn't exist yet. [1] https://wiki.documentfoundation.org/ReleaseNotes/7.5#Design Change-Id: Ie9f59d42bbc9375e7ca433c6452223b7ba3033a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159554 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-17android: Reuse launcher icon in activitiesMichael Weghorn
Instead of duplicating the icon as drawable, just use the one from the mipmap folder that's used for the app launcher. Change-Id: Idd6691c4639fb570357280cec63636d07fe06b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159553 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-17we can have just one LoadURL for writerCaolán McNamara
Change-Id: Ia0162ee1c275292fcf200bad4662e4c2c6b7b972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159557 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-17sw floattable, delete UI: add an uno command to unfloat frame from context menuMiklos Vajna
Word has an easy UI to turn floating tables into inline ones. Writer had a similar button, but that had a few shortcomings: 1) It was only visible if a non-split frame was too large to fit the page. 2) It was a separate VCL widget, so invisible to LOK clients. 3) It only worked for frames which had a single table in them. Researching the problem, it's interesting how deleting a frame always deletes its content as well, but e.g. deleting a section just removes the container but leaves the content in the body text. Fix the problem by adding a new menu item in the context menu that always allows converting the frame to inline content at the anchor point. This can share a bit of code with the old unfloat button. The undo/redo still needs fixing, in a follow-up change. Change-Id: I8ce05c9f958b08cb599fd5d2a27e770182f28cc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159550 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-11-17Missing parenthesisStephan Bergmann
...from e514f1a462f5fe2d1ef2d58fa3a0ef94892c41fb "fix --enable-wix switch - that didn't do anything" Change-Id: I4d8124152d5dcb97a11d6fced071ac428ac09bb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-17tdf#119908 sw smart justify: add unit testLászló Németh
Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb "tdf#119908 sw smart justify: fix justification by shrinking". Change-Id: I88cc7876c06729f81b9d61fed7456be801dc6373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159525 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-11-17sw: fix layout crash in SwObjectFormatterTextFrame::DoFormatObj()Michael Stahl
Since commit 15b886f460919ea3dce425a621dc017c2992a96b this is happening in testForcepoint93, but only on WNT. The crash is in SwObjectFormatterTextFrame::DoFormatObj() calling SwObjectFormatterTextFrame::InvalidateFollowObjs() and the mrPageFrame has been deleted; there is also the m_bAgain flag set in the SwLayAction up the stack, but the SwObjectFormatter::mpLayAction is null so DoFormatObj() cannot check this condition. In the caller CalcContent(), get the SwLayAction from the SwViewShell and pass it to the SwObjectFormatter, which appears to fix the problem. Change-Id: Ib3dc34ce39b4aad723251271c24bdd7a6598ab1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159518 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-17sw: extract SwTextFrame::dumpAsXmlAttributes() from SwFrameMiklos Vajna
Allows getting rid of a static cast. Change-Id: Ic74bb3e33f591387cc5939c0ffbc8793630978bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159517 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-11-17c++20: use std::erase instead of std::removed followed by eraseJulien Nabet
See https://en.cppreference.com/w/cpp/container/vector/erase2 Change-Id: I26744e74b34d1efa1524a1f88aa3af9e153bc9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159515 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-17Manual extended loplugin:ostr changeStephan Bergmann
Change-Id: I003851390566dfe2b98cecc88afc8153f061ad68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159522 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-17Manual extended loplugin:ostr changeStephan Bergmann
Change-Id: Ic0418ba78851183deba2555943cf26934b982378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159521 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-17gtk4 a11y: Map BLOCK_QUOTE role to new gtk equivalentMichael Weghorn
Map the role to the `GTK_ACCESSIBLE_ROLE_BLOCK_QUOTE` equivalent newly added to Gtk 4 in commit [1]: commit bbb0150383e6aabdbead635f1751322530392b3a Author: Michael Weghorn <m.weghorn@posteo.de> a11y: Add block quote role With this and the gtk commit in place, Accerciser shows the block quote role for Writer paragraphs using the "Block Quotation" paragraph style as expected. Also needs a bump of the gtk version to >= 4.13.4 on the gtk "main" branch after the 4.13.3 release for the `GTK_CHECK_VERSION` check to pass and actually make use of the new role, see MR [2]. Omit the fallback to `GTK_ACCESSIBLE_ROLE_PARAGRAPH` for Gtk versions >= 4.13.1 but < 4.13.4, since they are all development versions for the same stable release 4.14. [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/bbb0150383e6aabdbead635f1751322530392b3a [2] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6574 Change-Id: I2c17da13867a61f0e6819913583392962cfd44a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158685 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2023-11-17update creditsChristian Lohmaier
Change-Id: I1c4a240ba3af7805865b96fbee4911c022cac897
2023-11-16fix --enable-wix switch - that didn't do anythingChristian Lohmaier
it used the wrong variable name in AC_SUBST and also had no place where it would be set for the rest of the build to use. Also the script hardcodes the location of the WiX Toolkit, so check for the same path in configure. Also it was needlessly tied to LIBO_TEST_INSTALL - since it has its own conditional, "double-guarding" it is not necessary. Change-Id: I6dd4a41e63d2a43a3e2f1aac5b6799a6601eb656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159510 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-11-16tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyNameMichael Stahl
* officecfg: deprecate Inet::Settings::ooInetFTPProxyName/Port * ucbhelper: stop handling these settings * sfx2: remove SID_INET_FTP_PROXY_NAME and SID_INET_FTP_PROXY_PORT and usage from SfxApplication::GetOptions() * shell: remove proxy config code from backends * stoc: the JavaVM would have its "ftp.proxyHost" properties set based on officecfg values; remove that * sysui,vcl: remove protocol from KDE desktop files and file picker Change-Id: Iba02676cf6e519e2fa60ba925209436d38e75f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159500 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16tdf#146386 cui,sc,sw: Office::Common::Filter::HTML::Export::LocalGraphicMichael Stahl
Adapt its usage to removal of FTP UCP; the target protocol check in sc and sw was particularly silly. Change-Id: Ib94501ebcc589e257e9b882a340e18ef1a791584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16tdf#146386 remove references to FTP UCP codeMichael Stahl
Change-Id: I85f83c3d83f3de59a929ed053e0e92bb10bdcc5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159498 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16writerfilter: fix utext()'s dumb sal_uInt8* parameterMichael Stahl
This removes all but 4 reinterpret_cast in the module! TableManager::utext() even assumed that the bytes are little-endian. Change-Id: I12031336cabedfd6c0fb614ee0e3400810f98e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159486 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16writerfilter: remove DomainMapper::text() handling of paragraph breakMichael Stahl
Convert all remaining callers to utext(). Change-Id: Ie1fdf22e9e474289df2c72eadc236ec6b270df4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159485 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16tdf#119908 sw smart justify: fix justification by shrinkingLászló Németh
Shrink the exceeding lines by shrinking the spaces between the words. Because the negative spacing values are used for the extra space between the characters in the main data structure of the justified line layout, and not for the space between the words, like the positive values, the negative space values for shrinking are stored over LONG_MAX/2 as absolute values to avoid of bigger changes of the data structure before designing a better justification algorithm, where it's possible to mix different methods for the more visible text layout. Note: the text cursor doesn't follow the new word positions yet. Follow-up to commit 7d08767b890e723cd502b1c61d250924f695eb98 "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt." Change-Id: I9a63b5a93d6bce230e963ebc88ea2d0f9aa8fffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159511 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-11-16tdf#153194 writerfilter: RTF import: testContSectionPageBreak last paraMichael Stahl
For testContSectionPageBreak, Word inserts an additional empty paragraph at the end of the document that was missing in Writer. Ensure markLastSectionGroup() is always called at the end of the document so that the \par that is dispatched in m_bNeedPar case will be inserted and not automatically removed immediately. Also add a test for the same document without \sbknone, which has 4 pages instead of 2. Change-Id: Ib3e4fbdb66df55941e4a487d4b249cd98fe42008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159472 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16writerfilter: DomainMapper: fix undetected merge conflictMichael Stahl
... between commit fce18155052821756466ea043c638f4ed72f41d6 and commit 15b886f460919ea3dce425a621dc017c2992a96b - move the code from lcl_text() to lcl_utext(). Change-Id: Iaa515d2ebd9861e24b442b0d7b41f83662ed58df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159501 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16android: Add missing make dependencyMichael Weghorn
After commit f9b9e702465b4de29153b49e077c70a0ad78c89d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Nov 15 13:26:38 2023 +0100 android: Add button to open privacy URL , Android Jenkins builds started to fail intermittently (e.g. [1]) like this: > Task :stripStrippedUIEditingDebugDebugSymbols > Task :compileStrippedUIEditingDebugJavaWithJavac FAILED /home/tdf/lode/jenkins/workspace/android_x86/android/source/src/java/org/libreoffice/AboutDialogFragment.java:93: error: cannot find symbol final String privacyUrl = BuildConfig.PRIVACY_POLICY_URL; ^ symbol: variable PRIVACY_POLICY_URL location: class BuildConfig Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 1 error FAILURE: Build failed with an exception. This seems due to the pre-existing issue of a missing dependency of the `liboSettings.gradle` target on `android/Bootstrap/Makefile.shared`, so a change to the latter would not have caused the former to be regenerated and any old one still around that didn't set the new build config variable would get used, resulting in the above error. Issue reproducible locally: * do a local Android master build * `git revert f9b9e702465b4de29153b49e077c70a0ad78c89d` * `rm android/source/liboSettings.gradle` * `make` * `git cherry-pick f9b9e702465b4de29153b49e077c70a0ad78c89d` * `make` [1] https://ci.libreoffice.org/job/gerrit_android_x86/33773/console Change-Id: I87275fc71d93f460dfad4d75fc197b8ed8cd9922 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159497 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-16pass a frame to use as parent for any dialog that may need to appearCaolán McNamara
which avoids: sfx2/source/appl/appserv.cxx:314: no parent for dialogs Change-Id: I71734b42f3206fc724e5a3d5538072dc775f0b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-16combine these hyperlink dispatchers into one callCaolán McNamara
Change-Id: Icb7822e811013de648ccf2fbb23a5f0be9e29bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159489 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-16reuse AllowedLinkProtocolFromDocument in writerCaolán McNamara
Change-Id: Iacf5e313fc6ca5f7d69ca6986a036f0e1ab1f2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159488 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-16reorg calc hyperlink check to reuse elsewhereCaolán McNamara
Change-Id: I20ae3c5df15502c3a0a366fb4a2924c06ffac3d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-16tdf#157789 Comment size wrong behavior when zooming documentNoel Grandin
Revert commit 8d18b5af883bb6b56e758801ee730a08bb88a8f5 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Jun 13 10:11:08 2023 +0200 speed up rendering annotatins, cache meta height Change-Id: Ib0bae3fd9020200d09c5b37baf5ae882c8532e58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-16tdf#158224 Cannot convert bitmap to polygonsNoel Grandin
regression from commit a76a135c9e9bdecd38970e293e72eeeeca000d27 Author: Noel Grandin <noelgrandin@gmail.com> Date: Tue Jan 3 20:14:21 2023 +0200 flatten some vcl code Change-Id: Ibb2a059b283dc2e3bf3fecbf24ff71332a204d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159495 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-16tdf#153194 writerfilter: RTF import: \spltpgparMichael Stahl
1. Some experimenting with the bugdoc (saving it to DOCX in Word changes the layout in Word to exactly what Writer imports from RTF!) leads to DOCX w:splitPgBreakAndParaMark setting. 2. the RTF implementation of \spltpgpar was missing; apparently if the flag is present the "new" behavior is in effect, which is the opposite of how it's specified in RTF Spec 1.9.1. 3. the DomainMapper code that uses this attribute is not in the text() function to which RTFDocumentImpl sends paragraph breaks, but in the utext() function, so send the break there instead, rather than creating even more copypasta. 4. now some filters-text crashes with nullptr pContext in DomainMapper::lcl_utext(), avoid that. 5. dispatchSymbol(m_nResetBreakOnSectBreak) doesn't do anything because these are handled by dispatchFlag(). 6. Test name: testFdo81892::Load_Verify_Reload_Verify equality assertion failed - Expected: Performance - Actual : Fails because additional paragraph break inserted after \page; in dispatchSymbol() for \sect, remove the parBreak() as already hinted at in commit 3c610336a58f644525d5e4d2566c35eee6f7a618 7. rtfimport.cxx:868:Assertion Test name: testContSectionPageBreak::TestBody equality assertion failed - Expected: - Actual : THIRD It has no paragraph between SECOND and THIRD, whereas Word definitely shows a paragraph there. In dispatchSymbol() for \sect, sectBreak() is not called (which may create a paragraph break); in m_bIgnoreNextContSectBreak case this needs to be done manually for cont-section-pagebreak.rtf to get the empty paragraph between SECOND and THIRD. 8. testFdo52052 fails; in dispatchSymbol() for \sect, if the document ends with \sect (e.g. fdo52052.rtf) a paragraph break must be inserted after this (because DomainMapper unconditionally removes the last paragraph break), but not via m_bNeedCr as that creates unwanted page break in testNestedTable (m_bNeedCr => dispatchSymbol(\par) => m_bNeedSect => sectBreak()); handle it in RTFDocumentImpl::popState() for the end of the document by dispatching \par. 9. rtfimport.cxx:1519:Assertion testTdf108947 now has 1 empty paragraph in the header instead of 2; Word also shows only 1 so it's an improvement. 10. Test name: testFdo49893_2::Load_Verify_Reload_Verify equality assertion failed - Expected: 1 - Actual : 0 - xpath should match exactly 1 node This was reduced to only 2 pages, while Word shows 5; in dispatchSymbol() for \page, for the consecutive \page send an empty string to DomainMapper's utext() which causes a paragraph break to be created if \spltpgpar isn't set (this was not at all obvious!). 11. testTdf133437 fails with some numbers of flys changing, but it had those values before commit 3c610336a58f644525d5e4d2566c35eee6f7a618 which says "the exact number isn't that interesting". 12. testTdf153613_anchoredAfterPgBreak4 fails, but it now looks as in Word, so this is a bugfix. 13. Jenkins build on WNT (only) crashes in testForcepoint93 in sw layout code - disable test for now, debug asap. Change-Id: Ia1063693d96adff900ece943020a5bf69bdeb7a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159471 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-16sw floattable, delete UI: fix unfloat button for cant-split framesMiklos Vajna
Open sw/qa/extras/uiwriter/data/unfloatable_floating_table.odt, select the TextFrame, click on the "unfloat" button that appears, then nothing happens. This is a problem since commit 51379fb3d46e5891bdaea0122bd62b0753663da3 (weld writer's FrameControl MenuButtons, 2020-12-03), the old MouseButtonDown() callback is never invoked. Fix the problem similar to what SwHeaderFooterWin does, which works: instead of overriding the dead MouseButtonDown(), explicitly connect the click handler to the weld::Button widget. Also adjust SwFlyFrame::ActiveUnfloatButton() to use the welded callback, this way CppunitTest_sw_uiwriter2's testUnfloating covers the fix. Change-Id: I1180fc6a0ae2df7c01c273a5ef92dd8915ca70a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159493 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-11-16comphelper: use c++20 contains() instead of find() and end()Miklos Vajna
Whether an element is contained inside a container is better to be checked with contains() instead of find() because contains() conveys the intent more clearly. Change-Id: I267d915c95fcf9c98b2e11daa89c8fe801e59a75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159484 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-11-16[API CHANGE] Remove deprecated Password config itemSamuel Mehrbrodt
Deprecated since c51ef466f736c9e0e192d2c7feeda0a39bca2011 Change-Id: I9509a17de09e618c5d4b914b7ac1202cb76f506e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157485 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-16Format optaboutconfig with clang-formatSamuel Mehrbrodt
Change-Id: Ia696e096f972fe722920238c3710d20a3f03b221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159374 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-16expert config: Proper editing support for numbersSamuel Mehrbrodt
Change-Id: Ib97e027cedfdf2c5bb3c956aeee75af25198e498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159355 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
generated by cgit (git 2.34.1) at 2024-04-26 03:04:38 +0000