summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-27tdf#111907 Allow box in Manage Names dialog to expand on resizingAndreas Brandner
Reviewed-on: https://gerrit.libreoffice.org/41946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 9c34471f54870fc685c343f4af30310e75d3a9ca) Change-Id: I821e12d771d574dd191d9be86a19c23288902d5b
2017-11-27ofz: compare against available data lenCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/44688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 7e3572833b8ce0c9d2b92130df099a8bbbe95c4d) Change-Id: I407e104e08aa393d66ed5c6baf5e0b0ab2d361bd
2017-11-27ofz: XPMReader::ImplGetColKey short readCaolán McNamara
like commit 10a2388558df957b30136ba32ecc97ddef43fb57 Date: Tue Jan 17 12:35:24 2017 +0000 ofz#411: XPMReader::ImplGetColKey short read Change-Id: Iffc7ddb00b2849b2f9fad17314086b87d3097660 Reviewed-on: https://gerrit.libreoffice.org/44629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit e02f068b9719c89d7aac1aaf4bb650160a3a3aed)
2017-11-27ofz: special case max index for cSymbolCaolán McNamara
Change-Id: Ia5fb036196b0cff0739789e691a36d294660540b Reviewed-on: https://gerrit.libreoffice.org/44759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a5550289a37950195b7a7e5b22cba79ce5b5a673) Reviewed-on: https://gerrit.libreoffice.org/44803 (cherry picked from commit 701e1ec3a2e38a7b0bd2cdd3511a2a50578ea74e)
2017-11-27ofz#4123 do not read past end of fileEike Rathke
Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647 (cherry picked from commit 78bcc5ddca186f0009124a697184f332405d3e1e) Reviewed-on: https://gerrit.libreoffice.org/44586 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6ba9b72cff5a761f36b2b9b892b572bc7cb5ae18)
2017-11-27ofz+valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value derived from an earlier aSymbol.getLength() include the range after the embedded null, while lcl_UnicodeStrNCpy stops at the first embedded null leaving cSymbol with uninitialized value that are later read from it. Conditional jump or move depends on uninitialised value(s) at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275) by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248) by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419) by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118) by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656) by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729) by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851) by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369) by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377) by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400) by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34) Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7 Reviewed-on: https://gerrit.libreoffice.org/44658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6be596c282f84a3cb3a62edccfdfbf69663cf59e) Reviewed-on: https://gerrit.libreoffice.org/44690 (cherry picked from commit 8959754d2617dad38968ca008791e6431afcbdbd)
2017-11-27ofz: bad mnRangeOpPosInSymbolCaolán McNamara
Change-Id: Ieae5a81a1b475fd56cce76c43dab11c2d9fcbe6c Reviewed-on: https://gerrit.libreoffice.org/44499 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f17640a95b4c65809f8573c778a293c836a847cd)
2017-11-27ofz#4066 Bad-castCaolán McNamara
and a cluster of others around here. This pRedl has been deleted at this point. This doesn't matter for most users, seeing as !LibreOfficeKit::isActive() is the usual case so the deleted pRedl isn't fully accesssed. Because the deleted pRedl won't be found in GetRedlineTable when deleted, rework this a little to avoid the problem. Reviewed-on: https://gerrit.libreoffice.org/44392 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f0074dd8c6e0040d7f331ba4a42ea6193c0eac99) Change-Id: I5c2f405cdae0b0c804ee7452629a14206516962d
2017-11-27ofz#4076 bad palette READCaolán McNamara
Change-Id: I54943d96baa6e2309bbf2cd3b6d8bcada2b76952 Reviewed-on: https://gerrit.libreoffice.org/44353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4428c662765464e7f461101887f0141fde4ba4ef)
2017-11-27ofz#3759 check for valid starting dash indexCaolán McNamara
Change-Id: I09e117e14eda2565c9b25d407cc4328d4f2ee97a Reviewed-on: https://gerrit.libreoffice.org/43802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 2851316853b6c9106d9dc89a8ea4c3ca42eab01e)
2017-11-27ofz: returning SfxPoolItem belonging to localCaolán McNamara
Change-Id: Ib9760efb1231ef057dfd62d06095c15e3bf73a87 Reviewed-on: https://gerrit.libreoffice.org/43426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a2ca21fada002b895202abd2cbb4997b112627f8)
2017-11-27vcl: StyleSettings - start to unwind code duplication.Michael Meeks
This should be a pure re-factor, plus: switch from Serif -> Sans font default for the UI (wow). enable larger font size for LOK only that avoids a hard to debug svx junit test failure. Change-Id: Id438026064983ea4907819bab55c4be740954605 Reviewed-on: https://gerrit.libreoffice.org/44898 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-25Add ICU changeset-40324 fix for CVE-2017-14952Eike Rathke
(cherry picked from commit cebe1279665960b732c9cb05c18e481c33e778bb) Conflicts: external/icu/UnpackedTarball_icu.mk Change-Id: Ia457669c5ec6ef5c568f4550c44ef5df32a4be66 Reviewed-on: https://gerrit.libreoffice.org/44510 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-24tdf#67207: export MERGEDIELD to DOCX and DOCMike Kaganski
Also removed a hack for i119803, because proper solution is implemented. This does not export data source information yet. Unit tests for DOC and DOCX are included. RTF export is already covered in testFdo80905. Change-Id: Id4f6d53344edf474add7e885e8ae6f36618e569f Reviewed-on: https://gerrit.libreoffice.org/45193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/45243 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-24tdf#114025 - avoid deadlock between x11 clipboard and the lock dialog.Michael Meeks
Change-Id: I06e66f59531e7ff6a2e0bf874ebcf2a882d89b63 Reviewed-on: https://gerrit.libreoffice.org/45234 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-11-23Resolves: tdf#95960 improve custom properties pageCaolán McNamara
wrt widget heights and positions and other flakiness take the natural combobox height as the line height, use a vclgrid element for each row to get everything set to the same height move the positioning code into Resize, etc. Reviewed-on: https://gerrit.libreoffice.org/41734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 14afb688d3a24be302867ea614b0e30e01d168be) Reviewed-on: https://gerrit.libreoffice.org/41749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 69f19b7d2e538c66bb89f2acaf6e4ad7b0305825) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I22de98ef91e39d1e7e45bbe62f68496d55c0c1cb
2017-11-23Resolves: rhbz#1400287 resizing properties dialog hides widgetsCaolán McNamara
Change-Id: I5d066f53c5bdfb4dd50d60c5cb4b66e425c0293c Reviewed-on: https://gerrit.libreoffice.org/41698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 7040862125fb1d805286771c26f6b51396cfb145) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-11-23tdf#87075: Filter out unused directories from FILELISTsStephan Bergmann
...so that on macOS dictionary extensions don't pollute LibreOffice.app's Contents/Resources/extensions/ with empty directories (that would then show up as phantom extenions in the Extension Manager). Change-Id: Iacff73e931885cde0fe507e384de80e9bd38d475 (cherry picked from commit fbcdca2becb4eee0825697efffba14b5796ade6d) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-11-23tdf#109343 Fix paste as .RTF on MacXisco Fauli
Change-Id: Ida0433437301ea2803373e534df3d42f67d6aff8 Reviewed-on: https://gerrit.libreoffice.org/43513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit dd0bc7323014c528fefb516cacae0591f270862a) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-11-22Use the same solenv/bin/ooinstall as in the cp-5.1 branchTor Lillqvist
Specifically, pass the correct product name and not a hardcoded "LibreOffice" for the make_installer.pl script's -p option. As such, instsetoo_native/util/openoffice.lst.in hardcodes the product name as "CollaboraOffice" so we could as well do that also in ooinstall. Change-Id: I9b2d84bcc18e21b325960f7057e259daa37234a5
2017-11-22Don't bother with unoinfo either in the sandboxed app bundleTor Lillqvist
Note: Only for the ENABLE_MACOSX_SANDBOX case. Does not affect a regular signed build. Change-Id: I296ebdd5de075c1efbd198c671a3ec082681deb4 Reviewed-on: https://gerrit.libreoffice.org/44728 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 327ad42f4b641f37cf4dd9936346bc386252669a)
2017-11-22typoStephan Bergmann
Change-Id: If5876ca8ecb8e6c6fe1135ddd0d1aa31ebfc47ca Reviewed-on: https://gerrit.libreoffice.org/37468 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit d4e4c85d3cdf9faf678ea43e6a29e35bee0bc371)
2017-11-22Use same language list as in cp-5.1 for nowTor Lillqvist
2017-11-22Resolves: tdf#111428 swap ScColumn::mnBlkCountFormulaEike Rathke
This is a combination of 2 commits. (cherry picked from commit 423df1fa929784c14e3a133c06468589fe9269cd) (cherry picked from commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3) CellStoreEvent remembered the original ScColumn::mnBlkCountFormula, hence after inserting a column to the left the quick check of ScColumn::HasFormulaCell() whether there are any formula cells worked on the swapped in count (originally the one to the right) that happens to be empty in the scenario. Things worked correctly by accident if the next column to the right already contained a formula cell. c44fed96c49bea7365bf1200e06788860966795c Change-Id: If993856ceee657736f516a81c293506041a6b7eb Reviewed-on: https://gerrit.libreoffice.org/44210 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/44493 (cherry picked from commit 7f1297d9b4f449eb9ada8008fb21b7046d1a8f19)
2017-11-22Apparent fix for what seems like a copy-paste error by me in 2014Tor Lillqvist
(in 5f27a6864420815d0d0abc409333fec963536faf.) Whether this has anything to do with tdf#92190 is unclear. Some experimentation indeed seems to indicate that it fixes the problem, but I am not 100% sure. Reproducing the bug fully realistically would require using a printer with actual Letter size paper. Thanks to Telesto for noticing this copy-paste issue. Change-Id: I853aaaf2b7a19380dce908f93349b001bf3feb92 Reviewed-on: https://gerrit.libreoffice.org/44679 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 9f8429d81c08cc40d5b1210cb6e4b383316cdc75) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-11-19tdf#113790: skip charfmt grabbag items existing in autofmt grabbagMike Kaganski
Change-Id: Icc0065c1da9471cb36bfef0da45e2f67381a1a31 Reviewed-on: https://gerrit.libreoffice.org/44706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/44772 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-16Bump version to cp-5.3-31cp-5.3-31Andras Timar
Change-Id: I6ffd71efc5be636ee2347fbd6ebcb0f845c0bc7a
2017-11-16vcl: StyleSettings - start to unwind code duplication.Michael Meeks
This should be a pure re-factor, plus headless tweak. Change-Id: Iad7f524ea76625601b3f85cc13a50311ed1de171 Reviewed-on: https://gerrit.libreoffice.org/44811 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-11-16Fix gtktiledviewer crash: this should be a null terminated listTamás Zolnai
Change-Id: I06e0923980b98b37b06ab45d8db68424b01d4f71 Reviewed-on: https://gerrit.libreoffice.org/42645 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-16lokdialog: Expose cursor visible statusPranav Kant
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-16lokdialog: Callback for dialog cursor invalidationPranav Kant
Change-Id: Iecadb68737ed7b1a425d9ea633976fb24d1055c6 Reviewed-on: https://gerrit.libreoffice.org/44721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15Upgrade these SAL_WARNs to INFOPranav Kant
These are very common occurrences. Let's not flood the warning output. Also ressurrect some helpful looking commented out SAL_INFOs Change-Id: I3368fb46b27b72edd8ba1f52e2a145a661c40477
2017-11-15[API CHANGE] lok: Don't use 'bool' and 'uint64_t' in the stable API.Jan Holesovsky
This is a f70e0ec6b3c61a7c7caa469949b0ac8016c89854 follow-up. Change-Id: I4acf00a6da85ed14be4ed0ca20d541a9441736e7 Reviewed-on: https://gerrit.libreoffice.org/42266 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-15lokdialog: Invalidate-all when size is changedPranav Kant
Change-Id: Ic96fab62c1525154a60c0fa84e2a12ccfad15ae2
2017-11-15lokdialog: Compress invalidation callbacks in Callback flush handlerPranav Kant
Change-Id: Id76bde54395611f509a5d4be6bb2ac9b7f6ed1c0 Reviewed-on: https://gerrit.libreoffice.org/44474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Move getting dialog information in separate LOK callPranav Kant
Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Support painting parts of the dialogPranav Kant
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Tunnel dialog title to lokclient as outparamPranav Kant
Change-Id: I1beb5ab3f06debdca7ebf999af7ac879a41ea47e Reviewed-on: https://gerrit.libreoffice.org/43959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Clear the pointer after destroyingPranav Kant
Change-Id: Iebbe3fab6f6144f0cf1de9a1c45a0b2a62b07e0b Reviewed-on: https://gerrit.libreoffice.org/43958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Add more dialog related methods to LOK APIPranav Kant
Change-Id: I0e4abb38e1ea9450ae9c50f71ac6e8f9150868ae
2017-11-15lokdialog: Add dialog APIs to lok::Document classPranav Kant
Change-Id: I1947dc84c91e2e01072fbff3e97aa94d514ecb5a
2017-11-15lokdialog: Smoother mouse move on floating windowsPranav Kant
Do away with an early hack to create the floating window with every invalidate. This gets rid of persistent blinking when moving the mouse over a listbox, for example. Change-Id: Ida9367156605edc9835529f83529363ad97beaee
2017-11-15lokdialog: button press type debug infoPranav Kant
Change-Id: I193e0ab82e998905b670f7de73daae784de3ef00
2017-11-15lokdialog: Emit dialog close callback upon dialog closePranav Kant
Change-Id: I4ccef76cc3b2926dd8916f825671bb732e101027
2017-11-15Change CB_DIALOG_INVALIDATE to CB_DIALOGPranav Kant
We can specify whether it is an invalidation or something else in the payload. Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
2017-11-15lokdialog: Mouse events for dialog floating child windowsPranav Kant
Change-Id: I06a081835d246f752e57f8cc289162ed31fc91d4
2017-11-15lokdialog: drawing area needs to have focus to capture key eventsPranav Kant
With this, key events successfully work now. Change-Id: I6dc6aff91dea08fcbc7ab840a77e2542ab9048ce
2017-11-15lokdialog: Move the floating window to its actual positionPranav Kant
gtk_window_move them to the position broadcasted to us by vcl Change-Id: Id27b52a24e721b51d7a153cc7c0e03197a99ee2f
2017-11-15lokdialog: Support for rendering floating window dialog widgetsPranav Kant
Now gtktiledviewer can show floating window dialog widgets when user clicks any of such widget in the dialog. Change-Id: I13d756f236379bc8b2041ed41cb7b502f7fd9b24
generated by cgit (git 2.34.1) at 2024-08-03 23:40:02 +0000