summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
11 hourscrashreporting: disable load from template during print previewlibreoffice-25-2Caolán McNamara
Change-Id: Ifc60a01f0e5e1f6cdab3680e69202f98471c2a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179090 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
23 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to ad6a8eca797d64c0fb193f080049e98249f6e5a7 - tdf#163132 Adjust Impress Remote guide. as follow up of https://gerrit.libreoffice.org/c/help/+/171958 Change-Id: I2f6cb97fab60d463f127663ab3f9a6ce36a8a12c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178919 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 053504317ac7f4c205f540d6871c9389dd6b9240) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178961
23 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to f6df909f54e7c47b53fbd39eaa2419db51aef734 - Fix bad characters Change-Id: I3b8a1f8188d2b88fb8409df4a1e602102c4a3381 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178960 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit e4f4fd964633268c3e52cb2b4cc32a11000ad148) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178989
23 hoursUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to a4e9dae48e571b14f5621510809500566ad65b47 - Fix grammar Change-Id: I0843f2bf289d7950feaf6fdccf3e0f5e62a368f0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178965 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 6ecda866708ab53144cffd8ab3be134b949f3394) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178988
38 hourscorrect caching in osl_getLocalHostname*Noel Grandin
the change commit eac00017e34e77343b9ac3638bed9c75115a23fe Author: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Date: Thu Dec 10 14:24:05 2020 +0100 [API CHANGE] Do not call getaddrinfo if we just want the hostname means that the result returned from osl_getLocalHostname and osl_getLocalHostnameFQDN is always the same, but depends on which one is called first. Rather cache them independently, so they always return the right thing Change-Id: Ifa2f731a6002550cf08f57b53fd6e25e8b79295f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 46533f9c308bb57545fd25527f3141daec0080d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178930 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
44 hourstdf#164091 - sw fix Accessibility sidebar gives warning about decorativeBalazs Varga
marked shapes We should not have warning about missing alternative text in case of decorative marked shapes. Change-Id: Ibac7f152886d7db004039eede9b657fa5e84ae87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178795 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit 519282418137861144341da8b7a5759068104405) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178881 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2 daysbump product version to 25.2.0.1.0+Christian Lohmaier
Change-Id: I730a41a439e0c1abec5fe7918f5c909cd20731a8
2 daysUpdate git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-25-2' to 77b6ad601c215497e22f8e93e9e26297dd396284 - update translations for 25.2.0 rc1 and force-fix errors using pocheck Change-Id: I1dc145b300782c282ecfe4043754ea3a57bb58a0
2 daystdf#161623 Handle windows that macOS forces to native full screen modePatrick Luby
Starting with commit c1452e73091412ba0bb72306329e1912df2ba513, native full screen was disabled. However, in certain cases, macOS will force a window into native full screen mode and this caused numerous bugs. So add the following fixes to support native full screen windows. Note: the green titlebar button will still zoom the window. That button will only escape native full screen mode only when macOS has already forced a window into native full screen mode: - When in native full screen mode, -[NSWindow styleMask] will include NSWindowStyleMaskFullScreen which can affect the frame and content rectangle calculations so always use -[NSWindow styleMask] instead of the mask that was used to create the window when doing such calculations. - A comment in commit c1452e73091412ba0bb72306329e1912df2ba513 mentions crashing after ordering out a native full screen window. I have not experienced any crashing, but I did find that ordering out would leave the application in a state where there is no Desktop and both the menubar and the Dock are hidden. The fix, which is to close windows instead of ordering them out, was copied from the following NeoOffice source code file which is licensed under the Mozilla Public License, v. 2.0: https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/java/source/window/salframe.mm - In AquaSalFrame::GetWindowState(), add both the original and the curent frame when the window is in LibreOffice and/or native full screen mode. - Track LibreOffice and native full screen state in separate instance variables so that both modes can be activated independently and the window is not set back to its original size unitl a window has exited both full screen modes. LibreOffice also has its own full screen mode which hides the menubar and Dock, resizes to fill the screen, and hides all of its toolbars. As much as possible, both full screen modes should coexist and the user can enter or exit LibreOffice full screen mode while in native full screen mode. So add the following fixes for LibreOffice full screen mode: - Do not add the window's titlebar height to the window's frame as that will cause the titlebar to be pushed offscreen. - The menubar and Dock are both hidden when a window enters LibreOffice full screen mode. However, -[NSWindow setFrame:display:] shrinks the window frame to allow room for the menubar if the window is on the main screen. So, force the return value to match the frame that LibreOffice expects. - Multiple windows can be in LibreOffice full screen mode at the same time so hide or show the menubar and Dock when a LibreOffice full screen window gains or loses focus. - When a window is in LibreOffice full screen mode, LibreOffice hides the menubar. However, when in native full screen mode, hiding the menubar causes the window's titlebar to either fail to display or fail to hide when expected. So allow the menubar to remain visible when a window is in both LibreOffice and native full screen mode and disable all LibreOffice menus (like is done when a modal windowj is displayed) to mimic the effect of hiding the menubar. Note: this change is a combination of the following commits: - Commit 13bdc2ba0cec0cb1c9e8077eb2217f69822a805f - Commit 05b508f9f1397249079842dca86c36cbca01b43d - Commit 2120acaa261aaa1adaafc051582ac7f7dd4de372 Change-Id: I94ae24a03d192a681d5500930f7fec70e595ffaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178497 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins (cherry picked from commit 13bdc2ba0cec0cb1c9e8077eb2217f69822a805f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178820 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2 daystdf#164354 skip unnecessary transparency removal when printingPatrick Luby
On macOS, there are no known problems drawing semi-transparent shapes, fill, text, and bitmaps so only remove transparency when reduce transparency and no transparency print settings are both true. The fix not only eliminates the sometimes lengthy wait for the native print dialog to appear, but in cases like tdf#164354 the fix reduces the size of the PDF file generated by the macOS print subsystem by more than 90%. The fix was copied from the following NeoOffice source code files which are licensed under the Mozilla Public License, v. 2.0: - https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/source/gdi/print.cxx - https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/source/gdi/print2.cxx Change-Id: I54263a24201a0195fc86df6dc50580e2d6a61c70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178818 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins (cherry picked from commit fa3dd1c3a190fcbead9d39038a30f0fd306a1baa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178836 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2 daysUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to a6a06f82cb02bdf8a66c6a9263ecc2f0ab41d10b - Mute L10N when <embedvar> is a singleton in text + some refactor Change-Id: I071758f139a7f6e9ab91ca277a420c8283b1eae0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178833 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 9bbf0db1682b2cd6b749e0fbd9a72606277cafe5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178834 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2 daysRelated: tdf#164359 editeng RTF export: track unused follow styles recursivelyMiklos Vajna
Similar to commit a7a81b6fbe37af938ce461e790fac517be032317 (tdf#164359 editeng RTF export: track unused parent styles recursively, 2024-12-18), the follows of a style has to be tracked recursively as well, to avoid a crash. The Impress UI doesn't seem to have a way to specify the parent/next name of a style, but you can definitely create such a follow chain from test code and probably this is also possible via macros. Fix this similar to the parent case, except here handle when a style sets itself as a follow: that's what the default Outline N styles do in Impress. Change-Id: If3847add02061fdb9ba1e3fbf7c1fc42e3866209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178786 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 65043a50adf8d56e1f965ec48b9609ca836ccced) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178816 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2 daysUpdate git submodulesSamuel Mehrbrodt
* Update dictionaries from branch 'libreoffice-25-2' to 8c4f1341eb370adb075d7734728c739cddbf0d30 - Add new word "Ratenvereinbarung" And put "Rattenvereinbarung" on the blacklist Change-Id: Ie4d7b8fd93c5758316b5a60539c2a42152725537 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178143 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 31bc2a1104a1cd175f900902f994c76dea35c763) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178709 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2 daystdf#164263: avoid exception when SAL_DISABLE_PRINTERLIST #2Justin Luth
This fixes a backported to 24.2.1 regression from commit e6f75eb50bc5d1ebccda0c0f80a7b353d991106e Although an empty OUString is returned when IsDisplayPrinter(), using that to setPropertyValue causes an exception. Since IsDisplayPrinter always returns static values for all queries, there is no need to actually attempt to make any changes when IsDisplayPrinter(). I don't see any unit test examples from the offending regression, or anything else in SW relating to Printer or environment variables, nor is there any explict call available to set mpDisplayDev, so I don't know how I can create a unit test for this. Change-Id: I3d4054df57ab460833d9994d71133aef64cbb714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178753 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178827
3 daysFix typoAndrea Gelmini
Change-Id: I93758f1bb09b9a7ce65e3692d968149fc58ae6c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178746 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit 12af04516999c2e13156b25e7fe2a1d22f347575) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178797 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
3 daystdf#163620 Allow users to modify "Appearance" for Automatic schemeSahil Gautam
Disabling "Appearance" options for Automatic scheme is pointless and it's bad UX as the users don't have any clue about what's going on. "Normal user should have our old feature - to select dark/light/system theme in only one action. Customizing theme is absolutely another thing" -- Kompilainenn (LO Design Team) Change-Id: I181420daefd29e0f7a7d638d9c7a26034c40c566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178828 Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> Tested-by: Jenkins (cherry picked from commit e87b50fb4936c221bdfb0fe6e8efd15251f6f38f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178835
3 daysAvoid global variables with non-constexpr ctorsStephan Bergmann
...that had been introduced in ddeeca35d9630f2d3d3afb83a2ec8f21458f6e19 "tdf#163620 [API CHANGE] Add UI for libreoffice themes", but caused builds that statically link in Library_cui (like LOWA) to fail on start up with an uncaught css::uno::DeploymentException from > soffice.wasm.comphelper::getProcessServiceFactory() > soffice.wasm.comphelper::getProcessComponentContext() > soffice.wasm.utl::ConfigManager::acquireTree(utl::ConfigItem const&) > soffice.wasm.utl::ConfigManager::addConfigItem(utl::ConfigItem&) > soffice.wasm.utl::ConfigItem::ConfigItem(rtl::OUString, ConfigItemMode) > soffice.wasm.SvtSysLocaleOptions_Impl::SvtSysLocaleOptions_Impl() > soffice.wasm.SvtSysLocaleOptions::SvtSysLocaleOptions()) > soffice.wasm.SvtSysLocale_Impl::SvtSysLocale_Impl() > soffice.wasm.SvtSysLocale::SvtSysLocale() > soffice.wasm.CuiResId(TranslateId) > soffice.wasm._GLOBAL__sub_I_appearance.cxx > soffice.wasm.__wasm_call_ctors (because comphelper::getProcessServiceFactory was now called before comphelper::setProcessServiceFactory) Change-Id: I4e2d8aa048c5c0b8c5c15edf6ae358bafceb08a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178815 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 1338df7dcfaec258e5a015abb5d1e7ed561a2792) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178819
3 daystdf#163319 Do not decrement destination position when moving a tabAlin Andrei Abahnencei
to the right Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Id8da1a1b199927bb2f1b71b814737b8287ea2a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178362 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit e6d4af2a03f22de1493e00e497e081240bf8a5c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178799 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#135320 sd fix soft edges are not shown on text framesBalazs Varga
Allow soft edge and glow effect on text frames objects. Change-Id: If08da1cfeae515aa50ded5689b7fe3a963a98cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178656 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit 8b7900dc3dfc6e3284442dc106799c44dc8961de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178739 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daysReapply "add an autotext 'common' directory like templates/common"Caolán McNamara
This reverts commit 331bcad4dbe923f4ce47cfe1de64ea0ffbe5a6ce now there is a fix for the problem that triggered the revert. Change-Id: I4acacd51d5799e80dfa42a0433278e684d82a860 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178577 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 2388501ed81c4873d63f2f26505603ade06642d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178792 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 dayssc: Dereference after null checkXisco Fauli
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sc/source/core/data/column3.cxx(2821): error C2220: the following warning is treated as an error C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sc\source\core\data\column3.cxx(2752) : warning C6011: Dereferencing NULL pointer 'pPattern'. : Lines: 2723, 2726, 2727, 2728, 2730, 2731, 2732, 2733, 2734, 2735, 2736, 2737, 2738, 2739, 2740, 2742, 2744, 2745, 2747, 2751, 2752, 2753, 2754, 2756, 2762, 2763, 2766, 2791, 2809, 2811, 2814, 2819, 2740, 2742, 2744, 2745, 2747, 2751, 2752 make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sc/source/core/data/column3.o] Error 2 After commit 2c613da01d02d45a140b94b391a142aede46e8b8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Dec 4 11:20:01 2024 +0200 tdf#163010 inline and cache rDoc.GetCondFormat call Change-Id: If9093d5b43ae63e059b3f0597c85b326599e9ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178621 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 85b7a25135eb96919d62a108fea18eab5531a4da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178644
3 daysFix typoAndrea Gelmini
Change-Id: I97349f5ede05de8b2dd605e1bf88c6429d1ae999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178743 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit 83b8206c69d9b89c269b90eb7c0dcd95e75daa6d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178791 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 dayssd: keep a non-owning pointer to the OverridingShellSarper Akdemir
... instead of keeping an owning shared_ptr To fix the ubsan build error <https://ci.libreoffice.org/job/lo_ubsan/3385/> Which appears to be caused from EventMultiplexer::CallListeners triggering a NotesPanelView to be deleted, and then notifying that just-deleted NotesPanelView, see <https://gerrit.libreoffice.org/c/core/+/177686/2#message-857c0180ae3e6572534d3bcd40f32000d434cc3d> Change-Id: I05e67dfeab093e7549e9b2ec4caf4a95dc743627 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> (cherry picked from commit c1473de894b17f113fcb6c81f82592434e272a8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178552 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daysReplace workaround of resize to invalidate with an explicit SfxHintCaolán McNamara
Change-Id: Ic0c8ba5e5f65f7b1e472a667b69e737f4f1d9fbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178389 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 6002f2777ab9294c1d41ef64863480976f254e43) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178549 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#61358 - Remember the last "insert as link" stateAndreas Heinisch
Change-Id: I3fe88411092df159fa6dc39a8fb9eb3ab36eeb70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158254 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 9f5040abbfdb6057fc2455cd6726398dc8ba7b9b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178190 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 dayscid#1608560 Data race conditionCaolán McNamara
Change-Id: I3b579434727e8b51d0de136c83d891c2f409d77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 01f0676b9517af903abd7da041d8219e5df25eeb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178540 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 dayscid#1607671 Data race conditionCaolán McNamara
Change-Id: Id2e87001b77087a072705ba7ffa1a2190220a082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 18399240f2aa976041db1928b1ae9db1a0ad706d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178562 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#164213: don't activate OLE objects in read-only modeMike Kaganski
Similar to the check done in SwEditWin::MouseButtonDown. Change-Id: I1a1b8966502a6b1557d424f28cfc1c1ecdf4b65e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5950fe86b84bb062e88034e382fc5df90bb1e98c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178565 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#163395 tdf#153057 - sc fix standard filter problem with formattedBalazs Varga
values ScQueryEntry::ByValue was removed unnecessarily in the original patch, but it is necessary for filtering number values correctly. Regression from commit: 1f755525189884e4b2824889a6b9dea8933402db Change-Id: Ib013d971ad0b0809fc55949a6a2d9bf02418b516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178690 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178738
3 daystdf#157476 tdf#150861 - sc fix autoFilter is filtering incorrectlyBalazs Varga
caused by rounding problem with duplicated values. We need to store the rounded values, based on the numberformat precision, otherwise later can cause problems at removing the duplicated values. Regression from: f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d Change-Id: I19f5248122ffca1e52adb96714df79dd9c64b23c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178683 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178737
3 daysCppunitTest_sw_apitests: remove leftover myNewGroup2.bau before the testMiklos Vajna
This fails for me in a tree that runs 'make check' and there was a previous 'make check' previously. Seems the trouble is that we have this C++ test creating an autotext .bau file, but there is also a Java one, so if we're not lucky with the order of these, the C++ one will fail with its hardcoded "must be 3 .bau files in instdir" assertion. Fix the immediate problem by removing the test .bau file before running the C++ test. A better, but more complex fix would be to create the test .bau file in the user profile (and not in instdir) for both the Java and C++ cases, and then none of these tests would influece other tests during 'make check'. Change-Id: I536d769db733515ec6a7d41fd7dbf601c4b582d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178548 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178576 (cherry picked from commit 703cbc0bb75b0943cf5b95ff62c6fe4b4a028788) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178589 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
3 daysReqIF: avoid 'target' attribute in 'a' elementsMike Kaganski
Change-Id: Iab34a18e2da766d30a2d6b5f5d8ed3855f3c8b8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178207 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 46ce77dfffaa6445ed05e1400284f4f9491b9faf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178556 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#164359 editeng RTF export: track unused parent styles recursivelyMiklos Vajna
Start edit mode for the shape in the document, double-click on a word which has a "level 2" bullet associated with it -> crash. This is a regression from c8b607b7c0096c58dc5187262bf0133dee728d50 (tdf#163883 editeng RTF export: fix broken offsets into the para style table, 2024-11-19), the direct cause is that ImpEditEngine::WriteRTF() maps all style pointers to a style ID and once we write the parent property in the style table, we unconditionally dereference our search result, because we know all styles should be in that map. The root of the problem seems to be that once parent styles are marked as used for the "only write used styles for the clipboard" case, those parents themselves can have parents, and we didn't mark those as used. Combined with the unconditional dereference, this leads to a crash. Fix this by walking up the parent chain till we get no parent. This assumes that importers create a valid document model, so there can't be loops while walking the parent chain. If that would be a problem in practice, we could check for that in the future. Change-Id: I4b416e78f26bf455040d95ee8ed220cfe870e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178703 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit a7a81b6fbe37af938ce461e790fac517be032317) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178718 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 dayscrashtesting: unknown 'IsContentEmpty' property reloading rtf exportCaolán McNamara
of forum-mso-en4-218597.doc where the XText is a TextFrame, presumably a problem since: commit cfd3b14fd4e1ee889dd356523e5cdaa639786d37 CommitDate: Fri Aug 2 10:37:31 2024 +0200 tdf#162295 DOCX import: optimize the check if the header/footer is empty Change-Id: I14e851aea66ad66024e9a8e38b1d1cdef0bf570c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 88f0e9a245f4a52ea45a25274a075b48fae7ef9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178785 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#113015 Improve update descriptionBogdan Buzea
Change-Id: If5ba0ee65483ebe27e71522b25c34daf04751991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178534 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit 85212289dc3bcee17d2fac1d205b33f61bcdae74) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178749
3 daystdf#163634 Format empty paragraph if they have a bullet/numberingOliver Specht
Some optimization in commit 52abeff6d5836b29dbefe69f284bbd89f6672ae2 ignores paragph attributes if the paragraph is empty. But it is not empty if it has an active list. Change-Id: I8885d0f201fc48279263a3d41ec6d660b534ded2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178311 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit fdb13df0cb759e65e48bb65b1513e8add429d4d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178553 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
3 daystdf#164353 tdf#130857 qt weld: Keep extra msg dialog widget in placeMichael Weghorn
Both, QMessageBox::setText, and QMessageBox::setInformativeText call QMessageBoxPrivate::setupLayout [1], and that one deletes the QMessageBox's previous layout, creates a new QGridLayout and sets that as the dialog's new layout. As a consequence, adding the widget that can hold extra controls to the dialog's layout only once by calling QtInstanceMessageDialog::addWidgetForExtraItems from the QtInstanceMessageDialog ctor isn't sufficient, but needs to be repeated each time the dialog layout may have changed. (Otherwise the widget is not contained in the layout, and "randomly" placed in the dialog, so it can e.g. overlap other UI elements in the dialog, see tdf#164353). Therefore, rework QtInstanceMessageDialog::addWidgetForExtraItems a bit, rename it to QtInstanceMessageDialog::positionExtraControlsContainer and call it also after updating texts. [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/dialogs/qmessagebox.cpp#n290 Change-Id: Ib17b5867393a0694701c56b0ab74165021a8bc51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178726 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit ffbe93aa93c0300dd4ff5f4d55dfb33e4c7a394d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178740
4 daysUpdate git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-25-2' to d0a91e3525fdedbc4d0af45ea7e261052bbbe281 - update translations for 25-2 and force-fix errors using pocheck Change-Id: I2af3d7d86339cf5588b28eb64593387454ff3508
4 daystdf#163620 [API CHANGE] Add UI for libreoffice themesSahil Gautam
Instead of Color, we have Light and Dark in the registry. So each theme extension will specify dark and light color values for each "customizable element" like DocColor etc. Under appearance we have three radio buttons - light/dark/system. If system is selected then light/dark colors are switched based on the system's theme. if explicitly light/dark is selected - that color is used from the registry. ColorConfigValue now has three entries nColor, nLightColor, nDarkColor. nColor is used as a cache for the color being used at the moment. This is to avoid otherwise expensive function calls + hundreds of modifications in the codebase just to change nColor. nColor is cached either when the theme is loaded or when changes are committed in `ColorConfig_Impl::ImplCommit()`. Now, if Automatic theme is selected then themes is disabled and the application uses the system colors. If some other scheme is selected like "CustomTheme" etc, then LibreOffice themes/UI color customization is enabled and the theme colors are used. Instead of a scroll window, now we have a combobox for the registry entries and a single color dropdown to select the color value. This color dropdown is for convinience in case the user wants to change some specific color that's bothering him. For themeing, theme extensions should be used. API CHANGE + remove Color in favour of Light and Dark + AppBackground has additional two - BackgroundType and Bitmap + remove officecfg::Office::Common::Misc::Appearnce in favor of officecfg::Office::Common::Appearance::ApplicationAppearance + move LibreofficeTheme under officecfg::Office::Common::Appearance UI + it looks like https://i.imgur.com/UMxjfuC.png which is a little different from how the [mockup] on the ticket describes it, and that's because of lack of time due to upcomming feature freeze. + system/light/dark allow the user to switch between light/dark modes based on either the system theme (system) or by manually specifying light/dark. + ui themeing and color customization is disabled when automatic theme is selected, and enabled otherwise. [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469 Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit ddeeca35d9630f2d3d3afb83a2ec8f21458f6e19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178729
4 daystdf#163620 [API CHANGE] remove persona/appearance-toggle related codeSahil Gautam
- remove ui and source files related to app colors and personalization tabs - remove persona entries from registry - remove functions related to persona settings from StyleSettings, vcl.. - remove ui and code related to tools - options - view - appearance combo box Change-Id: I98f0c38dc1facddd0e8dd03197c61a92287fdbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176836 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> (cherry picked from commit c4962247e40b5e6750c522d43359d9436dcfec68) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178728
4 daysUpdate git submodulesBogdan Buzea
* Update helpcontent2 from branch 'libreoffice-25-2' to ae02c3ab71c924e57a32166f57fdfaf89bace1f0 - tdf#124954 Improve Help about cache spreedsheet formula Change-Id: If9fdd7fa699afd9735b98fb42def1c1700556591 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178535 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 6c4a6bbc4f688feeabeb307c0dea1ef0c8f2baab) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178716
4 daysUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to e7c95257e8a6c32fd460a11042d5cd5e38e27d1c - Typo Change-Id: I9ffdecb64a9a6adec25e6516615b65ea79e1e788 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178684 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 7001361d995b74c7ea2bb334e442797e57feaea7) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178699
4 daysResolves tdf#140298 - SQL dialog must not become oversizedHeiko Tietze
SQL history becomes quickly too large for the dropdown control The patch sets a fixed width so this control wont take over the dialog size. Change-Id: I106ae19dfd505388e5b528becbc06e9d6110d45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178702 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins (cherry picked from commit 872945ecec6cabac691b036676d3dfe81f240948) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178719
4 daysUpdate git submodulesRobert Muir
* Update dictionaries from branch 'libreoffice-25-2' to edb2228a1d8caf12d3daf93aae7cf1dd4284ec42 - tdf#164366: fix wrong REP count in mongolian .aff file Commit d169602 broke parsing of this file by the lucene hunspell support, because now a `REP 3619` is followed by 3621 REP rules. Fix the count to be correct. Change-Id: I2c971dec7c44793e3d5b7a4030940014ddbebbb4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178710 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c3ff53711dcac4bdec24f23a2c1f9712a0833b67) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178711
4 daysResolves: tdf#156398 use same color combination as used in tdf#51300Caolán McNamara
so we don't get white text on yellow background Change-Id: I346decaab293e2bb15c1110dfa61df5838607d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178695 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
4 daysUpdate git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-25-2' to 390cd867023cd8b4b76c66db1e4e5419ecd77498 - Typos Change-Id: I19aac6bc535a8ca337fe11247cb2823db64eb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178692 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 46b1c476e1b92773ea63f3e74460acb1cf5792a5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178698 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
4 daysUpdate git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-25-2' to 4283c1d2e204566bb987351fc7b901f2eb058c0f - update translations for master/25-2 and force-fix errors using pocheck Change-Id: Ie775663b93d82f8392fa6317099ad158661dbdc7 (cherry picked from commit 86672eb8932b6779dd5b6d036c083662d4bcd15f)
4 daystdf#132274 Clarify wording of default Writer zoom behaviourThorsten Behrens
There was apparently some confusion what 'latest setting' was referring to (in fact, it's the latest setting that was stored in the document, for most cases). Change-Id: I30d36567cde602ba18b0b721dec0c9e76b560edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178660 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 896e87937fe6985d2f8f47b6c28a78703eeb85c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178678 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
5 daysgtk4: GtkIconView doesn't have convert_widget_to_bin_window_coordsCaolán McNamara
but still has the same problem as the gtk3 iconview with reporting positions when scrolled a problem since: commit a36a58933a1e07d3f54bacd5c2fe8ca53063a63a CommitDate: Wed Dec 4 07:40:30 2024 +0100 sd: convert sidebar masterpage panels from drawingview to iconview Change-Id: Ice549b40d88c5d2063e37ccb63490e3537736d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 55e77a48fbafd47036d7bd3ba11579c5f15f2359) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178566
5 dayscrashtesting: unable to import rtf export of forum-mso-en-14843.docCaolán McNamara
user field names have control chars in them and import from rtf hits the code added by: commit a6516c76c01b92f7d35bfb352b63af7de42b5707 CommitDate: Wed Oct 30 14:44:09 2019 +0100 writerfilter: rtftok: filter control characters so control chars are stripped out, which results in a duplicate user field name which throws. Filtering out at doc import time seems to work better, so lets do that as well. Change-Id: I463e30b223bfb5639de23c696d112eda2c27b428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178657 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 7c2d94c6b41a71e0440953d753f6a7092626bc9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178671
generated by cgit (git 2.34.1) at 2024-12-22 07:36:13 +0000