summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19Turn ScGridWin::AutoFilterMode into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of SortAscending/Descending in enum SvSortMode in include/svtools/treelist.hxx Change-Id: I7022d3c6338c5ff50edf6362577f89f6609cd3e9 Reviewed-on: https://gerrit.libreoffice.org/61960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-19sw: create SwUnoModule instances with an uno constructorMiklos Vajna
Change-Id: If05d773d6823833ef075484807bf427dcc2c1426 Reviewed-on: https://gerrit.libreoffice.org/61955 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-19simplify construction of SequenceNoel Grandin
and don't bother with mutex when returning static data Change-Id: I92bb53cf4e9ae8996b25a1d83cb5ffa4a8d4aed5 Reviewed-on: https://gerrit.libreoffice.org/61948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19use unique_ptr in LwpGraphicObject::GetGrafDataNoel Grandin
Change-Id: I19ba8eb5251af3b0c381275a0a18cf8c50944372 Reviewed-on: https://gerrit.libreoffice.org/61941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy modernize-redundant-void-argNoel Grandin
Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19loplugin:staticvar in vclNoel Grandin
Change-Id: I2bdab84dc81e0545aa96542caec213db61765f68 Reviewed-on: https://gerrit.libreoffice.org/61922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19loplugin:staticvar in xmloffNoel Grandin
Change-Id: I283d162807a906334627613be7c340af566144f1 Reviewed-on: https://gerrit.libreoffice.org/61921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19ww8import: always protect document if setJustin Luth
Just because some sections are unprotected doesn't mean that the document should not open in forms mode. MSWord 2016 opens it in "forms view" mode which also doesn't allow editing those unrestricted settings. Only when choosing the "Edit Document" view are the unprotected sections editable - similar to LO turning off the Compatibility: Protect Forms flag. Unfortunately, the "I want to address this" comment was from 2011, so obviously his temporarly solution became more permanent that expected. If this patch now blocks someone from being able to edit a document (because now only the forms components of the document are editable) they can remove the forms protection by going to tools - options - LibreOffice Writer - compatability - and disable Protect Form. patch developed to support tdf#120499 and depends on the patch for tdf#37778. Change-Id: I86e26095ade6b2cf0ab8ea8fc941a92fa672a2f7 Reviewed-on: https://gerrit.libreoffice.org/61901 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-19Revert "Notebookbar: add context-Printpreview to calc tabbed NB"Christian Lohmaier
This reverts commit 3f9c477929c261a8862411c00153e4c7d0d0ae7c. Breaks the JunitTest_sc_unoapi tests with clang
2018-10-18NB: Rename Menu entries for drop down menuesandreas kainz
Change-Id: Iee8cbf1d3be4f205c975d5100a8b3f2506653e26 Reviewed-on: https://gerrit.libreoffice.org/61954 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18elementary: Add 32px connector line, tablemode, shape manipulation, etcRizal Muttaqin
Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e7 Reviewed-on: https://gerrit.libreoffice.org/61937 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18add test for bug tdf#73081Zdeněk Crhonek
Change-Id: I96f56cee0cab3fa18992281e3745164377adade3 Reviewed-on: https://gerrit.libreoffice.org/61939 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-18Turn SvgMarkerNode::MarkerUnits into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of userSpaceOnUse in enum SvgUnits in svgio/inc/svgtools.hxx Change-Id: Ie1438e6ad0f73c73ad643157e5f8366a6e3f6851 Reviewed-on: https://gerrit.libreoffice.org/61933 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-18Sync Image/Graphic Tabb and context menuandreas kainz
NB: sync MenuImage in tabbed toolbar context menu: sync graphic.xml context menu in writer, calc, impress and draw Change-Id: Idab90ae9af7ac68815fe689811d6c11f948063ca Reviewed-on: https://gerrit.libreoffice.org/61938 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18Notebookbar: add context-Printpreview to calc tabbed NBandreas kainz
Change-Id: Iee6c83ae03ead7ae0b2c33f6cf364c1c3c59528f Reviewed-on: https://gerrit.libreoffice.org/61892 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18Implement drag'n'drop-related qt5 events, no-op so farKatarina Behrens
Change-Id: I67b8cecdc85ad77d7ab48d229459a79bc168072d Reviewed-on: https://gerrit.libreoffice.org/61721 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Just enough of SystemEnvData for drag'n'dropKatarina Behrens
Change-Id: I18ef6cb58632898ddfcb28098b99447565bcfb99 Reviewed-on: https://gerrit.libreoffice.org/61720 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18Basic structures for qt5 drag'n'drop supportKatarina Behrens
put (so far) no-op UNO ifaces in place Change-Id: I95394cfe05b8e3db21ddce6dfed1c1bb1d0e6381 Reviewed-on: https://gerrit.libreoffice.org/61385 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-18tdf#113415 - Customizable links in Help menuheiko tietze
SendFeedbackURL, QA_URL, DocumentationURL, GetInvolvedURL, DonationURL added to global variables under Menus Change-Id: Ie95ef2795d4079edd204edb1fcd86fde4376cedf Reviewed-on: https://gerrit.libreoffice.org/61874 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-18update creditsChristian Lohmaier
Change-Id: I666805e38c40826328d8c4226c394d4c3072b2a7
2018-10-18oox: ignore SmartArt "fallback" with empty shape listMiklos Vajna
This way at least something shows up in the import result. Far from perfect, though. Change-Id: Iae5a073d458598e7b5059ebdf435d50ce7c7df80 Reviewed-on: https://gerrit.libreoffice.org/61925 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-18Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I20e2ecce45ead161a3f95b511416044af4e04290 Reviewed-on: https://gerrit.libreoffice.org/61917 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-18drop newly unused SdAbstractTabDialog_ImplCaolán McNamara
Change-Id: I1e3b000b1fa5c439768eef135433fbf810309bbd Reviewed-on: https://gerrit.libreoffice.org/61930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18[pt_PT] Added 21 autocorrect wordsMarco A.G.Pinto
Change-Id: Ifa4c540b83fd9c6841b6b57890fb5db5266d82ad Reviewed-on: https://gerrit.libreoffice.org/61908 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2018-10-18align the various previews to the same placeCaolán McNamara
Change-Id: Ice5bb1db9f4bec803121c160a1f74c0d24551b40 Reviewed-on: https://gerrit.libreoffice.org/61929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SdTabTemplateDlgCaolán McNamara
Change-Id: I3aae53844f839ff54fab85ab4649c0bf0691e6de Reviewed-on: https://gerrit.libreoffice.org/61927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SdPresLayoutTemplateDlgCaolán McNamara
Change-Id: Ifc4c9a4631e92eee4b7f9b215c41d2bcc12a17d1 Reviewed-on: https://gerrit.libreoffice.org/61926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMMResultEmailDialogCaolán McNamara
Change-Id: Ib12455751074bbd818cc2da0c813fe984d887571 Reviewed-on: https://gerrit.libreoffice.org/61920 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeCreateFromDlgCaolán McNamara
Change-Id: I9885881bfc6baffe1184d52c207d8f5d81a4a3b4 Reviewed-on: https://gerrit.libreoffice.org/61919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeOutputTypePageCaolán McNamara
Change-Id: I4177bfd48b6af1cfc526e5ff43f00f1405ea647f Reviewed-on: https://gerrit.libreoffice.org/61911 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18tdf#120573 export media type for .wav properly.Mark Hung
Only video files were handled before. .wav files had wrong mime type in [Content Types].xml, used videoFile tag in slide1.xml, and incorrect type in rel file. Change-Id: I92bded52eb9f366103a10334c6a92fda9648076e Reviewed-on: https://gerrit.libreoffice.org/61885 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-18offapi: document queryLogicalAdvancements() for XTextLayout.Mark Hung
Based on implementation, explain the definition of logical advancements for RTL and LTR case and remove incorrect part. Logical advancements are distances to the edge instead of widths of characters, so summing all do not yield the total. Change-Id: I437f490e5025c2124238e8cad506a966d7bc792c Reviewed-on: https://gerrit.libreoffice.org/61461 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-18convert SdrLayer::nType to boolNoel Grandin
since it is being used as a bool. Also rename it to something more readable Change-Id: I89acc47251770c94fa321b742b0fb9327024055f Reviewed-on: https://gerrit.libreoffice.org/61909 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins
2018-10-18weld SwMailMergeDocSelectPageCaolán McNamara
Change-Id: I0a319624656eb1305522ebd4ae3ff63d5106db3b Reviewed-on: https://gerrit.libreoffice.org/61910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18Turn BorderHandler::BorderPosition into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of BORDER_TOP/LEFT/BOTTOM/RIGHT in enum BorderPosition in writerfilter/source/dmapper/PropertyMap.hxx. Also, BorderPosition can apparently be made a private member of BorderHandler, which gives extra confidence that any other uses of BORDER_TOP/LEFT/BOTTOM/RIGHT across writerfilter/source/dmapper/ indeed meant to reference the other enum BorderPosition. And change BorderHandler::lcl_sprm to return early in default case, to avoid having to come up with some new BorderPosition sentinel value to represent "invalid pos". Change-Id: I31e535326627cec25a17b99485bf7cf56f4c66d3 Reviewed-on: https://gerrit.libreoffice.org/61896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-18Attempt to fix tdf#118193Arnaud Versini
Change-Id: I41e3548c98e0fbe86a9a736c66b4cf6d746d84c7 Reviewed-on: https://gerrit.libreoffice.org/61757 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2018-10-18Added Turkish Language Support on Android ViewerMert Tumer
Change-Id: I0b2f1ca5386510e3a8217cf3bb3e08a940f438f7 Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/61788 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-18Added language support on Android ViewerMert Tumer
Change-Id: I05a189dcee9cf4415ce59771da03c08cf0fef6c4 Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/60727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-18editeng: do not throw from QueryValue implementationMichael Stahl
None of the other QueryValue throw; in case of a problem they return false without initialising the Any. On the one hand, it would be useful to throw an exception for this special property that has now become Write-Only, so that API users get a better hint what is going wrong; on the other hand, it breaks various other things like the various multi-property interfaces that call QueryValue for multiple items (there are 3 such loops in SwAccessibleParagraph alone). (throw was introduced in 7a8ed362eb163ac15a000ba1cfc74b58315800a1) It turns out there is even a test for the exception on ToX. Change-Id: Id60ff43544f7399ce869227bfd6fb933dbaea3be Reviewed-on: https://gerrit.libreoffice.org/61719 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-18loplugin:staticvar in sdNoel Grandin
Change-Id: I2a0b7e70db0d244627a462a5da5de7eeba8db940 Reviewed-on: https://gerrit.libreoffice.org/61907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18tdf#119847 - Can now autoselect font size on first clickNickson
Change-Id: Id49f4d039f0eb7c4efccecda91bd656c1c31d497 Reviewed-on: https://gerrit.libreoffice.org/60784 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-18Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - update help ids Change-Id: I475516915714d6d05e3ccb65b2309241da9ff4ea
2018-10-18loplugin:staticvar in scNoel Grandin
Change-Id: I9f1d66e9af454a27a341e56bbe50a558898b65a1 Reviewed-on: https://gerrit.libreoffice.org/61900 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18weld SwMailMergeAddressBlockPageCaolán McNamara
Change-Id: I0344e3c408f07f97caa34a87ce9e1559b6a76892 Reviewed-on: https://gerrit.libreoffice.org/61889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeGreetingsPage and SwMailBodyDialogCaolán McNamara
Change-Id: I7ac171654ec0a5095c05d1b54bec423b8eb9247b Reviewed-on: https://gerrit.libreoffice.org/61888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18xmlsecurity: avoid repeated manual calls to PORT_FreeArena()Miklos Vajna
Change-Id: Id62a894b08e6221c858304d7cb198a5a3f0cbd43 Reviewed-on: https://gerrit.libreoffice.org/61893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-18tdf#37778 ww8import: protect section only if protEnabledJustin Luth
Protection is not related to fReadOnlyRecommended In Word, documentProtection enforcement is a document level setting which is required for the section protection setting to be enforced. formprot: "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." In LO, section protection is honored if it is simply enabled, so only enable a section's protection if the enforcement variable is set. Round-tripping will lose the fact that sections are marked as protected if the enforcement is off. patch initially developed to support tdf#120499 where the focus is on sections, not on read-only and the fake section that was being created. Change-Id: I08c37ea6a9cc8fd1bdf7f36771b2d719bf9c93d6 Reviewed-on: https://gerrit.libreoffice.org/61899 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2024-07-17 22:36:28 +0000