summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-02Template: Add Simple writer template styleandreas kainz
Change-Id: I6fdf8241d740929a6548029f6926b32ead409d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93327 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-02tdf#106724: sw: Add unittestXisco Fauli
Change-Id: Icb65e69a92bd1bbad8db945bf91153eb5c730d23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93314 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-02test import and export of multi-page PDF with PDFium filterTomaž Vajngerl
The test checks that the exported PDFs contain embedded PDF for different pages. Change-Id: I4e5cd108d8597851d86aa774efbde0d4f2b9d2ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93322 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02remove vclpixelprocessor2d.cxx from clang-format blacklistTomaž Vajngerl
Change-Id: I03ad72d0754cb8c180f4eab0e8040c3dab533ef9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93321 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02remove vclprocessor2d.cxx from clang-format blacklistTomaž Vajngerl
Change-Id: I359dfb0fe6fdf88e9c8141186a770c4cde777161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93320 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02vcl: PdfExportTest rename topdf method to saveAsPDFTomaž Vajngerl
Change-Id: Id26a79fa047f1f6d26cab1f08e1db57330d4168b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93319 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02Resolves: tdf#132477 Fix Writer Navigator drag and drop crashJim Raykowski
Dont allow drag and drop when tree root is selected Change-Id: Ia5b8c07861c4ac9b0e4632ccc09e1cd9211e2a8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92962 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02Related: tdf#132477 use GDK_KEY_Escape to cancel dndCaolán McNamara
simply calling gtk_drag_cancel on the treeview dnd under X doesn't seem to work as hoped for (though under wayland all is well). Under X the next (allowed) drag effort doesn't work to drop anything, but a then repeated attempt does. But sending an Escape keyevent to get gtk to cancel the drag for us does work as hoped for. Change-Id: I09d3187e66774f9d23c77e0d515af7ae2a8fe156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02use revenge instead of librevengeCaolán McNamara
Change-Id: I3ec4d8b5e508653668bee3567e32f0920f56e3b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02Resolves: tdf#132604 GtkToolButtons that should be GtkToggleToolButtonsCaolán McNamara
Change-Id: Ie481fd0599e0cbd22ea1be7e353016f951837a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02cid#1401342 silence Uncaught exceptionCaolán McNamara
Change-Id: I961d68bc02ed22ab446dabbc6073df8ddf6730f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to f6eb368525721bf598325dcf78c82604919b9484 - Basic color functions cleanup - Color picker dialog wrong link in RGB() - extra links in Red(), Green(), Blue() Change-Id: If515dafedec9333cabf4d6adf34b9e1c59d1b325 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93135 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-02Fix typoAndrea Gelmini
Change-Id: I1014ee1ee67b475d5dd72ceb07fd8fd234171f55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93309 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-02tdf#132603: fix crash when selecting part of a commentJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=160206 Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=65404e2c72ea2d5d3f6c074121005b8b9369e7fb author Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2020-04-08 08:54:21 +0200 committer Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2020-04-09 11:14:15 +0200 commit 65404e2c72ea2d5d3f6c074121005b8b9369e7fb (patch) tree 15eeeb5b634c461611893dbe3b49d689ef71f5c4 parent 40d83914d43f60a196dfabddea0b52e2046b333a (diff) Move is*Locked methods to object shell They depend on the model, not the view. Follow-up to 523922ee9d033fd304d2b50a72b76853ddcfbcdf Change-Id: I9267e856a0f0fb22778dcd95974bb4217fd3712f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93308 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-01tdf#124176: Use pragma once instead of include guardsYusuf Keten
Change-Id: I72c978c9d392d1aba1ca99feeacee021835adf52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93098 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-01ODF export: fix wrong definition of ODFSVER_LATEST_EXTENDEDMichael Stahl
The only real use of ODFSVER_LATEST_EXTENDED is as translated value of the default ODFVER_LATEST; it must match ODFSVER_012_EXTENDED which is larger than ODFSVER_LATEST | ODFSVER_EXTENDED because it *is* used in comparisons as the return value of GetODFSaneDefaultVersion(). (Guess the comment means not to use it as literal in comparisons.) Change-Id: I6ac5e012f314e86acdcb7ac7d615c747cd7b8a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92726 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-01Template: update category list sortandreas kainz
Change-Id: I6e3b25d65fa0fa57c4bfdac38c3cb6f24aa78f01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93246 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-01Resolves: tdf#129702 take text from correct model columnCaolán McNamara
Change-Id: If9af51348e5a254a0c5ab621fa162cdda4565e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 52eb45cd79ed75eb37b46c579860cee4e6180138 - Help CSS: allow title in header to be wider Added a column and let the title section to grow into it. Also removed the hardcoded size from the Xapian search input. Change-Id: Id391264a17556a35d54b705621deb9bdecc16af2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93278 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-01tdf#130792 Draw crashes when trying to add a point in a multilineNoel Grandin
regression from commit b4fc996520b47a6212661a9de3a1c72ccfc379a4 loplugin:useuniqueptr in SdrHdlList which changed SdrHdlList so that it crashes when passed a bad index. I can't seem to fix the calling code without creating other regressions, so just revert that part of the commit. The calling code is in SdrDragView::ImpBegInsObjPoint where it calls BegDragObj Change-Id: I494baa9a2e815fd7b9532840b65483ba2a70bd42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01transfer halign and valign alsoCaolán McNamara
Change-Id: I37bd5adab653f80a120cb9850a0bebd45c5cb7e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01tdf#66496: sw: Add unittestXisco Fauli
Change-Id: I3f74920cc2d706d6454c3338057cd73bd0e33519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93261 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-01Update for tdf#130778: Windows installer banner and icons. about imagesRizal Muttaqin
Change-Id: Id761f5c4de24fa600effb2a2311eb170d814eca2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93249 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-01Restructure solenv/bin/assemble-flatpak.shStephan Bergmann
...so that parts of it can be reused by the Flatpak build done from Fedora RPMs (see <https://src.fedoraproject.org/flatpaks/libreoffice>). The reused parts are split out into solenv/bin/assemble-flatpak-*.sh files. (I can't remember any specific reason why I added the <releases> section to the Flathub org.libreoffice.LibreOffice.appdata.xml; maybe just because the file format allows for it and it appeared easy to generate the section when writing the file. For the Fedora LO RPMs, none of the existing appdata.xml files contained such a section, and generating one for the Fedora Flatpak case would require obtaining values for those LIBO_VERSION_* variables, so I just added a switch to solenv/bin/assemble-flatpak-appdata-step1.sh allowing not to write that section at all. Splitting solenv/bin/assemble-flatpak-appdata.sh in two steps is necessary because the Fedora Flatpak case wants to replace the screenshots in the first part of the generated org.libreoffice.LibreOffice.appdata.xml, but not in the appended original appdata.xml files, so needs to hook in between those two steps.) Change-Id: Ic527f3d88ccbee85e86dad3569b8e73776adf273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93260 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-01Adapt solenv/flatpak-manifest.in to 8b9c26218cb2c9526f69b40ff6f72ce757a464c2Stephan Bergmann
..."external: update libxmlsec to 1.2.30" Change-Id: I53eb2b0a2e83b081e273d73ca785afdb6af4bd19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-01move some headers inside their respective modulesNoel Grandin
Change-Id: I6b463724e301989a60e423bbfc25aa1bf146ff5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01tdf#66668: sc: Add unittestXisco Fauli
Change-Id: Iccc60a5847987f3dc0b4a47e55d0886ada63e4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93236 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-01can just call isXMLToken hereNoel Grandin
Change-Id: I5cb0b5ce9c9be78b68c757590880bf894186d0be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01Template: update default/modern thumbnailandreas kainz
Change-Id: I1d4f247a96b329f901050dfe669dc43bb1c8777b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93243 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-01tdf#132540 and tdf#132338 align popover replacement with complete toolitemCaolán McNamara
not just the menubutton sub-part Change-Id: I75342e3b7b21537565a3a367e1a8b2924b95e822 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93233 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01Related: tdf#130505 strangely all these point to the same pair of widgetsCaolán McNamara
Change-Id: Icbfe4b56e1ec068197a0641a1364f392261ba80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01Related: tdf#132540 keep placeholder popover on same side as menuCaolán McNamara
Change-Id: I344dde9e04496612641bca502e7aac53506f920a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01improve loplugin:makesharedNoel Grandin
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01tdf#130122 Make Navigator CNV collapse to childrenJim Raykowski
in root Content Navigation View again SwContentTree CollapseHdl needs to return false, when a root node collapse to children is done, to inform the caller not to do the collapse. Change-Id: Ie8bd731c6ea2f4ae51ddfcd4515d4481ab2d37b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92999 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-05-01Revert "lokit: scale the validation dropdown with client zoom"Dennis Francis
The scaling of the float window containg the listbox is unfortunately far from ideal at certain zoom levels and entry sizes. There are issues like too much extra spaces around the entries and around scrollbar if present. These issues need more work to fix. Until then lets revert this. Another issue is that we don't really want to zoom adjust any popups in mobile or android as this does not match the design of jsdialogs. This reverts the commit : 7787bac16cbe63698f56a9a70d9b1b217f3ea860 (master) a87e78df635d4a8e745bfffcf33d022d2a498afa (cp62) Change-Id: Ic31040b491e25b5113dfc8e70d3f73de204862e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93239 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 84200fc5e1b807629de2d975acaa3ffb81640d1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93137 Tested-by: Jenkins
2020-05-01tdf#63967 Navigator section tooltip word and character countJim Raykowski
Change-Id: I13ef9d71b080d5cac15e402e9198cf3c182eb78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91268 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-04-30tdf#132138 Update Sunset impress themeandreas kainz
Change-Id: I5fd2ab88cced118867c270dc191ac3e2b0fde72a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93229 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30Drop obsolete variable stringsHeiko Tietze
Change-Id: I0cd96b3466f94681567663625aa662717630e92f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93220 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-30Resolves: tdf#130505 give default focus to the file name fieldCaolán McNamara
Change-Id: I2c78fa95e626029a4cfc7f8e2faf03d4a5d2dee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-30svx:unit tests for galleryAditya
Tests for creation of renaming, deletion of gallery theme Change-Id: I2bfb602342f5d6b4ed45ff2f2fb9df7601e0e6b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92679 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-30tdf#124397: sw: Add unittestXisco Fauli
Change-Id: Idd98980625e246dea432346f3d7c12c942132aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93223 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-30Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 21fd17892ae4827f66d16a67a9c30c1854c5079d - tdf#131416 Basic syntax diagrams - Add UNO objects in Dim, ReDim statements - Include std fragments in Dim, Redim, Type statements - "@" omission in Dim, ReDim Statements - Replace bugged example in Let statement Change-Id: I500e1dcaa605978981e3b96cb277664fe5916282 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93131 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-30tdf#132138 Update Portfolio impress templateandreas kainz
Change-Id: I3bdb7954fe93019da62512c6832b587cc39959e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93219 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30tdf#132138 Update piano impress templateandreas kainz
Change-Id: I77795dbc87d8835d5609dd12ed33ad029dd309a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93218 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30tdf#132138 Update Pencil impress templateandreas kainz
Change-Id: If7a0aeb665f357ce5833fd6214651b63ae0e08be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93217 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30tango theme was removedCaolán McNamara
Change-Id: I351c92a6a2519c2c8b7b1c6868194c1bee81aa12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93215 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-30implement basegfx::B2DLineJoin::NONE for Skia drawPolyLine()Luboš Luňák
Change-Id: I186622aec3e944b89536bdcd44ff0be6b1d9cd8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93213 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-30tdf#132138 Update Progress impress templateandreas kainz
Change-Id: I23f18f9a9cd18b0104541050900a3a84bb545e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93157 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30tdf#132138 Lights impress templateandreas kainz
Change-Id: Iac9ce595ecf98f1957ff829a2090f5a712ead144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93156 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-30tdf#132138 Update Lush Green impress templateandreas kainz
Change-Id: I52e3480ded1892fb29c1b4a0537235d1af52370b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93153 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>