summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-20svx: add rendering for semi-transparent shape textMiklos Vajna
The color's alpha is normally lost when we roundtrip SvxColorItem's tools Color via TextSimplePortionPrimitive2D's basegfx::BColor. One way would be to add an extra transparency member to the primitive, like BackgroundColorPrimitive2D does that. However, a much easier way is to go via UnifiedTransparencePrimitive2D, that way we handle transparency in drawinglayer::impBufferDevice::paint(), rather than platform-specific code like CairoTextRender::DrawTextLayout() in the Linux case. Change-Id: Ie7aebe77ad9ac776dd27fc50538a5045200c8010 Reviewed-on: https://gerrit.libreoffice.org/83307 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-20libxml2: upgrade to release 2.9.10Michael Stahl
... which is, surprisingly enough, required to build the latest libxslt. Change-Id: Ifbb36ed61b8f68185f9c788f63a8edeb58899f94 Reviewed-on: https://gerrit.libreoffice.org/83311 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-20poppler: upgrade to release 0.82.0Michael Stahl
fixes CVE-2019-9903 CVE-2019-9631 CVE-2019-9545 CVE-2019-9543 CVE-2019-14494 CVE-2019-12293 CVE-2019-11026 CVE-2019-10873 CVE-2019-10872 CVE-2019-10871 CVE-2019-10018 remove obsolete 0001-ImageStream-getLine-fix-crash-on-broken-files.patch.1 Change-Id: I72b3bf89b294ed3e24157c7e75fd58d4f68d9f35 Reviewed-on: https://gerrit.libreoffice.org/83308 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-20honour MenuFlags::AlwaysShowDisabledEntries for native gtk menusCaolán McNamara
Change-Id: I3d26320061f3da01e9b857cb3dad277f3d7aa4f5 Reviewed-on: https://gerrit.libreoffice.org/83293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20/safeseh valid only on Win32Julien Nabet
On Win10 with master sources updated today + Visual Studio, I had this part: [build CXX] bridges/source/cpp_uno/shared/component.cxx Microsoft (R) Macro Assembler (x64) Version 14.23.28107.0 Copyright (C) Microsoft Corporation. All rights reserved. MASM : warning A4018:invalid command-line option : /safeseh Assembling: C:/BLP/core/bridges/source/cpp_uno/msvc_win32_x86-64/call.asm [build CXX] bridges/source/cpp_uno/shared/types.cxx See this link for rationale: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers?view=vs-2019 According to https://bugzilla.mozilla.org/show_bug.cgi?id=581909 (9 years ago) "...For some reason ml64 ignores the -c following -safeseh..." I don't know if recent Visual Studio versions still ignore or not the following parameters but let's fix this Change-Id: I9ae5416f32429597fab35fcce8bf06707af4def5 Reviewed-on: https://gerrit.libreoffice.org/83230 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-20hide help buttons when LibreOfficeKit::isActive and local help unavailableCaolán McNamara
Change-Id: Ia263f9f7c78dbf48143678fc2f577402fb1ce998 Reviewed-on: https://gerrit.libreoffice.org/83304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Removed executable permission on fileAndrea Gelmini
Change-Id: I331f6edcd530d0d409986cf40ebc05b134dfbd1d Reviewed-on: https://gerrit.libreoffice.org/83314 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-20Turn useless OSL_FAIL/OSL_ENSURE into assert()Eike Rathke
Change-Id: Idc1cbb5ba7580963dd47f293d4104998d1f0095d Reviewed-on: https://gerrit.libreoffice.org/83218 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-20tdf#128812 speed up loading calc doc with lots of countifNoel Grandin
by creating a copy of ScQueryCellIterator that is specialised for this use-case. Takes the opening time from 50s to 8s on my machine. Change-Id: I193a7c181a5dfed6fecf75e871729d73625d0df6 Reviewed-on: https://gerrit.libreoffice.org/83299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20linetab dialog page updateandreas kainz
Change-Id: I6e152f69850d1fd3671660decd4186d8cd29465e Reviewed-on: https://gerrit.libreoffice.org/82047 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-20consistency wrt notification events for treeview cursor changeCaolán McNamara
Change-Id: I4ecc13cd7163304c0fa1683e75299d03ccc06446 Reviewed-on: https://gerrit.libreoffice.org/83283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Resolves: tdf#128900 can't edit initial macro with empty user profileCaolán McNamara
Change-Id: I5e28a4253b755fc3f5ed7c02c99c2611513e5bd8 Reviewed-on: https://gerrit.libreoffice.org/83282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Add some more source files for breakpointing convenienceTor Lillqvist
Change-Id: I0008393be56341fe7e1f385bd111475b67446240
2019-11-20tdf#124399 DOCX import: don't apply inside borders to 1-cell tablesSzabolcs Toth
Extra cell borders appeared on the bottom, top, left or right of the 1-cell tables when only the "inside borders" option was selected. The extra borders were the ones that would normally have appeared as inside borders if there were more than one cells in the table. Change-Id: I05d5f2a5a0168989f220d20a95b6dacf5152f9f7 Reviewed-on: https://gerrit.libreoffice.org/82675 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-20emfio: add SAL_WARNs for unimplemented EMR_COMMENTsChris Sherlock
Change-Id: I449a0c2db77888a87a0ae983617848a9f0886ef1 Reviewed-on: https://gerrit.libreoffice.org/83233 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-11-20Resolves: tdf#128811 Alignment option "Distributed" not working in calcCaolán McNamara
Change-Id: I605b62ef0dfa29db93e4d7df8285a05a12bda8e3 Reviewed-on: https://gerrit.libreoffice.org/83270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20sw: revert change in expanding hints in SwXText::insertTextContent()Michael Stahl
The SwXText implementation for inserting text works like this: * XTextPortionAppend methods appendTextPortion()/insertTextPortion() get the text properties passed as a parameter, and they should apply only those properties to the inserted text, not expand any existing formatting hints at the insert position. * XSimpleText method insertString() does expand existing formatting at the insert position, just like editing in the UI does For inserting XTextContent: * XTextContentAppend methods appendTextContent()/insertTextContentWithProperties() with properties parameter, similar to XTextPortionAppend * XTextContent::insertTextContent(), without properties So arguably, by analogy to inserting text, the methods that take properties should not expand hints, and the insertTextContent() should follow the insertString and expand hints. Commit 18cbb8fe699131a234355e1d00fa917fede6ac46 is an important bugfix for writerfilter import, but the problem is, it added the DontExpandFormat() call to insertTextContent(), whereas the regression it was fixing (from commit 232ad2f2588beff50cb5c1f3b689c581ba317583) was that the call was removed from insertTextContentWithProperties(). So restore the state before 232ad2f2588beff50cb5c1f3b689c581ba317583. Turns out that SwUiWriterTest2::testTdf126206 was checking how a bookmark-start is formatted instead of how the text is formatted. Change-Id: If524409f88a1a36aa062b6e132996d3f9c1bb571 Reviewed-on: https://gerrit.libreoffice.org/83223 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-20tdf#127711 Fix msi-soffice.ini CrashDumpEnable-entryJuergen Funk
when the switch --disable-crashdump is set, then the switch "CrashDumpEnable" set to "false", was only in instdir/program/soffice.ini, but was not in soffice.ini in msi it was always true Change-Id: I2668c1425a776fdf5f0c4e4511c2216e8f418a5b Reviewed-on: https://gerrit.libreoffice.org/83171 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-20ofz#19010 wrong start of rangeCaolán McNamara
Change-Id: Ibf97a830932d3f153b99031abc8c4a00b54cedab Reviewed-on: https://gerrit.libreoffice.org/83265 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-11-20drawinglayer: handle more primitives in the xml dumpMiklos Vajna
In preparation of writing a test for semi-transparent shape text. Change-Id: I2dac94a6cd9da48de9a5e407ceab78fb8be933d7 Reviewed-on: https://gerrit.libreoffice.org/83264 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-20Page Dialog updateandreas kainz
Change-Id: I7789ad1d4facb966ddc9ed4ed7201052809ce375 Reviewed-on: https://gerrit.libreoffice.org/83246 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-20tdf#42949 Fix IWYU warnings in framework/*/*cxxGabor Kelemen
Also drop the now unused framework/inc/general.h Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8e19036a507dbdcd178835b6ac4182719d27a654 Reviewed-on: https://gerrit.libreoffice.org/82744 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-20use correct parser overrides in ConvDicXMLImportContextNoel Grandin
after commit 36c965311f53dd9feae63ed4f8ab6de4cc449b99 Date: Sun Sep 29 19:40:09 2019 +0200 use FastParser in linguistic Change-Id: Ie337e53d12053068a63aee2d2fc48903e256302b Reviewed-on: https://gerrit.libreoffice.org/83259 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20PendingOverflowCheck in TextChain is unusedNoel Grandin
Change-Id: I575865d79fc279ec017b6af461003f77e9c6073c Reviewed-on: https://gerrit.libreoffice.org/83258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20loplugin:unusedmethodsNoel Grandin
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20Enable/Disable of children shouldn't be necessaryCaolán McNamara
Change-Id: Ied2c1b1305cd099f0a7a4c403c4a81a94234f363 Reviewed-on: https://gerrit.libreoffice.org/81134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20cid#1399334 Uncaught exceptionCaolán McNamara
and cid#1399224 Uncaught exception cid#1399153 Uncaught exception cid#1399090 Uncaught exception Change-Id: Icbafde4a1e1bd1713c25a20337f3e2d0f4103cad Reviewed-on: https://gerrit.libreoffice.org/83240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20tdf#42112 Add support for Custom Line CapBartosz Kosiorek
original patch updated by Chris Sherlock Change-Id: Ie68c3cc40d2c7263a0f786a973da77b00e4cbeb8 Reviewed-on: https://gerrit.libreoffice.org/82564 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-11-20expand out some macrosNoel Grandin
Change-Id: I5a2f6068ae80b9491af7f633564dd49358b0d3d1 Reviewed-on: https://gerrit.libreoffice.org/83257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20Use initializer list for unordered_set hereMichael Weghorn
Change-Id: I9099308834d7bf463bd92c07edc86b8e0aa1fe84 Reviewed-on: https://gerrit.libreoffice.org/82785 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-20Load "PrintTextPlaceholder" and "PrintHiddenText" based on configMichael Weghorn
While looking at tdf#118263, I realized that the "PrintTextPlaceholder" and "PrintHiddenText" attributes are unconditionally taken from the settings.xml when opening a document. All of the other options related to what content to print in "File" -> "Printer Settings" -> "Options" are (not) taken from the document based on whether the "Load user-specific settings with the document" option is enabled or not (in "Tools" -> "Options" -> "Load/Save" -> "General"). I didn't find a reason why those two should be handled differently, so also add them to the list of options not to load from the document if the above option is disabled. Change-Id: Id7e4810c10f4809650eab1f20a2caaf6881bf23d Reviewed-on: https://gerrit.libreoffice.org/82784 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-20Comment some code which resembles a wrong copypaste (sw/portxt)Julien Nabet
Thank you Miklos and Michael S! Change-Id: Ia24e2b9d39d919c26be3c7a5c38f9de875aad2e5 Reviewed-on: https://gerrit.libreoffice.org/83228 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-20Add SolarMutexGuard to infobar api methodsSamuel Mehrbrodt
Change-Id: If7fab7df7566b1db770437090115b064b98257c6 Reviewed-on: https://gerrit.libreoffice.org/83255 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-20Line Shadow Dialog updateandreas kainz
Change-Id: I59294e8de213059cb0bdc28b5006ee202019210a Reviewed-on: https://gerrit.libreoffice.org/83234 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-20connectivity: avoid redundant access specifierMiklos Vajna
Change-Id: Id30b699dfdf561a42012e620db7cafabeab3ebc0 Reviewed-on: https://gerrit.libreoffice.org/83238 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-20Options - calc - Calculate Dialog updateandreas kainz
Change-Id: Idc82bbbd7d3be045e70fe297a130f7b9197df9c9 Reviewed-on: https://gerrit.libreoffice.org/83146 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Options - calc - View Dialog updateandreas kainz
Change-Id: I4de99b93c3c3610d2ce5b19d44c1d12589a72e09 Reviewed-on: https://gerrit.libreoffice.org/83145 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Fix typoAndrea Gelmini
Change-Id: Ib5a16d8b5030e1974e5493b50caf7268c5c61191 Reviewed-on: https://gerrit.libreoffice.org/83242 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19Options - User Data Dialog labels left alignandreas kainz
Change-Id: If18abdb3e6d23ada149a9cfc7b2744db9ec3b5f8 Reviewed-on: https://gerrit.libreoffice.org/83124 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Fix typoAndrea Gelmini
Change-Id: I7068288ae990c9909000e9b088c03f3608694f6a Reviewed-on: https://gerrit.libreoffice.org/83241 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19Fix typoAndrea Gelmini
Change-Id: Ibc8c9e96d172eff616b946d3263e0bbe1ebc18fc Reviewed-on: https://gerrit.libreoffice.org/83226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19Fix typoAndrea Gelmini
Change-Id: I5ae932e727eb3bb4cef3f7e160c3ace32e3f7d47 Reviewed-on: https://gerrit.libreoffice.org/83225 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19don't crash if a linked to object is deleted after the doc is loadedCaolán McNamara
Change-Id: Ia6ab1261745d223dcf84b638edf6a64d46bc6f4b Reviewed-on: https://gerrit.libreoffice.org/83201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19LinkWarnDialog "ask" checkbox should be aligned with contentCaolán McNamara
there is a special argument to MessageDialogController to acheive that Change-Id: I0990cdc1f07479c23184e9b70914e611708dbd96 Reviewed-on: https://gerrit.libreoffice.org/83177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19ofz#18554 sw: fix Null-dereference due to overlapping fieldmarksMichael Stahl
The problem is that the WW8 import wants to set a fieldmark on a range that contains only the CH_TXT_ATR_FIELDEND of another fieldmark: (rr) p io_pDoc->GetNodes()[12]->m_Text.copy(33,10) $30 = "\bÿÿÿ\001ÿÿÿ\001 " MarkManager::makeMark() must check that a new fieldmark never overlaps existing fieldmarks or meta-fields. While at it, it looks like the test in DocumentContentOperationsManager::DelFullPara() can't necessarily use the passed rPam, because it obviously deletes entire nodes, but at least SwRangeRedline::DelCopyOfSection() doesn't even set nContent on rPam. Also, the check in makeMark() triggers an assert in CppunitTest_sw_uiwriter testTextFormFieldInsertion because SwHistoryTextFieldmark::SetInDoc() was neglecting to subtract 1 from the end position for the CH_TXT_ATR_FIELDEND. Change-Id: I46c1955dd8dd422a41dcbb9bc68dbe09075b4922 Reviewed-on: https://gerrit.libreoffice.org/83000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#128889: don't write "page break after" into w:pPrMike Kaganski
This produced invalid OOXML, which Word considers as "page before", and LibreOffice ignores when re-importing. Make sure to write it as *trailing* w:r with w:br, as Word also does when imports ODT with this atribute, and saves as DOCX. Change-Id: Ifc4f45d65d4455ecb5cd62aed1ef6a03375c8aa4 Reviewed-on: https://gerrit.libreoffice.org/83232 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-19cid#1448453 Untrusted value as argumentCaolán McNamara
Change-Id: I41a2f30df22b54e51acb593f340cb1ecf1c497b6 Reviewed-on: https://gerrit.libreoffice.org/83037 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19Fix loplugin:fakebool (clang-cl)Stephan Bergmann
...where it failed with > In file included from C:/lo-clang/core/extensions/source/activex/SOActiveX.cxx:23: > C:/lo-clang/core/extensions/source/activex/SOActiveX.h(160,1): error: VarDecl, use "bool" instead of 'BOOL' (aka 'int') [loplugin:fakebool] > BEGIN_MSG_MAP(CSOActiveX) > ^~~~~~~~~~~~~~~~~~~~~~~~~ > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1423~1.281/atlmfc/include\atlwin.h(2692,3): note: expanded from macro 'BEGIN_MSG_MAP' > BOOL bHandled = TRUE; \ > ^~~~~~~~~~~~~~~~~~~~ and no idea why I did the getImmediateMacroCallerLoc call in 913d34ec6b8fdb2796f76ce90fee51ade2051189 "Extend loplugin:salbool to loplugin:fakebool". Removing it doesn't cause any issues at least with my local Linux and Windows --enable-compiler-plugins builds. Change-Id: I64bd906a34e724aefe980ce8ff2b675e8fb2ec8a Reviewed-on: https://gerrit.libreoffice.org/83212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:fakebool (clang-cl)Stephan Bergmann
...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast Change-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90 Reviewed-on: https://gerrit.libreoffice.org/83207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19Fix multiple documentation sections (osl)Julien Nabet
Fix these warnings: Line 45: /cygdrive/c/BLP/core/instdir/sdk/include/osl/file.h:1308: warning: return value 'osl_File_E_LOOP' of osl_removeFile has multiple documentation sections Line 49: /cygdrive/c/BLP/core/instdir/sdk/include/osl/file.hxx:1893: warning: return value 'E_BUSY' of osl::Directory::remove has multiple documentation sections Line 50: /cygdrive/c/BLP/core/instdir/sdk/include/osl/file.hxx:1361: warning: return value 'E_LOOP' of osl::File::remove has multiple documentation sections Change-Id: Id82280efd9c6d1e33df966159dbef677839f6083 Reviewed-on: https://gerrit.libreoffice.org/83229 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-07-12 21:32:11 +0000