summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-08-28xmloff: support stroke/line complex color import/export + testTomaž Vajngerl
Change-Id: I4ed901fd5b23e58aafa781e2b07f460f034fbba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155685 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9d1140cb745613625bbd8af251c778a7c789e6d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156162 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sd: change fill/line theme colors for graphic styles on theme changeTomaž Vajngerl
Change-Id: Ieeb425519e805160bf6726a64086508290f9d521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155684 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit b5aaf194866c5e416167cb54d37f9f04dabc5375) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156161 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28Fix setting ComplexColor for lines/strokes through the dialogTomaž Vajngerl
Setting the line/stroke color through the (tab) dialog did not work as the complex colors was not set to the XLineColorItem. Change-Id: Ie1404264f2f82964fe3a5507a6f61ba269254134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155683 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 37203cb43758048134584f7d52efbc9b3dc59f65) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156160 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sd: add ThemeDialog to Impress/Draw, refactor ThemeColorChangerTomaž Vajngerl
Add "Theme" menu action, which starts the common ThemeDialog. Add Impress/Draw specific ThemeColorChanger and remove the one in svx, so that only the interface and common function remain. Rename the svx ThemeColorChanger files to THemeColorChangerCommon. Change-Id: Ibf07a443cadf0452747ab6685f65df37b145c984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155682 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ad873064b0135e4e00389cd38c7de688286c1fa1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156159 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28move theme test from svx to sd - so we can use ThemeColorChangeTomaž Vajngerl
Change-Id: I39cdc3baf81d3cb75d21ec963c05be57b97f30ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155865 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit eb217182a5c44de748218fea009a245254f30b95) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156151 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28ComplexColor various clean-up and (trivial) refactoringsTomaž Vajngerl
Don't allow access to member variables of ComplexColor and makes them private. Needs a lot of changes. Change "scheme" to "theme" to be more consistent. In LO we usually call the "theme color" what is usually refered to as "scheme color" in OOXML, where it is sometimes refered to as "scheme" and other times as theme color. Remove ThemeColor class which was replaced with CmplexColor some time ago. Remove un-needed includes and un-needed components. Use isValidThemeColor in many places where we check that the ComplexColor is of "Theme" type and that ThemeColorType is set to a valid value. Change-Id: I325595fa65b8e56a4707e9d22acc6330aac28961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155359 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9d5a7d9257db78eb3f4d77c39eae1affe877ea6b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156150 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: fix tiledrendering test execution order issue with comment IDsTomaž Vajngerl
ScPostIt::mnLastPostItId is a static variable, which is used for generated the comment ID. In the test we depend that the ID are consistent and start with 1, but as we have more tests that insert comments this can be a problem. testCommentCallback and testCommentCellCopyPaste, both add comments and the expected execution order is testCommentCallback and then testCommentCellCopyPaste, so the latter test resets the mnLastPostItId variable to 1, so the IDs are consistent. In a LO 7.6 build for Fedora, it happened that the testCommentCellCopyPaste was executed first and testCommentCallback afterwards, but in testCommentCallback we do not reset the mnLastPostItId and the build failed. This change resets the mnLastPostItId also in testCommentCallback. Change-Id: I123b2f47b0d6177b2f5bdefcf6d8e9c301a7413b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155498 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3dcf2acadb847ec76d7e1dff3b4b730a64b52c41) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156129 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: theme color support for sparklines + ODF & OOXML import/exportTomaž Vajngerl
This changes Sparkline colors to use complex colors instead and adds Sparkline theme color import and export support for ODF and OOXML. Change-Id: I58edd525d50f95199bd4fe7825afb51aaa7fc091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155113 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c8d8bf4282cbd04abacfa69ba2cc0fa4300e35e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156106 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28fix C/P typo that allowed setting LumMod color transform value 0Tomaž Vajngerl
should be m_nLumOff instead of m_nLumMod Change-Id: I14b04fb0fecad949a41abf752d2ac05ceed5ba83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155112 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 144d16443a74839f885dc9597bee1e48493b278f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156105 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28set finalColor of the ComplexColor in BorderLine and BrushItemTomaž Vajngerl
The final color is stored inside the ComplexColor and is used to represent the final computed color from theme color and/or transforms. Change-Id: I405615bba144bfe876b75c565746d9eebc88e973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155111 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 614dfb98cd4705b63bf1e525d3d34df9ce950ebb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156104 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: remove code duplication at OOXML export of ComplexColorTomaž Vajngerl
This removes the code duplication when exporting the ComplexColor to OOXML. Now we use a common oox::xls::writeComplexColor function which writes a ComplexColor to the stream. Change-Id: I4e7bb1f8427409d09550c71894c327dba5096bec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155110 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit fc996d8d195263f09d8aaf65deaf9d42f7413be8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156103 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: rename oox::xls::Color to oox::xls::XlsColorTomaž Vajngerl
It's annoying that the class name is so similar to the commonly used class Color, even when it is in its own namespace. To avoid unneccesary conflicts and confusion, it was renamed. (Similar would be also good for oox::drawingml::Color) Change-Id: I68dcaf951b7faf089cb2b13d94576007f40c441e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155109 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7f265875ef784d717f5a534bdca2cd36fdce7ecb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156102 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: Add import/export ODF support for border complex colorsTomaž Vajngerl
ODF Import and export support for border {left,right,top,bottom} complex colors. In addition round-trip test was extended with the border use case. Change-Id: I1d14690272c06e8ffcfcd483eb7f688ca5bb1e5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5e34a25aa7f58b37a2303aef9318bbe5a9af5d37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156101 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28xmloff: fix import of CharComplexColor - add StylePropertiesContextTomaž Vajngerl
Import of CharComplexColor in Calc didn't work because the class XMLComplexColorContext wasn't used. This introduces a new class StylePropertiesContext, because the plain SvXMLPropertySetContext is not enough as we can't define to use XMLComplexColorContext when XML_CHAR_COMPLEX_COLOR is used on that class. Also adds a import/export test for CharComplexColor. Change-Id: I765ac71a801a5e9bcb105aaea73637df5e601b85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155008 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit b543463f639ecee793484e8b419147d565a53d52) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156100 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28sc: ODF import/export of background cell complex colorTomaž Vajngerl
Change-Id: Idf526aea21ccfeda9b03d1fb69588f120b6e161d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit dceeb9550dfd4e40e93180b7e10f2539b594529f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156099 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-28xmloff: move XMLComplexColor* import/export classes to public includeTomaž Vajngerl
Change-Id: I52aad31f63858eba905481812cbf971493252642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154570 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 2455826917868a5da5ab1bb4586e067d6c968c43) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156082 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-26Bump version to 23.05.3.1co-23.05.3-1Andras Timar
Change-Id: I3eb41d0b42dc52b1c8f3fe794f018f4bc519339d
2023-08-26tdf#156611 SC: hyperlink option for MS behaviourAttila Szűcs
Added an options that can limit Calc to behave like MS excel in case of inserting hyperlinks, when MS format document is used. Tools -> Options -> LibreOfficeDev Calc -> Compatibility -> Hyperlinks In MS excel, only cells can have a hyperlink, and only 1. In Calc even textfields in a cell can have hyperlinks, so it can have multiple links in a cell, but once saved as MS format, and reloaded, textfield links will become cell links, if there was 1 link in the cell. If there was more links in the cell, then all will be lost. So, when MS excel format document is edited in calc, the ability to make text field links is useless can be missleading, and confuse users. If this option is set, and an MS file format is opened, then insering a hyperlink will work like if we selected the whole cell to insert the hyperlink. Change-Id: I7174216d10cf250d48f23f71ae681c46f7610bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 24cd55341bc3f3e8ed9d5ff23efd47a53532f283) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156009 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-08-26spellchecking wave doesn't extend to the full width of superscript textCaolán McNamara
or subscript, e.g. enter tmalltmalltmalltmalltmalltmalltmall in impress, format character, position, superscript, ok and without this change the wave extends only 80% of the width of the misspelt text Change-Id: I5d3ad61541152199809c950349533ca3fa7ed1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8ec43f37a7a5babe9227a5ca1ea84720fc2e15e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155924 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-08-26crashreporting: crash seen in FormNavigatorCaolán McNamara
set_text(rVclIter.iter, rText, col); ... m_xTreeView->set_text(*xEntry, pNameChangedHint->GetNewName()); ... m_pNavModel->Broadcast( aNameChangedHint ); Change-Id: I31275dd37de0146eae2ebb0931a5450e34fd21fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155991 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-08-25sw floattable: don't split if anchored inside a footnoteMiklos Vajna
See <https://gerrit.libreoffice.org/c/core/+/156025/1#message-94d8cdd4d59a4b991186e5780d41f213105a533d>, if we import an (inline) table inside a footnote from DOCX, we currently put that into an as-char anchored fly. In case the user would later change the anchor type to to-para, then we would crash in SwFlowFrame::GetPrevFrameForUpperSpaceCalc_(). Avoid all this trouble by simply not allowing split floating tables in footnotes, seeing that the Word UI is also disabled for this case. (cherry picked from commit 2e1ddc8aeb0a92cc43ef4b7dc4762cd50a6b7fbc) Change-Id: I3cf9461beb291084e1cced5c66ca14e6b6d55126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156085 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25tdf#77760 sw floattable: add support for footnotes, DOCX importMiklos Vajna
This was originally added in commit 2fe248f2b36d541c0d243a620c217058a50a9d5d (tdf#87460 DOCX import: fix missing endnote in floattable, 2015-06-23), because Writer core only allows footnotes in floating tables since commit 56da1d30afe48cc4acd79567052a575e81f8c7a0 (tdf#77760 sw floattable: add support for footnotes, doc model, 2023-08-22). The DOCX export works already. The ODT filter also works: there is a mechanism to try to not insert footnotes in text frames, but the way XMLTextImportHelper::IsInFrame() is implemented means that it only rejects footnotes directly in text frames, not in tables-in-textframes, which is the interesting case for us. (cherry picked from commit 178421a6c719dac9c16f220b76292fec16a53f60) Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport19.cxx Change-Id: I90a5f0228385b2e3db8d994c6c76064fe595f439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156084 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25sc: add test for changing theme colors and undo/redoTomaž Vajngerl
Change-Id: Ieaae64cd6cfd96b8c1627cf1c3935bc546a36617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8e4fb36a69d517bc5111d64d12b2c7df4f9791de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156081 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: Theme color change undo/redo - styles and direct formatTomaž Vajngerl
This adds the code for undo/redo for change of theme colors in styles and direct formatting. Change-Id: I58568b18ab18562e6148ec8530d3d22c62ef2b95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6f77ed620bbff11a1232b593be97e7d6f29aa8ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156080 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: test export of model::Theme into theme1.xml with xpathTomaž Vajngerl
Change-Id: I9b2b61a5ae93a0738fb90aa20b20f9a9ecc7272b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153786 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 8164915520b27b655372e7521b2a58978516f88d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156079 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: add border export and enable round-trip testTomaž Vajngerl
Change-Id: I76071185d819b9645d97a3e599ea7f48b341a145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153820 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 42bbc9fbdf940e55213ee2a259c1d31de2e4cbec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156078 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: OOXML export of theme colors for text and backgroundTomaž Vajngerl
Change-Id: Ifd0d8184c9210caa5ca099767baa5dbbf8783f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153785 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 20dbfa10d851b9df67fab561c3b86cba4f55cc8a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: change theme color for SdrObjectsTomaž Vajngerl
Change-Id: I318821c843fe937b7011f1674809f8c78df24a2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153938 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 30ee52e6c284be1095fdf278439b4c0a7c5982f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156076 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: fix failed assert in when setting a color on a shapeTomaž Vajngerl
When setting a color with a colorpicker, and assert failed, because it's not possible to clone a SfxItemSet by value - use a plane Clone instead, which clones into a SfxItemSet. Change-Id: I8780ed42d3807e9802d3f4fa1d68e16bd5d5a5e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153937 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 548e5b6d825606bd218ef18591df642872e6acd0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25svx: PaletteManager - remove printfTomaž Vajngerl
Change-Id: I7d631352d423b6465d8bea4b09561f33d2ad98f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153936 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit cbc45a7f713ea1f2c44ed27b371e342ed7547e05) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156069 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: OOXML import and export the model::Theme properlyTomaž Vajngerl
Change-Id: I76fc928a53d007a9f5e9174167e0594208a4b47a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153784 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 9a6cdc8a90cd32e8d9ecdae6fb6684cfa8aadbab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156068 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25tdf#101895 don't unconditionally default to ch[ar]/lineCaolán McNamara
if CJK typography is available. Given that we choose to show cm vs inch based on SvtSysLocaleOptions::GetRealLanguageTag() also choose to use ch[ar] and line based on that setting when bApplyCharUnit is enabled. Change-Id: I812d05e0639f7e214d5c3d4dcca01b0709126fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155949 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: improve import tests for text, background, border theme colorsTomaž Vajngerl
Change-Id: Icdc658e47c0e4fe20b2b38897d31278f058a6a75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f0c8ccaef39dc7cb876e00679f70c36ca60883d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156067 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: Add import tests for text, background, border theme colorsTomaž Vajngerl
Change-Id: I03f0ddb42e6491618e56ba98f5bd8befc9ba47a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153506 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e836e69eb6f2f01a475c5679fb338dda7936643f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156066 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: use ComplexColor for font color (+others) in OOXML exportTomaž Vajngerl
Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7501f8928264c48c88ab6ee6b757b295b13b63d4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156065 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25oox: convert Excel tint value into LumOff and LumModTomaž Vajngerl
tint value can be converted into LumOff and LumMod values, so we don't need a special Excel case for calculating the final color. Change-Id: I0725c06f9df6a37a309ea5d17b183e4100a228f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153716 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ba29922dcc0a7b079fb76df445c4cd3a80102e83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156064 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-25sc: import and prop. theme color support for cell bordersTomaž Vajngerl
Adds import for theme colors for cell borders and UNO properties for the cell border theme (complex) colors. Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 28e9f2bc390e10339859306ad5f733d377134ca8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156063 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-24add a SfxLokHelper::notifyInvalidation which can take a 'part'Caolán McNamara
no change in behaviour intended Change-Id: I6040eafb03bcf39724761d7708540e9b25edd8f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 560b5112f6738f02a12adec7d5be04e2411c93b9) add a LogicInvalidatePart which can take a 'part' no change in behaviour intended Change-Id: Idee6615cc86cd01bea9aaf17fff2840eea6521a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 28d41e60416ef10ae2a59d1c4ad34a2eb75dc408) for LibreOfficeKit::isActive we can skip to LogicInvalidate it should be the same effect Change-Id: I2faa0b728fdebe837855e1f23e066ae8b1a2bde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155815 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit a35311beef378c15ecbb3bb0560035c17f4657ca) on invalidating other views, specific what Tab is invalidated the other views might be viewing other tabs and it is only the tab ('part') this view is on which is invalidated Change-Id: I9f054ffa6158a6bc62e3eb7b7170450e26870b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 34d32740d89876c3d4fd2743a07d6e2578601683) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-08-24sc: simplify and fix prop. mapping for cell BG and char theme colorTomaž Vajngerl
Change-Id: I461106200d37f0c605c07095c6b5871ea89e0e20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153501 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit bcd3ca80cd1f59c4b94660daa8c3e66944caf58f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156028 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-24sc: ThemeColorChanger - change theme color for bordersTomaž Vajngerl
Change-Id: Id6b08ad48b496d2f1138aeea8d024a5f61bee633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153500 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 95d199e3d1a04a469e1d22896ffd967c7a06c3f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156027 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-24oox: map color transforms direct to create model::TransformTomaž Vajngerl
Change-Id: I82382f8d0936e90218fefe889ea5bfdd04c3e82b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153507 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 163ad701b61af6888bb9fbaaf2d8a49054f9a846) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156026 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-24tdf#77760 sw floattable: add support for footnotes, layoutMiklos Vajna
Once the footnote was inserted to the document model, the layout was also missing (footnote portion, footnote frame). One problem is that the footnote portion was empty instead of the footnote counter, because SwTextFormatter::NewFootnotePortion() returned early in the fly case. The other problem was the missing footnote frame, but once the footnote portion was created correctly, the matching footnote frame was also created. File filters (ODT, DOCX) still needs more work. (cherry picked from commit f8e1a62f944e5358fe498008b4ff8701f1e190a0) Change-Id: If71c44962f604f23fdcfccfe80b0d97787fd99d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156025 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-24sc: theme color export for cell fill color + testTomaž Vajngerl
Change-Id: Ibaad410f094f86d9f7197090db702ae45340c239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151859 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 25aa310b923ac26b62a97c0e95549e053d294da4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155550 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-24tdf#144073 and tdf#147645: use bounds and angle for gradientPatrick Luby
Passing an expanded, rotated polygon noticeably modifies the drawing of the gradient in a slideshow due to moving of the starting and ending colors far off the edges of the drawing surface. So try another way and set the angle of the gradient and draw only the unadjusted bounds. Change-Id: I95441dfa3215396d5bc7edfa9f985335480b37de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155729 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 9e0249b62afeca701dec27a4371f20829775422a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155705 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-08-24tdf#156419 sw: layout: don't prevent moving between linked flysMichael Stahl
... when there is a page break on the next page. Of course you can put a section into a fly, and then link multiple flys. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I5cb854fc7ee5caa2af4e04f4da2d8a8083c0d007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 987fe1175de2db53235cc6f2441335fcc3548d64) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155845 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-24tdf#156725 sw: layout: don't prevent moving between columns ...Michael Stahl
... on the same page when there is a page break on the next page. The existing, presumably pointless/always-false in case of same page, check of WrongPageDesc() let me assume that this would only be reached if the current page and the target page are different, but that was a mistake. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit db83c41d460103df5d80f5bd99816575c4ead5cd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155844 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-24update creditsXisco Fauli
Change-Id: I9747388a7b1514a165b2e6aad3e211139a0e4633 (cherry picked from commit 3a3060f6eb1f6d66fe230f919e560c28987135be)
2023-08-24sw: prevent crash in TextContrastCheckTomaž Vajngerl
Change-Id: Idc8740a275b9f49aca08d8a3add9a88f9d53a220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152012 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c53a8284cf1740af7035b952fbc040a785117319) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155789 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-24update creditsXisco Fauli
Change-Id: Ife0d509b91f17510e6a32494e6456fe7043781ec
2023-08-24tdf#151866 sw: layout: prevent deleting newly created SwSectionFrameMichael Stahl
A section frame is created so that content can move back from another page into it. Apparently only the pPrv frame is on the same page, and formatting it in SwFrame::MakePos() moves it backward, then CheckPageDescs() sees a page with only empty section frames on it and deletes the whole page. (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I4f8e4debd4bcf993c9355dcfc3ced779fe6732ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155467 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2f9e67d1e70bdc45dfc59554547bc3730481a757) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155475 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>