summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-12bump product version to 5.2.5.1.0+libreoffice-5-2-5Christian Lohmaier
Change-Id: Idb43b0caf384217c43a3ccad3b20c58f4177b00f
2017-01-12Branch libreoffice-5-2-5Christian Lohmaier
This is 'libreoffice-5-2-5' - the stable branch for the 5.2.5 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.2.x release, please use the 'libreoffice-5-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ic9645219a607c0a669b14d77b72a5d741b4eb8e8
2017-01-12tdf#105182 sd: avoid iterating too far in SdOutliner::Initialize()Michael Stahl
Considering the valid indexes are extended by "-1" for backwards iterators and "size()" for forward iterators, it's obvious that a not-yet-at-the-end-in-the-other-direction iterator can be incremented once, but not necessarily twice. Why this code even wants to increment it twice isn't obvious to me. Change-Id: I578c8c6202049ebe6dbed41b8276a6bfa0566bbc (cherry picked from commit aa1ee198b5b55d0a92418eb3294c93553e8513dd) Reviewed-on: https://gerrit.libreoffice.org/32975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-11tdf#101841 MM correctly account record selectionsJan-Marek Glogowski
Don't reset the pParam->xResultSet for selections when querying the result count. This actually resets the selection. * MM just increment after a successful next record This correctly counts the record id from 1, while using 0 for the first item in the selection array. (cherry picked from commit 178a23a827f16e046e5d5efb2aa2aa3fc990452a) * MM account next record fields for progress dialog When calculating the maximum document count, we were not accounting "next record" fields in the document, like in labels etc. Also any selection of records was ignored. Fixes accounting part of tdf#101841. (cherry picked from commit 260cd3aeea2d02507dd131ee2028c4f48f7562f8) Change-Id: I458e9e2e1af122f8324bcd873fd35ffcf89d62d3 Reviewed-on: https://gerrit.libreoffice.org/32184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-11Resolves: tdf#104711 adjust range reference constructed of named anchorsEike Rathke
A constructed range reference of named anchors (i.e. extended during expression compilation) forms a range listened at that needs to be adjusted if the cell is shifted and one or both anchor parts are individually named relative references. Currently the resulting range (ScComplexRefData aka DoubleRef) does not know to distinguish between whether its anchors are the result of a literal range in a named expression or the result of individually named anchors, so such RelName DoubleRef needs to be adjusted unconditionally when shifting or moving the formula cell. Change-Id: I75e2cc79ac60116671acce7641567337d5f5f7ed (cherry picked from commit 439b2a134218b93e6ca9fa23005b89c19498f586) Reviewed-on: https://gerrit.libreoffice.org/32924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-11Updated coreChristian Lohmaier
Project: translations 82afb6e52e019d26c110a745d68d5b882bb4bbe5 another update for translations for 5.2.5 rc1 Change-Id: If7935fd0b029bbb8444e11f9ab5e04e3ac1167a5
2017-01-11tdf#104830, need an own termination listener for lib objectsMarkus Mohrhard
The destruction of the SwDLL object happens already through the normal termination listener but the other termination listeners might still depend on it. Also the outstanding events might need the SwDLL instance to be still around. This makes the destruction of the instance explicit and at a time when it should be safe. We should use the same code for calc, impress, math and base as well. Change-Id: I50b8f30426f5a4a54e362e748fe962839abca73e Reviewed-on: https://gerrit.libreoffice.org/32856 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ad915fafd54f9115faea7147f82d80a942af2d68) Reviewed-on: https://gerrit.libreoffice.org/32928 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-11update creditsChristian Lohmaier
Change-Id: I7e32a57cf6941d36e0bbcfb447065c4b0d56f8c3 (cherry picked from commit 05d509482cedb7d7c4697a76e80352e430fd8c7e)
2017-01-11update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: I846126090a6bdf0c158eb6d23707d1244c30e41e
2017-01-11Resolves: rhbz#1408500 gtk3 toolbar borders too distinct vs native gtk3 onesCaolán McNamara
Change-Id: I7ce284d3e6f999e2ac08326dc40b060bf70d7d4b (cherry picked from commit 5088b2066651ed133dcfd93388f7ac7187844d33) Reviewed-on: https://gerrit.libreoffice.org/32955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-11tdf#105199: Keep URL intactStephan Bergmann
(cherry picked from commit 6a68e364faa0d384f1e3bf397f5decaadecf9b3b) Conflicts: sd/source/ui/dlg/PhotoAlbumDialog.cxx Change-Id: I85681fcc81246414332f88dc46ce4a4b60896c97 Reviewed-on: https://gerrit.libreoffice.org/32931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-11Resolves: rhbz#1409634 crash on close storing clipboard of database tableCaolán McNamara
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f (cherry picked from commit 6c2725038b627535ba97ead89dadb96e0ff69c3c) Reviewed-on: https://gerrit.libreoffice.org/32929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-10Updated coreChristian Lohmaier
Project: translations c9a77fe62307ba509ff3b66d8ad06c1385d17a11 update translations for 5.2.5 rc1 and force-fix errors using pocheck Change-Id: I0660f62ea515fc4c672f19a5dce747245f4fa12e
2017-01-10tdf#104814 Writer: accepting change tracking changes get stuckNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/32273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b7b5c23e6979205a662d857bc1c83270fb4a43ec) Reviewed-on: https://gerrit.libreoffice.org/32276 Change-Id: Ie8e0919b53c0b21f480b62eec7c394554757a061 Reviewed-on: https://gerrit.libreoffice.org/32887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09ofz#394 xbm ParseDefine problemCaolán McNamara
Change-Id: I75fb761d23fdb3780088a9d209200429edb57a26 Reviewed-on: https://gerrit.libreoffice.org/32878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-09tdf#105151 - be more conservative about EndTracking / Tracking calls.Michael Meeks
We really shouldn't be emitting these into widgets after they are disposed - it serves only to confuse things. Restore behaviour to how it was before the VclPtr change for this. Change-Id: Ife666929f8aac0e4431a5e43970769692c11888c Reviewed-on: https://gerrit.libreoffice.org/32785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d788d37a16d382d7ff32a19e8d65e5c605ac55dd) Reviewed-on: https://gerrit.libreoffice.org/32819 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09tdf#105009 sw: fix a11y crash when removing drawing objectMichael Stahl
SwFrame::RemoveDrawObj() calls SwAnchoredObject::ChgAnchorFrame(0) so the SwAnchoredDrawObj has no anchor frame later when SwAccessibleMap::InvalidateCursorPosition() asks for the parent. (regression from 76c549eb01dcb7b5bf28a271ce00e386f3d388ba) Change-Id: Id55cb5fc41a4e37e863498265d1565e1621d508e (cherry picked from commit ade1d4c36053c2a7aed959e3dd09ebc1b8430ea8) Reviewed-on: https://gerrit.libreoffice.org/32803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-08handle paste special of single formula cell with error resultEike Rathke
This apparently was never implemented, unlike in the block pasting code that handles it fine. Formula cells with error results were always copied as is if numeric was requested, even if formulas weren't requested. Change-Id: Id550c4e757b6bb2c06aa0637328216383cdf3d6b (cherry picked from commit 12ecd30476f17c6f6efde976f8e56d604eda0f1e) Reviewed-on: https://gerrit.libreoffice.org/32744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-08display error constants written by 5.3+ in the for 5.2 usual way, tdf#105024Eike Rathke
Change-Id: I5b61ed58144ae1583d74056389478e9d5c86d2cb Reviewed-on: https://gerrit.libreoffice.org/32794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-06libpng: update to release 1.6.28Thorsten Behrens
Change-Id: Ie22e5eb6656ef1d2e7903011ea72a1aa26d4da7c Reviewed-on: https://gerrit.libreoffice.org/32768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/32769 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-01-05Resolves: tdf#105096 add xdg-email as the default email routeCaolán McNamara
because xdg-email is apparently the only route that knows how to support adding an attachment to thunderbird (cherry picked from commit 5f58670b43e5284d9460b561e774175c7a2dd7ab) Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e Reviewed-on: https://gerrit.libreoffice.org/32756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-05process all outstanding events before shutdown, tdf#104969, tdf#104286, ↵Markus Mohrhard
tdf#104399 Change-Id: Id09c3dfdc94c430d5dcb2aebb017f17db80f17e6 Reviewed-on: https://gerrit.libreoffice.org/32486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/32668 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-05tdf#96218: MSO DOCX image incorrectly placed when using Alignment PositionTamás Zolnai
layoutInCell attribute should be ignored when we are not in a table. Reviewed-on: https://gerrit.libreoffice.org/32253 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 36750bc977b3210b23b7822abd395b30a78af6f5) Conflicts: sw/qa/extras/ooxmlimport/ooxmlimport.cxx Change-Id: Ieed29c690f8516f63d0956a4f0495500908a0d27 Reviewed-on: https://gerrit.libreoffice.org/32266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-04Resolves: ofz#313 cbBmiSrc > getDIBV5HeaderSizeCaolán McNamara
Change-Id: I67fb67dc0a4cb609b8f1391c1eb6dd395755a933 (cherry picked from commit 7485fc2a1484f31631f62f97e5c64c0ae74c6416) (cherry picked from commit 371f0f6770add78ae81e0f769d0490874bca353c) Reviewed-on: https://gerrit.libreoffice.org/32338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04tdf#104981 Fix deficiencies with PERCENTRANK functions.Winfried Donkers
Added constraint check for significance argument. Replced inproper use of log() with log10(). Improved code efficiency a little bit. Change-Id: Ie918857e6a04ea9fcf18410f789d7252f9c1cfc8 Reviewed-on: https://gerrit.libreoffice.org/32528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit facb4e69e4c75839df89969206403d2e97146dbd) Reviewed-on: https://gerrit.libreoffice.org/32724 Tested-by: Eike Rathke <erack@redhat.com>
2017-01-03tdf#93124: The arbitrary number 100 seems to be too high, let's try 50Tor Lillqvist
The test fails on a tinderbox. Adding a temporary printf shows that the number there is 71. Change-Id: Ic8fbaab9e3d3434e20ba6aef5cc1acd66b5f4283 (cherry picked from commit 9c07735a0160864c949ac27de1821d6967181516) Reviewed-on: https://gerrit.libreoffice.org/32693 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-03sd: make test "testTdf93124" more robustTomaž Vajngerl
Check that the bitmap ihas been exported and imported correctly instead of seg. fault. + use ScopedReadAccess Change-Id: Ib79b5beddef5dc4f7c3435bae94c2f6a26f8ac10 (cherry picked from commit f08e1630ae56e6f3335a11020e6d2c33c4ce2863) Reviewed-on: https://gerrit.libreoffice.org/32692 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02ofz#372 check if ImplSplit succeededCaolán McNamara
(cherry picked from commit 62a97e6a561ce65e88d4c537a1b82c336f012722) (cherry picked from commit 6431e2bff67e81b4aff4e3b52e67903e1cd566f3) Change-Id: I1e34295fe3ee5f77e787f583616d52fa92a0eca4 Reviewed-on: https://gerrit.libreoffice.org/32640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02Related: rhbz#1405521 abrt reported crash in dndCaolán McNamara
Change-Id: I8d8f9379d36dd3dd1a8973cd9f9c14860765630b Reviewed-on: https://gerrit.libreoffice.org/32178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02crashtesting: assert on loading certain rtfCaolán McNamara
Change-Id: I17acf270f552571fec898e19fa2d000ec4c00df5 (cherry picked from commit 82f25d5de546225548725e4056fdf1148fe605eb) Reviewed-on: https://gerrit.libreoffice.org/31979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02valgrind: stick 0 at end of successfully read dataCaolán McNamara
(cherry picked from commit 0dfc6f70ab53a773ee05664235d7c8927ab20f2c) (cherry picked from commit 3ea598f65bed096dbf4bda5fe4105b57c58b5310) Change-Id: Id79f68c9095ab313ac05d2c8b55df71788df81d3 Reviewed-on: https://gerrit.libreoffice.org/32335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02Resolves: ofz#310: Sanitize 1 bit bitmap palette indexes tooCaolán McNamara
(cherry picked from commit b08e48166310ab8a53f06f4fee227a948416cf4a) (cherry picked from commit 3bff2da31ed580817f6b5b653f48727e38078af5) crashtesting: fix bmp->odg failure... id:000178,src:000000,op:havoc,rep:16.bmp id:000383,src:000047,op:flip2,pos:18,+cov.bmp id:000403,src:000047,op:arith32,pos:22,val:-33.bmp id:000317,src:000025,op:havoc,rep:8.bmp id:000119,src:000000,op:havoc,rep:16.bmp id:000167,src:000000,op:havoc,rep:8.bmp revealed since commit 81e3ca4f60e6ac0823c1233841c22a759cfe937f Author: Tor Lillqvist <tml@collabora.com> Date: Tue Jun 21 10:34:21 2016 +0300 Use real assert() instead of DBG_ASSERT() sanitize invalid palette entry indexes at the outer perimeter on initial load to try and avoid having to do it in all sort of places in the interior. we load the palette before getting here, so we should always know the palette size here (cherry picked from commit 92cee94a262a3a2f43c87bb940c50cb90a2ebd89) Change-Id: Ied2b71eb1c9088bbbff5fed97f7a04b43f4b4827 Reviewed-on: https://gerrit.libreoffice.org/32333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-02tdf#81263 ww8par6: only use valid sal_uInt16 values for ULSpaceJustin Luth
VerticalOrient position returns a signed SwTwips number, but ULSpace uses unsigned int16, so negative numbers were creating huge margins. fixes commit 3755c87d0426a499d4755e82d8fbc77caa240764 Change-Id: I23daea9a913ef73efc42a65e0adfc393eaf4e775 Reviewed-on: https://gerrit.libreoffice.org/32400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 604cf7024fce29143150ab77b2f14b59a45e61eb) Reviewed-on: https://gerrit.libreoffice.org/32402 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 70b3dd697cb248fb56830db691269fe9e78c57fb) Reviewed-on: https://gerrit.libreoffice.org/32648
2017-01-02tdf#104876 writerfilter: m_bTableSizeTypeInserted = false hereJustin Luth
fixes commit cbd0fbc287051f918e4adb32b3e9b58dfbf8059d which removed the insertion code with the explanation saying we should simply not do anything, and that'll lead to the right behavior, don't try to be smart and try to set TABLE_WIDTH here but still left the flag set, falsely indicating that the tableSizeType had been inserted. TODO: the table size still isn't correct. Reviewed-on: https://gerrit.libreoffice.org/32385 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e73c961a7fb23246dc4a9c27d7ed0808b9ba74b5) Change-Id: I0720083c992d1d03a5fe259d5b4b177a0c8108f8 Reviewed-on: https://gerrit.libreoffice.org/32647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-01-02Revert "tdf#103514: Always ignore bitmap fonts on Windows"Khaled Hosny
This reverts commit e80621fb04093d5ab950485357f6058dcbaf8aaf. Lots of crashes related to this change, lets revert and see if we can fix it in 5.3: http://crashreport.libreoffice.org/stats/signature/ImplReleaseTempFonts(SalData%20&) Change-Id: I86b7d85fe1bfb7be28fbed7dc8957f71d1bedc55 Reviewed-on: https://gerrit.libreoffice.org/32591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02ofz#358 SJIS_84 table mnLeadEnd is out by oneCaolán McNamara
sjis 82 and 83 correctly denote the last index available while 84 reports one past the last available index 0x84BE is the last value to map, not 0x84BF Change-Id: Idcadc2d554ee59586f6e2f2775301fe69c94d55a (cherry picked from commit 0f4eb22d5f3a86af9e5f8042c69e4ddf4a350b93) Reviewed-on: https://gerrit.libreoffice.org/32589 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-01Resolves: tdf#104812 crash on exporting odpCaolán McNamara
was crashtesting: a gadzillion failures on export to odp e.g. fdo35235-1.odp (cherry picked from commit f1c08d6503442ec257aa8535dfbe3743c743e4a0) (cherry picked from commit 09b856289c44c0fe792082b681d48cf5ee70d808) Change-Id: I259cdc9ed073be2ad7d5208cd943d4f193f09c16 Reviewed-on: https://gerrit.libreoffice.org/32275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-01tdf#71435: Accessible caret-moved events are missing when "freeze" is enabledTamás Zolnai
Two accessible document is created when "freeze" options is enabled. meSplitPos identifies which accessible document handle which part of the window. We should handle events only in that accessible document which handles the active part. Change-Id: Ic9674344951f620546dd272beaad796de611d258 Reviewed-on: https://gerrit.libreoffice.org/32065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 06ea887f8ba34a628d7641eab210501f7bd2493d) Reviewed-on: https://gerrit.libreoffice.org/32078 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#105011, tdf#104795: copy string until its end if there's no commaJulien Nabet
5 0x00002aaab055f81e in rtl::OUString::copy (this=0x7fffffff29d0, beginIndex=3, count=-4) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00002aaab070acd2 in (anonymous namespace)::GetContentPart (_rRawString="CN=timur.davletshin@gmail.com", _rPartId="CN") at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:748 7 0x00002aaab070dd85 in SfxDocumentPage::ImplUpdateSignatures (this=0x55555ca2e0b0) at /home/julien/lo/libreoffice/sfx2/source/dialog/dinfdlg.cxx:901 so do the same as GetContentPart from uui/source/secmacrowarnings.cxx (I suppose we should avoid the redundancy but that's another story) Change-Id: Ief3ce1cce7035fb572778bdee02a1073b7dfe1c1 Reviewed-on: https://gerrit.libreoffice.org/32530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5e149b630bd837ca6c8cae609a5c148f25f9ee82) Reviewed-on: https://gerrit.libreoffice.org/32533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#104539 dir attribute of outerShdw has to be non-negativeAndras Timar
Change-Id: Ic6f1c8555eb8d137ced2f4e87baa866df84c69ac Reviewed-on: https://gerrit.libreoffice.org/32471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-01tdf#104818 Show the right label when a11y enabledMaxim Monastirsky
Change-Id: If4da5b9435e96e3830bac3d01e06f7ddc87754eb (cherry picked from commit c9303b98ad69213fe346d0657a8bca5ac8fa3bd7) Reviewed-on: https://gerrit.libreoffice.org/32377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-29add a crashreporter entry when we start the shutdownMarkus Mohrhard
This will help us identify shutdown related crashes. Reviewed-on: https://gerrit.libreoffice.org/32485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Conflicts: framework/source/services/desktop.cxx Change-Id: Id09c3dfdc94c430d5dcb2aebb017f17db80f17e5 Reviewed-on: https://gerrit.libreoffice.org/32488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-29Updated coreAndras Timar
Project: dictionaries b776c82c78b1cf53fc7269b725733aaaa3d98aac tdf#97349: typo fixes in control words Change-Id: I4896dd4084582e893914f09e730a2dd7d5a08acd Reviewed-on: https://gerrit.libreoffice.org/32477 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-12-20Resolves: tdf#103938 replace fix for tdf#78599/tdf#87977Caolán McNamara
i.e. revert commit 162c72d64077d9e0dae820d881ce2b56a5b2040c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 23 13:17:39 2015 +0000 and commit ad50b9a8636e0ee2f3c80669e8dde96577b26c4e Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 23 15:52:58 2015 +0000 Related: fdo#78599 wrong method and restore the original RegisterToFormat logic, and instead block setting modifications of the document until the explicit SetModified call to avoid the original problem of trying to generate a preview of the document during the section where it cannot be done Change-Id: I9dbec0a371d4d747b780aa271789d50a46eccefd Reviewed-on: https://gerrit.libreoffice.org/31977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-20tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)Julien Nabet
bt: 1 0x00002aaade2fea5b in accessibility::AccessibleGridControlTableBase::ensureIsValidIndex (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTableBase.cxx:257 2 0x00002aaade2f97f2 in accessibility::AccessibleGridControlTable::getAccessibleChild (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTable.cxx:60 3 0x00002aaade2ee054 in accessibility::AccessibleGridControl::commitTableEvent (this=0x555557e97500, _nEventId=5, _rNewValue=uno::Any(void), _rOldValue=uno::Any(void)) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControl.cxx:354 Seems a regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f32ba56a1e775e8ecd6c827ebd48f7f2fb51c81 Change-Id: Ia973eb381832da27ecc39fc5273f67a685d5a7bb Reviewed-on: https://gerrit.libreoffice.org/32205 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4e1c423358f60f7516a1682c97837edd21addcf3) Reviewed-on: https://gerrit.libreoffice.org/32209 (cherry picked from commit 899ea62194d59a69e04823962a3170f762a02e9b) Reviewed-on: https://gerrit.libreoffice.org/32210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-19tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. (cherry picked from commit 5a3b2111172f106378cbf78aba0fde1db3642275) loplugin:unnecessaryoverride (cherry picked from commit 10bf49c18d56f198e63514953a1c6e2ea17fcc9c) Reviewed-on: https://gerrit.libreoffice.org/32187 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 0dd9e51abc5705b7ae253d3f9b284136cf1597d6) Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee Reviewed-on: https://gerrit.libreoffice.org/32201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-19tdf#104722: Wrong text alignment when text box is smaller than the text insideTamás Zolnai
The default TextHorizontalAlignment is block. Setting paragraph alignment (on UI) works when this text alignment property is set to block (otherwise has no effect). In general this works on this way, but the existing algorithm did not work in those cases when the text was bigger than the container shape. Change-Id: I02dba76f8e3033a465bb14dc826521966bb30987 Reviewed-on: https://gerrit.libreoffice.org/32123 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5694b4970e3af096130e172ac6968b10ed587a6f) Reviewed-on: https://gerrit.libreoffice.org/32127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-17tdf#104613 revert there is a function for that: CalcLineSpaceJustin Luth
it should have been ,m_bBorderDist instead of ,true. In 5.3, m_bBorderDist is always true, but not in 5.2 Just revert back to the original code, since this was just supposed to be a readability change anyway. reverts commit feacae8571d003c60960d852e835a17ef722265c Change-Id: I2cb16e3c05d3c028eb3f8dcecfcf112524385780 Reviewed-on: https://gerrit.libreoffice.org/32110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-12-16tdf#97164 Add text for visualition of percent symbol.Gulsah Kose
Change-Id: I31dc1a7a4ed0bc0e760e10c1a2ff52660a258e12 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29299 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp> (cherry picked from commit 8e466c431e6d61911b2b15895a4b63df12422057) Reviewed-on: https://gerrit.libreoffice.org/31976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-14That's probably not meant to be a C++ reference to a uno::ReferenceStephan Bergmann
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make SfxClassificationHelper not require a full doc shell". Made CppunitTest_sfx2_classification crash now when dereferencing m_xDocumentProperties in SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a recent Clang trunk build. Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa (cherry picked from commit e90b004a41153770e672bb1d4524852499ab0ca5) Reviewed-on: https://gerrit.libreoffice.org/32003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>