summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-07bump product version to 5.3.1.2.0+libreoffice-5-3-1Christian Lohmaier
Change-Id: Ia3d0a3584decc228097d8b7780ee77817b4972dd
2017-03-07tdf#106096: Fix visible space on Mac with the new layout engineKhaled Hosny
This is not an issue on master since the alternative Mac code path is gone, but we need to skip it in 5.3 when the old layout engine is not used as well. Change-Id: Ib0c8fcf072229c59e15877815c9d88aed94672f0 Reviewed-on: https://gerrit.libreoffice.org/34433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4f8edca85216b46b266fc5dba3103da57e5975be) Reviewed-on: https://gerrit.libreoffice.org/34677 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-07Updated coreChristian Lohmaier
Project: translations 42e8a4f77df5ff0248a8b42352238391e75bf43d update translations for 5.3.1 rc2 and force-fix errors using pocheck Change-Id: I85b8fe751249803c02494ae35728ef93a8b88b81 (cherry picked from commit 66c300f4f5ba33a8243cd54ee077e7c79febec70) (cherry picked from commit aaa0dcfd50c14bdacf80ea601098962041fa679f)
2017-03-07tdf#106190 fix left alignment of denominatorLaurent Balland-Poirier
The bug was introduced with left aligment of denominator. Non feasable denominators were not tested and create infinite loop while inserting and removing the same space. This patch detects - if denominator starts just after fraction bar. Otherwise, format is faulty. - if a non digit is detected in the denominator, next part of format is treated as text This patch is changing behavior of some formats: "# ?/foo??" is treated as faulty format while it was considered as valid "# ?/??E?" is treated with 2 digits in denominator and "E?" at the end, while it was considered as faulty Change-Id: I0379a398dff79b6e21a44776c0d4356d066cdeab Reviewed-on: https://gerrit.libreoffice.org/34659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b2738c6f67cb650ac32228f3cd20b9dfe4b41c9c) Reviewed-on: https://gerrit.libreoffice.org/34826 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-07Resolves: tdf#106159 right click + left click with comments in navigatorCaolán McNamara
results in a disposed submenu in the menu, we need to flag with bSubPop4 that we have inserted the submenu into the parent menu to not dispose it Change-Id: I5b9711c0bba750c11d64dc175efd452f4bc8f4e5 (cherry picked from commit 58659cbaa8c955b135737bf9d77e4e57813310e5) Reviewed-on: https://gerrit.libreoffice.org/34592 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-02Resolves: tdf#105667 forget target area's caption pointer in Merge UndoEike Rathke
It's the same that was copied to the Undo document, so don't delete the caption. Change-Id: Ib89870ed6e392c4271de2f416c78d42135922609 (cherry picked from commit a627c44026fcf883918f84bddd1c3b745e1f898c) Reviewed-on: https://gerrit.libreoffice.org/34515 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-02tdf#104509: Fix GetGlyphBoundRect on MacKhaled Hosny
The rectangle top and bottom were mixed up! I tried to fix this in 8cef9b4dbafdebc0566d6d7f715f27f978ddfe5b, but it was not the right fix. Change-Id: Ia033ff2823bfd641e830d748d413d7791bfee5b8 Reviewed-on: https://gerrit.libreoffice.org/34557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 04d086531ff4a3ab24b704489270c7c23792bd20) Reviewed-on: https://gerrit.libreoffice.org/34559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 659a38ba7678c7a62ba0872f390c59329daadb90) Reviewed-on: https://gerrit.libreoffice.org/34579 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-02add the locale info to the crashreporter metadataMarkus Mohrhard
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/34561 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4cc2f2f683ee7144823503008a6216d1c01e7852) Reviewed-on: https://gerrit.libreoffice.org/34626 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-01xPoolHelper is empty in a clipboard docMarkus Mohrhard
Found by the crashreporter: http://crashreport.libreoffice.org/stats/signature/ScDocument::IsClipboardSource() Change-Id: I3fb030921b653396deb46a9e98d30d5df9c9ce15 (cherry picked from commit c63ff2a769f4601f67ffd13cb36df63c70fdd601) Reviewed-on: https://gerrit.libreoffice.org/34642 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-01prevent crash in PaletteManagerMarkus Mohrhard
Found by the crashreporter: http://crashreport.libreoffice.org/stats/signature/PaletteManager::ReloadColorSet(SvxColorValueSet%20&) Change-Id: I82c5e3f7588615700ec3b5540ac94e331df783bb Reviewed-on: https://gerrit.libreoffice.org/34627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ece3c97ca6c9aaffbf9dd51785ae2f1d4d3e2c9b) Reviewed-on: https://gerrit.libreoffice.org/34634 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5b76c743488b1e206cfe40a5ed087b3a0ceaa1d8) Reviewed-on: https://gerrit.libreoffice.org/34720 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-01tdf#77111 odt import: treat PAGEDESC_PAGENUMOFFSET==0 as autoJustin Luth
Ever since 2010 commit 7edaf190 zeroes have been saved as XML_AUTO. Ever since 2014 commit c2ccd20c, a numoffset of zero is no longer considered to be auto (for MS compatibility) but is still treated as auto during xml export. Thus, any older documents that had been saved with a zero should still xml import as auto instead of as 0. Change-Id: I1a0df32a8e2f1b30b2bedbf4c9bb07ebec239637 Reviewed-on: https://gerrit.libreoffice.org/33267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e36f0860f00af139a8fa94d36302f7b0c56383fe) Reviewed-on: https://gerrit.libreoffice.org/34694 (cherry picked from commit ae225329435cb49e61e3c9fc76129aa4e334598a) Reviewed-on: https://gerrit.libreoffice.org/34698 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-28Resolves: tdf#106105 duplicate marks not merged when they are at the startCaolán McNamara
i.e. initial mark isn't compared which goes on to crash under some circumstances regression from... commit aa11e7bae89fe691f914abb27d1c4a03d27a7ee5 Date: Tue Aug 14 16:31:53 2012 +0200 Convert maList in SdrMarkList from Container to std::vector Change-Id: Ib3e9b02aad91c14971656af171d48154507da127 (cherry picked from commit 35bb22c1a834b306c910cb065bc006818c9fa9b3) Reviewed-on: https://gerrit.libreoffice.org/34478 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28update creditsChristian Lohmaier
Change-Id: Iea0785f5ec1b55200d25d5cd55a63652ab5a38e1 (cherry picked from commit b694f15c86169fca1109ff0068afdf180c8a7d3b) (cherry picked from commit e9fd3674fe783df2c905c3d9b29d0a2bec0cfa00)
2017-02-28update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Ib837a679e359ac7f7c1e22f57cdfc0fddbdee931 (cherry picked from commit e5b616bc22bf66c78939258e8b7e4fa457ebff9b) (cherry picked from commit da671e946dd938a249d0e428f4e017d7d32460d5)
2017-02-28Updated coreChristian Lohmaier
Project: translations 48f61d5f411544af0e6797bdf5552216a8b69d0e update translations for 5.3.1 rc2 and force-fix errors using pocheck Change-Id: I37d9df9e5daf10adc8baf905bb43c621c37d960e (cherry picked from commit 05788c2f5a2a282905055c813b3b3504a25938c3)
2017-02-28Resolves: tdf#106089 generate range string with current address conventionEike Rathke
This is a combination of 2 commits. Resolves: tdf#106089 catch legal IllegalArgumentException on bad range string ... that for example doesn't match the document's current address convention. Further work is need to make that actually fly, but at least don't terminate the application but come up with a default Chart instead where the range can be edited. (cherry picked from commit 0200677891c6d592a12343f0d6f82c569cd7a9e0) Related: tdf#106089 generate range string with current address convention ... so subsequent parsing actually works. (cherry picked from commit 3ec3d7ead0f2e47a4e24ba0d6953fea0f49815ed) 47d661d24552104b56827248b4c5e6a6617c5d63 Change-Id: I6cb6400c56c896dac7ab949b8a986c784690dfd3 Reviewed-on: https://gerrit.libreoffice.org/34516 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28fix crash in the sidebar codeMarkus Mohrhard
The check should be for xPanel and not xPanels. See http://crashreport.libreoffice.org/stats/signature/sfx2::sidebar::Panel::GetTitleBar() Change-Id: I745d6d8abbfc68e86ed812460faa551867ddec43 Reviewed-on: https://gerrit.libreoffice.org/34560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0407200401358d3d565438800f55b61fc1a61794) Reviewed-on: https://gerrit.libreoffice.org/34563 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ed8b8f59e1a85b455a2f8daebd2c1f6fb59faeaa) Reviewed-on: https://gerrit.libreoffice.org/34624
2017-02-28mpMediaItem might be nullptrMarkus Mohrhard
This fixes at least two crashes reported through the crashreporter: http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getTime() http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getDuration() Change-Id: I92eeca229fa46921317586d0317e9f00309e793b Reviewed-on: https://gerrit.libreoffice.org/34710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b5987a4148a10e27fe44ecf5d03e697692e07ca9) Reviewed-on: https://gerrit.libreoffice.org/34712 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 52b89c4764b68cd560000cec68678c8234a8a3d5) Reviewed-on: https://gerrit.libreoffice.org/34716 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-27tdf#106082 fix missing statusbar translations (l10ntool is picky about syntax)Christian Lohmaier
having the ; on a separate line made all strings following that have the string-ID of the next unit, altering the msgctx and thus translations wouldn't apply anymore Change-Id: Ia1e3c36a9d2a57725c90e6c3f33de99bed85ec41 (cherry picked from commit 9eaa17e6bb35a2cb71ec59c96ea4a39466789667) (cherry picked from commit 4717dafe916d81f1c70ea0c51cb1342624116422)
2017-02-20bump product version to 5.3.1.1.0+Christian Lohmaier
Change-Id: I6a4ffc2b102cf9b24400828d46c223e37e178622
2017-02-20Branch libreoffice-5-3-1Christian Lohmaier
This is 'libreoffice-5-3-1' - the stable branch for the 5.3.1 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.3.x release, please use the 'libreoffice-5-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ib8607cc766c8c7f12e1f49330cd53802dd18ae5d
2017-02-20Updated coreChristian Lohmaier
Project: translations 6374c7e5df4654df346aea70692605c372d030cb update translations for 5.3.1 rc1 and force-fix errors using pocheck Change-Id: Ia3f9bd35c20e7738c4378ef0927d427da1ae4030 (cherry picked from commit 9f55d56ddd0b479429a4d75b596387ace58c2c3b)
2017-02-18revert tdf#101815 editeng SetMustRepaint when InsertTextJustin Luth
It wasn't targetted enough at the specific problem, and caused paint problems. This fixes tdf#106056. Change-Id: I2d87bc78627a558c62cb0efc24e49c7656662976 Reviewed-on: https://gerrit.libreoffice.org/34403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a189b27ebeac8f179b9cce959e66862a16c4dd52) Reviewed-on: https://gerrit.libreoffice.org/34405
2017-02-18Resolves: tdf#105858 check SC_DPOUT_MAXLEVELS to prevent crashEike Rathke
This is a combination of 2 commits. Resolves: tdf#105858 check nDataCount<SC_DPOUT_MAXLEVELS to prevent crash (cherry picked from commit 9bdf971b0202c6d55d88e61861b251459de9586b) more counts<SC_DPOUT_MAXLEVELS to check, tdf#105858 related Also for row, column and page field arrays. (cherry picked from commit 7fbdd8b7d3741d55b229977f9e6d6213af5fa542) 1dccdf139af778a2c0dc550be0b573c984256a2d Change-Id: If9084543a0a191d08da37b5b8a187bce46440871 Reviewed-on: https://gerrit.libreoffice.org/34369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-16Resolves: tdf#101000 ensure unique image names in .docscp-5.3-branch-pointCaolán McNamara
(cherry picked from commit 432f605e3287269d1a20383f4eeebf012ee3679d) Change-Id: Id4f93638ad366b66968e6946a835239beee16942 Reviewed-on: https://gerrit.libreoffice.org/34302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-16tdf#95306: Be sure to specify the entire range.Kohei Yoshida
Especially in presence of multiple disjointed selections. Change-Id: I8e7779824109c30e69fd43a2448ae900beaf28d3 Reviewed-on: https://gerrit.libreoffice.org/34140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit 6d450aad0a8f82ee0320ffc3e76eefb43c16addb) Reviewed-on: https://gerrit.libreoffice.org/34143 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16tdf#103677 Windows installer iconsAndreas Kainz
Icons refreshed according Tango style Change-Id: Ibb86ea0a7153f0ac7331d278b2dcd8f8c64835e7 Reviewed-on: https://gerrit.libreoffice.org/32998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a296a69c984b17cfbcd249cf6bdc191d08dff2a6) Reviewed-on: https://gerrit.libreoffice.org/33943 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16fix build with hunspell < 1.5David Tardon
Change-Id: I66810d2bf9bbd08990dd8e995e34c50caa472ff8 (cherry picked from commit 64362ec119a4f38c98d2ff959a5651f4887ff942) Reviewed-on: https://gerrit.libreoffice.org/34339 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2017-02-16Updated coreChristian Lohmaier
Project: translations ec0fc5710bf0de01ff618ba5e89458bce286961d update translations for 5.3.1 rc1 and force-fix errors using pocheck Change-Id: Iee1dc87c949d400b36b590d5dbcfc8b6434c3a46 (cherry picked from commit 83ab35b7b8dee968b2827220496920dbe84c3c16)
2017-02-16Resolves: tdf#105968 handle engineering notation rounded into next magnitudeEike Rathke
Change-Id: Ie31ab88543994f0e8aeef8152c230c05e071ef8e (cherry picked from commit 63bc2b13cb344cce99348496838d7d2c2f690211) Reviewed-on: https://gerrit.libreoffice.org/34321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16Related: tdf#105712 inconsistency with num of a11y children in special charCaolán McNamara
with no visible scrollbar it claims 1 child, but trying to get child at index 0 throws (cherry picked from commit b3098d239f46c8d5965754f275bc62216dcb4f4f) Change-Id: Icf1a0afc4a6f6090e3f14f30b4380db477955561 Reviewed-on: https://gerrit.libreoffice.org/34313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16tdf#106026: Export paragraph top and bottom margin to DrawingMLTor Lillqvist
Change-Id: I8c60f86a1debe135c9172ff639aa5af93f03b99b (cherry picked from commit d2b014edc0f466370023a35eb46548390ceb7fb2) Reviewed-on: https://gerrit.libreoffice.org/34299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16Resolves: tdf#105229 restart in normal mode instead of quittingKatarina Behrens
Change-Id: I546629656ada6c7a8a15b4dc77a042e1f1106924 Reviewed-on: https://gerrit.libreoffice.org/33059 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 29b13a24cf5f0e6e58641d4a55cdfa03c83b68ac) Reviewed-on: https://gerrit.libreoffice.org/34096 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-16Resolves: ofz#576 unexpected exception with invalid fractionCaolán McNamara
(cherry picked from commit cff6cdb2ee37e836b9bab39500d24fcedc360121) Change-Id: I1d653775e88e9fa2ba7b62fce39d52fc21ffe363 Reviewed-on: https://gerrit.libreoffice.org/34069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-15Simple work-around for unpleasant framework shutdown to avoid crash.Michael Meeks
http://crashreport.libreoffice.org/stats/crash_details/2de31c06-da20-4280-916a-e282a337b16b Change-Id: I0b599de9b36f62d65988c1ab698f1559134fbf7c Reviewed-on: https://gerrit.libreoffice.org/34294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 2c60e02bbfde8655828a5b019642f5e85f975e61) Reviewed-on: https://gerrit.libreoffice.org/34297 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-15external/firebird: Backport fix for CORE-5452 causing spurious SEGVStephan Bergmann
...while building LO. Patches from <https://github.com/FirebirdSQL/firebird>'s B3_0_Release branch; to apply, 0002 needed 0001 first (which looks like a reasonable thing to include in itself, anyway), plus a trivial whitespace modification, plus an additional #include for Windows. Reviewed-on: https://gerrit.libreoffice.org/33186 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 592f4f6a5941e42e6b2b3fa76e74b8ad509724c9) Change-Id: Idd2e326432fa52762742a168c7e880a9c6fb650c Reviewed-on: https://gerrit.libreoffice.org/34305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-15tdf#106011: The "swing angle" is negative when counter-clockwiseTor Lillqvist
Change-Id: I1ef77e4c8cf0a6d31b36411a79b576115c32c644 (cherry picked from commit 34d8dc19a08e2752a4b8d3b3d83b7cf3ac341f1c) Reviewed-on: https://gerrit.libreoffice.org/34283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-15tdf#105840 EXCEL export: fixes for hidden defaultRowJustin Luth
second attempt at fixing hidden rows without creating a million repeated rows. (related to tdf#98106) This affects both .xls and .xlsx. XLSX previously had NO support for default-hidden(zeroHeight), but XLS already did. Change-Id: I804e3f2ba21e595a1c2b2ebb355f0995868dd289 Reviewed-on: https://gerrit.libreoffice.org/34128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-on: https://gerrit.libreoffice.org/34277
2017-02-15Optimize Excel GetOrCreateRow: compare to previous map entryJustin Luth
Follow-up patch to 09e9274fc080b471393b806617eb03124db67590 and related to tdf#105840. Just keeping the non-dependent parts separate, and building up to a solution for bug 105840. Change-Id: I129e671f71de6abf876a82d4a6503695add85548 Reviewed-on: https://gerrit.libreoffice.org/34039 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Reviewed-on: https://gerrit.libreoffice.org/34276 Tested-by: Jenkins <ci@libreoffice.org>
2017-02-15Optimize Excel GetOrCreateRow: reduce loopsJustin Luth
for ( size_t nFrom = maRowMap.size(); nFrom <= nXclRow; ++nFrom ) This previous code worked best under the assumption that every row is added to the map. However, the size of the map actually has no correlation to the row numbers contained in it when many rows are identical to each other (think silly formatting and empty rows - related to tdf#105840) Thus row 1,000,000 could occupy slot 2, and every access of that row would then trigger nearly 1 million redundant loops. Optimize: -check to see if the row already exists - if so do nothing. -existance of higher rows indicates there are no missing rows. -build missing rows from the previously-mapped row. Reviewed-on: https://gerrit.libreoffice.org/34038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Conflicts: sc/source/filter/excel/xetable.cxx Change-Id: Ib02520a1bf0f77b5ca0ec5ad3165ff7ea879515f Reviewed-on: https://gerrit.libreoffice.org/34275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-15tdf#104315: Revert "tdf#44282 fix missing space...Xisco Fauli
... for numbered lists in TOC" This commit is causing lot of regressions in TOC. Besides, as the comment says, it's an ugly hack, so I'd prefer to revert it and find a better solution This reverts commit 250252d02bac88877845a4bc27e3f1837f1312ba. Change-Id: I9f57d1cb0f7237372030c12651ba92fbe5a60945 Reviewed-on: https://gerrit.libreoffice.org/34293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit dc8ebf205c3231ffc4d6737b53cee396c2ac0bfd) Reviewed-on: https://gerrit.libreoffice.org/34295
2017-02-15tdf#105386: crash with macro organizerJulien Nabet
bt part: 0 SvTreeList::GetParent (this=0x560670dd2e40, pEntry=pEntry@entry=0x0) at /home/julien/lo/libreoffice/svtools/source/contnr/treelist.cxx:1693 1 0x00007fd90573298c in SvTreeListBox::GetParent (this=this@entry=0x560670dd0d60, pEntry=pEntry@entry=0x0) at /home/julien/lo/libreoffice/svtools/source/contnr/treelistbox.cxx:779 2 0x00007fd8dfc3b4d8 in basctl::ExtTreeListBox::NotifyAcceptDrop (this=0x560670dd0d60, pEntry=0x560670e90b20) at /home/julien/lo/libreoffice/basctl/source/basicide/moduldlg.cxx:180 Change-Id: I033440c1fcc50e2c7a0bb1eed0efa4559c514126 Reviewed-on: https://gerrit.libreoffice.org/34280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 18be4782ad4a98041d9680f8d76a213b8fd49362) Reviewed-on: https://gerrit.libreoffice.org/34287 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-14Related: tdf#105707 PPTX import: warn on invalid/empty SmartArt fallback relidMiklos Vajna
We already warn when the SmartArt doesn't have a drawingML fallback, but having a reference to a fallback that is not a valid one (so resolves to an empty fragment path) is also unusable. So warn in that case as well. (cherry picked from commit 2d732b498bab244cde6978e9389511a940101995) This second related situation is about when there is drawingML fallback for the SmartArt, but it's ampty shape tree, which is never created with MSO2010+ (those shape trees always have at least one element). This is as bad as the missing drawingML fallback, so warn on it. (cherry picked from commit 8c6776f27cef1e2b7b40957f1801b08707bc3230) Change-Id: I03b2325003b4eb38b1347a88899799c6d5c33606 Reviewed-on: https://gerrit.libreoffice.org/34196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-14editeng: presumed copypasta in 048e30c1f8231e6cd144a9251061f6fa127b353eMichael Stahl
Doesn't make sense to check for RTF twice in a row. Change-Id: I15a384adb4d9e65770d81c414b6f24cc0a2b75e8 (cherry picked from commit 6ed7a9759fdf6affdb6ec81a9aae7a3398de8d9b) Reviewed-on: https://gerrit.libreoffice.org/34244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-14tdf#103890: Fix the logic on setting 3D flag on reference.Kohei Yoshida
This is a backport commit that combines 3 original commits from the master branch. (cherry picked from commit bf8d4fb60da5e583b3a90639af45b901e19cb5aa) (cherry picked from commit 6e1efe7b6bd16e3183cdb7c87d786cb714a61959) (cherry picked from commit aeb465a458fc7ba02e3b1ca6b4193488defef511) Change-Id: I401d379be058cc45a5715a4a8a8f72aa56208655 Reviewed-on: https://gerrit.libreoffice.org/34138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-13Resolves: tdf#105426 upgrade to hunspell-1.6.0Caolán McNamara
and use alternative optimizations for buffer creation bottleneck Change-Id: I9f29e8d3e5e97fe403a3e0d7d03c6ac01c7689c4 (cherry picked from commit 163435fa23fbfc237a7718c9d440a98847e4f626) Reviewed-on: https://gerrit.libreoffice.org/34183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-13Related: tdf#105707 PPTX import: decode document name from URLAndras Timar
Change-Id: I7448c48b9376a4b73b8a35034a73353981174823 Reviewed-on: https://gerrit.libreoffice.org/34136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-13tdf#105288 MM wait until all emails are sendJan-Marek Glogowski
Seems mail merge is now much faster then the sending of the merged documents via email. This is why the attached workaround patch to the tdf#103919 bug report, which simply sleeps after queuing a new message, helped solving the problem. It slows down the mail merge and gives time to the mail dispatcher thread. But we actually want to wait until all mails are send, so we have to add a listener and wait for the mail thread to become idle. This listener also allows us to cancel further mail merge when an SMTP error has occured. Reviewed-on: https://gerrit.libreoffice.org/33989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 5f2e1eda4532a52fe9f0f9d2017b37d566f25f33) Change-Id: I9d13bcd8f0d0ff084b20d72ab96f70afa3a764ba Reviewed-on: https://gerrit.libreoffice.org/34125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-13Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabledCaolán McNamara
so no Invalidate will be called if auto accelerators are not enabled so there should be no blinking under windows Change-Id: Iccc5dad7af41f39ac02d3be93e935f2d926a82a6 (cherry picked from commit f67dc04cfdd9e63a45ec6c8bc00829bce8f17d4b) Reviewed-on: https://gerrit.libreoffice.org/34076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-12tdf#86470: Let's not forget to move onto the next column.Kohei Yoshida
Change-Id: I451f521723458b5d6fe9d9fa8b41855fe17def64 Reviewed-on: https://gerrit.libreoffice.org/34159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit bcdde13996e3e33f9d4c41be25d062560c72636b) Reviewed-on: https://gerrit.libreoffice.org/34163 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>