summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-11convert MappingType to scoped enumNoel Grandin
Change-Id: I1f00e1fbdb9213d0c2f30da116684b77842282f5 Reviewed-on: https://gerrit.libreoffice.org/24851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert FONT_FAMILY to scoped enumNoel Grandin
Change-Id: Id7cc5c76ba45cdd6a06a981ad14e83713cfe5c1a Reviewed-on: https://gerrit.libreoffice.org/24840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert BORDERWINDOW_DRAW to scoped enumNoel Grandin
Change-Id: I25d8c8921445749be05974af5c00e9fde82382a3 Reviewed-on: https://gerrit.libreoffice.org/24837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert BORDERWINDOW_TITLE to scoped enumNoel Grandin
Change-Id: I9e3088c4ba51010a013f5bbaa2bb545ffa11409b Reviewed-on: https://gerrit.libreoffice.org/24836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11remove unused return type from SalGraphics::SetFontNoel Grandin
Change-Id: I0ca41130f5e1028a70f1242f7af3366b7c57c572 Reviewed-on: https://gerrit.libreoffice.org/24833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Change code related to setting diacritic and cluster property of a characterAkash Jain
To determine whether a character is a diacritic check the characters unicode combining class if the font has no GDEF table. Also change the way to determine whether a character is in a cluster or not. Change-Id: I1ef45d5ffe610216d492ce4a1caacf2c01bfde78 Reviewed-on: https://gerrit.libreoffice.org/24844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-05-11starmath: Drop unused non-const variant of GetLeftMostTakeshi Abe
... resulting in one less const_cast. Change-Id: I3dad339f25524fc22e7a02b08ee7ec01b341e991 Reviewed-on: https://gerrit.libreoffice.org/24810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-10tdf#99588: Fix radio button groups (and thus up/down key cycle)Katarina Behrens
Fix both Operations group (orig. report) as well as the other group (Shift cells) which was broken too, but since the buttons happened to be in alphabetical order, the bug didn't show Change-Id: Ib4d3dca29b286efe58f066dd20c4d4a9d6bf07dd Reviewed-on: https://gerrit.libreoffice.org/24857 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-10Assign 0 explicitly, avoiding intermediate downcastsMatteo Casalin
Change-Id: I43a9adeaf7078551a3447032fbf65affab817b15
2016-05-10Constify some temporariesMatteo Casalin
Change-Id: I4d88975c4c4639ff933dc155bd258f1617c2198f
2016-05-10This temporary Size is not really neededMatteo Casalin
Change-Id: Ieb20b30bb017118acc6fcc00d175cab9b47732c2
2016-05-10Use member initialization listMatteo Casalin
Change-Id: I98486822d1cac8fd16c8d916011c3d99baf1f1ae
2016-05-10Reorder class fieldMatteo Casalin
Change-Id: I7e4c7704cba8d1e2528b966267a350bdd7394e24
2016-05-10Fix code format and remove some unneeded parenthesesMatteo Casalin
Change-Id: I7ffd93c98736f1904cef5c5bfcfa18dbf365cd6d
2016-05-10Avoid some temporaries, constifyMatteo Casalin
Change-Id: I5a9a02b5dae88679d7f39a85b26796a161688815
2016-05-10Avoid some OUString temporariesMatteo Casalin
Change-Id: Icd7a63ac144c9ef365e64ab09d611cdfe3edf739
2016-05-10Avoid some OUString temporaries and constifyMatteo Casalin
Change-Id: I4789e9c0a4c2978e703ad4f8a088c8d267cd0972
2016-05-10Avoid some temporaries and constifyMatteo Casalin
Change-Id: Ie9ae7edb78e3c5768e4d253ab43a1dcdcf44078c
2016-05-10tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas
...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Presumably missing break in switchStephan Bergmann
The code was like this ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", but it looks more like the break was always missing than that it was an intended fallthrough. Note how the symmetric FIRSTRIGHT case does end in a break. Also note that in the original code, the fallthrough case RIGHT guarded its modifications with if (bTbx || n <= nPos) aInnerRect.Right() -= pCli->aSize.Width(); break; (where the surrounding if got since removed), so it was presumably less likely that an erroneous fallthrough actually caused any modifications. Change-Id: Idf7ee117f1e22dee19343684a2f56fbf464bdb7f
2016-05-10Presumably missing break in switchStephan Bergmann
In fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import" the case SDRDRAG_CROOK fell through to the default branch, but which was irrelevant, as the default branch's if-branch would only hit if bCroner || bVertex, in which case the SDRDRAG_CROOK's if-branch would already have hit and returned. Then dc1fddc142ab438775e2c1bae4a0e148d263ce0d "INTEGRATION: CWS cropmaster2000_DEV300: #i83933# added interactive graphic cropping" moved the case SDRDRAG_CROP in between. Change-Id: I66939fc62416e0a442b02e674d90812ce76f3b2b
2016-05-10Presumably missing break in switchStephan Bergmann
Was like that at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but as clarified on IRC: <vmiklos> sberg: doesn't look intended, i think ESCHER_Prop_lineDashing and ESCHER_Prop_fNoLineDrawDash are supposed to be mutually exclusive. Change-Id: I5ea92e6bdc9800c4511ca041c0572d1f9ffca49c
2016-05-10Missing break in switchStephan Bergmann
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM falling through to the default break case. Then 14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines, tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE, OBJECTTYPE_DATA_AVERAGE_LINE block in between. Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10-Werror=empty-bodyStephan Bergmann
("suggest braces around empty body in an ‘else’ statement") Change-Id: I7c6de1ed2cc1c2cc39e2c8f530866c31ab038907
2016-05-10tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav
replaced tolower with to AsciiLowerCase() in lingucomponent/source/languageguessing/altstrfunc.cxx l10ntools/source/gL10nMem.cxx Change-Id: I1340da18b263a4a921e2e8d96c0f133fe300086e Reviewed-on: https://gerrit.libreoffice.org/24682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I0dd8f3c1d9330bc58cf52212c9752adf51444d3d
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I1f147c4a0ebc6895435722d8385131917f88ecb5
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Id0470b3e60a455bc3807f4fa5da98cf5f1877d00
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Id6e230d026184ab243e994a17515f2e5539d3646
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I49c216ed6e1e401fcc2029c047d7a7feeb767b36
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I6df171debbf4940bf27898c3ff5d8597f437897f
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Iba1556d1918a336e376c0fda5e7e14b3e890d267
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I8fcd7bf2583c935e060a29e43c88614681d81d13
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I8a42f027d4970fe31c0e713d1402668499c8dda7
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I796ec3b79d7c26d9efe275b4232ae85cac80b578
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I646abf83b4dce8c92a3ba1c136d968bb9291dd83
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I005943a7c7bc4f8bfc647b2cf44f143a66a7e997
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ieee43fce49b7f07d6b356e8c2e34e9e92b605957
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ib0cb61ce63b065f6e2845ef7e8da0827556110ba
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I0dccdf984f4b171feab20e8400376cf8846ffe2e
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I07f247f003a5522e7d655f30f7c68d1b8f7225f2
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I041971ad00b6b2e41509fa6b877c0563748f1336
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I41dec58c163bdd33b71b3519fa0fd6eca72faae6
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ib67f7cb71255a32810f09a6b7e528f024bbef9df
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ic764a6499b8f5ecac62d326151b0957c53866e08
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I28bca2b15cb2d6f521efbcc27e93be2338500489
2016-05-10Add SAL_FALLTHROUGH to what looks like flex-generated codeStephan Bergmann
Change-Id: Icd980dbbdc8b55d76b7f8abe4dd1a9d7e475143d