summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-06upgrade curl to 7.61.1Thorsten Behrens
Reviewed-on: https://gerrit.libreoffice.org/60042 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d15d3ce697e88e72cec84b5b9b9619a37a8ae7ed) Conflicts: download.lst Change-Id: I4590f5f705dd08c63a1532ce5afa94a3af953f24 Reviewed-on: https://gerrit.libreoffice.org/60054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05Properly encode OAuth2 credentialsStephan Bergmann
Change-Id: Ic3edeae035262309e91fb01e3aca5c2f905bc3e5 Reviewed-on: https://gerrit.libreoffice.org/59986 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 33f7485dedea90e0f80c6348fa8ac5f27c5052e0) Reviewed-on: https://gerrit.libreoffice.org/60016 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05-Werror=return-local-addr (-with-webdav=serf)Stephan Bergmann
Missing adaption after 2e142c0ee54744d35517f0b9c49a24302fb32d47 "tdf#114227: Add support for PAC to ucbhelper::InternetProxyDecider on Windows", found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1456/>. Change-Id: I5093827035a9bbc31f3d8d2262e14df55fa610aa Reviewed-on: https://gerrit.libreoffice.org/59961 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 200f88c55842a3947eb3cbc5ce05b044eb25d338) Reviewed-on: https://gerrit.libreoffice.org/59981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2018-09-05tdf#119152 Hide Text Direction dropdown from Columns tab by defaultGabor Kelemen
To restore behavior seen before 6.1 Change-Id: I7dd6b566b4964298a3e08c6c6dd663f87857d038 Reviewed-on: https://gerrit.libreoffice.org/59479 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4f3dec1104a21d93d400c76ab0ae85083aec8492) Reviewed-on: https://gerrit.libreoffice.org/59955 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-05Resolves: tdf#119574 set specific width for style list widgetCaolán McNamara
so super wide style name doesn't break things Change-Id: I096eb1d3deeb935b43566b4d3ccb45d89ac2a56a Reviewed-on: https://gerrit.libreoffice.org/59929 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-09-04tdf#119344 fix libcmis build with boost 1.68rezso
Change-Id: I80d6ea8ecd001dc02b941c1eb8974c9244316045 Reviewed-on: https://gerrit.libreoffice.org/59958 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 3ef3569c4ae1c5319aff0664d52cbd8a8d42c909) Reviewed-on: https://gerrit.libreoffice.org/59971 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-04Resolves: tdf#118799 use spelling/search dialog as message dialog parentCaolán McNamara
when visible Change-Id: Id4d6df2a85aebd6887949f285e1a5ec1046dbf64 Reviewed-on: https://gerrit.libreoffice.org/59456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 50c9ed67d29d6105f3907cb7a2fe3322685af53c) Reviewed-on: https://gerrit.libreoffice.org/59975 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-04ofz#10198 reset uncommitted fly stuff & pams before applying redliningCaolán McNamara
Change-Id: I2a2587ec4590926f7cffc2a4d58a22d9d5f19c99 Reviewed-on: https://gerrit.libreoffice.org/59947 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-09-04ofz#10189 check container sizeCaolán McNamara
Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161 Reviewed-on: https://gerrit.libreoffice.org/59912 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-09-04upgrade to openssl 1.0.2pCaolán McNamara
Change-Id: Ifacf5dce39d830838b3cf57df760a04df97ade4b Reviewed-on: https://gerrit.libreoffice.org/59927 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-04Resolves: tdf#119533 reintroduce time rounding but cut, tdf#118800 follow-upEike Rathke
This is a combination of 2 commits. Resolves: tdf#119533 reintroduce time rounding but cut, tdf#118800 follow-up Regression from commit c69e7266916ac1b8917477fb4eccdb9098da5792 CommitDate: Thu Jul 19 14:01:30 2018 +0200 tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND. Rounding was only an error if it produced a value of a full day in seconds, or if it otherwise led to an inappropriately rounded-up individual value, but in general some rounding is necessary. Instead of omitting rounding completely, basically round to nanoseconds and then do not round individual hour,minute,second values but instead truncate to the next magnitude so 23:59:59.9999 gives 23h59m59s instead of 24h0m0s Reviewed-on: https://gerrit.libreoffice.org/59677 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 273b3e10eab70ebc084cb62568bd699fddfb376e) Shortcut small negative values to 0:0:0, tdf#119533 tdf#118800 follow-up ... instead of letting them end up as 24:0:0 Reviewed-on: https://gerrit.libreoffice.org/59699 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 98cb91686901dc0133c5c23dc5658d9623dbd436) 0212a2b422a931a24fd2748aa2826a5b60d2a397 Change-Id: I93df1aa54212c1b8816237c9467f270ed28a3f1f Reviewed-on: https://gerrit.libreoffice.org/59678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04Increase arbitrary sort elements limit from 100000 to two full columnsEike Rathke
The value 100000 already was in the year 2000 initial commit, probably some memory and performance constraints back then. At least one full column should be sortable, make it two so we don't bail out that early for functions like MODE() that can take multiple ranges. In fact maybe ScMatrix::IsSizeAllocatable() should be taken into account, which is much larger though and QuickSort() might not play well with it. Change-Id: I061abfd0f061c8df62c31468df744eb5dc7152be Reviewed-on: https://gerrit.libreoffice.org/59637 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8cb36fd6234270c8c31147db35cccab9c234529) Reviewed-on: https://gerrit.libreoffice.org/59660 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04Use INPUTSTRING_PRECISION to enable input of fraction of secondEike Rathke
This got lost when SvNumberFormatter::INPUTSTRING_PRECISION was introduced but not all places changed using the previous hard coded number 300, so input of fraction of second in time clock and duration was either truncated or not available at all, already since commit 0ce0dd5863208500d8d4658f1f68f34e254ab015 CommitDate: Tue Dec 1 16:58:07 2009 -0500 #i46511# Fixed one bug where the standard percent format incorrectly got unlimited precision. Change-Id: I9e4dd867b07090db16b23639fd01fb2cebb3f5d0 Reviewed-on: https://gerrit.libreoffice.org/59815 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 73c200d7e5779b18ee1406b7fbd2000a8c901589) Reviewed-on: https://gerrit.libreoffice.org/59838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04tdf#119146: fix populating maCurrentSubsetsMike Kaganski
Regression from commit 4600b07c1d787f959618d9ecf54161e4ea4ffa61 Before the mentioned commit, creating a subset X, and then adding sub-subsets until all the subset is excluded, had left the subset X with two *empty* nodes in maCurrentSubsets, 1st of them having both mnStartIndex and mnEndIndex equal to maSubset.mnStartIndex, and 2nd having both mnStartIndex and mnEndIndex equal to maSubset.mnEndIndex. The commit above changed that to adding maSubset to maCurrentSubsets in the beginning of each exclusion, which finally resulted in a messy maCurrentSubsets with multiple duplicating nodes effectively covering all maSubset. That resulted in the item as a whole handled *besides* the sub-subsets. This commit (1) avoids adding extra maSubset to maCurrentSubsets, and (2) adds the two empty nodes in case all the subset has been excluded by its sub-subsets. Change-Id: I7fc5f2d0b6ecf4f9247351da3a2746032150557b Reviewed-on: https://gerrit.libreoffice.org/59948 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a8aaffa6ea0f0fd8cf1d22883173df64a93e3322) Reviewed-on: https://gerrit.libreoffice.org/59952 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03Resolves: tdf#119607 crash in calling getPropertyState on TextParagraphCaolán McNamara
Change-Id: Ib7091473e3547241e95dc3d3921abf650f288aff Reviewed-on: https://gerrit.libreoffice.org/59825 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03tdf#119579 skip floating windows as potential parent for missing help dialogCaolán McNamara
Change-Id: Ibcee9a6aab0b04bf52f3e75a46f52d98864eee4c Reviewed-on: https://gerrit.libreoffice.org/59809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03Resolves: tdf#119259 reused in-use SdStyleSheet removed by undoCaolán McNamara
since... commit a4cd841541a729d7b8126d27d91fa28e30b01403 Date: Thu Feb 13 16:10:47 2014 +0530 n#757432: Styles (rename &) copy to different decks. While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. if a SdStyleSheet is not freshly created, but reused, it ends up in the rCreatedSheets list, and so when the copy is undone (via SdMoveStyleSheetsUndoAction), the SdStyleSheet is unconditionally remove from the StylePool and so its ref count hits 0 and is removed, even though there are still objects depending on it. the problem becames more common since... bash-4.4$ git show 57db6e24b5ad43d447c30e44a112c74c7e75b46b commit 57db6e24b5ad43d447c30e44a112c74c7e75b46b Date: Tue Aug 15 02:51:07 2017 +0530 Removing old SfxItemSet::getHash usage improves the SfxItemSet comparison. Assuming that its correct to leave SdStyleSheetPool::CopySheets with those reused SdStyleSheets in the list, change things so that a flag is passed around to indicate if the SdStyleSheet should be removed or not by undo Change-Id: I82b5bd93183fd1ff9e67957ccfb5babef81fd36d Reviewed-on: https://gerrit.libreoffice.org/59434 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-03sw TextGraphicObject: handle XBitmap for GraphicURLMiklos Vajna
This restores compatibility for API users who called getByName() on the bitmap table and expected that the result can be set as a value for the GraphicURL property. Changing the property type to cppu::UnoType<css::uno::Any>::get() is necessary, otherwise scripting languages figure out (via reflection) that the type doesn't match, and SwXFrame::setPropertyValue() is not called. Change-Id: Idd62f109e91dbaebf1138b9038f66c6c648d780e Reviewed-on: https://gerrit.libreoffice.org/58745 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins (cherry picked from commit 587803ba46055d43b5b108be744fdde17aeabc7c) Reviewed-on: https://gerrit.libreoffice.org/59850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03sw TextGraphicObject: fix GraphicURL handling in the descriptorMiklos Vajna
Commit dfee7d93b4e863d673c45921f79bb876b5738ea6 (sw: get rid of FN_UNO_GRAPHIC_U_R_L and "GraphicURL" property, 2018-03-08) removed support for string-based graphic references, then a later commit restored the setter. But one scenario (when setting the graphic URL before inserting the text graphic object) was still unsupported for real URL setter; restore that as well. (cherry picked from commit bba0ccd743a3d023e4829155571cdf0318fcb81c) Conflicts: sw/qa/extras/unowriter/unowriter.cxx Change-Id: I52a7f96e820f614d9d031df3ba03c794984ad68b Reviewed-on: https://gerrit.libreoffice.org/59849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-02tdf#118845: make HiddenPara have higher priority deciding visibilityMike Kaganski
Otherwise, a Database field in a paragraph which is non-empty would force the paragraph to be visible, regardless of HiddenPara field telling it to be hidden. Regression from commit db04be037b611e296ef9f2542322c52ed82d7a2b Change-Id: I21807e22bd339fd1ea0aaa3b382579f688903418 Reviewed-on: https://gerrit.libreoffice.org/59792 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 64cb57c82d9e7f7069821b2e2ef92574ec73ebe2) Reviewed-on: https://gerrit.libreoffice.org/59865 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-01package Indonesian (id) dictionaries into installsetChristian Lohmaier
Change-Id: I78b8c745b9d6e4a23fa13622188c5bd1776b0ac6 Reviewed-on: https://gerrit.libreoffice.org/59882 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 6c08039ebec28b936dd4521139c9670f7fadf9f4) Reviewed-on: https://gerrit.libreoffice.org/59889 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-31tdf#112454 Also consider last SCTAB in loopMichael Weghorn
Since 'rRange.aEnd.Tab()' is valid, it needs to be included in the loop to get a valid result. Change-Id: I7b2447e059dc03444c56e7fc0b113e1b618dd510 Reviewed-on: https://gerrit.libreoffice.org/59798 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 03b361673d04f31e0602d2988e4df26eaeb53a34) Reviewed-on: https://gerrit.libreoffice.org/59872 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-31tdf#117781: don't remove already applied conditional format dataMike Kaganski
... when deduplicating; only add new range. Check not to add the same conditional format to a range more than once. Change-Id: I0702b8e1462784cc71666ddfa6442a2827f00af5 Reviewed-on: https://gerrit.libreoffice.org/57725 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e56eb9cb7ee80215c05d06f25349d7ab7ad06640) Reviewed-on: https://gerrit.libreoffice.org/59866
2018-08-31tdf#73078 Let 'Type()' return '1' for empty cellsMichael Weghorn
Quote from tdf#73078: > The function TYPE is specified with the Syntax: > TYPE( Any value ) and the rule "If a Reference > is provided, the reference is first dereferenced, > and any formulas are evaluated." > [ODF1.2 part2 section 6.13.33 TYP] > > Because of argument type "Any" the function cannot result > in an error. Gnumeric, Apache OpenOffice, and Excel return > the number 1 in this case. Therefore, have LibreOffice return 1 as well, rather than having an "Err:502" ("Error: Invalid argument"). Change-Id: I1e679645e7b2e70e185574f805cd410b0508cbd8 Reviewed-on: https://gerrit.libreoffice.org/59826 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0383ccd4e7116c3d26edc1f86b7a74fe3cf649bd) Reviewed-on: https://gerrit.libreoffice.org/59852 Tested-by: Eike Rathke <erack@redhat.com>
2018-08-31Fix syntaxJulien Nabet
Change-Id: I21cca2e5cd81ee58a59fda077ed40ba02d9f1df3 Reviewed-on: https://gerrit.libreoffice.org/59844 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 49d1a2f70bb8c099f1a950e5ad9f805d252ea342) Reviewed-on: https://gerrit.libreoffice.org/59847 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-31tdf#116436 rtf export: add missing table background fillJustin Luth
MS formats only have support for Table and Cell fill. Interestingly, MS Word doesn't let the cells inherit from the Table fill setting, so that value also needs to be written out into every cell. Since Word apparently ignores the table color, I didn't bother trying to search out how to export that in RTF format. (I did add it to DOCX since it was so easy to find.) Change-Id: I7fe7723fb1603bc60608762aea79ff3b8122e073 Reviewed-on: https://gerrit.libreoffice.org/59282 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1a4bc964f15003c6aaec84989e3e47501b7f72df) Reviewed-on: https://gerrit.libreoffice.org/59667
2018-08-31tdf#91292 docx export: COL_AUTO != cleared fillJustin Luth
required for tdf#90906. If the color was COL_AUTO, then the fill was already marked as NONE, so that doesn't indicate a "change" made by the user since the document opened, and thus the original information shouldn't be tossed. Change-Id: I2e20c228c2a5f61826320798a2f07d94f0da024c Reviewed-on: https://gerrit.libreoffice.org/59442 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 2902771581ccd6465b3e8cdca0aa3fcb6d51ca60) Reviewed-on: https://gerrit.libreoffice.org/59535 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-31tdf#119557 style hierarchy isn't stable so looping check fails falselyCaolán McNamara
Given the css stuff a given style can end up with itself as a grandparent but then the css mutates things so it doesn't loop around to give itself as a grandgrandparent. So undo the loop detection check and turn it into a parse depth test instead with an arbitrary, but high, level Change-Id: If28684ad2b2adc664bc2da6b176b93248b377162 Reviewed-on: https://gerrit.libreoffice.org/59814 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-08-30tdf#117823 Save mail merge config item in new viewIlhan Yesil
The config object is now saved in a newly created document. Regression from commit id 00fa85e701d4a8984cfa3a24c9b7a3963b031fa0. Change-Id: I2265de1dd69038d447e28dfda2e85c7cf89903c6 Reviewed-on: https://gerrit.libreoffice.org/59728 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 9d847ff825c1c94286e8ab864a88fc5375d9341c) Reviewed-on: https://gerrit.libreoffice.org/59802
2018-08-30ofz#10056 Null derefCaolán McNamara
Change-Id: I9ea0f272d0a8b13fb51fec55ac57adca47cafc77 Reviewed-on: https://gerrit.libreoffice.org/59601 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-30ofz#10045 Null derefCaolán McNamara
Change-Id: If9c8edd94b02240510325d6c9c0fc7584ba89b5f Reviewed-on: https://gerrit.libreoffice.org/59574 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-30Resolves: tdf#119572 addressee/sender formatting swappedCaolán McNamara
Change-Id: Icdb2ca0362711e87edcb952fb52117502d80d328 Reviewed-on: https://gerrit.libreoffice.org/59794 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-08-30Resolves: tdf#118382 crash on paste of rtfCaolán McNamara
into an existing document since.... commit deaa16bd24fba4a3a6b072ab2b94542a7dbd41c6 Author: Serge Krot <Serge.Krot@cib.de> Date: Mon Jan 29 12:17:06 2018 +0100 tdf#72942 Do not overwrite styles from the inserted doc During inserting of the text from the external document we should not change original default styles in currently opened document. because missing styles aren't created, so there's exceptons thrown on their use. I see that the m_bIsNewDoc flag is already checked for since... commit 5ebe826caf75e8d00656b3333385bf0bbc05cb27 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Fri Oct 4 11:02:59 2013 +0200 fdo#69384 fix impress -> writer copy&paste Regression from 2ade07126971b79c92f729fae5709f2e2e2b495c (fdo#62044 RTF import: don't overwrite existing styles when pasting, 2013-06-04), during paste, if existing style was found, then the intention was to skip that style, but instead we tried to create one. in the body of the following loop, which should mean that existing styles are left alone and only missing styles created if we remove this hunk of the tdf#72942 commit Change-Id: Ia4aedb5e309c991490656061aa20d11ff24f4f9e Reviewed-on: https://gerrit.libreoffice.org/59519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1f1e349bbee1b2bff01a850d9a7fe4d6a77c4f29) Reviewed-on: https://gerrit.libreoffice.org/59636 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29tdf#119477 fix list box focused text colorJan-Marek Glogowski
This ignores the rollover state for text colors if the list box has the focus and just uses the highlight text color. The normal text color is a result from commit 9897fd1c4715 ("Fix list box focused text color"), which makes the highlighted list box text "invisible" (black on dark blue) in the "gen" VCL plugin and on Windows, e.g. when the focus is in the Math symbol list box. Reviewed-on: https://gerrit.libreoffice.org/59488 Reviewed-on: https://gerrit.libreoffice.org/59549 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 7a14326fea2cc317b8be57d45be7ca57aebd8bdd) (cherry picked from commit 9897fd1c4715e7dbbe99fae2b82c2eda1d2b6f7e) Change-Id: I751a811f2e2bbca112b8f9e0de2fffb04c437ba4 Reviewed-on: https://gerrit.libreoffice.org/59564 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119458 reorganize sw background Idle handlingJan-Marek Glogowski
This is the squashed version of the following commits: - ce68889678bc tdf#119458 always start the SwDocIdle - 107f0e6dba57 tdf#119458 fix sw background Idle state handling - 771544544ee1 tdf#119458 fix sw background Idle unblocking - 3bd8316718fd tdf#119458 just wakeup Scheduler on active Idle While the first commit was really wrong, the third is just an optimization to prevent unnecessary wakeups and Idle task interrups from new calls to StartIdling(). The 4th one contains the reset of the Idle state on run, which was probably the main origin of the problem and allows to wake up the Scheduler without moving the Task to the end of the queue. Starting the SwDocIdle in StartIdeling() just reintroduces the bug fixed in commit 401cba4c20fb ("tdf#116370 cleanup Writer idle job handing"), so trading one bug for the other. For the real solution we have to handle two states: 1. The SwDocIdle being active 2. The SwDocIdle being blocked For the first state we can just use the active state of the Idle itself. Since it's not a AutoIdle, it will be turned of, if invoked. Either some Idle handler will want to be run it again or some other thread might start it again, if needed. Since we're now tracking the wanted Idle state via the active task flag, we can drop the explicit mbStartIdleTimer handling. As a result of the first change, we can't stop the Idle anymore when blocking it. But the Idle itself checks its ready state via IsDocIdle() in its UpdateMinPeriod function, so we have to add the blocking state to IsDocIdle(). But we can't handle the correct state when blocking via a tasks mbActive bool, as this also schedules the task and starts the scheduler timer. So reintroduce a bool for the unblock state. This should prevent fdo#73165, which I couldn't reproduce, but just to be sure. More importantly this patch resets the m_bStartOnUnblock when the Idle job actually runs. This run should already determinates if more Idle work needs to be done, and others can still call BeginIdling() to ensure further processing. Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/59536 (cherry picked from commit ce68889678bca3b51c258452f7bfdd21982e4a0d) Reviewed-on: https://gerrit.libreoffice.org/59586 (cherry picked from commit 107f0e6dba57a5b27366a35a5cdb184079546df0) Reviewed-on: https://gerrit.libreoffice.org/59692 (cherry picked from commit 771544544ee13ec98961f93b5313a7d2e29429cd) Reviewed-on: https://gerrit.libreoffice.org/59730 (cherry picked from commit 3bd8316718fdfed454c01a9c4ae6af6beb34437d) Change-Id: I2d4328f31644017b09786ff4cba45cf7643f0a4b (cherry picked from commit f1fb30cf43eda45137ab96177238a29c3725789d) Reviewed-on: https://gerrit.libreoffice.org/59757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#109353 - Base: Listbox doesn't show a value.Alex McMurchy1917
This is because text in box is same colour as the background. This is only an issue for Linux/KDE. This change fixes this issue. Change-Id: Icb908ace25c69fd2fb51f8f44082ca6b00f55c43 Reviewed-on: https://gerrit.libreoffice.org/55660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 3f31455fdd10309ab85fc3d324096698d3f38e5b) Reviewed-on: https://gerrit.libreoffice.org/59563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29give the migration warn dialog a parentCaolán McNamara
Change-Id: Ie133c81464d87e5fbcfa9ff5d3c43f470b48d620 Reviewed-on: https://gerrit.libreoffice.org/59509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119556 Sync "Use only paper size from printer preferences"Michael Weghorn
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 571df3ede6f09c945c4cdfd37f34ef760b6b1af2) Reviewed-on: https://gerrit.libreoffice.org/59729 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-28tdf#119122 first (5%) pattern initially drawn with too many black cellsCaolán McNamara
pattern of area tab, pattern subtab of e.g. format page and in the pattern editor the 5% style is shown wrong, clicking ona different pattern and then back may make it draw correct a problem since... commit 6fbb6d80fe6203ff6f84ee85ca625b6e60bf5bae Date: Fri Feb 16 16:13:38 2018 +0200 use std::array in createHistorical8x8FromArray to make the assumption about the size of the array obvious in the code. Change-Id: I882384a13dedc7a14b63b3b8a9b764a4367b7cc6 Reviewed-on: https://gerrit.libreoffice.org/59726 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf#116436 docx export: add missing table background fillJustin Luth
MS formats only have support for Table and Cell fill. Interestingly, MS Word doesn't let the cells inherit from the Table fill setting (even though LO docx import currently does), so that value also needs to be written out into every cell. Change-Id: Ib49fddf52758ff641428de747ea290d1fcb894f3 Reviewed-on: https://gerrit.libreoffice.org/59260 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 8cc753d54ad1834709c5802115580adf65def89e) Reviewed-on: https://gerrit.libreoffice.org/59286 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#116436 doc export: add missing table background fillJustin Luth
MS formats only have support for Table and Cell fill. Interestingly, MS Word doesn't let the cells inherit from the Table fill setting, so that value also needs to be written out into every cell. Since Word apparently ignores the table color, I didn't bother trying to search out how to export that in DOC format. (I did add it to DOCX since it was so easy to find.) Change-Id: I8946f07b45f72fed5959369182882a7bf013b1d0 Reviewed-on: https://gerrit.libreoffice.org/59281 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit b576ab5073a8cdf5ca2db04838d255e142f5a896) Reviewed-on: https://gerrit.libreoffice.org/59287 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28Resolves: tdf#119350 page with 0 margins shown as 1cm in page dialogCaolán McNamara
since... commit 7958091b06954a7b253fdebb9ea0313db9217959 Date: Fri Jun 15 14:03:31 2018 +0100 weld SvxPageDescPage because the toggle handler fires when the value of landscape is set, change to a click handler which fires only when the user explicitly clicks on it, which restore the original quirky behaviour Change-Id: If93cc9e0b5d38d92844a1d85de53ee2da958efa0 Reviewed-on: https://gerrit.libreoffice.org/59394 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119050 sfx2 store: don't inherit temp file permissions when overwritingMiklos Vajna
The too aggressive error handling in commit fb04780cf8523ad4e900ae8b9cecbe7a2697a12a (tdf#116117 sfx2 store: don't inherit temp file permissions when renaming, 2018-03-12) means that if the file is already there, then we don't try to stat() it; even if there is no problem with that. (cherry picked from commit 38afe2976eea427999c39ee3a73e7938ec8d5f7b) Change-Id: Ie0b9084064834e339bcae3ad7b4a35c54cb9d3c2 Reviewed-on: https://gerrit.libreoffice.org/59709 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf#106260 Fix invisible pasted urlsPaul Trojahn
UpdateFields() was never called after pasting a field. Change-Id: I91f3eb183a0545d8735c0844f1e864a287101d22 Reviewed-on: https://gerrit.libreoffice.org/59339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7b52990a234bfd6d4efcbc9fe51e240e065faeea) Reviewed-on: https://gerrit.libreoffice.org/59641 Reviewed-by: Paul Trojahn <paul.trojahn@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28Related rhbz#1618703: Properly handle failure encoding zip fileStephan Bergmann
...when e.g. FIPS mode makes ZipFile::StaticGetCipher fail by throwing an exception which would be caught by ZipPackageStream::saveChild (in package/source/zippackage/ZipPackageStream.cxx) alright (and translated into bSuccess = false), if ZipFile::StaticGetCipher didn't unhelpfully swallow and ignore all exceptions in an outer try-catch. Change-Id: I14376128515df1dd4bdac921edd8ab94cc9b7617 Reviewed-on: https://gerrit.libreoffice.org/59514 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3cc6d3611ac8cbbfb9803f3a084d02edde470ad3) Reviewed-on: https://gerrit.libreoffice.org/59569 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28rhbz#1618703: Allow to use OpenSSL as backend for rtl/cipher.hStephan Bergmann
...with new configuration option --enable-cipher-openssl-backend rtl/cipher.h (which is part of the stable URE interface) offers functionality to en-/decrypt data with Blowfish in ECB, CBC, and streaming CFB mode, and with RC4 (aka ARCFOUR; which is a stream cipher). LO itself only uses Blowfish CFB and RC4, so only those are wired to OpenSSL for now, for simplicity. Using Blowfish ECB and CBC, or Blowfish CFB in DirectionBoth mode would cause failures for now (cf. sal/qa/rtl/cipher/rtl_cipher.cxx); the assumption is that no external code actually makes use of this functionality. Using NSS instead of OpenSSL could be an alternative, but there appears to be no support in NSS for Blowfish in streaming CFB mode, only CKM_BLOWFISH_CBC for CBC mode. Change-Id: I0bc042961539ed46844c96cb1c808209578528a0 Reviewed-on: https://gerrit.libreoffice.org/59428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4bc16aeb73c1201f187742e0fefe35521fae77ac) Reviewed-on: https://gerrit.libreoffice.org/59575 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28apparmor: fix printing to fileVincas Dargis
AppArmor denies writing to .ps files and dealing with temporaries needed for "Print to file" functionality. Add .ps to the allowed extensions list, also giving access to rm executable together with writing printing-related temporary file. Change-Id: I415e1401878bff6459f42162d4e8b517261b9cec Reviewed-on: https://gerrit.libreoffice.org/59114 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> (cherry picked from commit 136077b40cdabab83aec6833bf3895d4305d30a3) Reviewed-on: https://gerrit.libreoffice.org/59662 Reviewed-by: Vincas Dargis <vindrg@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28Related: tdf#112166 require opengl >= 3.0 for slide transitionsCaolán McNamara
glGenVertexArrays requires opengl >= 3.0 and since... commit c831e4851f35ddef5ef45062ba291d07dda4b1b4 Date: Wed Dec 9 21:39:27 2015 +0000 slideshow: Fix what was remaining to be able to use a core context we always use that in all slide transitions, so slideshow opengl transitions presumably thus all have a min opengl version of 3.0 Change-Id: Ifb21201fc94c4a911c8d4127d1df1efb3e34a2d8 Reviewed-on: https://gerrit.libreoffice.org/59299 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#112166 need to check if glXCreateContextAttribsARB really existsCaolán McNamara
checking the glXCreateContextAttribsARB function pointer will just return the epoxy_glXCreateContextAttribsARB stub which always exists. Change-Id: I740cc680082102c1f9712cf5cc083e92b26f8865 Reviewed-on: https://gerrit.libreoffice.org/59301 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119284 bg for automatic not set while editingCaolán McNamara
refactor and reuse fdo#35779 solution for this case Change-Id: I0631cd2560aa2acc2310f95b5c4dea36a2845a58 Reviewed-on: https://gerrit.libreoffice.org/59167 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-05-19 05:05:24 +0000