summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-15bump product version to 6.2.2.2.0+libreoffice-6-2-2Christian Lohmaier
Change-Id: I395cbb22314da4d4b2d333edd6bbe567ddc9d5c1
2019-03-15tdf#122129 Firebird: fix concurrency issueTamas Bunth
Allow only one isc_dsql_prepare at a time. Change-Id: I3d5974057272cd47697aeb7be54579d0c1a662a0 Reviewed-on: https://gerrit.libreoffice.org/67231 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 6affbd2b57a336749a6a2ab3466a4e652a7ff365) Reviewed-on: https://gerrit.libreoffice.org/69227 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit bd5ef0f1ecb445021fc693bfd3cab0979a4c4c28) Reviewed-on: https://gerrit.libreoffice.org/69281 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-15Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-2-2' - update translations for 6.2.2 rc2 and force-fix errors using pocheck Change-Id: I47aa143a6e3e17927fe5d2c4bb66585d25e19f06 (cherry picked from commit be42e4e43972dc6465aa549bf06a44dac5e5376e)
2019-03-15Revert "tdf#49684 Don't focus on Navigator or Sidebar on show"Jim Raykowski
See tdf#122900 for unwanted behavior changed caused by this. This reverts commit 88cbc3ea2db8358bbedff01361f95f972f2b0231. Change-Id: I9451a4b1f059b40d33b66b06f23228fc64170d8d Reviewed-on: https://gerrit.libreoffice.org/67853 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 5a557821c647c1a499270a8a1188e23fc015f782) Reviewed-on: https://gerrit.libreoffice.org/69087 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 35074dc5518e59284663ce85496b3cda406a25eb) Reviewed-on: https://gerrit.libreoffice.org/69129 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-15tdf#123446 sw_redlinehide: fix crash on Redo of ToXMichael Stahl
The problem is that the ToX must be updated with the same layout redline setting as it was originally created, so that subsequent Redo actions see the expected node indexes. Unfortunately it's not enough to just pass a flag to the ToX update functions, because they check GetTextNodeForParaProps() so we need a layout corresponding to the layout setting; if there isn't one, the existing one is temporarily toggled. This could be much better if the MergedPara would be independent of the layout and always exist, but with the various SwModify design issues that looks tricky to do... (regression from 80cedb5dcb6a7dd6c01349b93fab49ecee5f6594) Reviewed-on: https://gerrit.libreoffice.org/68704 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 405661a98f01416c596083262691cedd941733a1) Change-Id: Ibdc5b4ace54ace27e5223a25ecaf39bb493fb69b Reviewed-on: https://gerrit.libreoffice.org/68736 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit e53a3e8cc21b5c54c2463fbad6debd2011307b1c) Reviewed-on: https://gerrit.libreoffice.org/69130 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-15Resolves: tdf#123950 'standard' buttons missingCaolán McNamara
Change-Id: I44d25156c647e28c0b82f1c6da0de90a5a76261c Reviewed-on: https://gerrit.libreoffice.org/68982 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit d890caf52114856a3f909a9c87285ca476817bf1) Reviewed-on: https://gerrit.libreoffice.org/69166 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-15tdf#123304: Allow the full feature syntax as pre 6.2Khaled Hosny
Fix regression from: commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Fri Jun 15 19:32:15 2018 +0200 vcl: parser of font features included in the font name Where hb_feature_from_string() was replaced by a simple parser that supports avery limited subset of the syntax it supports (as documented in https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string) Reviewed-on: https://gerrit.libreoffice.org/69062 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 45deb5b714d2d011eb2a5ad91721a9c2c508a426) Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f Reviewed-on: https://gerrit.libreoffice.org/69068 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 3450311c403af714d3fc0ba14b9f7673c717a6a2) Reviewed-on: https://gerrit.libreoffice.org/69133 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-15Resolves: tdf#123694 we need the controller, not the tabpage parentCaolán McNamara
Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021 Reviewed-on: https://gerrit.libreoffice.org/69205 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-15Resolves: tdf#124028 dangling "completion" entries block responsesCaolán McNamara
so e.g. math font dialog doesn't react to button clicks. since... commit ab8e0f5832fa910f8b1abd36d7cb3929cbac2395 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 18 17:08:58 2019 +0000 Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect remove the entrycompletions but left the reference to them Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22 Reviewed-on: https://gerrit.libreoffice.org/69210 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-14tdf#123637 sw_redlinehide: fix iteration in SwCursorShell::GotoNextOutline()Michael Stahl
If nStartPos == size() and !bUseFirst. (regression from d0e9cc832d19b622532f01580d9cf78ee0b215db) Change-Id: I571d24ec5e9d4f2780e7c6d5c8cee09baeaffcc1 Reviewed-on: https://gerrit.libreoffice.org/68821 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit dfdb7f9fcffe0b8594359c22277b64c7b6cdfd4c) Reviewed-on: https://gerrit.libreoffice.org/68845 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 0308bfd590a5bdf602254491b1a76e055e6c3f85) Reviewed-on: https://gerrit.libreoffice.org/69169 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-13tdf#121040 sc: use pixel-per-twips in X for horizontal value conversionSerge Krot
Change-Id: I25bc3b3ec42ef5b026c2cd9572e8ff1863ed8c2d Reviewed-on: https://gerrit.libreoffice.org/68492 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1b4cfd79240f153703a02d63639b3895ab7c1d1b) Reviewed-on: https://gerrit.libreoffice.org/69207 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2019-03-13tdf#123452 EMF Re-enable compression for image/x-emf filesBartosz Kosiorek
Change-Id: I9fd801d5eef6c65f8e68e30723415da7b493d767 Reviewed-on: https://gerrit.libreoffice.org/68716 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit df22e97db5b7608b6d53b15b86b5a83610f9c87b) Reviewed-on: https://gerrit.libreoffice.org/68729 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 36f027769ea6aaabb5e993a321d7a56775d4bee1) Reviewed-on: https://gerrit.libreoffice.org/69086 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-13tdf#123745 vcl: fix some crash in Window::SetHelpHdl()Michael Stahl
Qt5 has some QEvent::DeferredDelete thing, perhaps that's why it calls this on a disposed Window? 0 vcl::Window::SetHelpHdl(Link<vcl::Window&, bool> const&) (this=0x60cf9e0, rLink=...) at vcl/source/window/window.cxx:1825 1 SalInstanceWindow::clear_child_help(vcl::Window*) (this=0x7fa40c0, pParent=0x60cf9e0) at vcl/source/app/salvtables.cxx:825 2 SalInstanceWindow::~SalInstanceWindow() (this=0x7fa40c0, __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at vcl/source/app/salvtables.cxx:962 3 SalInstanceWindow::~SalInstanceWindow() (this=0x7fa40c0, __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at vcl/source/app/salvtables.cxx:963 4 std::default_delete<weld::Window>::operator()(weld::Window*) const (this=0x60d0b90, __ptr=0x7fa4190) at /usr/include/c++/8/bits/unique_ptr.h:81 5 std::unique_ptr<weld::Window, std::default_delete<weld::Window> >::~unique_ptr() (this=0x60d0b90, __in_chrg=<optimized out>) at /usr/include/c++/8/bits/unique_ptr.h:274 6 SalFrame::~SalFrame() (this=0x60d0b40, __in_chrg=<optimized out>) at vcl/source/app/salvtables.cxx:73 7 Qt5Frame::~Qt5Frame() (this=0x60d0b30, __in_chrg=<optimized out>) at vcl/qt5/Qt5Frame.cxx:167 8 KDE5SalFrame::~KDE5SalFrame() (this=0x60d0b30, __in_chrg=<optimized out>) at vcl/unx/kde5/KDE5SalFrame.hxx:34 9 KDE5SalFrame::~KDE5SalFrame() (this=0x60d0b30, __in_chrg=<optimized out>) at vcl/unx/kde5/KDE5SalFrame.hxx:34 10 QObject::event(QEvent*) (this=0x60d0b30, e=<optimized out>) at kernel/qobject.cpp:1242 Change-Id: I2ac8cb24924ea3178c2b3eed14350515d8506ec3 Reviewed-on: https://gerrit.libreoffice.org/68581 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f8d98bcf37c790e4f02cbe19016b7f29f53e07ff) Reviewed-on: https://gerrit.libreoffice.org/69121 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2019-03-04bump product version to 6.2.2.1.0+Christian Lohmaier
Change-Id: I32a32026a60164b0a923b708a551fc98ce4ec93a
2019-03-04Branch libreoffice-6-2-2Christian Lohmaier
This is 'libreoffice-6-2-2' - the stable branch for the 6.2.2 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.2.x release, please use the 'libreoffice-6-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I138a0b1ffa71d0f07a09036e14f19fd61613af19
2019-03-04reintroduce ScCaptionPtrLuboš Luňák
This basically reverts b6b1ded0a0539e7be1b5338de378a3276a6ff445, since it introduces tdf#118707, and I cannot reproduce any of the original problems when reverting. The patch itself is technically correct, but the problem is in the Windows implementation of clipboard handling, which uses delayed processing of setting clipboard contents. This leads to previous clipboard contents being deleted too late, and with shared_ptr instances of SdrCaptionObj may get deleted after the related SdrModel has already been deleted. A proper fix would be to remove the stupid delayed processing from the clipboard code, but that's non-trivial. If that gets fixed, the change removing ScCaptionPtr may most probably be applied again. Change-Id: I29634847486aa955b20483c9eb38bba4fed87187 Reviewed-on: https://gerrit.libreoffice.org/67725 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68685 Reviewed-by: Eike Rathke <erack@redhat.com>
2019-03-04Resolves: tdf#123748 do not strip date part before calling Time::GetClock()Eike Rathke
GetClock() needs it to properly scale and round the floating point value. It also handles negative values, fiddling with that is only needed for the [] formats. Regression from commit e2e47898180e547cad7ccde1e5890385d573e551 CommitDate: Fri Aug 31 12:50:52 2018 +0200 Use tools::Time::GetClock() in number formatter for wall clock time Change-Id: I05fe9e22886d4e59f110c0a826dadb43234d348a Reviewed-on: https://gerrit.libreoffice.org/68508 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 609ea85b530185910bf326201f785fd32bcbad2b) Reviewed-on: https://gerrit.libreoffice.org/68513 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-04address list doesn't refresh on pressing 'delete'Caolán McNamara
m_nCurrentDataSet doesn't change, so it doesn't refill it, even though m_nCurrentDataSet was deleted so it no refers to a new entry Change-Id: I0c68f407a23a28a7e55fb3cf691e5f07e5ed6729 Reviewed-on: https://gerrit.libreoffice.org/68498 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-04Speed up languagepack installationMichael Schroeder
Reorder the order the filelists are initialized per package. Optimize speed of find_files_for_package: We can simply check if the modules entry is the same as last time. The code uses iterators instead of that C-ish for loops. Create a hash from the packagemodules to speed up the check if a module is included in the hash. Change-Id: I1e8ae394634a527880e08ef8ff333d94d04f49fd Before: 12s per language/package After: <1s per language/package Reviewed-on: https://gerrit.libreoffice.org/68339 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> (cherry picked from commit 6cf3f1fe4b77347f7b327f28e03941a95b9536b3) Reviewed-on: https://gerrit.libreoffice.org/68352 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-04Resolves: tdf#123426 don't reformat tabstop pos while editingCaolán McNamara
we want to know what it would format as, but we don't want to do the formatting during typing Change-Id: I817798adf5b3f9325682f43b92fe107659803b4f Reviewed-on: https://gerrit.libreoffice.org/67820 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-03-04do not call GetFormatTable() from GetNonThreadedContext() (tdf#121949)Luboš Luňák
ScDocument dtor calls ClearLookupCaches(), which calls GetNonThreadedContext(). But ScDocument instances used for copy&paste GetFormatTable() fails on null mxPoolHelper, because ScDocument ctor doesn't set it in such a case. So set up the pointer in ScInterpreterContext on demand only if actually needed. Change-Id: If3811da5bb00a2d7d404c089ee1bf46037a2cddb Reviewed-on: https://gerrit.libreoffice.org/68350 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit b5c3f38cb8d4121e3303be362e0757d3d3431059) Reviewed-on: https://gerrit.libreoffice.org/68539
2019-03-04tdf#123705: avoid duplicate themeColorJulien Nabet
See http://bugs.documentfoundation.org/attachment.cgi?id=149585 + https://bugs.documentfoundation.org/show_bug.cgi?id=123705#c4 Change-Id: I3c6fb0a1ac46a62c75bb9daeaded1633889416eb Reviewed-on: https://gerrit.libreoffice.org/68398 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 42398e3860aafd6468688eda6c0da942323b7f82) Reviewed-on: https://gerrit.libreoffice.org/68613 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-04Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-2' - update templates for 6.2.2 rc1 and force-fix errors using pocheck Change-Id: I0b1ccfeaccbab6f58d2b10d11b7a329f33895b8a
2019-03-04tdf#123772 UnoControlDialogModel: Don't ignore property "Sizeable"Samuel Mehrbrodt
which is supposed to make the dialog resizable, but was silently ignored. Change-Id: Ifa2d2ea70c769f7785ac044ab2b681802c54bc17 Reviewed-on: https://gerrit.libreoffice.org/68515 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit e55c7ff6df82c597763d2eb551f7ccdaa95cd0a9) Reviewed-on: https://gerrit.libreoffice.org/68528 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-04tdf#121440 writerfilter: do not use imported style for foot/endnotesVasily Melenchuk
Extra style is causing editing problem near footnote/endnote references. This behavior is a side effect of eaa9cf6a3069fba3d82c046f0041bfb537d9e648, allowing emission of these "technical" styles. Change-Id: I1885b92814746e7b5cd19f3ddd7bc22eb691615e Reviewed-on: https://gerrit.libreoffice.org/68588 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-01tdf#116382 Replace old dialog in header and footer drop-down menuAditya
Remove the Background tabpage in "Border/Background" dialog accessed from Border and Background menu item in Header/Footer drop-down list and replace it with the tabpages "Area" and "Transparency" of the dialog accessed from Page Style > Header > "More.." button. The old dialog does not have the tabpages "Area" and "Transparency". In simpler words, the patch is to match both the dialogs when accessed in two different ways. Reviewed-on: https://gerrit.libreoffice.org/67483 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 55042cb54fea5f7ad777c03af9bf8197127b6736) Change-Id: Ib84435854389360eba41aecb8578a9a67a92ca1e Reviewed-on: https://gerrit.libreoffice.org/68545 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-03-01avoid std::out_of_range thrown by mdds (tdf#122643)Luboš Luňák
Calling GetLastDataRow/Pos() with MAXROW as the last row is apparently fine, but if that's an invalid row, but anything beyond that is not ok. ScDependantsCalculator::trimLength() may use such larger "last" row value because it works on a range of cells. Change-Id: I819a4d20a4765e23af6208df5f2e208ac44b694c Reviewed-on: https://gerrit.libreoffice.org/68349 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> (cherry picked from commit beba45a5639bc32ca6893885ca3b1f07e3175c08) Reviewed-on: https://gerrit.libreoffice.org/68512
2019-03-01ignore disposed toplevelsCaolán McNamara
Change-Id: Ib5a9bad2537d43f7b6588dbdb958e4cdd34f7023 Reviewed-on: https://gerrit.libreoffice.org/68385 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-03-01tdf#123763 move back break command to graphic context menu for vectorgraphicsandreas kainz
Change-Id: I8af6a0197dc83117d936a7fcf8b794e6d853256a Reviewed-on: https://gerrit.libreoffice.org/68518 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 576519914588021d6e456128c5dee9496abee282) Reviewed-on: https://gerrit.libreoffice.org/68535 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-01Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'libreoffice-6-2' - Moved the pagination controls to the top As the height of the result list keeps changing constantly, it was highly annoying to click the arrows in the controls. Change-Id: I82308adc3971f25ed629009bf1e0854d38197560 Reviewed-on: https://gerrit.libreoffice.org/66795 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit b3686d53d10873b1260091a4c6a898575516217e) Reviewed-on: https://gerrit.libreoffice.org/68522 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'libreoffice-6-2' - This paragraph just repeats what the paragraph immediately above says Change-Id: Iccc9fb41811a4914fdda0f346f9bd32049932448 (cherry picked from commit 36a01a03a960bc2e152cb8ecd21844f91cfa46bd) Reviewed-on: https://gerrit.libreoffice.org/68517 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-28Related: tdf#123711 better optimal size for highlighting tabCaolán McNamara
it only uses the color subtab, so just measure ones which can be visible Change-Id: Id09419480fd920b242f4d0d65e9ac5fbfb619784 Reviewed-on: https://gerrit.libreoffice.org/68432 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-28Resolves: tdf#123711 measure scrollbar for optimal widthCaolán McNamara
Change-Id: I30225124e44e8a6290270ecba5024f36508817d3 Reviewed-on: https://gerrit.libreoffice.org/68429 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-28openssl: upgrade to release 1.0.2rMichael Stahl
Fixes CVE-2019-1559, plus a couple low-severity CVEs. Change-Id: Icb6849ca5f33cb1169ce303505b2e32636e3b25b Reviewed-on: https://gerrit.libreoffice.org/68430 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit e3b6c3ec9fd795601b0749675903fb49c72718fd) Reviewed-on: https://gerrit.libreoffice.org/68440 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-28tdf#123693 raise max sizeCaolán McNamara
Change-Id: I52d69d825ed11a15d9dbbe61f157035361fa5d52 Reviewed-on: https://gerrit.libreoffice.org/68375 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-28fix LockCorruptQueryBox titleNoel Grandin
regression from commit 082e69fefb7439fd4f3d543f0c402039e94c1e9c Date: Mon Feb 26 16:53:37 2018 +0000 convert various MessBox to weld::MessageDialog Change-Id: Ia9cef4de4ae9c13201c838f20f0ba6b6cff7f35d Reviewed-on: https://gerrit.libreoffice.org/68504 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-28fix "doc will be saved" dialog messageNoel Grandin
looks like a copy/paste error in commit 942f05996bc287923cdbcae12c64e57adf8ec975 Author: Caolán McNamara <caolanm@redhat.com> convert remaining ErrorBox to weld::MessageDialog Change-Id: I52d38311b1e276fd799128e058ea0b9c902aef06 Reviewed-on: https://gerrit.libreoffice.org/68491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e76203f45a4c645447f8379ee2123f518a8aca77) Reviewed-on: https://gerrit.libreoffice.org/68502 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-28tdf#123728 Always print on main thread to avoid deadlocksSamuel Mehrbrodt
Change-Id: Ia8c2600aee42c3063e18032d1e485ad417ec4639 Reviewed-on: https://gerrit.libreoffice.org/68421 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 110803068b75ffd895a9b1139aee2248d30f085b) Reviewed-on: https://gerrit.libreoffice.org/68461 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-28tdf#122689 qt5: Consider external clipboard updatesMichael Weghorn
Previously, once 'm_aContents' had been assigned in 'VclQt5Clipboard::setContents()', its value (or the one set in a subsequent call to the same method) was always returned in 'VclQt5Clipboard::getContents()', thus ignoring all system clipboard updates done by any other third-party applications, preventing copy-paste from other applications. In order to take external clipboard updates into account, add a slot for the 'QClipboard::changed' signal and drop the current own clipboard content if the clipboard has been updated by another application. In order to detect whether the clipboard update was made by this 'VclQt5Clipboard' itself or elsewhere, a custom MIME type "application/x-libreoffice-clipboard-uuid" is added, whose value is set to the clipboard's (randomly generated) UUID. If the entry is present and has the correct value, the clipboard content was added by this clipboard and can be kept. Otherwise, clear 'm_aContents', so that it's newly assigned in 'VclQt5Clipboard::getContents()', taking into account the external clipboard update. [Side note: Testing showed that, on Wayland, more 'QClipboard::changed' events were emitted without the clipboard content actually having changed (e.g. when switching focus between windows), which is why an approach of simply setting a flag and checking for that one is not enough, like "wrapping" the 'QClipboard::setMimeData()' call in 'VclQt5Clipboard::setContents()' as follows m_bIsFillingClipboard = true; clipboard->setMimeData(pMimeData.release(), m_aClipboardMode); m_bIsFillingClipboard = false; and then evaluating the 'm_bIsfillingClipboard' flag in 'VclQt5Clipboard::handleClipboardChange' instead of using the UUID-based approach. These additional 'QClipboard::changed' events did not show up the same way while testing on X11.] Change-Id: Ib3a6a4f9b7f5ca3573666fb9c072ae97cf2e0049 Reviewed-on: https://gerrit.libreoffice.org/68214 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 9c5dbbe4b0a62ff1af009beb00f1fc45318dad79) Reviewed-on: https://gerrit.libreoffice.org/68460
2019-02-28KDE5: set correct parent menu in functionAleksei Nikiforov
Set correct parent menu in function Qt5Menu::InsertMenuItem instead of just returning it and setting it later if needed. Change-Id: Id866987e91ec1d57c720735da6afc44109aa901a Reviewed-on: https://gerrit.libreoffice.org/68437 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c74cc70966e9bc3756509f4d50af50ec181e1774) Reviewed-on: https://gerrit.libreoffice.org/68459 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-28tdf#121970 KDE5: Regenerate menu when it's set as submenuAleksei Nikiforov
Also add item bits change notification function for SalMenu to properly convert regenerated menu items to check or radiocheck items. Change-Id: I61f16a771b484644bbefd9afaf2776232d38a2f9 Reviewed-on: https://gerrit.libreoffice.org/68438 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit f341921825370fb98ad896a20d823c5f0cb537f6) Reviewed-on: https://gerrit.libreoffice.org/68458 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-6-2' - tdf#117890 Remove unhelpful screenshots (1/2) Change-Id: I8a96220ae688f78fe43d66ab205323f3d4605140 Reviewed-on: https://gerrit.libreoffice.org/68392 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit c74a4653f50aedfd99ee83a1a841ad5b7886b9be) Reviewed-on: https://gerrit.libreoffice.org/68480 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-27add missing responsesCaolán McNamara
Change-Id: I2c24ea46b6e81ed02ae53da5e9ae1b7df85e44a1 Reviewed-on: https://gerrit.libreoffice.org/68455 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27tdf#120824 KDE5: fix visible/enabled state for menuAleksei Nikiforov
Change-Id: I003703f0bc2e1697124e068a68bfb2e24c33cd1a Reviewed-on: https://gerrit.libreoffice.org/68351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ea6b4b743d397f40029291954af6d37d9059042b) Reviewed-on: https://gerrit.libreoffice.org/68412 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-27tdf#123406 KDE5: Use delayed frame destructionAleksei Nikiforov
Destroy Qt5Frame after all events are received. Update Qt5Object to use delayed destruction too. Change-Id: I07c7251e097ad56f3616f325fdc394d00fec4f4f Reviewed-on: https://gerrit.libreoffice.org/68316 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5fe551931d49a64ca4ea793a5016c098e41e84cd) Reviewed-on: https://gerrit.libreoffice.org/68414 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-27tdf#119720 KDE5: Don't show hidden windows on modality changeAleksei Nikiforov
This change fixes clipping and drawing issues for document recovery window and other modal windows. Change-Id: I005254d4cd2598f4f2d02ba7e7bbf7388affe36c Reviewed-on: https://gerrit.libreoffice.org/68307 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5e8276e665490d961c333f788469a5ecdb996d16) Reviewed-on: https://gerrit.libreoffice.org/68413 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-27Resolves: tdf#123477 let array/matrix formula act as ForceArray on callsEike Rathke
... so the inheritance and checks introduced with ParamClass::ReferenceOrRefArray work for those as well. Change-Id: Ieb87f6a3df5a388f859eae4c5558cf282cd0cde3 Reviewed-on: https://gerrit.libreoffice.org/68236 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 1f97ce11178649a8d16aa4a1df277e1a3bd8ef1b) Reviewed-on: https://gerrit.libreoffice.org/68238 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27Check enable_mpl_subset, too, for mysqlcTor Lillqvist
Change-Id: I083583b86fa404eb16eea354ef9e6d22cf4c62fe Reviewed-on: https://gerrit.libreoffice.org/68346 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-02-26fix Sequence ostream operator<< wrt. constMichael Stahl
Change-Id: I0e9cf35b45b0bcd58ce9d987ffb0384afda4c5dd Reviewed-on: https://gerrit.libreoffice.org/68022 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-02-26these are dialog titles, so no use_underline for mnemonics wantedCaolán McNamara
Change-Id: I88c684c88df391beb62415240580064e97fe87f0 Reviewed-on: https://gerrit.libreoffice.org/68174 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>