summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-15Related: tdf#126931 abbreviated month names should be three lettersEike Rathke
Change-Id: I8d0d54bb70394f9e505d357b1f87aa47ef4d60fe Reviewed-on: https://gerrit.libreoffice.org/77505 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit add2f2e9185a759847f3ccabc2d0cb04306eca85) Reviewed-on: https://gerrit.libreoffice.org/77513 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-15Resolves: tdf#126943 load styles should be modalCaolán McNamara
Change-Id: I7526cd974d3c3ac47f29fda95af226d42d63f583 Reviewed-on: https://gerrit.libreoffice.org/77515 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-15tdf#126859 ensure initial height calculationCaolán McNamara
Change-Id: If4125886fd8d6b70f8d1bd7fc9d89ad093ff0b26 Reviewed-on: https://gerrit.libreoffice.org/77467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2dbe7c08340d6505c528544327e7c27f6d690c6c) Reviewed-on: https://gerrit.libreoffice.org/77511
2019-08-15sw: fix assert on export of ooo39250-1.rtf to DOCXMichael Stahl
The problem is that a fly anchored at-char inside a text frame is being exported; in DocxSdrExport::startDMLAnchorInline() the m_bFlyFrameGraphic is true so an "inline" element is written but then DocxSdrExport::writeDMLTextFrame() sets the flag to true then false, so in endDMLAnchorInline() it's false and "anchor" results. Remove the pointless information hiding between DocxSdrExport and its own pImpl class so that the previous flag can be restored. (regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5 which changed things somehow so that the anchor is inside the text frame instead of the body as it was before; Word has it also in the text frame so we can consider it an improvement) Change-Id: I2df20b5cc336251f1c20cf81b6d68153c0c6ff46 (cherry picked from commit e99f0182ca00d137238f89de67a06415d3c873e3) Reviewed-on: https://gerrit.libreoffice.org/77466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-15sw undo/redo derived style storing during creation by exampleVasily Melenchuk
Same as c4d82fc21c5e155472f6a30244b3fce806ada85c done for tdf#118384, but this code is fixing same problem with SwDocShell::MakeByExample ("New Style from Selection"). Change-Id: I488018bbf5ecb02e9e57eb032b6f875f4fe08f98 Reviewed-on: https://gerrit.libreoffice.org/77199 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 2e6b35cdcac629d98e7082fffffdc27e4fb6f70d) Reviewed-on: https://gerrit.libreoffice.org/77422
2019-08-15Resolves: tdf#126931 fix Sorbian date formats and add genitive month namesEike Rathke
Change-Id: I9ece3f55eff79a3eebc294f7ecc8cca0beae650f Reviewed-on: https://gerrit.libreoffice.org/77477 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d3a565eddffc6e39ffd47f018ec7ab17d2a554cd) Reviewed-on: https://gerrit.libreoffice.org/77481 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-15Resolves: tdf#124108 localized quotation marks for [fr-BF] and derivedEike Rathke
Inherited by fr_BJ fr_CI fr_ML fr_NE fr_SN fr_TG Change-Id: Ic47345fedd0792db213e6584f581ce63b8c5439b Reviewed-on: https://gerrit.libreoffice.org/77470 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 21bffad6bc108f3dc5eee608bf702412a5fcb530) Reviewed-on: https://gerrit.libreoffice.org/77478 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-15avoid invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara
Change-Id: I6fbc991e288b150dcbcfb61018f97fdce69c90cd Reviewed-on: https://gerrit.libreoffice.org/77406 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-6-3' - tdf#126889 Fix icon size in branch 6.3 fix dtd mistake Change-Id: Ic8b0fe43788d6743e3d7f7c11b05d96235a0b967 Reviewed-on: https://gerrit.libreoffice.org/77473 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-14tdf#124700 don't pull from or insert into cache for PixelSnapHairlineCaolán McNamara
Change-Id: I7ca0f556164b6bc462cee3c5532733dbd6b68a2b Reviewed-on: https://gerrit.libreoffice.org/77456 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-08-14sw: avoid dangling references to style in undo/redoVasily Melenchuk
if text style was created/deleted, reference contained in SwUndoAttr is irrelevant and can't be used. Instead of this style name is keept and reference to style is found during redo. Change-Id: I688ae5e7d58149f9fe824c6b0945e72aba82abb1 Reviewed-on: https://gerrit.libreoffice.org/76842 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c8e64ea4fd0122dad9d4f06bacffd1c179e753f8) Reviewed-on: https://gerrit.libreoffice.org/77424
2019-08-14sw: undo/redo dangling pointer removedVasily Melenchuk
pFormatColl can be invalidated if it refers style previously removed/created during undo/redo. So instead of keeping pointer let's use style name. Change-Id: I79c5a92046134c1921c9245f78335c8f033b05fb Reviewed-on: https://gerrit.libreoffice.org/76781 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d2750b7eb02d6f1c8866199c98fe2e2286639b88) Reviewed-on: https://gerrit.libreoffice.org/77423 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-14tdf#118384 Fix paragraph, character, and frame style undo redoJim Raykowski
In order for the inherited (parent) style to be restored after create style undo redo it must be included in the create style undo append. This patch prevents create style undo append during style make and provides for it after style dialog return ok when the parent of the new style is known. Change-Id: Ie9d7fb7989a5e669db18a1f263632ff208b0e718 Reviewed-on: https://gerrit.libreoffice.org/76279 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c4d82fc21c5e155472f6a30244b3fce806ada85c) Reviewed-on: https://gerrit.libreoffice.org/77433 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-14Resolves: tdf#126844 focus in to combobox with entries not seen in parentCaolán McNamara
there isn't a focus-in on the combobox, only the entry. So use entry focus-in as focus-in (we already do this for the combobox dropdown) Change-Id: I09cf6eb896acbbea5aed2d3b2aa238593ddcb793 Reviewed-on: https://gerrit.libreoffice.org/77410 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-14tdf#126808 vcl: fix crash due to leaking the frame's buffer vdevMiklos Vajna
This vdev is used to do vcl-level double-buffering, which is off by default, but e.g. listboxes/comboboxes use it to avoid flicker with Windows GDI. The root cause was introduced in commit ea5e83abcfa1406c401b8a1ec91efda65373b74b (tdf#92982 vcl: stop creating/disposing the paint buffer in PaintHelper, 2015-07-30), which removed the explicit mpBuffer.disposeAndClear() in the PaintHelper dtor, but forgot to explicitly dispose it elsewhere. This is now a much more visible problem since commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e (tdf#101978 vcl combobox/listbox floating window: avoid flicker, 2019-06-17) as the infrastructure is used for all list/comboboxes. Fix the problem by explicitly disposing the vdev before deleting the frame data, so the underlying GDI resource is released, even if we have a reference cycle. Change-Id: Ia217bbd78780a214308e497044e73e378ee8ecd6 Reviewed-on: https://gerrit.libreoffice.org/77370 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit e71093c0bc52426647a9d3a41ac0643bbc6cb0c6) Reviewed-on: https://gerrit.libreoffice.org/77389 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-14Writer: Saving a damaged file as DOCX crashesTamás Zolnai
Change-Id: I42de376c69d0b1caa0a03622506d1bf6385ca57e Reviewed-on: https://gerrit.libreoffice.org/77412 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit de8415ff5a730465258cd5f0ab7c0d989ba5518d) Reviewed-on: https://gerrit.libreoffice.org/77444 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-14configure: don't enable export validation if there are no schemasMichael Stahl
Schemas are excluded from tarballs since commit 34dced99c33a97dab86c4538fa267ad4ad4fb41f because of the license. Change-Id: I6540926d9ebb390d7956bbd1df3bb915adebb64b Reviewed-on: https://gerrit.libreoffice.org/77383 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit c78dd0a726b32d922a0d75a26a51d4c30612368c) Reviewed-on: https://gerrit.libreoffice.org/77392 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-14tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAGMike Kaganski
... because RES_CHRATR_GRABBAG value may be later reset by initial value read from char format, when it's present there. OTOH, RES_PARATR_GRABBAG shouldn't be present in character format, so it should be safe to pass the grabbag item there. Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e. Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2 Reviewed-on: https://gerrit.libreoffice.org/76981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 30d03b495f437e9b2edbb0f8ceebe3020ba7459c) Reviewed-on: https://gerrit.libreoffice.org/77016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-14tdf#126848: sc pivot table popup: avoid flickerXisco Fauli
Follow-up of 4dadbff74eff5f8ad00df99c659f8a2b914e09a1 Regression from commit a4cb27f61376d8f2d8faed0022c291af68d437bd Change-Id: I4d0cd2ad2d7d239307c48c9bc8c1f1ced6597f47 Reviewed-on: https://gerrit.libreoffice.org/77408 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 1352b1fcfa1668081c3197a12d5362286f8f9710) Reviewed-on: https://gerrit.libreoffice.org/77427 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-13tdf#126680 Revert "VCL make horizontal scrolling depend on RTL"Jan-Marek Glogowski
This reverts commit 845743131b733b52eb913048f55f5efdd013b24f. And fixes the direction in Qt, which I intentionally broke. Didn't find time yet to fix all the backends, so just stay with the original code. Change-Id: I9967a0d7e75dcb99f8465e9eecf81afe2d351064 Reviewed-on: https://gerrit.libreoffice.org/77390 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit a0a6a7e60ee499ffd82a57b899ca5f4981f0ab2f) Reviewed-on: https://gerrit.libreoffice.org/77428 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-13tdf#116085 add more Gpg4Win binary locationsThorsten Behrens
Seems Gpg4Win recently grew a few more variants where to put stuff. Look there, too. Change-Id: Ifa09db11665671f518a6a66480c1a71fd619d8cd Reviewed-on: https://gerrit.libreoffice.org/77341 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 536ab2f3ba1e71badaaf98db9419ca7c7ddd7ac4) Reviewed-on: https://gerrit.libreoffice.org/77420 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-13tdf#125923 Fix reset button.Gülşah Köse
Reset/Revert button worked as cancel, not reset. That commit provides reset button to do its own job. Reviewed-on: https://gerrit.libreoffice.org/76341 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 15664117ef4db51bdcabb46b7990573509da0d73) Change-Id: I82d3e838bff3fd690cb5a901232ecb5f76257b95 Reviewed-on: https://gerrit.libreoffice.org/76345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-13tdf#125100 After insert of calc document as OLE object, content is shownIlhan Yesil
After inserting an OLE object, the object has to be shown with the preview of it's content. The flag for this is set in the InsertObject method. Change-Id: I9f0f362190bb9ab0bc36987cf0a6f969932544ec Reviewed-on: https://gerrit.libreoffice.org/75207 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 7dbeb17da18612df84a4f865057059f7eea8350c) Reviewed-on: https://gerrit.libreoffice.org/77391 Tested-by: Jenkins
2019-08-13Resolves: tdf#122358 ensure right/bottom borders are included in damage regionCaolán McNamara
a simple safely backportable expand of damage region by one pixel Change-Id: If4d226d8546d55b00172d826c8816b09b55d54ef Reviewed-on: https://gerrit.libreoffice.org/77207 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13Resolves: tdf#126766 fix rounding correction at start of negative valuesEike Rathke
doubleToString() is entered with an inaccuracy afflicted fValue=-9999.9999999999927 for which the rounding into the next magnitude incremented the '-' character to '.' instead of appending a '1' (and '0' and then "000") thus yielded ".0000" instead of "-10000" This seems to have been always the case. Change-Id: I66170defa71fec40ca0b85f68affde8eff0d5ccb Reviewed-on: https://gerrit.libreoffice.org/77208 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit be8da97976658ff19b4dd010bff328cd3f424c1b) Reviewed-on: https://gerrit.libreoffice.org/77215 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-13construct final url from parsed outputCaolán McNamara
Change-Id: Ifd733625a439685ad307603eb2b00bf463eb9ca9 Reviewed-on: https://gerrit.libreoffice.org/77373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 87959e5deea6d33cd35dbb3b8423056f9566710e) Reviewed-on: https://gerrit.libreoffice.org/77379
2019-08-13Expand collapsed sidebar when calling XSidebarProvider::showDecksSamuel Mehrbrodt
This UNO call did not work correctly when the sidebar was completely collapsed. Change-Id: I3de0b89d95aa81287c36911bbd52a9941d9886b3 Reviewed-on: https://gerrit.libreoffice.org/76530 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-12tdf#126723 writerfilter::finishParagraph - me, not previousJustin Luth
In LO 6.2 commit 480ac84f2f5049fb4337b36f12fd6796e005761b the existing m_xPreviousParagraph was conveniently used to apply the changed properties. I never did like that choice, but despite looking at it, I failed to see that it is set in an inside loop, which means that it was NOT NECESSARILY reset to the current paragaph. So I'm happy to have proof that we should not use m_xPreviousParagraph. Change-Id: I5c7f1b0f097711d65ae0d0be1f0fbc40c8b96e9d Reviewed-on: https://gerrit.libreoffice.org/77185 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit d03c92b93d6ba1808a6641b4aa8cb4aae38058bf) Reviewed-on: https://gerrit.libreoffice.org/77218 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-12Resolves: tdf#126736 change range on change of unitCaolán McNamara
and make the max % 800 instead of 500 while we're at it (0.15cm is considered 100% FWIW) when flipping from measurement unit to % Change-Id: Ia1b15559f3db0d1e11d4563ad7c6aacc3f9ba32d Reviewed-on: https://gerrit.libreoffice.org/77193 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-12tdf#126746 Fix exporting closed Polylines to PPTXBartosz Kosiorek
In previous implementation the closed shapes was imported as a polylines without closing joint. As a result the joint style was not applied. This patch fixes that, and allow proper PPTX export. TODO The same issue needs to be fixed for PPT export Change-Id: I557daac1ba02330d8923f7eda3476e67d8711384 Reviewed-on: https://gerrit.libreoffice.org/77179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 3feaff84fafc23c26ff9c6a716709f17a6c8330b) Reviewed-on: https://gerrit.libreoffice.org/77229 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-08-12tdf#126626 sw: fix duplicate SwUndoInsLayFormat in single-node CopyMichael Stahl
Fly Undo created later in SwUndoInserts::SetInsertRange(); suppress it in DocumentContentOperationsManager::CopyImpl(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I3b8756c20a7472029748d9e64a941320fc10b19f Reviewed-on: https://gerrit.libreoffice.org/77190 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 844f9fa6ba7108b12758202c5fd08daa2a707641) Reviewed-on: https://gerrit.libreoffice.org/77214 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-12tdf#126590 DOCX import: fix absolute hyperlinks to documentsTünde Tóth
Absolute links in DOCX documents created with Word didn't work. Change-Id: Ie23c9ded1c88752768b925ec26df3061beeddd8e Reviewed-on: https://gerrit.libreoffice.org/76581 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/77191
2019-08-12tdf#126769 Sidebar can't be collapsed clicking on the hide arrowSamuel Mehrbrodt
Change-Id: I72ab41fb6c98ab548a1b3cfce837ab9312c7df66 Reviewed-on: https://gerrit.libreoffice.org/77156 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 2812610f4f39ed5892da08864893c758325d1d39) Reviewed-on: https://gerrit.libreoffice.org/77325 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-12Resolves: tdf#126790 use TopLevelWindowLocker in welded help pathCaolán McNamara
Change-Id: I4340d021b63609189d3179a7bcff7fac4fcef69d Reviewed-on: https://gerrit.libreoffice.org/77196 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-10tdf#126627 sw_redlinehide: fix corner case in SwUndoDelete::UndoImpl()Michael Stahl
The assumption that the merge by the moved nodes would be sufficient to handle the end node's frames is wrong: the MakeFrames() uses FrameMode::New, so the frames on the end node are not deleted, even if a previous node is merged with the end node, so the end node has 2 frames in the same layout, which will cause all sorts of problems. Ensure that the ::MakeFrames() that is called from SwUndoDelete will *once* use FrameMode::Existing, which will delete the existing frames on the end node *iff* it is merged. Subsequent SwTextNode::MakeFrames() calls on the nodes must use FrameMode::New of course, to prevent deleting the newly created frames immediately. Hopefully the SwUndoDelete is the only caller of MakeFrames() that will run into this corner case, as the others typically operate on a nodes-array section... (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I829c1e7a92434f93d56e3c88a4ba4a55bab818d4 Reviewed-on: https://gerrit.libreoffice.org/77211 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit f6a7dee56c984f36261c75a1056cc3a5bf43b2f1) Reviewed-on: https://gerrit.libreoffice.org/77220 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Resolves: tdf#126732 don't abort on IOException, just reportCaolán McNamara
Change-Id: Ia68b6e1e603fbc6397645abdf0ea7131a547ad42 Reviewed-on: https://gerrit.libreoffice.org/77187 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-08-09tdf#126748: temporary hack to avoid crash when several pivot tables ...Mike Kaganski
... reference a single cache, and have different sets of group fields. The problem is getting group field names from the tables referencing the cache; so when a table referencing not all group fields happens to be first in the reference list, the returned name is empty. The hack just stops writing group fields as soon as it finds an empty name; this naturally leaves bad cache data behind, but at least doen't crash. The retrieval of the names should be reimplemented using a different source, to not depend on tables referencing the cache. Regression after commit b082998401e37e6c7534906601bc481423a6ded0. Change-Id: Ib2e92f8acf93a801861c6ba5c68fab3bebe3672c Reviewed-on: https://gerrit.libreoffice.org/77110 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f5c27036ad63c8bc3d9b86f2e4e772c01490d883) Reviewed-on: https://gerrit.libreoffice.org/77124 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09tdf#125628: FORMATTING: Part of text loose yellow highlight reopening documentTamás Zolnai
Change-Id: Id42c33857537451c2dec17d24f65b10f9c16dfa2 Reviewed-on: https://gerrit.libreoffice.org/77135 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit fa774e16b1dfe4844ec5eb3f9372d6468f6b8a56) Reviewed-on: https://gerrit.libreoffice.org/77155 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-08tdf#126708 Fix EMF image size in CLI .doc exportLuke Deller
Implement EMF image size detection, to fix this bug where an EMF image gets zero size when exported to .doc format from the command line. Reviewed-on: https://gerrit.libreoffice.org/77031 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 6369cab9b1e16275c8700692bb717aec3c42d346) Conflicts: sw/qa/extras/ww8export/ww8export3.cxx Change-Id: If980c5d65d4880150815fd1df9704d9c1b3b93c9 Reviewed-on: https://gerrit.libreoffice.org/77136 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-08Resolves: tdf#126691 width/height considered changed, but it didn'tCaolán McNamara
regression from... commit c4041a3b6c703254ee3977eef1a989992506772b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon May 28 14:33:42 2018 +0100 weld SvxSwPosSizeTabPage Change-Id: Ib8a5359a1aee9ac7b645621b9de9311cd56449f5 Reviewed-on: https://gerrit.libreoffice.org/77122 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-08Resolves: tdf#125483 locale separator label needs to be derived from originalCaolán McNamara
regression from... commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Change-Id: I940269d14a0a84768c4f8e62c153cfac51cf577f Reviewed-on: https://gerrit.libreoffice.org/77087 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-07tdf#94300: custom gradients apply also from chart sidebarKatarina Behrens
Change-Id: Id6ba90b404ad97cdfc4091bcb4028677f1600fa2 Reviewed-on: https://gerrit.libreoffice.org/75693 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 0e15fb798a0d1fc8cc221ae2334411fac144f173) Reviewed-on: https://gerrit.libreoffice.org/77035 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-07tdf#126642 always allow PDF/A form exportJan-Marek Glogowski
This generally enables form export for PDF/A. A major problem was the saved user setting for UseTaggedPDF, which was overridden by the PDF/A export and used to be stored in the user config. At this point it was impossible to actually restore the user config for the next export, because it contained the overwritten PDF/A value. So this now guarantees that the user selection is stored, which means the underlying filter reading the config has to ignore the users UseTaggedPDF setting for PDF/A, which is happening in any way. That way it is possible to correctly restore the previous user selection after unchecking the PDF/A option. And the "Create form" frame is kept sensitive, just based on the "Create form" checkbox. Change-Id: I29162b423b2d8de77f549fdaabf0aefebcefa124 Reviewed-on: https://gerrit.libreoffice.org/76765 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c864d894a90141f6d73ed80c1035909986b17074) Reviewed-on: https://gerrit.libreoffice.org/77092
2019-08-07redland/raptor: use system xml2-config only on MacOSXMichael Stahl
On Fedora 30, we get: instdir/program/libraptor2-lo.so.0 has suspicious NEEDED: liblzma.so.5 Because: > xml2-config --libs -lxml2 -lz -llzma -lm -ldl However: > pkg-config --libs libxml-2.0 -lxml2 So prefer pkg-config for system libxml2, except on MacOSX, where people claim that pkg-config leads to disaster. Change-Id: I29ffd2ced769d7111c4de17de53082db2e2ba326 Reviewed-on: https://gerrit.libreoffice.org/77093 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 1067c32964e4e0754d2d926e1319b4060ded93f5) Reviewed-on: https://gerrit.libreoffice.org/77099 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-07tdf#42316 preserve macro signature of templatesJan-Marek Glogowski
When comparing the filter of the current and the target document we have to strip the '_template' from the filter name. Still this won't preserve the signature of the document attached to tdf#42316, as this is a ODF 1.0 OTT, which doesn't have a valid signature in ODF 1.2, as the signature doesn't match the ODF 1.2 namespace for signatures and the default LO ODF version is ODF 1.2 extended. In theory the signature itself could even be converted most times, but that can be done in an additional patch, if needed. Since the code literally saves a template to an internal document, SfxObjectShell::DoSaveCompleted must keep the signature of the template. Eventually it'll be dropped on save of the template as a document later. The signing tests check "OTT 1.0 => ODT 1.0: preserve", "OTT 1.2 => ODT 1.2: preserve" and "OTT 1.0 => ODT 1.2: drop". Change-Id: I2263093687f5a0568ea781ce3ac9b114c9599add Reviewed-on: https://gerrit.libreoffice.org/75958 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c3a1c83ff5af05d34f433ac808adbe85f47e8c18) Reviewed-on: https://gerrit.libreoffice.org/77112
2019-08-07tdf#123591: truncate and round to 'scale' number of decimal placesXisco Fauli
otherwise the number will be incorrectly converted to OUString if scale < number of decimals See https://bugs.documentfoundation.org/show_bug.cgi?id=123591#c25 Change-Id: Ie32c9c6ab339d6907e9a4e2645d6f19bad9e67c8 Reviewed-on: https://gerrit.libreoffice.org/75727 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 54028dc503fc08eb12e287919d5e2850cff05b73) Reviewed-on: https://gerrit.libreoffice.org/76751
2019-08-07tdf#121599, tdf#123099: ignore migration dialog whenXisco Fauli
1. a new HSQLDB database is created 2. the HSQLDB database is not opened interactively Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b Reviewed-on: https://gerrit.libreoffice.org/75643 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 77ef0a92b3bd19f836d0fcb2a41af5e643129283) Reviewed-on: https://gerrit.libreoffice.org/76843
2019-08-07tdf#126663 speed up styles displayNoel Grandin
reduce temporary OUString creation in a hotspot, reduces the time for me from 9s to 1s Change-Id: I0d5c479f124361661d55e78b802c04a06a3fefae Reviewed-on: https://gerrit.libreoffice.org/77098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 66661417ff019831cbe7e647be2df1a4328ec2e6) Reviewed-on: https://gerrit.libreoffice.org/77134
2019-08-07tdf#126588 crash in saving viewNoel Grandin
regression from commit d425658bd9fd8e315e4931afb544bc845da0360e Date: Wed Dec 19 16:10:51 2018 +0200 pass OSQLParseNode around by unique_ptr We have a OSQLNode being deleted at connectivity::OSQLParseNodesContainer::clearAndDelete() at connectivity/source/parse/sqlnode.cxx:2781 connectivity::OSQLParser::parseTree(rtl::OUString&, rtl::OUString const&, bool) (this=0x38eba90, rErrorMessage="syntax error, unexpected UNION, expecting $end", rStatement="CREATE VIEW \"View1\" AS SELECT \"Tab1\".\"Name\" AS \"Name1\", \"Tab1\".\"Geburtsdatum\" AS \"Geburtsdatum1\", 1 AS \"MonatZahl1\", COALESCE(\"Tab1\".\"MonatZaehler\",999) AS \"MonatZaehler1\", 'Januar' AS \"Monat1\", \"Tab2"..., bInternational=false) at workdir/YaccTarget/connectivity/source/parse/sqlbison.cxx:10914 namespace)::parseStatement_throwError(connectivity::OSQLParser&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (_rParser=..., _rStatement="CREATE VIEW \"View1\" AS SELECT \"Tab1\".\"Name\" AS \"Name1\", \"Tab1\".\"Geburtsdatum\" AS \"Geburtsdatum1\", 1 AS \"MonatZahl1\", COALESCE(\"Tab1\".\"MonatZaehler\",999) AS \"MonatZaehler1\", 'Januar' AS \"Monat1\", \"Tab2"..., _rxContext=uno::Reference to (dbaccess::OSingleSelectQueryComposer *) 0x38eb8d0) at dbaccess/source/core/api/SingleSelectQueryComposer.cxx:106 and then again at std::unique_ptr<connectivity::OSQLParseNode, std::default_delete<connectivity::OSQLParseNode> >::operator=(decltype(nullptr)) (this=0x38eba90) at connectivity/source/parse/sqlnode.cxx:1500 Change-Id: I292627a06369208e0010743063c7eb5a38921a19 Reviewed-on: https://gerrit.libreoffice.org/77106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 6d024a69164716f7856ec936a72d01a6630d2a7c) Reviewed-on: https://gerrit.libreoffice.org/77133 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-07tdf#126685 CRASH: selecting all in sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. We need to clamp the columns whenever we change sheet/table Change-Id: I5cf22b2a7cf2f6473b8340289bcddd75ed0ad70b Reviewed-on: https://gerrit.libreoffice.org/77105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d1cddc4775f03a52bb8fa2229dc5624d8cc5a3ce) Reviewed-on: https://gerrit.libreoffice.org/77125 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>