summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-29Related: tdf#127029 true was substituted for FALSECaolán McNamara
presumably accidentally by... commit 6ed0bcdd5bc07692fc81406942509eb9c30d3904 Date: Tue Oct 5 07:57:51 2010 -0500 FASTBOOL to bool conversion @@ -1305,7 +1305,7 @@ BOOL SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp if ( m_pImpl->m_bInSearchMode && bChanged && aInfo.GetWeight() == WEIGHT_NORMAL && aInfo.GetItalic() != ITALIC_NONE ) - bChanged = FALSE; + bChanged = true; } if ( !bChanged && pExampleSet && Change-Id: I711e6dbf26570189f9940958b02ca4e9561bf318 Reviewed-on: https://gerrit.libreoffice.org/77737 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29Don't hardcode "C:\\Program Files (x86)" path on WindowsMike Kaganski
It might be simple "Program Files" on 32-bit system; or localized (see https://www.samlogic.net/articles/program-files-folder-different-languages.htm), or on a different drive (if system isn't on C:), etc. Change-Id: Id0f28b4c4920fcda53a58fbff9f42bcfde6668f6 Reviewed-on: https://gerrit.libreoffice.org/77448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 9c8854b7d6e5c9debc7eeae57c0d51a3f151a03e) Reviewed-on: https://gerrit.libreoffice.org/77535 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29tdf#107776 sw ODF shape import: make is-textbox check more strictMiklos Vajna
Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF import/export, 2014-10-04), the problem was that we assumed graphic autostyles look like: <style:style style:name="gr2" style:family="graphic"> for simple (non-text-box) content, and look like: <style:style style:name="gr1" style:family="graphic" style:parent-style-name="Frame"> for complex (text-box) content. Turns out it's valid to have other parent styles as well, e.g. Graphics, which should not be imported as sw textboxes. With this, the arrow at the bottom of page 3 of the bugdoc is now again on top of the image, i.e. layout compatibility is restored. (cherry picked from commit 28d67b792724a23015dec32fb0278b729f676736) Change-Id: Icbba8a23c5f66e63090f90e6581ebc98948cb80b Reviewed-on: https://gerrit.libreoffice.org/78172 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-29Resolves: tdf#127029 keep spinbuttons blank if explicit set_text("")Caolán McNamara
and the value isn't changed by the user Change-Id: Ib45360c0a1b057c4a31fe399aada143d758615d1 Reviewed-on: https://gerrit.libreoffice.org/77744 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-29tdf#127085: FILESAVE: Transparency is lost after RTTamás Zolnai
Reviewed-on: https://gerrit.libreoffice.org/77963 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 505cbb9c3d2771a12c989515663cc1eb73dd0c2f) Change-Id: I22ba83b5cc00f84112a3755898ee2be58337afd6 Reviewed-on: https://gerrit.libreoffice.org/77978 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-29tdf#125340 transport preferred dialog parent down the migration dialogCaolán McNamara
Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3 Reviewed-on: https://gerrit.libreoffice.org/77638 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-6-3' - add icon size for svg images Change-Id: I96e309e9030e3587dc3d75511aa3ff9c894efab3 Reviewed-on: https://gerrit.libreoffice.org/77634 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-29tdf#126007 tdf#122355 online help won't look into a dialog notebookCaolán McNamara
when the focus is on the help button, offline will through the help fallback route, but online will just fire and forget and let the server side do a fallback, which can't know what the current notebook page was. so bodge it to look at the notebook page right from the start if there is one and its the help button itself which starts the request Change-Id: Ida1d3101d838d99639dda12c438414c16b1ccda5 Reviewed-on: https://gerrit.libreoffice.org/77549 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-28Resolves: tdf#126928 allow link updates in an intermediate linked documentEike Rathke
... if link updates are allowed in the current document and that intermediate document resides in a trusted location. This works with both, the "Always (from trusted locations)" and the "On request" settings under Tools -> Options -> Calc -> General. It can't work with documents residing in a non-trusted location as there is no way to allow updates on demand for a such loaded document (hidden via formulas). Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423 Reviewed-on: https://gerrit.libreoffice.org/77588 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640) Reviewed-on: https://gerrit.libreoffice.org/77604 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-28Related: rhbz#1691287 fill in default domain and usernameCaolán McNamara
and grab focus to first entry entry Change-Id: Icb50766948c77072eaab9faf89436c6ecbb49ecc Reviewed-on: https://gerrit.libreoffice.org/77676 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-28tdf#103345 Import decimalEnclosedCircle correctlySamuel Mehrbrodt
Change-Id: I227d149d07ea0f7b2569e5df5a5589834374fac9 Reviewed-on: https://gerrit.libreoffice.org/77992 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 66576edf4e7ed26f09788fac348ea6b556ae1c47) Reviewed-on: https://gerrit.libreoffice.org/77999 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-28add Silesian (szl) language packChristian Lohmaier
Change-Id: I47d9659fc21abec652a5a440004c0c2d27ec3b53 (cherry picked from commit f22ce154c7aa2275ed51a5321892ba0d5254d94c) Reviewed-on: https://gerrit.libreoffice.org/78192 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-27Fix old boost build for goodTomáš Chvátal
With the previous approach the code could lead to crashes in the flowfrm.cxx Change-Id: I3b56ed46db9d37a606a1cd793a20b8aff22db6e2 Reviewed-on: https://gerrit.libreoffice.org/78002 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-27tdf#126784 sw: only distribute across selected columnsJustin Luth
partial revert of LO6.2 commit ab18c17d70e1dcf5cf9db38256d35e6af479373e because MERGED cells had a very unexpected effect on the columns that were altered. Unselected columns are INCLUDED in the calculation IF they extend over the selected columns when SwTableSearchType::Col uses the entire table column. The last table in the unit test demonstrates why the regressive behaviour was included. A user can make an ugly layout if they don't choose a good set of columns. However, the merged cell really changes the way the calculation works, and since giving power to the user is ultimately the best, just revert the portion that tries to save the user from themself. I struggled then and now to get a good enough understanding to improve the documentation - which really is needed since reading it didn't help me a lot. However, since my understanding was and is obviously flawed, I'll just revert back to the original wording. Change-Id: Icf8f01f095652e2a023e0398852f43aa6b90332f Reviewed-on: https://gerrit.libreoffice.org/77976 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit d0e268ca18ec0d907980ca608c97fe8f727d20df) Reviewed-on: https://gerrit.libreoffice.org/77984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-26Improve checkStephan Bergmann
Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 761e6dd25782420bf06e4a2ff3205a79b6cbb136) Reviewed-on: https://gerrit.libreoffice.org/78127 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-26Resolves: tdf#126693 cannot put focus into combobox entryCaolán McNamara
Change-Id: I52a316e5c88a41c66ef08be1bae8fcdd10d2ab8e Reviewed-on: https://gerrit.libreoffice.org/78031 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-26tdf#126746 Add support for import/export line caps for .pptx formatBartosz Kosiorek
With this commit I have added importing and exporting line caps, which could be (for pptx format: rnd Round Line Cap sq Square Line Cap flat Flat Line Cap Also exporting of these caps are added. Change-Id: I799485048a2a7ac8df89f004e177d507f86ce99d Reviewed-on: https://gerrit.libreoffice.org/77233 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 606a88d2abf85aa6edcc1fa26dc50cab6de3241f) Reviewed-on: https://gerrit.libreoffice.org/77553 Tested-by: Jenkins
2019-08-24tdf#126792: DOCX legacy drop-downs are only supposed to hold 25 items, DOCXTamás Zolnai
Truncate item list if the MSO limit is exceeded. Reviewed-on: https://gerrit.libreoffice.org/77844 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8d84f32d55df06c2944da78e2b779de2dba21d50) Change-Id: I21fd63fd2b8d6c8fe76500e1cdd468d4692612c1 Reviewed-on: https://gerrit.libreoffice.org/77869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-24Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara
set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78041 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-23tdf#107394 sc ui: fix lack of row height update on undo of pasteMiklos Vajna
This is a problem since commit df9243626b39742a9a148bea95796f8824fee68a (fdo#73606: Avoid excessive and unnecessary heap allocation of array objects., 2014-01-14), though it seems this uncovered a problem that was introduced earlier. Reading ScViewFunc::AdjustBlockHeight(), commit 64a36fd4f4085ed05e4c0ee40ac109452ff81a78 (ScUndoPaste to handle multiple ranges., 2011-09-09) changed ScUndoPaste::DoChange(), so that AdjustBlockHeight() is invoked in a loop, but always with the same arguments. In case AdjustBlockHeight() doesn't get a mark data, the function takes the mark data from the view data, which is empty in the "undo of paste" case, so no row height gets updated. Fix the problem by explicitly providing the mark data to AdjustBlockHeight(), probably that was the intention in the second commit. [ Testing this from CppunitTest_sc_copypaste means ScImportExport has to be dllpublic, but that seems still better than having a view shell in CppunitTest_sc_ucalc. ] (cherry picked from commit 4840880148318dc384e28f9a8df9990b8690a4b6) Change-Id: I140b53588d59d231772152c0e820e5fdedf6894c Reviewed-on: https://gerrit.libreoffice.org/76318 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-08-22tdf#126560 Qt5 fix D'n'D key-modifier handlingJan-Marek Glogowski
The patch has still one problem: the key-modifier state isn't reflected by the cursor, unless the user moves the mouse. There is an upstream Qt bug, reported in 2016-09 against Qt 5.6.1! It is supposed to be fixed in Qt 5.12, according to the bug report at https://bugreports.qt.io/browse/QTBUG-56218, which is still open. I thought about adding a configure test, but I couldn't imagine any realistic way to write it. And after Michael Weghorn found the bug is actually not fixed, as claimed in one of the comments, I decided to drop the warning. Change-Id: Ice8ebc4ea149282b4c1551e755efe3d4856cf782 Reviewed-on: https://gerrit.libreoffice.org/77174 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 3355be0616c24c5e44b71e7623c4191ed9c69074) Reviewed-on: https://gerrit.libreoffice.org/77956
2019-08-22tdf#126271 Revert "tdf120965 Simplify SdrPathObj::AddToHdlList()"Regina Henschel
This reverts commit 26001f4f84b0d921c8612d888856613735ba5314. Change-Id: Ib4df476b405e65be9203ab376c9c68b03198c040 Reviewed-on: https://gerrit.libreoffice.org/77882 Tested-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 59189f3e02acbdf4e5bbd35fc278252b30022f43) Reviewed-on: https://gerrit.libreoffice.org/77939 Tested-by: Jenkins
2019-08-22Fix full url for calc/styles by adding missing '/'Julien Nabet
warn:sc:1272:1272:sc/source/filter/orcus/orcusfiltersimpl.cxx:149: Unable to load styles from xml file! boost::filesystem::file_size: Aucun fichier ou dossier de ce type Thread 1 "soffice.bin" hit Breakpoint 2, (anonymous namespace)::lookup (file=0x5555556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, override=false, key="BRAND_BASE_DIRshare", requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860 860 OUString v; (gdb) bt 0 0x00007ffff7f2ae45 in (anonymous namespace)::lookup(Bootstrap_Impl const*, (anonymous namespace)::LookupMode, bool, rtl::OUString const&, (anonymous namespace)::ExpandRequestLink const*) (file=0x5555556435a0, mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, override=false, key="BRAND_BASE_DIRshare", requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:860 1 0x00007ffff7f2b7f6 in (anonymous namespace)::expandMacros(Bootstrap_Impl const*, rtl::OUString const&, (anonymous namespace)::LookupMode, (anonymous namespace)::ExpandRequestLink const*) (file=0x5555556435a0, text="$BRAND_BASE_DIRshare/calc/styles.xml", mode=(anonymous namespace)::LOOKUP_MODE_NORMAL, requestStack=0x0) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:995 2 0x00007ffff7f2aa0d in rtl_bootstrap_expandMacros_from_handle(rtlBootstrapHandle, rtl_uString**) (handle=0x5555556435a0, macro=0x7ffffffefb90) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:791 3 0x00007ffff7f2aa60 in rtl_bootstrap_expandMacros(rtl_uString**) (macro=0x7ffffffefb90) at /home/julien/lo/libreoffice/sal/rtl/bootstrap.cxx:797 4 0x00007fffde89e675 in rtl::Bootstrap::expandMacros(rtl::OUString&) (macro="$BRAND_BASE_DIRshare/calc/styles.xml") at /home/julien/lo/libreoffice/include/rtl/bootstrap.hxx:131 5 0x00007fffde890d5f in ScDocShell::Load(SfxMedium&) (this=0x555558034760, rMedium=...) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docsh.cxx:613 Change-Id: I5e4019c730f25d32b431dbd01c5668189be6cc66 Reviewed-on: https://gerrit.libreoffice.org/77936 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org> (cherry picked from commit 86d55aaad49a3f83b61894afd81f195b37a142af) Reviewed-on: https://gerrit.libreoffice.org/77955
2019-08-21tdf#126787: extend/restore item set ranges to hold RES_PARATR_GRABBAGMike Kaganski
The original item set did not include that in its ranges list, so it ignored attempts to set its value. Change-Id: I5f928206f0614f0cfd54652e77d7dc6b9833fb26 Reviewed-on: https://gerrit.libreoffice.org/77617 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 202c9a7d826c95fc05db912a8d19c598a240f1cd) Reviewed-on: https://gerrit.libreoffice.org/77620 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-21Resolves: tdf#127021 not all formatting options shown for set variableCaolán McNamara
because we need to call SwNumFormatTreeView::clear to flag we want them added following that we then need to insert the extra entries before those now inserted stock ones Change-Id: Iccbd3a6b2c9fd48ad823b9dcc7cdfca87d29873c Reviewed-on: https://gerrit.libreoffice.org/77769 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-21Resolves tdf#126805 - Alignment of Tip-of-the-day labelHeiko Tietze
Change-Id: Ic4845dd87325ec952b8b987b69eedd8530b1cf02 Reviewed-on: https://gerrit.libreoffice.org/77703 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 96b5152e0009ff0ea26200d9b6e4bd3e0e8073ed) Reviewed-on: https://gerrit.libreoffice.org/77876 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-21Use get_value_or instead of value_orTomáš Chvátal
The old boost does not understand the value_or function Change-Id: I575d04eaab62294e1b402cd8c991c0daa1854271 Reviewed-on: https://gerrit.libreoffice.org/77729 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21Fix buidling with older boostTomáš Chvátal
Change-Id: I49691e8bf708aa9146d5c4f61532e7a215f4ac2d Reviewed-on: https://gerrit.libreoffice.org/77715 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-21Resolves: tdf#122110 convert condition decimal separator to target localeEike Rathke
Otherwise re-scanning the format code in the target locale failed. Change-Id: Ia4face1b5630c197f68b1f521e62b163550301e6 Reviewed-on: https://gerrit.libreoffice.org/77852 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 152c4fcbf1aa5b7454834581927056cfc9d1d7e5) Reviewed-on: https://gerrit.libreoffice.org/77858 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-08-21sw undo/redo: avoid usage of pointers as a style referencesVasily Melenchuk
Style can be created on previous undo steps and so after undo/redo pointer can became invalid. Style name as a reference looks like a good alternative to pointers. Change-Id: Ia099a717eaec1f1a23296b2c1273b8c1983a2b96 Reviewed-on: https://gerrit.libreoffice.org/77495 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 09228fabe88f3457105cf26d83c003719a793114) Reviewed-on: https://gerrit.libreoffice.org/77782
2019-08-20tdf#125869 LibreOffice UI freezes (shows not responding) while exporting a pdfNoel Grandin
Revert "use vcl::Timer in StatusIndicatorFactory" This reverts commit 848058625c7fad21e2469c95c2a2078678925a5a, which seems to have been a bad idea Change-Id: I68be1757717352f164ce27c300a4a0487680891c Reviewed-on: https://gerrit.libreoffice.org/77791 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-20tdf#126830 Icons not showing in menusNoel Grandin
regression from commit 9eae555542ce01cb289b9e736454abcf835b8394 Date: Sun Apr 28 09:54:42 2019 +0200 speed up gtk menu construction at startup Change-Id: I12327c0c62aa283c8b04a03933704082fd13463a Reviewed-on: https://gerrit.libreoffice.org/77702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 35b41150e84940e87b9d961b6b402e3e060d6b8b) Reviewed-on: https://gerrit.libreoffice.org/77783 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-20Resolves: tdf#126781 don't let width grow to fit condition textCaolán McNamara
make the label have no part of the width calc by giving it a small width request and force it to live with with the rest of the dialog ends up as Change-Id: Iae3012b6acfd63ba527727f022e999b144c6a941 Reviewed-on: https://gerrit.libreoffice.org/77772 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-20Resolves: tdf#127003 explicit grab focus needs explicit link callbackCaolán McNamara
Change-Id: I5131e5c49e7f7c2ef9bac8943420643ad8afef38 Reviewed-on: https://gerrit.libreoffice.org/77709 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-19tdf#126254 Help - About is black with Linux gen and gtk2Caolán McNamara
Change-Id: If18693e1cb8a92a7a152dd9decc892fc5f2b7ab5 Reviewed-on: https://gerrit.libreoffice.org/77592 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-19Improve check for absolute URIStephan Bergmann
Change-Id: I4dee44832107f72f8f3fb68554428dc1e646c346 Reviewed-on: https://gerrit.libreoffice.org/77712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19tdf#126989: always terminate shim after fallback completeMike Kaganski
It seems that DSM may not send MSG_CLOSEDSREQ (or we may already have unloaded DSM), so don't rely on it. Change-Id: I3ed2e0e70f4dc79c89b430b4bad6954bf9224c71 Reviewed-on: https://gerrit.libreoffice.org/77659 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 53e4d5fe73d98b109d79fc2c1f5032faea88afb9) Reviewed-on: https://gerrit.libreoffice.org/77664 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-19Resolves: tdf#127002 keystrokes in edit engine passed on to dialogCaolán McNamara
when they should stop at the edit engine Change-Id: I4079af7ed53ab4036e99c129d9e58fa530cf566b Reviewed-on: https://gerrit.libreoffice.org/77675 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-19tdf#126418: add some more checks for allocated columnsMike Kaganski
Change-Id: Ia91f0f11c9d7bcec5b9ecc2f8a28d9e4f6212dc5 Reviewed-on: https://gerrit.libreoffice.org/75671 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 159db459418a2c831bf00dca5a2c5087d65e9ab6) Reviewed-on: https://gerrit.libreoffice.org/77442 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-19tdf#126819 Can't retrieve the mouse position written in the statusbarNoel Grandin
regression from commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763 Date: Mon Jul 8 11:22:12 2019 +0200 tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText Make the custom StatusBarControls set better text on their parent StatusBar. Also remove some unnecessary work being done in the Paint methods, to reduce confusion. Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4 Reviewed-on: https://gerrit.libreoffice.org/77586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c53f3f8f58f55d0978fb968446975856d72a52f8) Reviewed-on: https://gerrit.libreoffice.org/77697
2019-08-19tdf#126663 speed up styles display by sorting twiceNoel Grandin
Change-Id: Ice5c2d0fd92196984efebf8c1183c1ed8399d1fb Reviewed-on: https://gerrit.libreoffice.org/77573 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9a03308fafee8f424eba399c1aae56af02beafb0) Reviewed-on: https://gerrit.libreoffice.org/77698
2019-08-19Resolves: tdf#126951 crash in custom slide showCaolán McNamara
on selecting entry 0 which doesn't exist Change-Id: I67656bed63f9055bc6c5dd5781e79f967996500d Reviewed-on: https://gerrit.libreoffice.org/77560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5d3e9ababc0b3e049a7556b210bb6349e3e3322c) Reviewed-on: https://gerrit.libreoffice.org/77695 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-08-17upload libabw 0.1.3David Tardon
Change-Id: Ibb45a473f49a9ba8f9cf53593dead375ac8a1951 Reviewed-on: https://gerrit.libreoffice.org/77643 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-17upload libvisio 0.1.7David Tardon
Change-Id: I4eb115c7c085b325370e9cd8f80e1b03f16f5033 Reviewed-on: https://gerrit.libreoffice.org/77642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-17tdf#126908 Add lang to TooltiplabelLaurent BP
Addition to commit c3ca559841c857bf7b39f665433d71c89d220d0f Change-Id: Ie51412b31239f6aaf3813dee5c226a21c7d9c79d Reviewed-on: https://gerrit.libreoffice.org/77562 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 003369b6d76225761373d46754890dd7f3c296c3) Reviewed-on: https://gerrit.libreoffice.org/77590 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-08-16tdf#118856 vcl: avoid flicker in the about dialogMiklos Vajna
There were two problems here: 1) The flickering widget in question is VclMultiLineEdit, but it wasn't like its own painting caused a flicker, rather the calling vcl::Window::PushPaintHelper() already erased the widget and later the widget painted itself. So the easy way with vcl::BufferDevice is not enough here. VclMultiLineEdit seems to be working with double buffering just fine, so enable that in the vcl::AboutDialog ctor. 2) Now that text did not flicker, its background was wrong. In case the NWF determines some gray background, the background was white for most text when there was no selection. When there was selection, then the after-selection area (in a single line) was fine, but nothing else. It seems TextEngine::ImpPaint() assumes that no need to set a default text fill color before drawing text, but the above shows that there is difference between the starting state and after clearing away a custom color with SetTextFillColor(). So fix this problem by always explicitly calling SetTextFillColor() before text paint: either setting the selection color or the default one. This brings improvement for the Windows GDI backend; Windows GL, Linux gen/gtk/gtk3 is unchanged in practice. (cherry picked from commit 7eb37a422f2e66bc177d72404c53659a248661ca) Change-Id: Ie7ff3a7f36bedf73424ea579a00588bd8858d6c4 Reviewed-on: https://gerrit.libreoffice.org/77369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-16bump product version to 6.3.2.0.0+Christian Lohmaier
Change-Id: Ia376060b7da2774040f21828c4e38ff3fca06db7
2019-08-16Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-3' - update translations for 6.3.1 rc1 and force-fix errors using pocheck Change-Id: I05d66c16174c18360182c88b86ecea4f9c5f8183
2019-08-16an absolute uri is invalid inputCaolán McNamara
Change-Id: I392be4282be8ed67e3451b28d2c9f22acd4c87fc Reviewed-on: https://gerrit.libreoffice.org/77564 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3c076e54f736980e208f5c27ecf179aa90aea103) Reviewed-on: https://gerrit.libreoffice.org/77571 Tested-by: Jenkins
2019-08-15warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77386 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>